Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

Hi Romain, On Fri, 15 Sep 2017 16:04:07 +0200 Romain Izard wrote: > It is not normal for the PMECC to fail when trying to fix ECC errors. > Report these cases as errors. I'm not sure we want to have ECC error messages at this level. ECC errors are rather unusual but

[PATCH 0/2] dwc3 on XU3 and XU4

Hi all, this short series addresses two issues. The first issue is devices not enumerating when connected to an Odroid XU4, to its 3.0 root hub. The interplay between refactoring certain parts of dwc3's code and handling the SUSPHY quirk results in the said problem. Please see:

[PATCH 1/2] ARM: dts: exynos: Add dwc3 SUSPHY quirk

Odroid XU4 board does not enumerate SuperSpeed devices. This patch makes exynos5 series chips use USB SUSPHY quirk, which solves the problem. Signed-off-by: Andrzej Pietrasiewicz --- arch/arm/boot/dts/exynos54xx.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

Hi, Andrzej Pietrasiewicz writes: > From: Vivek Gautam > > Adding phy calibration sequence for USB 3.0 DRD PHY present on > Exynos5420/5800 systems. > This calibration facilitates setting certain PHY parameters viz. > the Loss-of-Signal (LOS)

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

Hi, On Monday 18 September 2017 04:08 PM, Felipe Balbi wrote: > > Hi, > > Andrzej Pietrasiewicz writes: >> From: Vivek Gautam >> >> Adding phy calibration sequence for USB 3.0 DRD PHY present on >> Exynos5420/5800 systems. >> This calibration

Re: [regression] Force hard reset of Renesas uPD72020x USB controller

Hi Marc, 100% ack - Booting with a kernel that does not do a PCI reset yields the following topology: -[:00] - +-00.0 Intel Corporation 2nd Generation Core Processor Family DRAM Controller +-02.0 Intel Corporation 2nd Generation Core Processor Family Integrated

Re: [PATCH v4 0/3] initialize (multiple) PHYs in xhci-plat

On Sun, Sep 17, 2017 at 10:51:31PM +0200, Martin Blumenstingl wrote: > Hello Mathias, Hello Greg, > > On Sun, Sep 3, 2017 at 11:38 PM, Martin Blumenstingl > wrote: > > This series is the outcome of a discussion with Felipe Balbi, > > see [0] and [1]. > > The

[PATCH 1/4] usb: dwc3: gadget: check for lack of TRBs a bit earlier

This will let us call __dwc3_gadget_kick_transfer() unconditionally. No functional changes, cleanup only. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH 2/4] usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()

There is more possibility for sharing code if we just realise that now __dwc3_gadget_kic_transfer() knows to break out early if there are no TRBs left. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 19 --- 1 file changed, 4

[PATCH 3/4] usb: dwc3: gadget: cache frame number in struct dwc3_ep

This is in preparation to simplifying prototype of __dwc3_gadget_kick_transfer(). Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/gadget.c | 7 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 4/4] usb: dwc3: gadget: simplify __dwc3_gadget_kick_transfer() prototype

Now that all the information we need sits in struct dwc3_ep, we can start taking only a pointer to struct dwc3_ep as an argument. This allows us to clean the code up a bit. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 34

Re: [PATCH] USB: serial: option: add support for TP-Link LTE module

On Mon, Sep 11, 2017 at 05:57:34PM +0200, Henryk Heisig wrote: > This commit adds support for TP-Link LTE mPCIe module is used > in in TP-Link MR200v1, MR6400v1 and v2 routers. > > Signed-off-by: Henryk Heisig Now applied, thanks. Johan -- To unsubscribe from this list: send the

Re: Fibocom L831-EAU and cdc_mbim

Andreas Böhler writes: > I recently bought a Thinkpad T470 notebook and added the Fibocom > L831-EAU WWAN card. It's mbim-based, but unfortunately I can't get it > to work correctly. In fact I'm experiencing similar issues to Patrick > Chilton, who reported this behaviour a few

Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

On Tue, Sep 12, 2017 at 09:41:20AM -0700, Guenter Roeck wrote: > On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote: > > On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > > > Commented out code can be added as needed. Drop it. > > > Also drop TODO and an obsolete XXX

Re: [PATCH v3] USB: serial: cp210x.c -fix partnum regression for devices not having a part number

On Tue, Sep 12, 2017 at 09:50:59AM +0200, Sebastian Frei wrote: > When adding GPIO support for the cp2105, the mentioned commit by Martyn > Welch introduced a query for the part number of the chip. Unfortunately the > driver aborts loading when this query fails, so currently the driver can not >

Re: [PATCH 0/2] dwc3 on XU3 and XU4

Hi Andrzej, On 18 September 2017 at 15:32, Andrzej Pietrasiewicz wrote: > Hi all, > > this short series addresses two issues. > > The first issue is devices not enumerating when connected to an Odroid XU4, > to its 3.0 root hub. The interplay between refactoring certain

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

W dniu 18.09.2017 o 13:06, Kishon Vijay Abraham I pisze: Hi, On Monday 18 September 2017 04:08 PM, Felipe Balbi wrote: Hi, Andrzej Pietrasiewicz writes: From: Vivek Gautam Adding phy calibration sequence for USB 3.0 DRD PHY present on

[PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

From: Vivek Gautam Adding phy calibration sequence for USB 3.0 DRD PHY present on Exynos5420/5800 systems. This calibration facilitates setting certain PHY parameters viz. the Loss-of-Signal (LOS) Detector Threshold Level, as well as Tx-Vboost-Level for Super-Speed

Re: [regression] Force hard reset of Renesas uPD72020x USB controller

On 18/09/17 09:49, Albert Weichselbraun wrote: > Hi Marc, > > 100% ack > - Booting with a kernel that does not do a PCI reset yields the > following topology: > > > -[:00] - > +-00.0 Intel Corporation 2nd Generation Core Processor Family DRAM > Controller > +-02.0 Intel

Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

Hi, Peter Chen writes: > On Mon, Sep 04, 2017 at 11:14:02PM +0800, Li Jun wrote: >> } >> >> +#define MXS_USB_CHARGER_DATA_CONTACT_TIME_OUT 100 > > How about using "DATA_CONTACT_TIMEOUT_LOOP"? this really doesn't change anything. The only thing is that TIMEOUT is

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

Hi, W dniu 18.09.2017 o 13:27, Andrzej Pietrasiewicz pisze: W dniu 18.09.2017 o 13:06, Kishon Vijay Abraham I pisze: Hi, On Monday 18 September 2017 04:08 PM, Felipe Balbi wrote: Hi, Andrzej Pietrasiewicz writes: From: Vivek Gautam

Re: [PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

Hi Romain, On Fri, 15 Sep 2017 16:04:06 +0200 Romain Izard wrote: > During backup mode, the contents of all registers will be cleared as the > SoC will be completely powered down. For a product that boots on NAND > Flash memory, the bootloader will obviously use the

Re: how to instrument/debug module loading

On Mon, Sep 18, 2017 at 11:28:32AM -0400, Cliff Brake wrote: > On Thu, Sep 14, 2017 at 12:37 PM, Greg KH wrote: > > On Thu, Sep 14, 2017 at 08:20:09AM -0400, Cliff Brake wrote: > >> Hi, > >> > >> I'm trying to better understand the kernel module loading mechanism > >>

RE: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board

Thanks, -Jeffrey -Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Monday, September 18, 2017 4:41 AM To: Sheng-Hui J. Chu Cc: gre...@linuxfoundation.org; jo...@kernel.org; linux-usb@vger.kernel.org;

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

Hi, W dniu 18.09.2017 o 14:43, Felipe Balbi pisze: Hi, Andrzej Pietrasiewicz writes: +static int exynos5_usbdrd_phy_reset(struct phy *phy) +{ + struct phy_usb_instance *inst = phy_get_drvdata(phy); + struct exynos5_usbdrd_phy *phy_drd =

RE: Gadget mode advice sought

Hi and thanks > 3.4??? sorry, you're on your own. You need to ask for support from whoever forces you to stay on this kernel. Absolutely but sadly it is the all-important camera interface which is completely missing from mainline. That said I have GadgetFS working to the extent it is showing

Re: how to instrument/debug module loading

On Thu, Sep 14, 2017 at 12:37 PM, Greg KH wrote: > On Thu, Sep 14, 2017 at 08:20:09AM -0400, Cliff Brake wrote: >> Hi, >> >> I'm trying to better understand the kernel module loading mechanism >> (for example when you plug in a USB device and a kernel module >>

Re: Yet another Seagate quirk for unusual_uas.h

On Mon, 18 Sep 2017, Kris Lindgren wrote: > >> What happens if you plug the disk drive into a regular Linux desktop > >> computer? Remember, if an unusual_uas.h entry is added, it will affect > >> those machines too. > > > > I will need to get back to you on this. All of my other machines > >

Re: Yet another Seagate quirk for unusual_uas.h

On Sun, Sep 17, 2017 at 7:02 PM, Kris Lindgren wrote: > On Sun, Sep 17, 2017 at 3:41 PM, Alan Stern wrote: >> Please use Reply-To-All so that your message gets sent to the mailing >> and not just to me. >> >> Also, please don't top-post. >> >>

Re: how to instrument/debug module loading

On Mon, Sep 18, 2017 at 11:55 AM, Greg KH wrote: > On Mon, Sep 18, 2017 at 11:28:32AM -0400, Cliff Brake wrote: >> On Thu, Sep 14, 2017 at 12:37 PM, Greg KH wrote: >> > On Thu, Sep 14, 2017 at 08:20:09AM -0400, Cliff Brake wrote: >> >> Hi,

[PATCH 0/8] xhci fixes for usb-linus

Hi Greg Some small but important xhci fixes for usb-linus. A few vendor specific fixes, some USB 3.1 related issues related to resume and showing correct 10Gbps speed and other small fixes -Mathias Adam Wallis (1): usb: host: xhci-plat: allow sysdev to inherit from ACPI Jim Dickerson (1):

[PATCH 4/8] xhci: fix wrong endpoint ESIT value shown in tracing

Read the endpiont ESIT from endpiont context using correct macro. Add a macro for reading the high bits of ESIT for Large ESIT Payload Capable hosts (LEC=1) Cc: # 4.12 Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.h | 6 -- 1

[PATCH 3/8] usb: pci-quirks.c: Corrected timeout values used in handshake

From: Jim Dickerson Servers were emitting failed handoff messages but were not waiting the full 1 second as designated in section 4.22.1 of the eXtensible Host Controller Interface specifications. The handshake was using wrong units so calls were made with milliseconds not

[PATCH 1/8] usb: xhci: Free the right ring in xhci_add_endpoint()

From: Lu Baolu In the xhci_add_endpoint(), a new ring was allocated and saved at xhci_virt_ep->new_ring. Hence, when error happens, we need to free the allocated ring before returning error. Current code frees xhci_virt_ep->ring instead of the new_ring. This patch

[PATCH 2/8] xhci: fix finding correct bus_state structure for USB 3.1 hosts

xhci driver keeps a bus_state structure for each hcd (usb2 and usb3) The structure is picked based on hcd speed, but driver only compared for HCD_USB3 speed, returning the wrong bus_state for HCD_USB31 hosts. This caused null pointer dereference errors in bus_resume function. Cc:

Re: [regression] Force hard reset of Renesas uPD72020x USB controller

On Mon, 2017-09-18 at 12:46 +0100, Marc Zyngier wrote: > On 18/09/17 09:49, Albert Weichselbraun wrote: > > Hi Marc, > > > > 100% ack > > - Booting with a kernel that does not do a PCI reset yields the > > following topology: > > > > > > -[:00] - > > +-00.0 Intel Corporation 2nd

Re: [PATCH 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

Hi, Andrzej Pietrasiewicz writes: > +static int exynos5_usbdrd_phy_reset(struct phy *phy) > +{ > + struct phy_usb_instance *inst = phy_get_drvdata(phy); > + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); > + > + return

[PATCH 6/8] xhci: Fix sleeping with spin_lock_irq() held in ASmedia 1042A workaround

The flow control workaround for ASM1042A xHC hosts sleeps between register polling. The workaround gets called in several places, among them with spin_lock_irq() held when xHC host is resumed or hoplug removed. This was noticed as kernel panics at resume on a Dell XPS15 9550 with TB16 thunderbolt

[PATCH 7/8] xhci: set missing SuperSpeedPlus Link Protocol bit in roothub descriptor

A SuperSpeedPlus roothub needs to have the Link Protocol (LP) bit set in the bmSublinkSpeedAttr[] entry of a SuperSpeedPlus descriptor. If the xhci controller has an optional Protocol Speed ID (PSI) table then that will be used as a base to create the roothub SuperSpeedPlus descriptor. The PSI

[PATCH 5/8] usb: host: xhci-plat: allow sysdev to inherit from ACPI

From: Adam Wallis Commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA configuration") updated the method determining DMA for XHCI from sysdev. However, this patch broke the ability to enumerate the FWNODE from parent ACPI devices from the child plat XHCI device.

[PATCH 8/8] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

From: Kai-Heng Feng This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD Promontory hosts") makes all high speed USB ports on ASUS PRIME B350M-A cease to function after enabling runtime PM.

Re: [PATCH 7/8] xhci: set missing SuperSpeedPlus Link Protocol bit in roothub descriptor

Hello! Only some grammar nits, could prolly be fixed when applying... On 09/18/2017 05:39 PM, Mathias Nyman wrote: A SuperSpeedPlus roothub needs to have the Link Protocol (LP) bit set in the bmSublinkSpeedAttr[] entry of a SuperSpeedPlus descriptor. If the xhci controller has an optional

Re: usb/core: slab-out-of-bounds in usb_set_configuration

On Mon, Sep 18, 2017 at 07:22:24PM +0200, Andrey Konovalov wrote: > Hi! > > I've got the following crash while fuzzing the kernel with syzkaller. > > On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). > > It seems there's no proper size check of a > USB_DT_INTERFACE_ASSOCIATION

Re: Fibocom L831-EAU and cdc_mbim

On 18/09/17 12:27, Bjørn Mork wrote: > Andreas Böhler writes: > >> I recently bought a Thinkpad T470 notebook and added the Fibocom >> L831-EAU WWAN card. It's mbim-based, but unfortunately I can't get it >> to work correctly. In fact I'm experiencing similar issues to

Re: Yet another Seagate quirk for unusual_uas.h

On Mon, Sep 18, 2017 at 11:05 AM, Alan Stern wrote: > On Mon, 18 Sep 2017, Kris Lindgren wrote: > >> >> What happens if you plug the disk drive into a regular Linux desktop >> >> computer? Remember, if an unusual_uas.h entry is added, it will affect >> >> those

Re: [PATCH] USB: serial: cp210x: add support for ELV TFD500

On Mon, 18 Sep 2017 10:23:16 +0200, Johan Hovold wrote: > On Sun, Sep 03, 2017 at 12:04:40PM +0200, Andreas Engel wrote: >> Add the USB device id for the ELV TFD500 data logger. >> >> [...] > > This patch is whitespace damaged (tabs replaced with spaces) and does > not apply. > > Take a look at

usb/hid: slab-out-of-bounds read in usbhid_parse

Hi! I've got the following crash while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). It seems that there's no proper check on the hdesc->bNumDescriptors value in usbhid_parse(). it iterates over hdesc->desc and accesses hdesc->desc[n] fields,

Re: Yet another Seagate quirk for unusual_uas.h

On Mon, 18 Sep 2017, Kris Lindgren wrote: > So I upgrade to 17.04 which is using the 4.10 kernel. > > Without any modification the filesystem fails to mount. > > Unloading the usb_storage module and reloading it with > quirks=0bc2:3332:w allows the drive to be succesfully mounted and used >

[PATCH v2] USB: serial: cp210x: add support for ELV TFD500

Add the USB device id for the ELV TFD500 data logger. Signed-off-by: Andreas Engel --- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 2d945c9f975c..bd8574ca32aa 100644 ---

usb/core: slab-out-of-bounds in usb_set_configuration

Hi! I've got the following crash while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). It seems there's no proper size check of a USB_DT_INTERFACE_ASSOCIATION descriptor. It's only checked that the size is >= 2 in usb_parse_configuration(), so

Re: Fibocom L831-EAU and cdc_mbim

Andreas Böhler writes: > Unfortunately, it doesn't change anything. I applied the patch, > recompiled the kernel (it updated to 4.13.2 at the same time), rebooted > and upon connecting, I can see the 'cdc_mbim 1-6:1.0: nonzero urb status > received: -EPIPE' message again.

Re: Fibocom L831-EAU and cdc_mbim

On 18/09/17 22:18, Bjørn Mork wrote: > Andreas Böhler writes: >> >> I can also provide you with Wireshark USB traces, if that helps? > > It might help. We are obviously interacting badly with the firmware. > Seeing where and how it stops would be useful. Attached are two

Re: incomplete MJPG frames through dwc2 USB host

Hi Andrea, On 9/15/2017 1:34 PM, Andrea Di Chiara wrote: > Hi, > I'm using a RK3288 rockchip board whit kernel rockchip-linux release-4.4. > It has two USB host and one of them has a DW controller. If I connect a > UVC camera on it, I get into an incomplete MJPG frame error when enable > stream

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

On 16.09.2017 07:49, Kai-Heng Feng wrote: On Mon, Aug 28, 2017 at 9:56 PM, Kai-Heng Feng wrote: On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman wrote: On 28.08.2017 12:29, Greg KH wrote: Adding more people who were involved in the

Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: >>>gustavo panizzo writes: >>>--- >>>drivers/usb/dwc3/core.c | 33 + >>>1 file changed, 33 insertions(+) >>> >>>diff --git a/drivers/usb/dwc3/core.c

Re: [regression] Force hard reset of Renesas uPD72020x USB controller

Hi Albert, On 17/09/17 13:39, Albert Weichselbraun wrote: > Dear all, > > I ran into a regression with an ExpressCard/54 USB 3.0 expansion card > that uses the Renesas uPD72020x chipset on a Lenovo X220i Laptop (the > described behavior has been reproduced with kernel versions 4.12.8, > 4.12.13,

Re: [PATCH] USB: serial: cp210x: add support for ELV TFD500

On Sun, Sep 03, 2017 at 12:04:40PM +0200, Andreas Engel wrote: > Add the USB device id for the ELV TFD500 data logger. > > Signed-off-by: Andreas Engel > --- > drivers/usb/serial/cp210x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/cp210x.c

Re: [PATCH resend 2/2] usb: phy: mxs: add usb charger type detection

On Mon, Sep 04, 2017 at 11:14:02PM +0800, Li Jun wrote: > } > > +#define MXS_USB_CHARGER_DATA_CONTACT_TIME_OUT100 How about using "DATA_CONTACT_TIMEOUT_LOOP"? > +static int mxs_charger_data_contact_detect(struct mxs_phy *x) > +{ > + struct regmap *regmap = x->regmap_anatop; > +

Re: [PATCH v9] usb: serial: add vid:pid for Cypress WICED dev board

On Fri, Sep 08, 2017 at 09:08:58PM +, Sheng-Hui J. Chu wrote: > From: Jeffrey Chu > > Add CYPRESS_VID vid and CYPRESS_WICED_BT_USB and CYPRESS_WICED_WL_USB > device IDs to ftdi_sio driver > > Signed-off-by: Jeffrey Chu I have two v9 of