Re: [PATCH 0/2] USB 3.2 initial support

On Tue, 13 Mar 2018 17:27:21 +0200 Mathias Nyman wrote: > Example for clarification: > Gen 1x1 = 5Gbps, SuperSpeed, one lane, same as USB3.0, and USB 3.1 Gen1 > Gen 2x1 = 10Gbps, SuperSpeedPlus, one lane, same as USB 3.1 Gen2 > Gen 1x2 = 10Gbps, SuperSpeed,

Re: [PATCH v2] usb: musb: Fix external abort in musb_remove on omap2430

Hi, On Mon, Mar 12, 2018 at 11:30:39PM +0100, Merlijn Wajer wrote: > Hi Bin, > > On 09/03/18 15:11, Bin Liu wrote: > > Hi, > > > > On Thu, Mar 08, 2018 at 11:19:48PM +0100, Merlijn Wajer wrote: > >> This fixes an oops on unbind / module unload (on the musb omap2430 > >> platform). > >> > >>

Re: High CPU load produced by USB (DW2)

Hi Paul, On 3/13/2018 2:39 AM, Paul Zimmerman wrote: > On Mon, 12 Mar 2018 12:06:55 +, Minas Harutyunyan > wrote: > >> Hi Paul, >> >> Nice to hear you again! Hope you are doing well. > > Thanks, same to you. > >> On 3/8/2018 1:51 PM, Paul Zimmerman wrote:

RE: [PATCH 3/4] usb: host: xhci-plat: revert "usb: host: xhci-plat: enable clk in resume timing"

Hi Greg, > From: Greg KH, Sent: Saturday, March 10, 2018 2:08 AM > > On Fri, Mar 09, 2018 at 01:48:37AM +, Yoshihiro Shimoda wrote: > > Hi Greg, > > > > > From: Greg KH, Sent: Friday, March 9, 2018 2:06 AM > > > > > > On Thu, Mar 08, 2018 at 05:17:16PM +0200, Mathias Nyman wrote: > > > >

Re: High CPU load produced by USB (DW2)

On Tue, 13 Mar 2018 06:11:06 +, Minas Harutyunyan wrote: > Hi Paul, > > On 3/13/2018 2:39 AM, Paul Zimmerman wrote: > > On Mon, 12 Mar 2018 12:06:55 +, Minas Harutyunyan > > wrote: > > > >> Hi Paul, > >> > >> Nice to

[PATCH v6] usb: core: Add "quirks" parameter for usbcore

Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"

Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()

>> Use three values directly for a condition check without assigning them >> to intermediate variables. > > Hi, > > what is the benefit of this? I proposed a small source code reduction. Other software design directions might become more interesting for this use case. Regards, Markus -- To

Re: Leak of queue heads in DWC2 driver?

Hi Paul, On 3/13/2018 6:26 AM, Paul Zimmerman wrote: > Hi Minas, > > While ‌looking at the QH queuing in the DWC2 driver, I think I've found > some places where the QH struct may not be freed. Normally, the sequence is: > > dwc2_hcd_qh_unlink(); > < other stuff > >

Re: [PATCH v4 02/15] usb: core: urb: Check SSP isoc ep comp descriptor

Hi, Thinh Nguyen writes: > The maximum bytes per interval for USB SuperSpeed Plus can be set by > isoc endpoint companion descriptor when it is above 48K. If the > descriptor is provided, then use its value. > > USB 3.1 spec 9.6.8 > > Signed-off-by: Thinh Nguyen

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

Hi, +Andy Manu Gautam writes: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

On Tue, Mar 13, 2018 at 12:42:47PM +0100, Kashyap Chamarthy wrote: > [Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me > Cced, as I'm not subscribed to either of them.) [...] > I was suggested to return this SSD. But the Interweb[%] claims Samsung > T5 *does* have 'TRIM' (i.e.

Re: [PATCH v2] usb: core: introduce per-port over-current counters

Hi Greg, On 03/09/2018 06:19 PM, Greg KH wrote: >> diff --git a/Documentation/ABI/testing/sysfs-bus-usb >> b/Documentation/ABI/testing/sysfs-bus-usb >> index 0bd731cbb50c..27020293c85b 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-usb >> +++ b/Documentation/ABI/testing/sysfs-bus-usb >> @@

Re: [PATCH v4 13/15] usb: dwc3: Add workaround for isoc start transfer failure

Hi, Thinh Nguyen writes: > In DWC_usb31 version 1.70a-ea06 and prior, for highspeed and fullspeed > isochronous IN, BIT[15:14] of the 16-bit microframe number reported by > the XferNotReady event are invalid. The driver uses this number to > schedule the isochronous

[PATCH v1 1/2] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver

Existing documentation has lot of incorrect information as it was originally added for a driver that no longer exists. Signed-off-by: Manu Gautam --- .../devicetree/bindings/usb/qcom,dwc3.txt | 87 +++--- 1 file changed, 59 insertions(+), 28

[PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. Some of its uses are described below resulting in need to have a separate glue driver instead of using dwc3-of-simple: - It exposes register interface to override vbus-override and lane0-pwr-present signals going to hardware. These

[PATCH v3 04/12] usb: typec: add API to get typec basic port power and data config

This patch adds 3 APIs to get the typec port power and data type, and preferred power role. Signed-off-by: Li Jun --- change for v3: - Use fwnode to get the node of usb connector. - add one API to get data type drivers/usb/typec/class.c | 85

[PATCH v3 01/12] dt-bindings: connector: add properties for typec

Add bingdings supported by current typec driver, so user can pass all those properties via dt. Signed-off-by: Li Jun --- Change for v3: - port-type change to be power-type which only for power. - add data-type for data capability. - preferred-role change to try-power-role(bool

[PATCH v3 00/12] staging: typec: tcpci: move out of staging

This patch set attempts to move the tcpci driver out of staging by fix some tcpci driver issues and verified on NXP PTN5110, which is a standard tcpci typec port controller device with power delivery support, tested power source and sink with drp config. Changes for v3: - Use 2 properties to

[PATCH v3 03/12] usb: typec: add fwnode to tcpc

Add fwnode handle to get the fwnode so we can get typec configs it contains. Signed-off-by: Heikki Krogerus Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 14 +++--- drivers/usb/typec/tcpm.c | 1 +

[PATCH v3 05/12] usb: typec: add API to get sink and source config

This patch add 2 APIs to get sink and source power config from firmware description in case the port supports PD. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 47 +++ include/linux/usb/tcpm.h | 8 +--- 2 files changed, 52

[PATCH v3 07/12] staging: typec: tcpci: register port before request irq

With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 15 --- 1 file changed, 8

[PATCH v3 08/12] staging: typec: tcpci: enable vbus detection

TCPCI implementation may need SW to enable VBUS detection to generate power status events. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c index

[PATCH v3 09/12] typec: tcpm: add starting value for drp toggling

As DRP port autonomously toggles the Rp/Rd need a start value to begin with, so add one parameter for it in tcpm_start_drp_toggling. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 06/12] staging: typec: tcpci: support port config passed via dt

User can define the typec port properties in tcpci node to setup the port config. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/drivers/staging/typec/tcpci.c

[PATCH v3 02/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)

TCPCI stands for typec port controller interface, its implementation has full typec port control with power delivery support, it's a standard i2c slave with GPIO input as irq interface, detail see spec "Universal Serial Bus Type-C Port Controller Interface Specification Revision 1.0, Version 1.1"

Re: [2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()

Am Dienstag, den 13.03.2018, 08:24 +0100 schrieb SF Markus Elfring: > > > > > > > > Use three values directly for a condition check without assigning them > > > to intermediate variables. > > > > Hi, > > > > what is the benefit of this? > > I proposed a small source code reduction. > > Other

Re: [RFC PATCH] usb: typec: tcpm: match source fixed pdo with sink variable pdo

Hi, On 13-03-18 01:02, Li Jun wrote: This patch tries to fix the problem describled on revert patch commit[1], suppose any supported voltage ranges of sink should be describled by variable pdo, so instead of revert the patch of only comparing source and sink pdo to select one source pdo, this

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: > + usbcore.quirks= > + [USB] A list of quirks entries to supplement or > + override the built-in usb core quirk list. List > + entries are separated by commas. Each

Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

[Cross-posted to 'linux-scsi' and 'linux-usb' lists; please keep me Cced, as I'm not subscribed to either of them.) I unboxed a brand new Samsung T5 SSD[*]. Then formatted it with EXT4 filesystem. I wanted to clean the disk of any existing software, so I was reminded by a colleague to use

Re: Webcams not recognized on a Dell Latitude 5285 laptop

Am Montag, den 12.03.2018, 15:00 +0100 schrieb FRÉDÉRIC PARRENIN : > ipu3 Hi, sorry, I did not look closely enough. There is a failure report: [8.995211] ipu3-cio2 :00:14.3: enabling device ( -> 0002) [9.002030] ipu3-cio2 :00:14.3: device 0x9d32 (rev: 0x1) [9.002238]

[PATCH v3 12/12] staging: typec: tcpci: move tcpci driver out of staging

Move TCPCI(Typec port controller interface) driver out of staging. Signed-off-by: Li Jun --- drivers/staging/Kconfig| 2 -- drivers/staging/Makefile | 1 - drivers/staging/typec/Kconfig | 14 -- drivers/staging/typec/Makefile

[PATCH v3 10/12] staging: typec: tcpci: keep the not connecting cc line open

While set polarity, we should keep the not connecting cc line to be open when attached. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/staging/typec/tcpci.c

[PATCH v3 11/12] staging: typec: tcpci: Only touch target bit when enable vconn

We need regmap_update_bits to avoid touch any other bits when enable or disable vconn. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/typec/tcpci.c

Re: [PATCH v3 03/12] usb: typec: add fwnode to tcpc

Hi Jun Li, On Tue, Mar 13, 2018 at 05:34:29PM +0800, Li Jun wrote: > Add fwnode handle to get the fwnode so we can get typec configs > it contains. > > Signed-off-by: Heikki Krogerus You should not sign-off patches for other people. If you check section 13 from

Re: [RFC PATCH] usb: typec: tcpm: match source fixed pdo with sink variable pdo

HI, On 13-03-18 12:36, Hans de Goede wrote: Hi, On 13-03-18 01:02, Li Jun wrote: This patch tries to fix the problem describled on revert patch commit[1], suppose any supported voltage ranges of sink should be describled by variable pdo, so instead of revert the patch of only comparing source

Re: WARN_ON(irqs_disabled()) in dma_free_attrs?

On 11/03/18 18:01, Fredrik Noring wrote: Hi Christoph, The point is that you should always use a pool, period. dma_alloc*/dma_free* are fundamentally expensive operations on my architectures, so if you call them from a fast path you are doing something wrong. The author's comment in commit

Re: Webcams not recognized on a Dell Latitude 5285 laptop

Hi, I ran "udevadm monitor -kup" (this command does not terminate) and then "rmmod ipu3_cio2; modprobe ipu3_cio2", is that correct? Below is the output of udevadm after rmmod/modprobe. Thanks, Frédéric PS: maybe I should rather post to linux-media or linux-pci?

Re: WARN_ON(irqs_disabled()) in dma_free_attrs?

On Tue, Mar 13, 2018 at 12:11:49PM +, Robin Murphy wrote: > Taking a step back, though, provided the original rationale about > dma_declare_coherent_memory() is still valid, I wonder if we should simply > permit the USB code to call dma_{alloc,free}_from_dev_coherent() directly > here

Re: Webcams not recognized on a Dell Latitude 5285 laptop

Am Dienstag, den 13.03.2018, 13:11 +0100 schrieb FRÉDÉRIC PARRENIN : > Hi, > > I ran "udevadm monitor -kup" (this command does not terminate) and then > "rmmod ipu3_cio2; modprobe ipu3_cio2", is that correct? Yes, it is correct and the command is not supposed to terminate. It logs udev

Re: [PATCH 0/2] USB 3.2 initial support

Hi, Mathias Nyman writes: > The USB 3.2 specification adds support for Dual-lane, doubling the > maximum rate to 20Gbps by taking into use another set of rx and tx > wires and pins in the Type-C cable and connector. > > The changes to support this in USB core and

Re: [PATCH 2/2] USB: show USB3 Gen XxY version during device enumeration

On 13.03.2018 17:31, Felipe Balbi wrote: Hi, Mathias Nyman writes: USB 3.2 specification adds a Gen XxY notion for USB3 devices where X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count. USB

[PATCH 0/2] USB 3.2 initial support

The USB 3.2 specification adds support for Dual-lane, doubling the maximum rate to 20Gbps by taking into use another set of rx and tx wires and pins in the Type-C cable and connector. The changes to support this in USB core and xhci driver seems to be minor. USB 3.1 support already added the

[PATCH 2/2] USB: show USB3 Gen XxY version during device enumeration

USB 3.2 specification adds a Gen XxY notion for USB3 devices where X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count. USB 3.2 supports dual lane Gen Xx2 Gen 1x1 5Gbps single lane Gen 2x1 10Gbps single lane Gen 1x2 10Gbps

Re: Webcams not recognized on a Dell Latitude 5285 laptop

If you look at udev events, the /dev/video* devices are added and then they are removed. I don't know exactly why. If you don't know why this happens, I will email linux-media. Thanks, Frédéric > De: "Oliver Neukum" > À: "FRÉDÉRIC PARRENIN"

[PATCH 1/2] USB: Add support to store lane count used by USB 3.2

USB 3.2 specification adds Dual-lane support, doubling the maximum SuperSpeedPlus data rate from 10Gbps to 20Gbps. Dual-lane takes into use a second set of rx and tx wires/pins in the Type-C cable and connector. Add a "lanes" variable to struct usb_device to store the numer of lanes in use.

Re: [PATCH 1/2] USB: Add support to store lane count used by USB 3.2

On 13.03.2018 17:29, Felipe Balbi wrote: Hi, Mathias Nyman writes: USB 3.2 specification adds Dual-lane support, doubling the maximum SuperSpeedPlus data rate from 10Gbps to 20Gbps. Dual-lane takes into use a second set of rx and tx wires/pins in the Type-C

[PATCH] usb: musb: Fix external abort in musb_remove on omap2430

From: Merlijn Wajer This fixes an oops on unbind / module unload (on the musb omap2430 platform). musb_remove function now calls musb_platform_exit before disabling runtime pm. Signed-off-by: Merlijn Wajer Signed-off-by: Bin Liu ---

[PATCH] musb fixes for v4.16-rc6

Hi Greg, Here is one musb fix for v4.16-rc6, which fixes the wrong teardown order in musb_remove(). Please let me know if any change is needed. Regards, -Bin. --- Merlijn Wajer (1): usb: musb: Fix external abort in musb_remove on omap2430 drivers/usb/musb/musb_core.c | 2 +- 1 file changed,

[PATCH][usb-next] usb: dwc2: ix spelling mistake: "genereted" -> "generated"

From: Colin Ian King Trivial fix to spelling mistake in dev_warn warning message text. Signed-off-by: Colin Ian King --- drivers/usb/dwc2/hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c

4.14.13: Kernel panic, NULL pointer dereference in xhci_hcd

This is originally raised as Debian bug but the more I investigate it seems to trace back to 4.14.x xhci. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892647 (see also message #29) Call trace: xhci_giveback_urb_in_irq.isra.43+0x7f/0xe0 [xhci_hcd] xhci_td_cleanup+0xe7/0x170 [xhci_hcd]

Re: Webcams not recognized on a Dell Latitude 5285 laptop

On Sun, Mar 11, 2018 at 2:38 PM, FRÉDÉRIC PARRENIN wrote: > Dear Oliver and all, > > So I was expecting linux-4.16 to recognize my webcams, thanks to this new PCI > driver Oliver mentioned. > Therefore I installed 4.16-rc4. > Unfortunately, there is

Re: [PATCH 2/2] USB: show USB3 Gen XxY version during device enumeration

Hi, Mathias Nyman writes: > USB 3.2 specification adds a Gen XxY notion for USB3 devices where > X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed > and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count. > USB 3.2 supports dual lane Gen Xx2 > >

Re: [PATCH 1/2] USB: Add support to store lane count used by USB 3.2

Hi, Mathias Nyman writes: > USB 3.2 specification adds Dual-lane support, doubling the maximum > SuperSpeedPlus data rate from 10Gbps to 20Gbps. > > Dual-lane takes into use a second set of rx and tx wires/pins in the > Type-C cable and connector. > > Add a

Re: [PATCH v2 2/3] phy: phy-mtk-tphy: add configurable parameters for slew rate calibrate

On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > There are two parameters, ref_clk and coefficient, for U2 slew rate > calibrate which may vary on different SoCs, here allow them to be > configurable > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger

Re: Webcams not recognized on a Dell Latitude 5285 laptop

Am Dienstag, den 13.03.2018, 16:14 +0100 schrieb FRÉDÉRIC PARRENIN : > If you look at udev events, the /dev/video* devices are added and then they > are removed. > I don't know exactly why. > If you don't know why this happens, I will email linux-media. Sorry, I assumed you unloaded the

Re: [PATCH v2 3/3] dt-bindings: phy-mtk-tphy: add properties for U2 slew rate calibrate

On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > Add two properties of ref_clk and coefficient used by U2 slew rate > calibrate which may vary on different SoCs > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- >

Re: [PATCH 0/2] USB 3.2 initial support

On 13.03.2018 17:27, Felipe Balbi wrote: Hi, Mathias Nyman writes: The USB 3.2 specification adds support for Dual-lane, doubling the maximum rate to 20Gbps by taking into use another set of rx and tx wires and pins in the Type-C cable and connector. The

Re: [PATCH v4 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Tue, 2018-03-13 at 09:35 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2018-03-09 at 11:20 +0200, Felipe Balbi wrote: > > > > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c > > > b/drivers/usb/gadget/udc/aspeed-vhub/core.c > > > new file mode 100644 > > > index

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

Hi Manu, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180313] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Manu

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

Hi, On 3/13/2018 4:38 PM, Felipe Balbi wrote: > Hi, > > +Andy > > Manu Gautam writes: >> DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. >> Some of its uses are described below resulting in need to >> have a separate glue driver instead of using dwc3-of-simple:

RE: [PATCH v3 03/12] usb: typec: add fwnode to tcpc

> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月13日 19:18 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; a.ha...@samsung.com; li...@roeck-us.net; > yue...@google.com;

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

Matthew Wilcox wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or + override the built-in usb core quirk list. List +

Re: [PATCH v4 13/15] usb: dwc3: Add workaround for isoc start transfer failure

Hi Felipe, On 3/13/2018 1:45 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> In DWC_usb31 version 1.70a-ea06 and prior, for highspeed and fullspeed >> isochronous IN, BIT[15:14] of the 16-bit microframe number reported by >> the XferNotReady event are

Re: [PATCH v4 02/15] usb: core: urb: Check SSP isoc ep comp descriptor

Hi, On 3/13/2018 1:31 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> The maximum bytes per interval for USB SuperSpeed Plus can be set by >> isoc endpoint companion descriptor when it is above 48K. If the >> descriptor is provided, then use its value. >>