Re: [PATCH] Usb: core: Correct self assignment in phy.c
Hello,
thank you for finding this!
On Sat, Apr 7, 2018 at 1:04 AM, Rishabh Bhatnagar
wrote:
> In file drivers/usb/core/phy.c line 114, ret variable is assigned to
> itself. The following error was observed:
>
> kernel/drivers/usb/core/phy.c:114:8: warning: explicitly assigning value of
> variable of type 'int' to itself [-Wself-assign] error, forbidden
> warning: phy.c:114
> This error was found when compiling with Clang. Change it to ret = err.
I found the same bug myself two weeks ago and already sent a patch: [0]
it has not made it to Greg's tree yet. Greg asked me to re-send that
patch along with some others after -rc1 is out: [1]
> Fixes: commit 07dbff0ddbd8 ("usb: core: add a wrapper for the USB PHYs on the
> HCD")
> Signed-off-by: Rishabh Bhatnagar
would you like me to add your Acked-by or Signed-off-by to my patch?
> ---
> drivers/usb/core/phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
> index 09b7c43..f19aaa3 100644
> --- a/drivers/usb/core/phy.c
> +++ b/drivers/usb/core/phy.c
> @@ -111,7 +111,7 @@ int usb_phy_roothub_exit(struct usb_phy_roothub
> *phy_roothub)
> list_for_each_entry(roothub_entry, head, list) {
> err = phy_exit(roothub_entry->phy);
> if (err)
> - ret = ret;
> + ret = err;
> }
>
> return ret;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Regards
Martin
[0] http://lists.infradead.org/pipermail/linux-amlogic/2018-March/006819.html
[1] http://lists.infradead.org/pipermail/linux-amlogic/2018-April/006977.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: musb: asix ethernet incoming UDP loss
2018-03-22 20:11 GMT+03:00 Bin Liu : > On Thu, Mar 22, 2018 at 07:31:59PM +0300, Matwey V. Kornilov wrote: >> Hi, >> >> I am running 4.16-rc6 and see the following issue with ASIX >> usb-ethernet dongle running on BeagleBoneBlack (TI AM335x). > > Does the issue also happen on older kernels? > >> My device is 100Mbps USB 2.0 dongle (ASIX AX88772 USB 2.0 Ethernet >> idVendor=0b95, idProduct=7720). I've also tried 1Gbps USB 3.0 ASIX >> dongle, that shows the same behavior. >> >> When I start iperf server on the host, and start remote client in UDP >> (iperf3 -c ip -b 100M -u). The following I see at BeagleBoneBlack >> side. > > If this is not a regression in v4.16, please try with lower '-b', musb > rx is kinda slow right now. > >> >> --- >> Server listening on 5201 >> --- >> Accepted connection from 192.168.185.4, port 38624 >> [ 5] local 192.168.185.218 port 5201 connected to 192.168.185.4 port 38088 >> [ ID] Interval Transfer Bitrate Jitter >> Lost/Total Datagrams >> [ 5] 0.00-12.09 sec 1.33 MBytes 921 Kbits/sec 1742978.415 ms >> 317/487 (65%) >> [ 5] 12.10-13.00 sec 24.0 KBytes 218 Kbits/sec 1436810.214 ms 0/3 >> (0%) >> [ 5] 13.00-13.37 sec 0.00 Bytes 0.00 bits/sec 1436810.214 ms 0/0 (0%) >> - - - - - - - - - - - - - - - - - - - - - - - - - >> [ ID] Interval Transfer Bitrate Jitter >> Lost/Total Datagrams >> [ 5] 0.00-13.37 sec 1.35 MBytes 848 Kbits/sec 1436810.214 ms >> 317/490 (65%) receiver >> --- >> Server listening on 5201 >> --- > > I will try to reproduce it when I get some time. I've just found that the issue depends on cpufreq governor. For me it appears when ondemand is used. > >> Kernel config is attached here. >> >> -- >> With best regards, >> Matwey V. Kornilov > > Regards, > -Bin. -- With best regards, Matwey V. Kornilov -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: make xmldocs failed with error after 4.17 merge period
On Fri, 2018-04-06 at 13:38 +0200, Markus Heiser wrote: > > Sorry, not yet. Johannes started a discussion about this. Its a long > time ago and I do not have any new ideas yet :/ see: > > https://www.mail-archive.com/linux-doc@vger.kernel.org/msg07035.html I still think the tools themselves don't matter all that much, as long as there aren't totally onerous requirements. I'd argue pretty much everything available on a modern distro would be OK provided we have a reasonable fallback (e.g. to ASCII as I had even written), along with some sort of documentation of dependencies, or perhaps better, some command line option to gather the info dynamically. But then again, I've already said pretty much this a year and a half ago and most people seemed more interested in some kind of purity argument than having better documentation :-) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] USB: serial: simple: add libtransistor console
Add simple driver for libtransistor USB console.
This device is implemented in software:
https://github.com/reswitched/libtransistor/blob/development/lib/usb_serial.c
Signed-off-by: Collin May
Tested-by: Collin May
---
drivers/usb/serial/Kconfig | 1 +
drivers/usb/serial/usb-serial-simple.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
index c66b93664d54..dac738364950 100644
--- a/drivers/usb/serial/Kconfig
+++ b/drivers/usb/serial/Kconfig
@@ -69,6 +69,7 @@ config USB_SERIAL_SIMPLE
- ViVOtech ViVOpay USB device.
- Infineon Modem Flashloader USB interface
- ZIO Motherboard USB serial interface
+ - Libtransistor USB console
To compile this driver as a module, choose M here: the module
will be called usb-serial-simple.
diff --git a/drivers/usb/serial/usb-serial-simple.c
b/drivers/usb/serial/usb-serial-simple.c
index 4ef79e29cb26..e77017285fcd 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -103,6 +103,11 @@ DEVICE(suunto, SUUNTO_IDS);
{ USB_DEVICE(0x908, 0x0004) }
DEVICE(siemens_mpi, SIEMENS_IDS);
+/* Libtransistor USB console */
+#define LIBTRANSISTOR_IDS()\
+ { USB_DEVICE(0x1209, 0x8b00) }
+DEVICE(libtransistor, LIBTRANSISTOR_IDS);
+
/* All of the above structures mushed into two lists */
static struct usb_serial_driver * const serial_drivers[] = {
&carelink_device,
@@ -117,6 +122,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
&hp4x_device,
&suunto_device,
&siemens_mpi_device,
+ &libtransistor_device,
NULL
};
@@ -133,6 +139,7 @@ static const struct usb_device_id id_table[] = {
HP4X_IDS(),
SUUNTO_IDS(),
SIEMENS_IDS(),
+ LIBTRANSISTOR_IDS(),
{ },
};
MODULE_DEVICE_TABLE(usb, id_table);
--
2.16.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
