From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/usb/host/ehci-tegra.c | 8 ++--
1
Hi,
On Wed, Oct 31, 2012 at 11:33:20AM -0400, Behan Webster wrote:
On 12-10-31 09:28 AM, Felipe Balbi wrote:
hi,
On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote:
The use of variable length arrays in structs (VLAIS) in the Linux Kernel
code
precludes the use of compilers
Hi,
Brief update:
It is working!
The issue was in the .dts file.
Is there any DTS documentation?
Thanks
Avner
-Original Message-
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
ow...@vger.kernel.org] On Behalf Of Avner Flesch
Sent: ב 29 אוקטובר 2012 16:41
To: Peter Stuge
On 31.10.2012 15:54, Alan Stern wrote:
On Fri, 26 Oct 2012, Sarah Sharp wrote:
On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote:
The USB core isn't dropping the endpoints before it calls
xhci_check_bandwidth. I remember running into this bug a while back,
and I even
On Thu, Nov 01, 2012 at 09:19:48AM +0100, Munegowda, Keshava wrote:
From: Tony Lindgren [t...@atomide.com]
Sent: Wednesday, October 31, 2012 11:59 PM
To: Munegowda, Keshava
Cc: linux-o...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org;
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
head: 1789e52acc90c87484a109d6349eefe63cabb257
commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car USB
phy driver
config: make ARCH=cris allyesconfig
All error/warnings:
Hi,
On Wed, Oct 31, 2012 at 04:12:43PM +0100, Sebastian Andrzej Siewior wrote:
This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO
value which should do the same thing.
This patch probably also fixes ux500 because I did not find the musbid
variable to remove. And we close a
On Mon, 10 Sep 2012, Dmitry Torokhov wrote:
The other piece to this puzzle is that usbhid should blacklist these devices
to avoid binding if it happens to be loaded before usbtouchscreen. To do
this, usbhid needs to be able to blacklist devices based on interface
protocol (right now it
Hi,
On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
head: 1789e52acc90c87484a109d6349eefe63cabb257
commit: 1789e52acc90c87484a109d6349eefe63cabb257 [3/3] usb: phy: add R-Car
USB phy driver
config:
On Wed, Oct 24, 2012 at 02:53:01PM -0400, Lennart Sorensen wrote:
On Wed, Oct 24, 2012 at 07:24:15PM +0200, Johan Hovold wrote:
This is an updated series of fixes rebased on the interface-data memory leak
discovered by Lennart.
One of the reasons that I missed it was that the interface
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote:
Hi,
On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
head: 1789e52acc90c87484a109d6349eefe63cabb257
commit:
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote:
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote:
Hi,
On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
head:
On Wed, Oct 31, 2012 at 07:33:44PM +, Paul Zimmerman wrote:
Regarding that, would you guys accept a patch that adds the buflen
module parameter to the mass-storage gadget? Without increasing the
buffer length above 16K, it's impossible to approach the max throughput
allowed by SuperSpeed
Hi,
On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote:
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote:
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote:
Hi,
On Thu, Nov 01, 2012 at 06:29:30PM +0800, kbuild test robot wrote:
tree:
Felipe Balbi ba...@ti.com writes:
btw, only alpha and x86 seem to be providing all of those, but if you
look into our documentation, it's said that drivers are supposed to use
write/read{b,w,l,q} for all memory-mapped io. I'd expect all platforms
to provide those even if just to allow
On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote:
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote:
On Thu, Nov 01, 2012 at 12:33:39PM +0200, Felipe Balbi wrote:
Hi,
On Thu, Nov 01, 2012 at
On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote:
On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote:
On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote:
On Thu, Nov 01, 2012 at 12:33:39PM
Dear Peter Chen,
[...]
+static void ci_wait_vbus_stable(struct ci13xxx *ci, bool low)
+{
+ unsigned long timeout;
+ u32 otgsc = hw_read(ci, OP_OTGSC, ~0);
+
+ timeout = jiffies + CI_WAIT_VBUS_STABLE_TIMEOUT;
+
+ if (low) {
+ while (otgsc OTGSC_BSV) {
+
Dear Peter Chen,
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci.h |2 +
On Wed, 31 Oct 2012, Michal Nazarewicz wrote:
From: Michal Nazarewicz min...@mina86.com
The File-backed Storage Gadget (g_file_storage) gadget has been replaced
with Mass Storage Gadget (g_mass_storage) which uses the composite
framework. This commit removes g_file_storage (and most
On Wed, 31 Oct 2012, Paul Zimmerman wrote:
From: Michal Nazarewicz [mailto:m...@google.com] On Behalf Of Michal
Nazarewicz
Sent: Wednesday, October 31, 2012 1:10 PM
On Wed, Oct 31 2012, Paul Zimmerman wrote:
Regarding that, would you guys accept a patch that adds the buflen
On Thu, 1 Nov 2012, victor wrote:
Alan,
The partial patch is here. In fact I am using file_storage.c in u-boot, the
context and buf pointer are mismatch when the value is returned back from
irq routine. The file-storage.c is not in u-boot release, so I post my
question on linux usb. I am
On Thu, 1 Nov 2012, Wei Yongjun wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
From: Felipe Balbi ba...@ti.com
Date: Thu, 1 Nov 2012 09:21:16 +0200
then we can merge to net tree and handle the conflicts when merging to
Linus, that'd be fine by me as long as people know how to solve the
conflict properly ;-)
Like Herbert with the crypto tree, I'm simply not merging this
From: Bjørn Mork bj...@mork.no
Date: Thu, 01 Nov 2012 14:38:29 +0100
Felipe Balbi ba...@ti.com writes:
btw, only alpha and x86 seem to be providing all of those, but if you
look into our documentation, it's said that drivers are supposed to use
write/read{b,w,l,q} for all memory-mapped io.
From: Max Filippov jcmvb...@gmail.com
Date: Thu, 1 Nov 2012 16:47:14 +0300
Strange, AFAICS architectures that use asm-generic/io.h (blackfin, openrisc,
score, unicore32 and xtensa) also provide those functions.
They define HAVE_IOMEM, s390 does not, therefore you must protect
the driver
Greg:
This series of patches begins the process of splitting ehci-hcd up into
a core library module and multiple independent platform-specific driver
modules. The purpose of this change is to allow people and
distributions to build systems that support more than one platform
driver for EHCI
This patch (as1625) splits the PCI portion of ehci-hcd out into its
own separate driver module, called ehci-pci. Consistently with the
current practice, the decision whether to build this module is not
user-configurable. If EHCI and PCI are enabled then the module will
be built, always.
This patch (as1624) prepares ehci-hcd for being split up into a core
library and separate platform driver modules. A generic
ehci_hc_driver structure is created, containing all the standard
values, and a new mechanism is added whereby a driver module can
specify a set of overrides to those
This patch (as1626) splits the ehci-platform code from ehci-hcd out
into its own separate driver module.
Signed-off-by: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/host/Kconfig |2 -
drivers/usb/host/Makefile|1
drivers/usb/host/ehci-hcd.c |6 ---
Convert USB descriptor's fields to CPU byte order before using locally
in USB NCM gadget driver.
Tested on MIPS32 big-endian device.
Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com
---
drivers/usb/gadget/f_ncm.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff
Hi Felipe,
resent with requested formatting changes.
cheers,
-- dmytro
On Wed, Oct 31, 2012 at 2:35 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote:
Convert USB descriptor's fields to CPU byte order before using locally in
USB NCM
On Wed, 31 Oct 2012, Randy Dunlap wrote:
On 10/30/2012 11:26 PM, Stephen Rothwell wrote:
Hi all,
Changes since 20121030:
on x86_64:
drivers/built-in.o: In function `ehci_reset':
host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep'
host.c:(.text+0x542b75):
On 31 October 2012 05:25, Behan Webster beh...@converseincode.com wrote:
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
precludes the use of compilers which don't implement VLAIS (for instance the
Clang compiler). This patch instead calculates offsets into the
On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote:
+ ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
+ USB_REQ_SET_CONFIGURATION, 0, configuration, 0,
+ NULL, 0, USB_CTRL_SET_TIMEOUT);
+ if (ret 0 cp) {
+
On Mon, Oct 29, 2012 at 04:28:38PM +0800, Lan Tianyu wrote:
ACPI provide _PLD and _UPC aml methods to describe usb port
visibility and connectability. This patch is to use those information
to set usb port's DeviceRemovable.
You should probably mention you're changing the EHCI roothub
On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote:
This patch is to set xhci root hub's DeviceRemovable according to usb port's
connect type which currently comes from ACPI information. If ACPI information
was different with PORTSC, there would be a warning.
You should also add the
On Thu, 1 Nov 2012, Sarah Sharp wrote:
On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote:
+ ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
+ USB_REQ_SET_CONFIGURATION, 0, configuration, 0,
+ NULL, 0, USB_CTRL_SET_TIMEOUT);
+
On Wed, Oct 31, 2012 at 02:27:04PM +0530, $rik@nth wrote:
Hi Sarah,
I need some help regarding the usb devices(Android based mobiles).,
I am having some trouble in automating the task. I am testing some android
based mobiles in linux machine. The automation script uses the device id
On Thu, Nov 01 2012, Alan Stern wrote:
BTW, you might want to check about updating a couple of the web pages
at www.linux-usb.org. The gadget/index.html and
gadget/file_storage.html pages still refer to g_file_storage.
Will do. Probably not this or next week (LCE) though.
--
Best regards,
On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote:
On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote:
This patch is to set xhci root hub's DeviceRemovable according to usb port's
connect type which currently comes from ACPI information. If ACPI
information
was
On Wed, 31 Oct 2012, Michal Nazarewicz wrote:
--- a/arch/arm/configs/qil-a9260_defconfig
+++ b/arch/arm/configs/qil-a9260_defconfig
@@ -108,7 +108,6 @@ CONFIG_ROOT_NFS=y
CONFIG_NLS_CODEPAGE_437=y
CONFIG_NLS_CODEPAGE_850=y
CONFIG_NLS_ISO8859_1=y
-CONFIG_DEBUG_KERNEL=y
On Sat, Oct 27, 2012 at 07:37:50PM -0700, Matthew Hall wrote:
Sarah,
I finally had occasion to experiment with this further, as more USB 3.0
devices have become available at decent prices.
I discovered that, while the card reader would fail with strange errors, a 32
GB USB 3.0 flash
On Thu, 1 Nov 2012, Greg KH wrote:
On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote:
On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote:
This patch is to set xhci root hub's DeviceRemovable according to usb
port's
connect type which currently comes from ACPI
On Wed, Oct 31, 2012 at 12:31:43PM +0800, Shimmer Huang wrote:
Sarah,
This patch works for me. Would you please help submit and merge this patch ?
Yep, I'll get it merged shortly. It will be marked for stable kernels,
so it should make it into the Linux distribution kernels as well.
Sarah
On Mon, Oct 29, 2012 at 09:35:15PM +0300, Sergei Shtylyov wrote:
Hello.
On 10/29/2012 08:00 PM, Julius Werner wrote:
next = xhci_segment_alloc(xhci, cycle_state, flags);
if (!next) {
- xhci_free_segments_for_ring(xhci, *first);
+
In the former code, we have a race condition between the first interrupt
and the regs field initilization in the usb_hcd structure.
If the OHCI irq fires before hcd-regs is set, we are getting a null
pointer dereference in ohci_irq.
When calling usb_add_hcd(), it first executes the reset()
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: 99f91934a907df31ba878dfdd090002049dc476a
commit: 3e0232039967d7a1a06c013d097458b4d5892af1 [87/89] USB: EHCI: prepare to
make ehci-hcd a library module
config: make ARCH=arm imx_v6_v7_defconfig
All
From: Alan Stern [mailto:st...@rowland.harvard.edu]
Sent: Thursday, November 01, 2012 7:48 AM
On Wed, 31 Oct 2012, Paul Zimmerman wrote:
From: Michal Nazarewicz [mailto:m...@google.com] On Behalf Of Michal
Nazarewicz
Sent: Wednesday, October 31, 2012 1:10 PM
On Wed, Oct 31
On Fri, 2 Nov 2012, Fengguang Wu wrote:
Hi Alan,
FYI, kernel build failed on
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: 99f91934a907df31ba878dfdd090002049dc476a
commit: 99f91934a907df31ba878dfdd090002049dc476a [89/89] USB: EHCI: make
On Thu, 1 Nov 2012, Vincent Palatin wrote:
In the former code, we have a race condition between the first interrupt
and the regs field initilization in the usb_hcd structure.
If the OHCI irq fires before hcd-regs is set, we are getting a null
pointer dereference in ohci_irq.
When calling
On Thu, Nov 01, 2012 at 11:12:52AM -0400, Alan Stern wrote:
Greg:
This series of patches begins the process of splitting ehci-hcd up into
a core library module and multiple independent platform-specific driver
modules. The purpose of this change is to allow people and
distributions to
On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote:
Hi. Well, here is an interesting piece of information -- I started from
a poweroff state and the disk drive is seen even when its plugged in!
However, I almost never do it that way and certainly it would not work
Alexander:
The patch below (which is meant to apply to the linux-next tree) fixes
a build error I introduced recently. However I don't know if it will
work properly as the ChipIdea host driver. Can you verify that it is
okay?
Alan Stern
This patch (as1627) splits the ehci-hcd core code,
On Thu, Nov 01, 2012 at 01:00:43PM -0400, Alan Stern wrote:
On Thu, 1 Nov 2012, Greg KH wrote:
On Thu, Nov 01, 2012 at 08:59:11AM -0700, Sarah Sharp wrote:
On Mon, Oct 29, 2012 at 04:28:39PM +0800, Lan Tianyu wrote:
This patch is to set xhci root hub's DeviceRemovable according to usb
On Thu, Nov 01, 2012 at 10:10:07PM +0530, $rik@nth wrote:
Android is not giving any abstract layer for this kind of scenarios.
I heard that using udev rule we can solve the problem. But that is also not
the right way to do it, so thought of asking for experts thoughts.
What problem are you
On Thu, 1 Nov 2012, Greg KH wrote:
On Thu, Nov 01, 2012 at 11:12:52AM -0400, Alan Stern wrote:
Greg:
This series of patches begins the process of splitting ehci-hcd up into
a core library module and multiple independent platform-specific driver
modules. The purpose of this change
On Thu, 1 Nov 2012, Sarah Sharp wrote:
Alan, can you take a look at the patch and see what I can do in the case
where five warm port resets fail? I think it's a pretty unlikely
scenario, but if you have a good solution, I'm all ears.
Hmmm. Overall I'm not really sure about the logic in that
Alan Stern st...@rowland.harvard.edu 11/01/12 4:28 PM
On Wed, 31 Oct 2012, Randy Dunlap wrote:
on x86_64:
drivers/built-in.o: In function `ehci_reset':
host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep'
host.c:(.text+0x542b75): undefined reference to `dbgp_external_startup'
xhci_alloc_segments_for_ring() builds a list of xhci_segments and links
the tail to head at the end (forming a ring). When it bails out for OOM
reasons half-way through, it tries to destroy its half-built list with
xhci_free_segments_for_ring(), even though it is not a ring yet. This
causes a
On Thu, Nov 1, 2012 at 9:47 PM, Julius Werner jwer...@chromium.org wrote:
xhci_alloc_segments_for_ring() builds a list of xhci_segments and links
the tail to head at the end (forming a ring). When it bails out for OOM
reasons half-way through, it tries to destroy its half-built list with
On Thu, Nov 01, 2012 at 10:13:00PM +0200, Andy Shevchenko wrote:
On Thu, Nov 1, 2012 at 9:47 PM, Julius Werner jwer...@chromium.org wrote:
xhci_alloc_segments_for_ring() builds a list of xhci_segments and links
the tail to head at the end (forming a ring). When it bails out for OOM
reasons
Is it just
for (prev = *first; prev; prev = prev-next)
xhci_segment_free(xhci, prev);
?
Yeah, that seems cleaner.
Sarah Sharp
I can submit it that way if you want, but I would advise against it. This way
you access the prev pointer after it has been freed already… that's probably
On Thu, 1 Nov 2012, Jan Beulich wrote:
Alan Stern st...@rowland.harvard.edu 11/01/12 4:28 PM
On Wed, 31 Oct 2012, Randy Dunlap wrote:
on x86_64:
drivers/built-in.o: In function `ehci_reset':
host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep'
host.c:(.text+0x542b75):
Hi. Which kernel should I patch, the 3.6.2 or Linus's git tree which I
will update before I do it?
Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote:
Hi. Well, here is an interesting piece of information -- I started from
And thanks again for all your work on this -- its been a real pain.
Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
On Sat, Oct 27, 2012 at 04:48:55AM -0400, cov...@ccs.covici.com wrote:
Hi. Well, here is an interesting piece of information -- I started from
a poweroff state and the disk
Alan Stern st...@rowland.harvard.edu 11/01/12 9:39 PM
On Thu, 1 Nov 2012, Jan Beulich wrote:
Alan Stern st...@rowland.harvard.edu 11/01/12 4:28 PM
Evidently we need to change your new test in
drivers/usb/early/ehci-dbgp.c to:
#if IS_ENABLED(CONFIG_USB_HCD_EHCI) ||
On Thu, Nov 01, 2012 at 03:46:37PM -0400, Alan Stern wrote:
On Thu, 1 Nov 2012, Sarah Sharp wrote:
Alan, can you take a look at the patch and see what I can do in the case
where five warm port resets fail? I think it's a pretty unlikely
scenario, but if you have a good solution, I'm all
On Thu, Nov 01, 2012 at 04:47:48PM -0400, cov...@ccs.covici.com wrote:
Hi. Which kernel should I patch, the 3.6.2 or Linus's git tree which I
will update before I do it?
You should test Linus' git tree.
Sarah Sharp
Sarah Sharp sarah.a.sh...@linux.intel.com wrote:
On Sat, Oct 27, 2012
On 01.11.2012 12:03, Alan Stern wrote:
On Thu, 1 Nov 2012, Sarah Sharp wrote:
On Wed, Oct 31, 2012 at 03:54:49PM -0400, Alan Stern wrote:
+ ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
+ USB_REQ_SET_CONFIGURATION, 0, configuration, 0,
+
Hi Alan,
It's hard to know which headers are needed for foreign architectures.
Still, I think this ought to fix the problems you found. Can you test
this patch?
Yes, it works. Thanks for the quick fix!
Thanks,
Fengguang
Index: usb-3.7/drivers/usb/host/ehci-platform.c
On 2012年11月01日 23:54, Sarah Sharp wrote:
On Mon, Oct 29, 2012 at 04:28:38PM +0800, Lan Tianyu wrote:
ACPI provide _PLD and _UPC aml methods to describe usb port
visibility and connectability. This patch is to use those information
to set usb port's DeviceRemovable.
You should probably
On Wed, Oct 31, 2012 at 8:14 PM, Lukasz Majewski l.majew...@samsung.com wrote:
Hi Felipe,
Hi,
On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote:
@@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct
platform_device *pdev) int ret;
int i;
- plat =
Adding the phy driver support to hsotg driver. Keeping the platform data
for continuing the smooth operation for boards which still uses it.
Signed-off-by: Praveen Paneri p.pan...@samsung.com
---
drivers/usb/gadget/s3c-hsotg.c | 37 +++--
1 files changed, 27
74 matches
Mail list logo
