Re: USB gadget lockup on MX53 udc

2013-01-22 Thread Michael McTernan
On 01/21/2013 11:58 PM, Peter Chen wrote: On Mon, Jan 21, 2013 at 01:34:51PM +, Michael McTernan wrote: Hi, I think I've found a debug in fsl_udc_core.c and hope for some review of the fix. It's pretty complex so apologies in advance if my explanation misses anything. The background is

Re: Linux USB file storage gadget with new UDC

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 11:47:09AM +0800, victor yeo wrote: Some progress, now i am able to see the dump_msg from ep0_complete(). It looks like the enumeration is ok, but the SCSI Inquiry command is not received by the UDC driver. The do_scsi_command() in fsg_main_thread() is

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 11:18:55AM +0530, Vivek Gautam wrote: On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim kgene@samsung.com wrote: Sylwester Nawrocki wrote: On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Sylwester Nawrocki
On 01/22/2013 06:35 AM, Kukjin Kim wrote: - { .compatible = samsung,exynos-dwc3 }, + { .compatible = samsung,synopsis-dwc3 }, Or if any version or something, how about following? + { .compatible = samsung,dwc-v3 }, Well, yes the newer SoCs with same IP using the chip name can

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
HI, On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: Vivek Gautam wrote: Changes from v5: - Rebased on top of latest patches: usb: phy: samsung: Introducing usb phy driver for hsotg (v9) usb: phy: samsung: Add support to set pmu isolation (v6) As a

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:28:48 Bjørn Mork wrote: Agreed. But I believe the condition should be if (!(info-flags FLAG_SEND_ZLP) !(info-flags FLAG_MULTI_PACKET)) { .. } else { urb-transfer_flags |= URB_ZERO_PACKET; } to ensure that we send the ZLP in this case.

Re: USB subsystem stops working

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 10:52:41AM +0900, Norbert Preining wrote: Hi Felipe, hi all, On Mo, 21 Jan 2013, Felipe Balbi wrote: Can you try rebuilding your kernel with CONFIG_USB_DEBUG=y and run your test again ? Maybe it gives us more information of what's going on. Ok, I can

Re: [PATCH net 3/3] net: cdc_ncm: fix error path for single interface probing

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:50:40 Bjørn Mork wrote: commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented support for devices with a single combined control and data interface. Fix up the error path so that we do not double release such interfaces in case of probing failures. Hi

Re: USB subsystem stops working

2013-01-22 Thread Norbert Preining
Hi I need to see what happens before the problem shows up. Your log starts after the problem has already triggered. It is a cycle, it repeats after the lsusb -v when it is back to normal. So reading from *after* the issuing the lsusb -v should show you what you need. If you want I sent

Re: USB subsystem stops working

2013-01-22 Thread Felipe Balbi
HI, On Tue, Jan 22, 2013 at 06:04:53PM +0900, Norbert Preining wrote: Hi I need to see what happens before the problem shows up. Your log starts after the problem has already triggered. It is a cycle, it repeats after the lsusb -v when it is back to normal. So reading from *after* the

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote: Specification says: NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize. The problem is: dwNtbOutMaxSize value is negotiated between host and device NCM/MBIM entities and usbnet has no knowledge about it. Adding one

[PATCH 1/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices

2013-01-22 Thread fangxiaozhi 00110321
From: fangxiaozhi huana...@huawei.com 1. Define a new macro for USB storage match rules: matching with Vendor ID and interface descriptors. Signed-off-by: fangxiaozhi huana...@huawei.com diff -uprN

Re: [PATCH] usb: musb: fix context save over suspend.

2013-01-22 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It looks like Kevin has a new address: Kevin Hilman khil...@deeprootsystems.com On 01/21/13 23:38, NeilBrown wrote: On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg grinb...@compulab.co.il wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1

[PATCH 2/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices

2013-01-22 Thread fangxiaozhi 00110321
From: fangxiaozhi huana...@huawei.com 1. Optimize the matching rules with new macro for Huawei USB storage devices, to avoid to load USB storage driver for the modem interface with Huawei devices. 2. Add to support new switch command for new Huawei USB dongles. Signed-off-by: fangxiaozhi

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote: HI, On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: Vivek Gautam wrote: Changes from v5: - Rebased on top of latest patches: usb: phy: samsung: Introducing usb phy driver for hsotg (v9)

RE: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-22 Thread Fangxiaozhi (Franko)
Dear Greg: OK, I have fixed up and resend the patches based on linux-3.8-rc4 today. Email subjects: 1. [PATCH 1/2]linux-usb:define new macro and add new match rules for Huawei USB storage devices 2. [PATCH 2/2]linux-usb:define new macro and add

Re: Linux USB file storage gadget with new UDC

2013-01-22 Thread victor yeo
Hi, Is there any way to to further debug into why do_scsi_command() is not called? usbmon, printk(), trace_printk(), kernel function tracer, there are many ways choose one and spend some time debugging, I'm sure you'll find the bug. It sounds like the UDC driver now works okay

Re: Linux USB file storage gadget with new UDC

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 05:22:58PM +0800, victor yeo wrote: Is there any way to to further debug into why do_scsi_command() is not called? usbmon, printk(), trace_printk(), kernel function tracer, there are many ways choose one and spend some time debugging, I'm sure you'll

Re: [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-22 Thread Roger Quadros
On 01/21/2013 05:03 PM, Paul Walmsley wrote: Hi On Mon, 21 Jan 2013, Roger Quadros wrote: On 01/18/2013 10:27 PM, Paul Walmsley wrote: On Fri, 18 Jan 2013, Roger Quadros wrote: We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. CC:

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote: HI, On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: Vivek Gautam wrote: Changes from v5: - Rebased on top of latest

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote: Either the FLAG_MULTI_PACKET minidriver will have already padded the buffer so that we do not hit (length % dev-maxpacket == 0), or we should choose one of the alternatives: ZLP or padding. But we cannot simply call __skb_put

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
HI, On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote: On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote: HI, On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: Vivek

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Hi Felipe, On Tue, Jan 22, 2013 at 3:02 PM, Felipe Balbi ba...@ti.com wrote: HI, On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote: On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: Hi Felipe, On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi ba...@ti.com wrote:

Re: [PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-22 Thread Bjørn Mork
Alexey ORISHKO alexey.oris...@stericsson.com writes: If you add ZLP for NTBs of dwNtbOutMaxSize, you are heavily affecting CPU load, increasing interrupt load by factor of 2 in high load traffic scenario and possibly decreasing throughput for all other devices which behaves correctly. Hello

[PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread Kishon Vijay Abraham I
This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding

[PATCH v1 5/6] usb: otg: add device tree support to otg library

2013-01-22 Thread Kishon Vijay Abraham I
Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a device node phandle value. This function will return a pointer to the phy on success, -EPROBE_DEFER if there is a device_node for the phandle, but the phy has not been added, or a ERR_PTR() otherwise. Cc: Marc Kleine-Budde

[PATCH v1 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-22 Thread Kishon Vijay Abraham I
In order to support platforms which has multiple PHY's (of same type) and which has multiple USB controllers, a new design is adopted wherin the binding information (between the PHY and the USB controller) should be passed to the PHY library from platform specific file (board file). So added a

[PATCH v1 2/6] usb: otg: utils: add facilities in phy lib to support multiple PHYs of same type

2013-01-22 Thread Kishon Vijay Abraham I
In order to add support for multipe PHY's of the same type, new API's for adding PHY and getting PHY has been added. Now the binding information for the PHY and controller should be done in platform file using usb_bind_phy API. And for getting a PHY, the device pointer of the USB controller and an

[PATCH v1 4/6] drivers: usb: musb: omap: make use of the new PHY lib APIs

2013-01-22 Thread Kishon Vijay Abraham I
New PHY lib APIs like usb_add_phy_dev() and devm_usb_get_phy_dev() are used in MUSB (OMAP), in order to make use of the binding information provided in the board file (of OMAP platforms). All the platforms should be modified similar to this to add and get the PHY. Signed-off-by: Kishon Vijay

[PATCH v1 3/6] ARM: OMAP: USB: Add phy binding information

2013-01-22 Thread Kishon Vijay Abraham I
This is w.r.t the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding information between the PHY and the USB controller should be specified in the platform specific initialization code. So it's been done here for OMAP platforms.

[PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread Kishon Vijay Abraham I
The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/omap2430.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index

Re: [PATCH v2] HID: add support for Sony RF receiver with USB product id 0x0374

2013-01-22 Thread Jiri Kosina
On Tue, 22 Jan 2013, Fernando Luis Vazquez Cao wrote: If possible, I would like to get it backported to 3.7-stable (and possibly 3.2 stable), since without it a whole family of Sony desktop computers is unusable under Linux out of the box. Should I do it myself or do you have a

Re: HID: clean up quirk for Sony RF receivers

2013-01-22 Thread Jiri Kosina
On Tue, 22 Jan 2013, Fernando Luis Vázquez Cao wrote: Document what the fix-up is does and make it more robust by ensuring that it is only applied to the USB interface that corresponds to the mouse (sony_report_fixup() is called once per interface during probing). Applied. -- Jiri Kosina

Re: [PATCH net 3/3] net: cdc_ncm: fix error path for single interface probing

2013-01-22 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 21 January 2013 16:50:40 Bjørn Mork wrote: commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented support for devices with a single combined control and data interface. Fix up the error path so that we do not double release such

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 21 January 2013 16:28:48 Bjørn Mork wrote: Agreed. But I believe the condition should be if (!(info-flags FLAG_SEND_ZLP) !(info-flags FLAG_MULTI_PACKET)) { .. } else { urb-transfer_flags |= URB_ZERO_PACKET; } to ensure

Re: [PATCH v1 5/6] usb: otg: add device tree support to otg library

2013-01-22 Thread Mark Rutland
+struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, + const char *phandle, u8 index) +{ + struct usb_phy *phy = NULL, **ptr; + unsigned long flags; + struct device_node *node; + + if (!dev-of_node) { + dev_dbg(dev, device does not have a

[PATCH] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Venu Byravarasu
As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under driver/usb/phy. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- drivers/usb/otg/otg.c| 184 --

Re: [PATCH] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Felipe Balbi
HI, On Tue, Jan 22, 2013 at 04:26:50PM +0530, Venu Byravarasu wrote: As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under driver/usb/phy. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com ---

[PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Venu Byravarasu
As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under driver/usb/phy. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- delta from v1: Missed adding newly created file usb_phy.c with previous patch. hence sending

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-22 Thread Pali Rohár
On Monday 21 January 2013 09:05:06 Felipe Balbi wrote: Hi, On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote: On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: Signed-off-by: Pali Rohár pali.ro...@gmail.com

RE: [PATCH] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Venu Byravarasu
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 22, 2013 4:31 PM To: Venu Byravarasu Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] usb: phy: moving all PHY API definitions

Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 04:31:11PM +0530, Venu Byravarasu wrote: As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under driver/usb/phy. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- delta from v1:

[PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Vivek Gautam
Changes from v7: - Rebased on 'xceive' of Balbi's usb tree. - Placing proper Acked By's received for each patch. Changes from v6: - Changing macro names from 'HOST_CTRL0_FSEL_CLKSEL_XX' to 'FSEL_CLKSEL_XX' since it's being used by HOST and OTG block to prepare reference clock. - Directly

[PATCH v8 1/4] ARM: EXYNOS: Update move usb-phy types to generic include layer

2013-01-22 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com ---

[PATCH v8 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-22 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com ---

[PATCH v8 4/4] USB: ohci-exynos: Add phy driver support

2013-01-22 Thread Vivek Gautam
Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Kukjin Kim

Re: ehci-hcd compile error

2013-01-22 Thread Roger Quadros
On 01/18/2013 08:35 PM, Alan Stern wrote: On Fri, 18 Jan 2013, Roger Quadros wrote: Thanks. I used the below code (also attached) and could reproduce corruption on the first byte at ehci-priv. This is from the the kernel log. [ 30.381774] ehci-omap ehci-omap.0: ehci_hcd_omap_probe a

Re: [PATCH v6 6/8] usb: expose usb port's pm qos flags to user space

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:31, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:05PM +0800, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off flag to prohibit the port from being powered off. How are

Re: PROBLEM: 3.8.0-rc4 keyboard failure at boot

2013-01-22 Thread Jiri Kosina
On Tue, 22 Jan 2013, Brad Tilley wrote: Could you please provide dmesg output from both working and non-working case? See attached. Two dmesgs from the same machine. One from 3.7.3, the other from 3.8-rc4 (with a ps2 keyboard). USB keyboards on this machine never work with 3.8, but

Re: [PATCH v6 7/8] usb: add usb_device_allow_power_off() and usb_device_prevent_power_off() function.

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:33, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:06PM +0800, Lan Tianyu wrote: Some usb devices can't be resumed correctly after power off. This patch is to add usb_device_allow_power_off() and usb_device_prevent_power_off() for device's driver. Call pm_runtime_get_sync(portdev)

Re: [PATCH v1 2/6] usb: otg: utils: add facilities in phy lib to support multiple PHYs of same type

2013-01-22 Thread Roger Quadros
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: In order to add support for multipe PHY's of the same type, new API's for adding PHY and getting PHY has been added. Now the binding information for the PHY and controller should be done in platform file using usb_bind_phy API. And for

Re: [PATCH v1 4/6] drivers: usb: musb: omap: make use of the new PHY lib APIs

2013-01-22 Thread Roger Quadros
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: New PHY lib APIs like usb_add_phy_dev() and devm_usb_get_phy_dev() are used in MUSB (OMAP), in order to make use of the binding information provided in the board file (of OMAP platforms). All the platforms should be modified similar to this

Re: [PATCH v1 2/6] usb: otg: utils: add facilities in phy lib to support multiple PHYs of same type

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 07:37 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: In order to add support for multipe PHY's of the same type, new API's for adding PHY and getting PHY has been added. Now the binding information for the PHY and controller should

Re: PROBLEM: 3.8.0-rc4 keyboard failure at boot

2013-01-22 Thread Brad Tilley
On Tue, Jan 22, 2013 at 02:51:08PM +0100, Jiri Kosina wrote: On Tue, 22 Jan 2013, Brad Tilley wrote: Could you please provide dmesg output from both working and non-working case? See attached. Two dmesgs from the same machine. One from 3.7.3, the other from 3.8-rc4 (with a ps2

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread Roger Quadros
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/omap2430.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2] usb: phy: moving all PHY API definitions to usb/phy directory

2013-01-22 Thread Roger Quadros
On 01/22/2013 01:01 PM, Venu Byravarasu wrote: As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under driver/usb/phy. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- delta from v1: Missed adding newly

Re: [PATCH v6 7/8] usb: add usb_device_allow_power_off() and usb_device_prevent_power_off() function.

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:33, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:06PM +0800, Lan Tianyu wrote: Some usb devices can't be resumed correctly after power off. This patch is to add usb_device_allow_power_off() and usb_device_prevent_power_off() for device's driver. Call pm_runtime_get_sync(portdev)

Re: [PATCH v6 8/8] usb: enable usb port device's async suspend.

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:34, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:07PM +0800, Lan Tianyu wrote: Signed-off-by: Lan Tianyu tianyu@intel.com Why are you doing this? Why is it now ok? We need a much better changelog entry here. Ok. I will add later. thanks, greg k-h -- Best Regards

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/omap2430.c |7 ++- 1 file

Re: uhci irq race before term_td is allocated

2013-01-22 Thread Don Zickus
On Tue, Jan 22, 2013 at 06:17:00AM +, Huang, Adrian (ISS Linux TW) wrote: Hi Alan, Recently, I'm debugging this issue (the same symptom described by Don) on my server. Fortunately, the issue was fixed by applying your patch posted in this email thread. Just checked the latest kernel

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread Roger Quadros
On 01/22/2013 04:37 PM, kishon wrote: On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

Re: Linux USB file storage gadget with new UDC

2013-01-22 Thread victor yeo
Hi, It sounds like the UDC driver now works okay for control transfers but not for bulk transfers. Some code in file_storage.c that i cannot understand. In ep0_complete(), the code snippet: if (req-status == 0 req-context) ((fsg_routine_t)

Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 09:16:08AM +, Fangxiaozhi (Franko) wrote: Dear Greg: OK, I have fixed up and resend the patches based on linux-3.8-rc4 today. Email subjects: 1. [PATCH 1/2]linux-usb:define new macro and add new match rules for Huawei USB storage

Re: [PATCH v6 7/8] usb: add usb_device_allow_power_off() and usb_device_prevent_power_off() function.

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 10:23:12PM +0800, Lan Tianyu wrote: On 2013/1/22 5:33, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:06PM +0800, Lan Tianyu wrote: Some usb devices can't be resumed correctly after power off. This patch is to add usb_device_allow_power_off() and

Re: [PATCH v6 7/8] usb: add usb_device_allow_power_off() and usb_device_prevent_power_off() function.

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Lan Tianyu wrote: +/** + * usb_device_control_power_off - Allow or prohibit power off device. + * @udev: target usb device + * @allow: choice of allow or prohibit + * + * Call pm_runtime_get/put_sync(portdev) to allow or prohibit target + * usb device to be

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Manjunath Goudar wrote: I think we can actually get the same results by turning the Kconfig logic around and making the platform glue drivers 'select USB_EHCI_HCD' than depending on it. That's a good idea. The Kconfig changes would have to be done

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote: On 01/22/2013 04:37 PM, kishon wrote: On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by:

Re: ehci-hcd compile error

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Roger Quadros wrote: Alan, It seems that EHCI_STATS is locally defined in ehci_hcd.c thus causing different versions of struct ehci_hcd to be visible to other users like ehci-omap.c The attached patch solves the problem for me and must go in with your other patches.

[PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-22 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver

2013-01-22 Thread Vivek Gautam
Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-22 Thread Vivek Gautam
Changes from v1: - Putting separate device nodes for usb 2.0 phy and usb 3.0 phy based on separate driver for samsung usb 3.0 phy and samsung usb 2.0 phy: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250 [PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250 -

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Shawn Guo wrote: On Mon, Jan 21, 2013 at 09:37:42PM +, Arnd Bergmann wrote: Arnd, please take a look at http://marc.info/?l=linux-usbamp;m=135843716515529amp;w=2 I can't test it easily, not being set up for cross compilation. I'm waiting to

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:30, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: This patch is to add usb port auto power off mechanism. When usb device is suspending, usb core will suspend usb port and usb port runtime pm callback will clear PORT_POWER feature to power off port if

Re: [PATCH v6 7/8] usb: add usb_device_allow_power_off() and usb_device_prevent_power_off() function.

2013-01-22 Thread Lan Tianyu
On 2013/1/22 23:05, Greg KH wrote: On Tue, Jan 22, 2013 at 10:23:12PM +0800, Lan Tianyu wrote: On 2013/1/22 5:33, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:06PM +0800, Lan Tianyu wrote: Some usb devices can't be resumed correctly after power off. This patch is to add

Re: [PATCH v1 5/6] usb: otg: add device tree support to otg library

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 04:06 PM, Mark Rutland wrote: +struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, + const char *phandle, u8 index) +{ + struct usb_phy *phy = NULL, **ptr; + unsigned long flags; + struct device_node *node; + + if

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread Peter Ujfalusi
On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Arnd Bergmann
On Tuesday 22 January 2013, Alan Stern wrote: In order to prevent this, you have to make sure that each glue driver depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround the Kconfig entries for those drivers with if USB USB_ARCH_HAS_EHCI ... endif. I was actually thinking we

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 09:08 PM, Peter Ujfalusi wrote: On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread Koen Kooi
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread kishon
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in

RE: [PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-22 Thread Alexey ORISHKO
H Bjørn, -Original Message- From: Bjørn Mork [mailto:bj...@mork.no] Sent: Tuesday, January 22, 2013 10:54 AM If you add ZLP for NTBs of dwNtbOutMaxSize, you are heavily affecting CPU load, increasing interrupt load by factor of 2 in high load traffic scenario and possibly

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: On 2013/1/22 5:30, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: @@ -127,7 +128,7 @@ static inline char *portspeed(struct usb_hub *hub, int portstatus) } /* Note that hdev or one of its children

Re: USB issue with kernel 3.6

2013-01-22 Thread Alan Stern
On Fri, 18 Jan 2013, Alan Stern wrote: Well, I guess there's no choice but to go back to the one-at-a-time approach. I'll write a proper patch for that. And here it is at last. This completely replaces the earlier patch. Alan Stern Index: 3.7/drivers/usb/host/ehci-timer.c

Re: Linux USB file storage gadget with new UDC

2013-01-22 Thread Felipe Balbi
On Tue, Jan 22, 2013 at 10:49:50PM +0800, victor yeo wrote: Hi, It sounds like the UDC driver now works okay for control transfers but not for bulk transfers. Some code in file_storage.c that i cannot understand. In ep0_complete(), the code snippet: if

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 12:03:09PM +0100, Pali Rohár wrote: On Monday 21 January 2013 09:05:06 Felipe Balbi wrote: Hi, On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote: On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: On Sun, Jan 20, 2013 at 03:58:13AM +0100,

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/23 0:02, Greg KH wrote: On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: On 2013/1/22 5:30, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: @@ -127,7 +128,7 @@ static inline char *portspeed(struct usb_hub *hub, int portstatus) } /* Note

[PATCH 0/4] USB: EHCI: fix several bugs and error for v3.8

2013-01-22 Thread Alan Stern
Greg: The following series fixes some bugs and build errors introduced into ehci-hcd during the v3.8 kernel development, partly as a result of moving over to the ehci-hcd is a library approach and partly as a result of the ARM multi-arch work: The ehci_stats structure is built

[PATCH 1/4] USB: EHCI: Move definition of EHCI_STATS to ehci.h

2013-01-22 Thread Alan Stern
From 70a3621d583c0c76d0bf8239b27eb65d01d918b2 Mon Sep 17 00:00:00 2001 From: Roger Quadros rog...@ti.com Date: Tue, 22 Jan 2013 14:37:57 +0200 Subject: [PATCH] USB: EHCI: Move defination of EHCI_STATS to ehci.h Without this, platform drivers e.g. ehci-omap.c will see a different version of struct

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread Koen Kooi
Op 22 jan. 2013, om 17:16 heeft kishon kis...@ti.com het volgende geschreven: Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven:

Re: [PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-22 Thread Yauheni Kaliuta
Hi! On Tue, Jan 22, 2013 at 12:01 AM, Bjørn Mork bj...@mork.no wrote: Yauheni Kaliuta y.kali...@gmail.com writes: BM == Bjørn Mork writes: We normally avoid sending ZLPs by padding NTBs with a zero byte if the NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Greg KH
On Wed, Jan 23, 2013 at 12:58:09AM +0800, Lan Tianyu wrote: On 2013/1/23 0:02, Greg KH wrote: On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: On 2013/1/22 5:30, Greg KH wrote: @@ -3758,7 +3805,9 @@ static int hub_port_debounce(struct usb_hub *hub, int port1)

Re: [PATCH 4/4] USB: EHCI: fix build error in ehci-mxc

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 12:00:35PM -0500, Alan Stern wrote: This patch (as1643) fixes a build error in ehci-hcd when compiling for ARM with allmodconfig: drivers/usb/host/ehci-hcd.c:1285:0: warning: PLATFORM_DRIVER redefined [enabled by default] drivers/usb/host/ehci-hcd.c:1255:0: note:

Re: USB issue with kernel 3.6

2013-01-22 Thread Piergiorgio Sartor
Hi Alan, On Tue, Jan 22, 2013 at 11:09:43AM -0500, Alan Stern wrote: On Fri, 18 Jan 2013, Alan Stern wrote: Well, I guess there's no choice but to go back to the one-at-a-time approach. I'll write a proper patch for that. And here it is at last. This completely replaces the earlier

Re: USB issue with kernel 3.6

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Piergiorgio Sartor wrote: Hi Alan, On Tue, Jan 22, 2013 at 11:09:43AM -0500, Alan Stern wrote: On Fri, 18 Jan 2013, Alan Stern wrote: Well, I guess there's no choice but to go back to the one-at-a-time approach. I'll write a proper patch for that. And

Re: [PATCH 4/4] USB: EHCI: fix build error in ehci-mxc

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Greg KH wrote: This patch fails to apply: patching file drivers/usb/host/Kconfig patching file drivers/usb/host/Makefile patching file drivers/usb/host/ehci-hcd.c patching file drivers/usb/host/ehci-mxc.c Hunk #1 FAILED at 17. Hunk #2 succeeded at 112 (offset -1

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/23 1:18, Greg KH wrote: On Wed, Jan 23, 2013 at 12:58:09AM +0800, Lan Tianyu wrote The above line, as written is under 80 characters, so I don't understand the issue. If I do following, scripts/checkpatch.pl will complain over 80 characters. @@ -3767,7 +3814,9 @@

Re: USB subsystem stops working

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Norbert Preining wrote: Hi Felipe, hi all, On Mo, 21 Jan 2013, Felipe Balbi wrote: Can you try rebuilding your kernel with CONFIG_USB_DEBUG=y and run your test again ? Maybe it gives us more information of what's going on. Ok, I can reliably reproduce the problem

Re: USB subsystem stops working

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Alan Stern wrote: On Tue, 22 Jan 2013, Norbert Preining wrote: Hi Felipe, hi all, On Mo, 21 Jan 2013, Felipe Balbi wrote: Can you try rebuilding your kernel with CONFIG_USB_DEBUG=y and run your test again ? Maybe it gives us more information of what's going

Root hub autosusend delay

2013-01-22 Thread Alan Stern
Lei: It turns out that your patch setting the autosuspend delay for hubs to 0 causes problems for root hubs. They need a delay of at least 30 ms. When a child device sends a remote wakeup request, the root hub generates an interrupt. The HCD's interrupt handler sees what happened and requests

  1   2   >