Re: [PATCH v3] USB: mos7840: looping issue: avoid the return value overriden by looping

2013-04-06 Thread Chen Gang
On 2013年04月03日 17:25, Chen Gang wrote: inside the 'for' looping: the return value 'rv' may override if not have a check in time. the next checking (outside the 'for' looping): can not find failure which generated during the 'for' looping the fix is for: let outside know

Re: [PATCH -next] usb: gadget: multi: fix error return code in rndis_do_config()

2013-04-06 Thread Wei Yongjun
On 04/06/2013 01:39 PM, Felipe Balbi wrote: On Sat, Apr 06, 2013 at 12:39:34PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei

[PATCH -next v2] usb: gadget: multi: fix error return code in rndis_do_config()

2013-04-06 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 59835a(usb: gadget: multi: use function framework for ACM.) Signed-off-by: Wei Yongjun

[PATCH -next v2] usb: gadget: cdc2: fix error return code in cdc_do_config()

2013-04-06 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 29a664(usb: gadget: cdc2: use function framework for ACM) Signed-off-by: Wei Yongjun

Re: [PATCH v3] USB: mos7840: looping issue: avoid the return value overriden by looping

2013-04-06 Thread Chen Gang
On 2013年04月06日 15:34, Chen Gang wrote: On 2013年04月03日 17:25, Chen Gang wrote: inside the 'for' looping: the return value 'rv' may override if not have a check in time. the next checking (outside the 'for' looping): can not find failure which generated during the 'for' looping

Re: [PATCH -next v2] usb: gadget: multi: fix error return code in rndis_do_config()

2013-04-06 Thread Michal Nazarewicz
On Sat, Apr 06 2013, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Introduced by commit 59835a(usb: gadget: multi: use function framework for ACM.)

Re: [RFC PATCH 14/41] staging: dwc2: simplify debug output in dwc_hc_init

2013-04-06 Thread Sergei Shtylyov
Hello. On 06-04-2013 1:26, Matthijs Kooijman wrote: Before, the value of the hcchar register was shifted and masked and then the debug output extracted the individual values out of the complete hcchar register again. This commit makes the debug prints directly use the original values instead.

Re: [RFC PATCH 27/41] staging: dwc2: add dwc2_disable_common_interrupts function

2013-04-06 Thread Sergei Shtylyov
Hello. On 06-04-2013 1:27, Matthijs Kooijman wrote: This function disables all common interrupts, i.e., those that are handled by the common interrupt handler. Signed-off-by: Matthijs Kooijman matth...@stdin.nl [...] diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c

Re: [RFC PATCH 28/41] staging: dwc2: introduce GINTMSK_HOST macro

2013-04-06 Thread Sergei Shtylyov
Hello. On 06-04-2013 1:27, Matthijs Kooijman wrote: This simply defines a list of interrupts handled by the the host interrupt handler. Signed-off-by: Matthijs Kooijman matth...@stdin.nl [...] diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c index a3b8556..ab6844c

Re: [RFC PATCH 36/41] staging: dwc2: Make dwc2_set_uninitialized more specific

2013-04-06 Thread Sergei Shtylyov
On 06.04.2013 1:27, Matthijs Kooijman wrote: Before, it was a function that would set all members of a given struct containing only int members to -1. Now, it is renamed to dwc_set_all_params and it works only on the dwc2_core_params struct. This makes sure that all of the slightly dubious

IMX23 usb instability on 3.9-rc5

2013-04-06 Thread Alexandre Pereira da Silva
Hello, I am testing a usb key connected on a IMX23-Olinuxino board. The kernel panics at heavy usb trafic. This was build with the mxs defconfig This happens everytime with dd if=/dev/sda of=/dev/null bs=4k. The messages of the failure varies a lot from run to run. I tested also on kernel

Re: IMX23 usb instability on 3.9-rc5

2013-04-06 Thread Fabio Estevam
Alexandre, On Sat, Apr 6, 2013 at 4:39 PM, Alexandre Pereira da Silva aletes@gmail.com wrote: Hello, I am testing a usb key connected on a IMX23-Olinuxino board. The kernel panics at heavy usb trafic. This was build with the mxs defconfig This happens everytime with dd if=/dev/sda