Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-30 Thread Felipe Balbi
Hi, On Fri, Jun 28, 2013 at 10:06:01PM +0200, Michael Grzeschik wrote: right, but in DT you will define both instances and each instance will have a seaparate snps,maximum_speed attribute :-) I'm now considering if we should make maximum_speed a generic

[PATCH] USB: OHCI: make ohci-nxp a separate driver

2013-06-30 Thread Manjunath Goudar
Separate the OHCI NXP host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Many place function name and struct name started with usb, current scenario replaced usb with ohci for proper

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-30 Thread Ming Lei
On Sun, Jun 30, 2013 at 2:35 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 29 Jun 2013, Ming Lei wrote: The ehci_endpoint_disable() routine can be improved. In the QH_STATE_LINNKED or QH_STATE_COMPLETING case, we now need to handle interrupt QHs -- the comment about periodic qh

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-30 Thread Alan Stern
On Sun, 30 Jun 2013, Ming Lei wrote: Come to think of it, we never should see an endpoint being disabled while there are active URBs. It might be a better idea to put a Right. WARN_ON there and simply return, without unlinking anything. If this ever triggers, it means there's a bug

How should we handle isochronous underruns?

2013-06-30 Thread Alan Stern
Clement and Laurent: The two of you seem to be the people who make the most use of isochronous USB transfers. Since the ehci-hcd driver is being changed to use a tasklet for URB completion callbacks, it looks like I will need to reconsider how isochronous underruns get handled. The basic prolem

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-30 Thread Ming Lei
On Sun, Jun 30, 2013 at 10:05 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sun, 30 Jun 2013, Ming Lei wrote: Come to think of it, we never should see an endpoint being disabled while there are active URBs. It might be a better idea to put a Right. WARN_ON there and simply return,

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-30 Thread Alan Stern
On Mon, 1 Jul 2013, Ming Lei wrote: So I think we should unlink here to speed up the procedure as suggested in your previous email. You are right. If the QH's qtd_list isn't empty then we should WARN_ON and return without doing anything -- just leak the QH. Otherwise, Yes, we can

[PATCH 3/3] USB: mos7840: fix race in led handling

2013-06-30 Thread Johan Hovold
Fix race in LED handling introduced by commit 0eafe4de (USB: serial: mos7840: add support for MCS7810 devices) which reused the port control urb for manipulating the LED without making sure that the urb is not already in use. This could lead to the control urb being manipulated while in flight.

[PATCH 1/3] USB: mos7840: fix race in register handling

2013-06-30 Thread Johan Hovold
Fix race in mos7840_get_reg which unconditionally manipulated the control urb (which may already be in use) by adding a control-urb busy flag. Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/usb/serial/mos7840.c | 18 -- 1 file changed, 16

[PATCH 0/3] USB: mos7840: fixes for v3.11-rc1

2013-06-30 Thread Johan Hovold
These patches fix three (related) races in mos7840. Driver's a bit of mess... Tested using a mos7820 (and by faking a mos7810 with LED). Johan Johan Hovold (3): USB: mos7840: fix race in register handling USB: mos7840: fix device-type detection USB: mos7840: fix race in led handling

[PATCH 2/3] USB: mos7840: fix device-type detection

2013-06-30 Thread Johan Hovold
Fix race in device-type detection introduced by commit 0eafe4de (USB: serial: mos7840: add support for MCS7810 devices) which used a static variable to hold the device type. Move type detection to probe and use serial data to store the device type. Cc: sta...@vger.kernel.org Signed-off-by: Johan

Re: Scanner fails on USB3 port

2013-06-30 Thread Martin van Es
3.9.8 brought a tiny improvement! scanimage -L now succesfully reports the scanner, but then hangs. I still can not scan with xsane however (no scanner device found) $ scanimage -L device `plustek:libusb:001:004' is a Canon CanoScan N670U/N676U/LiDE20 flatbed scanner (hang, but eventually

Re: [PATCH] usb: host: xhci-plat: Enable XHCI_SPURIOUS_SUCCESS quirk for xhci-plat

2013-06-30 Thread Sarah Sharp
On Wed, Jun 26, 2013 at 09:53:34AM -0700, Sarah Sharp wrote: On Wed, Jun 26, 2013 at 02:28:57PM +0530, George Cherian wrote: Synopsis xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr

Re: [PATCH] xhci: Compute last_ctx from complete set of configured endpoints.

2013-06-30 Thread Sarah Sharp
On Mon, Jun 24, 2013 at 09:24:28AM -0700, Reilly Grant wrote: On Mon, Jun 24, 2013 at 08:59AM -0700, Sarah Sharp wrote: On Tue, Jun 18, 2013 at 02:09:13PM -0700, Reilly Grant wrote: So, no, I can't accept this patch. If this fixes a real problem in some hardware, we'll add a quirk for

[RFC] xhci: remove USB_XHCI_HCD_DEBUGGING config option

2013-06-30 Thread Xenia Ragiadakou
CONFIG_USB_XHCI_HCD_DEBUGGING option is used to enable verbose debugging output for the xHCI host controller driver. In the current version of the xhci-hcd driver, this option must be turned on, in order for the debugging log messages to be displayed, and users may need to recompile the linux

Re: [RFC] xhci: remove USB_XHCI_HCD_DEBUGGING config option

2013-06-30 Thread Greg KH
On Mon, Jul 01, 2013 at 12:23:18AM +0300, Xenia Ragiadakou wrote: CONFIG_USB_XHCI_HCD_DEBUGGING option is used to enable verbose debugging output for the xHCI host controller driver. In the current version of the xhci-hcd driver, this option must be turned on, in order for the debugging

Re: Scanner fails on USB3 port

2013-06-30 Thread Greg KH
On Sun, Jun 30, 2013 at 09:35:59PM +0200, Martin van Es wrote: 3.9.8 brought a tiny improvement! scanimage -L now succesfully reports the scanner, but then hangs. I still can not scan with xsane however (no scanner device found) $ scanimage -L device `plustek:libusb:001:004' is a Canon

Re: [PATCH] xhci: fix dma mask setup in xhci.c

2013-06-30 Thread Sarah Sharp
On Wed, Jun 26, 2013 at 01:20:53AM +0300, Xenia Ragiadakou wrote: On 06/26/2013 12:16 AM, Sarah Sharp wrote: I'm a little bit confused by this patch, so I'm CC-ing the list. On Tue, Jun 25, 2013 at 08:52:49AM +0300, Xenia Ragiadakou wrote: This patch initializes the dma_mask pointer to point

Huawei E3131 wwan interface

2013-06-30 Thread Enrico Mioso
Hi! I'm trying to investigate on the Huawei E3131 wwan interface - like the E398, this device ignores the at^ndisdup command. I wanted to verify if my device was running a jungo firmware or not, since I found contraddictory informations on the network. To this end, I patched the cdc_ncm driver

Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-30 Thread ZhenHua
On 06/28/2013 10:22 PM, Alan Stern wrote: On Fri, 28 Jun 2013, Li, Zhen-Hua (USL-China) wrote: There was a problem, the warning Controller not stopped yet. And your last patch for this problem does a wrong thing: It prevents all HP uhci devices from auto-stop, which make HP uhci devices waste

Re: [RFC] xhci: remove USB_XHCI_HCD_DEBUGGING config option

2013-06-30 Thread Sarah Sharp
On Sun, Jun 30, 2013 at 02:54:26PM -0700, Greg KH wrote: On Mon, Jul 01, 2013 at 12:23:18AM +0300, Xenia Ragiadakou wrote: CONFIG_USB_XHCI_HCD_DEBUGGING option is used to enable verbose debugging output for the xHCI host controller driver. In the current version of the xhci-hcd driver,

Re: [RFC] xhci: remove USB_XHCI_HCD_DEBUGGING config option

2013-06-30 Thread Xenia Ragiadakou
On 07/01/2013 04:24 AM, Sarah Sharp wrote: On Sun, Jun 30, 2013 at 02:54:26PM -0700, Greg KH wrote: On Mon, Jul 01, 2013 at 12:23:18AM +0300, Xenia Ragiadakou wrote: CONFIG_USB_XHCI_HCD_DEBUGGING option is used to enable verbose debugging output for the xHCI host controller driver. In the

Re: [PATCH] xhci: fix dma mask setup in xhci.c

2013-06-30 Thread Xenia Ragiadakou
On 07/01/2013 01:29 AM, Sarah Sharp wrote: On Wed, Jun 26, 2013 at 01:20:53AM +0300, Xenia Ragiadakou wrote: On 06/26/2013 12:16 AM, Sarah Sharp wrote: I'm a little bit confused by this patch, so I'm CC-ing the list. On Tue, Jun 25, 2013 at 08:52:49AM +0300, Xenia Ragiadakou wrote: This

RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-30 Thread Chen Peter-B29397
You should see the voltage of vbus pin is less than 0.8v when nothing is connected, we use B_SESSION_VALID (0.8v) to judge it is connected or not. You get 2.25 all the time or it is discharged very slowly? On my mx28evk it discharges very very slowly. Any hints about it? Due to

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-30 Thread Ming Lei
On Mon, Jul 1, 2013 at 1:35 AM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 1 Jul 2013, Ming Lei wrote: So I think we should unlink here to speed up the procedure as suggested in your previous email. You are right. If the QH's qtd_list isn't empty then we should WARN_ON and

Re: How should we handle isochronous underruns?

2013-06-30 Thread Ming Lei
On Sun, Jun 30, 2013 at 11:02 PM, Alan Stern st...@rowland.harvard.edu wrote: Clement and Laurent: The two of you seem to be the people who make the most use of isochronous USB transfers. Since the ehci-hcd driver is being changed to use a tasklet for URB completion callbacks, it looks like

[PATCH v2] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-06-30 Thread George Cherian
Xhci controllers with hci_version 0.96 gives spurious success events on short packet completion. During webcam capture the ERROR Transfer event TRB DMA ptr not part of current TD was observed. The same application works fine with synopsis controllers hci_version 0.96. The same Issue is seen with