[PATCH 4/4] usb: gadget: net2280: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/usb/gadget/net2280.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/ne

[PATCH 3/4] usb: gadget: pch_udc: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/usb/gadget/pch_udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/pc

[PATCH 2/4] usb: gadget: goku_udc: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/usb/gadget/goku_udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/g

[PATCH 1/4] usb: gadget: amd5536udc: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/usb/gadget/amd5536udc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadg

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

At Wed, 11 Sep 2013 16:42:09 -0700, Sarah Sharp wrote: > > Hi Takashi, > > You've added the PCI device IDs of the xHCI LPT and LPT-LP to pci_ids.h. > AFAIK, the xHCI driver is the only driver to use it, and I thought the > rule was that we would only add the device IDs to pci_ids.h if more than >

Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call

On Thursday 12 September 2013 04:44 AM, Sarah Sharp wrote: Hi Kumar, I was waiting until after the 3.12 merge window to queue this patch, but Xenia noticed that the xhci_readl functions can completely go away and be replaced by standard readl/writel operations. She's posted a patchset to do tha

Re: usbnet transmit path problems

On Thu, Sep 12, 2013 at 12:05 AM, David Laight wrote: >> On Wed, Sep 11, 2013 at 8:56 PM, David Laight >> wrote: >> >> > > 2) If 'length % dev->maxpacket == 0' for a multi-fragment packet then >> >> > >the extra byte isn't added correctly (the code probably falls off >> >> > >the end of

Re: [PATCH] usb: dwc3: gadget: avoid memory leak when failing to allocate all eps

Hi Mr. Balbi, :) On 09/11/2013 05:38 PM, David Cohen wrote: If dwc3_gadget_init_endpoint() fails after allocate some of the eps, we need to free their memory to avoid leak. Signed-off-by: David Cohen --- drivers/usb/dwc3/gadget.c | 13 - 1 file changed, 8 insertions(+), 5 deleti

[PATCH v2] usb: dwc3: gadget: avoid memory leak when failing to allocate all eps

If dwc3_gadget_init_endpoint() fails after allocate some of the eps, we need to free their memory to avoid leak. Signed-off-by: David Cohen --- drivers/usb/dwc3/gadget.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.

[PATCH] usb: dwc3: gadget: avoid memory leak when failing to allocate all eps

If dwc3_gadget_init_endpoint() fails after allocate some of the eps, we need to free their memory to avoid leak. Signed-off-by: David Cohen --- drivers/usb/dwc3/gadget.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

Hi Takashi, You've added the PCI device IDs of the xHCI LPT and LPT-LP to pci_ids.h. AFAIK, the xHCI driver is the only driver to use it, and I thought the rule was that we would only add the device IDs to pci_ids.h if more than one driver used it. Wouldn't it make sense to avoid polluting pci_id

Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call

Hi Kumar, I was waiting until after the 3.12 merge window to queue this patch, but Xenia noticed that the xhci_readl functions can completely go away and be replaced by standard readl/writel operations. She's posted a patchset to do that: http://marc.info/?l=linux-usb&m=137874983529708&w=2 I ha

Re: [PATCH] net: qmi_wwan: add new Qualcomm devices

From: Bjørn Mork Date: Tue, 10 Sep 2013 15:06:20 +0200 > Adding the device list from the Windows driver description files > included with a new Qualcomm MDM9615 based device, "Alcatel-sbell > ASB TL131 TDD LTE", from China Mobile. This device is tested > and verified to work. The others are ass

RE: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

On Wed, 11 Sep 2013, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > > Sent: Wednesday, September 11, 2013 9:30 AM > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > > Reloading xhci-hcd module works no

RE: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > Sent: Wednesday, September 11, 2013 9:30 AM > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > Reloading xhci-hcd module works no matter whether CONFIG_PM_RUNTIME=y > > or not. (And yes,

Re: "Virtual" Interrupts -- Need help please

On 09/10/2013 01:01 PM, Mark Brown wrote: On Mon, Sep 09, 2013 at 04:12:21PM -0500, Daniel Santos wrote: One of my original requirements for this driver is that it is reusable for different devices that use the MCP2210, not just my own hardware. There are a number of ways to accomplish this, bu

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

On Wed, 11 Sep 2013, Takashi Iwai wrote: > Reloading xhci-hcd module works no matter whether CONFIG_PM_RUNTIME=y > or not. (And yes, the device went to D3 at unload and to D0 at load, > as long as looking at lspci output.) Interesting. I thought there wasn't any code in the PCI core for putting

[PATCH 01/11] staging: usbip: Fix IPv6 support in usbipd

getaddrinfo() leaves the order of the returned addrinfo structs unspecified. On systems with bindv6only disabled (this is the default), PF_INET6 sockets bind to IPv4, too. Thus, IPv6 support in usbipd was broken when getaddrinfo returned first IPv4 and then IPv6 addrinfos, as the IPv6 bind failed w

[PATCH 08/11] staging: usbip: Handle usbip being started as user

usbip now prints an error message when started as user and requiring root access. Also, some debug messages are changed to error messages so the command line utilities now print less confusing (and more verbose) error messages when not used correctly. Signed-off-by: Dominik Paulus Signed-off-by:

[no subject]

Hi, this patch series includes an updated version of the IPv6 support patch (a call to freeaddrinfo() was missing) as well as: - The client/server authentication support using GnuTLS Tobias already announced on the usbip-devel mailing list some time ago[1] - Support for restricting the acce

[PATCH 05/11] staging: usbip: Add ACL support to usbip bind

Add the command line argument -a (--allow) to usbip bind to specify networks allowed to attach to the device and code to store the ACLs in sysfs. Signed-off-by: Kurt Kanzenbach Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/doc/usbip.8 | 8

[PATCH 03/11] staging: usbip: Add kernel support for client ACLs

This patch adds the possibility to stored ACLs for allowed clients for each stub device in sysfs. It adds a new sysfs entry called "usbip_acl" for each stub device, containing a list of CIDR masks of allowed clients. This file will be used by usbip and usbipd to store the ACL. Signed-off-by: Kurt

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

At Wed, 11 Sep 2013 11:45:08 -0400 (EDT), Alan Stern wrote: > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > > > > Haswell LynxPoint and LynxPoint-LP with the recent In

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > It seems that this will be fixed in the BIOS side, too. But, the > > > problematic BIOS is still on the shipped machines that will appear in > > > the market sooner, unfortunately. > > > > People can update the BIOS, if a fix is available. > > It'd

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

At Wed, 11 Sep 2013 18:04:41 +0200, Takashi Iwai wrote: > > At Wed, 11 Sep 2013 11:45:08 -0400 (EDT), > Alan Stern wrote: > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > > At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), > > > Alan Stern wrote: > > > > > > > > On Wed, 11 Sep 2013, Takashi Iwa

[PATCH 04/11] staging: usbip: Add CIDR matching helper functions

This patch adds a few utility functions to match IP addresses against CIDR masks. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/utils.c | 84 + drivers/staging/usbip/userspace/src/utils.h | 15 ++ 2 files chang

[PATCH 02/11] staging: usbip: Add support for client authentication

This patch adds support for authenticating both client and server using a pre-shared passphrase using SRP (Secure Remote Password) over TLS (see RFC 5054) using GnuTLS. Both usbip and usbipd now accept a shared secret as a command line argument. Currently, the established TLS connection is only use

[PATCH 07/11] staging: usbip: Add proper error reporting

This patch adds new error codes and features extended error reporting in op_common packets. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +- drivers/staging/usbip/userspace/src/usbip_list.c | 3 +- .../staging/usbip/us

[PATCH 06/11] staging: usbip: Add support for ACLs in usbipd

Interpret the ACLs stored in sysfs in usbipd and reject clients not matching one of the ACLs. Signed-off-by: Kurt Kanzenbach Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/Makefile.am | 2 +- drivers/staging/usbip/userspace/src/usbipd.c|

RE: usbnet transmit path problems

> On Wed, Sep 11, 2013 at 8:56 PM, David Laight wrote: > >> > > 2) If 'length % dev->maxpacket == 0' for a multi-fragment packet then > >> > >the extra byte isn't added correctly (the code probably falls off > >> > >the end of the scatter-gather list). > >> > > >> > Indeed. Ming Lei, shoul

[PATCH 11/11] staging: usbip: Increment version to 1.2.0

Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace/configure.ac index 099d24b..0b0e035 1006

[PATCH 10/11] staging: usbip: Separate protocol/program version

Not all new program versions necessarily introduce non-backwards-compatible protocol changes. We thus move the definition of the protocol version from configure.ac to usbip_network.h, where it logically belongs to. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/u

[PATCH 09/11] staging: usbip: Improve debug output

For IPv6, IP:Port is unreadable. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/usbipd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/src/usbipd.c b/drivers/staging/usbip/userspace/src/us

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

On Wed, 11 Sep 2013, Takashi Iwai wrote: > At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), > Alan Stern wrote: > > > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > > > mysterious wakeups after shutdown occasionally. After disc

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

On Wed, 11 Sep 2013, Takashi Iwai wrote: > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > mysterious wakeups after shutdown occasionally. After discussing with > BIOS engineers, they explained that the new BIOS expects that the > wakeup sources are cleared and set to D3 for

Re: usbnet transmit path problems

On Wed, Sep 11, 2013 at 8:56 PM, David Laight wrote: >> > > 2) If 'length % dev->maxpacket == 0' for a multi-fragment packet then >> > >the extra byte isn't added correctly (the code probably falls off >> > >the end of the scatter-gather list). >> > >> > Indeed. Ming Lei, should usbnet han

Re: [PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

At Wed, 11 Sep 2013 10:54:40 -0400 (EDT), Alan Stern wrote: > > On Wed, 11 Sep 2013, Takashi Iwai wrote: > > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > > mysterious wakeups after shutdown occasionally. After discussing with > > BIOS engineers, they explained that the

Re: [alsa-devel] alsa crash with “ ALSA sound/usb/urb.c:179 cannot submit urb (err = -27)” on imx6q sabrelite

On Wed, 11 Sep 2013, Daniel Mack wrote: > On 11.09.2013 14:53, Ankit Agarwal wrote: > > > > On Sun, Sep 8, 2013 at 8:27 PM, Daniel Mack > > wrote: > > > > On 02.09.2013 12:51, Ankit Agarwal wrote: > > > I am using alsa pcm player to listen to audio. The alsa pcm

Re: FUSB200 xhci issue

On Wed, 11 Sep 2013, Oleksij Rempel wrote: > >> Same issue on two different intel controllers. I'll try some thing > >> different for comparison. > > > > Don't try different hardware. Try submitting multiple URBs. > > Suddenly i can't submit multiple urbs, we have lots of read->write > operatio

Re: [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd

On Tue, 10 Sep 2013, Lucas De Marchi wrote: > >>> > The ordering is more of a recommendation than a necessity. Systems > >>> > should work oksy if the modules are loaded in the wrong order. > >>> > > >>> > The only issue if the drivers are loaded in the wrong order is that > >>> > full- and low-s

Re: [alsa-devel] alsa crash with “ ALSA sound/usb/urb.c:179 cannot submit urb (err = -27)” on imx6q sabrelite

On 11.09.2013 14:53, Ankit Agarwal wrote: > > On Sun, Sep 8, 2013 at 8:27 PM, Daniel Mack > wrote: > > On 02.09.2013 12:51, Ankit Agarwal wrote: > > I am using alsa pcm player to listen to audio. The alsa pcm > crashes with > > the error: ALSA sound/usb/u

Re: [PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

> > I need 115200, since that is what most of my development systems use > > for the serial console. Will the normal path, tty_get_baud_rate(tty), > > handle baud rates above 57600? > > Yes, cfsetospeed can be used up to 4Mbaud for example. > > > The hardware is also capable of "custom divisor" a

[PATCH] xhci: Fix spurious wakeups after S5 on Haswell (v3)

Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show mysterious wakeups after shutdown occasionally. After discussing with BIOS engineers, they explained that the new BIOS expects that the wakeup sources are cleared and set to D3 for all wakeup devices when the system is going to sle

Re: [PATCH v2] xhci: Fix spurious wakeups after S5 on Haswell

At Tue, 10 Sep 2013 17:48:37 +0200, Takashi Iwai wrote: > > At Tue, 10 Sep 2013 08:38:50 -0700, > Sarah Sharp wrote: > > > > On Tue, Sep 10, 2013 at 08:24:51AM +0200, Takashi Iwai wrote: > > > Haswell LynxPoint and LynxPoint-LP with the recent Intel BIOS show > > > mysterious wakeups after shutdo

Re: Introducing libgadget 0.0.1

On 09/11/2013 03:42 AM, Jan Engelhardt wrote: On Wednesday 2013-09-04 19:25, Matt Porter wrote: With the move to configfs for creation of arbitrary USB composite gadgets, I found myself wanting a simple C library to configure and parse gadgets in a system. It has no other dependencies other tha

Re: [PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

On Tue, Sep 10, 2013 at 07:24:35PM +0200, Andrew Lunn wrote: > Hi Johan > > Thanks for your quick comments. I hopefully have more time to work on > this code now, so v3 will not take as long as v2 did. Great. It shouldn't be that much more work. > > > +/* This structure holds all of the local p

MUSB: Problem limiting otg host to FullSpeed mode

Hello! We are currently evaluating if it would be possible to limit the USB Speed of the MUSB controller of an TI-OMAP 4430 in host mode to FullSpeed mode. Hardware: CPU: TI-OMAP 4430 Board: Pandaboard A5 Kernel: 3.9.11 Unfortunately I currently face some problems. I tried to mask out 'MUSB_

Re: [PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

Dear Peter Chen, > On Tue, Sep 10, 2013 at 10:18:04AM +0200, Marek Vasut wrote: > > Dear Peter Chen, > > > > > On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote: > > > > Dear Peter Chen, > > > > > > Please see my commit log, the mx6sl-phy has some improvements compared > > > to mx6q-ph

Re: Introducing libgadget 0.0.1

On Wednesday 2013-09-04 19:25, Matt Porter wrote: >With the move to configfs for creation of arbitrary USB composite gadgets, >I found myself wanting a simple C library to configure and parse gadgets >in a system. It has no other dependencies other than libc itself. > >It can be found at: > >

Re: FUSB200 xhci issue

Am 07.09.2013 03:38, schrieb Alan Stern: On Fri, 6 Sep 2013, Oleksij Rempel wrote: Am 06.09.2013 23:09, schrieb Alan Stern: On Fri, 6 Sep 2013, Oleksij Rempel wrote: Hi Alan, i need more help. We have more test results now. Initial patch was probably fixing fallowing issue - bad performanc

Re: [PATCH] usb: gadget: use usb_composite_dev for usb_function_{de}activate

Hi Felipe, On Tue, Sep 10, 2013 at 04:19:40PM +0200, Michael Grzeschik wrote: > usb_function_{de}activate makes it possible to have several "gadget > functions", inside one composite device, to be able to prevent the gadget > to enumerate until an prepared condition has triggered (i.e. userspace >