From: Enrico Mioso mrkiko...@gmail.com
This driver supports devices using the NCM protocol as an encapsulation layer
for other protocols, like the E3131 Huawei 3G modem. This drivers approach was
heavily inspired by the qmi_wwan/cdc_mbim approach code model.
Signed-off-by: Enrico Mioso
Enrico has been kind enough to let me repost his driver with the changes
requested by Oliver Neukum during the last review of this series.
The changes I have made from Enricos original v5 series to this version
are:
v6:
- fix to avoid corrupting drvstate-pmcount
- fix error return value from
From: Enrico Mioso mrkiko...@gmail.com
Remove device IDs of NCM-like (but not NCM-conformant) devices, that are
handled by the huawwei_cdc_ncm driver now.
Signed-off-by: Enrico Mioso mrkiko...@gmail.com
Signed-off-by: Bjørn Mork bj...@mork.no
---
drivers/net/usb/cdc_ncm.c | 11 ---
1
From: Enrico Mioso mrkiko...@gmail.com
Some drivers implementing NCM-like protocols, may re-use those functions, as is
the case in the huawei_cdc_ncm driver.
Export them via EXPORT_SYMBOL_GPL, in accordance with how other functions have
been exported.
Signed-off-by: Enrico Mioso
Joe Perches j...@perches.com writes:
You did most all the multi-line statement
alignment perfectly but missed a couple.
Damn! OK, that will teach me to do checkpatch --strict before
submitting.
Maybe in a follow-on patch.
Yes, I'll fix this when I get around to the next series for this
This patch removes dependency on Freescale USB UTG Transceiver
driver and makes OTG FSM implementation selectable.
Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com
---
drivers/usb/phy/Kconfig | 10 +-
drivers/usb/phy/Makefile |4 ++--
2 files changed, 11 insertions(+), 3
OTG Final State Machine calls functions which may sleep.
For example, start_gadget callback implementation can use
usb_gadget_vbus_connect(), whose context: can sleep.
If so, mutex should be used instead of spinlock.
Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com
---
Other USB drivers may want to use OTG final state machine
implementation, so make this header available for them.
Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com
---
drivers/usb/phy/phy-fsl-usb.h |1 -
drivers/usb/phy/phy-fsm-usb.c |2 -
drivers/usb/phy/phy-fsm-usb.h | 236
On Fri, 2013-11-01 at 12:35 +0100, Bjørn Mork wrote:
So I believe we should do the update unconditionally, and but skip
usb_autopm_put_interface if the get failed. Accordingly, these
functions should always return 0 (not that there is anything currently
checking the return anyway).
I'll
On Sun, Nov 03, 2013 at 11:09:50PM +0100, Colin Leitner wrote:
This patch fixes the CS5 setting on the PL2303 USB-to-serial devices. CS5 has
a
value of 0 and the CSIZE setting has been skipped altogether by the enclosing
if. Tested on 3.11.6 and the scope shows the correct output after the
Hi Kishon,
From: Kishon Vijay Abraham I [mailto:kis...@ti.com]
Sent: Monday, November 04, 2013 7:55 AM
Hi Vivek,
On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
The new driver uses the generic PHY framework and
Replace the array of pointers to transfer descriptors with
the transfer descriptors themselves.
This saves a kzalloc() call on every transfer and some memory
indirections.
The only possible downside is for isochronous tranfers with 64 td
when the allocate is 8+4096 bytes (on 64bit systems) so
In many cases the constant 1 is used for values that eventually
get written to the hardware ring. Replace all of these with the
symbolic constant TRB_CYCLE.
This makes it clear that the ring-cycle_state value is used when
writing to the actual ring itself.
Always use ^= TRB_CYCLE to invert the
If there are setup requests not directed to an endpont or an interface,
current config's setup() has been attempted so far.
This patch, in case the above fails, adds code which tries the setup() of
configuration's function if there is only one function in the configuration.
This behavior is
Add support for using the loopback USB function in gadgets composed with
configfs.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../ABI/testing/configfs-usb-gadget-loopback |8 ++
drivers/usb/gadget/Kconfig
alloc_ep_req() is a function repeated in several modules.
Make a common implementation and use it.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/f_hid.c
Add support for using the sourcesink function in gadgets composed with
configfs.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../ABI/testing/configfs-usb-gadget-sourcesink | 12 +
drivers/usb/gadget/Kconfig
This series aims at integrating configfs into gadget zero, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet,
mass_storage and FunctionFS. It contains everything that is required to provide
the
equivalent of g_zero.ko with configfs.
BACKWARD COMPATIBILITY
Hi Matt,
Thank you for the library:
http://thread.gmane.org/gmane.linux.kernel/1556137
I'd like to make some comments you might want to consider.
I don't like too much the idea of hardcoding the set of available functions.
When new functions' conversions to use configfs are available (or
Hi, greg
I have used the minicom program which calls the open system call in
blocking mode to access the usb device, and it seems there is no
problem with it. So, the only thing I can suspect is that there is a
bug in open system call implementation. Do you know which directory
containing the
Hi Kishon,
On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote:
Hi Vivek,
On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
The new driver uses the generic PHY framework and will interact
with DWC3
Hi,
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, October 31, 2013 4:23 PM
To: Krzysztof Opasiak
Cc: ba...@ti.com; linux-usb@vger.kernel.org; 'Matt Porter'
Subject: Re: Gadget tool proposition
Hi,
On Thu, Oct 31, 2013 at 01:35:45PM +0100,
Hi,
-Original Message-
From: 'Matt Porter' [mailto:matt.por...@linaro.org]
Sent: Saturday, November 02, 2013 6:59 PM
To: Krzysztof Opasiak
Cc: ba...@ti.com; linux-usb@vger.kernel.org
Subject: Re: Gadget tool proposition
On Thu, Oct 31, 2013 at 01:35:45PM +0100, Krzysztof Opasiak
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Nov 04, 2013 at 07:58:42PM +0800, ys6 land wrote:
Hi, greg
I have used the minicom program which calls the open system call in
blocking mode to access the usb device, and it seems there
Legacy gadgets supporting mass storage (g_mass_storage, g_acm_ms, g_multi)
all depend on BLOCK.
Make the standalone compilation of f_mass_storage (without any legacy
gadget) dependent no BLOCK, too.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park
Interface 1 on this device isn't for option to bind to otherwise an oops
on usb_wwan with log flooding will happen:
tty_release: ttyUSB1: read/write wait queue active!
And it doesn't seem to respond to QMI if it's added to qmi_wwan so don't
add it there.
Signed-off-by: Gustavo Zacarias
Hi guys,
This is my first post to this list, so let me quickly introduce myself.
I'm a software engineer for Ettus Research (National Instruments).
One of our new products [1] is a USB 3.0 (using Cypress FX3) based SDR
that currently ships
with a libusb based open source driver integrated in our
On Monday 04 November 2013 05:56 PM, Tomasz Figa wrote:
Hi Kishon,
On Monday 04 of November 2013 12:24:42 Kishon Vijay Abraham I wrote:
Hi Vivek,
On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
The new driver uses the
Hi,
On Monday 04 November 2013 03:45 PM, Kamil Debski wrote:
Hi Kishon,
From: Kishon Vijay Abraham I [mailto:kis...@ti.com]
Sent: Monday, November 04, 2013 7:55 AM
Hi Vivek,
On Thursday 31 October 2013 01:15 PM, Vivek Gautam wrote:
Add a new driver for the USB 3.0 PHY on Exynos5 series of
In Test 10 of usbtest module, it queues multiple control messages and
thereby tests control message queuing, protocol stalls, short reads, and
fault handling. And this patch add a test case to support queue BOS control
request for USB 3.0 SPEC.
Signed-off-by: Huang Rui ray.hu...@amd.com
---
Hi,
-Original Message-
From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com]
Sent: Monday, November 04, 2013 12:52 PM
To: matt.por...@linaro.org
Cc: jeng...@inai.de; linux-usb@vger.kernel.org; Marek Szyprowski;
kyungmin.p...@samsung.com; Krzysztof Opasiak
Subject: about
On 18/10/2013 21:26, Boris BREZILLON :
The AT91 PMC (Power Management Controller) provides a USB clock used by
the different USB controllers (ehci, ohci and udc).
The atmel-ehci driver must configure the usb clock rate to 48Mhz in order
to get a fully functionnal USB host controller.
This
Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf
Signed-off-by: Stanislaw Wadas s.wa...@samsung.com
---
src/gadget.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/gadget.c b/src/gadget.c
index faed675..ff4f3d5 100644
--- a/src/gadget.c
+++
In reference to the message sent by Andrzej Pietrasiewicz
(about libusbg (formerly libgadget)) I would like to propose
some changes to libusbg.
Best Regards
Stanislaw Wadas
Samsung RD Institute Poland
Samsung Electronics
s.wa...@samsung.com
--
To unsubscribe from this list: send the line
mkdir() function are now called after successfull function
creation.
Added inline to gadget_write_string().
256 hard coded value has been replaced by two defined
constants MAX_LENGHT and MAX_PATH_LENGHT
Change-Id: Ifcfaf9cf95da6558c176ce3367cd553cea54e871
Signed-off-by: Stanislaw Wadas
W dniu 04.11.2013 14:55, Stanislaw Wadas pisze:
mkdir() function are now called after successfull function
creation.
Added inline to gadget_write_string().
256 hard coded value has been replaced by two defined
constants MAX_LENGHT and MAX_PATH_LENGHT
LENGHT - LENGTH
Change-Id:
On Sat, 2013-11-02 at 19:17 +0530, Govindarajulu Varadarajan wrote:
Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com
[]
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
@@ -3719,7 +3719,7 @@ sub process {
# check for needless if (foo) fn(foo) uses
On Mon, Nov 4, 2013 at 2:21 PM, Greg KH gre...@linuxfoundation.org wrote:
Where specifically in the kernel? Busywaiting for data transferrs to
complete, or doing something else? Are you keeping the pipeline full to
the device? You should be able to hit USB line speed from userspace
if you
On Sun, 3 Nov 2013, Peter Chen wrote:
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index a06d501..bf405fd 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -139,6 +139,7 @@ static int usb_hcd_fsl_probe(const struct hc_driver
On Mon, 4 Nov 2013, Luke-Jr wrote:
On Tuesday, October 29, 2013 2:39:14 PM Alan Stern wrote:
On Mon, 28 Oct 2013, Luke-Jr wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=63961
Kernel version 3.10.15
[1774470.503558] hub 2-1.3:1.0: hub_port_status failed (err = -71)
mkdir() function are now called after successfull function
creation.
Added inline to gadget_write_string().
256 hard coded value has been replaced by two defined
constants MAX_LENGTH and MAX_PATH_LENGTH
Change-Id: Ifcfaf9cf95da6558c176ce3367cd553cea54e871
Signed-off-by: Stanislaw Wadas
Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf
Signed-off-by: Stanislaw Wadas s.wa...@samsung.com
---
src/gadget.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/gadget.c b/src/gadget.c
index faed675..ff4f3d5 100644
--- a/src/gadget.c
+++
On 04.11.2013 15:10, Andrzej Pietrasiewicz wrote:
W dniu 04.11.2013 14:55, Stanislaw Wadas pisze:
mkdir() function are now called after successfull function
creation.
Added inline to gadget_write_string().
256 hard coded value has been replaced by two defined
constants MAX_LENGHT and
On Mon, 4 Nov 2013, Moritz Fischer wrote:
Hi guys,
This is my first post to this list, so let me quickly introduce myself.
I'm a software engineer for Ettus Research (National Instruments).
One of our new products [1] is a USB 3.0 (using Cypress FX3) based SDR
that currently ships
with
On Monday, November 04, 2013 3:07:18 PM Alan Stern wrote:
On Mon, 4 Nov 2013, Luke-Jr wrote:
On Tuesday, October 29, 2013 2:39:14 PM Alan Stern wrote:
On Mon, 28 Oct 2013, Luke-Jr wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=63961
Kernel version 3.10.15
Updating the TRB_CYCLE bit in the first trb has to be done after all the
subsequent
trb have been written. The code to do this was overly complicated.
When initially writing the start_trb invert its TRB_CYCLE bit.
In giveback_first_trb() invert the TRB_CYCLE bit again.
Tested with a USB
On Fri, Nov 1, 2013 at 5:04 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 1 Nov 2013, Cliff Brake wrote:
On Thu, Oct 31, 2013 at 2:25 PM, Alan Stern st...@rowland.harvard.edu
wrote:
What host controller driver are you using?
Its the USB EHCI host in the TI DM3730, so it uses
On Mon, 4 Nov 2013, Luke-Jr wrote:
Perhaps I phrased that wrong: I suspect this is a hardware issue or firmware
bug, triggering bad error handling in Linux. After upgrading to 3.12, Linux
indeed survives the hub being plugged in, and the hub is usable, but I still
see various errors in
On Mon, Nov 04, 2013 at 04:09:39PM +0100, Stanislaw Wadas wrote:
Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf
Signed-off-by: Stanislaw Wadas s.wa...@samsung.com
Need a commit log entry for this one.
Can you please follow kernel conventions when posting/reposting?
Submit the updated
On Monday, November 04, 2013 4:22:04 PM Alan Stern wrote:
On Mon, 4 Nov 2013, Luke-Jr wrote:
Perhaps I phrased that wrong: I suspect this is a hardware issue or
firmware bug, triggering bad error handling in Linux. After upgrading to
3.12, Linux indeed survives the hub being plugged in, and
On Mon, Nov 04, 2013 at 02:55:46PM +0100, Stanislaw Wadas wrote:
In reference to the message sent by Andrzej Pietrasiewicz
(about libusbg (formerly libgadget)) I would like to propose
some changes to libusbg.
Along the lines in my other reply, it would be preferred if you could
send this type
Mass storage gadget returns DELAYED_STATUS in stead of
USB_GADGET_DELAYED_STATUS while handling bulk reset request. Since
peripheral driver uses USB_GADGET_DELAYED_STATUS for delayed status
handling, therefore replace DELAYED_STATUS by USB_GADGET_DELAYED_STATUS
in mass storage driver.
Since,
Hi
I'm attaching dmesg with old_scheme_first=1 and
CONFIG_USB_STORAGE_DEBUG enabled. I compiled code with
old_scheme_first set to 1. I see that it doesn't do get descriptor
early in the loop so it doesn't run into khubd time out. But as I
mentioned earlier usb-storage runs into some sort of error
On Mon, 4 Nov 2013, Cliff Brake wrote:
As far as I can tell, the big blockage occurs when the machine has to
analyze an input report from which it extracts 767 fields and ends up
calling hid_process_event about 2300 times. Since each call takes
around 60-80 microseconds, you end up with
On Sat, Nov 02, 2013 at 04:18:05AM +0800, Paul Zimmerman wrote:
From: Alan Stern
Sent: Friday, November 01, 2013 7:09 AM
Now DELAYED_STATUS isn't used anywhere. You should add the following
hunk to this patch:
Index: usb-3.12/drivers/usb/gadget/storage_common.c
2013/11/4 Stanislaw Wadas:
@@ -127,6 +132,7 @@ static void gadget_write_buf(char *path, char *name, char
*file, char *buf)
{
char p[MAX_LENGHT];
FILE *fp;
+ int ret;
this new variable isn't used in the hunk that follows:
sprintf(p, %s/%s/%s, path, name,
On 10/30/2013 03:38 PM, Bin Liu wrote:
Only start the otg_timer in dual role mode; otherwise in peripheral mode
when musb is disconnected from the host port, otg_timer starts and
continuously toggles the session, which causes VBUS pulse.
Hmm. Okay, so one piece of the pulsing should be gone
On Mon, 4 Nov 2013, Luke-Jr wrote:
On Monday, November 04, 2013 4:22:04 PM Alan Stern wrote:
On Mon, 4 Nov 2013, Luke-Jr wrote:
Perhaps I phrased that wrong: I suspect this is a hardware issue or
firmware bug, triggering bad error handling in Linux. After upgrading to
3.12, Linux
On Mon, 4 Nov 2013, Prasad Koya wrote:
Hi
I'm attaching dmesg with old_scheme_first=1 and
CONFIG_USB_STORAGE_DEBUG enabled. I compiled code with
old_scheme_first set to 1. I see that it doesn't do get descriptor
early in the loop so it doesn't run into khubd time out. But as I
mentioned
On Mon, 4 Nov 2013, Alan Stern wrote:
On Mon, 4 Nov 2013, Prasad Koya wrote:
Hi
I'm attaching dmesg with old_scheme_first=1 and
CONFIG_USB_STORAGE_DEBUG enabled. I compiled code with
old_scheme_first set to 1. I see that it doesn't do get descriptor
early in the loop so it doesn't
* Dirk Gouders | 2013-11-01 00:39:46 [+0100]:
This patch sets choice_values' visibility that depend on symbols set
to 'm' to 'n' if the corresponding choice is set to 'y'. This makes
them disappear from the choice list and will also cause the
choice_values' value set to 'n' in sym_calc_value()
Sebastian,
On Mon, Nov 4, 2013 at 11:13 AM, Sebastian Andrzej Siewior
bige...@linutronix.de wrote:
On 10/30/2013 03:38 PM, Bin Liu wrote:
Only start the otg_timer in dual role mode; otherwise in peripheral mode
when musb is disconnected from the host port, otg_timer starts and
continuously
Sebastian,
On Mon, Nov 4, 2013 at 11:40 AM, Bin Liu binml...@gmail.com wrote:
Sebastian,
On Mon, Nov 4, 2013 at 11:13 AM, Sebastian Andrzej Siewior
bige...@linutronix.de wrote:
On 10/30/2013 03:38 PM, Bin Liu wrote:
Only start the otg_timer in dual role mode; otherwise in peripheral mode
On 11/04/2013 06:43 PM, Bin Liu wrote:
Sebastian,
Hi Bin,
Sorry, please ignore my message above. I misinterpreted your response.
Yeah, probably not easy to get rid of starting otg_timer in
dsps_interrupt(), otg mode still needs it.
Yes. It may work with the try_idle() thingy that we have in
This patch fixes the CS5 setting on the PL2303 USB-to-serial devices. CS5 has a
value of 0 and the CSIZE setting has been skipped altogether by the enclosing
if. Tested on 3.11.6 and the scope shows the correct output after the fix has
been applied.
Tagged to be added to stable, because it fixes
Hello.
On 11/04/2013 04:01 PM, Gustavo Zacarias wrote:
Interface 1 on this device isn't for option to bind to otherwise an oops
on usb_wwan with log flooding will happen:
tty_release: ttyUSB1: read/write wait queue active!
And it doesn't seem to respond to QMI if it's added to qmi_wwan
Hello.
On 11/04/2013 04:55 PM, Stanislaw Wadas wrote:
Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf
This line shouldn't be present in the upstream patches.
Signed-off-by: Stanislaw Wadas s.wa...@samsung.com
---
src/gadget.c | 12 +++-
1 file changed, 11
On Mon, Nov 04, 2013 at 07:40:43PM +0100, Colin Leitner wrote:
This patch fixes the CS5 setting on the PL2303 USB-to-serial devices. CS5 has
a
value of 0 and the CSIZE setting has been skipped altogether by the enclosing
if. Tested on 3.11.6 and the scope shows the correct output after the
From: Govindarajulu Varadarajan govindarajul...@gmail.com
Date: Sat, 2 Nov 2013 19:17:43 +0530
@@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int
csr0)
}
#ifdef XMT_VIA_SKB
- if(p-tmd_skb[p-tmdlast]) {
-
On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote:
This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf.
It's not easy to create a driver for all the various firmware
bugs out there.
This change caused regressions for a number of devices, which
started to fail link detection and
Sebastian, All,
On 2013-11-04 18:27 +0100, Sebastian Andrzej Siewior spake thusly:
* Dirk Gouders | 2013-11-01 00:39:46 [+0100]:
This patch sets choice_values' visibility that depend on symbols set
to 'm' to 'n' if the corresponding choice is set to 'y'. This makes
them disappear from the
From: Bjørn Mork bj...@mork.no
Date: Fri, 1 Nov 2013 14:18:51 +0100
This series fixes three problems Oliver pointed out during the
review of the new huawei_cdc_ncm driver:
http://patchwork.ozlabs.org/patch/278903/
That innocent driver only used cdc_mbim as a blueprint, and
all the blame
From: hayeswang hayesw...@realtek.com
Date: Thu, 31 Oct 2013 13:52:38 +0800
From: David Miller [mailto:da...@davemloft.net]
Sent: Thursday, October 31, 2013 5:05 AM
From: Hayes Wang hayesw...@realtek.com
Date: Wed, 30 Oct 2013 15:13:39 +0800
[...]
Basically, your driver will now queue up
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote:
This is required in order to integrate configfs support.
f_fs needs to be a separately compiled module and so it needs to use the new
interface.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote:
Prepare for configfs integration. Use the new interface so that f_fs can be
made a module.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote:
There are no old function interface users left, so the old interface can
be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote:
Add support for using FunctionFS in configfs-based USB gadgets.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
--
Best regards,
On Mon, Nov 04, 2013 at 02:55:48PM +0100, Stanislaw Wadas wrote:
Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf
Signed-off-by: Stanislaw Wadas s.wa...@samsung.com
---
src/gadget.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/gadget.c
This patch moves all bitflags to the end of usb_gadget struct in order
to improve readability.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
include/linux/usb/gadget.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
Due to USB controllers may have different restrictions, usb gadget layer
needs to provide a generic way to inform gadget functions to complain
with non-standard requirements.
This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
to inform when controller's epout requires buffer
DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
This patch adds necessary quirk for it.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs
to pad epout buffer to match above condition if quirk is found.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/gadget/f_fs.c
Hi,
These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to adapt gadget functions to their
non-standard restrictions.
This change is necessary to make
DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
This patch sets necessary quirk for it.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
Changes from v4 to v4.1:
- just updated patch's subject. No actual code changed.
drivers/usb/dwc3/gadget.c | 6 ++
1
On Mon, Nov 4, 2013 at 11:51 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 4 Nov 2013, Cliff Brake wrote:
We have the same system running on a older PXA270 version of the
product (vs the current TI DM3730). It has an older OHCI 12Mbit USB
host controller (vs the current TI EHCI
Hi Felipe Shawn,
The serial adds power management support for MXS PHY, it includes:
- Add three common PHY APIs, .set_wakeup, .notify_suspend, notify_resume.
- Related above API implementation at mxs phy driver
- misc changes for mxs phy to support low power mode and wakeup.
My github tree:
Some PHY bugs are fixed by IC logic, but these bits are not
enabled by default, so we enable them at driver.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 32 ++--
1 files changed, 30 insertions(+), 2 deletions(-)
diff --git
The mxs-phy has several bugs and features at different
versions, the driver code can get it through of_device_id.data.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 59 ++--
1 files changed, 50 insertions(+), 9
Add anatop phandle which is used to access anatop registers to
control PHY's power and other USB operations.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
It is needed by imx6 SoC serial, but not for imx23 and imx28.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
Implementation of notify_suspend and notify_resume will be different
according to mxs_phy_platform_flag-flags.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 54 +---
1 files changed, 50 insertions(+), 4 deletions(-)
When we need the PHY can be waken up by external signals,
we can call this API. Besides, we call mxs_phy_disconnect_line
at this API to close the connection between USB PHY and
controller, after that, the line state from controller is SE0.
Once the PHY is out of power, without calling
Add anatop phandle for usbphy
Signed-off-by: Peter Chen peter.c...@freescale.com
---
arch/arm/boot/dts/imx6qdl.dtsi |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 226ce75..bb79678 100644
---
We need this to keep PHY's power on or off during the system
suspend mode. If we need to enable USB wakeup, then we
must keep PHY's power being on during the system suspend mode.
Otherwise, we need to keep PHY's power being off to save power.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
With the auto setting, the PHY's clock and power can be
recovered correctly from low power mode, it is ganranteed by IC logic.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/phy/phy-mxs-usb.c | 20 +---
1 files changed, 17 insertions(+), 3 deletions(-)
diff
This API is used to set wakeup enable at PHY registers, in that
case, the PHY can be waken up from suspend due to external events,
like vbus change, dp/dm change and id change.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
include/linux/usb/phy.h | 16
1 files
Hi Greg,
This serial adds power management (system runtime) for chipidea core.
With this, the chipidea controller can be at low power mode when it is not in
use, and the chipidea controller can be the system wakeup source.
It needs to depend on my patch[1], since [1]-Add power management support
Currently, only imx6q adds wakeup logic, so only enable
runtime pm for imx6q.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci_hdrc_imx.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
- Disable wakeup after probe
- Enable wakeup during the suspend
- Disable wakeup after controller is active
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci_hdrc_imx.c | 36
1 files changed, 36 insertions(+), 0 deletions(-)
Add system and runtime power management support for imx gluy layer.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci_hdrc_imx.c | 94 ++-
1 files changed, 91 insertions(+), 3 deletions(-)
diff --git
1 - 100 of 127 matches
Mail list logo
