RE: [PATCH v2 2/4] usb: renesas_usbhs: gadget: fix the behavior of pullup

2014-10-30 Thread yoshihiro shimoda
Hi Morimoto-san, Hi shimoda-san From: Takeshi Kihara takeshi.kihara...@renesas.com This patch fixes an issue that this driver always enable the D+ pullup after it detected the VBUS connection even though this usb controller can control the D+ pullup timing by software. So, this

Re: [PATCH v3] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Johan Hovold
On Wed, Oct 29, 2014 at 08:53:14PM -0400, Jim Paris wrote: The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com ---

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-30 Thread Oliver Neukum
On Thu, 2014-10-30 at 02:19 +0100, Peter Stuge wrote: Oliver Neukum wrote: Then I guess I'll take no further action in kernel space. I for one would like the kernel messages to be less prominent, if they stay at all. I am removing them. Regards Oliver -- To

Re: [PATCH] USB: cdc-acm: only raise DTR on transitions from B0

2014-10-30 Thread Oliver Neukum
On Wed, 2014-10-29 at 16:58 +0100, Johan Hovold wrote: On Wed, Oct 29, 2014 at 11:56:02PM +0800, Greg Kroah-Hartman wrote: This should go to older kernels as well, right? Yes, if you want. It's fixing handling of B0, but I doubt many people care (hence the missing stable tag). Note that

Re: dogfooding fedora 21 - usb printers mtp devices

2014-10-30 Thread Hans de Goede
Hi, On 10/29/2014 11:32 PM, Alon Levy wrote: Hey, how are you? have you noticed problems with $SUBJECT? I have a continuously disconnecting printer. Using XHCI (T440p) getting a repeat of: [105574.775812] usblp 3-6:1.0: usblp0: USB Bidirectional printer dev 27 if 0 alt 0 proto 2 vid 0x03F0

[PATCH v4 19/20] usb: dwc3: add support for AMD Nolan platform

2014-10-30 Thread Huang Rui
This patch adds support for AMD Nolan (NL) FPGA and SoC platform. Cc: Jason Chang jason.ch...@amd.com Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/dwc3-pci.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-pci.c

[PATCH v4 18/20] PCI: Prevent xHCI driver from claiming AMD Nolan USB3 DRD device

2014-10-30 Thread Huang Rui
The AMD Nolan (NL) SoC contains a DesignWare USB3 Dual-Role Device that can be operated either as a USB Host or a USB Device. In the AMD NL platform, this device ([1022:7912]) has a class code of PCI_CLASS_SERIAL_USB_XHCI (0x0c0330), which means the xhci driver will claim it. But the dwc3 driver

[PATCH v4 17/20] PCI: Add support for AMD Nolan USB3 DRD

2014-10-30 Thread Huang Rui
This patch adds PCI id for USB3 Dual-Role Device of AMD Nolan (NL) SoC. It will be used for PCI quirks and DWC3 device driver. Signed-off-by: Jason Chang jason.ch...@amd.com Signed-off-by: Huang Rui ray.hu...@amd.com Acked-by: Bjorn Helgaas bhelg...@google.com --- include/linux/pci_ids.h | 1 +

[PATCH v4 20/20] usb: dwc3: make HIRD threshold configurable

2014-10-30 Thread Huang Rui
HIRD threshold should be configurable by different platforms. From DesignWare databook: When HIRD_Threshold[4] is set to 1b1 and HIRD value is greater than or equal to the value in HIRD_Threshold[3:0], dwc3 asserts output signals utmi_l1_suspend_n to put PHY into Deep Low-Power mode in L1. When

[PATCH v4 16/20] usb: dwc3: add disable usb2 suspend phy quirk

2014-10-30 Thread Huang Rui
This patch adds disable usb2 suspend phy quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui ray.hu...@amd.com --- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + drivers/usb/dwc3/core.c| 7 +++ drivers/usb/dwc3/core.h

[PATCH v4 13/20] usb: dwc3: set SUSPHY bit for all cores

2014-10-30 Thread Huang Rui
It is recommended to set USB3 and USB2 SUSPHY bits to '1' after the core initialization is completed above the dwc3 revision 1.94a. Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/core.c | 24 1 file changed, 24

[PATCH v4 14/20] usb: dwc3: add Tx de-emphasis quirk

2014-10-30 Thread Huang Rui
This patch adds Tx de-emphasis quirk, and the Tx de-emphasis value is configurable according to PIPE3 specification. Value Description 0 -6dB de-emphasis 1 -3.5dB de-emphasis 2 No de-emphasis 3 Reserved It can be configured on DT

[PATCH v4 10/20] usb: dwc3: add delay phy power change quirk

2014-10-30 Thread Huang Rui
This patch adds delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by:

[PATCH v4 07/20] usb: dwc3: add P3 in U2 SS Inactive quirk

2014-10-30 Thread Huang Rui
This patch adds P3 in U2 SS Inactive quirk, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v4 11/20] usb: dwc3: add LFPS filter quirk

2014-10-30 Thread Huang Rui
This patch adds LFPS filter quirk, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com --- Documentation/devicetree/bindings/usb/dwc3.txt | 1

[PATCH v4 12/20] usb: dwc3: add rx_detect to polling LFPS quirk

2014-10-30 Thread Huang Rui
This patch adds RX_DETECT to Polling.LFPS control quirk, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v4 09/20] usb: dwc3: add delay P1/P2/P3 quirk

2014-10-30 Thread Huang Rui
This patch adds delay P0 to P1/P2/P3 quirk for U2/U2/U3, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v4 08/20] usb: dwc3: add request P1/P2/P3 quirk

2014-10-30 Thread Huang Rui
This patch adds request P1/P2/P3 quirk for U2/U2/U3, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v4 05/20] usb: dwc3: add lpm erratum support

2014-10-30 Thread Huang Rui
When parameter DWC_USB3_LPM_ERRATA_ENABLE is enabled in Advanced Configuration of coreConsultant, support of xHCI BESL Errata Dated 10/19/2011 is enabled in host mode. In device mode it adds the capability to send NYET response threshold based on the BESL value received in the LPM token, and the

[PATCH v4 06/20] usb: dwc3: add U2Exit LFPS quirk

2014-10-30 Thread Huang Rui
This patch adds U2Exit LFPS quirk, and some special platforms can configure that if it is needed. [ ba...@ti.com : added DeviceTree binding documentation ] Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com --- Documentation/devicetree/bindings/usb/dwc3.txt | 1

[PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Huang Rui
It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v4 04/20] usb: dwc3: add disable scramble quirk

2014-10-30 Thread Huang Rui
This patch adds disable scramble quirk, and it only needs to be enabled at FPGA board on some vendor platforms. [Note] In DesignWare databook, HW designer describes: disscramble = disable scramble Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v4 03/20] usb: dwc3: initialize platform data at pci glue layer

2014-10-30 Thread Huang Rui
This patch initializes platform data at pci glue layer, and SoCs x86-based platform vendor is able to define their flags in platform data at bus glue layer. Then do some independent behaviors at dwc3 core level. Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com

[PATCH v4 00/20] usb: dwc3: add support for AMD Nolan SoC

2014-10-30 Thread Huang Rui
Hi, The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3 OTG IP with PCI bus glue layer. This controller supported hibernation, LPM erratum and used the 2.80a IP version and amd own phy. Current implementation support both simulation and SoC platform. And already tested with

[PATCH v4 02/20] usb: dwc3: add a flag to check if it is FPGA board

2014-10-30 Thread Huang Rui
Some chip vendor is on pre-silicon phase, which needs to use the simulation board. It should have the same product and vendor id with the true SoC, but might have some minor different configurations. Below thread discussion proposes to find a method to distinguish between simulation board and

[PATCH v3 0/4] usb: renesas_usbhs: fixes this driver in gadget mode (part2)

2014-10-30 Thread Yoshihiro Shimoda
If we tested this driver as gadget, some issues below happened: - Oops happened if g_audio. - A usb enumeration may fail if we do insmod during connected the usb cable. - A transaction will not finish if g_zero. - A usb enumeration may fail after we re-connected the usb cable. This patch

[PATCH v3 2/4] usb: renesas_usbhs: gadget: fix the behavior of pullup

2014-10-30 Thread Yoshihiro Shimoda
From: Takeshi Kihara takeshi.kihara...@renesas.com This patch fixes an issue that this driver always enable the D+ pullup after it detected the VBUS connection even though this usb controller can control the D+ pullup timing by software. So, this driver should enable the D+ pullup after a gadget

[PATCH v3 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()

2014-10-30 Thread Yoshihiro Shimoda
From: Kazuya Mizuguchi kazuya.mizuguchi...@renesas.com This patch fixes an issue that the NULL pointer dereference happens when we uses g_audio driver. Since the g_audio driver will call usb_ep_disable() in afunc_set_alt() before it calls usb_ep_enable(), the uep-pipe of renesas usbhs driver will

[PATCH v3 3/4] usb: renesas_usbhs: fix the timing of dcp_control_transfer_done

2014-10-30 Thread Yoshihiro Shimoda
According to the datasheet, this driver should clear the INTSTS0.CTRT bit before this controller detects the next stage transition. Otherwise, the driver may not be able to clear the bit after the controller went to the next stage transition. After that, the driver will not be able to clear the

[PATCH v3 4/4] usb: renesas_usbhs: fix usbhs_pipe_clear() for DCP PIPE

2014-10-30 Thread Yoshihiro Shimoda
Since the DCPCTR doesn't have the ACLRM bit, the usbus_pipe_clear() should not call the usbhsp_pipectrl_set() with ACLRM. So, this patch fixes this issue to add the usbhs_fifo_clear_dcp() in fifo.c because the controller needs the CFIFO to clear the the DCP PIPE. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 18:08:26 Huang Rui wrote: It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe Balbi ba...@ti.com Something went wrong with the Signed-off-by

[PATCH 1/6] usb: chipidea: setup ci_hdrc_platform_data in core driver

2014-10-30 Thread Antoine Tenart
Hello, This series introduce the ci_hdrc_get_platdata function to help setting up the ChipIdea internal ci_hdrc_platform_data structure. This helps avoiding duplicating code. This series comes from a duscission on Berlin's USB pacthes where it was asked to move the PHY phandle handling in the

[PATCH 5/6] usb: chipidea: use ci_hdrc_get_platdata in ci_hdrc_zevio

2014-10-30 Thread Antoine Tenart
Use the newly introduced ci_hdrc_get_platdata function to help setup the chipidea internal ci_hdrc_platform_data structure. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- drivers/usb/chipidea/ci_hdrc_zevio.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[PATCH 4/6] usb: chipidea: use ci_hdrc_get_platdata in ci_hdrc_pci

2014-10-30 Thread Antoine Tenart
Use the newly introduced ci_hdrc_get_platdata function to help setup the chipidea internal ci_hdrc_platform_data structure. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- drivers/usb/chipidea/ci_hdrc_pci.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

[PATCH 1/6] usb: chipidea: add a core function to setup ci_hdrc_platform_data

2014-10-30 Thread Antoine Tenart
Add a function into the chipidea core to help drivers setup the internal ci_hdrc_platform_data structure. This helps not duplicating common code. The ci_hdrc_get_platdata function only setup non filled members of the structure so that is is possible to give an already filled one. This is what the

[PATCH 6/6] usb: chipidea: remove obsolete ci_get_platdata function

2014-10-30 Thread Antoine Tenart
The addition of the ci_hdrc_get_platdata function makes the use of ci_get_platdata obsolete. Remove it. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- drivers/usb/chipidea/core.c | 41 - 1 file changed, 41 deletions(-) diff --git

[PATCH 2/6] usb: chipidea: use ci_hdrc_get_platdata in ci_hdrc_imx

2014-10-30 Thread Antoine Tenart
Use the newly introduced ci_hdrc_get_platdata function to help setup the chipidea internal ci_hdrc_platform_data structure. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH 3/6] usb: chipidea: use ci_hdrc_get_platdata in ci_hdrc_msm

2014-10-30 Thread Antoine Tenart
Use the newly introduced ci_hdrc_get_platdata function to help setup the chipidea internal ci_hdrc_platform_data structure. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- drivers/usb/chipidea/ci_hdrc_msm.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Huang Rui
On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: On Thursday 30 October 2014 18:08:26 Huang Rui wrote: It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe

Re: [PATCH 1/6] usb: chipidea: setup ci_hdrc_platform_data in core driver

2014-10-30 Thread Antoine Tenart
On Thu, Oct 30, 2014 at 12:36:41PM +0100, Antoine Tenart wrote: Hello, This series introduce the ci_hdrc_get_platdata function to help setting up the ChipIdea internal ci_hdrc_platform_data structure. This helps avoiding duplicating code. This series comes from a duscission on Berlin's

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-30 Thread Johan Hovold
Hi Peter, Forgot to reply to this one. On Wed, Oct 22, 2014 at 07:40:20AM -0400, Peter Hurley wrote: On 10/19/2014 01:12 PM, Johan Hovold wrote: [ +CC: Jiri, Alan, linux-serial ] On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter Hurley wrote: On 10/16/2014 01:59 PM, Peter Hurley wrote:

Re: [PATCH] USB: kobil_sct: Remove unused transfer buffer allocs

2014-10-30 Thread Peter Hurley
On 10/30/2014 08:08 AM, Johan Hovold wrote: Hi Peter, Forgot to reply to this one. On Wed, Oct 22, 2014 at 07:40:20AM -0400, Peter Hurley wrote: On 10/19/2014 01:12 PM, Johan Hovold wrote: [ +CC: Jiri, Alan, linux-serial ] On Thu, Oct 16, 2014 at 02:09:29PM -0400, Peter Hurley wrote:

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 11:02:36AM -0700, Andrew Bresticker wrote: [...] Maybe something like this patch would be more correct in handling this: diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index afcb430508ec..85691a7d8ca6 100644 --- a/drivers/mailbox/mailbox.c

Re: [PATCH usb 00/32] cleanup on resource check

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 09:08:45AM +0530, Varka Bhadram wrote: On 10/30/2014 09:05 AM, Varka Bhadram wrote: Hi Balbi, On 10/30/2014 08:13 AM, Felipe Balbi wrote: Hi, On Thu, Oct 30, 2014 at 06:42:08AM +0530, Varka Bhadram wrote: On Thursday 30 October 2014 02:43 AM, Alan Stern wrote:

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] + + for (i = 0; i TEGRA_XUSB_USB3_PHYS; i++) { + if (phy == padctl-phys[TEGRA_XUSB_PADCTL_USB3_P0 + i]) +

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 09:37:14AM -0700, Andrew Bresticker wrote: On Wed, Oct 29, 2014 at 2:43 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Oct 28, 2014 at 03:27:50PM -0700, Andrew Bresticker wrote: [...] diff --git

Re: [PATCHv6 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-10-30 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 06:25:42PM -0500, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the driver data dereference code looking

Re: [PATCHv6 2/8] usb: dwc2: Move gadget probe function into platform code

2014-10-30 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 06:25:43PM -0500, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com This patch will aggregate the probing of gadget/hcd driver into platform.c. The gadget probe funtion is converted into gadget_init that is now only responsible for

Re: [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 28, 2014 at 06:25:45PM -0500, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Make dwc2_handle_common_intr call the gadget interrupt function when operating in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as

Re: [PATCHv6 5/8] usb: dwc2: Add call_gadget functions for perpheral mode interrupts

2014-10-30 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 06:25:46PM -0500, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Update the dwc2 wakeup and suspend interrupt functions to use call_gadget when the IP is in peripheral mode. it seems like you're actually fixing a bug here. Those

Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 28, 2014 at 06:25:47PM -0500, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. For dual-role

Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: On Thursday 30 October 2014 18:08:26 Huang Rui wrote: It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Huang Rui ray.hu...@amd.com Signed-off-by: Felipe

Re: [PATCH v3 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 07:30:16PM +0900, Yoshihiro Shimoda wrote: From: Kazuya Mizuguchi kazuya.mizuguchi...@renesas.com This patch fixes an issue that the NULL pointer dereference happens when we uses g_audio driver. Since the g_audio driver will call usb_ep_disable() in afunc_set_alt()

Re: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-30 Thread Felipe Balbi
On Wed, Oct 29, 2014 at 08:35:24AM -0500, Dinh Nguyen wrote: On 10/28/14, 8:26 PM, Paul Zimmerman wrote: From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] Sent: Tuesday, October 28, 2014 4:26 PM Now that platform.c will get built for both Host and Gadget,

Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Arnd Bergmann
On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: On Thursday 30 October 2014 18:08:26 Huang Rui wrote: It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi ba...@ti.com

Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 03:14:17PM +0100, Arnd Bergmann wrote: On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: On Thursday 30 October 2014 18:08:26 Huang Rui wrote: It enables hibernation if the function is set in

Re: [PATCH] USB: simple: add Google simple serial SubClass support

2014-10-30 Thread Greg Kroah-Hartman
On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote: Add support for Google devices that export simple serial interfaces using the vendor specific SubClass/Protocol pair 0x50/0x01. Signed-off-by: Anton Staaf robot...@chromium.org --- drivers/usb/serial/usb-serial-simple.c | 11

[PATCH v4] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Moved prototype. Thanks, Jim --- drivers/usb/class/cdc-acm.c | 5

Re: [PATCH v4] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Johan Hovold
On Thu, Oct 30, 2014 at 10:45:38AM -0400, Jim Paris wrote: The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com ---

[PATCH v4-real] cdc-acm: ensure that termios get set when the port is activated

2014-10-30 Thread Jim Paris
The driver wasn't properly configuring the hardware for the current termios settings under all conditions. Ensure that termios are written to the device when the port is activated. Signed-off-by: Jim Paris j...@jtan.com --- Johan Hovold wrote: On Thu, Oct 30, 2014 at 10:45:38AM -0400, Jim

Question r/e zero byte bulk transfer on musb gadget (causes kernel panic)

2014-10-30 Thread Breton M. Saunders
Hi All, I want to ask what the correct USB behavior should be for a gadget attempting to perform a zero byte transfer (note transfer, not transaction) on a bulk-in endpoint should be: Background: * Basically I've got a hacked up kernel; hardware is TI omap dm3730 (an overo gumstix

[PATCH usb v2 01/29] host: ehci-atmel: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-atmel.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH usb v2 02/29] host: ohci-da8xx: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram var...@cdac.in Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-da8xx.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH usb v2 00/29] cleanup on resource check

2014-10-30 Thread varkabhadram
From: Varka Bhadram var...@cdac.in This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git

[PATCH usb v2 04/29] host: ehci-w90x900: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-w90x900.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH usb v2 05/29] host: ohci-at91: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 11 +++ 1 file changed, 3 insertions(+), 8

[PATCH usb v2 03/29] host: ehci-tegra: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-tegra.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH usb v2 08/29] host: ohci-octeon: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-octeon.c | 12 +++- 1 file changed, 3 insertions(+), 9

[PATCH usb v2 06/29] host: ohci-exynos: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-exynos.c | 10 ++ 1 file changed, 2 insertions(+), 8

[PATCH usb v2 09/29] host: ohci-platform: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-platform.c | 13 - 1 file changed, 4 insertions(+), 9

[PATCH usb v2 07/29] host: ohci-jz4740: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-jz4740.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH usb v2 11/29] host: ehci-sh: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-sh.c | 15 +++ 1 file changed, 3 insertions(+), 12

[PATCH usb v2 12/29] host: ohci-spear: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-spear.c | 11 +++ 1 file changed, 3 insertions(+), 8

[PATCH usb v2 13/29] host: ehci-msm: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-msm.c | 10 ++ 1 file changed, 2 insertions(+), 8

[PATCH usb v2 10/29] host: ohci-pxa27x: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-pxa27x.c | 11 ++- 1 file changed, 2 insertions(+), 9

[PATCH usb v2 16/29] host: ehci-octeon: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-octeon.c | 12 +++- 1 file changed, 3 insertions(+), 9

[PATCH usb v2 19/29] host: ehci-sead3: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-sead3.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH usb v2 25/29] phy: phy-rcar-usb: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/usb/phy/phy-rcar-usb.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH usb v2 22/29] host: xhci-plat: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/xhci-plat.c | 10 -- 1 file changed, 4 insertions(+), 6

[PATCH usb v2 23/29] musb: musb_core: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/usb/musb/musb_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_core.c

[PATCH usb v2 21/29] host: uhci-platform: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Also fix in accessing NULL if resource didn't get. Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/uhci-platform.c |7

[PATCH usb v2 27/29] dwc3: dwc3-keystone: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/usb/dwc3/dwc3-keystone.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-keystone.c

[PATCH usb v2 15/29] host: ehci-mxc: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mxc.c | 11 ++- 1 file changed, 2 insertions(+), 9

[PATCH usb v2 29/29] host: ehci-exynos: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-exynos.c | 11 +++ 1 file changed, 3 insertions(+), 8

[PATCH usb v2 28/29] host: ehci-fsl: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-fsl.c | 12 +++- 1 file changed, 3 insertions(+), 9

[PATCH usb v2 24/29] musb: musb_dsps: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/usb/musb/musb_dsps.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c

[PATCH usb v2 26/29] renesas_usbhs: common: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/usb/renesas_usbhs/common.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH usb v2 20/29] host: ehci-spear: remove duplicate check on resource

2014-10-30 Thread varkabhadram
From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-spear.c |9 ++--- 1 file changed, 2 insertions(+), 7

Re: [PATCH v7 1/7] usb: move the OTG state from the USB PHY to the OTG structure

2014-10-30 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 05:35:35PM +0100, Antoine Tenart wrote: Before using the PHY framework instead of the USB PHY one, we need to move the OTG state into another place, since it won't be available when USB PHY isn't used. This patch moves the OTG state into the OTG structure, and makes all

Re: [PATCH v7 2/7] usb: rename phy to usb_phy in OTG

2014-10-30 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 05:35:36PM +0100, Antoine Tenart wrote: This patch prepares the introduction of the generic PHY support in the USB OTG common functions. The USB PHY member of the OTG structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Renaming this

Re: [PATCH v7 0/7] usb: add support for the generic PHY framework

2014-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 28, 2014 at 05:35:34PM +0100, Antoine Tenart wrote: The series can be found at: git://git.free-electrons.com:users/antoine-tenart/linux.git usb-phy Changes since v6: - rebased on top of v3.18-rc2 Changes since v5: - rebased on the latest version of Sergei's

Re: [PATCH v7 1/7] usb: move the OTG state from the USB PHY to the OTG structure

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 11:31:48AM -0500, Felipe Balbi wrote: On Tue, Oct 28, 2014 at 05:35:35PM +0100, Antoine Tenart wrote: Before using the PHY framework instead of the USB PHY one, we need to move the OTG state into another place, since it won't be available when USB PHY isn't used.

Re: [PATCH v4 20/20] usb: dwc3: make HIRD threshold configurable

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 06:08:45PM +0800, Huang Rui wrote: HIRD threshold should be configurable by different platforms. From DesignWare databook: When HIRD_Threshold[4] is set to 1b1 and HIRD value is greater than or equal to the value in HIRD_Threshold[3:0], dwc3 asserts output signals

Re: [PATCH v4 19/20] usb: dwc3: add support for AMD Nolan platform

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 06:08:44PM +0800, Huang Rui wrote: This patch adds support for AMD Nolan (NL) FPGA and SoC platform. Cc: Jason Chang jason.ch...@amd.com Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/dwc3-pci.c | 23 +++ 1 file changed, 23

Re: [PATCH v4 16/20] usb: dwc3: add disable usb2 suspend phy quirk

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 06:08:41PM +0800, Huang Rui wrote: This patch adds disable usb2 suspend phy quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui ray.hu...@amd.com --- Documentation/devicetree/bindings/usb/dwc3.txt | 1 +

Re: [PATCH v4 14/20] usb: dwc3: add Tx de-emphasis quirk

2014-10-30 Thread Felipe Balbi
On Thu, Oct 30, 2014 at 06:08:39PM +0800, Huang Rui wrote: This patch adds Tx de-emphasis quirk, and the Tx de-emphasis value is configurable according to PIPE3 specification. Value Description 0 -6dB de-emphasis 1 -3.5dB de-emphasis 2 No

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-30 Thread Andrew Bresticker
On Thu, Oct 30, 2014 at 6:22 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Oct 29, 2014 at 11:02:36AM -0700, Andrew Bresticker wrote: [...] Maybe something like this patch would be more correct in handling this: diff --git a/drivers/mailbox/mailbox.c

Re: [PATCH usb v2 19/29] host: ehci-sead3: remove duplicate check on resource

2014-10-30 Thread Sergei Shtylyov
Hello. On 10/30/2014 06:52 PM, varkabhad...@gmail.com wrote: From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu ---

Re: [PATCH usb v2 19/29] host: ehci-sead3: remove duplicate check on resource

2014-10-30 Thread Sergei Shtylyov
On 10/30/2014 08:08 PM, Sergei Shtylyov wrote: From: Varka Bhadram varkabhad...@gmail.com Sanity check on resource happening with devm_ioremap_resource(). Signed-off-by: Varka Bhadram var...@cdac.in Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-sead3.c |5

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Andrew Bresticker
On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] + + for (i = 0; i TEGRA_XUSB_USB3_PHYS;

  1   2   3   >