Re: [PATCH 1/3] USB: serial: use static attribute groups for sysfs entries

2015-02-15 Thread Takashi Iwai
At Sun, 15 Feb 2015 14:25:05 +0700, Johan Hovold wrote: On Thu, Feb 05, 2015 at 02:36:23PM +0100, Takashi Iwai wrote: static int usb_serial_device_probe(struct device *dev) { struct usb_serial_driver *driver; @@ -72,15 +79,9 @@ static int usb_serial_device_probe(struct device

Re: [PATCH 2/3] USB: serial: Handle the error from tty_register_device*()

2015-02-15 Thread Takashi Iwai
At Sun, 15 Feb 2015 14:32:39 +0700, Johan Hovold wrote: On Thu, Feb 05, 2015 at 02:36:24PM +0100, Takashi Iwai wrote: No commit message? Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/usb/serial/bus.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH 1/1] usb: common: otg-fsm: only signal connect after switching to peripheral

2015-02-15 Thread Peter Chen
We should signal connect (pull up dp) after we have already at peripheral mode, otherwise, the dp may be toggled due to we reset controller or do disconnect during the initialization for peripheral, then, the host may be confused during the enumeration, eg, it finds the reset can't succeed, but

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-15 Thread Sneeker Yeh
Hi Alan: thanks for comment it, and sorry that a little bit late for replying, 2015-02-12 23:18 GMT+08:00 Alan Stern st...@rowland.harvard.edu: On Thu, 12 Feb 2015, Mathias Nyman wrote: On 25.01.2015 10:13, Sneeker Yeh wrote: This issue is defined by a three-way race at disconnect, between

RE: Usb serial driver change question in the linux kernel

2015-02-15 Thread Li, Elvin
Hi Johan, Your patch fixed my issue. Thank you for support! Regards Elvin Li -Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Sunday, February 15, 2015 1:16 PM To: Li, Elvin Cc: linux-usb@vger.kernel.org;

Re: [PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-02-15 Thread Sneeker Yeh
hi Mathias: thanks for reviewing these patch, and sorry for replying lately~ 2015-02-12 21:50 GMT+08:00 Mathias Nyman mathias.ny...@intel.com: On 25.01.2015 10:13, Sneeker Yeh wrote: This issue is defined by a three-way race at disconnect, between 1) Class driver interrupt endpoint

[GIT PULL] USB driver patches for 3.20-rc1

2015-02-15 Thread Greg KH
The following changes since commit e36f014edff70fc02b3d3d79cead1d58f289332e: Linux 3.19-rc7 (2015-02-01 20:07:21 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.20-rc1 for you to fetch changes up to

Re: [PATCH 1/1] MAINTAINERS: add entry for USB OTG FSM

2015-02-15 Thread Greg KH
On Sun, Feb 15, 2015 at 12:22:59PM +0800, Peter Chen wrote: Add MAINTAINER entry for USB OTG Finite State Machine Cc: Felipe Balbi ba...@ti.com Signed-off-by: Peter Chen peter.c...@freescale.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS

[PATCH v3] usb: dwc2: gadget reuse ahbcfg assigned from platform

2015-02-15 Thread Zhangfei Gao
Reuse ahbcfg if assigned from platform Input from John: AHB_SINGLE, NOTI_ALL_DMA_WRIT, REM_MEM_SUPP, HBSTLEN, and INV_DESC_ENDIANNESS only apply in DMA mode and are ignored in slave mode operation. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/usb/dwc2/gadget.c | 11

Re: [possible fix] HL-340 USB don't work correctly (ch340 based usb-rs232 adapter)

2015-02-15 Thread Eddi De Pieri
Hi Karl, I don't know but as documented by usbsnoop log the value written from kernel driver make my device to fail. Windows driver after some assumption write back the original value (0xc3) Regards, Eddi On Sun, Feb 8, 2015 at 2:54 AM, Karl Palsson ka...@tweak.net.au wrote: My work in

Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-02-15 Thread Athlion
Just one more FYI, by blacklisting the ses module, the oops goes away. On Tue, Feb 3, 2015 at 6:05 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 3 Feb 2015, Athlion wrote: On Mon, Feb 2, 2015 at 7:27 PM, Alan Stern st...@rowland.harvard.edu wrote: Had you made any changes to the

[PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

2015-02-15 Thread Joseph Kogut
Moved DWC3 PCI IDS to linux/pci_ids.h per the FIXME. Signed-off-by: Joseph Kogut joseph.ko...@gmail.com --- drivers/usb/dwc3/dwc3-pci.c | 10 +- include/linux/pci_ids.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c

Re: Re: [possible fix] HL-340 USB don't work correctly (ch340 based usb-rs232 adapter)

2015-02-15 Thread Karl Palsson
Eddi De Pieri e...@depieri.net wrote: Hi Karl, I don't know but as documented by usbsnoop log the value written from kernel driver make my device to fail. Windows driver after some assumption write back the original value (0xc3) Ok, I'm still progressing on more of that init code,

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-15 Thread Ruslan Bilovol
Hi Alan, On Mon, Feb 9, 2015 at 10:00 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 9 Feb 2015, Krzysztof Opasiak wrote: Why bother matching by name? Why not simply take the first available UDC? Because you may have more than one udc. This would allow to pick one by name

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-15 Thread Ruslan Bilovol
Hi Krzysztof, On Tue, Feb 10, 2015 at 10:47 AM, Krzysztof Opasiak k.opas...@samsung.com wrote: -Original Message- From: Ruslan Bilovol [mailto:ruslan.bilo...@gmail.com] Sent: Tuesday, February 10, 2015 12:46 AM To: Alan Stern Cc: Krzysztof Opasiak; Peter Chen;

[PATCH v2 0/4] usb: renesas_usbhs: add support for USB-DMAC

2015-02-15 Thread Yoshihiro Shimoda
This patch set is based on Felipe's usb.git / testing/next branch. (commit id = 6461d69d12508fe166be5c6c31d5a9da02a4dfb5) To use the USB-DMAC, we have to add some device nodes for USB-DMAC in dts file. If we don't have such device nodes, this driver will use PIO. Changes from v1: - Change

[PATCH v2 3/4] usb: renesas_usbhs: fix the sequence in xfer_work()

2015-02-15 Thread Yoshihiro Shimoda
This patch fixes the setup sequence in xfer_work(). Otherwise, sometimes a usb transaction will get stuck. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- drivers/usb/renesas_usbhs/fifo.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

2015-02-15 Thread Yoshihiro Shimoda
According to the gadget.h, a complete function will always be called with interrupts disabled. However, sometimes usbhsg_queue_pop() function is called with interrupts enabled. So, this function should calls local_irq_save() before this calls the usb_gadget_giveback_request(). Otherwise, there is

[PATCH v2 2/4] usb: renesas_usbhs: add the channel number in dma-names

2015-02-15 Thread Yoshihiro Shimoda
To connect the channel of USB-DMAC to USBHS DnFIFO number, this patch adds this channel/FIFO number in dma-names. Otherwise, this driver needs to add analysis code for device tree. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- .../devicetree/bindings/usb/renesas_usbhs.txt

[PATCH v2 4/4] usb: renesas_usbhs: add support for USB-DMAC

2015-02-15 Thread Yoshihiro Shimoda
Some Renesas SoCs have the USB-DMAC. It is able to terminate transfers when a short packet is received, even if less bytes than the transfer counter size have been received. Also, it is able to send a short packet even if the packet size is not multiples of 8bytes. Since the previous code has

RE: [PATCH 1/1] MAINTAINERS: add entry for USB OTG FSM

2015-02-15 Thread Peter Chen
On Sun, Feb 15, 2015 at 12:22:59PM +0800, Peter Chen wrote: Add MAINTAINER entry for USB OTG Finite State Machine Cc: Felipe Balbi ba...@ti.com Signed-off-by: Peter Chen peter.c...@freescale.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: Kernel crash on usb-storage disconnect, multiqueue in use

2015-02-15 Thread Bruno Prémont
On Thu, 12 Feb 2015 07:56:47 +0100 Bart Van Assche wrote: On 02/11/15 22:25, Bruno Prémont wrote: Since 3.19-rcX kernel crashes when I disconnect an external HDD drive (not sure since which kernel revision tough early 3.19-rcs possibly are not affected). It looks like this crash is

Re: Usb serial driver change question in the linux kernel

2015-02-15 Thread Johan Hovold
On Sun, Feb 15, 2015 at 01:26:08PM +, Li, Elvin wrote: Hi Johan, Your patch fixed my issue. Thank you for support! Great, thanks for testing. Johan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

[PATCH] USB: console: add dummy __module_get

2015-02-15 Thread Johan Hovold
Add call to __module_get when initialising the fake tty in usb_console_setup to match the module_put in release_one_tty. Note that the tty-driver (i.e. usb-serial core) must be compiled-in to enable the usb console so the __module_get is essentially a noop as driver-owner will be null.

Re: [PATCH] USB: console: fix potential use after free

2015-02-15 Thread Ben Hutchings
On Wed, 2015-02-11 at 14:55 +0800, Johan Hovold wrote: On Tue, Feb 10, 2015 at 08:39:26PM +, Ben Hutchings wrote: On Mon, 2015-01-05 at 16:04 +0100, Johan Hovold wrote: Use tty kref to release the fake tty in usb_console_setup to avoid use after free if the underlying serial driver

Re: [PATCH] USB: console: fix potential use after free

2015-02-15 Thread Johan Hovold
On Mon, Feb 16, 2015 at 03:49:17AM +, Ben Hutchings wrote: On Wed, 2015-02-11 at 14:55 +0800, Johan Hovold wrote: On Tue, Feb 10, 2015 at 08:39:26PM +, Ben Hutchings wrote: On Mon, 2015-01-05 at 16:04 +0100, Johan Hovold wrote: Use tty kref to release the fake tty in