Why you use unsigned, but not unsigned int or unsigned long?
unsigned is equal to unsigned int, currently only 13 timers are defined, so
unsigned is okay, for possible future extension, I will change it to be
unsigned long
Since I see you use unsigned long below, I have this
On Sat, Feb 28, 2015 at 09:43:30AM +0800, Chen Peter-B29397 wrote:
Why you use unsigned, but not unsigned int or unsigned long?
unsigned is equal to unsigned int, currently only 13 timers are defined,
so
unsigned is okay, for possible future extension, I will change it to be
Hi Mathias Devin,
On Thu, Feb 19, 2015 at 3:18 PM, Mathias Nyman
mathias.ny...@linux.intel.com wrote:
Got one more patch added to the for-usb-next-branch.
It makes sure we allocate enough scratchpad memory for xhci.
It's one possible cause.
Patch will anyway go to 3.20, but you can try it
On Thu, Feb 26 2015, Tal Shorer tal.sho...@gmail.com wrote:
Signed-off-by: Tal Shorer tal.sho...@gmail.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
drivers/usb/gadget/function/f_mass_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
* Sergei Shtylyov sergei.shtyl...@cogentembedded.com [150227 06:27]:
Hello.
On 2/27/2015 5:17 PM, Robert Abel wrote:
Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
parameter names, doesn't it?
Jesus Christ, you guys are killing me...
I've already spent way more
Hello.
On 2/27/2015 5:17 PM, Robert Abel wrote:
Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
parameter names, doesn't it?
Jesus Christ, you guys are killing me...
I've already spent way more time on this patch series than I intended
to anyway...
That's what you
On Thu, Feb 26, 2015 at 4:06 PM, Sergei Shtylyov
sergei.shtyl...@cogentembedded.com wrote:
Documentation/kernel-doc-nano-HOWTO.txt requires colons after the
parameter names, doesn't it?
Jesus Christ, you guys are killing me...
I've already spent way more time on this patch series than I
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ handlers with interrupts enabled can cause stack overflows
when the interrupt line of the issuing device is still active.
This patch removes
Hi Roger,
On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros rog...@ti.com wrote:
time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0);
should be
time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0;
That's a micro-optimization.
+ 1ns since we don't want to
The goal is to remove the old function interface, so its (only) user
must be converted to the new interface.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/legacy/Kconfig | 1 +
drivers/usb/gadget/legacy/printer.c | 50 ++---
Substitute some boilerplate code with a dedicated macro.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/legacy/printer.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/legacy/printer.c
This is a follow-up to this thread:
http://www.spinics.net/lists/linux-usb/msg121791.html
after patches 01..24 have been applied by Felipe.
This series contains the remainig patches rebased onto Felipe's
testing/next.
Andrzej Pietrasiewicz (6):
usb: gadget: f_printer: eliminate legacy
In order to add configfs support, a usb function must be converted to use
the new interface. This patch converts the function to the new interface
and provides backward compatiblity layer, which can be removed after
all its users are converted to use the new interface.
Signed-off-by: Andrzej
There are no old interface users left, so it can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/function/f_printer.c | 113
1 file changed, 113 deletions(-)
diff --git a/drivers/usb/gadget/function/f_printer.c
With multiple (and dynamically allocated and removed) instances of the
printer function it does not make sense to depend on a component of a
particular struct printer_dev in order to clean up after _all_ printer
instances.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
Add support for configfs interface so that f_printer can be used as a
component of usb gadgets composed with it.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
.../ABI/testing/configfs-usb-gadget-printer| 9 ++
Documentation/usb/gadget-testing.txt | 47
Access to the 'serial_table' array needs to be protected by the spinlock.
Signed-off-by: Aleksander Morgado aleksan...@aleksander.es
---
drivers/net/usb/hso.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index
On Thu, Feb 26, 2015 at 5:12 PM, Mathias Nyman
mathias.ny...@linux.intel.com wrote:
When a control transfer has a short data stage, the xHCI controller generates
two transfer events: a COMP_SHORT_TX event that specifies the untransferred
amount, and a COMP_SUCCESS event. But when the data stage
On Wed, Feb 11, 2015 at 07:35:29PM -0800, Bjorn Andersson wrote:
The function regulator_set_optimum_mode() is changing name to
regulator_set_load(), so update the code accordingly.
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com
since this depends on the rest of the series:
On Wed, Feb 11, 2015 at 07:35:30PM -0800, Bjorn Andersson wrote:
The function regulator_set_optimum_mode() is changing name to
regulator_set_load(), so update the code accordingly.
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com
since this depends on the rest of the series:
On Fri, 27 Feb 2015, Christian Böhme wrote:
Hello all,
this is a response to
https://bugzilla.kernel.org/show_bug.cgi?id=14987#c6
whose main thread more or less merely rehashes what was
already said in other (bug) reports before it elsewhere.
I'd like for this to be a reminder that
On Fri, Feb 27, 2015 at 04:48:39PM +0100, Valentin Rothberg wrote:
On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc
Silence the following warning:
drivers/usb/gadget/udc/net2280.c:3176:33: warning: context imbalance in
'handle_stat1_irqs' - unexpected unlock
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/udc/net2280.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ handlers with interrupts enabled can cause stack overflows
when the
Hi,
On Mon, Feb 02, 2015 at 10:55:25AM +0100, Mian Yousaf Kaukab wrote:
@@ -465,13 +484,18 @@ static struct usb_request
struct net2280_ep *ep;
struct net2280_request *req;
- if (!_ep)
+ if (!_ep) {
+ pr_err(%s: Invalid ep\n, __func__);
OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily
hard to turn DEBUG on. Remove the offending lines.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
---
drivers/memory/omap-gpmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c
Hi Roger,
On Fri, Feb 27, 2015 at 11:24 AM, Roger Quadros rog...@ti.com wrote:
+ /* is child a common bus? */
+ if (of_match_node(of_default_bus_match_table, child))
+ /* create children and other common bus children */
+ if (of_platform_populate(child,
On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
running IRQ
These are the changes I proposed in these patch series: [1], [2], [3], [4]
rebased to 3.19 as well as new changes for little bugs I noticed while
preparing this patch series as well as changes introduced via comments.
1. DEBUG was undefined in source code -- remove offending lines
2. add
On Fri, Feb 27, 2015 at 08:48:40AM +, Schmid, Carsten wrote:
I have had a look into the spec (USB PD), but it does not explicitly
explain whether the negotiation is done in hardware (by dedicated
charger chips) or driver software (which then assigns higher allowed
current to the ports).
This patch adds support for spawning buses as children of the GPMC.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
---
drivers/memory/omap-gpmc.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/omap-gpmc.c
GPMC_CONFIG1_i parameters CLKACTIVATIONTIME and WAITMONITORINGTIME
have reserved values.
Raise an error if calculated timings try to program reserved values.
GPMC_CONFIG1_i ATTACHEDDEVICEPAGELENGTH and DEVICESIZE were already checked
when parsing the DT.
Explicitly comment invalid values on
DTS output was formatted to require additional work when copy-pasting into DTS.
Nano-second timings were replaced with interval of values that produce the same
number of clock ticks.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
---
drivers/memory/omap-gpmc.c | 38
The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
even though the access is defined as asynchronous, and no GPMC_CLK clock
is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider
for the GPMC clock, so it must be programmed to define the
correct
The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
even though the access is defined as asynchronous, and no GPMC_CLK clock
is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider
for the GPMC clock, so it must be programmed to define the
correct
The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
even though the access is defined as asynchronous, and no GPMC_CLK clock
is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider
for the GPMC clock, so it must be programmed to define the
correct
GPMC debug output is aligned to 10 characters for field names.
However, some fields have bigger names, screwing up the alignment.
Consequently, alignment was changed to longest field name (17 chars) for now.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
---
drivers/memory/omap-gpmc.c
On Fri, Feb 27, 2015 at 7:44 PM, Aleksander Morgado
aleksan...@aleksander.es wrote:
Access to the 'serial_table' array needs to be protected by the spinlock.
Signed-off-by: Aleksander Morgado aleksan...@aleksander.es
---
drivers/net/usb/hso.c | 9 +++--
1 file changed, 7 insertions(+),
Hi,
On Fri, Feb 27, 2015 at 02:55:25PM -0600, Felipe Balbi wrote:
On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote:
Non-standard requests can encode the actual interface number in a
non-standard way. For example composite_setup() assumes
that it is w_index 0xFF, but
On Mon, Feb 23, 2015 at 04:02:09PM +0100, Andrzej Pietrasiewicz wrote:
Non-standard requests can encode the actual interface number in a
non-standard way. For example composite_setup() assumes
that it is w_index 0xFF, but the printer function encodes the interface
number in a context-dependet
Alan Stern stern@... writes:
Specifically, HID_QUIRK_IGNORE_MOUSE existed in 2.6.27
and was dealt with in drivers/hid/usbhid/hid-core.c:730,
thereby somehow fixing things. But those lines (and
the symbol) disappeared after 2.6.27. Why were they
removed?
They weren't removed. The
as soon as we find out tx fifo is empty, there's
no need to break out of the loop just to have another
branch to complete the transfer. We can just complete
transfer and exit early.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_cppi41.c | 12
1 file changed, 4
Hi Amit,
commit ef11982dd7a657512c362242508bb4021e0d67b6 (Add support for
interrupt EP) actually broke testusb for MUSB when MUSB is the gadget.
The reason is that we're requesting an endpoint with a 64-byte FIFO, but
later deciding to use the same endpoint with wMaxPacketSize set to 1024
and
On 02/20, David Miller wrote:
From: Ben Shelton ben.shel...@ni.com
Date: Mon, 16 Feb 2015 13:47:06 -0600
The National Instruments USB Host-to-Host Cable is based on the Prolific
PL-25A1 chipset. Add its VID/PID so the plusb driver will recognize it.
Signed-off-by: Ben Shelton
no functional changes, clean up only.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_cppi41.c | 88 +-
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index
Silence the following warning:
drivers/usb/gadget/udc/net2280.c:3176:33: warning: context imbalance in
'handle_stat1_irqs' - unexpected unlock
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/udc/net2280.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
according to comment in code, HS completion
will happen pretty fast, instead of using
udelay(), let's just busy loop and drop a
cpu_relax() where udelay() was.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/musb/musb_cppi41.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Luca Ceresoli l...@lucaceresoli.net
Date: Thu, 26 Feb 2015 00:58:12 +0100
Just another AX88178-based 10/100/1000 USB-to-Ethernet dongle. This one
shows up in lsusb as: Sitecom Europe B.V. LN-028 Network USB 2.0 Adapter.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Applied,
Felipe,
On Thu, Feb 26, 2015 at 2:53 PM, Felipe Balbi ba...@ti.com wrote:
Hi folks,
this is v3 of my patchset which has been in discussion with
Bin Liu (hey, thanks).
Thanks for clean this up. Dropping reset from the babble handling has
been on my TODO for a long time, but never got a chance
On Fri, Feb 27, 2015 at 03:22:11PM -0600, Bin Liu wrote:
Felipe,
On Thu, Feb 26, 2015 at 2:53 PM, Felipe Balbi ba...@ti.com wrote:
Hi folks,
this is v3 of my patchset which has been in discussion with
Bin Liu (hey, thanks).
Thanks for clean this up. Dropping reset from the babble
Ben Hutchings ben.hutchi...@codethink.co.uk writes:
cdc_ncm disagrees with usbnet about how much framing overhead should
be counted in the tx_bytes statistics, and tries 'fix' this by
decrementing tx_bytes on the transmit path. But statistics must never
be decremented except due to
On Fri, 2015-02-27 at 10:12 +0100, Bjørn Mork wrote:
Ben Hutchings ben.hutchi...@codethink.co.uk writes:
cdc_ncm disagrees with usbnet about how much framing overhead should
be counted in the tx_bytes statistics, and tries 'fix' this by
decrementing tx_bytes on the transmit path. But
I have had a look into the spec (USB PD), but it does not explicitly explain
whether the negotiation is done in hardware (by dedicated charger chips) or
driver software (which then assigns higher allowed current to the ports).
We are planning for new devices to be designed, where we want to
Ben Hutchings ben.hutchi...@codethink.co.uk writes:
Currently the usbnet core does not update the tx_packets statistic for
drivers with FLAG_MULTI_PACKET and there is no hook in the TX
completion path where they could do this.
cdc_ncm and dependent drivers are bumping tx_packets stat on the
Hi,
On Sat, Feb 28, 2015 at 12:19:41AM +0100, Arnd Bergmann wrote:
A recent bug fix I did that was marked for stable backports
introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY.
I was missing the fact that the PHY driver already stubs out the
omap_control_usb_set_mode, and
A recent bug fix I did that was marked for stable backports
introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY.
I was missing the fact that the PHY driver already stubs out the
omap_control_usb_set_mode, and we only need to add a dependency
to prevent the musb-omap2430 driver from
Robert,
On 26/02/15 16:45, Robert ABEL wrote:
DTS output was formatted to require additional work when copy-pasting into
DTS.
Nano-second timings were replaced with interval of values that produce the
same
number of clock ticks.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
Hi Robert,
On 26/02/15 16:45, Robert ABEL wrote:
This patch adds support for spawning buses as children of the GPMC.
Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de
---
drivers/memory/omap-gpmc.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff
From: Ben Shelton ben.shel...@ni.com
Date: Fri, 27 Feb 2015 15:26:32 -0600
On 02/20, David Miller wrote:
From: Ben Shelton ben.shel...@ni.com
Date: Mon, 16 Feb 2015 13:47:06 -0600
The National Instruments USB Host-to-Host Cable is based on the Prolific
PL-25A1 chipset. Add its VID/PID
59 matches
Mail list logo