[PATCH 04/19] USB: hub.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Alan Stern st...@rowland.harvard.edu CC: Dan Williams dan.j.willi...@intel.com CC: Petr Mladek pmla...@suse.cz CC: Peter Chen peter.c...@freescale.com

[PATCH 08/19] USB: mon_main.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/mon/mon_main.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH 15/19] USB: speedtch.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Duncan Sands duncan.sa...@free.fr Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/atm/speedtch.c | 18 -- 1 file

[PATCH 09/19] USB: mon_stat.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/mon/mon_stat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 07/19] USB: mon_bin.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/mon/mon_bin.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 05/19] USB: inode.c: move assignment out of if () block

2015-04-30 Thread Christoph Hellwig
On Thu, Apr 30, 2015 at 11:32:54AM +0200, Greg Kroah-Hartman wrote: We should not be doing assignments within an if () block so fix up the code to not do this. Any reason your ccing me on random cleanups on random usb crap? Nothing personal, but I'm getting tons of these weird cc lately, so I

Re: [PATCHv3 10/12] usb: dwc3: add ULPI interface support

2015-04-30 Thread Heikki Krogerus
Hi Felipe, + case DWC3_GHWPARAMS3_HSPHY_IFC_ULPI: + /* Soft reset here to sync the clocks */ + ret = dwc3_soft_reset(dwc); you just lost all DWC3_GUSB3PIPECTL(0) and DWC3_GUSB2PHYCFG(0) configurations which happened right before this switch. Essentially breaking

Re: [PATCHv3 01/11] usb: add bus type for USB ULPI

2015-04-30 Thread Heikki Krogerus
+struct bus_type ulpi_bus = { non-static and undeclared anywhere, adds a sparse error. I'm dropping the series for now :-) drivers/usb/common/ulpi.c:77:17: warning: symbol 'ulpi_bus' was not declared. Should it be static? Need to fix that. I'll wait for your comment's to 10/12

[PATCH 11/19] USB: ohci-hcd.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Alan Stern st...@rowland.harvard.edu Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/host/ohci-hcd.c | 3 ++- 1 file changed, 2

[PATCH 17/19] USB: usblp.c: move assignment out of if () block

2015-04-30 Thread Greg Kroah-Hartman
We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Pete Zaitcev zait...@redhat.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/class/usblp.c | 15 ++- 1 file changed,

[PATCH 3/3] xhci: gracefully handle xhci_irq dead device

2015-04-30 Thread Mathias Nyman
From: Joe Lawrence joe.lawre...@stratus.com If the xHCI host controller has died (ie, device removed) or suffered other serious fatal error (STS_FATAL), then xhci_irq should handle this condition with IRQ_HANDLED instead of -ESHUTDOWN. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Cc:

Re: [PATCH 01/19] USB: ehci-dbg.c: move assignment out of if () block

2015-04-30 Thread Alan Stern
On Thu, 30 Apr 2015, Greg Kroah-Hartman wrote: We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Alan Stern st...@rowland.harvard.edu Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[GIT PULL] USB driver fixes for 4.1-rc2

2015-04-30 Thread Greg KH
The following changes since commit b787f68c36d49bb1d9236f403813641efa74a031: Linux 4.1-rc1 (2015-04-26 17:59:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.1-rc2 for you to fetch changes up to

Re: [PATCH 1/2] usb: gadget: add usb_gadget_activate/deactivate functions

2015-04-30 Thread Felipe Balbi
On Thu, Apr 30, 2015 at 11:08:27AM +0200, Robert Baldyga wrote: On 04/29/2015 05:30 PM, Felipe Balbi wrote: On Wed, Apr 29, 2015 at 11:08:06AM +0200, Robert Baldyga wrote: Hi Felipe, On 04/28/2015 06:40 PM, Felipe Balbi wrote: On Tue, Apr 07, 2015 at 10:31:52AM +0200, Robert Baldyga

Re: [PATCHv3 10/12] usb: dwc3: add ULPI interface support

2015-04-30 Thread Felipe Balbi
Hi, On Thu, Apr 30, 2015 at 01:34:22PM +0300, Heikki Krogerus wrote: Hi Felipe, + case DWC3_GHWPARAMS3_HSPHY_IFC_ULPI: + /* Soft reset here to sync the clocks */ + ret = dwc3_soft_reset(dwc); you just lost all DWC3_GUSB3PIPECTL(0) and DWC3_GUSB2PHYCFG(0)