Re: [PATCH] f_uac1: check return code from config_ep_by_speed
On Mon, May 18, 2015 at 02:58:22PM +0200, Michael Trimarchi wrote:
Signed-off-by: Michael Trimarchi mich...@amarulasolutions.com
you need a commit log, even if it appears obvious now, it might not be
10 years from now.
Also, since you're respinning anyway, subject would be nicer as:
usb: gadget: f_uac1: check return code from config_ep_by_speed()
cheers
---
drivers/usb/gadget/function/f_uac1.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_uac1.c
b/drivers/usb/gadget/function/f_uac1.c
index 9719abf..7856b33 100644
--- a/drivers/usb/gadget/function/f_uac1.c
+++ b/drivers/usb/gadget/function/f_uac1.c
@@ -588,7 +588,10 @@ static int f_audio_set_alt(struct usb_function *f,
unsigned intf, unsigned alt)
if (intf == 1) {
if (alt == 1) {
- config_ep_by_speed(cdev-gadget, f, out_ep);
+ err = config_ep_by_speed(cdev-gadget, f, out_ep);
+ if (err)
+ return err;
+
usb_ep_enable(out_ep);
out_ep-driver_data = audio;
audio-copy_buf = f_audio_buffer_alloc(audio_buf_size);
--
1.9.1
--
balbi
signature.asc
Description: Digital signature
Re: [PATCH v2 2/2] usb: renesas_usbhs: Add support for R-Car E2
On Mon, May 18, 2015 at 1:04 PM, Yoshihiro Shimoda
yoshihiro.shimoda...@renesas.com wrote:
This patch adds a compatible string to support for R-Car E2.
Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com
Acked-by: Geert Uytterhoeven geert+rene...@glider.be in patch 2
---
Remarks: Geert's Acked-by is for the DT binding part (renesas_usbhs.txt).
For the remaining part:
Acked-by: Geert Uytterhoeven geert+rene...@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] usb: gadget: ether: Fix MAC address parsing
On 2015-05-18 14:16, Bjørn Mork wrote: Stefan Agner ste...@agner.ch writes: MAC addresses can be written without leading zeros. A popular example is libc's ether_ntoa_r function which creates such MAC addresses. Example: 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe The function get_ether_addr potentially also parsed past the end of the user provided string. Use the opportunity and fix the function to never parse beyond the end of the string while allowing MAC addresses with and without leading zeros. Also corner cases such as 00:14:3d:0f:ff:0 + new-line character are parsed correctly. Please don't allow arbitrary noise in an exported API like this. It's just a recipe for bugs. Do strict parsing and return clean errors on unexpected input. Don't try to fix up anything. Leave that for userspace. There is not much fix-up beside the allowance of the libc standard format with single digits and the new-line character. static int get_ether_addr(const char *str, u8 *dev_addr) This function should simply call mac_pton() like the other mac address parsers in the kernel. I agree that using a common implementation makes sense, however that implementation does not support the central idea of that patch: supporting the standard format which is created by libc's ether_ntoa_r... -- Stefan -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Fixes for rndis
This short series fixes three bugs in rndis. Patches 1/3 and 3/3 fix problems indicated by kbuild test robot. Andrzej Pietrasiewicz (3): usb: gadget: rndis: change the value passed to rndis_signal_(dis)connect() usb: gadget: rndis: don't duplicate the i variable usb: gadget: rndis: use signed type for a signed value drivers/usb/gadget/function/rndis.c | 9 - drivers/usb/gadget/function/rndis.h | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: make module xhci_hcd removable
On Mon, May 18, 2015 at 08:53:10PM +0300, Arthur Demchenkov wrote: Fixed regression. After commit 29e409f the module xhci_hcd became non-removable. That behaviour is not expected and there're no notes about it in commit message. The module should be removable as it blocks PM suspend/resume functions (Debian Bug#666406). I hate to ask why debian things that unloading all kernel modules is the correct thing to do for suspend... But that's separate from this patch, this looks correct, thanks. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] usb: renesas_usbhs: Change USBHS_TYPE_R8A779x to USBHS_TYPE_RCAR_GEN2
On Mon, May 18, 2015 at 08:04:14PM +0900, Yoshihiro Shimoda wrote: Since the HSUSB controllers of R-Car Gen2 are the same specification (they have 16 pipes and usb-dmac), this patch changes USBHS_TYPE_R8A7790 and USBHS_TYPE_R8A7791 to USBHS_TYPE_RCAR_GEN2. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Acked-by: Simon Horman horms+rene...@verge.net.au -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
