Re: [PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

Hi Felipe, Can you take this serie or would you like me to resend it? BR, Gregory On Fri, Nov 06, 2015 at 12:02:42AM +0100, John Youn wrote: > On 11/5/2015 12:41 AM, Gregory Herrero wrote: > > Hi, > > > > This patchset contains bug fixes for host descriptor dma mode. > > > > Descriptor dma

[GIT PULL] USB-serial fixes for v4.4-rc2

Hi Greg, Here are a few fixes and new device ids for v4.4-rc2. All have been in linux-next for a few days now. Thanks, Johan The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at:

Re: [PATCH v2 1/2] cdc_acm: Ignore Infineon Flash Loader utility

On Mon, Nov 16, 2015 at 01:34:14PM +0100, Jonas Jonsson wrote: > Some modems, such as the Telit UE910, are using an Infineon Flash Loader > utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC > Data). The latter can be used as a serial interface to upgrade the > firmware of the

Re: [PATCH v2 2/2] USB: serial: Another Infineon flash loader USB ID

On Mon, Nov 16, 2015 at 01:34:15PM +0100, Jonas Jonsson wrote: > This has been seen on a Telit UE910 modem. Please expand this message as well and mention why this is not a CDC device so we do not forget. > Signed-off-by: Jonas Jonsson > Tested-by: Daniele Palmas

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote: > First part of lockdep report: > http://imgur.com/clLsCWe > > Second part: > http://imgur.com/Wa2PzRl > > Here are some printk's of mine while reproducing + debugging the issue: > http://imgur.com/SETOHT7 So the real problem is that Intuos driver

Re: [PATCH] usb: gadget: Add the console support for usb-to-serial port

On 11/19/2015 01:48 AM, Baolin Wang wrote: >> >>> +{ >>> + struct gscons_info *info = gserial_cons.data; >>> + int port_num = gserial_cons.index; >>> + struct usb_request *req; >>> + struct gs_port *port; >>> + struct usb_ep *ep; >>> + >>> + if (port_num >=

Re: [PATCH] usb: gadget: Add the console support for usb-to-serial port

On 19 November 2015 at 17:36, Peter Hurley wrote: > On 11/19/2015 01:48 AM, Baolin Wang wrote: >>> +{ + struct gscons_info *info = gserial_cons.data; + int port_num = gserial_cons.index; + struct usb_request *req; + struct gs_port

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

On Wed, 18 Nov 2015, Ioan-Adrian Ratiu wrote: > > > The critical section protected by usbhid->lock in hid_ctrl() is too > > > big and in rare cases causes a recursive deadlock because of its call > > > to hid_input_report(). > > > > > > This deadlock reproduces on newer wacom tablets like

Re: [PATCH v2 1/4] usb: gadget: f_sourcesink: add queue depth

On 11/19/2015 08:02 AM, Peter Chen wrote: Add queue depth for both iso and bulk transfer, with more queues, we can do performance and stress test using sourcesink, and update g_zero accordingly. Signed-off-by: Peter Chen Reviewed-by: Krzysztof Opasiak

Re: [PATCH v2 3/4] Doc: ABI: configfs-usb-gadget-sourcesink: add two entries for depth of queue

On 11/19/2015 08:02 AM, Peter Chen wrote: Add both bulk and iso depth of queue entries. Signed-off-by: Peter Chen Reviewed-by: Krzysztof Opasiak --- Documentation/ABI/testing/configfs-usb-gadget-sourcesink | 2 ++ 1 file changed, 2

Re: [PATCH v2 4/4] usb: gadget: f_sourcesink: quit if usb_ep_queue returns error

On 11/19/2015 08:02 AM, Peter Chen wrote: Since now, we may have more than one request during the test, and it is better we just quit once the error occurs instead of try queueing further requests. Signed-off-by: Peter Chen Suggested-by: Krzysztof Opasiak

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

On 11/19/2015 08:02 AM, Peter Chen wrote: Add both bulk and iso depth of queue for sourcesink. Signed-off-by: Peter Chen Reviewed-by: Krzysztof Opasiak --- Documentation/usb/gadget-testing.txt | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v3 2/2] usb: dwc2: host: Clear interrupts before handling them

In general it is wise to clear interrupts before processing them. If you don't do that, you can get: 1. Interrupt happens 2. You look at system state and process interrupt 3. A new interrupt happens 4. You clear interrupt without processing it. This patch was actually a first attempt to fix

[PATCH v3 1/2] usb: dwc2: host: Fix missing device insertions

If you've got your interrupt signals bouncing a bit as you insert your USB device, you might end up in a state when the device is connected but the driver doesn't know it. Specifically, the observed order is: 1. hardware sees connect 2. hardware sees disconnect 3. hardware sees connect 4.

Re: [PATCH] usb: gadget: pxa27x: fix suspend callback

Hi, Robert Jarzmik writes: > Felipe Balbi writes: > >> pxa27x disconnects pullups on suspend but doesn't >> notify the gadget driver about it, so gadget driver >> can't disable the endpoints it was using. >> >> This causes problems on resume because gadget

[PATCH] usb: gadget: pxa27x: fix suspend callback

pxa27x disconnects pullups on suspend but doesn't notify the gadget driver about it, so gadget driver can't disable the endpoints it was using. This causes problems on resume because gadget core will think endpoints are still enabled and just ignore the following usb_ep_enable(). Fix this

Re: [PATCH RESEND 1/2] usb: dwc2: Make PHY optional

Hi John, John Youn writes: > Fixes commit 09a75e85 > "usb: dwc2: refactor common low-level hw code to platform.c" these two lines should be placed ... > > The above commit consolidated the low-level phy access into a common > location. This change introduced a check

RE: [PATCH] usb: dwc3: add generic OF glue layer

Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, November 19, 2015 8:28 PM > To: Linux USB Mailing List > Cc: Subbaraya Sundeep Bhatta; Ivan T . Ivanov > Subject: Re: [PATCH] usb: dwc3: add generic OF glue layer > > > Hi, > > Felipe Balbi

Re: [PATCH v2 2/2] usb: phy: mxs: add "fsl,imx6ul-usbphy" compatible string

Hi, Peter Chen writes: > On Wed, Sep 16, 2015 at 03:52:33PM +0800, Li Jun wrote: >> From: Peter Chen >> >> Add "fsl,imx6ul-usbphy" compatible string for iMX6ul usb phy >> >> Signed-off-by: Peter Chen >>

Re: [PATCH v2 10/13] usb: dwc2: host: enable descriptor dma for fs devices

Hi, Gregory Herrero writes: > From: Mian Yousaf Kaukab > > As descriptor dma mode does not support split transfers, it can't be > enabled for high speed devices. Add a core parameter to enable it for > full speed devices. > > Ensure frame

[PATCH] usb: dwc3: remove dwc3-qcom in favor of dwc3-of-simple

Now that we have a generic dwc3-of-simple.c, we can use that instead of maintaining dwc3-qcom.c which is extremely similar. Cc: Ivan T. Ivanov Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/Kconfig | 8 --- drivers/usb/dwc3/Makefile| 1 -

Re: [PATCH] usb: gadget: pxa27x: fix suspend callback

Felipe Balbi writes: > pxa27x disconnects pullups on suspend but doesn't > notify the gadget driver about it, so gadget driver > can't disable the endpoints it was using. > > This causes problems on resume because gadget core > will think endpoints are still enabled and just >

RE: [PATCH] usb: dwc3: add generic OF glue layer

Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, November 19, 2015 8:28 PM > To: Linux USB Mailing List > Cc: Subbaraya Sundeep Bhatta; Ivan T . Ivanov > Subject: Re: [PATCH] usb: dwc3: add generic OF glue layer > > > Hi, > > Felipe Balbi

RE: [PATCH] usb: dwc3: add generic OF glue layer

Hi, Subbaraya Sundeep Bhatta writes: > Hi Felipe, > >> -Original Message- >> From: Felipe Balbi [mailto:ba...@ti.com] >> Sent: Thursday, November 19, 2015 8:28 PM >> To: Linux USB Mailing List >> Cc: Subbaraya Sundeep Bhatta; Ivan T . Ivanov >>

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

Hi, Peter Chen writes: > Add both bulk and iso depth of queue for sourcesink. > > Signed-off-by: Peter Chen > --- > Documentation/usb/gadget-testing.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them

Hi, Doug Anderson writes: isn't this a regression ? You're first clearing the interrupts and only then reading to check what's pending, however, what's pending has just been cleared. Seems like this should be: hprt0 = dwc2_readl(HPRT0);

Re: [PATCH v3 2/2] usb: dwc2: host: Clear interrupts before handling them

On 19 November 2015 at 21:45, Douglas Anderson wrote: > In general it is wise to clear interrupts before processing them. If > you don't do that, you can get: > 1. Interrupt happens > 2. You look at system state and process interrupt > 3. A new interrupt happens > 4.

[PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory

The current coding writes to memory before allocating it. Signed-off-by: Heinrich Schuchardt --- drivers/usb/phy/phy-omap-otg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/usb/phy/phy-omap-otg.c index

Re: [PATCH] HID: usbhid: add Logitech G710+ keyboard quirk NOGET

On Tue, Nov 17, 2015 at 12:40:12AM -0600, Jimmy Berry wrote: > Without quirk keyboard repeats '6' until volume control is used since it > indicates the key is pressed without ever releasing. > > Signed-off-by: Jimmy Berry > --- > drivers/hid/hid-ids.h | 1 + >

[PATCH] usb-storage: Fix scsi-sd failure "Invalid field in cdb" for USB adapter JMicron

From: Dmitry Katsubo The patch extends the family of SATA-to-USB JMicron adapters that need FUA to be disabled and applies the same policy for uas driver. See details in http://unix.stackexchange.com/questions/237204/ Signed-off-by: Dmitry Katsubo

Re: [PATCH v3 2/2] usb: dwc2: host: Clear interrupts before handling them

Antti, On Thu, Nov 19, 2015 at 1:09 PM, Antti Seppälä wrote: > On 19 November 2015 at 21:45, Douglas Anderson wrote: >> In general it is wise to clear interrupts before processing them. If >> you don't do that, you can get: >> 1. Interrupt happens

Re: [PATCH] usb: gadget: pxa27x: fix suspend callback

Felipe Balbi writes: > pxa27x disconnects pullups on suspend but doesn't > notify the gadget driver about it, so gadget driver > can't disable the endpoints it was using. > > This causes problems on resume because gadget core > will think endpoints are still enabled and just >

Re: [PATCH] usb: dwc2: add support of hi6220

Hi, Zhangfei Gao writes: > Support hisilicon,hi6220-usb for HiKey board > > Signed-off-by: Zhangfei Gao doesn't apply: Applying: usb: dwc2: add support of hi6220 error: drivers/usb/dwc2/platform.c: does not match index Patch failed at 0001

Re: [PATCH v3 6/8] usb: dwc2: host: Assume all devices are on one single_tt hub

Hi, Doug Anderson writes: >> Douglas Anderson writes: >>> Until we have logic to determine which devices share the same TT let's >>> add logic to assume that all devices on a given dwc2 controller are on >>> one single_tt hub. This is better than

[PATCH v4 1/2] usb: dwc2: host: Fix missing device insertions

If you've got your interrupt signals bouncing a bit as you insert your USB device, you might end up in a state when the device is connected but the driver doesn't know it. Specifically, the observed order is: 1. hardware sees connect 2. hardware sees disconnect 3. hardware sees connect 4.

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote: > But please understand further my reasoning for submitting this patch. > Consider if this is a bug in the wacom driver or in the usbhid core? IMO > this is a usbhid bug: the critical region in hid_ctrl() is too big, > there is no reason for the

[PATCH v4 2/2] usb: dwc2: host: Clear interrupts before handling them

In general it is wise to clear interrupts before processing them. If you don't do that, you can get: 1. Interrupt happens 2. You look at system state and process interrupt 3. A new interrupt happens 4. You clear interrupt without processing it. This patch was actually a first attempt to fix

Re: [GIT PULL] USB-serial fixes for v4.4-rc2

On Thu, Nov 19, 2015 at 11:20:47AM +0100, Johan Hovold wrote: > Hi Greg, > > Here are a few fixes and new device ids for v4.4-rc2. All have been in > linux-next for a few days now. > > Thanks, > Johan > > > The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: > >

Re: [PATCH RESEND] USB: serial: cp210x: Add tx_empty()

On Wed, Nov 11, 2015 at 03:47:21PM -0600, Konstantin Shkolnyy wrote: Please make the commit message self-contained even if it means repeating what callback you're implementing here. > Without this function, when the port is closed the data in the chip's > transmit FIFO are lost. If the actual

Re: [PATCH] usb: gadget: Add the console support for usb-to-serial port

On 19 November 2015 at 18:28, Peter Hurley wrote: > On 11/18/2015 09:35 PM, Baolin Wang wrote: >> On 18 November 2015 at 23:32, Peter Hurley wrote: >>> Hi Baolin, >>> >>> On 11/16/2015 02:05 AM, Baolin Wang wrote: It dose not work when we

Re: scsi-sd fails with error "Invalid field in cdb" for SATA-to-USB adapter JMicron

On 2015-11-17 19:18, Alan Stern wrote: > That line is completely inappropriate for uas; it applies only to > usb-storage. Don't add it. I got it. My first thought was like you have said (every module uses its own structure), but I blindly tried to guess. > Here you need to test devinfo->flags

Re: [PATCH] usb: gadget: Add the console support for usb-to-serial port

On 11/18/2015 09:35 PM, Baolin Wang wrote: > On 18 November 2015 at 23:32, Peter Hurley wrote: >> Hi Baolin, >> >> On 11/16/2015 02:05 AM, Baolin Wang wrote: >>> It dose not work when we want to use the usb-to-serial port based >>> on one usb gadget as a console. Thus

Re: [PATCH] usb: dwc2: add support of hi6220

On 11/19/2015 11:04 AM, Felipe Balbi wrote: > > Hi, > > Zhangfei Gao writes: >> Support hisilicon,hi6220-usb for HiKey board >> >> Signed-off-by: Zhangfei Gao > > doesn't apply: > > Applying: usb: dwc2: add support of hi6220 > error:

Re: Udoo support for chipidea

On Thu, 19 Nov 2015, Philipp Zabel wrote: > On Wed, Oct 21, 2015 at 10:39:00AM +0800, Peter Chen wrote: > > On Tue, Oct 20, 2015 at 02:09:38PM -0200, Fabio Estevam wrote: > > > Hi Peter, > > > > > > On Mon, Oct 19, 2015 at 12:50 AM, Peter Chen > > > wrote: > > > > >

Re: [PATCH v3 6/8] usb: dwc2: host: Assume all devices are on one single_tt hub

Felipe, On Thu, Nov 19, 2015 at 7:34 AM, Felipe Balbi wrote: > > Hi, > > Douglas Anderson writes: >> Until we have logic to determine which devices share the same TT let's >> add logic to assume that all devices on a given dwc2 controller are on >> one

Re: scsi-sd fails with error "Invalid field in cdb" for SATA-to-USB adapter JMicron

On Thu, 19 Nov 2015, Dmitry Katsubo wrote: > On 2015-11-17 19:18, Alan Stern wrote: > > That line is completely inappropriate for uas; it applies only to > > usb-storage. Don't add it. > > I got it. My first thought was like you have said (every module uses its > own structure), but I blindly

Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

On Thu, 19 Nov 2015 10:10:19 +0100 (CET) Jiri Kosina wrote: > On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote: > > > First part of lockdep report: > > http://imgur.com/clLsCWe > > > > Second part: > > http://imgur.com/Wa2PzRl > > > > Here are some printk's of mine while

Re: Help needed for EHCI problem: removing an active bulk-in QH

On Wed, Nov 18, 2015 at 10:23 AM, Alan Stern wrote: > For the last patch. And yes, do set usb_snoop_max. Dmesg output with usb_snoop and usb_snoop_max is attached below. > I hope so. There is one thing I'm still undecided about: Should this > workaround be applied

Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them

Hi, On Wed, Nov 18, 2015 at 5:43 PM, John Youn wrote: > On 11/16/2015 9:22 AM, Doug Anderson wrote: >> Felipe, >> >> On Mon, Nov 16, 2015 at 8:28 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Douglas Anderson writes: In general it

Re: [PATCH v3 6/8] usb: dwc2: host: Assume all devices are on one single_tt hub

On 11/19/2015 8:27 AM, Doug Anderson wrote: > Felipe, > > On Thu, Nov 19, 2015 at 7:34 AM, Felipe Balbi wrote: >> >> Hi, >> >> Douglas Anderson writes: >>> Until we have logic to determine which devices share the same TT let's >>> add logic to assume that

Re: [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory

Hi, The same patch was already reviewed and applied on usb.git repository[1] [1] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes=2c2025b41aeff57963f9ae2dd909fea704c625ab Thanks, Chanwoo Choi On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote: > The current

Re: [PATCH] HID: usbhid: add Logitech G710+ keyboard quirk NOGET

On Thu, Nov 19, 2015 at 6:26 PM, Greg KH wrote: > On Tue, Nov 17, 2015 at 12:40:12AM -0600, Jimmy Berry wrote: >> Without quirk keyboard repeats '6' until volume control is used since it >> indicates the key is pressed without ever releasing. >> >> Signed-off-by: Jimmy Berry

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

On Thu, Nov 19, 2015 at 12:24:28PM -0600, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > Add both bulk and iso depth of queue for sourcesink. > > > > Signed-off-by: Peter Chen > > --- > > Documentation/usb/gadget-testing.txt | 2 ++ >

Re: [PATCH v3 6/8] usb: dwc2: host: Assume all devices are on one single_tt hub

Hi, Douglas Anderson writes: > Until we have logic to determine which devices share the same TT let's > add logic to assume that all devices on a given dwc2 controller are on > one single_tt hub. This is better than the previous code that assumed > that all devices were

Re: [PATCH] usb: dwc3: add generic OF glue layer

Hi, Felipe Balbi writes: > For simple platforms which merely enable some clocks > and populate its children, we can use this generic > glue layer to avoid boilerplate code duplication. > > For now this supports Qcom and Xilinx, but if we > find a way to add generic handling of

[PATCH] usb: gadget: pxa27x: fix suspend callback

pxa27x disconnects pullups on suspend but doesn't notify the gadget driver about it, so gadget driver can't disable the endpoints it was using. This causes problems on resume because gadget core will think endpoints are still enabled and just ignore the following usb_ep_enable(). Fix this