RE: [PATCH] Add support for usbfs zerocopy.

On Tue, 15 Dec 2015, David Laight wrote: > > Good point. So it seems that the try_module_get() / module_put() > > solution is the only one. > > That still isn't entirely correct. > > Someone with more knowledge than either of us has needs to sort out > how to handle this properly. > > Before

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

On 12/15/2015 04:20 AM, Chanwoo Choi wrote: Maxim Integrated MAX3355E chip integrates a charge pump and comparators to ^^ ^^ enable a system with an integrated USB OTG dual-role transceiver to function as an USB OTG dual-role device. In

RE: [PROBLEM] usb hub malformed packets causes null pointer dereference

On Tue, 15 Dec 2015, Cornea, Alexandru wrote: > Hello, >Apologies for the late response. >We tried the patch, and although the system does not crash anymore, > another issue occurs. > >Depending on platform (Gigabyte GXBT, Galileo board), the USB port that is > used for testing

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

On 9 December 2015 at 09:55, Arnd Bergmann wrote: > On Wednesday 09 December 2015 16:12:24 Peter Chen wrote: >> On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote: >> > On Tue, Dec 08, 2015 at 10:58:48AM +0100, Arnd Bergmann wrote: >> > > On Tuesday 08 December 2015

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

On Tue, Dec 15, 2015 at 02:24:56PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/15/2015 2:44 AM, Greg KH wrote: > > >>Maxim Integrated MAX3355E chip integrates a charge pump and > >>comparators > >>to > >>enable a system with an integrated USB OTG dual-role transceiver to

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hello. On 12/15/2015 09:51 PM, Greg KH wrote: Maxim Integrated MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as an USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also

Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

Hi Yoshihiro, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.4-rc5 next-20151214] url: https://github.com/0day-ci/linux/commits/Yoshihiro-Shimoda/usb-gadget-renesas_usb3-add-support-for-Renesas-USB3-0-peripheral-controller/20151215-145706 base: https

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

On Mon, Dec 14, 2015 at 10:35:19AM +0100, Arnd Bergmann wrote: > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > Hi all, > > > > There is a known issue that the USB code can't handle USB HUB's > > external pins well, in that case, it may cause some onboard > > USB HUBs can't work since

[PATCH v3 4/9] phy: ti-pipe3: move mem resource initialization to a separate function

No functional change. Moved mem resource initialization done in probe to a separate function as part of cleaning up ti_pipe3_probe. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-ti-pipe3.c | 52 1 file changed, 33

[PATCH v3 2/9] phy: ti-pipe3: move clk initialization to a separate function

No functional change. Moved clock initialization done in probe to a separate function as part of cleaning up ti_pipe3_probe. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-ti-pipe3.c | 127 +--- 1 file changed, 72 insertions(+),

[PATCH v3 3/9] phy: ti-pipe3: move sysctrl initialization to a separate function

No functional change. Moved sysctrl initialization done in probe to a separate function as part of cleaning up ti_pipe3_probe. Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/phy-ti-pipe3.c | 78 +--- 1 file changed, 45

[PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie

Add new device tree node for the control module register space where PCIe registers are present. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi

RE: [PATCH] Add support for usbfs zerocopy.

From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: 14 December 2015 17:59 > On Mon, 14 Dec 2015, David Laight wrote: > > > From: Alan Stern > > > Sent: 14 December 2015 15:28 > > ... > > > I thought of something else, a more serious problem. According to the > > > man page for

[PATCH v3 9/9] phy: omap-usb2: use *syscon* framework API to power on/off the PHY

Deprecate using phy-omap-control driver to power on/off the PHY, and use *syscon* framework to do the same. This handles powering on/off the PHY for the USB2 PHYs used in various TI SoCs. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt |

[PATCH v3 8/9] phy: omap-usb2: use omap_usb_power_off to power off the PHY during probe

No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once phy-omap-usb2 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used omap_usb_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 1/9] phy: ti-pipe3: introduce local struct device* in probe

No functional change. Introduce local struct device pointer in probe and replace using >dev/phy->dev with the local device pointer. This is in preparation to split ti_pipe3_probe and add separate functions for getting mem resource, getting sysctrl and getting clocks. Signed-off-by: Kishon Vijay

[PATCH v3 4/4] ARM: dts: : Use "syscon-phy-power" instead of "ctrl-module"

Add "syscon-phy-power" property and remove the deprecated "ctrl-module" property from SATA and USB PHY node. Also remove the unused control module dt nodes. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/am4372.dtsi | 16 ++--

[PATCH v3 3/4] ARM: dts: dra7: Use "ti,dra7x-usb2-phy2" compatible string for USB2 PHY2

The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, use the new compatible string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |3

[PATCH v3 2/4] ARM: dts: dra7: Use "syscon-phy-power" and "syscon-pcs" in PCIe PHY node

Add "syscon-phy-power" property and "syscon-pcs" property which can be used to perform the control module initializations and remove the deprecated "ctrl-module" property from PCIe PHY dt nodes. Phandle to "sysclk" clock node is also added to the PCIe PHY node since some of the syscon

[PATCH v3 0/4] ARM: dts: use syscon property instead of ctrl-module

This series is basically to deprecate using ctrl-module property and use corresponding syscon properties to program the control module registers. Changes from v2: No changes. Changes from v1: *) Squashed the patches that replaces "ctrl-module" with "syscon-phy-power" *) Added

[PATCH v3 6/9] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY

Deprecate using phy-omap-control driver to power on/off the PHY and use *syscon* framework to do the same. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/phy/ti-phy.txt | 10 ++- drivers/phy/phy-ti-pipe3.c | 90

[PATCH v3 7/9] phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHY

Deprecate using phy-omap-control driver to set PCS value of the PHY and start using *syscon* API to do the same. Signed-off-by: Kishon Vijay Abraham I Acked-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti-phy.txt |2 ++

[PATCH v3 5/9] phy: ti-pipe3: use ti_pipe3_power_off to power off the PHY during probe

No functional change. Previously omap_control_phy_power() was used to power off the PHY during probe. But once PIPE3 driver is adapted to use syscon, omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off to power off the PHY. Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

This series is basically to deprecate using phy-omap-control and use syscon APIs to program the control module registers. Changes from v2: No changes. Changes from v1: *) cleanup ti_pipe3_probe in multiple steps *) other minor cleanups Changes from [1] in PHY patches include *) cleanup

Re: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

On Tuesday 15 December 2015 15:54:32 Yoshihiro Shimoda wrote: > R-Car H3 has USB3.0 peripheral controllers. This controller's has the > following features: > - Supports super, high and full speed > - Contains 30 pipes for bulk or interrupt transfer > - Contains dedicated DMA controller > >

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

Hi Arnd, On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote: > On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: >> This series is basically to deprecate using phy-omap-control and use >> syscon APIs to program the control module registers. >> >> Changes from v2: >> No

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hi Sergei, On Tue, Dec 15, 2015 at 12:54 PM, Sergei Shtylyov wrote: > On 12/15/2015 2:28 PM, Geert Uytterhoeven wrote: You are mixing 2 and 1 spaces between words, don't do that. >>> >>> Care to just explain why? >> >> It makes the text difficult to

[PATCH 2/2] usb: chipidea: otg: use usb autosuspend to suspend bus for HNP

Directly manipulate the controller regsiter to suspend the usb bus for HNP is not the proper way, this should be done through the usbcore by usb autosuspend. So to start HNP, autosuspend support should be added for OTG devices interface driver if it's not enabled. Signed-off-by: Li Jun

[PATCH 1/2] usb: chipidea: host: set host to be null after hcd is freed

Set ci->hcd and ci->otg.host to be null in host_stop since the hcd already freed. Signed-off-by: Li Jun --- drivers/usb/chipidea/host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 3d24304..053bac9

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote: > Thanks, Fabio. > > I am afraid I forget to set gpio as output, would you please apply > below patch against my original ones: Same error happens with these changes applied. Here are more details: if I run a pure

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

On Thu, 2015-12-03 at 13:36 -0500, Alan Stern wrote: > This is an old problem, but it was never resolved and it still affects > people (Bugzilla #89511). In short, there are USB-(S)ATA bridges that > claim to be write-back but don't support the SYNCHRONIZE CACHE > command. > This causes errors

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: > This series is basically to deprecate using phy-omap-control and use > syscon APIs to program the control module registers. > > Changes from v2: > No changes. > > Changes from v1: > *) cleanup ti_pipe3_probe in multiple steps >

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

On Tue, 2015-12-08 at 15:33 +0100, Peter Wu wrote: > Can you have a look? I guess that reset_resume needs different > treatment, but don't know how to do it properly as suspend is not > called > before system reset (because the device is apparently already in > suspended state). > > I think that

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

On Tue, Dec 15, 2015 at 7:41 AM, Simon Horman wrote: >> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt >> >b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt >> >index a14c0bb561d5..c55cf77006d0 100644 >> >---

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hello. On 12/15/2015 2:44 AM, Greg KH wrote: Maxim Integrated MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as an USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hi Sergei, On Tue, Dec 15, 2015 at 12:24 PM, Sergei Shtylyov wrote: "So what" and "I'd like to keep my spacing as is" aren't valid reasons. Fix it, then I'll look at the rest again. >>> >>> >>> I'll consider doing that if you care to explain

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

Hello. On 12/15/2015 9:41 AM, Simon Horman wrote: Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- v3 * Moved

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

On Tuesday 15 December 2015 16:44:41 Kishon Vijay Abraham I wrote: > Hi Arnd, > > On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote: > > On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: > >> This series is basically to deprecate using phy-omap-control and use > >> syscon

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hello. On 12/15/2015 2:28 PM, Geert Uytterhoeven wrote: "So what" and "I'd like to keep my spacing as is" aren't valid reasons. Fix it, then I'll look at the rest again. I'll consider doing that if you care to explain what's the problem with my spacing. TIA. You are mixing 2 and 1

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

Hi Peter, On 16.09.2015 05:05, Peter Chen wrote: >> On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam >> wrote: >> >>> This did not help. >>> >>> It is getting late here, so I will be able to try more things tomorrow. >> >> I was able to fix it. Your initial patch had a missing

RE: [PROBLEM] usb hub malformed packets causes null pointer dereference

On Tue, 15 Dec 2015, Alan Stern wrote: > On Tue, 15 Dec 2015, Cornea, Alexandru wrote: > > > Hello, > > Apologies for the late response. > > We tried the patch, and although the system does not crash anymore, another > > issue occurs. > > Depending on platform (Gigabyte GXBT, Galileo

poweroff-issue with dwc2 on Felipe's testing/next branch

Hi, it seems the recent dwc2 additions to the testing/next branch [0] caused some interesting issue for me. Setting is a regular 4.4-rc3/4 (only with some display-stuff added), and the testing/next branch merged in. If I attach a single usb device everything still works fine, but once it is

Re: poweroff-issue with dwc2 on Felipe's testing/next branch

On 12/15/2015 3:49 PM, Heiko Stübner wrote: > Hi, > > it seems the recent dwc2 additions to the testing/next branch [0] caused > some interesting issue for me. > > Setting is a regular 4.4-rc3/4 (only with some display-stuff added), and the > testing/next branch merged in. > > If I attach a

[PATCH v4 0/3] usb: renesas_usbhs: More compat strings

Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Changes since v3: * State that one or more compat string should be used Changes since v2: *

[PATCH v4 2/3] usb: renesas_usbhs: add fallback compatibility strings

Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v4 *

[PATCH v4 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring Acked-by: Kuninori Morimoto

[PATCH v4 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

This extends the documentation of compatibility strings a little to include the SoC names. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v3 * Split into separate patch ---

RE: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

Hi Arnd, Thank you very much for your review! > From: Arnd Bergmann > Sent: Tuesday, December 15, 2015 6:30 PM > > On Tuesday 15 December 2015 15:54:32 Yoshihiro Shimoda wrote: > > R-Car H3 has USB3.0 peripheral controllers. This controller's has the > > following features: > > - Supports

RE: [PATCH] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

Hi Arnd again, > From: Yoshihiro Shimoda > Sent: Wednesday, December 16, 2015 10:43 AM < snip > > > > +static void usb3_write(struct renesas_usb3 *usb3, u32 data, u32 offs) > > > +{ > > > + iowrite32(data, usb3->reg + offs); > > > +} > > > + > > > +static u32 usb3_read(struct renesas_usb3 *usb3,

[PATCH v2] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

R-Car H3 has USB3.0 peripheral controllers. This controller's has the following features: - Supports super, high and full speed - Contains 30 pipes for bulk or interrupt transfer - Contains dedicated DMA controller This driver doesn't support the dedicated DMAC for now. Signed-off-by:

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

On Tue, Dec 15, 2015 at 09:32:18AM -0200, Fabio Estevam wrote: > On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote: > > > Thanks, Fabio. > > > > I am afraid I forget to set gpio as output, would you please apply > > below patch against my original ones: > > Same error

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

Hi, On Tuesday 15 December 2015 05:25 PM, Arnd Bergmann wrote: > On Tuesday 15 December 2015 16:44:41 Kishon Vijay Abraham I wrote: >> Hi Arnd, >> >> On Tuesday 15 December 2015 04:26 PM, Arnd Bergmann wrote: >>> On Tuesday 15 December 2015 14:45:59 Kishon Vijay Abraham I wrote: This series

Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie

Hello. On 12/15/2015 12:39 PM, Kishon Vijay Abraham I wrote: Add new device tree node for the control module register space where PCIe registers are present. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |5 + 1 file changed, 5 insertions(+)

RE: [PROBLEM] usb hub malformed packets causes null pointer dereference

Hello, Apologies for the late response. We tried the patch, and although the system does not crash anymore, another issue occurs. Depending on platform (Gigabyte GXBT, Galileo board), the USB port that is used for testing or all USB ports become blocked and cannot recognize new

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

On Tue, Dec 15, 2015 at 09:21:09PM +0100, Ulf Hansson wrote: > On 9 December 2015 at 09:55, Arnd Bergmann wrote: > > On Wednesday 09 December 2015 16:12:24 Peter Chen wrote: > >> On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote: > >> > On Tue, Dec 08, 2015 at 10:58:48AM

Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

On Tue, Dec 15, 2015 at 09:19:39PM +0100, Maciej S. Szmigiero wrote: > Hi Peter, > > On 16.09.2015 05:05, Peter Chen wrote: > >> On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam > >> wrote: > >> > >>> This did not help. > >>> > >>> It is getting late here, so I will be able to

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

* Kishon Vijay Abraham I [151215 04:47]: > On Tuesday 15 December 2015 05:25 PM, Arnd Bergmann wrote: > >>> > >>> Can you explain here what the conversion is good for? Why do you > >>> prefer the syscon mapping over a high-level driver in this case? > >> > >> phy-omap-control

RE: [PATCH] Add support for usbfs zerocopy.

From: Alan Stern > Sent: 15 December 2015 15:13 ... > > I was thinking that some side effect of dma_free_coherent() would > > find the user mapping for the pages, force unmap them and invalidate > > the user PTE (although the address range would have to remain reserved). > > Maybe that is wishful

RE: [PATCH] Add support for usbfs zerocopy.

On Tue, 15 Dec 2015, David Laight wrote: > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > Sent: 14 December 2015 17:59 > > On Mon, 14 Dec 2015, David Laight wrote: > > > > > From: Alan Stern > > > > Sent: 14 December 2015 15:28 > > > ... > > > > I thought of something else, a more

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

On Tue, 15 Dec 2015, Oliver Neukum wrote: > On Thu, 2015-12-03 at 13:36 -0500, Alan Stern wrote: > > This is an old problem, but it was never resolved and it still affects > > people (Bugzilla #89511). In short, there are USB-(S)ATA bridges that > > claim to be write-back but don't support the