Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-23 Thread Peter Chen
On Tue, Aug 23, 2016 at 09:17:02PM +0200, Stefan Wahren wrote: > Hi, > > i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with > 4.8.0-rc2-next-20160819: > > [ 420.04] ci_hdrc ci_hdrc.0: remove, state 1 > [ 420.05] usb usb1: USB disconnect, device number 1 > [

[no subject]

2016-08-23 Thread Jeffrey Chu
unsubscribe -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-08-23 Thread Stephen Boyd
On Tue, Aug 23, 2016 at 4:06 PM, Rob Herring wrote: > On Tue, Aug 23, 2016 at 3:00 PM, Stephen Boyd wrote: >> On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote: >>> Quoting Rob Herring (2016-07-17 19:23:55) On Thu, Jul 07,

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-08-23 Thread Rob Herring
On Tue, Aug 23, 2016 at 3:00 PM, Stephen Boyd wrote: > On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote: >> Quoting Rob Herring (2016-07-17 19:23:55) >>> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: >>> > +--- >>> > + >>> >

[PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-23 Thread Rafał Miłecki
From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port(s) and a proper LED telling user a device is connected. The trigger gets

[RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)

2016-08-23 Thread Guenter Roeck
This driver implements the USB Type-C Power Delivery state machine for both source and sink ports. Alternate mode support is not fully implemented. The driver attaches to the USB Type-C class code implemented in the following patches. usb: typec: add driver for Intel Whiskey Cove PMIC

[RFC PATCH v3 0/2] Type-C Port Manager

2016-08-23 Thread Guenter Roeck
The following series of patches implements a USB Type-C Port Manager using the pending USB Type-C class code as basis. The code is still WIP, but I think it is important to get feedback from the community at this point. There are two patches in the series. The first patch implements the Type-C

[RFC PATCH v3 2/2] usb: typec: Type-C Port Controller Interface driver (tcpci)

2016-08-23 Thread Guenter Roeck
The port controller interface driver interconnects the Type-C Port Manager with a Type-C Port Controller Interface (TCPCI) compliant port controller. Signed-off-by: Guenter Roeck --- v3: - No change v2: - Adjust to modified callbacks into tcpm code

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-23 Thread Alan Stern
On Thu, 18 Aug 2016, Felipe Balbi wrote: > >> You mean a ep0 ioctl? Makes sense to me. Then we can add more features > >> later. Perhaps just add a "Get supported features" IOCTL which returns > >> a struct with 256 bits (4x uint64_t). I doubt we will ever need that > >> many bits, but better

Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-08-23 Thread John Youn
On 8/21/2016 12:32 PM, Randy Li wrote: > On the rk3288 USB host-only port (the one that's not the OTG-enabled > port) the PHY can get into a bad state when a wakeup is asserted (not > just a wakeup from full system suspend but also a wakeup from > autosuspend). > > We can get the PHY out of its

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-08-23 Thread Stephen Boyd
On Fri, Aug 5, 2016 at 2:40 PM, Stephen Boyd wrote: > Quoting Rob Herring (2016-07-17 19:23:55) >> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: >> > +--- >> > + >> > +usb { >> > + compatible = "vendor,usb-controller"; >> > + >> > + ulpi { >> >

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-08-23 Thread Stephen Boyd
On Fri, Aug 5, 2016 at 2:27 PM, Stephen Boyd wrote: > Quoting Peter Chen (2016-07-08 02:04:58) >> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: >> > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct >> > device_driver *driver) >> >

[PATCH] USB: avoid left shift by -1

2016-08-23 Thread Alan Stern
UBSAN complains about a left shift by -1 in proc_do_submiturb(). This can occur when an URB is submitted for a bulk or control endpoint on a high-speed device, since the code doesn't bother to check the endpoint type; normally only interrupt or isochronous endpoints have a nonzero bInterval

usb: chipidea: hdc: kernel panic during shutdown

2016-08-23 Thread Stefan Wahren
Hi, i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with 4.8.0-rc2-next-20160819: [ 420.04] ci_hdrc ci_hdrc.0: remove, state 1 [ 420.05] usb usb1: USB disconnect, device number 1 [ 420.06] usb 1-1: USB disconnect, device number 2 [ 420.06] usb 1-1.1:

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Ritesh Raj Sarraf wrote: > This one is after a fresh boot. > > T:  Bus=02 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#=  9 Spd=480  MxCh= 0 > D:  Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=ff MxPS=64 #Cfgs=  1 > P:  Vendor=0bda ProdID=0129 Rev=39.60 > S:  Manufacturer=Generic > S:  

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Vittorio Zecca wrote: > After applying the patch above the UBSAN issue in devio.c disappeared. > > However, I got the following messages in dmesg, probably due to a > NetworkManager > malfunctioning, and if I click on the NetworkManager icon I get > "NetworkManager is not

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

2016-08-23 Thread Stefan Wahren
Hi John, > John Youn hat am 23. August 2016 um 20:37 > geschrieben: > > > > How about we fall back to smaller defaults if the original values > fail? And don't configure more than the amount of endpoints. this sounds good. I would prefer to calculate the estimated

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

2016-08-23 Thread John Youn
On 8/22/2016 9:41 PM, Stefan Wahren wrote: > Hi John, > >> John Youn hat am 23. August 2016 um 00:08 >> geschrieben: >> >> >> On 8/22/2016 1:47 PM, Stefan Wahren wrote: >>> Hi John, >>> John Youn hat am 22. August 2016 um 22:06

Re: [PATCH v3 6/7] phy-sun4i-usb: Add "allwinner,usb0-usb-a-connector" dt property

2016-08-23 Thread Hans de Goede
Hi, On 08/23/2016 08:00 PM, Rob Herring wrote: On Sun, Aug 21, 2016 at 02:16:38PM +0200, Hans de Goede wrote: On some devices the musb otg controller can be used in both device and host mode, but requires software mode switching since there is no id pin connected. The usb0 phy code will

Re: [PATCH 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-08-23 Thread Rob Herring
On Sun, Aug 21, 2016 at 03:56:43PM +0800, Randy Li wrote: > It is a hardware bug in RK3288, the only way to solve it is to > reset the phy. > > Signed-off-by: Randy Li > --- > .../devicetree/bindings/phy/rockchip-usb-phy.txt | 3 +++ > drivers/phy/phy-rockchip-usb.c

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 19:14, Jose Marino wrote: On 08/23/2016 06:36 AM, Mathias Nyman wrote: On 23.08.2016 14:26, Mathias Nyman wrote: On 23.08.2016 13:54, Mathias Nyman wrote: On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 18:10, Alan Stern wrote: On Tue, 23 Aug 2016, Mathias Nyman wrote: The Dell XPS 9550 has an additional xhci controller for handling the type-C port. This controller is hotplug removed from the PCI bus when the last USB type-c device is disconnected. xhci driver, and usb core it

[PATCH 3/3] usb: gadget: f_hid: use alloc_ep_req()

2016-08-23 Thread Felipe F. Tonello
Use gadget's framework allocation function instead of directly calling usb_ep_alloc_request(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 2/3] usb: gadget: f_hid: use free_ep_req()

2016-08-23 Thread Felipe F. Tonello
We should always use free_ep_req() when allocating requests with alloc_ep_req(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c

[PATCH 0/3] Gadget endpoint allocation request

2016-08-23 Thread Felipe F. Tonello
Patch #1 removes a unnecessary and confusing parameter from alloc_ep_req(). Also, this series updates f_hid function to use alloc/free_ep_req() instead of allocating/freeing requests directly. Felipe F. Tonello (3): usb: gadget: remove useless parameter in alloc_ep_req() usb: gadget: f_hid:

[PATCH 1/3] usb: gadget: remove useless parameter in alloc_ep_req()

2016-08-23 Thread Felipe F. Tonello
The default_length parameter of alloc_ep_req was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. This patch removes that parameter and updates all calls to alloc_ep_req() to use the new API. Signed-off-by:

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 17:53, Alan Stern wrote: On Tue, 23 Aug 2016, Mathias Nyman wrote: Or then this happens: (I'll call the hcds usb2_hcd and usb3_hcd to keep track of them, usb2_hcd is the primary_hcd) to begin with: Actually, to begin with neither usb2_hcd nor usb3_hcd exists. Then usb2_hcd

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 16:13, Greg KH wrote: On Tue, Aug 23, 2016 at 01:54:05PM +0300, Mathias Nyman wrote: On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone through the USB-C connection and in

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Jose Marino
On 08/23/2016 06:36 AM, Mathias Nyman wrote: On 23.08.2016 14:26, Mathias Nyman wrote: On 23.08.2016 13:54, Mathias Nyman wrote: On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Jose Marino
On 08/23/2016 01:57 AM, Oliver Neukum wrote: On Mon, 2016-08-22 at 17:21 -0600, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the phone I select USB tethering.

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Vittorio Zecca
After applying the patch above the UBSAN issue in devio.c disappeared. However, I got the following messages in dmesg, probably due to a NetworkManager malfunctioning, and if I click on the NetworkManager icon I get "NetworkManager is not running" but maybe this is another issue and your patch

Re: [PATCH v7] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Wenyou Yang wrote: > The usb controller does not manage correctly the suspend mode for > the ehci. In echi mode, there is no way to suspend without any > device connected to it. This is why this specific control is added > to fix this issue. Since the suspend mode works in

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-23 Thread Bin Liu
Hi, On Tue, Aug 23, 2016 at 09:57:17AM +0800, Ayaka wrote: > > > 從我的 iPad 傳送 > > > Bin Liu 於 2016年8月19日 上午12:08 寫道: > > > > Hi, > > > >> On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote: > >> Hello all: > >> I recently add a support for customize am3358 board using the

[PATCH 1/1] usb: usbip: vudc: fix left shift overflow

2016-08-23 Thread Nicolas Iooss
In v_recv_cmd_submit(), urb_p->urb->pipe has the type unsigned int (which is 32-bit long on x86_64) but 11<<30 results in a 34-bit integer. Therefore the 2 leading bits are truncated and urb_p->urb->pipe &= ~(11 << 30); has the same meaning as urb_p->urb->pipe &= ~(3 << 30); This

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Mathias Nyman wrote: > The Dell XPS 9550 has an additional xhci controller for handling the type-C > port. > This controller is hotplug removed from the PCI bus when the last USB type-c > device is disconnected. > > xhci driver, and usb core it seems is not really designed

Re: UBSAN: Undefined behaviour in linux-4.7.2/drivers/usb/core/devio.c:1713:25

2016-08-23 Thread Alan Stern
On Mon, 22 Aug 2016, Vittorio Zecca wrote: > I can reproduce the UBSAN report by inserting in the USB receptacle a > HUAWEI Mobile Broadband E353 HSPA+ USB Stick. > If there is any patch I'll be happy to try it. Thank you. Please let us know what happens with the patch below. Alan Stern

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Alan Stern
On Tue, 23 Aug 2016, Mathias Nyman wrote: > Or then this happens: > (I'll call the hcds usb2_hcd and usb3_hcd to keep track of them, usb2_hcd is > the primary_hcd) > > to begin with: Actually, to begin with neither usb2_hcd nor usb3_hcd exists. Then usb2_hcd is registered, at which point we

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Greg KH
On Tue, Aug 23, 2016 at 01:54:05PM +0300, Mathias Nyman wrote: > On 23.08.2016 02:21, Jose Marino wrote: > > I'm using my phone (Nexus 5X running Android) to tether a USB connection to > > my laptop (XPS 15 9550). I plug the phone through the USB-C connection and > > in the phone I select USB

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 14:26, Mathias Nyman wrote: On 23.08.2016 13:54, Mathias Nyman wrote: On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the phone I

[PATCH] usb: gadget: udc: renesas-usb3: clear VBOUT bit in DRD_CON

2016-08-23 Thread Yoshihiro Shimoda
This driver should clear the bit. Otherwise, the VBUS will output wrongly if the usb port on a board has VBUS output capability. Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller") Cc: # v4.5+

[PATCH v2] usb: dwc3: gadget: don't rely on jiffies while holding spinlock

2016-08-23 Thread Nicolas Saenz Julienne
__dwc3_gadget_wakeup() is called while holding a spinlock, then depends on jiffies in order to timeout while polling the USB core for a link state update. In the case the wakeup failed, the timeout will never happen and will also cause the cpu to stall until rcu_preempt kicks in. This switches to

Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

2016-08-23 Thread Felipe Ferreri Tonello
Hi Balbi, On 23/08/16 12:03, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >>> John Youn writes: On 8/8/2016 1:30 PM, Felipe F. Tonello wrote: > Use gadget's framework allocation function instead of directly calling

Re: [PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req()

2016-08-23 Thread Felipe Ferreri Tonello
Hi Balbi, On 23/08/16 12:01, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >>> "Felipe F. Tonello" writes: The default_length parameter of alloc_ep_req was not really necessary and gadget drivers would almost always

Re: [patch] USB: serial: option: add WeTelecom WM-D200

2016-08-23 Thread Aleksandr Makarov
22.08.2016 22:20, Dan Williams пишет: > On Mon, 2016-08-22 at 20:07 +0300, Aleksandr Makarov wrote: >> 22.08.2016 18:03, Dan Williams пишет: >>> >>> On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov wrote: USB: serial: option: add WeTelecom WM-D200 Add support for WeTelecom

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 13:54, Mathias Nyman wrote: On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the phone I select USB tethering. Initially things look

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-23 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 2016-08-23 at 14:21 +0530, Ritesh Raj Sarraf wrote: > In one of yesterday's email, I have shared the output of > /sys/kernel/debug/usb/devices before the bug is triggered. The same I've > pasted > below. > > T:  Bus=01 Lev=01 Prnt=01

Re: [PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req()

2016-08-23 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >> "Felipe F. Tonello" writes: >>> The default_length parameter of alloc_ep_req was not really necessary >>> and gadget drivers would almost always create an inline function to pass >>> the same value to len and

Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

2016-08-23 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >> John Youn writes: >>> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote: Use gadget's framework allocation function instead of directly calling usb_ep_alloc_request(). Signed-off-by: Felipe F.

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Mathias Nyman
On 23.08.2016 02:21, Jose Marino wrote: I'm using my phone (Nexus 5X running Android) to tether a USB connection to my laptop (XPS 15 9550). I plug the phone through the USB-C connection and in the phone I select USB tethering. Initially things look normal: a usb0 network interface appears

Re: [PATCH v2 0/6] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Tuesday 23 August 2016 03:52 PM, Vaibhav Hiremath wrote: On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement

Re: [PATCH v2 0/6] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Wednesday 13 July 2016 07:36 AM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement

Re: [PATCH v4 10/10] usb: gadget: f_hid: use alloc_ep_req()

2016-08-23 Thread Felipe Ferreri Tonello
Hi, On 22/08/16 08:45, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 8/8/2016 1:30 PM, Felipe F. Tonello wrote: >>> Use gadget's framework allocation function instead of directly calling >>> usb_ep_alloc_request(). >>> >>> Signed-off-by: Felipe F. Tonello

Re: [PATCH v4 08/10] usb: gadget: remove useless parameter in alloc_ep_req()

2016-08-23 Thread Felipe Ferreri Tonello
Hi Blabi, On 18/08/16 08:12, Felipe Balbi wrote: > > Hi, > > "Felipe F. Tonello" writes: >> The default_length parameter of alloc_ep_req was not really necessary >> and gadget drivers would almost always create an inline function to pass >> the same value to len and

Re: [PATCH V9 1/1] usb:serial: Add Fintek F81532/534 driver

2016-08-23 Thread Johan Hovold
On Tue, Aug 23, 2016 at 04:23:44PM +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi Johan, > > Johan Hovold 於 2016/8/22 下午 09:14 寫道: > >> +{ > >> + size_t count = F81534_USB_MAX_RETRY; > >> + int status; > >> + u8 *tmp; > >> + > >> + tmp = kmalloc(sizeof(u8), GFP_KERNEL); > >> + if (!tmp) > >> +

Re: [PATCH v3] usb: serial: mos7840.c Support TIOCGRS485 and TIOCSRS485 ioctls()

2016-08-23 Thread Johan Hovold
On Mon, Apr 11, 2016 at 02:27:20PM -0700, Aaron Marburg wrote: > > Add callbacks to handle TIOCGRS485 and TIOCSRS485 ioctl > calls in mos7840.c, allowing configuration of the chip's > "scratchpad" register to strobe the DTR line while transmitting. > > This functionality is required for

Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:46PM +0200, Mathieu OTHACEHE wrote: > Remove variables affected but never read. This commit message is also incomplete. The tp_flags variable was indeed read, even if it was always ANDed with 0. I applied it anyway this time, and also dropped the now unused

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-23 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thank you Alan for confirming the bug. On Mon, 2016-08-22 at 15:09 -0400, Alan Stern wrote: > > https://people.debian.org/~rrs/tmp/usb_1u-usbmon.txt.gz > >  > > https://people.debian.org/~rrs/tmp/dmesg-usbmon.txt > > The usbmon trace shows two

Re: [PATCH V9 1/1] usb:serial: Add Fintek F81532/534 driver

2016-08-23 Thread Ji-Ze Hong (Peter Hong)
Hi Johan, Johan Hovold 於 2016/8/22 下午 09:14 寫道: +static const struct reg_value f81534_pin_control[4][3] = { + /* M0_SDM1 M2 */ + {{0x2ae8, 7}, {0x2a90, 5}, {0x2a90, 4}, }, /* port 0 pins */ + {{0x2ae8, 6}, {0x2ae8, 0}, {0x2ae8, 3}, }, /* port 1

Re: [PATCH v2 07/22] usb: serial: ti_usb_3410_5052: Use macros instead of magic values

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:47PM +0200, Mathieu OTHACEHE wrote: > Use macros to define 3410 and 5052 baud bases. > Use macro to define usb download timeout. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 22 +++--- > 1

Re: [PATCH v2 04/22] usb: serial: ti_usb_3410_5052: Remove useless NULL-testing

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:44PM +0200, Mathieu OTHACEHE wrote: > It is useless to check the return of usb_get_serial_port_data. Please be more specific in your commit messages in general. In this case it should mention that there's no need to check for NULL private data in the tty or tty-port

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-23 Thread Oliver Neukum
On Mon, 2016-08-22 at 17:21 -0600, Jose Marino wrote: > I'm using my phone (Nexus 5X running Android) to tether a USB connection > to my laptop (XPS 15 9550). I plug the phone through the USB-C > connection and in the phone I select USB tethering. Initially things > look normal: a usb0 network

Re: [PATCH v2 03/22] usb: serial: ti_usb_3410_5052: Use kzalloc instead of kmalloc

2016-08-23 Thread Johan Hovold
On Wed, Jul 27, 2016 at 02:46:32PM +0200, Mathieu OTHACEHE wrote: > > > in that case, where is the initialisation to 0 you avoid and hence > > can remove from the code? > > Hi, > > In v1, kzalloc was useful to avoid wFlags initialisation to 0 : > > https://lkml.org/lkml/2016/5/12/139 > > In

Re: [PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:42PM +0200, Mathieu OTHACEHE wrote: > Remove useless or redundant dev_dbg messages. > Fix debug-message typos. You never fix any typos, and forgot to mention the added NULL-check for oldtermios, which is currently not needed and really should go in its own patch. >

Re: [PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types

2016-08-23 Thread Johan Hovold
On Tue, Jul 26, 2016 at 07:59:41PM +0200, Mathieu OTHACEHE wrote: > __uX types should only be used for user-space interactions. > > Signed-off-by: Mathieu OTHACEHE > --- > > Changelog: > v2: > * Replace cpu_to_be16s calls by cpu_to_be16 > * Remove other useless casts You