Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-08 Thread John Stultz
On Thu, Dec 8, 2016 at 11:09 PM, Chen Yu wrote: > On 2016/12/9 7:29, John Youn wrote: >> On 12/8/2016 2:43 PM, John Stultz wrote: >>> On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: On 12/6/2016 5:48 PM, John Stultz wrote: > This patch works

Re: Emulating USB devices from userspace

2016-12-08 Thread Greg Kroah-Hartman
On Fri, Dec 09, 2016 at 12:38:23AM +0100, Andrey Konovalov wrote: > Hi, > > I'm working on a way to extend syzkaller [1] to support fuzzing of the > USB subsystem. The idea is to be able to emulate various USB devices > and fuzz communication between the emulated device and the kernel. I'm >

Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error

2016-12-08 Thread Greg Kroah-Hartman
On Thu, Dec 08, 2016 at 10:30:35PM +, manju goudar wrote: > > > On Thu, Dec 8, 2016 at 4:49 PM, Greg Kroah-Hartman > > wrote: > > On Wed, Dec 07, 2016 at 11:37:45PM +, csmanjuvi...@gmail.com wrote: > > From: Manjunath Goudar

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-08 Thread Chen Yu
On 2016/12/9 7:29, John Youn wrote: > On 12/8/2016 2:43 PM, John Stultz wrote: >> On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: >>> On 12/6/2016 5:48 PM, John Stultz wrote: Hey John, Just wanted to send this by you, as it seems something is slightly

[PATCH V1 0/2] Implement break control for F81232/F81534

2016-12-08 Thread Ji-Ze Hong (Peter Hong)
The following 2 patches makes break control available for Fintek F81232/F81534. Ji-Ze Hong (Peter Hong) (2): usb:serial: Implement Fintek F81232 break on/off usb:serial: Implement Fintek f81534 break on/off drivers/usb/serial/f81232.c | 40 ++--

[PATCH V1 2/2] usb:serial: Implement Fintek f81534 break on/off

2016-12-08 Thread Ji-Ze Hong (Peter Hong)
Implement Fintek f81534 break on/off with LCR register It's the same with 16550A LCR register layout We'll add a shadow LCR variable to save the final LCR we had set due to the "read ep0" operations maybe slow down all the serial ports performance. Signed-off-by: Ji-Ze Hong (Peter Hong)

[PATCH V1 1/2] usb:serial: Implement Fintek F81232 break on/off

2016-12-08 Thread Ji-Ze Hong (Peter Hong)
Implement Fintek F81232 break on/off with LCR register, it's the same with 16550A LCR register layout. Signed-off-by: Ji-Ze Hong (Peter Hong) --- drivers/usb/serial/f81232.c | 40 ++-- 1 file changed, 34 insertions(+), 6

Re: ch341

2016-12-08 Thread Russell Senior
On Thu, Dec 8, 2016 at 10:02 AM, Johan Hovold wrote: > On Thu, Dec 08, 2016 at 04:41:44AM -0800, Russell Senior wrote: >> > "Johan" == Johan Hovold writes: >> >> [...] >> >> Johan> Ok, and you were using a terminal program such as minicom that >> Johan>

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-12-08 Thread Hayes Wang
Mark Lord I find an issue about autosuspend, and it may result in the same problem with you. I don't sure if this is helpful to you, because it only occurs when enabling the autosuspend. Best Regards, Hayes /* * Copyright (c) 2014 Realtek Semiconductor Corp. All rights

Re: [PATCH] usb: gadget: f_fs: Fix possibe deadlock

2016-12-08 Thread Baolin Wang
Hi Michal, On 8 December 2016 at 23:18, Michal Nazarewicz wrote: > On Thu, Dec 08 2016, Baolin Wang wrote: >> When system try to close /dev/usb-ffs/adb/ep0 on one core, at the same >> time another core try to attach new UDC, which will cause deadlock as >> below scenario. Thus

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Baolin Wang
Hi, On 9 December 2016 at 01:52, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Baolin Wang writes: >> On 28 November 2016 at 14:43, Baolin Wang wrote: >>> For some mobile devices with

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread Shuah Khan
On 12/08/2016 05:08 PM, fx IWATA NOBUO wrote: > Dear Shuah, > > Sorry for taking time. > > It's caused by my patch. > It was included "vhci number of ports extension" patch set. > The set consists of 3 patches. > > The fixing was included in v5. > Only 1/3 of the set was merged but I missed to

[RFC][PATCH] usb: dwc2: Avoid sleeping while holding hsotg->lock

2016-12-08 Thread John Stultz
Basically when plugging in various cables in different orders, I'm occasionally seeing the following BUG splat: [ 86.215403] BUG: scheduling while atomic: kworker/u16:2/53/0x0002 [ 86.219164] usb 1-1: USB disconnect, device number 9 [ 86.226845] Preemption disabled at:[ 86.230218] []

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Stultz
On Thu, Dec 8, 2016 at 4:31 PM, John Youn wrote: > On 12/8/2016 4:25 PM, John Stultz wrote: >> On Thu, Dec 8, 2016 at 4:17 PM, John Youn wrote: >>> On 12/8/2016 3:12 PM, John Stultz wrote: Hey John, In my testing I've come across

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Youn
On 12/8/2016 4:25 PM, John Stultz wrote: > On Thu, Dec 8, 2016 at 4:17 PM, John Youn wrote: >> On 12/8/2016 3:12 PM, John Stultz wrote: >>> Hey John, >>> In my testing I've come across another issue in the dwc2 driver. >>> >>> Basically when plugging in various cables in

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Stultz
On Thu, Dec 8, 2016 at 4:17 PM, John Youn wrote: > On 12/8/2016 3:12 PM, John Stultz wrote: >> Hey John, >> In my testing I've come across another issue in the dwc2 driver. >> >> Basically when plugging in various cables in different orders, I'm >> occasionally seeing

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Youn
On 12/8/2016 3:12 PM, John Stultz wrote: > Hey John, > In my testing I've come across another issue in the dwc2 driver. > > Basically when plugging in various cables in different orders, I'm > occasionally seeing the following BUG splat: > > [ 86.215403] BUG: scheduling while atomic:

RE: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread fx IWATA NOBUO
Dear Shuah, Sorry for taking time. It's caused by my patch. It was included "vhci number of ports extension" patch set. The set consists of 3 patches. The fixing was included in v5. Only 1/3 of the set was merged but I missed to check the fixing line. This time, I took my time to check

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Grygorii Strashko [161208 15:38]: > On 12/08/2016 04:57 PM, Tony Lindgren wrote: > > Seems to work based on few boot tests. Probably both should be applied, > > my original patch to prevent spurious interrupts before things are > > initialized, > > you patch - do you

Emulating USB devices from userspace

2016-12-08 Thread Andrey Konovalov
Hi, I'm working on a way to extend syzkaller [1] to support fuzzing of the USB subsystem. The idea is to be able to emulate various USB devices and fuzz communication between the emulated device and the kernel. I'm looking for a way to emulate devices from userspace. Similar to how tuntap allows

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Grygorii Strashko
On 12/08/2016 04:57 PM, Tony Lindgren wrote: * Grygorii Strashko [161208 13:54]: Hi Tony, On 12/08/2016 09:37 AM, Tony Lindgren wrote: * Felipe Balbi [161208 01:45]: Tony Lindgren writes: Somehow starting with v4.9-rc7 there

Re: usb/gadget: use-after-free in gadgetfs_setup

2016-12-08 Thread Andrey Konovalov
On Wed, Dec 7, 2016 at 8:15 PM, Alan Stern wrote: > On Wed, 7 Dec 2016, Andrey Konovalov wrote: > >> > And in any case, is there any way you can post the series of system >> > calls that syzkaller makes so we can tell what went wrong? >> >> I've attached a reproducer

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-08 Thread John Youn
On 12/8/2016 2:43 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: >> On 12/6/2016 5:48 PM, John Stultz wrote: >>> Hey John, >>> Just wanted to send this by you, as it seems something is >>> slightly off with the GOTGCTL state when removing a otg

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Stultz
On Thu, Dec 8, 2016 at 3:12 PM, John Stultz wrote: > Hey John, > In my testing I've come across another issue in the dwc2 driver. > > Basically when plugging in various cables in different orders, I'm > occasionally seeing the following BUG splat: > > [ 86.215403] BUG:

BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

2016-12-08 Thread John Stultz
Hey John, In my testing I've come across another issue in the dwc2 driver. Basically when plugging in various cables in different orders, I'm occasionally seeing the following BUG splat: [ 86.215403] BUG: scheduling while atomic: kworker/u16:2/53/0x0002 [ 86.219164] usb 1-1: USB

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Grygorii Strashko [161208 13:54]: > Hi Tony, > > On 12/08/2016 09:37 AM, Tony Lindgren wrote: > > * Felipe Balbi [161208 01:45]: > >> Tony Lindgren writes: > >>> Somehow starting with v4.9-rc7 there have been imprecise > >> > >>

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

2016-12-08 Thread John Stultz
On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: > On 12/6/2016 5:48 PM, John Stultz wrote: >> Hey John, >> Just wanted to send this by you, as it seems something is >> slightly off with the GOTGCTL state when removing a otg adapter >> cable. The following seems to work

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Grygorii Strashko
Hi Tony, On 12/08/2016 09:37 AM, Tony Lindgren wrote: > * Felipe Balbi [161208 01:45]: >> Tony Lindgren writes: >>> Somehow starting with v4.9-rc7 there have been imprecise >> >> There's nothing touching dwc3 since v4.9-rc5. > > Right, nothing obvious has

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 12:10]: > > Hi, > > Tony Lindgren writes: > >> nothing against it. Would be nice if TI could confirm this is needed and > >> check if other families might also need it. > > > > But as we currently are not using the WRAPRESET bit, the

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 12:12]: > > Hi, > > Tony Lindgren writes: > > * Felipe Balbi [161208 11:17]: > >> Tony Lindgren writes: > >> > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. > >> > >> right,

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 11:17]: >> Tony Lindgren writes: >> > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. >> >> right, but there's no runtime suspend until ->remove(). IOW, after >>

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: >> nothing against it. Would be nice if TI could confirm this is needed and >> check if other families might also need it. > > But as we currently are not using the WRAPRESET bit, the reset > function is nop except for the delay. So this just papers

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 11:17]: > Tony Lindgren writes: > > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. > > right, but there's no runtime suspend until ->remove(). IOW, after > pm_runtime_get_sync(), all necessary clocks should already

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 11:19]: > > Hi, > > Tony Lindgren writes: > >> Is there also some dwc3 internal clock? If we assume the usb_otg_ss > >> module is properly enabled it could be some dwc3 internal clock not > >> enabled? > >> > >> We do have a

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: >> Is there also some dwc3 internal clock? If we assume the usb_otg_ss >> module is properly enabled it could be some dwc3 internal clock not >> enabled? >> >> We do have a srst_udelay needed for enabling musb controller for some >> SoCs, I'll check

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 09:52]: >> >> Hi, >> >> Tony Lindgren writes: >> > * Felipe Balbi [161208 01:45]: >> >> >> >> Hi, >> >> >> >> Tony Lindgren writes: >> >> >

[PATCH v3] USB: Add uPD78F0730 USB to Serial Adaptor Driver

2016-12-08 Thread Maksim Salau
The adaptor can be found on development boards for 78k, RL78 and V850 microcontrollers produced by Renesas Electronics Corporation. This is not a full-featured USB to serial converter, however it allows basic communication and simple control which is enough for programming of on-board flash and

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Tony Lindgren [161208 10:45]: > * Tony Lindgren [161208 10:25]: > > * Felipe Balbi [161208 09:52]: > > > > > > Hi, > > > > > > Tony Lindgren writes: > > > > * Felipe Balbi [161208 01:45]: > > > >> >

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-12-08 Thread Tony Lindgren
* Laurent Pinchart [161208 04:03]: > Hi Tony, > > On Wednesday 07 Dec 2016 21:51:23 Tony Lindgren wrote: > > * Laurent Pinchart [161123 08:44]: > > > On Wednesday 23 Nov 2016 18:40:09 Tomi Valkeinen wrote: > > >> On 23/11/16

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Tony Lindgren [161208 10:25]: > * Felipe Balbi [161208 09:52]: > > > > Hi, > > > > Tony Lindgren writes: > > > * Felipe Balbi [161208 01:45]: > > >> > > >> Hi, > > >> > > >> Tony Lindgren writes: >

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 09:52]: > > Hi, > > Tony Lindgren writes: > > * Felipe Balbi [161208 01:45]: > >> > >> Hi, > >> > >> Tony Lindgren writes: > >> > Somehow starting with v4.9-rc7 there have been imprecise > >> >

Re: [PATCH 0/1] NET: usb: cdc_mbim: add quirk for supporting Telit LE922A

2016-12-08 Thread David Miller
From: Daniele Palmas Date: Wed, 7 Dec 2016 14:07:47 +0100 > Telit LE922A MBIM based composition does not work properly > with altsetting toggle done in cdc_ncm_bind_common. > > This patch adds CDC_MBIM_FLAG_AVOID_ALTSETTING_TOGGLE quirk > to avoid this procedure that,

Re: ch341

2016-12-08 Thread Johan Hovold
On Thu, Dec 08, 2016 at 04:41:44AM -0800, Russell Senior wrote: > > "Johan" == Johan Hovold writes: > > [...] > > Johan> Ok, and you were using a terminal program such as minicom that > Johan> properly configures the port for say 8-bit words? > > I was using GNU screen,

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Felipe Balbi
Hi, Baolin Wang writes: >> Baolin Wang writes: > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to >> suspend >> the host when the

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > * Felipe Balbi [161208 01:45]: >> >> Hi, >> >> Tony Lindgren writes: >> > Somehow starting with v4.9-rc7 there have been imprecise >> >> There's nothing touching dwc3 since v4.9-rc5. > > Right, nothing

RE: USB3.0 DWC3 can't work with latest Linux-4.9.rc7

2016-12-08 Thread Jerry Huang
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Thursday, December 08, 2016 5:46 PM > To: Jerry Huang ; st...@rowland.harvard.edu; > linux-usb@vger.kernel.org; Mathias Nyman > ; Arnd Bergmann

Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error

2016-12-08 Thread Greg Kroah-Hartman
On Wed, Dec 07, 2016 at 11:37:45PM +, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > This patch will fix the checkpatch.pl following warnings and error: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a

[v1] usb:gadget:legacy:nokia :- Check for NULL in nokia_bind_config

2016-12-08 Thread Arvind Yadav
Here, f_acm,f_ecm and f_msg needs to be checked for being NULL in nokia_bind_config() before calling usb_add_function(), otherwise kernel can run into a NULL-pointer dereference. f_phonet, f_obex1 and f_obex2 need to be checked for NULL in nokia_bind_config() to print proper debug information.

Re: vUDC

2016-12-08 Thread Shuah Khan
On 12/08/2016 08:07 AM, Krzysztof Opasiak wrote: > Hi, > > On 12/08/2016 03:33 PM, Shuah Khan wrote: >> Hi Elen, >> >> Adding k.opas...@samsung.com >> >> On Thu, Dec 8, 2016 at 7:07 AM, Elen Niedermeyer >> wrote: >>> Dear Sir or Madam, >>> >>> I'm trying to run

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Tony Lindgren
* Felipe Balbi [161208 01:45]: > > Hi, > > Tony Lindgren writes: > > Somehow starting with v4.9-rc7 there have been imprecise > > There's nothing touching dwc3 since v4.9-rc5. Right, nothing obvious has changed. I think it's just a slight timing change in

Re: [PATCH] usb: gadget: f_fs: Fix possibe deadlock

2016-12-08 Thread Michal Nazarewicz
On Thu, Dec 08 2016, Baolin Wang wrote: > When system try to close /dev/usb-ffs/adb/ep0 on one core, at the same > time another core try to attach new UDC, which will cause deadlock as > below scenario. Thus we should release ffs lock before issuing > unregister_gadget_item(). > > [ 52.642225]

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Greg KH
On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote: > > Do you have a driver that was based on this skeleton that needed this > > flag to be added to work properly? Has it been updated in the kernel > > source tree properly for it? > > > > Yes, Based on the skeleton driver, I made a

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Jae Joong Kim
Hi Greg 2016-12-08 19:40 GMT+09:00 Greg KH : > On Thu, Dec 08, 2016 at 05:20:28PM +0900, Jae Joong Kim wrote: >> Hi Greg >> >> I think 'urb->transfer_flags' also has URB_ZERO_PACKET flag to handle >> the data is aligned to an endpoint packet boundary. >> >> How do you

Re: vUDC

2016-12-08 Thread Krzysztof Opasiak
Hi, On 12/08/2016 03:33 PM, Shuah Khan wrote: > Hi Elen, > > Adding k.opas...@samsung.com > > On Thu, Dec 8, 2016 at 7:07 AM, Elen Niedermeyer > wrote: >> Dear Sir or Madam, >> >> I'm trying to run usbip-vudc since a few days. I want to access my emulated >>

Re: vUDC

2016-12-08 Thread Shuah Khan
Hi Elen, Adding k.opas...@samsung.com On Thu, Dec 8, 2016 at 7:07 AM, Elen Niedermeyer wrote: > Dear Sir or Madam, > > I'm trying to run usbip-vudc since a few days. I want to access my emulated > usb devices over usbip. > I use Ubuntu 16.04.01 and updated my

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-08 Thread Shuah Khan
On 12/07/2016 09:12 PM, fx IWATA NOBUO wrote: > Dear Shuah, > >> I noticed that in many places sysfs_attr_init() is called before populating >> the fields such as name etc. However, I don't think the order matters. >> >> sysfs_attr_init() doesn't depend on name or any other fields being set: >>

vUDC

2016-12-08 Thread Elen Niedermeyer
Dear Sir or Madam, I'm trying to run usbip-vudc since a few days. I want to access my emulated usb devices over usbip. I use Ubuntu 16.04.01 and updated my kernel to version 4.8.0-30. I've installed linux-tools-4.8.0-30-generic which includes usbip. I enabled the modules usbip-host and

Re: [PATCH] usb: misc: rio500: fix result type for error message

2016-12-08 Thread Jae Joong Kim
Hi Greg, It was my fault to reply email to you except Linux USB mailing list. So, I resend a reply email :) 2016-12-08 9:45 GMT+09:00 Jae Joong Kim : > Hi Greg > > 2016-12-07 23:50 GMT+09:00 Greg KH : >> >> On Wed, Dec 07, 2016 at 08:12:10PM +0900, Kim Jae

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-08 Thread Jacek Anaszewski
On 12/08/2016 12:38 PM, Rafał Miłecki wrote: On 8 December 2016 at 09:40, Jacek Anaszewski wrote: On 12/06/2016 06:29 PM, Rafał Miłecki wrote: On 6 December 2016 at 18:26, Pavel Machek wrote: On Fri 2016-12-02 09:48:18, Ralph Sennhauser wrote: On

Re: ch341

2016-12-08 Thread Russell Senior
> "Johan" == Johan Hovold writes: Johan> This may be a bit of long shot (or maybe not) but could you try Johan> the below patch on top of usb-next as well? [...] Russell> Your patch seems to have fixed it! Yay! Oops, not so fast. It worked in loopback, but it didn't

Re: ch341

2016-12-08 Thread Russell Senior
> "Johan" == Johan Hovold writes: [...] Johan> Ok, and you were using a terminal program such as minicom that Johan> properly configures the port for say 8-bit words? I was using GNU screen, which I don't specifically configure to be 8-bits, but I retried with minicom and

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

2016-12-08 Thread Laurent Pinchart
Hi Tony, On Wednesday 07 Dec 2016 21:51:23 Tony Lindgren wrote: > * Laurent Pinchart [161123 08:44]: > > On Wednesday 23 Nov 2016 18:40:09 Tomi Valkeinen wrote: > >> On 23/11/16 18:34, Tony Lindgren wrote: > >>> OK. And what changes to your current .config make

[PATCH] usb: gadget: f_fs: Fix possibe deadlock

2016-12-08 Thread Baolin Wang
When system try to close /dev/usb-ffs/adb/ep0 on one core, at the same time another core try to attach new UDC, which will cause deadlock as below scenario. Thus we should release ffs lock before issuing unregister_gadget_item(). [ 52.642225] c1

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-08 Thread Rafał Miłecki
On 8 December 2016 at 09:40, Jacek Anaszewski wrote: > On 12/06/2016 06:29 PM, Rafał Miłecki wrote: >> >> On 6 December 2016 at 18:26, Pavel Machek wrote: >>> >>> On Fri 2016-12-02 09:48:18, Ralph Sennhauser wrote: On Thu, 1 Dec 2016 17:56:07

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Baolin Wang
Hi, On 8 December 2016 at 19:02, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: On 28 November 2016 at 14:43, Baolin Wang wrote: > For some mobile devices with strict power management, we also want to >

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> On 28 November 2016 at 14:43, Baolin Wang wrote: For some mobile devices with strict power management, we also want to suspend the host when the slave is detached for power saving. Thus we add the host

RE: USB3.0 DWC3 can't work with latest Linux-4.9.rc7

2016-12-08 Thread Felipe Balbi
Hi, Jerry Huang writes: >> -Original Message- >> From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] >> Sent: Thursday, December 08, 2016 5:46 PM >> To: Jerry Huang ; st...@rowland.harvard.edu; >> linux-usb@vger.kernel.org; Mathias Nyman >>

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-08 Thread Greg Kroah-Hartman
On Thu, Dec 08, 2016 at 09:40:43AM +0100, Jacek Anaszewski wrote: > Hi Rafał, > > On 12/06/2016 06:29 PM, Rafał Miłecki wrote: > > On 6 December 2016 at 18:26, Pavel Machek wrote: > > > On Fri 2016-12-02 09:48:18, Ralph Sennhauser wrote: > > > > On Thu, 1 Dec 2016 17:56:07 +0100 >

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Greg KH
On Thu, Dec 08, 2016 at 05:20:28PM +0900, Jae Joong Kim wrote: > Hi Greg > > I think 'urb->transfer_flags' also has URB_ZERO_PACKET flag to handle > the data is aligned to an endpoint packet boundary. > > How do you think this change? > > diff --git a/drivers/usb/usb-skeleton.c

Re: ch341

2016-12-08 Thread Johan Hovold
On Thu, Dec 08, 2016 at 10:37:28AM +0100, Johan Hovold wrote: > [ +CC: Adain, Grigori, Karl ] > > On Wed, Dec 07, 2016 at 05:51:33PM -0800, Russell Senior wrote: > > I still suspect shoddy hardware. It would be nice to hear someone else > > with the ch341-based hardware to say it works for

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Baolin Wang
Hi, On 8 December 2016 at 17:40, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi Felipe, >> >> On 28 November 2016 at 14:43, Baolin Wang wrote: >>> For some mobile devices with strict power management, we also want to

[PATCH] usb: dwc3: skip interrupt when ep disabled

2016-12-08 Thread Janusz Dziedzic
In case EP disabled pass only EPCPLT command to be handled. In other case we could hit Bug like below. BUG: unable to handle kernel NULL pointer dereference at 0003 IP: [] dwc3_thread_interrupt+0x11c8/0x1790 while dep->endpoint.desc is NULL. Signed-off-by: Janusz Dziedzic

RE: USB3.0 DWC3 can't work with latest Linux-4.9.rc7

2016-12-08 Thread Felipe Balbi
Hi, Jerry Huang writes: [...] >> >> >> oh, it's the DMA thing. We have patches going to next for this. >> >> >> Arnd, do you know if next has all missing pieces? There was >> >> >> something pending on XHCI IIRC, right? >> >> > So, there are some patches for this issue?

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

2016-12-08 Thread Felipe Balbi
Hi, Tony Lindgren writes: > Somehow starting with v4.9-rc7 there have been imprecise There's nothing touching dwc3 since v4.9-rc5. > external aborts on omap5-uevm dwc3 controller. I have not been > able to bisect what exactly triggered this as it does not always > happen. It

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

2016-12-08 Thread Felipe Balbi
Hi, Baolin Wang writes: > Hi Felipe, > > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to suspend >> the host when the slave is detached for power saving. Thus we add the

Re: ch341

2016-12-08 Thread Johan Hovold
[ +CC: Adain, Grigori, Karl ] On Wed, Dec 07, 2016 at 05:51:33PM -0800, Russell Senior wrote: > > "Johan" == Johan Hovold writes: > > >> I attach the tty's with GNU screen (but I have also tried microcom > >> and minicom with the same results). This was my first

Re: [PATCH] USB: serial: option: add dlink dwm-158

2016-12-08 Thread Johan Hovold
On Wed, Dec 07, 2016 at 09:51:50PM +0100, Giuseppe Lippolis wrote: > Dear Johan, > Thanks for the tips. > > Here is the patch. > Bye. > > --- Great, this one would have applied fine (but of course lacks a commit message and Signed-off-by). I already applied your previous submission. Also note

Re: [BUG 4.9] New led trigger usbport gets the kernel to panic

2016-12-08 Thread Jacek Anaszewski
Hi Rafał, On 12/06/2016 06:29 PM, Rafał Miłecki wrote: On 6 December 2016 at 18:26, Pavel Machek wrote: On Fri 2016-12-02 09:48:18, Ralph Sennhauser wrote: On Thu, 1 Dec 2016 17:56:07 +0100 Rafał Miłecki wrote: On 12/01/2016 03:28 PM, Ralph Sennhauser

add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-08 Thread Jae Joong Kim
Hi Greg I think 'urb->transfer_flags' also has URB_ZERO_PACKET flag to handle the data is aligned to an endpoint packet boundary. How do you think this change? diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index 5133a07..e5c9261b 100644 --- a/drivers/usb/usb-skeleton.c