A lot of messages "gspca_zc3xx 1-9.1.1:1.0: URB error -71, resubmitting" in kernel log without clear reason

2016-12-27 Thread Михаил Гаврилов
Hi! Any idea how find root of problem? Thanks. -- Best Regards, Mike Gavrilov. system.log.bz2 Description: BZip2 compressed data

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Alan Stern
On Tue, 27 Dec 2016, George Cherian wrote: > Hi Alan, > > > On Tuesday 27 December 2016 08:50 PM, Alan Stern wrote: > > On Tue, 27 Dec 2016, Oliver Neukum wrote: > > > >> On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > >>> I don't see how this patch fixes anything. Unless I'm mistaken,

RE: net2280 Driver Bug

2016-12-27 Thread Raz Manor
I'm not entirely sure either, that is why I wanted the specs. Alan sent me the PLX NET2280 specs, but I'm using the USB3380/USB3381 - the USB3 version of the device. As it seems from the code, the HW interface is mostly the same, with some minor changes, so it is the same driver (net2280.c) but

Re: [PATCH] usb: mtu3: fix U3 port link issue

2016-12-27 Thread Chunfeng Yun
Hi, On Tue, 2016-12-27 at 13:22 +0200, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > the issue is introduced when @is_u3_ip is used in mtu3_device_enabe() > > before initialized in mtu3_mem_alloc(), so get global IP information > > at first before used by

[PATCH] HID: usbhid: Add quirk for the Futaba TOSD-5711BB VFD

2016-12-27 Thread Alex Wood
Sorry, first time patcher here, and forgot to include the list when I sent this patch to Jiri and Benjamin last week. The Futaba TOSD-5711BB VFD crashes when the initial HID report is requested, register the display in hid-ids and tell hid-quirks to not do the init. Signed-off-by: Alex Wood

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread George Cherian
Hi Alan, On Tuesday 27 December 2016 08:50 PM, Alan Stern wrote: On Tue, 27 Dec 2016, Oliver Neukum wrote: On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: I don't see how this patch fixes anything. Unless I'm mistaken, it just avoids the problem by preventing the system from issuing

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Oliver Neukum
On Tue, 2016-12-27 at 10:20 -0500, Alan Stern wrote: > On Tue, 27 Dec 2016, Oliver Neukum wrote: > > > On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > > > I don't see how this patch fixes anything. Unless I'm mistaken, it > > > just avoids the problem by preventing the system from issuing

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Alan Stern
On Tue, 27 Dec 2016, Oliver Neukum wrote: > On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > > I don't see how this patch fixes anything. Unless I'm mistaken, it > > just avoids the problem by preventing the system from issuing the > > command that provokes the error, rather than really

Re: net/gadget: slab-out-of-bounds write in dev_config

2016-12-27 Thread Alan Stern
On Tue, 27 Dec 2016, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: > > On Tue, 6 Dec 2016, Andrey Konovalov wrote: > > > >> Hi! > >> > >> I've got the following error report while running the syzkaller fuzzer. > >> > >> ep0_write() doesn't check the length, so

RE: net2280 Driver Bug

2016-12-27 Thread Alan Stern
On Mon, 26 Dec 2016, Linus Torvalds wrote: > On Dec 26, 2016 4:04 PM, "Alan Stern" wrote: > > > Note that the usage of tmp in the "if (unlikely(req->td->dmadesc == 0)) {" > branch really is not conflicting, because that branch breaks out of the > enclosing "while" loop. > > > No. > > Look

Re: [PATCH v2] usb: musb: blackfin: add bfin_fifo_offset in bfin_ops

2016-12-27 Thread Bin Liu
On Thu, Dec 22, 2016 at 05:11:20PM +0100, Jérémy Lefaure wrote: > From: Jérémy Lefaure > > The function bfin_fifo_offset is defined but not used: > > drivers/usb/musb/blackfin.c:36:12: warning: ‘bfin_fifo_offset’ defined > but not used [-Wunused-function] > static

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Oliver Neukum
On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > I don't see how this patch fixes anything. Unless I'm mistaken, it > just avoids the problem by preventing the system from issuing the > command that provokes the error, rather than really fixing the > underlying error. Please clarify. If a

[PATCH] usb: dwc3: pci: add Intel Gemini Lake PCI ID

2016-12-27 Thread Felipe Balbi
From: Heikki Krogerus Intel Gemini Lake SoC has the same DWC3 than Broxton. Add the new ID to the supported Devices. Signed-off-by: Heikki Krogerus Signed-off-by: Felipe Balbi ---

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Baolin Wang
Hi, On 27 December 2016 at 19:11, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi, >> >> On 27 December 2016 at 18:52, Janusz Dziedzic >> wrote: >>> 2016-12-26 9:01 GMT+01:00 Baolin Wang :

[PATCH 2/3] usb: dwc3: ep0: explicitly call dwc3_ep0_prepare_one_trb()

2016-12-27 Thread Felipe Balbi
Let's call dwc3_ep0_prepare_one_trb() explicitly because there are occasions where we will need more than one TRB to handle an EP0 transfer. A follow-up patch will fix one bug related to multiple-TRB Data Phases when it comes to mapping/unmapping requests for DMA. Cc:

[PATCH 3/3] usb: dwc3: gadget: always unmap EP0 requests

2016-12-27 Thread Felipe Balbi
commit 0416e494ce7d ("usb: dwc3: ep0: correct cache sync issue in case of ep0_bounced") introduced a bug where we would leak DMA resources which would cause us to starve the system of them resulting in failing DMA transfers. Fix the bug by making sure that we always unmap EP0 requests since those

[PATCH 1/3] usb: dwc3: ep0: add dwc3_ep0_prepare_one_trb()

2016-12-27 Thread Felipe Balbi
For now this is just a cleanup patch, no functional changes. We will be using the new function to fix a bug introduced long ago by commit 0416e494ce7d ("usb: dwc3: ep0: correct cache sync issue in case of ep0_bounced") and further worsened by commit c0bd5456a470 ("usb: dwc3: ep0: handle non

[PATCH 2/3] usb: dwc3: gadget: make use of No Response Update Transfer

2016-12-27 Thread Felipe Balbi
commit 8897a761c371ceefda98570953185daa3c059ad1 upstream No Response Update Transfer is a special type of Update Transfer command which can be used whenever we're not relying on XferNotReady to prepare transfers. With this, we don't need to wait for CMDACT to be cleared and issue further commands

[PATCH 1/3] usb: dwc3: gadget: properly check ep cmd

2016-12-27 Thread Felipe Balbi
commit 514f227b20addf01297b3df24be6b4161f69 upstream. The cmd argument we pass to dwc3_send_gadget_ep_cmd() could contain extra arguments embedded. When checking for StartTransfer command, we need to make sure to match only lower 4 bits which contain the actual command and ignore the rest.

Re: usb/gadget: warning in dummy_free_request

2016-12-27 Thread Felipe Balbi
Hi, Andrey Konovalov writes: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > WARNING: CPU: 0 PID: 5257 at drivers/usb/gadget/udc/dummy_hcd.c:672 >

Re: [PATCH 0/9] usb: dwc2: Fix checkpatch issues

2016-12-27 Thread Felipe Balbi
Hi John, John Youn writes: > The dwc2 driver triggers several hundred checkpatch warnings and > checks. None of them are actual problems but this is still very noisy. > This series fixes most of those issues. > > The first patch in the series is the result of running

Re: [PATCH v2] usb: dwc3: pci: Add "linux,sysdev_is_parent" property

2016-12-27 Thread Felipe Balbi
Hi, John Youn writes: > Calling platform_device_add_properties() replaces existing properties so > the "linux,sysdev_is_parent" property doesn't get set. Add this property > to each platform. > > Fixes: d64ff406e51e ("usb: dwc3: use bus->sysdev for DMA configuration") >

Re: [PATCH] usb: mtu3: fix U3 port link issue

2016-12-27 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > the issue is introduced when @is_u3_ip is used in mtu3_device_enabe() > before initialized in mtu3_mem_alloc(), so get global IP information > at first before used by following functins. > > Signed-off-by: Chunfeng Yun

Re: net/gadget: slab-out-of-bounds write in dev_config

2016-12-27 Thread Felipe Balbi
Hi, Alan Stern writes: > On Tue, 6 Dec 2016, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following error report while running the syzkaller fuzzer. >> >> ep0_write() doesn't check the length, so a user can cause an >> out-of-bounds with both size and data

Re: [PATCH v2 RESEND] usb: gadget: udc-core: Rescan pending list on driver unbind

2016-12-27 Thread Felipe Balbi
Hi, Krzysztof Opasiak writes: > Since: > > commit 855ed04a3758 ("usb: gadget: udc-core: independent registration > of gadgets and gadget drivers") > > if we load gadget module but there is no free udc available > then it will be stored on a pending gadgets list. > > $

Re: [PATCH 1/2] usb: dwc3-pci: Fix dr_mode misspelling

2016-12-27 Thread Felipe Balbi
Hi, Hans de Goede writes: > usb_get_dr_mode() expects the device-property to be spelled > "dr_mode" not "dr-mode". > > Spelling it properly fixes the following warning showing up in dmesg: > [ 8704.500545] dwc3 dwc3.2.auto: Configuration mismatch. dr_mode forced to >

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Felipe Balbi
Hi, Baolin Wang writes: > Hi, > > On 27 December 2016 at 18:52, Janusz Dziedzic > wrote: >> 2016-12-26 9:01 GMT+01:00 Baolin Wang : >>> On some platfroms(like x86 platform), when one core is running the USB >>> gadget

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Felipe Balbi
Hi, Janusz Dziedzic writes: > 2016-12-26 9:01 GMT+01:00 Baolin Wang : >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >>

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Felipe Balbi
Hi, Lu Baolu writes: > On 12/26/2016 04:01 PM, Baolin Wang wrote: >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >> respond other interrupts from dwc3

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Baolin Wang
Hi, On 27 December 2016 at 18:52, Janusz Dziedzic wrote: > 2016-12-26 9:01 GMT+01:00 Baolin Wang : >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

2016-12-27 Thread Janusz Dziedzic
2016-12-26 9:01 GMT+01:00 Baolin Wang : > On some platfroms(like x86 platform), when one core is running the USB gadget > irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can > respond other interrupts from dwc3 controller and modify the event