[GIT PULL] USB/PHY driver fixes for 4.11-rc2

The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.11-rc2 for you to fetch changes up to

[PATCH] block: DAC960: fix ifnullfree.cocci warnings

drivers/block/DAC960.c:441:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/DAC960.c:446:1-17: WARNING: NULL check before

Re: [PATCH v5 01/19] block: DAC960: Replace PCI pool old API

Hi Romain, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.11-rc1 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Romain-Perier/Replace-PCI-pool-by-DMA

[PATCH v4 3/8] phy: phy-mt65xx-usb3: split SuperSpeed port into two ones

Currently usb3 port in fact includes two sub-ports, but it is not flexible for some cases, such as following one: usb3 port0 includes u2port0 and u3port0; usb2 port0 includes u2port1; If wants to support only HS, we can use u2port0 or u2port1, when select u2port0, u3port0 is not needed; If

[PATCH v4 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is usually 26M. it is flexible to move it into port node, then unused clock can be disabled. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi |8 ++--

[PATCH v4 6/8] arm64: dts: mt8173: split usb SuperSpeed port into two ports

split the old SuperSpeed port node into a HighSpeed one and a new SuperSpeed one. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH v4 8/8] dt-bindings: phy-mt65xx-usb: add support for new version phy

add a new compatible string for "mt2712", and move reference clock into each port node; Signed-off-by: Chunfeng Yun Acked-by: Rob Herring --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 93 +--- 1 file changed, 80

[PATCH v4 5/8] phy: phy-mt65xx-usb3: add support for new version phy

There are some variations from mt2701 to mt2712: 1. banks shared by multiple ports are put back into each port, such as SPLLC and U2FREQ; 2. add a new bank MISC for u2port, and CHIP for u3port; 3. bank's offset in each port are also rearranged; Signed-off-by: Chunfeng Yun

[PATCH v4 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

each port has its own reference clock, the HighSpeed port is 48M, and the SuperSpeed port is usually 26M, put them into port node for flexibility, this can close clock if the port is not used. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c | 29

[PATCH v4 1/8] phy: phy-mt65xx-usb3: improve RX detection stable time

The default value of RX detection stable time is 10us, and this margin is too big for some critical cases which cause U3 link fail and link to U2(probability is about 1%). So change it to 5us. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c | 18

[PATCH v4 2/8] phy: phy-mt65xx-usb3: increase LFPS filter threshold

Increase LFPS filter threshold to avoid some fake remote wakeup signal which cause U3 link fail and link to U2 only at about 0.01% probability. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c |9 + 1 file changed, 9 insertions(+) diff --git

[PATCH] usbnet: smsc95xx: Reduce logging noise

An insert/remove stress test generated the following log message sequence. usb 7-1.1: New USB device found, idVendor=0424, idProduct=ec00 usb 7-1.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0 smsc95xx 7-1.1:1.0 (unnamed net_device) (uninitialized):

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 03/10/2017 02:22 PM, Mats Karrman wrote: On 2017-03-08 14:58, Heikki Krogerus wrote: On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: If I read Heikki's original suggestion I understand it like the DP driver would be responsible for AM specific USB PD/VDM communication. But

Re: [PATCH] usb: hub: Fix error loop seen after hub communication errors

Hi Alan, On 03/10/2017 01:14 PM, Alan Stern wrote: On Wed, 8 Mar 2017, Guenter Roeck wrote: While stress testing a usb controller using a bind/unbind looop, the following error loop was observed. usb 7-1.2: new low-speed USB device number 3 using xhci-hcd usb 7-1.2: hub failed to enable

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 2017-03-08 14:58, Heikki Krogerus wrote: On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: If I read Heikki's original suggestion I understand it like the DP driver would be responsible for AM specific USB PD/VDM communication. But wouldn't that lead to a lot of code

[PATCH v4] usb: gadget: udc: remove pointer dereference after free

Remove pointer dereference after free. Addresses-Coverity-ID: 1091173 Acked-by: Michal Nazarewicz Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Move pointer dereference before pci_pool_free() Set pointer to NULL after free Changes in v3:

[PATCHv2] usb: gadget: f_fs: simplify ffs_dev name handling

Currently ffs_dev::name can be either allocated by the client of the ffs_dev structure or by the f_fs.c core itself. The former is used by g_ffs while the latter happens with configfs. Historically, g_ffs did not need to allocate separate buffer for the name so what is now f_fs.c core never

Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free

Hello, Quoting Felipe Balbi : "Gustavo A. R. Silva" writes: Remove pointer dereference after free. Addresses-Coverity-ID: 1091173 Acked-by: Michal Nazarewicz Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH] usb: hub: Fix error loop seen after hub communication errors

On Wed, 8 Mar 2017, Guenter Roeck wrote: > While stress testing a usb controller using a bind/unbind looop, the > following error loop was observed. > > usb 7-1.2: new low-speed USB device number 3 using xhci-hcd > usb 7-1.2: hub failed to enable device, error -108 > usb 7-1-port2: cannot

[PATCH 1/3] usb: musb: cppi41: don't check early-TX-interrupt for Isoch transfer

The CPPI 4.1 driver polls register to workaround the premature TX interrupt issue, but it causes audio playback underrun when triggered in Isoch transfers. Isoch doesn't do back-to-back transfers, the TX should be done by the time the next transfer is scheduled. So skip this polling workaround

[PATCH 3/3] usb: musb: fix possible spinlock deadlock

The DSPS glue calls del_timer_sync() in its musb_platform_disable() implementation, which requires the caller to not hold a lock. But musb_remove() calls musb_platform_disable() will musb->lock held. This could causes spinlock deadlock. So change musb_remove() to call musb_platform_disable()

[PATCH 0/3] musb fixes for v4.11-rc3

Hi Greg, Here are the musb fixes for v4.11-rc3 even the -rc2 is not out yet, because I will be offline for about 10 days and don't want to wait until I am back. One of the patches fixes the missing iounmap() caused in -rc1, and the other two fix the old bugs which were just exposed recently. If

[PATCH 2/3] usb: musb: dsps: fix iounmap in error and exit paths

Cleanly iounmap the pointer in error and exit paths. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 7c047c4a2565..9c7ee26ef388 100644

Re: Neophyte questions about PCIe

On Fri, Mar 10, 2017 at 04:05:50PM +0100, Mason wrote: > On 10/03/2017 15:06, David Laight wrote: > > > Robin Murphy wrote: > > > >> On 09/03/17 23:43, Mason wrote: > >> > >>> I think I'm making progress, in that I now have a better > >>> idea of what I don't understand. So I'm able to ask > >>>

Re: [PATCH v3 2/2] usb: gadget: reword configuration choices

On 03/10/17 05:11, Romain Izard wrote: > As USB_CONFIGFS is not a part of the "USB Gadget Drivers" choice > anymore, the name for the option and its attached description needs to > be more descriptive. It appears one level higher in the configuration > menu, and without the context provided by the

Re: Neophyte questions about PCIe

On 10/03/2017 17:45, Mason wrote: > Time to clean up a million hacks to be able to discuss the finer points. Here is my current boot log: [1.133895] OF: PCI: host bridge /soc/pcie@5000 ranges: [1.139607] pci_add_resource_offset: res=[bus 00-0f] offset=0x0 [1.145659] OF: PCI:

Re: [PATCH/RFC 1/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

On Fri, 10 Mar 2017, Yoshihiro Shimoda wrote: > This patch sets hcd->phy from own phy context to avoid phy_get() > in usb_add_hcd(). Since hcd.c manage the phy only in usb_add_hcd() > and usb_remove_hcd(), there is difficult to manage the phy in > suspend/resume. > > Signed-off-by: Yoshihiro

Re: Neophyte questions about PCIe

On 10/03/2017 00:43, Mason wrote: > I think I'm making progress [...] Yes! I was able to plug a USB3 Flash drive, mount it, and read its contents. A million thanks, my head was starting to hurt from too much banging. Time to clean up a million hacks to be able to discuss the finer points.

Re: [PATCH] usb: xhci: bInterval quirk for TI TUSB73x0

On 09/03/17 11:44, Sergei Shtylyov wrote: > Hello! > > On 3/9/2017 11:47 AM, Roger Quadros wrote: > >> As per [1] issue #4, >> "The periodic EP scheduler always tries to schedule the EPs >> that have large intervals (interval equal to or greater than >> 128 microframes) into different

Re: Neophyte questions about PCIe

On 10/03/17 15:35, David Laight wrote: > From: Robin Murphy >> Sent: 10 March 2017 15:23 > ... So you have 128MB (max) of system memory that has cpu physical addresses 0x8000 upwards. I'd expect it all to be accessible from any PCIe card at some PCIe address, it might be

Re: [PATCH v1] usb: gadget: udc: atmel: Remove an unused local variable

2017-03-09 18:02 GMT+01:00 Romain Izard : > The local variable ept_cfg is not used anymore in usba_ep_enable. > Use ep->ept_cfg in the debug function to remove a warning when building > with dynamic debug enabled. > > Signed-off-by: Romain Izard

RE: Neophyte questions about PCIe

From: Robin Murphy > Sent: 10 March 2017 15:23 ... > >> So you have 128MB (max) of system memory that has cpu physical > >> addresses 0x8000 upwards. > >> I'd expect it all to be accessible from any PCIe card at some PCIe > >> address, it might be at address 0, 0x8000 or any other offset.

Re: Neophyte questions about PCIe

On 10/03/2017 16:14, David Laight wrote: > Mason wrote: > >> My RC drops packets not targeting its BAR0. > > I suspect the fpga/cpld logic supports RC and endpoint modes > and is using much the same names for the registers (and logic > implementation). Your guess is spot on. In the

Re: Neophyte questions about PCIe

On 10/03/17 15:05, Mason wrote: > On 10/03/2017 15:06, David Laight wrote: > >> Robin Murphy wrote: >> >>> On 09/03/17 23:43, Mason wrote: >>> I think I'm making progress, in that I now have a better idea of what I don't understand. So I'm able to ask (hopefully) less vague

RE: Neophyte questions about PCIe

From: Mason > Sent: 10 March 2017 15:06 ... > My RC drops packets not targeting its BAR0. I suspect the fpga/cpld logic supports RC and endpoint modes and is using much the same names for the registers (and logic implementation). If your cpu support more than 1GB of memory but only part is PCIe

Re: Neophyte questions about PCIe

On 10/03/2017 15:06, David Laight wrote: > Robin Murphy wrote: > >> On 09/03/17 23:43, Mason wrote: >> >>> I think I'm making progress, in that I now have a better >>> idea of what I don't understand. So I'm able to ask >>> (hopefully) less vague questions. >>> >>> Take the USB3 PCIe adapter I've

Re: Neophyte questions about PCIe

On 10/03/2017 14:15, Robin Murphy wrote: > On 09/03/17 23:43, Mason wrote: >> On 08/03/2017 16:17, Bjorn Helgaas wrote: >> [snip excellent in-depth overview] >> >> I think I'm making progress, in that I now have a better >> idea of what I don't understand. So I'm able to ask >> (hopefully) less

Re: [PATCH v4 1/3] usb: orion-echi: Add support for the Armada 3700

On Fri, Mar 10, 2017 at 10:55:23AM +0100, Gregory CLEMENT wrote: > Hi Alan, > > On jeu., mars 09 2017, Alan Stern wrote: > > > On Thu, 9 Mar 2017, Gregory CLEMENT wrote: > > > >> From: Hua Jing > >> > >> - Add a new compatible string for the

Re: [PATCH 1/2] reset: Add API to count number of reset available with device

Hi Philipp, On Wed, Feb 22, 2017 at 10:54 AM, Vivek Gautam wrote: > Count number of reset phandles available with the device node > to know the resets a given device has. > > Cc: Philipp Zabel > Signed-off-by: Vivek Gautam

Re: [PATCH 2/2] usb; dwc3: of-simple: Add support to get resets for the device

Hi, Vivek Gautam writes: > On Fri, Mar 10, 2017 at 4:54 PM, Felipe Balbi wrote: >> Vivek Gautam writes: >> >>> Add support to get a list of resets available for the device. >>> These resets must be kept de-asserted

RE: Neophyte questions about PCIe

From: Robin Murphy > Sent: 10 March 2017 13:16 > On 09/03/17 23:43, Mason wrote: > > On 08/03/2017 16:17, Bjorn Helgaas wrote: > > [snip excellent in-depth overview] > > > > I think I'm making progress, in that I now have a better > > idea of what I don't understand. So I'm able to ask > >

Re: Neophyte questions about PCIe

On 09/03/17 23:43, Mason wrote: > On 08/03/2017 16:17, Bjorn Helgaas wrote: > [snip excellent in-depth overview] > > I think I'm making progress, in that I now have a better > idea of what I don't understand. So I'm able to ask > (hopefully) less vague questions. > > Take the USB3 PCIe adapter

[PATCH v3 0/2] Various cleanups for USB Gadget Kconfig

Fix some issues left when the configuration was updated to support a built-in USB gadget configfs together with modular legacy gadget drivers. Changes in v2: - Reword description Changes in v3: - Split functional and comment changes Romain Izard (2): usb: gadget: legacy gadgets are optional

[PATCH v3 2/2] usb: gadget: reword configuration choices

As USB_CONFIGFS is not a part of the "USB Gadget Drivers" choice anymore, the name for the option and its attached description needs to be more descriptive. It appears one level higher in the configuration menu, and without the context provided by the comments for the choice entry, it needs to

[PATCH v3 1/2] usb: gadget: legacy gadgets are optional

With commit bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadgets"),it is possible to build a modular kernel with both built-in configfs support and modular legacy gadget drivers. But when building a kernel without modules, it is also necessary to be able to build with configfs but

RE: [PATCH/RFC 2/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

> From: Yoshihiro Shimoda, Sent: Friday, March 10, 2017 10:01 PM Oops, this subject should be ohci-platform, not ehci-platform... Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More

[PATCH/RFC 2/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

This patch sets hcd->phy from own phy context to avoid phy_get() in usb_add_hcd(). Since hcd.c manage the phy only in usb_add_hcd() and usb_remove_hcd(), there is difficult to manage the phy in suspend/resume. Signed-off-by: Yoshihiro Shimoda ---

[PATCH/RFC 0/2] usb: host: [eo]hci-plat: set hcd->phy to avoid phy_get_() in usb_add_hcd()

The usb_add_hcd() will call phy_{get,init,power_on}() if hcd->phy is not set. After the usb_add_hcd() call phy_power_on(), it keeps until usb_remove_hcd(). And then, even if the system turns suspend, the usb core keeps the phy power. I think that each host driver should handle the phy power. So,

[PATCH/RFC 1/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() in usb_add_hcd()

This patch sets hcd->phy from own phy context to avoid phy_get() in usb_add_hcd(). Since hcd.c manage the phy only in usb_add_hcd() and usb_remove_hcd(), there is difficult to manage the phy in suspend/resume. Signed-off-by: Yoshihiro Shimoda ---

Re: [PATCH v3 1/2] usb: dwc3: refactor gadget endpoint count calculation

Hi, Bryan O'Donoghue writes: > - DWC_USB3_NUM indicates the number of Device mode single directional > endpoints, including OUT and IN endpoint 0. > > - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN > endpoints active at any time,

Re: [PATCH 2/2] usb; dwc3: of-simple: Add support to get resets for the device

On Fri, Mar 10, 2017 at 4:54 PM, Felipe Balbi wrote: > Vivek Gautam writes: > >> Add support to get a list of resets available for the device. >> These resets must be kept de-asserted until the device is >> in use. >> >> Cc: Felipe Balbi

Re: [PATCH v2] usb: gadget: legacy gadgets are optional

Hi, Romain Izard writes: > Hello Felipe, > > 2017-03-10 10:15 GMT+01:00 Felipe Balbi : >> >> Hi, >> >> Romain Izard writes: >>> With commit "usb: gadget: don't couple configfs to legacy gadgets" >>> it is possible to

Re: [PATCH 2/2] usb: gadget: function: f_fs: pass companion descriptor along

Hi, Krzysztof Opasiak writes: >> Krzysztof Opasiak writes: >>> On 01/31/2017 02:08 PM, Felipe Balbi wrote: If we're dealing with SuperSpeed endpoints, we need to make sure to pass along the companion descriptor and initialize fields

Re: [PATCH] usb: dwc3: gadget: Fix starting microframe for ISOC

John Youn writes: > The gadget wants to set the starting microframe for the first ISOC TRB > to 4 microframes in the future, but it does so by multiplying the > dep->interval. This only works if dep->interval = 1. For other intervals > it will put it 4 *intervals* in the

Re: [PATCH v2] usb: gadget: legacy gadgets are optional

Hi, Romain Izard writes: > With commit "usb: gadget: don't couple configfs to legacy gadgets" > it is possible to build a modular kernel with both built-in configfs > support and modular legacy gadget drivers. > > But when building a kernel without modules, it is

Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free

"Gustavo A. R. Silva" writes: > Remove pointer dereference after free. > > Addresses-Coverity-ID: 1091173 > Acked-by: Michal Nazarewicz > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Move pointer dereference

Re: [PATCH v2 2/3] usb: dwc3: use BIT() macro where possible

Roger Quadros writes: > To avoid checkpatch warnings with new patches let's > start using the BIT() macro wherever possible. > > Signed-off-by: Roger Quadros unfortunately doesn't apply: checking file drivers/usb/dwc3/core.h Hunk #2 succeeded at 67 (offset 1

Re: Problem of Serial_State in cdc-acm.c

Am Freitag, den 10.03.2017, 17:20 +0800 schrieb 家瑋: >  Hi, > I have encounter a problem while sending Serial_State packet of > CDC-ACM from Linux gadget to Linux host . > Here is my question: > The environment is a USB device which runs Linux is using > CDC-ACM(f_acm.c) to communicate

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> >> -- >> >> 1.7.9.5 >> > Hi, Balbi and all guys, >> > Any comment for these patches? Can they be accepted? >> >> Rob had comments which you didn't reply yet. I cannot take this patchset >> yet ;-) >> > Balbi, > > I look into his mail again,

Re: [PATCH 2/2] usb; dwc3: of-simple: Add support to get resets for the device

Vivek Gautam writes: > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Cc: Felipe Balbi > Signed-off-by: Vivek Gautam how do you

Re: [PATCH v2 01/14] usb: dwc2: Rename hibernation to partial_power_down

Hi, Vardan Mikayelyan writes: > No-op change, only rename. > > This code was misnamed originally. It was only responsible for partial > power down and not for hibernation. > > Rename core_params->hibernation to core_params->power_down, >

Re: [PATCH] usb: gadget: f_fs: simplify ffs_dev name handling

Hi, Michal Nazarewicz writes: > Currently ffs_dev::name can be either allocated by the client of > the ffs_dev structure or by the f_fs.c core itself. The former > is used by g_ffs while the latter happens with configfs. > > Historically, g_ffs did not need to allocate

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 10 March 2017 at 16:27, Jun Li wrote: > Hi > >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Friday, March 10, 2017 3:15 PM >> To: Jun Li >> Cc: NeilBrown ; Felipe Balbi ; Greg KH >>

Re: [PATCH v4 1/3] usb: orion-echi: Add support for the Armada 3700

Hi Alan, On jeu., mars 09 2017, Alan Stern wrote: > On Thu, 9 Mar 2017, Gregory CLEMENT wrote: > >> From: Hua Jing >> >> - Add a new compatible string for the Armada 3700 SoCs >> >> - add sbuscfg support for orion usb controller driver. For

Re: [PATCH v2] usb: gadget: legacy gadgets are optional

Hello Felipe, 2017-03-10 10:15 GMT+01:00 Felipe Balbi : > > Hi, > > Romain Izard writes: >> With commit "usb: gadget: don't couple configfs to legacy gadgets" >> it is possible to build a modular kernel with both built-in configfs >> support and

Problem of Serial_State in cdc-acm.c

Hi Greg, Thanks for your kind reminding. I never notice the footer if you don't tell me... I resend my mail by another mail account. Following is the original message. I have encounter a problem while sending Serial_State packet of CDC-ACM from Linux gadget to Linux host . Here is my

RE: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Friday, March 10, 2017 3:15 PM > To: Jun Li > Cc: NeilBrown ; Felipe Balbi ; Greg KH > ; Sebastian Reichel ;