[PATCH v2] usb: phy: isp1301: Add OF device ID table

2017-03-14 Thread Javier Martinez Canillas
The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could

[PATCH 1/4] cdc-acm: reassemble fragmented notifications

2017-03-14 Thread Tobias Herzog
USB devices may have very limitited endpoint packet sizes, so that notifications can not be transferred within one single usb packet. Reassembling of multiple packages may be necessary. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 102

[PATCH 2/4] cdc-acm: fix possible invalid access when processing notification

2017-03-14 Thread Tobias Herzog
Notifications may only be 8 bytes so long. Accessing the 9th and 10th byte of unimplemented/unknown notifications may be insecure. Also check the length of known notifications before accessing anything behind the 8th byte. Signed-off-by: Tobias Herzog ---

[PATCH 3/4] cdc-acm: log message for serial state notification

2017-03-14 Thread Tobias Herzog
Adds a similar log message to USB_CDC_NOTIFY_SERIAL_STATE as it is already done with USB_CDC_NOTIFY_NETWORK_CONNECTION. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c

[PATCH 4/4] cdc-acm: remove unused element of struct acm

2017-03-14 Thread Tobias Herzog
write_used was introduced with commit 884b600f63dc ("[PATCH] USB: fix acm trouble with terminals") but never used since. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.h

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

2017-03-14 Thread Diego Viola
On Tue, Mar 14, 2017 at 2:20 PM, Diego Viola wrote: > On Thu, Mar 9, 2017 at 2:15 PM, Diego Viola wrote: >> On Thu, Mar 9, 2017 at 11:11 AM, Diego Viola wrote: >>> On Wed, Mar 8, 2017 at 5:40 PM, Diego Viola

Re: Dell Inspiron 5558/0VNM2T hangs at resume from suspend when USB 3 is enabled

2017-03-14 Thread Diego Viola
On Thu, Mar 9, 2017 at 2:15 PM, Diego Viola wrote: > On Thu, Mar 9, 2017 at 11:11 AM, Diego Viola wrote: >> On Wed, Mar 8, 2017 at 5:40 PM, Diego Viola wrote: >>> Hi Greg, >>> >>> On Wed, Mar 8, 2017 at 5:15 PM, Greg KH

unexpected TRB Type 4, Disable of device-initiated U1 failed

2017-03-14 Thread Nathan Shearer
I have been archiving data from old hard drives, and I have a drive that spins up, but does not finish detecting (the drive is faulty). When this happens on kernel 4.10.1 there is some kind of a timeout, and the usb port that my dock is plugged into is permanently disabled until I reboot.

Re: [PATCH] net: usb: rtl8150: use new api ethtool_{get|set}_link_ksettings

2017-03-14 Thread Petko Manolov
On 17-03-13 17:00:20, Petko Manolov wrote: > On 17-03-12 23:16:25, Philippe Reynes wrote: > > The ethtool api {get|set}_settings is deprecated. We move this driver to > > new > > api {get|set}_link_ksettings. > > > > As I don't have the hardware, I'd be very pleased if someone may test this >

[PATCH 2/2] USB: usbtmc: fix probe error path

2017-03-14 Thread Johan Hovold
Make sure to initialise the return value to avoid having allocation failures going unnoticed when allocating interrupt-endpoint resources. This prevents use-after-free or worse when the device is later unbound. Fixes: dbf3e7f654c0 ("Implement an ioctl to support the USMTMC-USB488

[PATCH 1/2] USB: usbtmc: add missing endpoint sanity check

2017-03-14 Thread Johan Hovold
USBTMC devices are required to have a bulk-in and a bulk-out endpoint, but the driver failed to verify this, something which could lead to the endpoint addresses being taken from uninitialised memory. Make sure to zero all private data as part of allocation, and add the missing endpoint sanity

Re: [PATCH] ohci-pci: add qemu quirk

2017-03-14 Thread Alan Stern
On Tue, 14 Mar 2017, Gerd Hoffmann wrote: > On a loaded virtualization host (dozen guests booting at the same time) > it may happen that the ohci controller emulation doesn't manage to do > timely frame processing, with the result that the io watchdog fires and > considers the controller being

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-14 Thread James Bottomley
On Tue, 2017-03-14 at 12:29 +, Reshetova, Elena wrote: > > Elena Reshetova writes: > > > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid accidental > > >

RE: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-14 Thread Reshetova, Elena
> Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations.

RE: Neophyte questions about PCIe

2017-03-14 Thread David Laight
From: Mason > Sent: 14 March 2017 12:06 > On 14/03/2017 11:23, David Laight wrote: > > > Mason wrote: > > > >> I'd like to push support for this PCIe controller upstream. > >> > >> Is the code I posted on the right track? > >> Maybe I can post a RFC patch tomorrow? > > > > I think you need to

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Lee Jones
On Tue, 14 Mar 2017, Baolin Wang wrote: > Hi, > > On 14 March 2017 at 17:57, Lee Jones wrote: > > On Mon, 20 Feb 2017, Baolin Wang wrote: > > > > [...] > > > >> drivers/power/supply/wm831x_power.c | 63 +++ > >> drivers/usb/gadget/Kconfig |8 + > >>

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-14 Thread Michael Ellerman
Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

Re: Neophyte questions about PCIe

2017-03-14 Thread Mason
On 14/03/2017 11:23, David Laight wrote: > Mason wrote: > >> I'd like to push support for this PCIe controller upstream. >> >> Is the code I posted on the right track? >> Maybe I can post a RFC patch tomorrow? > > I think you need to resolve the problem of config space (and IO) cycles > before

[PATCH] ACM gadget: fix endianness in notifications

2017-03-14 Thread Oliver Neukum
The gadget code exports the bitfield for serial status changes over the wire in its internal endianness. The fix is to convert to little endian before sending it over the wire. Signed-off-by: Oliver Neukum Tested-by: 家瑋 CC: sta...@vger.kernel.org ---

[PATCH] [v2]lvs: fix race condition in disconnect handling

2017-03-14 Thread Oliver Neukum
There is a small window during which the an URB may remain active after disconnect has returned. If in that case already freed memory may be accessed and executed. The fix is to poison the URB befotre the work is flushed. Typos fixed in v2 Signed-off-by: Oliver Neukum ---

Re: Problem of Serial_State in cdc-acm.c

2017-03-14 Thread 家瑋
Hi, It's OK for me. Thanks for your help Best Regards Benson On Tue, Mar 14, 2017 at 5:44 PM, Oliver Neukum wrote: > Am Dienstag, den 14.03.2017, 17:13 +0800 schrieb 家瑋: >> Hi, >> Thanks for your help. I tried this patch and it works well. >> So what else I should do?

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Baolin Wang
Hi, On 14 March 2017 at 17:57, Lee Jones wrote: > On Mon, 20 Feb 2017, Baolin Wang wrote: > > [...] > >> drivers/power/supply/wm831x_power.c | 63 +++ >> drivers/usb/gadget/Kconfig |8 + >> drivers/usb/gadget/udc/Makefile |1 + >>

RE: Neophyte questions about PCIe

2017-03-14 Thread David Laight
From: Mason > Sent: 13 March 2017 21:58 ... > I'd like to push support for this PCIe controller upstream. > > Is the code I posted on the right track? > Maybe I can post a RFC patch tomorrow? I think you need to resolve the problem of config space (and IO) cycles before the driver can be deemed

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-14 Thread Lee Jones
On Mon, 20 Feb 2017, Baolin Wang wrote: [...] > drivers/power/supply/wm831x_power.c | 63 +++ > drivers/usb/gadget/Kconfig |8 + > drivers/usb/gadget/udc/Makefile |1 + > drivers/usb/gadget/udc/charger.c| 865 > +++ >

[PATCH] ohci-pci: add qemu quirk

2017-03-14 Thread Gerd Hoffmann
On a loaded virtualization host (dozen guests booting at the same time) it may happen that the ohci controller emulation doesn't manage to do timely frame processing, with the result that the io watchdog fires and considers the controller being dead, even though it's only the emulation being

Re: [PATCH] option: add Quectel UC15, UC20, EC21, and EC25 modems

2017-03-14 Thread Johan Hovold
On Thu, Mar 09, 2017 at 11:32:28AM -0600, Dan Williams wrote: > Add Quectel UC15, UC20, EC21, and EC25. The EC20 is handled by > qcserial due to a USB VID/PID conflict with an existing Acer > device. > > Signed-off-by: Dan Williams > --- > NOTE: The UC20, EC21, and EC25 should

Re: Problem of Serial_State in cdc-acm.c

2017-03-14 Thread Oliver Neukum
Am Dienstag, den 14.03.2017, 17:13 +0800 schrieb 家瑋: > Hi, > Thanks for your help. I tried this patch and it works well. > So what else I should do? Will you help to merge it to trunk? > Thanks for your help. >  Hi, I will submit it. May I add a "Tested-by" tag from you? Regards

Re: [PATCH] [for 4.11]xhci: plat: Register shutdown for xhci_plat

2017-03-14 Thread Mathias Nyman
On 13.03.2017 23:59, Adam Wallis wrote: Shutdown should be called for xhci_plat devices especially for situations where kexec might be used by stopping DMA transactions. Signed-off-by: Adam Wallis --- drivers/usb/host/xhci-plat.c | 1 + 1 file changed, 1 insertion(+)

Re: Problem of Serial_State in cdc-acm.c

2017-03-14 Thread 家瑋
Hi, Thanks for your help. I tried this patch and it works well. So what else I should do? Will you help to merge it to trunk? Thanks for your help. Best Regards Benson On Fri, Mar 10, 2017 at 7:28 PM, Oliver Neukum wrote: > Am Freitag, den 10.03.2017, 17:20 +0800 schrieb

Re: [PATCH] usb-core: Add MS_INTR_BINTERVAL USB quirk

2017-03-14 Thread Samuel Thibault
Dave Mielke, on lun. 13 mars 2017 22:20:01 -0400, wrote: > It's possible that this device is using high speed because it offers a > feature > to transfer its internal clipboard to the host, and it allows that clipboard > to > contain lots of data. Interestingly, though, hidden within a usage

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Vivek Gautam
Hi Krzysztof, On 03/14/2017 12:14 PM, Krzysztof Kozlowski wrote: On Tue, Mar 14, 2017 at 8:22 AM, Vivek Gautam wrote: Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Jaehoon Chung
On 03/14/2017 03:22 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek Gautam

RE: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Yoshihiro Shimoda
Hi, > From: Vivek Gautam, Sent: Tuesday, March 14, 2017 3:23 PM > > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by:

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Krzysztof Kozlowski
On Tue, Mar 14, 2017 at 8:22 AM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > >

[RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Vivek Gautam
Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory structure for phy drivers. Signed-off-by: Vivek Gautam Acked-by: Heiko Stuebner

[PATCH net] r8152: fix the list rx_done may be used without initialization

2017-03-14 Thread Hayes Wang
The list rx_done would be initialized when the linking on occurs. Therefore, if a napi is scheduled without any linking on before, the following kernel panic would happen. BUG: unable to handle kernel NULL pointer dereference at 008 IP: [] r8152_poll+0xe1e/0x1210

[PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Vivek Gautam
Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory structure for phy drivers. Signed-off-by: Vivek Gautam Acked-by: Heiko Stuebner