RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, March 28, 2017 9:06 PM >> >> Hi, >> >> Yoshihiro Shimoda writes: >> > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD

Re: [PATCH 2/2] usb: host: xhci: using dma pool for scratchpad buffer

2017-03-28 Thread Felipe Balbi
Hi, Peter Chen writes: > According to xHCI ch4.20 Scratchpad Buffers > A Scratchpad Buffer is a PAGESIZE block of system memory > located on a PAGESIZE boundary > ... > Software clears the Scratchpad Buffer to ‘0’ > > So, we need to use dma

Re: [PATCH] usb: musb: fix possible spinlock deadlock

2017-03-28 Thread Greg KH
On Tue, Mar 28, 2017 at 12:56:34PM -0500, Bin Liu wrote: > On Tue, Mar 28, 2017 at 07:15:58PM +0200, Greg KH wrote: > > On Tue, Mar 28, 2017 at 08:45:31AM -0500, Bin Liu wrote: > > > commit bc1e2154542071e3cfe1734b143af9b8bdacf8bd upstream. > > > > > > The DSPS glue calls del_timer_sync() in its

[PATCH 1/2] usb: host: xhci: delete sp_dma_buffers for scratchpad

2017-03-28 Thread Peter Chen
We already have sp_array to store each scratch buffer address for xHC, it doesn't need another sp_dma_buffers array to store it. Signed-off-by: Peter Chen --- drivers/usb/host/xhci-mem.c | 18 -- drivers/usb/host/xhci.h | 1 - 2 files changed, 4

[PATCH 2/2] usb: host: xhci: using dma pool for scratchpad buffer

2017-03-28 Thread Peter Chen
According to xHCI ch4.20 Scratchpad Buffers A Scratchpad Buffer is a PAGESIZE block of system memory located on a PAGESIZE boundary ... Software clears the Scratchpad Buffer to ‘0’ So, we need to use dma pool for PAGESIZE boundary buffer, and zeroed its region

Re: USB device disconnect after suspend/resume

2017-03-28 Thread Peter Chen
On Tue, Mar 28, 2017 at 03:25:34PM +0200, Stephan Müller wrote: > Am Dienstag, 28. März 2017, 03:12:44 CEST schrieb Peter Chen: > > Hi Peter, > > > Do you have debug information from USB core (not only USB storage)? It > > may show why it is disconnected from low level. > > The device is

Re: USB device disconnect after suspend/resume

2017-03-28 Thread Peter Chen
On Tue, Mar 28, 2017 at 03:25:34PM +0200, Stephan Müller wrote: > Am Dienstag, 28. März 2017, 03:12:44 CEST schrieb Peter Chen: > > Hi Peter, > > > Do you have debug information from USB core (not only USB storage)? It > > may show why it is disconnected from low level. > > The device is

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-28 Thread Rob Herring
On Wed, Mar 22, 2017 at 04:46:02PM -0700, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for

RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Yoshihiro Shimoda
Hi Felipe-san, > From: Felipe Balbi, Sent: Tuesday, March 28, 2017 9:06 PM > > Hi, > > Yoshihiro Shimoda writes: > > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD > > controller on R-Car Gen3, software has to set the DRD_CON register > >

Re: [PATCH v19 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2017-03-28 Thread NeilBrown
On Tue, Mar 07 2017, Baolin Wang wrote: > On 3 March 2017 at 10:23, NeilBrown wrote: > >> >> I understand your reluctance to change drivers that you cannot test. >> An alternative it do change all the >> atomic_notifier_call_chain(.*notifier, >> calls that don't pass a pointer

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-28 Thread NeilBrown
On Thu, Mar 23 2017, Baolin Wang wrote: > Usually usb phy need register one extcon device to get the connection > notifications. It will remove some duplicate code if the extcon device > is registered using common code instead of each phy driver having its > own related extcon APIs. So we add one

Fast Loans

2017-03-28 Thread Service Loans
Do you need a loan to pay up bill or to start a business? Email Us -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: phy: isp1301: Fix build warning when CONFIG_OF is disabled

2017-03-28 Thread Javier Martinez Canillas
Commit fd567653bdb9 ("usb: phy: isp1301: Add OF device ID table") added an OF device ID table, but used the of_match_ptr() macro that will lead to a build warning if CONFIG_OF symbol is disabled: drivers/usb/phy//phy-isp1301.c:36:34: warning: ‘isp1301_of_match’ defined but not used

Re: [PATCH] usb: musb: fix possible spinlock deadlock

2017-03-28 Thread Bin Liu
On Tue, Mar 28, 2017 at 07:15:58PM +0200, Greg KH wrote: > On Tue, Mar 28, 2017 at 08:45:31AM -0500, Bin Liu wrote: > > commit bc1e2154542071e3cfe1734b143af9b8bdacf8bd upstream. > > > > The DSPS glue calls del_timer_sync() in its musb_platform_disable() > > implementation, which requires the

Re: [PATCH] usb: musb: fix possible spinlock deadlock

2017-03-28 Thread Greg KH
On Tue, Mar 28, 2017 at 08:45:31AM -0500, Bin Liu wrote: > commit bc1e2154542071e3cfe1734b143af9b8bdacf8bd upstream. > > The DSPS glue calls del_timer_sync() in its musb_platform_disable() > implementation, which requires the caller to not hold a lock. But > musb_remove() calls

[PATCH linux-next v2 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH linux-next v2 3/4] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Use dev_warn() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH linux-next v2 2/4] usb: gadget: udc: atmel: Minor code cleanup

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Minor code cleanup based on feedback received on mailinglist. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-)

[PATCH linux-next v2 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

2017-03-28 Thread cristian.birsan
From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP

[PATCH linux-next v2 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree

2017-03-28 Thread cristian.birsan
From: Cristian Birsan Check fifo configuration values against device tree values for endpoint fifo in auto configuration mode (fifo_mode=0). Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 24

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-03-28 Thread Tony Lindgren
* Moreno Bartalucci [170327 23:12]: > > Il giorno 27 mar 2017, alle ore 19:15, Bin Liu ha scritto: > > > > […] > > > > The MUSB otg state machine has been changed in many place since the last > > time I looked at it, and I am not sure how exactly

INVESTITIONSPLÄNE

2017-03-28 Thread Joanna Diane Christopher
Hallo Mein Name ist Joanna Diane Christopher, ich bin 20 Jahre alte Waise von Abidjan Elfenbeinküste in Westafrika, ich habe die Summe von (7,5 Millionen Euro), die mein verstorbener Vater in einer der Prime Bank hier mit meinem Namen als nächster Verwandter niedergelegt hat Weil ich sein

INVESTITIONSPLÄNE

2017-03-28 Thread Joanna Diane Christopher
Hallo Mein Name ist Joanna Diane Christopher, ich bin 20 Jahre alte Waise von Abidjan Elfenbeinküste in Westafrika, ich habe die Summe von (7,5 Millionen Euro), die mein verstorbener Vater in einer der Prime Bank hier mit meinem Namen als nächster Verwandter niedergelegt hat Weil ich sein

[PATCH] dwc2: gadget: Fix in control write transfers

2017-03-28 Thread Minas Harutyunyan
After data out stage gadget driver should not initate ZLP on control EP, because it is up to function driver. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git

Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table

2017-03-28 Thread Javier Martinez Canillas
Hello Felipe, On 03/28/2017 09:45 AM, Felipe Balbi wrote: > > Hi, > > Javier Martinez Canillas writes: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device

Re: [PATCH] usb: gadget: uvc: Missing files for configfs interface

2017-03-28 Thread Felipe Balbi
Hi, Petr Cvek writes: > Dne 7.3.2017 v 06:58 Laurent Pinchart napsal(a): >> Hi Petr, >> >> Thank you for the patch. >> >> On Tuesday 07 Mar 2017 00:57:20 Petr Cvek wrote: >>> Commit 76e0da34c7ce ("usb-gadget/uvc: use per-attribute show and store >>> methods") caused a

Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table

2017-03-28 Thread Felipe Balbi
Hi, Javier Martinez Canillas writes: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that

Re: [PATCH v2 2/2] usb: dwc2: add multiple clocks handling

2017-03-28 Thread Felipe Balbi
Hi, Heiko Stübner writes: > Am Donnerstag, 9. Februar 2017, 10:44:39 CET schrieb Frank Wang: >> Since dwc2 may have one or more input clocks need to manage for some >> platform, so this adds change clk to clk's array of struct dwc2_hsotg >> to handle more clocks operation. >>

Re: [PATCH v5 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

2017-03-28 Thread Alexandre Torgue
On 03/28/2017 03:36 PM, Felipe Balbi wrote: Hi, Alexandre Torgue writes: Hi John, On 02/01/2017 04:37 AM, John Youn wrote: On 1/31/2017 5:26 PM, Bruno Herrera wrote: This patch introduces a new parameter to activate USB OTG HS/FS core embedded phy transceiver.

Re: [PATCH v3 2/2] usb: gadget: reword configuration choices

2017-03-28 Thread Felipe Balbi
Hi, Randy Dunlap writes: >> @@ -477,6 +477,12 @@ choice >>not be able work with that controller, or might need to implement >>a less common variant of a device class protocol. >> >> + The available choices each represent a single precomposed USB >>

[PATCH] usb: musb: fix possible spinlock deadlock

2017-03-28 Thread Bin Liu
commit bc1e2154542071e3cfe1734b143af9b8bdacf8bd upstream. The DSPS glue calls del_timer_sync() in its musb_platform_disable() implementation, which requires the caller to not hold a lock. But musb_remove() calls musb_platform_disable() will musb->lock held. This could causes spinlock deadlock.

Re: [PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister

2017-03-28 Thread Felipe Balbi
Hi, Baolin Wang writes: > Since usb phy core has added common code to register or unregister > extcon device, then phy-qcom-8x16-usb driver does not need its own > code to register/unregister extcon device, then remove them. > > Signed-off-by: Baolin Wang

Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

2017-03-28 Thread Felipe Balbi
Hi, Baolin Wang writes: > Usually usb phy need register one extcon device to get the connection > notifications. It will remove some duplicate code if the extcon device > is registered using common code instead of each phy driver having its > own related extcon APIs. So

Re: [PATCH v5 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

2017-03-28 Thread Felipe Balbi
Hi, Alexandre Torgue writes: > Hi John, > > On 02/01/2017 04:37 AM, John Youn wrote: >> On 1/31/2017 5:26 PM, Bruno Herrera wrote: >>> This patch introduces a new parameter to activate USB OTG HS/FS core >>> embedded phy transceiver. The STM32F4x9 SoC uses the GGPIO

Re: USB device disconnect after suspend/resume

2017-03-28 Thread Stephan Müller
Am Dienstag, 28. März 2017, 03:12:44 CEST schrieb Peter Chen: Hi Peter, > Do you have debug information from USB core (not only USB storage)? It > may show why it is disconnected from low level. The device is question is at port 2-3. usb core dyndbg: [ 72.546341] Restarting tasks ... [

[PATCH v3 3/3] xhci: Manually give back cancelled URB if we can't queue it for cancel

2017-03-28 Thread Mathias Nyman
xhci needs to take care of four scenarios when asked to cancel a URB. 1 URB is not queued or already given back. usb_hcd_check_unlink_urb() will return an error, we pass the error on 2 We fail to find xhci internal structures from urb private data such as virtual device and endpoint ring.

[PATCH v3 1/3] xhci: plat: Register shutdown for xhci_plat

2017-03-28 Thread Mathias Nyman
From: Adam Wallis Shutdown should be called for xhci_plat devices especially for situations where kexec might be used by stopping DMA transactions. Signed-off-by: Adam Wallis Signed-off-by: Mathias Nyman ---

[PATCH v3 2/3] xhci: Set URB actual length for stopped control transfers

2017-03-28 Thread Mathias Nyman
A control transfer that stopped at the status stage incorrectly warned about a "unexpected TRB Type 4", and did not set the transferred actual_length for the URB. The URB actual_length for control transfers should contain the bytes transferred in the data stage. Bytes of a partially sent setup

Re: [PATCH] usb: gadget: pch_udc: don't update td->next after it has been released to the pool

2017-03-28 Thread Felipe Balbi
Hi, Colin King writes: > From: Colin Ian King > > Writing to td->next should be avoided after td has been freed using > dma_pool_free. The intent was to nullify the next pointer, but this > is potentially dangerous once it is back in the

[PATCH v3 0/3] xhci fixes for usb-linus

2017-03-28 Thread Mathias Nyman
Hi Greg Third version A few more xhci fixes for usb-linus 4.11-rc Most important is the URB dequeue fix that resolves a hang on resume reported by Diego Viola on his DELL Inspiron 5558. v3: - make patch 2/3 very targeted and only fix the missing case of how we handle control transfers

Re: [PATCH] usb: gadget: pch_udc: don't update td->next after it has been released to the pool

2017-03-28 Thread Colin Ian King
On 28/03/17 13:51, Felipe Balbi wrote: > > Hi, > > Colin King writes: >> From: Colin Ian King >> >> Writing to td->next should be avoided after td has been freed using >> dma_pool_free. The intent was to nullify the next pointer, but this >>

[PATCH] usb: gadget: pch_udc: don't update td->next after it has been released to the pool

2017-03-28 Thread Colin King
From: Colin Ian King Writing to td->next should be avoided after td has been freed using dma_pool_free. The intent was to nullify the next pointer, but this is potentially dangerous once it is back in the pool. Remove it. Detected by CoverityScan, CID#1091173 ("Write

[PATCH v4] USB: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

2017-03-28 Thread Ajay Kaher
Greg, sending patch again using git send-email, please apply. Let me know if still any issue. There is race condition when two USB class drivers try to call init_usb_class at the same time and leads to crash. code path: probe->usb_register_dev->init_usb_class To solve this, mutex locking has

Re: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD > controller on R-Car Gen3, software has to set the DRD_CON register > which is included in a usb3.0 peripheral controler's register. > To simply implementation,

[PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

2017-03-28 Thread Yoshihiro Shimoda
Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD controller on R-Car Gen3, software has to set the DRD_CON register which is included in a usb3.0 peripheral controler's register. To simply implementation, the previous code always set peripheral mode as hardcoded. However, to

[PATCH 0/4] usb: gadget: udc: renesas_usb3: add USB3.0 DRD support

2017-03-28 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.bit / testing/next branch (commit id = 29986993f67341493988b6c5d68e0653061975b2). The USB3.0 DRD controller on R-Car Gen3 can change the role via DRD_CON register in the periperal side sadly, so this patch adds support for usb role swap feature

[PATCH 3/4] usb: gadget: udc: renesas_usb3: add extcon support

2017-03-28 Thread Yoshihiro Shimoda
This patch adds extcon support to see VBUS/ID signal states. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/Kconfig| 1 + drivers/usb/gadget/udc/renesas_usb3.c | 43 +-- 2 files changed, 42 insertions(+), 2

[PATCH 4/4] usb: gadget: udc: renesas_usb3: add support for usb role swap

2017-03-28 Thread Yoshihiro Shimoda
This patch adds support for usb role swap via sysfs "role". For example: 1) Connect a usb cable using 2 Salvator-X boards. - For A-Device, the cable is connected to CN11 (USB3.0 ch0). - For B-Device, the cable is connected to CN9 (USB2.0 ch0). 2) On A-Device, you input the following

[PATCH 2/4] usb: gadget: udc: add USB ID signal monitoring

2017-03-28 Thread Yoshihiro Shimoda
This usb 3.0 peripheral controller has a register (USB_OTG_STA) to monitor the USB ID signal. So, this patch adds the ID signal monitoring to change the mode to host (A-Device) or peripheral (B-Device). Signed-off-by: Yoshihiro Shimoda ---

Re: [PATCH v2 4/4] usb: dwc3: Workaround for super-speed host on dra7 in dual-role mode

2017-03-28 Thread Felipe Balbi
Hi, Roger Quadros writes: > dra7 OTG core limits the host controller to USB2.0 (high-speed) mode > when we're operating in dual-role. yeah, that's not a quirk. DRA7 supports OTGv2, not OTGv3. There was no USB3 when OTGv2 was written. DRA7 just shouldn't use OTG core altogether.

Re: [PATCH] usb: mtu3: Replace the extcon API

2017-03-28 Thread Chunfeng Yun
Hi, On Tue, 2017-03-28 at 13:42 +0900, Chanwoo Choi wrote: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Cc: Greg Kroah-Hartman

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-28 Thread Felipe Balbi
Hi, Roger Quadros writes: > If dr_mode is "otg" then support dual role mode of operation. > > Get ID and VBUS information from the OTG controller > and put the controller in the appropriate state. > > This is our dual-role state table. > > IDVBUSdual-role state > --

[PATCH v3 6/7] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-03-28 Thread Raviteja Garimella
The device node is used for UDCs integrated into Broadcom's iProc family of SoCs'. The UDC is based on Synopsys Designware Cores AHB Subsystem USB Device Controller IP. Signed-off-by: Raviteja Garimella --- Documentation/devicetree/bindings/usb/iproc-udc.txt |

[PATCH v3 7/7] UDC: Add Synopsys UDC Platform driver

2017-03-28 Thread Raviteja Garimella
This patch adds platform driver support for Synopsys UDC. A new driver file (snps_udc_plat.c) is created for this purpose where the platform driver registration is done based on OF node. Currently, UDC integrated into Broadcom's iProc SoCs (Northstar2 and Cygnus) work with this driver. New

[PATCH v3 3/7] UDC: make debug prints compatible with both pci and platform devices

2017-03-28 Thread Raviteja Garimella
This patch adds a struct device member to UDC data structure and makes changes to the arguments of dev_err and dev_dbg calls so that the debug prints work for both pci and platform devices. Signed-off-by: Raviteja Garimella ---

[PATCH v3 0/7] Platform driver support for 'amd5536udc' driver

2017-03-28 Thread Raviteja Garimella
Changes in PATCH v3: === 1. Updated bindings documentation and platform driver to add "brcm,iproc-udc" compatibility string. 2. Added a patch to replace references of struct pci_pool with struct dma_pool so that it is compatibile with non-pci drivers. Changes in PATCH v2:

[PATCH v3 5/7] UDC: Use struct dma_pool instead of pci_pool

2017-03-28 Thread Raviteja Garimella
Using dma_pool instead of pci_pool will make snps_udc_core driver to be compatible with non-pci platforms. Signed-off-by: Raviteja Garimella --- drivers/usb/gadget/udc/amd5536udc.h| 4 ++-- drivers/usb/gadget/udc/snps_udc_core.c | 8 2 files

[PATCH v3 1/7] UDC: Split the driver into amd (pci) and Synopsys core IP driver

2017-03-28 Thread Raviteja Garimella
This patch splits the amd5536udc driver into two -- one that does pci device registration and the other file that does the rest of the driver tasks like the gadget/ep ops etc for Synopsys UDC. This way of splitting helps in exporting core driver symbols which can be used by any other platform/pci

[PATCH v3 4/7] UDC: Provide correct arguments for 'dma_pool_create'

2017-03-28 Thread Raviteja Garimella
Change the argument from NULL to a struct device for the dma_pool_create call during dma init. Signed-off-by: Raviteja Garimella --- drivers/usb/gadget/udc/snps_udc_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 3/3] xhci: Manually give back cancelled URB if queuing it for cancel fails

2017-03-28 Thread Mathias Nyman
On 28.03.2017 09:49, Felipe Balbi wrote: Hi, Mathias Nyman writes: On 27.03.2017 17:54, Felipe Balbi wrote: Hi, Mathias Nyman writes: Manually give back URB if we are can not add it to the cancel queue, and stop the endpoint

Re: [PATCH v2 0/4] usb: dwc3: dual-role support

2017-03-28 Thread Felipe Balbi
Roger Quadros writes: > Hi, > > We rely on the OTG controller block or Extcon to provide us with > VBUS and ID line status via an interrupt. > > This is then used to switch the controller between host, peripheral > and idle roles based on the following table. > > ID VBUS

[PATCH 3/3] usb: gadget: u_ether: conditionally align transfer size

2017-03-28 Thread Felipe Balbi
Unless HW sets quirk_ep_out_aligned_size, gadget driver shouldn't make any efforts towards aligning transfers. If the UDC needs, it *must* set the quirk flag. Signed-off-by: Felipe Balbi --- tested with Intel Edison (DWC3) and "g_ether use_eem=1"

[PATCH 2/3] usb: gadget: u_ether: use better list accessors

2017-03-28 Thread Felipe Balbi
We have helpers for some of these, let's rely on them instead of open coding what they do in u_ether.c Signed-off-by: Felipe Balbi --- tested with Intel Edison (DWC3) and "g_ether use_eem=1" drivers/usb/gadget/function/u_ether.c | 16 ++-- 1 file

[PATCH 1/3] usb: dwc3: trace: change format for string to cmd trace

2017-03-28 Thread Felipe Balbi
a %x is much easier for a human to parse when reading tracepoint output. Let's change it. Signed-off-by: Felipe Balbi --- tested with Intel Edison (DWC3) and "g_ether use_eem=1" drivers/usb/dwc3/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's'

2017-03-28 Thread Sergei Shtylyov
Hello! On 3/28/2017 1:34 AM, Colin King wrote: From: Colin Ian King The initial setting of pointer s to the driver name or to the literal string "(none)" is redundant as later it is always set to point to a different literal string before it is printed log. Remove

[PATCH] USB: serial: drop termios-flag debugging

2017-03-28 Thread Johan Hovold
Drop some unnecessary termios-flag debugging that have been faithfully reproduced in a few old drivers, including the "clfag" typo and all. This also addresses a compiler warning on sparc where tcflag_t is unsigned long and would have required an explicit cast. Reported-by: Geert Uytterhoeven

Re: [PATCH RFC] dwc2: Don't assume URB transfer_buffer are dword-aligned

2017-03-28 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 10:24:15 +0900 Greg Kroah-Hartman escreveu: > On Thu, Mar 16, 2017 at 09:08:40PM -0300, Mauro Carvalho Chehab wrote: > > The dwc2 hardware doesn't like to do DMA transfers without > > aligning data in DWORD. The driver also assumes that, even > >

[PATCH v3 1/2] USB: lvstest: tighten endpoint sanity check

2017-03-28 Thread Johan Hovold
Use the new endpoint helpers to lookup the required interrupt-in endpoint. Note that this in fact both loosens and tightens the endpoint sanity check by accepting any interface with an interrupt-in endpoint rather than always using the first endpoint without verifying its type. Signed-off-by:

[PATCH v3 2/2] USB: usbtmc: refactor endpoint retrieval

2017-03-28 Thread Johan Hovold
Use the new endpoint helpers to lookup the required bulk-in and bulk-out endpoints, and the optional interrupt-in endpoint. Signed-off-by: Johan Hovold --- drivers/usb/class/usbtmc.c | 56 +++--- 1 file changed, 18 insertions(+), 38

[PATCH v3 0/2] USB: refactor endpoint retrieval

2017-03-28 Thread Johan Hovold
Many USB drivers iterate over the available endpoints to find required endpoints of a specific type and direction. Typically the endpoints are required for proper function and a missing endpoint should abort probe. To facilitate code reuse, this series adds a helper to retrieve common endpoints

Re: [PATCH v2 1/4] cdc-acm: reassemble fragmented notifications

2017-03-28 Thread Oliver Neukum
Am Freitag, den 24.03.2017, 22:50 +0100 schrieb Tobias Herzog: > Hi Oliver, > > thank you for your patience... :) I have a question to one of your > comments (see below). > > Best regards, > Tobias > > > > > Am Samstag, den 18.03.2017, 19:52 +0100 schrieb Tobias Herzog: > > > > > > > > > USB

Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver

2017-03-28 Thread Oliver Neukum
Am Freitag, den 24.03.2017, 07:17 -0700 schrieb Eric Dumazet: > On Fri, 2017-03-24 at 15:42 +1000, Greg Ungerer wrote: > > > > > The usbnet core is used by a number of drivers. This patch only > > updates the qmi-wwan driver to use stats64. If you remove the > > dev->stats.rx_* updates all those

Re: BUG Report: USB Storage is not working when connecting on a Thunderbolt 3.0 port

2017-03-28 Thread Mathias Nyman
Hi On 28.03.2017 05:35, Olivier Langlois wrote: Hardware: HP Spectre 13 http://h10032.www1.hp.com/ctg/Manual/c05228576.pdf Kernel version: 4.10.6 SMP PREEMPT x86_64 Is this a new issue? was it working on some other kernel? When I plug my usb storage on the USB 3.1 Gen1 port, the storage

Re: [PATCH v2 3/3] xhci: Manually give back cancelled URB if queuing it for cancel fails

2017-03-28 Thread Felipe Balbi
Hi, Mathias Nyman writes: > On 27.03.2017 17:54, Felipe Balbi wrote: >> >> Hi, >> >> Mathias Nyman writes: >>> Manually give back URB if we are can not add it to the cancel queue, and >>> stop the endpoint normally. >> >> this

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-03-28 Thread Moreno Bartalucci
> Il giorno 27 mar 2017, alle ore 19:15, Bin Liu ha scritto: > > […] > > The MUSB otg state machine has been changed in many place since the last > time I looked at it, and I am not sure how exactly it works now. > > If the $subject patch can correctly keep the VBUS on for