Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

On 05/19/2017 12:46 AM, Yuyang Du wrote: > On Thu, May 18, 2017 at 03:53:04PM +0300, Sergei Shtylyov wrote: >>> + if (vhci_driver->nports <=0) { >> >>Please add a space after <= too. > > Indeed. Thanks. > > Hi Greg, > > Do you want me to send another version to fix this? > Yes. Please

Re: [PATCH v2 0/9] usbip: Enable USB3 SuperSpeed

On 05/18/2017 04:08 AM, Yuyang Du wrote: > Hi Shuah, > > SuperSpeed (only) USB devices cannot be shared via usbip. This > patch series attempts to fix it. > > The first 5 patches refactors the existing code to prepare for the > SuperSpeed addition. With this series, our SuperSpeed device works >

[PATCH] ezusb: Delete an error message for a failed memory allocation in ezusb_writememory()

From: Markus Elfring Date: Fri, 19 May 2017 22:30:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link:

[PATCH 3/4] ueagle-atm: Delete unnecessary return statements in two functions

From: Markus Elfring Date: Fri, 19 May 2017 19:22:12 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions.

[PATCH 2/4] ueagle-atm: Improve a size determination in uea_bind()

From: Markus Elfring Date: Fri, 19 May 2017 19:09:28 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support

* Alan Stern [170518 10:24]: > On Wed, 17 May 2017, Tony Lindgren wrote: > > > This is needed in preparation of adding support for omap3 and > > later OHCI. The runtime PM will only do something on platforms > > that implement it. > > > @@ -51,6 +52,10 @@ static int

[PATCH 4/4] ueagle-atm: Adjust three checks for null pointers

From: Markus Elfring Date: Fri, 19 May 2017 19:29:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 1/4] ueagle-atm: Delete error messages for failed memory allocations in two functions

From: Markus Elfring Date: Fri, 19 May 2017 19:02:01 +0200 Omit two extra messages for memory allocation failures in these functions. This issue was detected by using the Coccinelle software. Link:

[PATCH 0/4] ueagle-atm: Adjustments for eight function implementations

From: Markus Elfring Date: Fri, 19 May 2017 19:41:23 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete error messages for failed memory allocations in two functions Improve a size determination

Re: [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

* Sebastian Reichel [170518 10:25]: > Hi, > > On Thu, May 18, 2017 at 07:08:58AM -0700, Tony Lindgren wrote: > > * Sebastian Reichel [170518 02:18]: > > > On Wed, May 17, 2017 at 03:59:21PM -0700, Tony Lindgren wrote: > > > > We can't just remove ohci-omap3 as

HELLO!!!!!

HELLO! I am Mr Neil Trotter, the current winner of 108 Euro millions jackpot, if you have received this email then you are of the lucky fellows to benefit from me,so do get back to me for a better understanding. Here is the website for proof

Re: Runtime PM enabled EHCI does not respond to device plugging.

On Fri, 19 May 2017, Kai-Heng Feng wrote: > Hi, > > This issue happens on Carrizo AMD laptops, only EHCI is affected, XHCI > works fine on the same machine. > > I can see lots of USB wakeup and resume messages showed every two seconds. > Plug USB devices to the EHCI port does not change

RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: Bjørn Mork > Sent: 19 May 2017 14:56 ... > Unless someone has a nice way to just collect a list of skbs and have > them converted to proper framing on the fly when transmitting, without > having to care about USB packet boundaries. skb can be linked into arbitrary chains (or even trees),

[PATCH v4] usb: musb: musb_cppi41: Defer probe only if DMA is not ready

If dma_request_slave_channel() failed to return a channel, then the driver will print an error and request to defer probe, regardless of the cause of the failure. Defer if the DMA is not ready yet otherwise print an error. Signed-off-by: Alexandre Bailon Reviewed-by: Johan

Re: [PATCH v3] usb: musb: musb_cppi41: Update an error message

On Fri, May 19, 2017 at 03:27:47PM +0200, Alexandre Bailon wrote: > If dma_request_slave_channel() failed to return a channel, > then the driver will print an error and request to defer probe, > regardless of the cause of the failure. > Defer if the DMA is not ready yet otherwise print an error.

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

David Laight writes: > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter >> Sent: 16 May 2017 18:41 >> >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the

RE: [PATCH 6/8] xhci: remove GFP_DMA flag from allocation

From: Mathias Nyman > Sent: 19 May 2017 10:49 > To: David Laight; gre...@linuxfoundation.org > Cc: linux-usb@vger.kernel.org; Matthias Lange; sta...@vger.kernel.org > Subject: Re: [PATCH 6/8] xhci: remove GFP_DMA flag from allocation > > On 19.05.2017 12:10, David Laight wrote: > > From: Mathias

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

On Fri, 19 May 2017 14:46:25 +0200 Christoph Hellwig wrote: > On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > > ktest config bisect ended with: > > > > *** > > Found bad config: CONFIG_PCI_MSI > >

[RESEND PATCH v5] ARM: dts: da850: Add the CPPI 4.1 DMA to the USB OTG controller

This adds the CPPI 4.1 DMA controller to the USB OTG controller. Changes since v2: - Fixed the the property reg-names (had glue register defined) - Removed few useless property Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 27

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

On 05/19/2017 03:35 AM, Heikki Krogerus wrote: On Thu, May 18, 2017 at 02:08:53PM -0700, Badhri Jagan Sridharan wrote: On Thu, May 18, 2017 at 9:51 AM, Guenter Roeck wrote: On Thu, May 18, 2017 at 11:13:51AM +0200, Oliver Neukum wrote: Am Mittwoch, den 17.05.2017, 02:36

[PATCH v3] usb: musb: musb_cppi41: Update an error message

If dma_request_slave_channel() failed to return a channel, then the driver will print an error and request to defer probe, regardless of the cause of the failure. Defer if the DMA is not ready yet otherwise print an error. Signed-off-by: Alexandre Bailon ---

drivers/usb/host/xhci-ring.c:1390 handle_cmd_completion

I'm having this issue on kernel 4.11.0 and 4.11.1. It usually happens after a while of ordinary USB use. Afterwards, USB does not work. If I rmmod all the modules and reinsert them, it works for a while, but even sooner after it stops working again. [48112.422418] [ cut here

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

On Fri, May 19, 2017 at 08:37:21AM -0400, Steven Rostedt wrote: > ktest config bisect ended with: > > *** > Found bad config: CONFIG_PCI_MSI > *** Oh, that's interesting. I think there's been a bug in the !CONFIG_PCI_MSI

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

On Fri, 19 May 2017 06:08:56 -0400 Steven Rostedt wrote: > > But other configs on this same hardware work, can you do a diff of a > > working vs. not working? > > I could probably run my config-bisect and see what it comes up with. ktest config bisect ended with:

RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter > Sent: 16 May 2017 18:41 > > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

Am Donnerstag, den 18.05.2017, 14:08 -0700 schrieb Badhri Jagan Sridharan: > > Badhri, would that work for us ? > > Yes Geunter that should work as well. Requesting non-pd role swap either > through > current_power_role or current_data_role is virtually the same. Yes and that is the issue. If

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

On Thu, May 18, 2017 at 02:08:53PM -0700, Badhri Jagan Sridharan wrote: > On Thu, May 18, 2017 at 9:51 AM, Guenter Roeck wrote: > > On Thu, May 18, 2017 at 11:13:51AM +0200, Oliver Neukum wrote: > >> Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck: > >> > On

Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors

On Fri, 19 May 2017 07:42:23 +0200 Greg Kroah-Hartman wrote: > On Thu, May 18, 2017 at 11:42:34PM -0400, Steven Rostedt wrote: > > > > One of my the configs I use to test ftrace with (configs that have > > caused failures in the past), has lots of irq issues and

Re: [PATCH 6/8] xhci: remove GFP_DMA flag from allocation

On 19.05.2017 12:10, David Laight wrote: From: Mathias Nyman Sent: 17 May 2017 16:32 There is no reason to restrict allocations to the first 16MB ISA DMA addresses. It is causing problems in a virtualization setup with enabled IOMMU (x86_64). The result is that USB is not working in the VM.

RE: [PATCH 6/8] xhci: remove GFP_DMA flag from allocation

From: Mathias Nyman > Sent: 17 May 2017 16:32 > There is no reason to restrict allocations to the first 16MB ISA DMA > addresses. > > It is causing problems in a virtualization setup with enabled IOMMU > (x86_64). The result is that USB is not working in the VM. ... > diff --git

[PATCH] uwb: i1480: add missing goto

Add missing goto. Addresses-Coverity-ID: 1226913 Signed-off-by: Gustavo A. R. Silva --- drivers/uwb/i1480/dfu/phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uwb/i1480/dfu/phy.c b/drivers/uwb/i1480/dfu/phy.c index 3b1a87d..1ac8526 100644 ---

Re: [uwb-i1480] question about value overwrite

Hi Greg, Quoting Greg KH : On Thu, May 18, 2017 at 06:00:06PM -0500, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226913 I ran into the following piece of code at drivers/uwb/i1480/dfu/phy.c:99: 99static 100int

[PATCH] usb: chipidea: core: check before accessing ci_role in ci_role_show

ci_role BUGs when the role is >= CI_ROLE_END. This is the case while the role is changing. Signed-off-by: Michael Thalmeier --- drivers/usb/chipidea/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c

Re: [PATCH] usb: chipidea: debug: check before accessing ci_role

On Fri, May 19, 2017 at 09:15:40AM +0800, Peter Chen wrote: > On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote: > > ci_role BUGs when the role is >= CI_ROLE_END. > > > > Signed-off-by: Michael Thalmeier > > --- > > drivers/usb/chipidea/debug.c | 3 ++-

Re: [GIT PULL] USB-serial fixes for v4.12-rc2

On Fri, May 19, 2017 at 09:52:23AM +0200, Johan Hovold wrote: > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: > > Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) > > are available in the git repository at: > >

Re: uas failing on multiple disk access on a jmicron JMS567 bridge

On 18.05.2017 17:30, Christoph Gohle wrote: Hi, I have seen several reports around the internet regarding failing io on USB-SATA bridges. However, these reports seem to be partially old and/or fixes proposed are implemented in my kernel but don’t fix things. Therefore I thought I report here

[GIT PULL] USB-serial fixes for v4.12-rc2

The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.12-rc2 for you to fetch changes up to

Re: [PATCH] usb: xhci: add quirk flag for broken stop command on AMD platforms

On 18.05.2017 16:46, Alan Stern wrote: On Thu, 18 May 2017, Shyam Sundar S K wrote: on AMD platforms with SNPS 3.1 USB controller has an issue if the stop EP command is issued when the controller is not in running state. If issued, it is leading to a critical RTL bug because of which

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

On Thu, May 18, 2017 at 03:53:04PM +0300, Sergei Shtylyov wrote: > >+if (vhci_driver->nports <=0) { > >Please add a space after <= too. Indeed. Thanks. Hi Greg, Do you want me to send another version to fix this? Thanks, Yuyang -- To unsubscribe from this list: send the line