Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread kbuild test robot
Hi Felipe, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-gadget-functions-add

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread kbuild test robot
Hi Andy, [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/usb-misc-usbsevseg-Use

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread kbuild test robot
Hi Felipe, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-gadget-functions-add

Re: [PATCH v2 2/2] usb: typec: ucsi: Add ACPI driver

2017-06-09 Thread Guenter Roeck
On 06/05/2017 07:30 AM, Heikki Krogerus wrote: Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus Reviewed-by: Guenter Roeck ---

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

2017-06-09 Thread Guenter Roeck
On 06/05/2017 07:30 AM, Heikki Krogerus wrote: UCSI - USB Type-C Connector System Software Interface - is a specification that defines set of registers and data structures for controlling the USB Type-C ports. It's designed for systems where an embedded controller (EC) is in charge of the USB

Re: [PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread kbuild test robot
Hi Andy, [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/usb-misc-usbsevseg-Use

Re: [PATCH net-next 00/11] r8152: minor adjustment

2017-06-09 Thread David Miller
From: Hayes Wang Date: Fri, 9 Jun 2017 17:11:37 +0800 > Adjust some code to make it reasonable or satisfy the suggestion from > the engineers. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-09 Thread Alan Stern
On Fri, 9 Jun 2017, Andrey Konovalov wrote: > On Fri, Jun 9, 2017 at 2:41 PM, Andrey Konovalov > wrote: > > Hi, > > > > I'm getting some hangs while fuzzing the kernel with syzkaller. > > > > Possibly it happens during the execution of the following syzkaller program: > >

Re: [PATCH 11/11] USB: usbip: convert to use DRIVER_ATTR_RW

2017-06-09 Thread Shuah Khan
On 06/09/2017 03:03 AM, Greg Kroah-Hartman wrote: > We are trying to get rid of DRIVER_ATTR(), and the usbip driver > attribute can be trivially changed to use DRIVER_ATTR_RW(). > > Cc: Valentina Manea > Cc: Shuah Khan > Cc:

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Steven Rostedt
On Fri, 09 Jun 2017 17:05:52 +0300 Felipe Balbi wrote: > Hi, > > Steven Rostedt writes: > > On Fri, 9 Jun 2017 09:13:27 +0300 > > Felipe Balbi wrote: > > > >> Allow for ftrace data to be exported over a USB

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-09 Thread Andrey Konovalov
On Fri, Jun 9, 2017 at 2:41 PM, Andrey Konovalov wrote: > Hi, > > I'm getting some hangs while fuzzing the kernel with syzkaller. > > Possibly it happens during the execution of the following syzkaller program: > > mmap(&(0x7f00/0xb9)=nil, (0xb9), 0x3, 0x32,

Re: [PATCH 0/3] USB: add API for interface driver to vote for autosuspend

2017-06-09 Thread Alan Stern
On Thu, 8 Jun 2017, Yueyao Zhu wrote: > From: Yueyao Zhu > > Currently, if a USB driver would like to enable autosuspend on the USB > device, usb_enable_autosuspend() seems to be the only option. However, > this acts on the device level, and other interfaces might not desire

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

2017-06-09 Thread Alan Stern
On Fri, 9 Jun 2017, Kai-Heng Feng wrote: > As Alan Stern points out [1], the PME signal is not enabled when > controller is in D3, therefore it's not being woken up when new deivces > get plugged in. > > Workaround this bug by preventing the controller enters D3 power state. > > [1]

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-09 Thread Alan Stern
On Fri, 9 Jun 2017, lingareddy praneethreddy wrote: > Thanks Alan. I understand and agree. > > It is a legacy platform that we are supporting and I needed to address > this issue on 3.10.17. We are in the process of migrating to 4.1.x > this coming week to check on this behavior. Until then can

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Hans de Goede
Hi, On 09-06-17 13:25, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? From:

Re: Gadget driver & virtual hub

2017-06-09 Thread Alan Stern
On Fri, 9 Jun 2017, Benjamin Herrenschmidt wrote: > On Thu, 2017-06-08 at 11:30 -0400, Alan Stern wrote: > > On Thu, 8 Jun 2017, Benjamin Herrenschmidt wrote: > > > > > Another question ... > > > > > > Do i need to support dequeue() on EP0 ? > > > > Yes.  I don't know if any drivers ever

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Felipe Balbi
Hi, Steven Rostedt writes: > On Fri, 9 Jun 2017 09:13:27 +0300 > Felipe Balbi wrote: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pipe for >> transmitting ftrace data to

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Steven Rostedt
On Fri, 9 Jun 2017 09:13:27 +0300 Felipe Balbi wrote: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to

Re: Possible bug in usb_gadget_ep_match_desc()

2017-06-09 Thread Felipe Balbi
Hi, Benjamin Herrenschmidt writes: > Another one popped to my eyes. > > The following test in usb_gadget_ep_match_desc() > (in udc core.c) > > /* "high bandwidth" works only at high speed */ > if (!gadget_is_dualspeed(gadget) && usb_endpoint_maxp(desc) &

Possible bug in usb_gadget_ep_match_desc()

2017-06-09 Thread Benjamin Herrenschmidt
Another one popped to my eyes. The following test in usb_gadget_ep_match_desc() (in udc core.c) /* "high bandwidth" works only at high speed */ if (!gadget_is_dualspeed(gadget) && usb_endpoint_maxp(desc) & (3<<11)) return 0; If you look at the definition of

Re: [PATCH v2 0/3] New driver for UCSI (USB Type-C)

2017-06-09 Thread Guenter Roeck
On 06/09/2017 04:03 AM, Heikki Krogerus wrote: Hi Guenter, On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote: Hi, This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the new USB Type-C class (drivers/usb/typec/). That allows us to finally do role swapping. The

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Hans de Goede
Hi, On 09-06-17 15:00, Benjamin Tissoires wrote: On Jun 09 2017 or thereabouts, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go

Re: usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-09 Thread Andrey Konovalov
On Fri, Jun 9, 2017 at 2:41 PM, Andrey Konovalov wrote: > Hi, > > I'm getting some hangs while fuzzing the kernel with syzkaller. > > Possibly it happens during the execution of the following syzkaller program: > > mmap(&(0x7f00/0xb9)=nil, (0xb9), 0x3, 0x32,

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Benjamin Tissoires
On Jun 09 2017 or thereabouts, Jiri Kosina wrote: > On Fri, 9 Jun 2017, Jiri Kosina wrote: > > > This is something I've been wanting to fix for ages, but never really got > > to it. So let's take this as the final impulse to do it. > > So I'd suggest to go with something like the below for

Re: [PATCH v2 2/2] phy: tusb1210: implement ->set_mode()

2017-06-09 Thread Felipe Balbi
Hi, Kishon Vijay Abraham I writes: > On Friday 09 June 2017 03:50 PM, Felipe Balbi wrote: >> ->set_mode() can be used to tell PHY to prepare itself to enter USB >> Host/Peripheral mode and that's very important for DRD >> configurations. >> >> Signed-off-by: Felipe Balbi

Re: More dynamic EP allocation

2017-06-09 Thread Benjamin Herrenschmidt
On Fri, 2017-06-09 at 14:08 +0300, Felipe Balbi wrote: > > I was originally thinking of having some device-tree construct > > assigning fixed number of EPs from the pool to the various devices, but > > that sucks... > > > > I'm trying to figure out if I can do something more dynamic. > > > > My

usb/gadget: potential deadlock in gadgetfs_suspend

2017-06-09 Thread Andrey Konovalov
Hi, I'm getting some hangs while fuzzing the kernel with syzkaller. Possibly it happens during the execution of the following syzkaller program: mmap(&(0x7f00/0xb9)=nil, (0xb9), 0x3, 0x32, 0x, 0x0) r0 =

Re: [PATCH] usb: gadget: f_mass_storage: Fix the logic to iterate all common->luns

2017-06-09 Thread Michal Nazarewicz
On Fri, Jun 09 2017, Axel Lin wrote: > It is wrong to do --i in the for loop. > > Fixes: dd02ea5a3305 ("usb: gadget: mass_storage: Use static array for luns") > Signed-off-by: Axel Lin Acked-by: Michal Nazarewicz > --- >

[PATCH v1] usb: misc: usbsevseg: Use __sysfs_match_string() helper

2017-06-09 Thread Andy Shevchenko
Use __sysfs_match_string() helper instead of open coded variant. Cc: Greg Kroah-Hartman Signed-off-by: Andy Shevchenko --- drivers/usb/misc/usbsevseg.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff

[PATCH] usb: mtu3: Handle return value of clk_prepare_enable

2017-06-09 Thread Arvind Yadav
clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/mtu3/mtu3_plat.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_plat.c

Re: [PATCH v2 2/2] phy: tusb1210: implement ->set_mode()

2017-06-09 Thread Kishon Vijay Abraham I
On Friday 09 June 2017 03:50 PM, Felipe Balbi wrote: > ->set_mode() can be used to tell PHY to prepare itself to enter USB > Host/Peripheral mode and that's very important for DRD > configurations. > > Signed-off-by: Felipe Balbi > > changes since v1: > -

Re: [PATCH v2 1/2] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
On Friday 09 June 2017 03:50 PM, Felipe Balbi wrote: > TUSB1211 is software compatible with TUSB1210 and as such we don't > need an entire new driver to control it. Let's add its product ID to > the existing TUSB1210 driver instead. > > Signed-off-by: Felipe Balbi

[PATCH 1/2] usb: xhci: Fix USB 3.1 supported protocol parsing

2017-06-09 Thread Mathias Nyman
From: YD Tseng xHCI host controllers can have both USB 3.1 and 3.0 extended speed protocol lists. If the USB3.1 speed is parsed first and 3.0 second then the minor revision supported will be overwritten by the 3.0 speeds and the USB3 roothub will only show support for

[PATCH 2/2] usb: xhci: ASMedia ASM1042A chipset need shorts TX quirk

2017-06-09 Thread Mathias Nyman
From: Corentin Labbe When plugging an USB webcam I see the following message: [106385.615559] xhci_hcd :04:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk? [106390.583860] handle_tx_event: 913 callbacks suppressed With this patch

[PATCH 0/2] xhci fixes for usb-linus

2017-06-09 Thread Mathias Nyman
Hi Greg A couple more small xhci fixes for usb-linus. -mathias Corentin Labbe (1): usb: xhci: ASMedia ASM1042A chipset need shorts TX quirk YD Tseng (1): usb: xhci: Fix USB 3.1 supported protocol parsing drivers/usb/host/xhci-mem.c | 7 +-- drivers/usb/host/xhci-pci.c | 3 +++ 2

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Hans de Goede
Hi, On 09-06-17 13:25, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? Looks

[PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

2017-06-09 Thread Jiri Kosina
On Fri, 9 Jun 2017, Jiri Kosina wrote: > This is something I've been wanting to fix for ages, but never really got > to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? From: Jiri Kosina Subject:

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-09 Thread Fabien Lahoudere
Hi Peter On Fri, 2017-06-09 at 08:26 +, Peter Chen wrote: >   > > > > I have a look at your patches > > (http://www.spinics.net/lists/linux-usb/msg157134.html) > > and I wonder if power sequence is applicable only on hub node? > > No, power sequence can be used for any devices which needs

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Felipe Balbi
Felipe Balbi writes: > Felipe Balbi writes: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pipe for >> transmitting ftrace data to a Host PC for further analysis.

Re: More dynamic EP allocation

2017-06-09 Thread Benjamin Herrenschmidt
On Fri, 2017-06-09 at 21:00 +1000, Benjamin Herrenschmidt wrote: > Hi ! > > So for the aspeed virtual hub, I'm in a situation where I have up to 5 > devices sharing a pool of 15 "generic" endpoints (not counting EP0's, > those have dedicated HW). > > I was originally thinking of having some

Re: More dynamic EP allocation

2017-06-09 Thread Felipe Balbi
Hi, Benjamin Herrenschmidt writes: > Hi ! > > So for the aspeed virtual hub, I'm in a situation where I have up to 5 > devices sharing a pool of 15 "generic" endpoints (not counting EP0's, > those have dedicated HW). > > I was originally thinking of having some

Re: [PATCH v2 0/3] New driver for UCSI (USB Type-C)

2017-06-09 Thread Heikki Krogerus
Hi Guenter, On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote: > Hi, > > This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the > new USB Type-C class (drivers/usb/typec/). That allows us to finally do > role swapping. > > The driver is now split into core library

More dynamic EP allocation

2017-06-09 Thread Benjamin Herrenschmidt
Hi ! So for the aspeed virtual hub, I'm in a situation where I have up to 5 devices sharing a pool of 15 "generic" endpoints (not counting EP0's, those have dedicated HW). I was originally thinking of having some device-tree construct assigning fixed number of EPs from the pool to the various

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Bjørn Mork
Bjørn Mork writes: > But I should probably go google now, before I repeat too mcuh of the > previous discussions ;-) I guess this is the previous proposal: https://lwn.net/Articles/121227/ and discussion: http://lkml.iu.edu/hypermail/linux/kernel/0502.1/index.html#0438 The

Re: [PATCH v2] usb: xhci: Issue stop EP command only when the EP state is running

2017-06-09 Thread Mathias Nyman
On 09.06.2017 12:44, Shyam Sundar S K wrote: On 6/7/2017 4:45 PM, Mathias Nyman wrote: Hi The internal variable is just what xhci spec recommends as it says the output context is not immediately updated for example at endpoint doorbell ring. It's to make sure we don't read stale values from

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Bjørn Mork
Greg KH writes: > On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: >> Greg KH writes: >> >> > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: >> >> Longer-term, we'd ideally make 'generic' driver special and let it attach >> >> as a 'last

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Felipe Balbi
Felipe Balbi writes: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decode the data, one needs access

[PATCH v2 2/2] phy: tusb1210: implement ->set_mode()

2017-06-09 Thread Felipe Balbi
->set_mode() can be used to tell PHY to prepare itself to enter USB Host/Peripheral mode and that's very important for DRD configurations. Signed-off-by: Felipe Balbi changes since v1: - rebase on PHY -next --- drivers/phy/ti/phy-tusb1210.c | 35

[PATCH v2 1/2] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Felipe Balbi
TUSB1211 is software compatible with TUSB1210 and as such we don't need an entire new driver to control it. Let's add its product ID to the existing TUSB1210 driver instead. Signed-off-by: Felipe Balbi --- changes since v1: - rebase on PHY -next

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Felipe Balbi
Hi, Kishon Vijay Abraham I writes: >> Kishon Vijay Abraham I writes: >>> On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: TUSB1211 is software compatible with TUSB1210 and as such we don't need an entire new driver to control it. Let's add its

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
Hi, On Friday 09 June 2017 03:27 PM, Felipe Balbi wrote: > > Hi, > > Kishon Vijay Abraham I writes: >> On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: >>> TUSB1211 is software compatible with TUSB1210 and as such we don't >>> need an entire new driver to control it. Let's

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Felipe Balbi
Hi, Kishon Vijay Abraham I writes: > On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: >> TUSB1211 is software compatible with TUSB1210 and as such we don't >> need an entire new driver to control it. Let's add its product ID to >> the existing TUSB1210 driver instead. >>

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Benjamin Tissoires
On Jun 09 2017 or thereabouts, Greg KH wrote: > On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: > > Greg KH writes: > > > > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > > >> Longer-term, we'd ideally make 'generic' driver special and let it > > >>

Re: [PATCH v2] usb: xhci: Issue stop EP command only when the EP state is running

2017-06-09 Thread Shyam Sundar S K
On 6/7/2017 4:45 PM, Mathias Nyman wrote: > Hi > > The internal variable is just what xhci spec recommends as it says the output > context is not immediately > updated for example at endpoint doorbell ring. It's to make sure we don't > read stale values from the output context. > > The race

[PATCH net-next 00/11] r8152: minor adjustment

2017-06-09 Thread Hayes Wang
Adjust some code to make it reasonable or satisfy the suggestion from the engineers. Hayes Wang (11): r8152: add r8153_phy_status function r8152: adjust lpm settings for RTL8153 r8152: adjust the settings about MAC clock speed down for RTL8153 r8152: move the setting of rx aggregation

[PATCH net-next 01/11] r8152: add r8153_phy_status function

2017-06-09 Thread Hayes Wang
Use r8153_phy_status() to check phy status of RTL8153. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

[PATCH net-next 02/11] r8152: adjust lpm settings for RTL8153

2017-06-09 Thread Hayes Wang
Enable lpm after r8153_init() and remove other enable/disable lpm. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 9239dfb..b8c904f 100644

[PATCH net-next 04/11] r8152: move the setting of rx aggregation

2017-06-09 Thread Hayes Wang
Move the setting from r8153_first_init() to r8153_init(). It only needs to be set once. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH net-next 06/11] r8152: adjust U2P3 for RTL8153

2017-06-09 Thread Hayes Wang
Use another way to keep disabling the U2P3 for both RTL_VER_03 and RTL_VER_04. Move enabling U2P3 from r8153_init() to r8153_hw_phy_cfg(). The engineer ask the setting should be done after PHY settings. Disable U2P3 first in rtl8153_up(). Signed-off-by: Hayes Wang ---

[PATCH net-next 05/11] r8152: adjust rtl8153_runtime_enable function

2017-06-09 Thread Hayes Wang
Adjust the order of rtl8153_runtime_enable() according to the suggestion from the engineer. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH net-next 07/11] r8152: move the default coalesce setting for RTL8153

2017-06-09 Thread Hayes Wang
Only RTL8153 could set coalesce, so move the default setting for rtl8152_probe() to r8153_init(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH net-next 08/11] r8152: move the initialization to reset_resume function

2017-06-09 Thread Hayes Wang
Move tp->rtl_ops.init() from rtl8152_resume() to rtl8152_reset_resume(). The initialization is only necessary for reset_resume(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 09/11] r8152: check if disabling ALDPS is finished

2017-06-09 Thread Hayes Wang
Use PLA 0xe000 bit 8 to check if disabling ALDPS is finished. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f43b7a8..204f4b2 100644

[PATCH net-next 10/11] r8152: avoid rx queue more than 1000 packets

2017-06-09 Thread Hayes Wang
Stop queuing rx packets if it is more than 1000. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 204f4b2..fa29583 100644 --- a/drivers/net/usb/r8152.c +++

[PATCH net-next 11/11] r8152: replace napi_complete with napi_complete_done

2017-06-09 Thread Hayes Wang
Change from using napi_complete to napi_complete_done to allow for the use of gro_flush_timeout in tuning network processing. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 03/11] r8152: adjust the settings about MAC clock speed down for RTL8153

2017-06-09 Thread Hayes Wang
The MAC clock speed down could be enabled if the U1/U2 is disabled. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH 11/11] USB: usbip: convert to use DRIVER_ATTR_RW

2017-06-09 Thread Greg Kroah-Hartman
We are trying to get rid of DRIVER_ATTR(), and the usbip driver attribute can be trivially changed to use DRIVER_ATTR_RW(). Cc: Valentina Manea Cc: Shuah Khan Cc: Signed-off-by: Greg Kroah-Hartman

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Greg KH
On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: > Greg KH writes: > > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > >> Longer-term, we'd ideally make 'generic' driver special and let it attach > >> as a 'last resort driver' if none of the specific

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Hans de Goede
Hi, On 09-06-17 10:52, Bjørn Mork wrote: Greg KH writes: On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: Longer-term, we'd ideally make 'generic' driver special and let it attach as a 'last resort driver' if none of the specific driver picked the device up

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Bjørn Mork
Greg KH writes: > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: >> Longer-term, we'd ideally make 'generic' driver special and let it attach >> as a 'last resort driver' if none of the specific driver picked the device >> up during probe. But I don't think our

Re: [PATCH 1/5] phy: tusb1210: add support for TUSB1211

2017-06-09 Thread Kishon Vijay Abraham I
Hi Felipe, On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote: > TUSB1211 is software compatible with TUSB1210 and as such we don't > need an entire new driver to control it. Let's add its product ID to > the existing TUSB1210 driver instead. > > Signed-off-by: Felipe Balbi

Re: [PATCH] usb: gadget: f_mass_storage: Fix the logic to iterate all common->luns

2017-06-09 Thread Krzysztof Opasiak
On 06/09/2017 10:18 AM, Axel Lin wrote: It is wrong to do --i in the for loop. Fixes: dd02ea5a3305 ("usb: gadget: mass_storage: Use static array for luns") Signed-off-by: Axel Lin --- drivers/usb/gadget/function/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Greg KH
On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > Longer-term, we'd ideally make 'generic' driver special and let it attach > as a 'last resort driver' if none of the specific driver picked the device > up during probe. But I don't think our current driver model allows this >

RE: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-09 Thread Peter Chen
> >I have a look at your patches >(http://www.spinics.net/lists/linux-usb/msg157134.html) >and I wonder if power sequence is applicable only on hub node? No, power sequence can be used for any devices which needs to carry out power on before probe. > hub are probed too >late (after

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Jiri Kosina
On Fri, 9 Jun 2017, Hans de Goede wrote: > Right, so this is not really a problem with this specific patch, but > with how the hid_have_special_driver array works in general currently it > has very few #if IS_ENABLED(CONFIG_FOO) guards around all the devices it > blacklists the generic HID

[PATCH] usb: gadget: f_mass_storage: Fix the logic to iterate all common->luns

2017-06-09 Thread Axel Lin
It is wrong to do --i in the for loop. Fixes: dd02ea5a3305 ("usb: gadget: mass_storage: Use static array for luns") Signed-off-by: Axel Lin --- drivers/usb/gadget/function/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

2017-06-09 Thread Hans de Goede
Hi, First of all lets add the HID subsys maintainers to the To list (done). On 08-06-17 22:17, Linus Torvalds wrote: On Thu, Jun 8, 2017 at 12:49 PM, Alan Stern wrote: So maybe CONFIG_HID_ASUS should default to Y? I'll leave it up to Hans to straighten this out.

[PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

2017-06-09 Thread Kai-Heng Feng
As Alan Stern points out [1], the PME signal is not enabled when controller is in D3, therefore it's not being woken up when new deivces get plugged in. Workaround this bug by preventing the controller enters D3 power state. [1] https://www.spinics.net/lists/linux-usb/msg157462.html

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-09 Thread Felipe Balbi
Hi, lingareddy praneethreddy writes: >>> Until then can you help us with the one thing i.e. can you point me to >>> where in the latest kernel code is the warm reset initiated? Thanks >>> again. >> >> You have the full source tree, it's easier for you to search for

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-09 Thread lingareddy praneethreddy
On Fri, Jun 9, 2017 at 12:19 PM, Greg KH wrote: > On Fri, Jun 09, 2017 at 11:57:23AM +0530, lingareddy praneethreddy wrote: >> On Wed, Jun 7, 2017 at 9:09 PM, Alan Stern wrote: >> > On Wed, 7 Jun 2017, lingareddy praneethreddy wrote: >> > >> >> On Tue,

Re: [PATCH] usb: gadget: dummy: implement ->udc_set_speed()

2017-06-09 Thread Felipe Balbi
Hi, Alan Stern writes: > On Thu, 8 Jun 2017, Felipe Balbi wrote: > >> > Any results on testing the new memory barrier and exception handling >> > patches for f_mass_storage? >> >> Oh, I couldn't reproduce anymore. I thought I had told ya. Hopefully, >> this will be

Re: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-09 Thread Greg KH
On Fri, Jun 09, 2017 at 06:33:39AM +, Lars Chang(張家豪) wrote: > == > This email and any attachments to it contain confidential information and are > intended solely for the use of

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-09 Thread Greg KH
On Fri, Jun 09, 2017 at 11:57:23AM +0530, lingareddy praneethreddy wrote: > On Wed, Jun 7, 2017 at 9:09 PM, Alan Stern wrote: > > On Wed, 7 Jun 2017, lingareddy praneethreddy wrote: > > > >> On Tue, Jun 6, 2017 at 7:38 PM, Alan Stern > >>

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-09 Thread 張家豪
> -Original Message- > From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] > Sent: Friday, June 09, 2017 2:04 PM > To: Jiahau Chang; linux-usb@vger.kernel.org; mathias.ny...@intel.com > Cc: Brain Lee(李魁中); mario.limoncie...@dell.com; Justin_CY Chen(陳志勇); > keith_w...@dell.com; Yd

RTL8153 connected via ASM1042A causes transfer errors

2017-06-09 Thread Frederik Schwan
Hi everyone, here is a bug that occurs when a RTL8153 is connected to the host via an ASM1042A chip. I wrongly submitted a report at bugzilla.kernel.org - sorry for that. RTL8153 connected via ASM1042A is used in Dell's TB15 and TB16 docks. So anyone using these docks is probably affected.

RE: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-09 Thread Felipe Balbi
Hi, "Lars Chang(張家豪)" writes: >> -Original Message- >> From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] >> Sent: Friday, June 09, 2017 2:04 PM >> To: Jiahau Chang; linux-usb@vger.kernel.org; mathias.ny...@intel.com >> Cc: Brain Lee(李魁中);

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-09 Thread lingareddy praneethreddy
On Wed, Jun 7, 2017 at 9:09 PM, Alan Stern wrote: > On Wed, 7 Jun 2017, lingareddy praneethreddy wrote: > >> On Tue, Jun 6, 2017 at 7:38 PM, Alan Stern wrote: >> >>On Tue, 6 Jun 2017, lingareddy praneethreddy wrote: >> >> >> >> I am using

[PATCH] usb: gadget: functions: add ftrace export over USB

2017-06-09 Thread Felipe Balbi
Allow for ftrace data to be exported over a USB Gadget Controller. With this, we have a potentially very fast pipe for transmitting ftrace data to a Host PC for further analysis. Note that in order to decode the data, one needs access to kernel symbols in order to convert binary data into

Re: [PATCH v2] xhci: Bad Ethernet performance plugged in ASM1042A host

2017-06-09 Thread Felipe Balbi
Hi, Jiahau Chang writes: > v2 : fix coding format this doesn't need to be in the commit log. You should place such notes after the tearline (---) below > When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad > performance was manifesting in Web browser use (like