[PATCH 4/4] [media] zr364xx: Fix a typo in a comment line of the file header

2017-08-28 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 28 Aug 2017 22:46:30 +0200 Fix a word in this description. Signed-off-by: Markus Elfring --- drivers/media/usb/zr364xx/zr364xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] [media] zr364xx: Adjust ten checks for null pointers

2017-08-28 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 28 Aug 2017 22:40:47 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 2/4] [media] zr364xx: Improve a size determination in zr364xx_probe()

2017-08-28 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 28 Aug 2017 22:28:02 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/4] [media] zr364xx: Delete an error message for a failed memory allocation in two functions

2017-08-28 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 28 Aug 2017 22:23:56 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/4] [media] zr364xx: Adjustments for some function implementations

2017-08-28 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Aug 2017 07:17:07 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Improve a size

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-28 Thread Kai-Heng Feng
On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman wrote: > On 28.08.2017 12:29, Greg KH wrote: >> >> On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: >>> >>> This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. >>> >>> Commit dec08194ffec ("xhci:

[PATCH v3 1/1] usbip: auto retry for concurrent attach

2017-08-28 Thread Nobuo Iwata
This patch adds recovery from false busy state on concurrent attach operation. The procedure of attach operation is as below. 1) Find an unused port in /sys/devices/platform/vhci_hcd/status. (userspace) 2) Request attach found port to driver through /sys/devices/platform/vhci_hcd/attach.

Re: [PATCH v2] cdc_ncm: flag the u-blox TOBY-L4 as wwan

2017-08-28 Thread David Miller
From: Aleksander Morgado Date: Fri, 25 Aug 2017 15:39:16 +0200 > The u-blox TOBY-L4 is a LTE Advanced (Cat 6) module with HSPA+ and 2G > fallback. > > Unlike the TOBY-L2, this module has one single USB layout and exposes > several TTYs for control and a NCM interface

Re: [PATCH V2] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Adam Wallis
On 8/28/2017 1:57 PM, Vivek Gautam wrote: > Hi Adam, > > > On Mon, Aug 28, 2017 at 10:05 PM, Adam Wallis wrote: >> The dma ops from the parent DWC device are not getting passed to the >> child xhci-hcd device. This patch makes use of >> platform_device_register_full to

Re: [PATCH V2] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Grygorii Strashko
Hi On 08/28/2017 11:35 AM, Adam Wallis wrote: > The dma ops from the parent DWC device are not getting passed to the > child xhci-hcd device. This patch makes use of > platform_device_register_full to set the DMA ops. For the DT/OF case, > dma_ops were still null after the the device register, so

Re: [PATCH V2] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Vivek Gautam
Hi Adam, On Mon, Aug 28, 2017 at 10:05 PM, Adam Wallis wrote: > The dma ops from the parent DWC device are not getting passed to the > child xhci-hcd device. This patch makes use of > platform_device_register_full to set the DMA ops. For the DT/OF case, > dma_ops were

[PATCH] usb: core: usbport: fix "BUG: key not in .data" when lockdep is enabled

2017-08-28 Thread Christian Lamparter
This patch fixes a splat that happens if CONFIG_DEBUG_LOCK_ALLOC is enabled and the ledtrig_usbport is loaded. (on a device that has some usb ports). [ 60.695479] BUG: key c53f8420 not in .data! [ 60.695521] [ cut here ] [ 60.698542] WARNING: CPU: 1 PID: 854 at

[PATCH v2] USB: xhci: reducing HS port auto-resume latency.

2017-08-28 Thread anshuman . gupta
From: Anshuman Gupta This patch will improve the variable auto-resume latency of an usb-port. When xhci gets a HS port status change event interrupt due to PORT_PLC (port link state transition), linux Host controller driver drives the resume signalling on the bus for

[PATCH V2] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Adam Wallis
The dma ops from the parent DWC device are not getting passed to the child xhci-hcd device. This patch makes use of platform_device_register_full to set the DMA ops. For the DT/OF case, dma_ops were still null after the the device register, so of_dma_configure is called in only the OF case.

Re: ASM1153 detected as ASM1051 and breaking UAS

2017-08-28 Thread Oliver Neukum
Am Montag, den 28.08.2017, 17:08 +0200 schrieb Oliver Neukum: > Am Donnerstag, den 24.08.2017, 14:05 +0200 schrieb Massimo Burcheri: > > > > > > Bus 004 Device 005: ID 174c:5106 ASMedia Technology Inc. ASM1051 SATA 3Gb/s > > bridge > > Device Descriptor: > > bLength18 > >

Re: [PATCH] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Adam Wallis
On 8/25/2017 7:03 PM, Grygorii Strashko wrote: > > > On 08/25/2017 01:02 PM, Adam Wallis wrote: >> The dma ops from the parent DWC device are not getting passed to the >> child xhci-hcd device. This patch makes use of >> platform_device_register_full to set the DMA ops. For the DT/OF case, >>

Re: [PATCH] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Adam Wallis
On 8/28/2017 9:05 AM, Felipe Balbi wrote: > > Hi, > > Adam Wallis writes: >> The dma ops from the parent DWC device are not getting passed to the >> child xhci-hcd device. This patch makes use of >> platform_device_register_full to set the DMA ops. For the DT/OF case, >>

Re: ASM1153 detected as ASM1051 and breaking UAS

2017-08-28 Thread Oliver Neukum
Am Donnerstag, den 24.08.2017, 14:05 +0200 schrieb Massimo Burcheri: > > Bus 004 Device 005: ID 174c:5106 ASMedia Technology Inc. ASM1051 SATA 3Gb/s > bridge > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 3.00 > bDeviceClass

Re: Possible regression between 4.9 and 4.13

2017-08-28 Thread Mason
On 28/08/2017 10:39, Mathias Nyman wrote: > Could you take a log with the following added debug, without > your extra delays, It should show a bit more about the state > of the controller when we read 0x I applied the following patch on top of v4.12-rc1 diff --git

Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1

2017-08-28 Thread Maciej S. Szmigiero
Hi Johan, On 28.08.2017 12:19, Johan Hovold wrote: > On Mon, Aug 21, 2017 at 05:43:46PM +0200, Maciej S. Szmigiero wrote: >> This commit adds support (IDs, really) for D-Link DWM-157 hardware version >> C1 USB modem to option driver. >> >> According to manufacturer-provided Windows INF file the

[RFC PATCH 4/4] USB: adutux: fix debugging

2017-08-28 Thread Oliver Neukum
Handling for removal of the controller was missing at one place. Add it. Signed-of-by: Oliver Neukum --- drivers/usb/misc/adutux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 17a4702d4636..14bf2beaf964 100644

[RFC PATCH 2/4] USB: adutux: fix locking on disconnect

2017-08-28 Thread Oliver Neukum
The driver uses udev as a flag. Some functions using it hold the global mutex and other the device's mutex. Setting it to NULL requires both mutexes to be held. Signed-off-by: Oliver Neukum Fixes: f08812d5eb8f8 ("USB: FIx locks and urb->status in adutux (updated)") Reported-by:

[RFC PATCH 3/4] USB: adutux: add a clear flag for disconnect

2017-08-28 Thread Oliver Neukum
Drivers operate on interfaces and using the device pointer as a flag is unclean. This patch makes things explicit. Signed-off-by: Oliver Neukum --- drivers/usb/misc/adutux.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff

[RFC PATCH 1/4] USb: adutux: fix oops on disconnect from debug statements

2017-08-28 Thread Oliver Neukum
The driver uses setting the udev pointer to NULL on disconnect. Hence you cannot use it in debug statements to feed a device to dev_dbg(). Johan added a stored pointer to the interface. It can serve for dev_debg() Signed-off-by: Oliver Neukum Reported-by: Anton Volkov

[PATCHv2 7/7] ARM: dts: stm32: Enable USB FS on stm32f746-disco

2017-08-28 Thread Amelie Delaunay
This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS enable. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746-disco.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746-disco.dts

[PATCHv2 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-28 Thread Amelie Delaunay
This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32746g-eval.dts

[PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding

2017-08-28 Thread Amelie Delaunay
This patch adds binding documentation for DWC2 controller in HS mode found on STMicroelectronics STM32F7 SoC. Signed-off-by: Amelie Delaunay --- Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCHv2 0/7] Add support for USB OTG on STM32F7

2017-08-28 Thread Amelie Delaunay
The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB OTG FS and the other is USB OTG HS. The USB FS core only works with its internal phy whilst the USB HS core can work in HS with external ULPI phy or in FS/LS with the on-chip FS phy. Amelie Delaunay (7): dt-bindings: usb:

[PATCHv2 3/7] ARM: dts: stm32: Add USB HS support for STM32F746 MCU

2017-08-28 Thread Amelie Delaunay
This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 49 1 file changed, 49 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746.dtsi

[PATCHv2 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

2017-08-28 Thread Amelie Delaunay
This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746.dtsi

[PATCHv2 5/7] ARM: dts: stm32: Enable USB HS on stm32f746-disco

2017-08-28 Thread Amelie Delaunay
This patch enables USB HS on stm32f746-disco (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746-disco.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746-disco.dts

[PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

2017-08-28 Thread Amelie Delaunay
This patch adds the dwc2_set_params function for STM32F7 USB OTG HS. Signed-off-by: Amelie Delaunay --- drivers/usb/dwc2/params.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index a3ffe97..d5b672d

Re: ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Matwey V. Kornilov
Hi all, I've just realized what is the reason for such long delays (~250ms) between setting ASYNC_LOW_LATENCY and starting receiving incoming data. Setting ASYNC_LOW_LATENCY leads to setting FTDI latency timer limit which is expressed in ms and allowed to be between 1ms and 255ms. Current default

Re: [PATCH] usb: dwc3: Initialize DMA ops/mask for xhci-hcd

2017-08-28 Thread Felipe Balbi
Hi, Adam Wallis writes: > The dma ops from the parent DWC device are not getting passed to the > child xhci-hcd device. This patch makes use of > platform_device_register_full to set the DMA ops. For the DT/OF case, > dma_ops were still null after the the device

Re: xhci bandwidth problem with isochronous endpoints

2017-08-28 Thread Mathias Nyman
On 19.07.2017 01:39, Curt Meyers wrote: Hello, I have a new USB3 camera that can only operate in isochronous mode. I can open and stream data from the camera using guvcview. The camera has 3 interfaces, two show up as uvc video devices. The interface I open claims a maximum bandwidth

Re: Possible null pointer dereference in adutux.ko

2017-08-28 Thread Oliver Neukum
Am Freitag, den 18.08.2017, 18:04 +0300 schrieb Anton Volkov: > > On 15.08.2017 18:58, Oliver Neukum wrote: > > > > Am Dienstag, den 15.08.2017, 16:38 +0300 schrieb Anton Volkov: > > > > > > On 15.08.2017 16:20, Oliver Neukum wrote: > > > > > > > > > > > > Am Dienstag, den 15.08.2017, 15:59

[PATCH] usb: phy: Avoid unchecked dereference warning

2017-08-28 Thread Baolin Wang
Move the USB phy NULL checking before issuing usb_phy_set_charger_current() to avoid unchecked dereference warning. Signed-off-by: Baolin Wang --- include/linux/usb/phy.h |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/usb/phy.h

Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1

2017-08-28 Thread Johan Hovold
On Mon, Aug 21, 2017 at 05:43:46PM +0200, Maciej S. Szmigiero wrote: > This commit adds support (IDs, really) for D-Link DWM-157 hardware version > C1 USB modem to option driver. > > According to manufacturer-provided Windows INF file the device has four > serial ports: > "D-Link HSPA+DataCard

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-28 Thread Mathias Nyman
On 28.08.2017 12:29, Greg KH wrote: On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD Promontory hosts") makes all high speed USB ports on ASUS PRIME

Re: ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Matwey V. Kornilov
2017-08-28 11:22 GMT+03:00 Matwey V. Kornilov : > Hi all, > > I have an issue with the following patch: > c6dce2626606 ("USB: serial: ftdi_sio: fix extreme low-latency setting") > > I really need sub 16-ms latency for my peripheral and while I have no > problems with

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-28 Thread Greg KH
On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: > This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. > > Commit dec08194ffec ("xhci: Limit USB2 port wake support for AMD Promontory > hosts") makes all high speed USB ports on ASUS PRIME B350M-A cease to > function after

Re: BUG/PATCH: cp210x.c - reenable support for chips which don't report a partnum

2017-08-28 Thread Johan Hovold
On Wed, Aug 09, 2017 at 02:18:06PM +0200, Sebastian Frei wrote: Thanks for the patch. I have few comments below, and also make sure to send the patch with a proper subject line, such as: [PATCH v2] USB: serial: cp210x: fix partnum regression > Make cp210x not abort if part number could

Re: ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Matwey V. Kornilov
2017-08-28 11:49 GMT+03:00 Greg KH : > On Mon, Aug 28, 2017 at 11:22:48AM +0300, Matwey V. Kornilov wrote: >> Hi all, >> >> I have an issue with the following patch: >> c6dce2626606 ("USB: serial: ftdi_sio: fix extreme low-latency setting") >> >> I really need sub 16-ms

Re: [PATCH] USB: serial: ti_usb_3410_5052: Port uart_mode from io_ti.

2017-08-28 Thread Greg KH
On Fri, Aug 18, 2017 at 12:56:59PM +1000, Stuart Longland wrote: > This introduces the `uart_mode` sysfs attribute as seen in the `io_ti` > USB serial driver, allowing this USB serial interface to be switched > between RS-232, 2-wire RS-485 and 4-wire RS-485. > >

Re: usb: chipidea changes for v4.14-rc1

2017-08-28 Thread Greg Kroah-Hartman
On Mon, Aug 28, 2017 at 11:35:01AM +0800, Peter Chen wrote: > The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: > > Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) > > are available in the git repository at: > >

Re: ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Greg KH
On Mon, Aug 28, 2017 at 11:22:48AM +0300, Matwey V. Kornilov wrote: > Hi all, > > I have an issue with the following patch: > c6dce2626606 ("USB: serial: ftdi_sio: fix extreme low-latency setting") > > I really need sub 16-ms latency for my peripheral and while I have no > problems with idea of

Re: [bug report] usb: phy: Add USB charger support

2017-08-28 Thread Baolin Wang
Hi Felipe, On 28 August 2017 at 15:58, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi Dan, >> >> On 25 August 2017 at 20:20, Dan Carpenter wrote: >>> Hello Baolin Wang, >>> >>> This is a semi-automatic

Re: [PATCH 1/7] dt-bindings: usb: Document the STM32F7xx DWC2 USB OTG HS core binding

2017-08-28 Thread Amelie DELAUNAY
On 08/22/2017 04:10 AM, Rob Herring wrote: > On Thu, Aug 17, 2017 at 11:33:00AM +0200, Amelie Delaunay wrote: >> This patch adds binding documentation for DWC2 controller in HS mode found >> on STMicroelectronics STM32F7xx SoC. >> >> Signed-off-by: Amelie Delaunay >> ---

Re: Possible regression between 4.9 and 4.13

2017-08-28 Thread Mathias Nyman
On 23.08.2017 17:30, Mason wrote: On 23/08/2017 14:41, Mason wrote: I compiled a minimal kernel, with lots of irrelevant drivers and frameworks left out, including power management. I still get the "xHCI host controller not responding, assume dead" issue. The problem seems to have a

ftdi_sio: timing issue while setting ASYNC_LOW_LATENCY from user space

2017-08-28 Thread Matwey V. Kornilov
Hi all, I have an issue with the following patch: c6dce2626606 ("USB: serial: ftdi_sio: fix extreme low-latency setting") I really need sub 16-ms latency for my peripheral and while I have no problems with idea of setting ASYNC_LOW_LATENCY I would like point out that it doesn't work as expected

Re: [bug report] usb: phy: Add USB charger support

2017-08-28 Thread Felipe Balbi
Hi, Baolin Wang writes: > Hi Dan, > > On 25 August 2017 at 20:20, Dan Carpenter wrote: >> Hello Baolin Wang, >> >> This is a semi-automatic email about new static checker warnings. >> >> The patch a9081a008f84: "usb: phy: Add USB charger