Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread David Miller
From: Kristian Evensen Date: Tue, 7 Nov 2017 13:47:56 +0100 > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter,

Re: [PATCH net,stable] net: cdc_ether: fix divide by 0 on bad descriptors

2017-11-07 Thread David Miller
From: Bjørn Mork Date: Mon, 6 Nov 2017 15:37:22 +0100 > Setting dev->hard_mtu to 0 will cause a divide error in > usbnet_probe. Protect against devices with bogus CDC Ethernet > functional descriptors by ignoring a zero wMaxSegmentSize. > > Signed-off-by: Bjørn Mork

Re: [PATCH net,stable] net: qmi_wwan: fix divide by 0 on bad descriptors

2017-11-07 Thread David Miller
From: Bjørn Mork Date: Mon, 6 Nov 2017 15:32:18 +0100 > A CDC Ethernet functional descriptor with wMaxSegmentSize = 0 will > cause a divide error in usbnet_probe: > > divide error: [#1] PREEMPT SMP KASAN ... > Fix by simply ignoring the bogus descriptor, as it is optional

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-07 Thread wlf
Hi Alan, 在 2017年11月07日 23:18, Alan Stern 写道: On Tue, 7 Nov 2017, wlf wrote: That sounds like a good idea. Minas, does the following patch fix your problem? In theory we could do this calculation for every isochronous URB, not just those coming from usbfs. But I don't think there's any

Re: [PATCH 2/2] usbip: use monotonic timestamps

2017-11-07 Thread Shuah Khan
On 11/07/2017 04:22 AM, Krzysztof Opasiak wrote: > > > On 11/07/2017 11:39 AM, Arnd Bergmann wrote: >> This gets rid of the deprecated do_gettimeofday() function in usbip. >> The comment above vgadget_get_frame() mentions that it suffers >> from issues with the time jumps due to suspend and

Re: [PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Shuah Khan
On 11/07/2017 04:21 AM, Krzysztof Opasiak wrote: > > > On 11/07/2017 11:39 AM, Arnd Bergmann wrote: >> vgadget_get_frame returns a frame number from 0 to 2046, which >> may require an expensive division operation to wrap at one lower >> than the usual number. >> >> I can't see any reason for

Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev

2017-11-07 Thread Robert Jarzmik
Colin King writes: > From: Colin Ian King > > Variable is_short is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. Pointer dev is assigned a

Re: WARNING in usb_submit_urb

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, Greg KH wrote: > On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 36ef71cae353f88fd6e095e2aaa3e5953af1685d > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > > compiler: gcc (GCC)

Re: [PATCH] usb: host: fix incorrect updating of offset

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, Colin King wrote: > From: Colin Ian King > > The variable temp is incorrectly being updated, instead it should > be offset otherwise the loop just reads the same capability value > and loops forever. Thanks to Alan Stern for pointing out the >

Re: [PATCH] USB: remove redundant assignment to temp

2017-11-07 Thread Colin Ian King
On 07/11/17 15:42, Alan Stern wrote: > On Tue, 7 Nov 2017, Colin King wrote: > >> From: Colin Ian King >> >> The variable temp is being set at the end of each loop iteration >> but this value is never read, it is either being updated in just >> the case 1 block or at

[PATCH] usb: host: fix incorrect updating of offset

2017-11-07 Thread Colin King
From: Colin Ian King The variable temp is incorrectly being updated, instead it should be offset otherwise the loop just reads the same capability value and loops forever. Thanks to Alan Stern for pointing out the correct fix to my original fix. Fix also cleans up

Re: WARNING in usb_submit_urb

2017-11-07 Thread Greg KH
On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 36ef71cae353f88fd6e095e2aaa3e5953af1685d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: Suspend to disk with usb connected fails to detect usb(reset) during resume

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, Ivid Suvarna wrote: > Hi, > > I am trying to support suspend to disk(hibernate) on Hikey with 4.4 > kernel. During suspend, I could see the usb devices getting reset and I > can access them properly. Message can be seen as below: > > usb 1-1: reset high-speed USB device

Re: [PATCH v3] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-07 Thread Guenter Roeck
On Mon, Nov 6, 2017 at 6:01 PM, Yu Chen wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [9.261355] []

Re: [PATCH] USB: remove redundant assignment to temp

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, Colin King wrote: > From: Colin Ian King > > The variable temp is being set at the end of each loop iteration > but this value is never read, it is either being updated in just > the case 1 block or at the end of the loop. Thus the assignment > is

RE: [RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-07 Thread Adam Thomson
On 06 November 2017 13:26, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 01, 2017 at 05:03:13PM +, Adam Thomson wrote: > > This adds a type to represent USB PPS chargers as defined in the > > USB Power Delivery Specification Revision 3.0 V1.1 > > > > Signed-off-by: Adam Thomson

Re: [PATCH] usb: core: lower log level when device is not able to deal with string

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, Greg KH wrote: > On Tue, Nov 07, 2017 at 03:58:29AM -0500, Kai-Heng Feng wrote: > > USB devices should work just fine when they don't support language id. > > They still work, but it's a "broken" device, and it should be fixed (I > thought it was part of the spec, but I can't

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-07 Thread Alan Stern
On Tue, 7 Nov 2017, wlf wrote: > > That sounds like a good idea. Minas, does the following patch fix your > > problem? > > > > In theory we could do this calculation for every isochronous URB, not > > just those coming from usbfs. But I don't think there's any point, > > since the USB class

Re: [PATCH 3/6] USB: chipidea: ci_hdrc_tegra.c: add SPDX line

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 09:36:48AM +0800, Peter Chen wrote: > On Mon, Nov 06, 2017 at 04:34:09PM +0100, Greg Kroah-Hartman wrote: > > The license text was removed from this file, yet they somehow missed > > the big "add SPDX tags to all files" sweep due to them being new. So > > add the proper

Re: [PATCH 5/6] USB: typec: add SPDX identifiers to some files

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 11:32:07AM +, Rui Miguel Silva wrote: > Hi, > On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman > wrote: > > Due to these typec files being moved into the drivers/usb/ directory in > > this tree, they missed the larger "add SPDX tags to all

Re: [PATCH v2 0/5] usb: core: add support for PTM status

2017-11-07 Thread Greg Kroah-Hartman
On Thu, Nov 02, 2017 at 10:57:37AM +0200, Felipe Balbi wrote: > Hi, > > Here's the new revision of PTM status support patches with the changes > requested by Alan Stern. > > Changes since v1: > - move code around to avoid two changes to all users of > usb_get_status() Now applied,

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 03:12:24PM -0600, Li Yang wrote: > On Mon, Nov 6, 2017 at 8:37 AM, Greg Kroah-Hartman > wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 08:15:50AM +0100, Robert Jarzmik wrote: > Greg Kroah-Hartman writes: > > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 03:50:31PM +0100, Nicolas Ferre wrote: > On 06/11/2017 at 15:37, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no

Re: [PATCH 03/24] USB: renesas_usbhs: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 09:19:25AM +, Yoshihiro Shimoda wrote: > Hi, > > > From: Greg Kroah-Hartman, Sent: Monday, November 6, 2017 11:37 PM > > > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text

Re: [PATCH 07/24] USB: mtu3: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 09:55:03AM +0800, Chunfeng Yun wrote: > On Mon, 2017-11-06 at 15:37 +0100, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 11:05:44PM +, Vincent Pelletier wrote: > On Mon, 6 Nov 2017 15:37:32 +0100, Greg Kroah-Hartman > wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra

Re: [PATCH 13/24] USB: early: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 10:39:30AM +0800, Lu Baolu wrote: > Hi, > > On 11/06/2017 10:37 PM, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is

Re: [PATCH 06/24] USB: musb: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 09:59:42AM -0600, Bin Liu wrote: > On Mon, Nov 06, 2017 at 03:37:15PM +0100, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed

Re: [PATCH 02/24] USB: usbip: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 08:41:20AM -0700, Shuah Khan wrote: > On 11/06/2017 07:37 AM, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no

Re: [PATCH 21/24] USB: gadget: legacy: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 09:00:46AM +0200, Laurent Pinchart wrote: > Hi Greg, > > Thank you for the patch. > > On Monday, 6 November 2017 16:37:30 EET Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner.

Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 04:55:06PM +0100, Michal Nazarewicz wrote: > On Mon, Nov 06 2017, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no

Re: [PATCH 05/24] USB: typec: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 04:51:48PM +0200, Heikki Krogerus wrote: > On Mon, Nov 06, 2017 at 03:37:14PM +0100, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be

[PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev

2017-11-07 Thread Colin King
From: Colin Ian King Variable is_short is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Pointer dev is assigned a value that is not read and it is updated a few statements

Re: [PATCH 17/24] USB: host: ehci: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 01:36:15PM -0500, Alan Stern wrote: > On Mon, 6 Nov 2017, Greg Kroah-Hartman wrote: > > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no

Re: [PATCH 04/24] USB: phy: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 04:46:42PM +0200, Felipe Balbi wrote: > Greg Kroah-Hartman writes: > > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as

Re: [PATCH 09/24] USB: chipidea: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 09:35:03AM +0800, Peter Chen wrote: > On Mon, Nov 06, 2017 at 03:37:18PM +0100, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be

Re: [PATCH 14/24] USB: host: xhci: Remove redundant license text

2017-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2017 at 01:31:52PM +0200, Mathias Nyman wrote: > On 06.11.2017 16:37, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no

Re: [PATCH v3] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-07 Thread Mathias Nyman
On 07.11.2017 04:01, Yu Chen wrote: From: Yu Chen Check vdev->real_port 0 to avoid panic [9.261347] [] xhci_free_virt_devices_depth_first+0x58/0x108 [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 [9.261355] [] xhci_stop+0x140/0x1c8 [9.261365] []

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Kristian Evensen
Hei, On Tue, Nov 7, 2017 at 2:02 PM, Bjørn Mork wrote: > And his should probably go to stable as well? with a > > Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") Yes, I forgot to add the fixes-tag + comment about stable. Should I submit a v2? -Kristian -- To

NAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short

2017-11-07 Thread Colin Ian King
On 07/11/17 14:31, Colin King wrote: > From: Colin Ian King > > Variable is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed. Cleans up clang warning: > >

[PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short

2017-11-07 Thread Colin King
From: Colin Ian King Variable is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Cleans up clang warning: drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored

Re: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support

2017-11-07 Thread Mathias Nyman
On 07.11.2017 13:00, Biju Das wrote: Hi Mathias, Does this patch look okay to you? Yes, Adding to queue, Will send out after rc1 Thanks -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

2017-11-07 Thread kbuild test robot
Hi Ruslan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.14-rc8 next-20171107] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Bjørn Mork
Kristian Evensen writes: > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter, the packets have > no MAC header and

[PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread Kristian Evensen
When we receive a packet on a QMI device in raw IP mode, we should call skb_reset_mac_header() to ensure that skb->mac_header contains a valid offset in the packet. While it shouldn't really matter, the packets have no MAC header and the interface is configured as-such, it seems certain parts of

[PATCH] usb: host: isp1362-hcd: remove a couple of redundant assignments

2017-11-07 Thread Colin King
From: Colin Ian King Variable index is being initialized and the value is never read, it is being updated a few statements later, so remove the redundant initialization. Variable total is being updated but the value is never read, so this is also redundant and can be

Re: [PATCH 2/2 v5] typec: tcpm: Only request matching pdos

2017-11-07 Thread Heikki Krogerus
On Sat, Nov 04, 2017 at 12:22:13PM -0700, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and always selects the pdo with highest > possible power within the board limit. This assumption > might not hold good for all devices. To

[PATCH] USB: adutux: remove redundant variable minor

2017-11-07 Thread Colin King
From: Colin Ian King Variable minor is being assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/usb/misc/adutux.c:770:2: warning: Value stored to 'minor' is never read Signed-off-by: Colin Ian King

Re: [PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

2017-11-07 Thread kbuild test robot
Hi Ruslan, Thank you for the patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.14-rc8 next-20171107] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 6/6] USB: typec: Remove remaining redundant license text

2017-11-07 Thread Rui Miguel Silva
Hi, On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is

Re: [PATCH 5/6] USB: typec: add SPDX identifiers to some files

2017-11-07 Thread Rui Miguel Silva
Hi, On Mon 06 Nov 2017 at 15:34, Greg Kroah-Hartman wrote: > Due to these typec files being moved into the drivers/usb/ directory in > this tree, they missed the larger "add SPDX tags to all files" work. So > add the correct SPDX license tag, based on the license text

Re: [PATCH 2/6] USB: host: xhci-debugfs: add SPDX lines

2017-11-07 Thread Mathias Nyman
On 06.11.2017 17:34, Greg Kroah-Hartman wrote: The license text was removed from these files, yet they somehow missed the big "add SPDX tags to all files" sweep due to them being new. So add the proper SPDX license tag to them, based on the original license text in the file. Cc: Mathias Nyman

Re: [PATCH 14/24] USB: host: xhci: Remove redundant license text

2017-11-07 Thread Mathias Nyman
On 06.11.2017 16:37, Greg Kroah-Hartman wrote: Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different

Re: [PATCH 2/2] usbip: use monotonic timestamps

2017-11-07 Thread Krzysztof Opasiak
On 11/07/2017 11:39 AM, Arnd Bergmann wrote: This gets rid of the deprecated do_gettimeofday() function in usbip. The comment above vgadget_get_frame() mentions that it suffers from issues with the time jumps due to suspend and settimeofday, so I'm changing it to use ktime_get_ts64() to use

Re: [PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Krzysztof Opasiak
On 11/07/2017 11:39 AM, Arnd Bergmann wrote: vgadget_get_frame returns a frame number from 0 to 2046, which may require an expensive division operation to wrap at one lower than the usual number. I can't see any reason for this, and all other drivers wrap at a power-of-two number. My best

RE: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support

2017-11-07 Thread Biju Das
Hi Mathias, Does this patch look okay to you? Regards, Biju > -Original Message- > From: Yoshihiro Shimoda > Sent: 17 October 2017 02:34 > To: Biju Das ; Greg Kroah-Hartman > ; Felipe Balbi ; Rob Herring >

Re: [PATCH 1/2 v5] typec: tcpm: Validate source and sink caps

2017-11-07 Thread Heikki Krogerus
On Sat, Nov 04, 2017 at 12:22:12PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates whether the src_caps/snk_caps adheres > to it. > > 6.4.1 Capabilities Message > A Capabilities message (Source Capabilities message or Sink

Re: [PATCH 1/6] USB: add SPDX identifiers to all remaining Makefiles

2017-11-07 Thread Heikki Krogerus
On Mon, Nov 06, 2017 at 04:34:07PM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > This updates the remaining drivers/usb/*Makefile* that were missing SPDX > identifiers. They all get the

[PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Arnd Bergmann
vgadget_get_frame returns a frame number from 0 to 2046, which may require an expensive division operation to wrap at one lower than the usual number. I can't see any reason for this, and all other drivers wrap at a power-of-two number. My best explanation is that it was a simple typo, so I'm

[PATCH 2/2] usbip: use monotonic timestamps

2017-11-07 Thread Arnd Bergmann
This gets rid of the deprecated do_gettimeofday() function in usbip. The comment above vgadget_get_frame() mentions that it suffers from issues with the time jumps due to suspend and settimeofday, so I'm changing it to use ktime_get_ts64() to use monotonic times that don't have this problem. I

RE: [PATCH] renesas_usbhs: use renesas_usbhs_get_info()

2017-11-07 Thread Yoshihiro Shimoda
Hi Morimoto-san, > From: Kuninori Morimoto, Sent: Tuesday, November 7, 2017 5:26 PM > > From: Kuninori Morimoto > > We already have renesas_usbhs_get_info() macro. > Let's use it. > > Signed-off-by: Kuninori Morimoto > --- >

Re: [PATCH 6/6] USB: typec: Remove remaining redundant license text

2017-11-07 Thread Heikki Krogerus
On Mon, Nov 06, 2017 at 04:34:12PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to

Re: [PATCH 5/6] USB: typec: add SPDX identifiers to some files

2017-11-07 Thread Heikki Krogerus
On Mon, Nov 06, 2017 at 04:34:11PM +0100, Greg Kroah-Hartman wrote: > Due to these typec files being moved into the drivers/usb/ directory in > this tree, they missed the larger "add SPDX tags to all files" work. So > add the correct SPDX license tag, based on the license text in the file >

[PATCH] USB: remove redundant assignment to temp

2017-11-07 Thread Colin King
From: Colin Ian King The variable temp is being set at the end of each loop iteration but this value is never read, it is either being updated in just the case 1 block or at the end of the loop. Thus the assignment is redundant and can be removed. Cleans up clang

Re: [PATCH] usb: dwc2: host: fix isoc urb actual length

2017-11-07 Thread wlf
Hi Alan, 在 2017年11月07日 03:17, Alan Stern 写道: On Mon, 6 Nov 2017, wlf wrote: Hi Minas, 在 2017年11月06日 17:28, Minas Harutyunyan 写道: Hi, On 11/6/2017 12:46 PM, William Wu wrote: The actual_length in dwc2_hcd_urb structure is used to indicate the total data length transferred so far, but in

RE: [PATCH 4/6] USB: renesas_usbhs: rcar?.h: add SPDX tags

2017-11-07 Thread Yoshihiro Shimoda
Hi, > From: Greg Kroah-Hartman, Sent: Tuesday, November 7, 2017 12:34 AM > > These files somehow never got an SPDX tag added to them, maybe due to > the small size. So provide the default identifier of the whole project: > SPDX-License-Identifier: GPL-2.0 > > The SPDX identifier is a

RE: [PATCH 03/24] USB: renesas_usbhs: Remove redundant license text

2017-11-07 Thread Yoshihiro Shimoda
Hi, > From: Greg Kroah-Hartman, Sent: Monday, November 6, 2017 11:37 PM > > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a

Re: [PATCH] usb: core: lower log level when device is not able to deal with string

2017-11-07 Thread Greg KH
On Tue, Nov 07, 2017 at 03:58:29AM -0500, Kai-Heng Feng wrote: > USB devices should work just fine when they don't support language id. They still work, but it's a "broken" device, and it should be fixed (I thought it was part of the spec, but I can't find it right now...) > Lower the log level

[PATCH] usb: core: lower log level when device is not able to deal with string

2017-11-07 Thread Kai-Heng Feng
USB devices should work just fine when they don't support language id. Lower the log level so user won't panic in the future. BugLink: https://bugs.launchpad.net/bugs/1729618 Signed-off-by: Kai-Heng Feng --- drivers/usb/core/message.c | 2 +- 1 file changed, 1

[PATCH] renesas_usbhs: use renesas_usbhs_get_info()

2017-11-07 Thread Kuninori Morimoto
From: Kuninori Morimoto We already have renesas_usbhs_get_info() macro. Let's use it. Signed-off-by: Kuninori Morimoto --- Shimoda-san can you please check this patch ? drivers/usb/renesas_usbhs/common.c | 4 ++-- 1 file

Re: [PATCH v2 3/3] usb: dwc3: Enable USB 3.0 phy driver

2017-11-07 Thread Felipe Balbi
Hi, Ran Wang writes: > Adds entry point at dwc3 core init function to enable > USB 3.0 PHY driver. > > Signed-off-by: Ran Wang > --- > Change in v2: > - New file > > drivers/usb/dwc3/core.c | 15 +++ > 1 file changed, 15 insertions(+)

Suspend to disk with usb connected fails to detect usb(reset) during resume

2017-11-07 Thread Ivid Suvarna
Hi, I am trying to support suspend to disk(hibernate) on Hikey with 4.4 kernel. During suspend, I could see the usb devices getting reset and I can access them properly. Message can be seen as below: usb 1-1: reset high-speed USB device number 2 using dwc2 usb 1-1.2: reset high-speed USB device