Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Greg KH
On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > r8153 on Dell TB dock corrupts rx packets. > > The root cause is not found yet, but disabling rx checksumming can > workaround the issue. We can use this connection to decide if it's > a Dell TB dock: > Realtek r8153 <-> SMSC hub

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > > There is no need to #define the license of the

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the MODULE_LICENSE() line directly as

[PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Kai-Heng Feng
r8153 on Dell TB dock corrupts rx packets. The root cause is not found yet, but disabling rx checksumming can workaround the issue. We can use this connection to decide if it's a Dell TB dock: Realtek r8153 <-> SMSC hub <-> ASMedia XHCI controller BugLink: https://bugs.launchpad.net/bugs/1729674

Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file

2017-11-22 Thread Manu Gautam
Hi, On 11/22/2017 10:56 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> New revision (v3) of QMP PHY uses different offsets >> for almost all of the registers. Hence, move these >> definitions to header file so that updated offsets >> can be added for QMP v3. >> >>

Re: [PATCH v3 03/16] phy: qcom-qmp: Power-on PHY before initialization

2017-11-22 Thread Manu Gautam
Hi, On 11/22/2017 11:33 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> PHY must be powered on before turning ON clocks and >> attempting to initialize it. Driver is exposing >> separate init and power_on routines for this. >> Apparently USB dwc3 core driver performs

Re: [PATCH 11/11] usb/gadget: Make it again possible to enable the legacy drivers without enabling USB_ETH

2017-11-22 Thread Bart Van Assche
On Tue, 2017-10-31 at 11:03 -0700, Bart Van Assche wrote: > Considerable time ago the legacy gadget menu was added inside the > USB_ETH choice. I think this was a mistake and that the legacy > gadget menu should have been added after "endchoice" instead of > before. Hence this patch. > > Fixes:

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-22 Thread Adam Wallis
On 11/22/2017 10:24 AM, Mathias Nyman wrote: [..] > > We know have at least two hosts/platforms that need custom interrupt > moderation > values > > How about adding a u32 device property for xhci with the interrupt moderation > interval in > nanoseconds?  And also add a u32 imod_interval

[PATCH AUTOSEL for 4.14 19/51] usb: dwc2: Fix UDC state tracking

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c.usb/state file would

[PATCH AUTOSEL for 4.14 20/51] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The existing usb devices being utilized in host mode are disconnected. This is most visible with usb

[PATCH AUTOSEL for 4.4 07/16] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The existing usb devices being utilized in host mode are disconnected. This is most visible with usb

[PATCH AUTOSEL for 4.4 06/16] usb: dwc2: Fix UDC state tracking

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c.usb/state file would

[PATCH AUTOSEL for 4.9 12/24] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit 9b481092c2a31a6b630aff9c28f0145bf6683787 ] We've found that while in host mode, using Android, if one runs the command: stop adbd The existing usb devices being utilized in host mode are disconnected. This is most visible with usb

[PATCH AUTOSEL for 4.9 11/24] usb: dwc2: Fix UDC state tracking

2017-11-22 Thread alexander . levin
From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c.usb/state file would

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-22 Thread Adam Wallis
On 11/22/2017 10:24 AM, Mathias Nyman wrote: > On 22.11.2017 02:07, Adam Wallis wrote: >> On 11/21/2017 3:06 PM, Rob Herring wrote: >> >> [..] >> I like where you are going with this. Are you saying that I could read for a device property read from firmware (for DTB or ACPI) like

[PATCH] USB: usbip: fix spelling mistake: "synchronuously" -> "synchronously"

2017-11-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error message text Signed-off-by: Colin Ian King --- drivers/usb/usbip/vhci_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/vhci_rx.c

Re: [PATCH v3 03/16] phy: qcom-qmp: Power-on PHY before initialization

2017-11-22 Thread Stephen Boyd
On 11/21/2017 01:23 AM, Manu Gautam wrote: > PHY must be powered on before turning ON clocks and > attempting to initialize it. Driver is exposing > separate init and power_on routines for this. > Apparently USB dwc3 core driver performs power-on after > init. Also, poweron and init for QMP PHY

Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file

2017-11-22 Thread Stephen Boyd
On 11/21/2017 01:23 AM, Manu Gautam wrote: > New revision (v3) of QMP PHY uses different offsets > for almost all of the registers. Hence, move these > definitions to header file so that updated offsets > can be added for QMP v3. > > Signed-off-by: Manu Gautam > --- Why?

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Julia Lawall
On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Joe Perches
On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly,

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that

[PATCH] usb: bdc: fix platform_no_drv_owner.cocci warnings

2017-11-22 Thread Vasyl Gomonovych
Remove .owner field if calls are used which set it automatically drivers/usb/gadget/udc/bdc/bdc_core.c:645:3-8: No need to set .owner here. The core will do it. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Vasyl Gomonovych ---

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-22 Thread Mathias Nyman
On 22.11.2017 02:07, Adam Wallis wrote: On 11/21/2017 3:06 PM, Rob Herring wrote: [..] I like where you are going with this. Are you saying that I could read for a device property read from firmware (for DTB or ACPI) like DWC3 does for "snps,hird-threshold"? Is that for the same thing? If

[PATCH] USB: gadget: legacy: remove redundant zero assignment to variable 'value'

2017-11-22 Thread Colin King
From: Colin Ian King The variable value is being assigned to zero but that value is never being read. Either value is being reassigned in the following if condition, or it is never read and the function returns. In both cases the assignment is redundant and can be

RE: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

2017-11-22 Thread Chris Welch
> -Original Message- > From: Vignesh R [mailto:vigne...@ti.com] > Sent: Wednesday, November 22, 2017 5:41 AM > To: Chris Welch ; Quadros, Roger > > Cc: linux-usb@vger.kernel.org; linux-...@vger.kernel.org; Joao Pinto > ;

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
Hi Minas, > Stefan Wahren hat am 22. November 2017 um 12:21 > geschrieben: > > > Hi Minas, > > > Minas Harutyunyan hat am 21. November 2017 > > um 13:02 geschrieben: > > > > Hi Stefan, > > > > We have prepared patch for this issue in

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 21. November 2017 > um 13:02 geschrieben: > > Hi Stefan, > > We have prepared patch for this issue in July-August'17. > Find attached 2 patch files. Please apply patches and test. If issue > gone, we will send these patches

Re: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

2017-11-22 Thread Vignesh R
On Tuesday 21 November 2017 08:20 PM, Chris Welch wrote: > > >> -Original Message- >> From: Vignesh R [mailto:vigne...@ti.com] >> Sent: Tuesday, November 21, 2017 12:48 AM >> To: Roger Quadros >> Cc: Chris Welch ;

Re: [PATCH v7] xhci : AMD Promontory USB disable port support

2017-11-22 Thread Greg KH
On Wed, Nov 22, 2017 at 05:45:14PM +0800, Joe Lee wrote: > For AMD Promontory xHCI host, > although you can disable USB 2.0 ports in BIOSsettings, > those ports will be enabled anyway after you remove a device on > that port and re-plug it in again. It's a known limitation of the chip. > As a

[PATCH v7] xhci : AMD Promontory USB disable port support

2017-11-22 Thread Joe Lee
For AMD Promontory xHCI host, although you can disable USB 2.0 ports in BIOSsettings, those ports will be enabled anyway after you remove a device on that port and re-plug it in again. It's a known limitation of the chip. As a workaround we can clear the PORT_WAKE_BITS. Signed-off-by: Joe Lee

Re: xhci_hcd HC died; cleaning up with TUSB7340 and µPD720201

2017-11-22 Thread Vignesh R
On Tuesday 21 November 2017 08:20 PM, Chris Welch wrote: > > >> -Original Message- >> From: Vignesh R [mailto:vigne...@ti.com] >> Sent: Tuesday, November 21, 2017 12:48 AM >> To: Roger Quadros >> Cc: Chris Welch ;

Re: usbip port number limits

2017-11-22 Thread Juan Zea
Hi Yuyang, > > - Mensaje original - > De: "Yuyang Du" > Para: "Juan Zea" > CC: "Shuah Khan" , sh...@kernel.org, "Bjørn Mork" > , linux-usb@vger.kernel.org, "Valentina Manea" >

Re: usbip port number limits

2017-11-22 Thread Yuyang Du
On Tue, Nov 21, 2017 at 07:33:41AM -0700, Shuah Khan wrote: > I have been debugging on 4.12 and this bad commit. Low speed devices can be > attached, but you see the following and then shutdown hangs. Oh, just tested a high speed USB stick, I got the message. I'm working on it. -- To unsubscribe