Re: usbip port number limits

2017-11-23 Thread Yuyang Du
On Wed, Nov 22, 2017 at 09:38:27AM +0100, Juan Zea wrote: > I don't come up with any more detail... anything I'm missing? Hi Juan, Thank you so much for your patience. Really appreciate it. I came up with the following patch, with which at my side the BUG doesn't happen again with both a (low

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Kai Heng Feng
> On 23 Nov 2017, at 5:24 PM, Greg KH wrote: > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: >> >> What I want to do here is to finding this connection: >> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537) <-> >> ASMedia XHCI controller (PCI ID:

Re: [PATCH v7] xhci : AMD Promontory USB disable port support

2017-11-23 Thread kbuild test robot
Hi Joe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.14] [also build test WARNING on next-20171122] [cannot apply to usb/usb-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-23 Thread Joe Perches
On Thu, 2017-11-23 at 15:30 -0800, Joe Perches wrote: > --- /dev/null 2017-11-23 06:19:12.943046739 -0800 > +++ single_use_module.pl 2017-11-23 15:23:11.729812156 -0800 > @@ -0,0 +1,15 @@ [] > +$data =~ s~$var~$string~; this needs to be: $data =~ s~\b$var\b~$string~; -- To unsubscribe from

Re: [PATCH v2] typec: fusb302: Use dev_err during probe

2017-11-23 Thread Guenter Roeck
On 11/23/2017 03:03 PM, Mats Karrman wrote: If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman Reviewed-by: Guenter Roeck

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-23 Thread Joe Perches
On Wed, 2017-11-22 at 18:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the MODULE_LICENSE() line

[PATCH v2] typec: fusb302: Use dev_err during probe

2017-11-23 Thread Mats Karrman
If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman --- Changes since v1: - Driver is no longer in stageing. - Removed accidental change of gpio

Re: [PATCH] typec: fusb302: Use dev_err during probe

2017-11-23 Thread Mats Karrman
On 2017-11-23 23:12, Guenter Roeck wrote: On 11/23/2017 01:41 PM, Mats Karrman wrote: If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman ---  

Re: [PATCH] typec: fusb302: Use dev_err during probe

2017-11-23 Thread Guenter Roeck
On 11/23/2017 01:41 PM, Mats Karrman wrote: If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman --- drivers/staging/typec/fusb302/fusb302.c | 21

[PATCH] typec: fusb302: Use dev_err during probe

2017-11-23 Thread Mats Karrman
If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman --- drivers/staging/typec/fusb302/fusb302.c | 21 +++-- 1 file changed, 11

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-23 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 23. November 2017 > um 11:00 geschrieben: > > > Hi Stefan, > > ... > > In addition to above patches please apply this one: > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index

Re: [PATCHv2] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Alan Stern
On Thu, 23 Nov 2017, Oliver Neukum wrote: > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > Improve sanity checking. > > Reported-by: andreyk...@google.com This should be Reported-by: Andrey Konovalov > Signed-off-by: Oliver Neukum >

usbutils 009 release

2017-11-23 Thread Greg KH
The 009 release of usbutils happened about a month ago, but I forgot to announce it anywhere, and also forgot to upload the tarball to kernel.org until today. So here's the belated announcement of the 009 release of usbutils. It's been a few years since the last release, sorry about that, didn't

[PATCHv2] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Oliver Neukum
USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. Improve sanity checking. Reported-by: andreyk...@google.com Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/usb/core/devio.c | 16 ++-- 1 file changed, 10 insertions(+), 6

[PATCH] [stable only]USB: fix buffer overflows with parsing CDC headers

2017-11-23 Thread Oliver Neukum
Parsing CDC headers a buffer overflow cannot just be prevented by checking that the remainder of the buffer is longer than minimum length. The size of the fields to be parsed must be figured in, too. In newer kernels this issue has been fixed at a central location with commit

Re: [PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 04:06:28PM +0100, Oliver Neukum wrote: > Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH: > > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > > > > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > > Improve sanity checking.

Re: [PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Oliver Neukum
Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH: > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > Improve sanity checking. > > > > Signed-off-by: Oliver Neukum > > --- > >

Re: [PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > Improve sanity checking. > > Signed-off-by: Oliver Neukum > --- > drivers/usb/core/devio.c | 16 ++-- > 1 file changed, 10

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-23 Thread Adam Wallis
On 11/23/2017 5:59 AM, Mathias Nyman wrote: > On 23.11.2017 01:32, Adam Wallis wrote: >> On 11/22/2017 10:24 AM, Mathias Nyman wrote: >> [..] >>> >>> We know have at least two hosts/platforms that need custom interrupt >>> moderation >>> values >>> >>> How about adding a u32 device property for

[PATCH] USB: usbfs: Filter flags passed in from user space

2017-11-23 Thread Oliver Neukum
USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. Improve sanity checking. Signed-off-by: Oliver Neukum --- drivers/usb/core/devio.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/devio.c

RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-23 Thread Adam Thomson
On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and always selects the pdo with highest > possible power within the board limit. This assumption > might not hold good for all devices. To overcome this, > this

Re: [PATCH 1/2] usb: xhci: add relaxed timing quirk bit

2017-11-23 Thread Mathias Nyman
On 23.11.2017 01:32, Adam Wallis wrote: On 11/22/2017 10:24 AM, Mathias Nyman wrote: [..] We know have at least two hosts/platforms that need custom interrupt moderation values How about adding a u32 device property for xhci with the interrupt moderation interval in nanoseconds?  And also add

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-23 Thread Minas Harutyunyan
Hi Stefan, On 11/22/2017 6:15 PM, Stefan Wahren wrote: > Hi Minas, > >> Stefan Wahren hat am 22. November 2017 um 12:21 >> geschrieben: >> >> >> Hi Minas, >> >>> Minas Harutyunyan hat am 21. November 2017 >>> um 13:02 geschrieben: >>>

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > > > On 23 Nov 2017, at 3:58 PM, Greg KH wrote: > > > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > >> r8153 on Dell TB dock corrupts rx packets. > >> > >> The root cause is not

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-23 Thread Kai Heng Feng
> On 23 Nov 2017, at 3:58 PM, Greg KH wrote: > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: >> r8153 on Dell TB dock corrupts rx packets. >> >> The root cause is not found yet, but disabling rx checksumming can >> workaround the issue. We can use

Re: [PATCH 11/11] usb/gadget: Make it again possible to enable the legacy drivers without enabling USB_ETH

2017-11-23 Thread Felipe Balbi
Hi, Bart Van Assche writes: > On Tue, 2017-10-31 at 11:03 -0700, Bart Van Assche wrote: >> Considerable time ago the legacy gadget menu was added inside the >> USB_ETH choice. I think this was a mistake and that the legacy >> gadget menu should have been added after