Re: very slow USB security token access after switch from 2.6.13 to 4.4.52

2017-11-28 Thread Nikola Ciprich
Hi Greg, thanks a lot for your reply! I've found the difference just yesterday, it's not kernel problem after all, the reason it was much faster under suse is that there was public key caching mechanism which I wasn't aware of.. (I had the same opensc config, but cache needed to be created

Re: drivers/net/usb/r8152.c USB net driver outdated

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 07:51:06PM -0700, Cameron Seader wrote: > Greetings, > The upstream kernel seems to be outdated with version 1.09.9 of the > drivers/net/usb/r8152.c driver. There is newer hardware now which requires > the newer version where running with the old one becomes unstable. For >

drivers/net/usb/r8152.c USB net driver outdated

2017-11-28 Thread Cameron Seader
Greetings, The upstream kernel seems to be outdated with version 1.09.9 of the drivers/net/usb/r8152.c driver. There is newer hardware now which requires the newer version where running with the old one becomes unstable. For example the latest Dell Precision 5520 uses this driver. I have

Re: usbip port number limits

2017-11-28 Thread Shuah Khan
On 11/28/2017 11:32 AM, Shuah Khan wrote: > On 11/26/2017 06:33 PM, Yuyang Du wrote: >> Hi Juan, >> >> On Fri, Nov 24, 2017 at 12:42:22PM +0100, Juan Zea wrote: >>>The patch doesn't apply cleanly with the patch command, but given it is >>> that simple I've changed it myself (I'm telling you

Re: [PATCH 1/1] usb: serial: usb_debug: Add new USB device id

2017-11-28 Thread Lu Baolu
Hi Johan, On 11/28/2017 05:01 PM, Johan Hovold wrote: > On Tue, Nov 28, 2017 at 12:40:59PM +0800, Lu Baolu wrote: >> USB vendor id and product id for Linux USB Debug Target is added. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/usb/serial/usb_debug.c | 2 ++ >> 1

Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

2017-11-28 Thread Lu Baolu
Hi Felipe, On 11/28/2017 04:05 PM, Felipe Balbi wrote: > Hi, > > Lu Baolu writes: >> The kernel FIFO implementation, kfifo, provides interfaces to manipulate >> a first-in-first-out circular buffer. Use kfifo instead of the homemade >> one to make the code more concise

[PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device.

2017-11-28 Thread Mikhail Zaytsev
This patch adds the device_reinit function into the us_data structure. The usb-storage driver uses this function for notify the subdrivers that they need to reinitialize the device. Signed-off-by: Mikhail Zaytsev --- drivers/usb/storage/usb.c | 16

Re: [PATCH v1] usb: xhci: allow imod-interval to be configurable

2017-11-28 Thread Adam Wallis
On 11/28/2017 2:35 PM, Greg Kroah-Hartman wrote: > On Tue, Nov 28, 2017 at 12:11:46PM -0500, Adam Wallis wrote: >> The xHCI driver currently has the IMOD set to 160, which >> translates to an IMOD interval of 40,000ns (160 * 250)ns >> [..] >> --- a/drivers/usb/host/xhci-plat.c >> +++

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 02:59:32PM -0500, Alan Stern wrote: > On Tue, 28 Nov 2017, Ladislav Michl wrote: > > > On Tue, Nov 28, 2017 at 01:09:45PM -0500, Alan Stern wrote: > > > The EHCI debugging files require CONFIG_DYNAMIC_DEBUG to be enabled. > > > Oddly enough, the OHCI debugging files do

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Alan Stern
On Tue, 28 Nov 2017, Ladislav Michl wrote: > On Tue, Nov 28, 2017 at 01:09:45PM -0500, Alan Stern wrote: > > The EHCI debugging files require CONFIG_DYNAMIC_DEBUG to be enabled. > > Oddly enough, the OHCI debugging files do not have the same > > requirement. I don't know the reason for this

Re: very slow USB security token access after switch from 2.6.13 to 4.4.52

2017-11-28 Thread Greg KH
On Sun, Nov 26, 2017 at 07:05:12PM +0100, Nikola Ciprich wrote: > Hello dear linux USB users and developers, > > I've got a bit desperate question, but maybe somebody will have > some idea on what to try.. > > we're migrating lots (thousands) of users from very old opensuse running > 2.6.13

Re: [PATCH v1] usb: xhci: allow imod-interval to be configurable

2017-11-28 Thread Greg Kroah-Hartman
On Tue, Nov 28, 2017 at 12:11:46PM -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 01:09:45PM -0500, Alan Stern wrote: > The EHCI debugging files require CONFIG_DYNAMIC_DEBUG to be enabled. > Oddly enough, the OHCI debugging files do not have the same > requirement. I don't know the reason for this difference. I see, thanks for suggestion. USB cable

Re: usbip port number limits

2017-11-28 Thread Shuah Khan
On 11/26/2017 06:33 PM, Yuyang Du wrote: > Hi Juan, > > On Fri, Nov 24, 2017 at 12:42:22PM +0100, Juan Zea wrote: >>The patch doesn't apply cleanly with the patch command, but given it is >> that simple I've changed it myself (I'm telling you just in case we're >> missing something). >> >>

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Alan Stern
On Tue, 28 Nov 2017, Ladislav Michl wrote: > On Tue, Nov 28, 2017 at 10:00:32AM -0500, Alan Stern wrote: > > On Tue, 28 Nov 2017, Greg KH wrote: > > > > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > > Hi there, > > > > > > > > USB hosts do not discover any connected

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 06:39:13AM -0800, Tony Lindgren wrote: > * Ladislav Michl [171128 14:31]: > > On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > > > * Ladislav Michl [171128 09:42]: > > > > On Tue, Nov 28, 2017 at 10:30:54AM

Re: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Ulf Hansson
On 28 November 2017 at 13:48, Yoshihiro Shimoda wrote: > Hi Geert-san, > >> From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM >> >> Hi Rafael, Shimoda-san, >> >> On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki >> wrote:

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl [171128 17:01]: > On Tue, Nov 28, 2017 at 06:39:13AM -0800, Tony Lindgren wrote: > > Limiting things to C1 with cpuidle is probably what you need > > for having USB also working. > > With echo 1 > /sys/devices/system/cpu/cpu0/cpuidle/state{1-6}/disable >

[PATCH v1] usb: xhci: allow imod-interval to be configurable

2017-11-28 Thread Adam Wallis
The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") introduced a QUIRK for the MTK platform to adjust this interval to 20, which translates to an IMOD interval of

4.14 dwc3 gadget mode WARNING on unplug

2017-11-28 Thread Vincent Pelletier
Hello, Now that "unplugging" the userland process does not kill the kernel, I tried unplugging the cable in the same starting conditions (two submitted AIO read transfers, host having enabled the device, but no data transfer actually happening). And I got below WARNING. Sadly, the error goes

hid report: padding differs from report descriptor?

2017-11-28 Thread Florian Dollinger
I have a device that has the following hid report descriptor: - ... Collection (Logical) A1 02 Usage Page (Physical Input Device) 05 Usage (DC Enable Actuators) 09 97 Logical Minimum (0) 15 00 Logical Maximum (1) 25 01 Report Size (4) 75 04 Report Count (1) 95 01 Output

usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2017-11-28 Thread Vincent Pelletier
!! This is an RFC patch - hence sign-off absence !! This bug happens only when the UDC needs to sleep during usb_ep_dequeue, as is the case for (at least) dwc3. RFC: - I do not understand what eps_lock is supposed to protect in original ffs_aio_cancel implementation, especially once one

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-11-28 Thread Doug Anderson
Hi, On Tue, Nov 28, 2017 at 6:37 AM, Stefan Wahren wrote: > Hi Doug, > > Doug Anderson hat am 30. Oktober 2017 um 18:14 > geschrieben: > > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: >> > > Hi, > > Doug Anderson

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 10:00:32AM -0500, Alan Stern wrote: > On Tue, 28 Nov 2017, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > Hi there, > > > > > > USB hosts do not discover any connected device on OMAP3 based board > > > with CONFIG_PM=n. Just

usb: gadget: ffs: Make sparse happier

2017-11-28 Thread Vincent Pelletier
Silences the following warnings: drivers/usb/gadget/function/f_fs.c:1253:37: warning: incorrect type in argument 1 (different address spaces) drivers/usb/gadget/function/f_fs.c:1253:37:expected void [noderef] *to drivers/usb/gadget/function/f_fs.c:1253:37:got void *

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Alan Stern
On Tue, 28 Nov 2017, Yoshihiro Shimoda wrote: > Hi Geert-san, > > > From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM > > > > Hi Rafael, Shimoda-san, > > > > On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki > > wrote: > > > From: Rafael J. Wysocki

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Alan Stern
On Tue, 28 Nov 2017, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > Hi there, > > > > USB hosts do not discover any connected device on OMAP3 based board > > with CONFIG_PM=n. Just enabling this option is enough to restore working > > behaviour. Nothing

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl [171128 14:31]: > On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > > * Ladislav Michl [171128 09:42]: > > > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > > > bit-banging an ir decoder, ugh, you are in for

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > * Ladislav Michl [171128 09:42]: > > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > > bit-banging an ir decoder, ugh, you are in for a world of hurt. Can't > > > you put a chip on the device that

Re: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Rafael J. Wysocki
On Tue, Nov 28, 2017 at 11:58 AM, Geert Uytterhoeven wrote: > Hi Rafael, Shimoda-san, > > On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> The check for "active" children in

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl [171128 09:42]: > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > bit-banging an ir decoder, ugh, you are in for a world of hurt. Can't > > you put a chip on the device that does this for you in hardware? > > OMAP has DM timer which can be

Re: [PATCH] USB: atm: use setup_timer instead of init_timer

2017-11-28 Thread Greg Kroah-Hartman
On Fri, Nov 24, 2017 at 01:31:54PM +, Colin King wrote: > From: Colin Ian King > > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH] usb: core: add support for USB_REQ_SET_ISOCH_DELAY

2017-11-28 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> Felipe Balbi writes: >> > Greg Kroah-Hartman writes: >> >> On Thu, Nov 09, 2017 at 03:41:54PM +0200, Felipe Balbi wrote: >> >>> USB SS and SSP hubs provide wHubDelay values

Re: [PATCH] usb: core: add support for USB_REQ_SET_ISOCH_DELAY

2017-11-28 Thread Greg Kroah-Hartman
On Tue, Nov 14, 2017 at 12:24:04PM +0200, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: > > Greg Kroah-Hartman writes: > >> On Thu, Nov 09, 2017 at 03:41:54PM +0200, Felipe Balbi wrote: > >>> USB SS and SSP hubs provide wHubDelay

Re: [PATCHv2] USB: usbfs: Filter flags passed in from user space

2017-11-28 Thread Greg KH
On Thu, Nov 23, 2017 at 10:53:13AM -0500, Alan Stern wrote: > On Thu, 23 Nov 2017, Oliver Neukum wrote: > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > Improve sanity checking. > > > > Reported-by: andreyk...@google.com > > This should be > > Reported-by: Andrey

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-11-28 Thread Mathias Nyman
On 28.11.2017 13:16, Yaroslav Isakov wrote: Mathias, Hello again! Any news on progress of upstreaming this patch? Applied to my for-usb-linus branch on top of 4.15-rc1 I pushed it to internal testing and I'll let it be there a couple of days before sending it forward to Greg -Mathias --

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM > > Hi Rafael, Shimoda-san, > > On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The check for "active" children in

RE: dwc2/dwc_otg drivers

2017-11-28 Thread Felipe Balbi
Hi, "Araujo, Billy" writes: > Hi Felipe, > > I think the issue is very similar to the one indicated by Johan Hovold: > > https://lkml.kernel.org/r/20171030170802.14489-1-diand...@chromium.org > > Eventually we would like to test this patch on our system and check if

RE: dwc2/dwc_otg drivers

2017-11-28 Thread Araujo, Billy
Hi Felipe, I think the issue is very similar to the one indicated by Johan Hovold: https://lkml.kernel.org/r/20171030170802.14489-1-diand...@chromium.org Eventually we would like to test this patch on our system and check if it works for us. Regards, Billy. -Original Message-

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-28 Thread Heikki Krogerus
On Mon, Nov 27, 2017 at 04:54:08PM +, Adam Thomson wrote: > On 27 November 2017 14:12, Heikki Krogerus wrote: > > > Hi Adam, > > > > On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote: > > > On 24 November 2017 12:19, Heikki Krogerus wrote: > > > > Is it OK to everybody that the

RE: dwc2/dwc_otg drivers

2017-11-28 Thread Felipe Balbi
Hi, (no top-posting) "Araujo, Billy" writes: > Hi Felipe, > > I think the issue is very similar to the one indicated by Johan Hovold: > > https://lkml.kernel.org/r/20171030170802.14489-1-diand...@chromium.org > > Eventually we would like to test this patch on our

Re: xhci_hcd 0000:00:14.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?

2017-11-28 Thread Yaroslav Isakov
Mathias, Hello again! Any news on progress of upstreaming this patch? 2017-10-18 1:21 GMT+03:00 Yaroslav Isakov : > Applied it to 4.13.7, and it helps! Thanks a lot! > > 2017-10-16 14:33 GMT+03:00 Mathias Nyman : >> On 13.10.2017 14:46,

Re: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Geert Uytterhoeven
Hi Rafael, Shimoda-san, On Sun, Nov 12, 2017 at 1:27 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The check for "active" children in __pm_runtime_set_status(), when > trying to set the parent device status to "suspended", doesn't >

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 11:03:50AM +0200, Felipe Balbi wrote: > Ladislav Michl writes: > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > >> On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > >> > Hi there, > >> > > >> > USB hosts do not discover

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-28 Thread Kai Heng Feng
> On 27 Nov 2017, at 11:13 PM, > wrote: > > This is quite surprising to me too. The externally plugged in r8153 dongle, > was it connected over type C port or over type A port? AFAIK Type C port is > actually Alpine ridge pass through

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 09:57:51AM +0100, Ladislav Michl wrote: > > Hi Greg, > > > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > > Hi there, > > > >

RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-28 Thread Adam Thomson
On 28 November 2017 02:07, Guenter Roeck wrote: > On 11/27/2017 05:38 PM, Badhri Jagan Sridharan wrote: > > On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson > > wrote: > >> On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > >> > >>> At present, TCPM code

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 09:57:51AM +0100, Ladislav Michl wrote: > Hi Greg, > > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > > Hi there, > > > > > > USB hosts do not discover any connected device on OMAP3 based

RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-28 Thread Adam Thomson
On 28 November 2017 01:38, Badhri Jagan Sridharan wrote: > > examples in the kernel where this happens. Where are these functions likely > > to > > be called from, as wherever that is it will need a reference to the port? > > Actually should we be adding DT bindings to set supported src/snk PDOs

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Felipe Balbi
Hi, Ladislav Michl writes: > On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: >> On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: >> > Hi there, >> > >> > USB hosts do not discover any connected device on OMAP3 based board >> > with CONFIG_PM=n.

Re: [PATCH 1/1] usb: serial: usb_debug: Add new USB device id

2017-11-28 Thread Johan Hovold
On Tue, Nov 28, 2017 at 12:40:59PM +0800, Lu Baolu wrote: > USB vendor id and product id for Linux USB Debug Target is added. > > Signed-off-by: Lu Baolu > --- > drivers/usb/serial/usb_debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Ladislav Michl
Hi Greg, On Tue, Nov 28, 2017 at 08:33:28AM +0100, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:08:33PM +0100, Ladislav Michl wrote: > > Hi there, > > > > USB hosts do not discover any connected device on OMAP3 based board > > with CONFIG_PM=n. Just enabling this option is enough to restore

Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg

2017-11-28 Thread Johan Hovold
On Mon, Nov 27, 2017 at 03:36:51PM +, Gimcuan Hui wrote: > write_reg returns 0 on success, we can make it more explicit by returning > number 0 instead of result variable. > > read_reg should return 0 on success since this is a more common pattern. > > The user of read_reg has been clean-up

Re: Fwd: Performance regression in dwc3 ecm for linux 4.4.60

2017-11-28 Thread Felipe Balbi
Hi, Arjav Parikh writes: > Hi, > > Thank You for your response. > > I will update you after trying main line kernel. read this: https://www.kernel.org/doc/html/v4.14/process/2.Process.html?highlight=process#mailing-lists In short: don't top-post ;-) -- balbi

Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

2017-11-28 Thread Felipe Balbi
Hi, Lu Baolu writes: > The kernel FIFO implementation, kfifo, provides interfaces to manipulate > a first-in-first-out circular buffer. Use kfifo instead of the homemade > one to make the code more concise and readable. > > Signed-off-by: Lu Baolu

Re: Fwd: Performance regression in dwc3 ecm for linux 4.4.60

2017-11-28 Thread Felipe Balbi
Hi, Arjav Parikh writes: > Hi Team, > > Hope you all are doing good. > > Currently I am facing an bandwidth issue in dwc3 driver using ecm > gadget with linux kernel version 4.4. did you try mainline? Try mainline and let me know how it goes. -- balbi signature.asc