Re: usb device implemented with functionfs - must app run as root?

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 07:26:13PM +0100, Krzysztof Opasiak wrote: > > > On 12/06/2017 07:26 AM, Greg KH wrote: > > On Tue, Dec 05, 2017 at 10:09:35PM +, andy_purc...@keysight.com wrote: > > > I have implemented a USB device using functionfs. > > > A colleague now says our app must run as a

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Geert Uytterhoeven
Hi Alan, On Wed, Dec 6, 2017 at 11:02 PM, Alan Stern wrote: > On Wed, 6 Dec 2017, SF Markus Elfring wrote: >> >>> Does the existing memory allocation error message include the >> >>> >dev device name and driver name? If it doesn't, there will be >> >>> no way for the

Re: [PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-12-06 Thread Anna-Maria Gleixner
On Mon, 4 Dec 2017, Felipe Balbi wrote: > Anna-Maria Gleixner writes: > > > From: Thomas Gleixner > > > > The tx_tasklet tasklet is used in invoke the hrtimer (task_timer) in > > softirq context. This can be also achieved without the tasklet but >

Re: [PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 10:10 PM, Greg KH wrote: > > On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote: >> Trying quirks in usbcore needs to rebuild the driver or the entire >> kernel if it's builtin. It can save a lot of time if usbcore has similar >>

Re: [PATCH] usb: xhci: fix TDS for MTK xHCI1.1

2017-12-06 Thread Mathias Nyman
On 06.12.2017 08:42, Chunfeng Yun wrote: For MTK's xHCI 1.0 or latter, TD size is the number of max packet sized packets remaining in the TD, not including this TRB (following spec). For MTK's xHCI 0.96 and older, TD size is the number of max packet sized packets remaining in the TD, including

[PATCH] usb: phy: Factor out the usb charger initialization

2017-12-06 Thread Baolin Wang
Factor out the guts of usb charger initialization into usb_charger_init() function, to make the usb_add_extcon() only do the extcon related things. Meanwhile we also should initialize the USB charger before registering the extcon device, in case the extcon notification was issued earlier than usb

[PATCH] usb: dwc3: of-simple: set dev_pm_ops

2017-12-06 Thread Masahiro Yamada
dwc3_of_simple_dev_pm_ops has never been used since the initial support by commit 16adc674d0d6 ("usb: dwc3: add generic OF glue layer"). I guess it just missed to set .pm struct member. Signed-off-by: Masahiro Yamada --- drivers/usb/dwc3/dwc3-of-simple.c | 1 +

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Dave Chinner
On Wed, Dec 06, 2017 at 06:06:48AM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 07:44:04PM +1100, Dave Chinner wrote: > > On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > > > That said, using xa_cmpxchg() in the dquot code looked like the right > > > thing to do? Since

Re: [PATCH v4 00/73] XArray version 4

2017-12-06 Thread Matthew Wilcox
On Wed, Dec 06, 2017 at 04:58:29PM -0700, Ross Zwisler wrote: > Maybe I missed this from a previous version, but can you explain the > motivation for replacing the radix tree with an xarray? (I think this should > probably still be part of the cover letter?) Do we have a performance problem > we

Re: [PATCH v4 00/73] XArray version 4

2017-12-06 Thread Ross Zwisler
On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I looked through some notes and decided this was version 4 of the XArray. > Last posted two weeks ago, this version includes a *lot* of changes. > I'd like to thank Dave Chinner for

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Alan Stern
On Wed, 6 Dec 2017, SF Markus Elfring wrote: > >>> Does the existing memory allocation error message include the > >>> >dev device name and driver name? If it doesn't, there will be > >>> no way for the user to tell that the error message is related to the > >>> device failure. > >> > >> No,

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread SF Markus Elfring
>>> Does the existing memory allocation error message include the >>> >dev device name and driver name? If it doesn't, there will be >>> no way for the user to tell that the error message is related to the >>> device failure. >> >> No, but the effect is similar. >> >> OOM does a dump_stack()

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-06 Thread Rob Herring
On Mon, Dec 04, 2017 at 09:27:51AM -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Alan Stern
On Wed, 6 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote: > > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > > > Omit an extra message for a memory allocation failure in this function. > > Markus' typical terrible commit message. > > > > diff --git

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-06 Thread David Miller
From: Bjørn Mork Date: Wed, 6 Dec 2017 20:21:24 +0100 > The qmi_wwan minidriver support a 'raw-ip' mode where frames are > received without any ethernet header. This causes alignment issues > because the skbs allocated by usbnet are "IP aligned". > > Fix by allowing minidrivers

RE: usb device implemented with functionfs - must app run as root?

2017-12-06 Thread andy_purcell
Hello, Suggestion from GKH is to write a udev rule to change ownership, group, permissions of the functionfs created endpoint files: /dev/usbffs/ep1 /dev/usbffs/ep2 /dev/usbffs/ep3 I tried all morning to create a udev rule, but no success. My attempts are documented below. I don't

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Geert Uytterhoeven
Hi Markus, On Wed, Dec 6, 2017 at 6:51 PM, SF Markus Elfring wrote: >> The system will come to a grinding halt anyway if it can't allocate 24 or 40 >> bytes. > > Maybe. Since you've been sending zillions of patches for this, perhaps the time is ripe to actually

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Joe Perches
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote: > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. Markus' typical terrible commit message. > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c [] > > @@

[PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-06 Thread Bjørn Mork
The qmi_wwan minidriver support a 'raw-ip' mode where frames are received without any ethernet header. This causes alignment issues because the skbs allocated by usbnet are "IP aligned". Fix by allowing minidrivers to disable the additional alignment offset. This is implemented using a per-device

Re: usb device implemented with functionfs - must app run as root?

2017-12-06 Thread Krzysztof Opasiak
On 12/06/2017 07:26 AM, Greg KH wrote: On Tue, Dec 05, 2017 at 10:09:35PM +, andy_purc...@keysight.com wrote: I have implemented a USB device using functionfs. A colleague now says our app must run as a normal user, not as root. I tried it and it does not work. The problem is this - the

Re: [PATCH] tools/usbip: fixes build with musl libc toolchain

2017-12-06 Thread Shuah Khan
On 12/05/2017 10:48 AM, julien.boibes...@free.fr wrote: > From: Julien BOIBESSOT > > Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD. > SIGCHLD is the new POSIX name for that signal so it doesn't change > anything on other libcs. > >

Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread SF Markus Elfring
> The system will come to a grinding halt anyway if it can't allocate 24 or 40 > bytes. Maybe. > Which is BTW more or less the amount of memory saved by killing > the useless (error) message. Would you dare to resend this update suggestion after such a view? Regards, Markus -- To unsubscribe

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Geert Uytterhoeven
Hi Alan, On Wed, Dec 6, 2017 at 5:45 PM, Alan Stern wrote: > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Wed, 6 Dec 2017 17:00:18 +0100 >> >> Omit an extra message for a memory allocation failure in

Re: [PATCH v1 5/8] lsusb: Add descriptor definitions for UAC3.

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 04:52:37PM +, Michael Drake wrote: > > > On 05/12/17 16:39, Greg KH wrote: > > On Tue, Dec 05, 2017 at 04:14:28PM +, Michael Drake wrote: > > > --- > > > desc-defs.c | 277 > > > > > > desc-defs.h |

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Greg Kroah-Hartman
On Wed, Dec 06, 2017 at 11:45:31AM -0500, Alan Stern wrote: > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Wed, 6 Dec 2017 17:00:18 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > > >

Re: [PATCH v1 0/8] lsusb: Add initial support for USB Audio Class 3

2017-12-06 Thread Michael Drake
On 05/12/17 16:32, Greg KH wrote: On Tue, Dec 05, 2017 at 04:14:23PM +, Michael Drake wrote: This adds a new way of dumping descriptors, which splits the knowledge of how to interpret descriptor data from the actual dumping. This has two advantages: 1. It is easy to add support for new

Re: [PATCH v1 5/8] lsusb: Add descriptor definitions for UAC3.

2017-12-06 Thread Michael Drake
On 05/12/17 16:39, Greg KH wrote: On Tue, Dec 05, 2017 at 04:14:28PM +, Michael Drake wrote: --- desc-defs.c | 277 desc-defs.h | 3 + desc-dump.c | 5 ++ 3 files changed, 270 insertions(+), 15 deletions(-) We need

Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread Alan Stern
On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 17:00:18 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > >

Re: [PATCH v1 3/8] lsusb: Add code to dump descriptor data using descriptor definition.

2017-12-06 Thread Michael Drake
On 05/12/17 16:38, Greg KH wrote: On Tue, Dec 05, 2017 at 04:14:26PM +, Michael Drake wrote: This adds a new way of dumping descriptors. It takes the descriptor data to be dumped, and a descriptor definition as input. The descriptor definition takes the form of a NULL terminated array

Re: [PATCH v1 2/8] lsusb: Add declarative definitions for UAC1 and UAC2 descriptors.

2017-12-06 Thread Michael Drake
On 05/12/17 16:37, Greg KH wrote: On Tue, Dec 05, 2017 at 04:14:25PM +, Michael Drake wrote: These descriptor definitions descibe how raw descriptor data should be interpreted. --- desc-defs.c | 647 desc-defs.h | 153

Re: [PATCH v1 1/8] lsusb: Split subtype mapping out of AudioControl interface handling.

2017-12-06 Thread Michael Drake
On 05/12/17 16:31, Greg KH wrote: On Tue, Dec 05, 2017 at 04:14:24PM +, Michael Drake wrote: UAC1 and UAC2 have different different meanings for the same subtype value. This splits the subtype mapping out. --- Minor nit, can you sign-off on your patches like kernel patches have? That way

[PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()

2017-12-06 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 6 Dec 2017 17:00:18 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] USB: uas and storage: Add US_FL_BROKEN_FUA for another JMicron JMS567 ID

2017-12-06 Thread Alan Stern
On Tue, 5 Dec 2017, David Kozub wrote: > There is another JMS567-based USB3 UAS enclosure (152d:0578) that fails > with the following error: > > [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [sda] tag#0 Sense Key : Illegal Request [current] > [sda] tag#0 Add. Sense:

[PATCH] usb: dwc2: Make function static

2017-12-06 Thread Grigor Tovmasyan
Declared dwc2_force_mode() function as static, because it was used only in core.c file, for fixing sparse error. Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/core.c

[PATCH] usb: dwc2: Delete unused functionality

2017-12-06 Thread Grigor Tovmasyan
Deleted dwc2_hcd_dump_frrem() function, because it used undefined parameters from dwc2_hsotg structure. The function body was in #ifdef statement and was never compiled. Also removed that parameters from dwc2_hsotg structure, which were used only in dwc2_hcd_dump_frrem() function. And also

[PATCH] USB: dwc2: Delete an error message for a failed memory allocation in dwc2_hsotg_handle_unaligned_buf_start()

2017-12-06 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 6 Dec 2017 16:16:00 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] usb: dwc2: hcd: Fix host channel halt flow

2017-12-06 Thread Minas Harutyunyan
According databook in Buffer and External DMA mode non-split periodic channels can't be halted. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/hcd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c

[PATCH v2] usb: dwc2: Add safety check in setting of descriptor chain pointers

2017-12-06 Thread Minas Harutyunyan
In some cases device sending ZLP IN on non EP0 which reassigning EP0 OUT descriptor pointer to that EP. Dedicated for EP0 OUT descriptor multiple time re-used by other EP while that descriptor already in use by EP0 OUT for SETUP transaction. As result when SETUP packet received BNA interrupt

[PATCH] usb: dwc2: Add safety check for STSPHSERCVD intr

2017-12-06 Thread Minas Harutyunyan
STSPHSERCVD (status phase received) interrupt should be handled when EP0 is in DWC2_EP0_DATA_OUT state. Sometimes STSPHSERCVD interrupt asserted , when EP0 is not in DATA_OUT state. Spurios interrupt. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 10

[PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-06 Thread Minas Harutyunyan
Before flushing fifos required to check AHB master state and flush when AHB master is in IDLE state. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/core.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/usb/dwc2/core.c

[PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-12-06 Thread Minas Harutyunyan
Added missing GUSBCFG programming in host mode. These fields even if was programmed in device mode (in function dwc2_hsotg_core_init_disconnected()) will be resetting to POR values after core soft reset applied. So, each time when switching to host mode required to set these fields to correct

[PATCH] Revert "usb: dwc2: gadget: use ep->fifo_index in context of FIFO registers"

2017-12-06 Thread Minas Harutyunyan
This reverts commit ad674a15249e7d800162858e49272877a782ec40 "usb: dwc2: gadget: use ep->fifo_index in context of FIFO registers". DTXFSTSn indexation based on EP number not TxFIFO number. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 5 ++--- 1 file

Re: [PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

2017-12-06 Thread Kai-Heng Feng
On Wed, Dec 6, 2017 at 1:14 AM, Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Wed, Dec 06, 2017 at 12:22:42AM +0800, Kai-Heng Feng wrote: >> The board in question has three XHCI HCs: >> 02:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] USB 3.1 >> XHCI

[PATCH] usb: dwc2: Remove version check in GSNPSID

2017-12-06 Thread Gevorg Sahakyan
Only check the ID portion of the GSNPSID register and don’t check the version. This will allow the driver to work with version 4.00a and later of the DWC_hsotg IP. Cc: sta...@vger.kernel.org Signed-off-by: Gevorg Sahakyan Signed-off-by: Minas Harutyunyan

[PATCH] usb: dwc2: Fix TxFIFOn sizes and total TxFIFO size issues

2017-12-06 Thread Gevorg Sahakyan
In host mode reading from DPTXSIZn returning invalid value in dwc2_check_param_tx_fifo_sizes function. In total TxFIFO size calculations unnecessarily reducing by ep_info. hw->total_fifo_size can be fully allocated for FIFO's. Added num_dev_in_eps member in dwc2_hw_params structure to save

Re: [PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote: > Trying quirks in usbcore needs to rebuild the driver or the entire > kernel if it's builtin. It can save a lot of time if usbcore has similar > ability like "usbhid.quirks=" and "usb-storage.quirks=". > > Rename the original quirk

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Matthew Wilcox
On Wed, Dec 06, 2017 at 07:44:04PM +1100, Dave Chinner wrote: > On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > > That said, using xa_cmpxchg() in the dquot code looked like the right > > thing to do? Since we'd dropped the qi mutex and the ILOCK, it looks > > entirely

[PATCH v2] usb: dwc2: Remove unnecessary debug prints

2017-12-06 Thread Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side from dwc2_gahbcfg_init() function. Signed-off-by: Razmik Karapetyan --- drivers/usb/dwc2/hcd.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c

[PATCH v2] usb: dwc2: Rename function names

2017-12-06 Thread Razmik Karapetyan
Renamed __orr32 and __bic32 function names to more descriptive dwc2_set_bit and dwc2_clear_bit respectively. Signed-off-by: Razmik Karapetyan --- drivers/usb/dwc2/gadget.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-)

Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

2017-12-06 Thread SF Markus Elfring
>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int >> address, >> int result; >> unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); >> >> -if (!buffer) { >> -dev_err(>dev, "kmalloc(%d) failed.\n", length); > > I guess the length

Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

2017-12-06 Thread Dan Carpenter
On Wed, Dec 06, 2017 at 01:12:32PM +0100, Julia Lawall wrote: > > > On Wed, 6 Dec 2017, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > > > Omit an extra message for a memory allocation failure in this function. >

[PATCH] USB: imx21-hcd: Delete an error message for a failed memory allocation in activate_etd()

2017-12-06 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 6 Dec 2017 13:23:35 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

2017-12-06 Thread Julia Lawall
On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by:

[PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

2017-12-06 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 6 Dec 2017 13:03:21 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] USB: emi62: Delete an error message for a failed memory allocation in emi62_writememory()

2017-12-06 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 6 Dec 2017 12:42:20 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Oliver Neukum
Am Mittwoch, den 06.12.2017, 17:09 +0800 schrieb Kai-Heng Feng: > Now users can use "usbcore.quirks=" as short term workaround before the > next kernel release. > > This is inspired by usbhid and usb-storage. Hi, if you include this for debugging purposes, it would be interesting to be able to

[PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 5:13 PM, Greg KH wrote: > > On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: >> +/* Works only for digits and letters, but small and fast */ >> +#define TOLOWER(x) ((x) | 0x20) > > What is wrong with the in-kernel version of

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: > +/* Works only for digits and letters, but small and fast */ > +#define TOLOWER(x) ((x) | 0x20) What is wrong with the in-kernel version of tolower()? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/2] usbip: Delete an error message for a failed memory allocation in two functions

2017-12-06 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in these functions. >> >> This issue was detected by using the Coccinelle software. > > Please include the problem Do you find the wording “WARNING: Possible unnecessary 'out of memory' message” from the script “checkpatch.pl” more

[PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-06 Thread Dave Chinner
On Tue, Dec 05, 2017 at 08:45:49PM -0800, Matthew Wilcox wrote: > On Wed, Dec 06, 2017 at 02:14:56PM +1100, Dave Chinner wrote: > > > The other conversions use the normal API instead of the advanced API, so > > > all of this gets hidden away. For example, the inode cache does this: > > > > Ah,

[PATCH 1/3] usb: renesas_usbhs: remove redundant polling in usbhsf_fifo_barrier()

2017-12-06 Thread Yoshihiro Shimoda
The datasheet doesn't mention that needs to poll of FRDY is set or not. So, this patch removes such handling in the usbhsf_fifo_barrier(). Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/fifo.c | 16 +--- 1 file changed, 5

[PATCH 0/3] usb: renesas_usbhs: modify fifo/pipe buffer clear handling

2017-12-06 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.git / testing next branch (commit id = 3ed9bbf28b6bc494606b4c1847073343f96d85db). Yoshihiro Shimoda (3): usb: renesas_usbhs: remove redundant polling in usbhsf_fifo_barrier() usb: renesas_usbhs: add usbhs_pipe_clear_without_sequence()

[PATCH 3/3] usb: renesas_usbhs: use PIPEnCLR.ACLRM instead of {C,Dn}FIFOCTR.BCLR in usbhs_pkt_pop()

2017-12-06 Thread Yoshihiro Shimoda
This patch uses usbhs_pipe_clear_without_sequence() instead of usbhsf_fifo_clear() because usbhsf_fifo_clear() may not clear the pipe buffer completely. This patch also changes the clearing condition from DMA only to both DMA and PIO. Signed-off-by: Yoshihiro Shimoda

[PATCH 2/3] usb: renesas_usbhs: add usbhs_pipe_clear_without_sequence() function

2017-12-06 Thread Yoshihiro Shimoda
This patch adds usbhs_pipe_clear_without_sequence() function. The controller has the pipe buffer and the PIPEnCTR.ACLRM can clear it completely. But, it's also clear the data sequence. So, the driver needs to get the sequence before. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH] usb: remove msm_hsusb_hw.h

2017-12-06 Thread Greg KH
On Thu, Nov 02, 2017 at 05:21:41PM -0700, Jack Pham wrote: > The last two remaining drivers (ehci-msm.c and phy-msm-usb.c) that > needed this header were recently removed, so delete this now-unused > file. > > Signed-off-by: Jack Pham > --- >