Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Tue, 19 Dec 2017 02:04:51 +0100, Mauro Santos wrote: > > On 18-12-2017 22:48, Takashi Iwai wrote: > > On Mon, 18 Dec 2017 22:56:07 +0100, > > Mauro Santos wrote: > >> > >> On 18-12-2017 19:30, Takashi Iwai wrote: > >>> On Mon, 18 Dec 2017 20:10:44 +0100, > >>> Mauro Santos wrote: > >

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Bjørn Mork
"SZ Lin (林上智)" writes: >> Johan Hovold writes: >> >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; >> > >> > Do you really need to blacklist the first interface? >> >> Good

RE: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread 林上智
> -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Tuesday, December 19, 2017 2:44 AM > To: SZ Lin (林上智) > Cc: Johan Hovold; Taiyi TY Wu (吳泰毅); Greg Kroah-Hartman; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] USB: serial: option:

[PATCH V2] USBIP: return correct port ENABLE status

2017-12-18 Thread pei . zhang
From: Pei Zhang USB system will clear port's ENABLE feature for some USB devices when vdev is already assigned port address. This cause getPortStatus reports to system that this device is not enabled, client OS will failed to use this usb device. The failure devices include

[PATCH v2] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Dmitry Fleytman
From: Dmitry Fleytman Dmitry Fleytman Commit e0429362ab15 ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") introduced quirk to workaround an issue with some Logitech webcams. There is one more model that has the same issue - C925e, so applying the

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Dmitry Fleytman
> On 18 Dec 2017, at 20:07, Kai-Heng Feng wrote: > > Hi, > >> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman >> wrote: >> >> From: Dmitry Fleytman Dmitry Fleytman >> >> Commit e0429362ab15 >> ("usb: Add

[PATCH v1] usb: chipidea: tegra: Use aligned DMA on Tegra30

2017-12-18 Thread Dmitry Osipenko
USB Ethernet gadget now works on Tegra30. Signed-off-by: Dmitry Osipenko --- drivers/usb/chipidea/ci_hdrc_tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c index

Re: Mixer regression with usb soundcard

2017-12-18 Thread Jaejoong Kim
2017-12-19 7:48 GMT+09:00 Takashi Iwai : > On Mon, 18 Dec 2017 22:56:07 +0100, > Mauro Santos wrote: >> >> On 18-12-2017 19:30, Takashi Iwai wrote: >> > On Mon, 18 Dec 2017 20:10:44 +0100, >> > Mauro Santos wrote: >> >> >> >> On 18-12-2017 17:50, Jaejoong Kim wrote: >> >>> Mauro, >>

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 22:48, Takashi Iwai wrote: > On Mon, 18 Dec 2017 22:56:07 +0100, > Mauro Santos wrote: >> >> On 18-12-2017 19:30, Takashi Iwai wrote: >>> On Mon, 18 Dec 2017 20:10:44 +0100, >>> Mauro Santos wrote: On 18-12-2017 17:50, Jaejoong Kim wrote: > Mauro, > > Could you

Re: Storing errors in the XArray

2017-12-18 Thread Randy Dunlap
On 12/15/2017 09:10 AM, Matthew Wilcox wrote: > On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: >>> +The XArray does not support storing :c:func:`IS_ERR` pointers; some >>> +conflict with data values and others conflict with entries the XArray >>> +uses for its own purposes. If you

[PATCH] usbip: vhci: stop printing kernel pointer addresses in messages

2017-12-18 Thread Shuah Khan
Remove and/or change debug, info. and error messages to not print kernel pointer addresses. Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 10 -- drivers/usb/usbip/vhci_rx.c | 23 +++ drivers/usb/usbip/vhci_tx.c | 3 ++- 3

[PATCH] usbip: stub: stop printing kernel pointer addresses in messages

2017-12-18 Thread Shuah Khan
Remove and/or change debug, info. and error messages to not print kernel pointer addresses. Signed-off-by: Shuah Khan --- drivers/usb/usbip/stub_main.c | 5 +++-- drivers/usb/usbip/stub_rx.c | 7 ++- drivers/usb/usbip/stub_tx.c | 6 +++--- 3 files changed, 8

Re: Naming of tag operations in the XArray

2017-12-18 Thread Randy Dunlap
On 12/15/2017 04:34 AM, Matthew Wilcox wrote: > On Thu, Dec 14, 2017 at 08:22:14PM -0800, Matthew Wilcox wrote: >> On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote: +A freshly-initialised XArray contains a ``NULL`` pointer at every index. +Each non-``NULL`` entry in the array

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 22:56:07 +0100, Mauro Santos wrote: > > On 18-12-2017 19:30, Takashi Iwai wrote: > > On Mon, 18 Dec 2017 20:10:44 +0100, > > Mauro Santos wrote: > >> > >> On 18-12-2017 17:50, Jaejoong Kim wrote: > >>> Mauro, > >>> > >>> Could you please try debug patch(I also attach the patch

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 21:56, Mauro Santos wrote: > On 18-12-2017 19:30, Takashi Iwai wrote: >> On Mon, 18 Dec 2017 20:10:44 +0100, >> Mauro Santos wrote: >>> >>> On 18-12-2017 17:50, Jaejoong Kim wrote: Mauro, Could you please try debug patch(I also attach the patch file)? >>> >>> With the

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 19:30, Takashi Iwai wrote: > On Mon, 18 Dec 2017 20:10:44 +0100, > Mauro Santos wrote: >> >> On 18-12-2017 17:50, Jaejoong Kim wrote: >>> Mauro, >>> >>> Could you please try debug patch(I also attach the patch file)? >> >> With the attached patch I get the following when plugging in

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 20:10:44 +0100, Mauro Santos wrote: > > On 18-12-2017 17:50, Jaejoong Kim wrote: > > Mauro, > > > > Could you please try debug patch(I also attach the patch file)? > > With the attached patch I get the following when plugging in the usb dac > directly to a usb3 port: > [

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 17:50, Jaejoong Kim wrote: > Mauro, > > Could you please try debug patch(I also attach the patch file)? With the attached patch I get the following when plugging in the usb dac directly to a usb3 port: [ 54.391539] usb 1-2: new full-speed USB device number 7 using xhci_hcd [

Re: [PATCH 2/5 v3] Modify behaviour of request_*muxed_region()

2017-12-18 Thread Guenter Roeck
On Mon, Dec 18, 2017 at 09:48:38AM +0100, Zoltan Boszormenyi wrote: > From: Böszörményi Zoltán > > In order to make request_*muxed_region() behave more like > mutex_lock(), a possible failure case needs to be eliminated. > When drivers do not properly share the same I/O region,

Re: [PATCH 1/5 v3] Extend the request_region() infrastructure

2017-12-18 Thread Guenter Roeck
On Mon, Dec 18, 2017 at 09:48:37AM +0100, Zoltan Boszormenyi wrote: > From: Böszörményi Zoltán > > Add a new IORESOURCE_ALLOCATED flag that is automatically used > when alloc_resource() is used internally in kernel/resource.c > and free_resource() now takes this flag into account.

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Bjørn Mork
Johan Hovold writes: >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> +.reserved = BIT(0) | BIT(1) | BIT(4), >> +}; > > Do you really need to blacklist the first interface? Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 16:59, Jaejoong Kim wrote: > Mauro, > thanks for the report and sorry for the make problem. > > Could you try below debug patch? I add more debug code with Takashi's > guideline. > I get this when I plug the device directly to a usb3 port: [ 63.643706] usb 1-2: new full-speed

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Kai-Heng Feng
Hi, > On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman > wrote: > > From: Dmitry Fleytman Dmitry Fleytman > > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an

Re: [PATCH] usb: pd: fix the offset for SVID specific commands

2017-12-18 Thread Heikki Krogerus
On Mon, Dec 18, 2017 at 03:08:35PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 18, 2017 at 05:03:03PM +0300, Heikki Krogerus wrote: > > The SVID specific commands in the Command field of the > > Structured VDM Header start from 16, not 10. Changing the > > value used in VDO_CMD_VENDOR() macro

Re: Mixer regression with usb soundcard

2017-12-18 Thread Jaejoong Kim
Mauro, Could you please try debug patch(I also attach the patch file)? And can you share your usb audio dac? Is this same device with yours? https://hifimediy.com/index.php?route=product/product_id=83 diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 84b9f9c..6200aa2 100644 ---

Re: [PATCH] usb: pd: fix the offset for SVID specific commands

2017-12-18 Thread Guenter Roeck
On Mon, Dec 18, 2017 at 05:03:03PM +0300, Heikki Krogerus wrote: > The SVID specific commands in the Command field of the > Structured VDM Header start from 16, not 10. Changing the > value used in VDO_CMD_VENDOR() macro from 10 to 0x10. > > Signed-off-by: Heikki Krogerus

Re: Mixer regression with usb soundcard

2017-12-18 Thread Jaejoong Kim
2017-12-19 2:13 GMT+09:00 Takashi Iwai : > On Mon, 18 Dec 2017 18:05:18 +0100, > Mauro Santos wrote: >> >> On 18-12-2017 15:45, Takashi Iwai wrote: >> > On Mon, 18 Dec 2017 16:30:13 +0100, >> > Mauro Santos wrote: >> >> >> >> On 18-12-2017 13:53, Takashi Iwai wrote: >> >>> On Mon,

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 18:05:18 +0100, Mauro Santos wrote: > > On 18-12-2017 15:45, Takashi Iwai wrote: > > On Mon, 18 Dec 2017 16:30:13 +0100, > > Mauro Santos wrote: > >> > >> On 18-12-2017 13:53, Takashi Iwai wrote: > >>> On Mon, 18 Dec 2017 14:44:44 +0100, > >>> Greg KH wrote: > > On

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 17:59:38 +0100, Jaejoong Kim wrote: > > AudioControl Interface Descriptor: > bLength 8 > bDescriptorType36 > bDescriptorSubtype 5 (SELECTOR_UNIT) > bUnitID11 > bNrInPins 2 >

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 15:45, Takashi Iwai wrote: > On Mon, 18 Dec 2017 16:30:13 +0100, > Mauro Santos wrote: >> >> On 18-12-2017 13:53, Takashi Iwai wrote: >>> On Mon, 18 Dec 2017 14:44:44 +0100, >>> Greg KH wrote: On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: > I believe

Re: Mixer regression with usb soundcard

2017-12-18 Thread Jaejoong Kim
Mauro, thanks for the report and sorry for the make problem. Could you try below debug patch? I add more debug code with Takashi's guideline. diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 84b9f9c..0233425 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -595,7 +595,7 @@ int

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Johan Hovold
[ +CC: Bjørn ] On Fri, Dec 15, 2017 at 06:32:03PM +0800, SZ Lin wrote: > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option > driver. Could you specify what each interface is used for here? > Signed-off-by: Taiyi Wu > Signed-off-by: SZ Lin

Re: [PATCH V1 4/4] usb: serial: f81534: add H/W disable port support

2017-12-18 Thread Johan Hovold
On Thu, Nov 16, 2017 at 03:46:09PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 can be disable port by manufacturer with > following H/W design. > 1: Connect DCD/DSR/CTS/RI pin to ground. > 2: Connect RX pin to ground. > > In driver, we'll implements some detect method likes

Re: [PATCH V1 3/4] usb: serial: f81534: add output pin control

2017-12-18 Thread Johan Hovold
On Thu, Nov 16, 2017 at 03:46:08PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 3 output pin (M0/SD, M1, M2) with open-drain mode to > control transceiver. We'll read it from internal Flash with address > 0x2f05~0x2f08 for 4 ports. The value is range from 0 to 7. The M0/SD is > MSB

[PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Dmitry Fleytman
From: Dmitry Fleytman Dmitry Fleytman Commit e0429362ab15 ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") introduced quirk to workaround an issue with some Logitech webcams. There is one more model that has the same issue - C925e, so applying the

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 16:30:13 +0100, Mauro Santos wrote: > > On 18-12-2017 13:53, Takashi Iwai wrote: > > On Mon, 18 Dec 2017 14:44:44 +0100, > > Greg KH wrote: > >> > >> On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: > >>> I believe this is the right place to report this problem,

Re: Mixer regression with usb soundcard

2017-12-18 Thread Mauro Santos
On 18-12-2017 13:53, Takashi Iwai wrote: > On Mon, 18 Dec 2017 14:44:44 +0100, > Greg KH wrote: >> >> On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: >>> I believe this is the right place to report this problem, but if it >>> isn't please point me in the right direction. >> >> Adding

Re: [PATCH V1 2/4] usb: serial: f81534: add auto RTS direction support

2017-12-18 Thread Johan Hovold
On Thu, Nov 16, 2017 at 03:46:07PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had auto RTS direction support for RS485 mode. > We'll read it from internal Flash with address 0x2f01~0x2f04 for 4 ports. > There are 4 conditions below: > 0: F81534_PORT_CONF_RS232. > 1:

[PATCH] usb: dwc3: of-simple: fix oops by unbalanced clk disable call

2017-12-18 Thread Enric Balletbo i Serra
dwc3_of_simple_dev_pm_ops has never been used since commit a0d8c4cfdf31 ("usb: dwc3: of-simple: set dev_pm_ops"), but this commit has brought and oops when unbind the device due this sequence: dwc3_of_simple_remove -> clk_disable ... -> pm_runtime_put_sync ->

Re: [PATCH V1 1/4] usb: serial: f81534: add high baud rate support

2017-12-18 Thread Johan Hovold
On Thu, Nov 16, 2017 at 03:46:06PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates can > be up to 1.5Mbits with 24MHz. > > F81532/534 Clock register (offset +08h) > > Bit0: UART Enable (always on) > Bit2-1: Clock source

Re: [debian bug:883345] vhci-hcd: kernel oops when attaching a mass storage on client side of usbip

2017-12-18 Thread Borissh1983
On 12/5/17, Greg KH wrote: > On Tue, Dec 05, 2017 at 10:17:08AM +0200, borissh1...@gmail.com wrote: >> On Tuesday, 5 December 2017 9:39:33 IST Greg KH wrote: >> > On Mon, Dec 04, 2017 at 10:05:45PM +0200, borissh1...@gmail.com wrote: >> > > Hi , >> > > >> > > vhci-hcd

Re: [PATCH] usb: pd: fix the offset for SVID specific commands

2017-12-18 Thread Greg Kroah-Hartman
On Mon, Dec 18, 2017 at 05:03:03PM +0300, Heikki Krogerus wrote: > The SVID specific commands in the Command field of the > Structured VDM Header start from 16, not 10. Changing the > value used in VDO_CMD_VENDOR() macro from 10 to 0x10. > > Signed-off-by: Heikki Krogerus

[PATCH] usb: pd: fix the offset for SVID specific commands

2017-12-18 Thread Heikki Krogerus
The SVID specific commands in the Command field of the Structured VDM Header start from 16, not 10. Changing the value used in VDO_CMD_VENDOR() macro from 10 to 0x10. Signed-off-by: Heikki Krogerus --- include/linux/usb/pd_vdo.h | 2 +- 1 file changed, 1

Re: Mixer regression with usb soundcard

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 14:44:44 +0100, Greg KH wrote: > > On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: > > I believe this is the right place to report this problem, but if it > > isn't please point me in the right direction. > > Adding the developer of that patch, and the sound

Re: Mixer regression with usb soundcard

2017-12-18 Thread Greg KH
On Sun, Dec 17, 2017 at 06:56:05PM +, Mauro Santos wrote: > I believe this is the right place to report this problem, but if it > isn't please point me in the right direction. Adding the developer of that patch, and the sound maintainer and developers to the thread. > I have noticed that

[PATCH v3 2/7] typec: tcpm: Add ADO header for Alert message handling

2017-12-18 Thread Adam Thomson
This commit adds a header providing definitions for handling Alert messages. Currently the header only focuses on handling incoming alerts. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ado.h | 42 ++ 1 file

[PATCH v3 5/7] power: supply: Add 'connected_type' property and supporting code

2017-12-18 Thread Adam Thomson
This commit adds the 'connected_type' property to represent supplies which can report a number of different types of supply based on a connection event. Examples of this already exist in drivers whereby the existing 'type' property is updated, based on an event, to represent what was connected

[PATCH v3 4/7] typec: tcpm: Add core support for sink side PPS

2017-12-18 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson ---

[PATCH v3 0/7] typec: tcpm: Add sink side support for PPS

2017-12-18 Thread Adam Thomson
This patch set adds sink side support for the PPS feature introduced in the USB PD 3.0 specification. The source PPS supply is represented using the Power Supply framework to provide access and control APIs for dealing with it's operating voltage and current, and switching between a standard PDO

[PATCH v3 6/7] typec: tcpm: Represent source supply through power_supply class

2017-12-18 Thread Adam Thomson
This commit adds a power_supply class instance to represent a PD source's voltage and current properties. This provides an interface for reading these properties from user-space or other drivers. For PPS enabled Sources, this also provides write access to set the current and voltage and allows

[PATCH v3 7/7] typec: tcpm: Add support for sink PPS related messages

2017-12-18 Thread Adam Thomson
This commit adds sink side support for Get_Status, Status, Get_PPS_Status and PPS_Status handling. As there's the potential for a partner to respond with Not_Supported handling of this message is also added. Sending of Not_Supported is added is added to handle messages received but not yet

[PATCH v3 3/7] typec: tcpm: Add SDB header for Status message handling

2017-12-18 Thread Adam Thomson
This commit adds a header providing definitions for handling Status messages. Currently the header only focuses on handling incoming Status messages. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ext_sdb.h | 31 +++ 1 file

[PATCH v3 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2017-12-18 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 187 + 1 file changed, 175 insertions(+),

Re: [PATCH] phy: rockchip-typec: Try to turn the PHY on several times

2017-12-18 Thread Enric Balletbo Serra
Hi, 2017-12-13 20:14 GMT+01:00 Doug Anderson : > Hi, > > On Wed, Dec 13, 2017 at 4:41 AM, Enric Balletbo Serra > wrote: >> Hi Doug, >> >> 2017-12-11 22:45 GMT+01:00 Douglas Anderson : >>> Bind / unbind stress testing of the USB

Re: Scatter Gather Implementation in DWC3

2017-12-18 Thread Felipe Balbi
Hi, Arjav Parikh writes: > I want to use scatter gather logic in DWC3. As per code in DWC3 I > identified that DWC3 supports scatter-gather implementation. > > Now, to check the working of scatter-gather I randomly prepared a > buffer containing some strings and pass

Re: [PATCH v2 1/4] dt-bindings: usb: add DT binding for RK3328 dwc3 controller

2017-12-18 Thread Felipe Balbi
Hi, Heiko Stuebner writes: > Hi Greg, Felipe, > > Am Montag, 4. Dezember 2017, 10:40:38 CET schrieb Heiko Stuebner: >> From: William Wu >> >> Adds the device tree bindings description for RK3328 and >> compatible USB DWC3 controller. >> >>

RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

2017-12-18 Thread Jun Li
> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Saturday, December 16, 2017 6:26 AM > To: Jun Li > Cc: mathias.ny...@intel.com; gre...@linuxfoundation.org; > mark.rutl...@arm.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org > Subject: