RE: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

2018-02-04 Thread Peter Chen
> > Martin, you design has no problem for most of cases, but some hardware > > needs special sequence for phy control. I will give an example below. > great to hear that this should work for most devices! > > >> it would be great if you could explain the issue behind this (and > >> thereby

Re: [PATCH 1/3] dt-bindings: usb: add support for dwc3 controller on Amlogic Meson GX

2018-02-04 Thread Rob Herring
On Sun, Jan 28, 2018 at 09:03:31PM +0100, Martin Blumenstingl wrote: > Amlogic Meson GX SoCs (GXL and AXG) come with a (host-only) dwc3 USB > controller. This requires a clock to be enabled and a reset line to be > pulsed to get the hardware into a known state. > Add the documentation for this IP

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-04 Thread Rob Herring
On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: > These bindings allow to describe most known standard USB connectors > and it should be possible to extend it if necessary. > USB connectors, beside USB can be used to route other protocols, > for example UART, Audio, MHL. In such

Re: [PATCH v4 08/15] usb: dwc3: Make TX/RX threshold configurable

2018-02-04 Thread Rob Herring
On Wed, Jan 31, 2018 at 01:16:38PM -0800, Thinh Nguyen wrote: > DWC_usb31 periodic transfer at 48K+ bytes per interval may need > modification to the TX/RX packet threshold to achieve optimal result. > Add properties to make it configurable. > > By default, periodic ESS TX and RX threshold are

[PATCH/resend] usb: gadget: udc: renesas_usb3: fix oops in renesas_usb3_remove()

2018-02-04 Thread Yoshihiro Shimoda
This patch fixes an issue that the renesas_usb3_remove() causes NULL pointer dereference because the usb3_to_dev() macro will use the gadget instance and it will be deleted before. Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") Signed-off-by: Yoshihiro

[PATCH v2 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

2018-02-04 Thread Peter Chen
At former code, the SETUP stage does not enable interrupt for qtd completion, it relies on IAA watchdog to complete interrupt, then the transcation would be considered timeout if the flag need_io_watchdog is cleared by platform code. In this commit, we always add enable interrupt for qtd

[PATCH 11/20] usb: gadget: udc: Remove USB_GADGET_DUALSPEED select

2018-02-04 Thread Ulf Magnusson
USB_GADGET_DUALSPEED was removed by commit 85b8614d7223 ("usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED"), but the USB_SNP_UDC_PLAT symbol still selects it. Remove the USB_GADGET_DUALSPEED select from USB_SNP_UDC_PLAT. Discovered with the

Re: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

2018-02-04 Thread Martin Blumenstingl
Hi Peter, On Mon, Jan 29, 2018 at 4:30 AM, Peter Chen wrote: > >> > >> >> >> >> Now that usb_add_hcd parses all generic PHYs anyways the code which >> >> skips initialization of a single PHY will go away. >> >> Remove the code which sets struct usb_hcd's phy field from the >>

Re: [Bug 197863] Thinkpad X240 resume dramatically slower on kernels 4.13+

2018-02-04 Thread Bjørn Mork
Greg KH writes: > On Sat, Feb 03, 2018 at 07:25:54PM +0100, Markus Demleitner wrote: > >> It's 662591461c4b9a1e3b9b159dbf37648a585ebaae. To my eyes, it even >> looks plausible that it's causing the problematic behaviour, but >> since I can't say I understand what I'd

Re: [PATCH] option: Add support for Quectel EP06

2018-02-04 Thread Bjørn Mork
Johan Hovold writes: > IIRC we have already started reusing entries, but the names have not > always been made generic in the process. I think Bjørn may have proposed > a generic naming scheme at some point, but that essentially just meant > we encoded the two masks in the

[PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread JackStocker
Following on from this patch: https://lkml.org/lkml/2017/11/3/516, Corsair K70 RGB keyboards also require the DELAY_INIT quirk to start correctly at boot. Device ids found here: usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13 usb 3-3: New USB device strings: Mfr=1, Product=2,

Re: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 5 Feb 2018, at 12:18 AM, JackStocker wrote: > > Do you mean like this? Yes, with proper commit message. > > Signed-off-by: JackStocker > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread JackStocker
Do you mean like this? Signed-off-by: JackStocker --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index a6aaf2f..0405d68 100644 --- a/drivers/usb/core/quirks.c +++

Re: power management problems in ehci-omap

2018-02-04 Thread H. Nikolaus Schaller
Hi, Andreas seems to be travelling back from FOSDEM so I jump in with best of my knowledge. > Am 04.02.2018 um 12:34 schrieb Michael Nazzareno Trimarchi > : > > Hi > > On Sun, Feb 4, 2018 at 12:07 PM, H. Nikolaus Schaller > wrote: >> Hi

Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 2 Feb 2018, at 11:51 PM, JackStocker wrote: > > From: Jack Stocker > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516, > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to > start correctly at boot. > >

Re: power management problems in ehci-omap

2018-02-04 Thread Michael Nazzareno Trimarchi
Hi On Sun, Feb 4, 2018 at 12:07 PM, H. Nikolaus Schaller wrote: > Hi Michael, > >> Am 04.02.2018 um 11:55 schrieb Michael Nazzareno Trimarchi >> : >> >> Hi Andreas >> >> On Sun, Feb 4, 2018 at 11:50 AM, Andreas Kemnade

Re: power management problems in ehci-omap

2018-02-04 Thread H. Nikolaus Schaller
Hi Michael, > Am 04.02.2018 um 11:55 schrieb Michael Nazzareno Trimarchi > : > > Hi Andreas > > On Sun, Feb 4, 2018 at 11:50 AM, Andreas Kemnade wrote: >> Hi, >> >> On Sun, 4 Feb 2018 09:43:45 +0100 >> Michael Nazzareno Trimarchi

Re: power management problems in ehci-omap

2018-02-04 Thread Michael Nazzareno Trimarchi
Hi Andreas On Sun, Feb 4, 2018 at 11:50 AM, Andreas Kemnade wrote: > Hi, > > On Sun, 4 Feb 2018 09:43:45 +0100 > Michael Nazzareno Trimarchi wrote: > >> Hi Andreas >> >> On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade

Re: power management problems in ehci-omap

2018-02-04 Thread Andreas Kemnade
Hi, On Sun, 4 Feb 2018 09:43:45 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade wrote: > > On Sun, 4 Feb 2018 00:10:50 +0100 > > Michael Nazzareno Trimarchi

Re: power management problems in ehci-omap

2018-02-04 Thread Michael Nazzareno Trimarchi
Hi Andreas On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade wrote: > On Sun, 4 Feb 2018 00:10:50 +0100 > Michael Nazzareno Trimarchi wrote: > >> Hi >> >> On Sun, Feb 4, 2018 at 12:03 AM, Andreas Kemnade >> wrote: >> >

Re: power management problems in ehci-omap

2018-02-04 Thread Andreas Kemnade
On Sun, 4 Feb 2018 00:10:50 +0100 Michael Nazzareno Trimarchi wrote: > Hi > > On Sun, Feb 4, 2018 at 12:03 AM, Andreas Kemnade wrote: > > Hi, > > > > I booted a 4.15 kernel without udev and loaded modules piece by piece to > > analyze > > pm