Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Fri, 2018-03-16 at 11:44 +1100, Benjamin Herrenschmidt wrote: > The Aspeed BMC SoCs support a "virtual hub" function. It provides some > HW support for a top-level USB2 hub behind which sit 5 gadget "ports". > > This driver adds support for the full functionality, emulating the > hub standard

Re: [PATCH v4 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Sat, 2018-03-17 at 09:50 -0400, Alan Stern wrote: > On Sat, 17 Mar 2018, Benjamin Herrenschmidt wrote: > > > On Fri, 2018-03-16 at 16:56 -0400, Alan Stern wrote: > > > On Fri, 16 Mar 2018, Benjamin Herrenschmidt wrote: > > > > > > > On Thu, 2018-03-15 at 08:03 +1100, Benjamin Herrenschmidt

[PATCH v2] ACPI / PM: allow deeper wakeup power states with no _SxD nor _SxW

acpi_dev_pm_get_state() is used to determine the range of allowable device power states when going into S3 suspend. This is implemented by executing the _S3D and _S3W ACPI methods. Linux follows the ACPI spec behaviour in that when _S3D is implemented and _S3W is not, Linux will not go into a

RE: [PATCH v3 02/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)

> -Original Message- > From: Jun Li > Sent: 2018年3月20日 10:29 > To: Mats Karrman ; robh...@kernel.org; > mark.rutl...@arm.com; gre...@linuxfoundation.org; > heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; li...@roeck-us.net; yue...@google.com; >

RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

> -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月16日 0:06 > To: Jun Li ; robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; li...@roeck-us.net;

RE: [PATCH v3 02/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)

Hi > -Original Message- > From: Mats Karrman [mailto:mats.dev.l...@gmail.com] > Sent: 2018年3月15日 23:54 > To: Jun Li ; robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; li...@roeck-us.net;

[PATCH v2 1/1] usb: musb: gadget: misplaced out of bounds check

musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- v2 Only the 4 low bits of epnum are relevant for indexing. --- drivers/usb/musb/musb_gadget_ep0.c | 9

RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月15日 20:06 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; a.ha...@samsung.com; li...@roeck-us.net; > yue...@google.com;

RE: [PATCH v3 06/12] staging: typec: tcpci: support port config passed via dt

Hi > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: 2018年3月15日 19:43 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; a.ha...@samsung.com; li...@roeck-us.net; > yue...@google.com;

RE: [PATCH v1 2/3] usb: dwc2: Change ISOC DDMA flow

Hi Minas: A few minor comments: >-Original Message- >From: linux-usb-ow...@vger.kernel.org >[mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Minas Harutyunyan >Sent: Saturday, March 17, 2018 5:10 PM >To: John Youn ; Felipe Balbi ; >Greg

RE: [PATCH v3 05/12] usb: typec: add API to get sink and source config

> -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Heikki Krogerus > Sent: 2018年3月15日 19:21 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; a.ha...@samsung.com;

RE: [PATCH v3 10/12] staging: typec: tcpci: keep the not connecting cc line open

Hi > -Original Message- > From: shufan_lee(李��帆) [mailto:shufan_...@richtek.com] > Sent: 2018年3月15日 15:45 > To: Jun Li ; robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com > Cc: a.ha...@samsung.com; li...@roeck-us.net;

RE: [PATCH v3 07/12] staging: typec: tcpci: register port before request irq

Hi > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: 2018年3月15日 12:51 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > a.ha...@samsung.com;

Re: [PATCH v5 1/2] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

On Mon, 2018-03-19 at 12:56 +0200, Felipe Balbi wrote: > >> do you really need this to be safe? You don't seem to be modifying > >> ep_list here. > > > > Yes, ep->dispose() may do just that. In my Aspeed implementation in > > fact that's pretty much the first thing it does. > > > > IE, I'm

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

On 14/03/2018 at 15:43:46 +0100, Arnd Bergmann wrote: > A lot of Kconfig symbols have architecture specific dependencies. > In those cases that depend on architectures we have already removed, > they can be omitted. > > Signed-off-by: Arnd Bergmann > --- > block/bounce.c

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

Kai Heng Feng wrote: Matthew Wilcox wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or + override the

[PATCH 4.4 068/134] usb: dwc2: Make sure we disconnect the gadget state

4.4-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ] I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have

[PATCH v3] usb: dwc3: pci: Properly cleanup resource

Platform device is allocated before adding resources. Make sure to properly cleanup on error case. Cc: Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()") Signed-off-by: Thinh Nguyen --- Changes in v3: - Include Cc:

[PATCH] MAINTAINERS: Update maintainer for dwc2

Update to show Minas Harutyunyan as the new maintainer for dwc2. Signed-off-by: John Youn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 93a12af4f180..fc23eb016198 100644 --- a/MAINTAINERS +++

[PATCHv2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

Add bFrameIndex as a UVCG_FRAME_ATTR for each frame size. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget). After the negotiation the host

[PATCH 4.9 139/241] usb: dwc2: Make sure we disconnect the gadget state

4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz [ Upstream commit dad3f793f20fbb5c0c342f0f5a0bdf69a4d76089 ] I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have

Re: howto debug xhci driver?

On Mon, Mar 05, 2018 at 01:21:42PM -0600, Bin Liu wrote: > On Mon, Mar 05, 2018 at 10:16:49AM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Bin Liu writes: > > > I am relatively new to xhci and its driver. I am trying to get a xhci > > > driver runtime log to understand how it

Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

Hi Roger, On Mon, Mar 19, 2018 at 9:49 AM, Roger Quadros wrote: > Hi, > > On 19/03/18 00:29, Martin Blumenstingl wrote: >> Hi Roger, >> >> On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros wrote: >>> +some TI folks >>> >>> Hi Martin, >>> >>> On 18/02/18 20:44, Martin

Re: [PATCH 1/1] usb: musb: gadget: misplaced out of bounds check

Hi, On Mon, Mar 19, 2018 at 08:12:28AM +0100, Heinrich Schuchardt wrote: > musb->endpoints[] has array size MUSB_C_NUM_EPS. > We must check array bounds before accessing the array and not afterwards. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

On Mon, Mar 19, 2018 at 11:49:35AM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Add device tree binding document for Richtek RT1711H Type-C chip driver Cc: Rob Herring , devicet...@vger.kernel.org is missing. Added here but it might make sense to

[PATCH v7] usb: core: Add "quirks" parameter for usbcore

Trying quirks in usbcore needs to rebuild the driver or the entire kernel if it's builtin. It can save a lot of time if usbcore has similar ability like "usbhid.quirks=" and "usb-storage.quirks=". Rename the original quirk detection function to "static" as we introduce this new "dynamic"

Re: [PATCH 1/2] staging: typec: rt1711h typec chip driver

On Mon, Mar 19, 2018 at 11:49:34AM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > Add definition of TCPC_CC_STATUS_TOGGLING. > >

Re: [PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

On Mon, Mar 19, 2018 at 11:55:02AM +0100, Joel Pepper wrote: > This adds bFrameIndex as a UVCG_FRAME_ATTR for each frame size. > Beforehand all bFrameindex were set to "1" with no way to configure the > gadget otherwise. > > This resulted in the host always negotiating for bFrameIndex 1 (i.e.

Re: [RFC] musb: removing otg protocol support

On Mon, Mar 19, 2018 at 03:40:48PM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 19, 2018 at 09:20:23AM -0500, Bin Liu wrote: > > On Sun, Mar 18, 2018 at 02:16:25PM +0100, Greg Kroah-Hartman wrote: > > > On Fri, Mar 16, 2018 at 02:09:51PM -0500, Bin Liu wrote: > > > > Hi, > > > > > > > > The

Re: [RFC] musb: removing otg protocol support

On Mon, Mar 19, 2018 at 09:20:23AM -0500, Bin Liu wrote: > On Sun, Mar 18, 2018 at 02:16:25PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Mar 16, 2018 at 02:09:51PM -0500, Bin Liu wrote: > > > Hi, > > > > > > The kernel usb stack and musb drivers have gone through some changes in > > > the past

Re: [PATCH] USB: serial: ftdi_sio: add support for Harman FirmwareHubEmulator

On Fri, Mar 16, 2018 at 10:20:46AM +0100, Clemens Werther wrote: > Make the device auto-detectable by the driver > > Signed-off-by: Clemens Werther Now applied (with a slightly updated commit message). Thanks, Johan -- To unsubscribe from this list: send the line

Re: [RFC] musb: removing otg protocol support

On Sun, Mar 18, 2018 at 05:36:10PM +0100, Hans de Goede wrote: > Hi, > > On 18-03-18 14:16, Greg Kroah-Hartman wrote: > >On Fri, Mar 16, 2018 at 02:09:51PM -0500, Bin Liu wrote: > >>Hi, > >> > >>The kernel usb stack and musb drivers have gone through some changes in > >>the past several kernel

Re: [RFC] musb: removing otg protocol support

On Sun, Mar 18, 2018 at 02:16:25PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 16, 2018 at 02:09:51PM -0500, Bin Liu wrote: > > Hi, > > > > The kernel usb stack and musb drivers have gone through some changes in > > the past several kernel versions, such as adding otg fsm, musb runtime > > PM,

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

Hi Felipe, Thanks for reviewing the patch , please find my comments inline >-Original Message- >From: Felipe Balbi [mailto:ba...@kernel.org] >Sent: Monday, March 19, 2018 2:21 PM >To: Anurag Kumar Vulisha ; Greg Kroah-Hartman > >Cc:

Re: [PATCH] ACPI / PM: allow deeper wakeup power states with no _SxD nor _SxW

Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, On 3/19/2018 3:36 PM, Minas Harutyunyan wrote: > Hi, > > On 3/19/2018 12:55 PM, Felipe Balbi wrote: >> >> Hi, >> >> Minas Harutyunyan writes: Thanks for picking this for -next. Is it better to have this in v4.16-rc fixes? and also

Re: [RFC PATCH v2 3/3] usb: typec: tcpm: Support for Alternate Modes

Hi Guenter, On Fri, Mar 16, 2018 at 02:32:06PM -0700, Guenter Roeck wrote: > On Fri, Mar 09, 2018 at 06:19:18PM +0300, Heikki Krogerus wrote: > > This adds more complete handling of VDMs and registration of > > partner alternate modes, and introduces callbacks for > > alternate mode operations. >

Re: [RFC PATCH v2 2/3] usb: typec: Bus type for alternate modes

Hi Guenter, On Fri, Mar 16, 2018 at 02:33:36PM -0700, Guenter Roeck wrote: > On Fri, Mar 09, 2018 at 06:19:17PM +0300, Heikki Krogerus wrote: > > diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c > > new file mode 100644 > > index ..92944aaf3d6a > > --- /dev/null > > +++

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, On 3/19/2018 12:55 PM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >>> Thanks for picking this for -next. >>> Is it better to have this in v4.16-rc fixes? >>> and also stable? v4.12+ >> >> Well, there was no "Fixes: foobar"

Re: [PATCH 1/2] staging: typec: rt1711h typec chip driver

On Mon, Mar 19, 2018 at 11:49:34AM +0800, ShuFan Lee wrote: > From: ShuFan Lee > > Richtek RT1711H Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and > USB Type-C functionalities. > Add definition of TCPC_CC_STATUS_TOGGLING. > >

Re: [PATCH v1 2/3] usb: dwc2: Change ISOC DDMA flow

Hi Zengtao, You email not received by linux-usb@vger.kernel.org. I suspect it rejected due to your email format have some issues, violate linux-usb@vger.kernel.org rules. I think you received email from linux-usb similar to this: : host

[PATCH] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first

This adds bFrameIndex as a UVCG_FRAME_ATTR for each frame size. Beforehand all bFrameindex were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget). After the negotiation the host driver

Re: [PATCH v5 1/2] usb/gadget: Add an EP dispose() callback for EP lifetime tracking

Hi, Benjamin Herrenschmidt writes: > On Fri, 2018-03-16 at 13:02 +0200, Felipe Balbi wrote: >> Hi, >> >> Benjamin Herrenschmidt writes: >> > Some UDC may want to allocate endpoints dynamically, either because >> > the HW supports an

RE: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS

On 12 March 2018 08:33, Adam Thomson wrote: > On 09 March 2018 17:34, Greg Kroah-Hartman wrote: > > > On Tue, Jan 02, 2018 at 03:50:48PM +, Adam Thomson wrote: > > > This patch set adds sink side support for the PPS feature introduced in > > > the > > > USB PD 3.0 specification. > > > > > >

RE: [PATCH v3 08/12] staging: typec: tcpci: enable vbus detection

Hi > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: 2018年3月15日 12:47 > To: Jun Li > Cc: robh...@kernel.org; mark.rutl...@arm.com; > gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > a.ha...@samsung.com;

Re: [RFC PATCH] usb: typec: tcpm: match source fixed pdo with sink variable pdo

HI, On 19-03-18 10:43, Jun Li wrote: Hi -Original Message- From: Hans de Goede [mailto:hdego...@redhat.com] Sent: 2018年3月14日 18:39 To: Jun Li ; gre...@linuxfoundation.org; li...@roeck-us.net; heikki.kroge...@linux.intel.com; adam.thomson.opensou...@diasemi.com;

RE: [RFC PATCH] usb: typec: tcpm: match source fixed pdo with sink variable pdo

Hi > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: 2018年3月14日 18:39 > To: Jun Li ; gre...@linuxfoundation.org; li...@roeck-us.net; > heikki.kroge...@linux.intel.com; adam.thomson.opensou...@diasemi.com; > bad...@google.com > Cc:

RE: [PATCH v3 04/12] usb: typec: add API to get typec basic port power and data config

Hi > > I been thinking about this. Perhaps it's better that we don't read any > properties in these helpers. These helpers become more useful that way, and > we can use the in other places as well if needed. > > So my proposal is that the callers of these functions are responsible of > reading

RE: About patchwork for linux-usb

> > > > At some situations, we may need to save reviewing patches from web, > > but I can't find linux-usb at > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.k > ernel.org%2F=02%7C01%7Cpeter.chen%40nxp.com%7Cbef6ada7885641ed5 >

Re: [PATCH v2] usb: dwc3: pci: Properly cleanup resource

Hi, Thinh Nguyen writes: > Platform device is allocated before adding resources. Make sure to > properly cleanup on error case. > > Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()") this commit is from way back in 3.16, please resend with a "Cc:

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, Minas Harutyunyan writes: >> Thanks for picking this for -next. >> Is it better to have this in v4.16-rc fixes? >> and also stable? v4.12+ > > Well, there was no "Fixes: foobar" or "Cc: stable" lines in the commit > log ;-) > >

Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

Hi, On 19/03/18 00:29, Martin Blumenstingl wrote: > Hi Roger, > > On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros wrote: >> +some TI folks >> >> Hi Martin, >> >> On 18/02/18 20:44, Martin Blumenstingl wrote: >>> Many SoC platforms have separate devices for the USB PHY which are

Re: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

Hi, Anurag Kumar Vulisha writes: > This patch fixes two issues > > 1. The code logic in dwc3_prepare_one_trb() incorrectly uses the address > and length given in req packet even for scattergather lists. This patch > correct's the code to use sg->address and

Re: [PATCH 8/9] usb: host: xhci-rcar: add support for r8a77965

On 16.03.2018 16:38, Greg KH wrote: On Fri, Mar 16, 2018 at 04:33:05PM +0200, Mathias Nyman wrote: From: Yoshihiro Shimoda This patch adds support for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda Reviewed-by: Rob

[PATCH] ACPI / PM: allow deeper wakeup power states with no _SxD nor _SxW

acpi_dev_pm_get_state() is used to determine the range of allowable device power states when going into S3 suspend. This is implemented by executing the _S3D and _S3W ACPI methods. Linux follows the ACPI spec behaviour in that when _S3D is implemented and _S3W is not, Linux will not go into a

[PATCH 1/1] usb: musb: gadget: misplaced out of bounds check

musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- drivers/usb/musb/musb_gadget_ep0.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

This patch fixes two issues 1. The code logic in dwc3_prepare_one_trb() incorrectly uses the address and length given in req packet even for scattergather lists. This patch correct's the code to use sg->address and sg->length when scattergather lists are present. 2. The present code correctly

Re: [PATCH usb-next v10 3/8] usb: core: add a wrapper for the USB PHYs on the HCD

Hi, On Sun, 2018-03-18 at 23:29 +0100, Martin Blumenstingl wrote: > Hi Roger, > > On Fri, Mar 16, 2018 at 3:32 PM, Roger Quadros wrote: > > +some TI folks > > > > Hi Martin, > > > > On 18/02/18 20:44, Martin Blumenstingl wrote: > >> Many SoC platforms have separate devices for the