Re: [Regression] xhci: some hard drives cannot be seen using a JMicron JMS56x enclosure

Hello, On 03/07/18 17:16, Mathias Nyman wrote: > I can try to write a workaround that sets dequeue pointers for both the > stream we want, and > the current active stream for each URB canceling. Is there a branch from which I could pull the workaround and test it? Regards, Cyril Roelandt. --

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 06:08:07PM -0700, Andrew Chant wrote: > >> +"New USB device found, idVendor=%04x, idProduct=%04x, > >> bcdDevice=%04x\n", > > Can you please decode bcdDevice into a decimal string? > > > > lsusb -v does this (bcdDevice: 0.03 for example) and in my

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung

Re: [PATCH v6 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Fri, 2018-03-23 at 09:54 +0200, Felipe Balbi wrote: > Hi, > > Benjamin Herrenschmidt writes: > > > The Aspeed BMC SoCs support a "virtual hub" function. It provides some > > HW support for a top-level USB2 hub behind which sit 5 gadget "ports". > > > > This driver

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:48 PM, Andrew Chant wrote: > On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: >> Print bcdDevice which is used by vendors to identify different versions >> of the same product (or different versions of firmware). >> >> Adding

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Signed-off-by: Benson

[PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Signed-off-by: Benson Leung --- drivers/usb/core/hub.c | 16 +--- 1

Re: [PATCH v3] usb: dwc2: dwc2_vbus_supply_init: fix error check

Hi Tomeu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on next-20180323] [cannot apply to v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH 0/4] net: drivers/net: Use octal permissions

Using octal and not symbolic permissions is preferred by many as more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than getting these piecemeal, just do them all. Done with checkpatch and some typing. Joe Perches (4): ethernet: Use octal not symbolic permissions wireless: Use octal

[PATCH 4/4] drivers/net: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches --- drivers/net/bonding/bond_procfs.c | 2 +-

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

On Fri 2018-03-23 12:35:21, Sebastian Reichel wrote: > Hi, > > On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > > Hi! > > > > > > > Do you have the related dts patches picked from next? > > > > > > > > > > fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming") > > > > >

[PATCH 1/2] usb: core: Copy parameter string correctly and remove superfluous null check

strsep() slices string, so the string gets copied by param_set_copystring() at the end of quirks_param_set() is not the original value. Fix that by calling param_set_copystring() earlier. The null check for val is unnecessary, the caller of quirks_param_set() does not pass null string. Remove the

[PATCH 2/2] usb: core: Add USB_QUIRK_DELAY_CTRL_MSG to usbcore quirks

There's a new quirk, USB_QUIRK_DELAY_CTRL_MSG. Add it to usbcore quirks for completeness. Signed-off-by: Kai-Heng Feng --- Documentation/admin-guide/kernel-parameters.txt | 4 +++- drivers/usb/core/quirks.c | 3 +++ 2 files changed, 6

Re: [PATCH] usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue

Hi Felipe, On Fri, Mar 23, 2018 at 10:05:33AM -0700, Jack Pham wrote: > dwc3_ep_dequeue() waits for completion of End Transfer command > using wait_event_lock_irq(), which will release the dwc3->lock > while waiting and reacquire after completion. This allows a > potential race condition with

Possible deadlock due to double spinlock in /drivers/usb/gadget/function/f_hid

For some reason, Tuba can't seem to post to linux-usb@vger, so I'm forwarding on his message below. Felipe, sorry if you have seen this 3+ times already :( thanks, greg k-h On Fri, Mar 23, 2018 at 01:05:28PM +, Yavuz, Tuba wrote: > > Hello, > > It looks like there is a deadlock

[PATCH] usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue

From: Mayank Rana dwc3_ep_dequeue() waits for completion of End Transfer command using wait_event_lock_irq(), which will release the dwc3->lock while waiting and reacquire after completion. This allows a potential race condition with ep_disable() which also removes all

[PATCH v2 5/5] usb: typec: tcpm: remove max_snk_mv/ma/mw

Since there is no user of max_snk_*, so we can remove them from tcpm. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 12 include/linux/usb/tcpm.h | 9 - 2 files changed, 21 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c

[PATCH v2 4/5] usb: typec: wcove: remove max_snk_* for sink config

Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun --- drivers/usb/typec/typec_wcove.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/typec/typec_wcove.c

[PATCH v2 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

Remove max-sink-* properties since they are deprecated. Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt

[PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 51 +++-- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git

[PATCH v2 0/5] usb: typec: remove max_snk_mv/ma/mw

This patch set is to remove max_snk_mv/ma/mw configs, as we should define the sink capability by sink PDOs, the first patch update the source PDO match policy by compare the voltage range between source and sink PDOs no matter what type they are, the following patchs remove those 3 variables from

[PATCH v2 1/5] usb: typec: tcpm: pdo matching optimization

This patch is a combination of commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") and source pdo selection optimization based on it, instead of only compare between the same pdo type of sink and source, we should check source pdo voltage range is within the voltage range of one sink

[hid:for-4.17/upstream 10/10] drivers//hid/hid-multitouch.c:379:8: error: 'struct mt_device' has no member named 'initial_quirks'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.17/upstream head: f6e9683c937e2246bbc1e7e8582ec71d6494f1f0 commit: f6e9683c937e2246bbc1e7e8582ec71d6494f1f0 [10/10] HID: core: reset the quirks before calling probe again config: i386-randconfig-x000-201811 (attached

Re: [hid:for-4.17/multitouch 1/3] drivers/hid/hid-multitouch.c:332:4: error: 'MT_QUIRK_WIN8_PTP_BUTTONS' undeclared here (not in a function); did you mean 'MT_QUIRK_IGNORE_DUPLICATES'?

On Fri, 23 Mar 2018, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git > for-4.17/multitouch > head: 1816c671e130e35707320987b1385387b4fc3085 > commit: 2bd739551fa216c637c81e10a5d0bb39b5d0d707 [1/3] HID: multitouch: > remove dead zones of Razer

[hid:for-4.17/multitouch 1/3] drivers/hid/hid-multitouch.c:332:4: error: 'MT_QUIRK_WIN8_PTP_BUTTONS' undeclared here (not in a function); did you mean 'MT_QUIRK_IGNORE_DUPLICATES'?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.17/multitouch head: 1816c671e130e35707320987b1385387b4fc3085 commit: 2bd739551fa216c637c81e10a5d0bb39b5d0d707 [1/3] HID: multitouch: remove dead zones of Razer Blade Stealth config: i386-randconfig-x014-201811

Re: [PATCH] HID: usbhid: extend the polling interval configuration to keyboards

On Wed, 21 Mar 2018, Filip Alac wrote: > For mouse and joystick devices user can change the polling interval > via usbhid.mousepoll and usbhid.jspoll. > Implement the same thing for keyboards, so user can > reduce(or increase) input latency this way. > > This has been tested with a Cooler Master

Re: [PATCH v2] usb: do not reset if a low-speed or full-speed device timed out

My "0cf3:3004 Qualcomm Atheros Communications AR3012 Bluetooth 4.0" work correct only with this patch. On vanilla kernel this device can work long time or can stop at once boot with log "hci0 command 0x041f tx timeout". Hex number can be different. Many users report this bug.

[PATCH] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

This is needed to support the modem found in HP EliteBook 820 G3. Signed-off-by: Torsten Hilbrich --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index

Re: [PATCH v2] usb: do not reset if a low-speed or full-speed device timed out

On Thu, Jan 04, 2018 at 09:43:03PM +0300, Maxim Moseychuk wrote: > Some low-speed and full-speed devices (for example, bluetooth) > do not have time to initialize. For them, ETIMEDOUT is a valid error. > We need to give them another try. Otherwise, they will > never be initialized correctly and in

Re: [GIT PULL] USB: changes for v4.17 merge window

On Fri, Mar 23, 2018 at 01:03:30PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's my big(-ish) pull request for v4.17 merge window. I tested what I > could with a GLK board. > > Let me know if you want anything to be changed. I did a test merge here > and everything was fine. Nope, all

[PATCH 26/30] media: zr364xx: avoid casting just to print pointer address

Instead of casting, just use %p. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/zr364xx/zr364xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c index

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

Hi, On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > Hi! > > > > > Do you have the related dts patches picked from next? > > > > > > > > fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming") > > > > e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY") > >

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

(please configure your email client to break lines at 80 columns ;-) Hi, Anurag Kumar Vulisha writes: > Hi Felipe, > > Thanks for reviewing the patch , please find my comments inline no issues :-) >>Anurag Kumar Vulisha writes: >>> This

[PATCH v7 0/6] typec: tcpm: Add sink side support for PPS

This patch set adds sink side support for the PPS feature introduced in the USB PD 3.0 specification. The source PPS supply is represented using the Power Supply framework to provide access and control APIs for dealing with it's operating voltage and current, and switching between a standard PDO

[PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI

This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages

This commit adds sink side support for Get_Status, Status, Get_PPS_Status and PPS_Status handling. As there's the potential for a partner to respond with Not_Supported, handling of this message is also added. Sending of Not_Supported is added to handle messagescreceived but not yet handled.

[GIT PULL] USB: changes for v4.17 merge window

Hi Greg, here's my big(-ish) pull request for v4.17 merge window. I tested what I could with a GLK board. Let me know if you want anything to be changed. I did a test merge here and everything was fine. cheers The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb:

[PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply

This commit adds a power_supply class instance to represent a PD source's voltage and current properties. This provides an interface for reading these properties from user-space or other drivers. For PPS enabled Sources, this also provides write access to set the current and voltage and allows

[PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: Heikki

[PATCH v7 3/6] power: supply: Add error checking of psy desc during registration

Currently there's no error checking of this parameter in the registration function and it's blindly added to psy class and subsequently used as is. For example if this is NULL the call to psy_register_thermal() will try to dereference the pointer thus causing a kernel dump. This commit updates

[PATCH v7 4/6] power: supply: Add 'usb_type' property and supporting code

This commit adds the 'usb_type' property to represent USB supplies which can report a number of different types based on a connection event. Examples of this already exist in drivers whereby the existing 'type' property is updated, based on an event, to represent what was connected (e.g. USB,

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

Hi! > > > Do you have the related dts patches picked from next? > > > > > > fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming") > > > e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY") > > > > > > But yeah all you need to do is have phy-mapphone-mdm6600 and > > >

RE: [PATCH 1/5] usb: typec: tcpm: source pdo selection update

Hi > -Original Message- > From: Jun Li > Sent: 2018年3月21日 19:14 > To: Hans de Goede ; gre...@linuxfoundation.org; > robh...@kernel.org; mark.rutl...@arm.com; > heikki.kroge...@linux.intel.com; li...@roeck-us.net; rmf...@gmail.com; > yueyao@gmail.com > Cc:

Re: [GIT PULL] USB-serial fixes for v4.16-rc7

On Fri, Mar 23, 2018 at 10:28:57AM +0100, Johan Hovold wrote: > On Fri, Mar 23, 2018 at 10:25:13AM +0100, Greg Kroah-Hartman wrote: > > On Fri, Mar 23, 2018 at 09:52:41AM +0100, Johan Hovold wrote: > > > Hi Greg, > > > > > > Here are some new device id for -rc7 unless you prefer to hold them off

Re: [GIT PULL] USB-serial fixes for v4.16-rc7

On Fri, Mar 23, 2018 at 10:25:13AM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 23, 2018 at 09:52:41AM +0100, Johan Hovold wrote: > > Hi Greg, > > > > Here are some new device id for -rc7 unless you prefer to hold them off for > > 4.17-rc1. > > Can I just pull this into my usb-next branch for

Re: [GIT PULL] USB-serial fixes for v4.16-rc7

On Fri, Mar 23, 2018 at 09:52:41AM +0100, Johan Hovold wrote: > Hi Greg, > > Here are some new device id for -rc7 unless you prefer to hold them off for > 4.17-rc1. Can I just pull this into my usb-next branch for 4.17-rc1? They really aren't all that high of a priority, right? thanks, greg

AW: [PATCH v2] net-usb: add qmi_wwan if on lte modem wistron neweb d18q1

Johan thanks again. As I told you currently the option is only an auxiliary IF. What is really needed is the qmi_wwan interface. I prefer to add the option patch later on (testing it). Bye. Giuseppe. > -Ursprüngliche Nachricht- > Von: Johan Hovold [mailto:jhov...@gmail.com] Im Auftrag

Re: [PATCH v2] net-usb: add qmi_wwan if on lte modem wistron neweb d18q1

On Fri, Mar 23, 2018 at 09:55:38AM +0100, Giuseppe Lippolis wrote: > Johan thanks for your advices. > Currently I don't have the opportunity to test the patch on a > linux-next system. > Therefore I will apply now the patch only for the qmi_wwan IF only and > I will wait the option backport/update

[PATCH v2] net-usb: add qmi_wwan if on lte modem wistron neweb d18q1

Johan thanks for your advices. Currently I don't have the opportunity to test the patch on a linux-next system. Therefore I will apply now the patch only for the qmi_wwan IF only and I will wait the option backport/update on my system to send the option patch. For this device the option IF is an

[PATCH v2] net-usb: add qmi_wwan if on lte modem wistron neweb d18q1

This modem is embedded on dlink dwr-921 router. The oem configuration states: T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1435 ProdID=0918 Rev= 2.32 S: Manufacturer=Android

[GIT PULL] USB-serial fixes for v4.16-rc7

Hi Greg, Here are some new device id for -rc7 unless you prefer to hold them off for 4.17-rc1. Thanks, Johan The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) are available in the Git repository at:

Re: [bug report] usb: core: Add "quirks" parameter for usbcore

On Fri, Mar 23, 2018 at 02:16:23PM +0800, Kai-Heng Feng wrote: > Hi Dan, > > Dan Carpenter wrote: > > > Hello Kai-Heng Feng, > > > > This is a semi-automatic email about new static checker warnings. > > I ran Smatch but didn't see the error message: > $ make

Re: [PATCH v6 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

Hi, Benjamin Herrenschmidt writes: > The Aspeed BMC SoCs support a "virtual hub" function. It provides some > HW support for a top-level USB2 hub behind which sit 5 gadget "ports". > > This driver adds support for the full functionality, emulating the > hub standard

Re: [bug report] usb: core: Add "quirks" parameter for usbcore

Hi Dan, Dan Carpenter wrote: Hello Kai-Heng Feng, This is a semi-automatic email about new static checker warnings. I ran Smatch but didn't see the error message: $ make -j`nproc` CHECK="~/smatch/smatch -p=kernel" C=1 bzImage modules | tee warns.txt`" Also,