Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 14:36 GMT+09:00 Felipe Balbi : > > Hi, > > Masahiro Yamada writes: >> Currently, DWC3 core IP (drivers/usb/dwc3/core.c) >> can take only one PHY phandle for each of SS, HS. >> (phy-names DT property is "usb2-phy" and

Re: Multiple generic PHY instances for DWC3 USB IP

Hi, Masahiro Yamada writes: > Currently, DWC3 core IP (drivers/usb/dwc3/core.c) > can take only one PHY phandle for each of SS, HS. > (phy-names DT property is "usb2-phy" and "usb3-phy" for each) We never had any other requirements :-) > The DWC3 core IP is

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 19:35 GMT+09:00 Vivek Gautam : > > > On 4/3/2018 3:49 PM, Masahiro Yamada wrote: >> >> 2018-04-03 17:46 GMT+09:00 Philipp Zabel : >>> >>> On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: 2018-04-03 17:00 GMT+09:00

Handling custom device control requests in userspace

Hi all, I've been looking for a way to handle custom device targeted control requests from userspace. This would allow us to move away from needing kernel patches to implement https://source.android.com/devices/accessories/aoa. It seems like we are close to being able to do this. With the flag

[PATCH v2] lan78xx: Connect phy early

When using wicked with a lan78xx device attached to the system, we end up with ethtool commands issued on the device before an ifup got issued. That lead to the following crash: Unable to handle kernel NULL pointer dereference at virtual address 039c pgd = 800035b3

Re: [PATCH 4.4 068/134] usb: dwc2: Make sure we disconnect the gadget state

On Sun, Apr 01, 2018 at 04:49:45PM +0100, Ben Hutchings wrote: > On Mon, 2018-03-19 at 19:05 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > -- > > > > From: John Stultz > > > > >

Re: [PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

Hi Grigor, Am 03.04.2018 um 13:21 schrieb Grigor Tovmasyan: Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. AFAIK Minas Harutyunyan is the new maintainer of dwc2. So this series should go to him. Regards Stefan

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

On 04/03/2018 12:56 AM, Greg KH wrote: > On Mon, Apr 02, 2018 at 02:52:31PM -0600, Shuah Khan wrote: >> vhci_hcd module can be removed even when devices are attached. Fix to >> prevent module removal when devices are still attached. >> >> Signed-off-by: Shuah Khan >> ---

Re: [PATCH v2 0/5] usb: typec: remove max_snk_mv/ma/mw

Hi, On 23-03-18 15:58, Li Jun wrote: This patch set is to remove max_snk_mv/ma/mw configs, as we should define the sink capability by sink PDOs, the first patch update the source PDO match policy by compare the voltage range between source and sink PDOs no matter what type they are, the

Re: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

Hi, On 23-03-18 15:58, Li Jun wrote: Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 51 +++-- 1 file changed, 37

Re: [PATCH v2 1/5] usb: typec: tcpm: pdo matching optimization

Hi, On 23-03-18 15:58, Li Jun wrote: This patch is a combination of commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") and source pdo selection optimization based on it, instead of only compare between the same pdo type of sink and source, we should check source pdo voltage range

Re: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

On 04/03/2018 12:56 AM, Greg KH wrote: > On Mon, Apr 02, 2018 at 02:52:32PM -0600, Shuah Khan wrote: >> vhci_hcd fails to do reset to put usb device and sockfd in the >> module remove/stop paths. Fix the leak. >> >> Signed-off-by: Shuah Khan > > Should this be marked for

Multiple generic PHY instances for DWC3 USB IP

Hi. Currently, DWC3 core IP (drivers/usb/dwc3/core.c) can take only one PHY phandle for each of SS, HS. (phy-names DT property is "usb2-phy" and "usb3-phy" for each) The DWC3 core IP is provided by Synopsys, but some SoC-dependent parts (a.k.a glue-layer) are implemented by SoC venders. The

Re: [PATCH v1] usb: dwc2: Fix kernel doc's warnings.

On 4/3/2018 5:10 PM, Grigor Tovmasyan wrote: > On 4/3/2018 4:41 PM, Greg Kroah-Hartman wrote: >> On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: >>> Added descriptions for all not described parameters. >>> Fix all kernel doc's warnings. >>> >>> Signed-off-by: Grigor Tovmasyan

[PATCH v2] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan --- Changes from version 1: Fix minor kernel-doc style issue. Changes from version 0: Rebased to balbi/next. Fixed new kernel-doc warnings which cames

Re: [PATCH v1] usb: dwc2: Fix kernel doc's warnings.

On 4/3/2018 4:41 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: >> Added descriptions for all not described parameters. >> Fix all kernel doc's warnings. >> >> Signed-off-by: Grigor Tovmasyan >> --- >> >> Changes from

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

On Tue, 03 Apr 2018, Masahiro Yamada wrote: > 2018-04-03 17:03 GMT+09:00 Lee Jones : > > On Mon, 02 Apr 2018, Andrew Lunn wrote: > > > >> On Mon, Apr 02, 2018 at 10:21:01PM +0900, Masahiro Yamada wrote: > >> > 2018-04-02 21:04 GMT+09:00 Andrew Lunn : > >> >

Re: [PATCH v1] usb: dwc2: Fix kernel doc's warnings.

On Tue, Apr 03, 2018 at 03:28:22PM +0400, Grigor Tovmasyan wrote: > Added descriptions for all not described parameters. > Fix all kernel doc's warnings. > > Signed-off-by: Grigor Tovmasyan > --- > > Changes from version 0: > > Rebased to balbi/next. > Fixed new

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

2018-04-03 17:03 GMT+09:00 Lee Jones : > On Mon, 02 Apr 2018, Andrew Lunn wrote: > >> On Mon, Apr 02, 2018 at 10:21:01PM +0900, Masahiro Yamada wrote: >> > 2018-04-02 21:04 GMT+09:00 Andrew Lunn : >> > >> The maintainer of DWC3, Felipe Balbi, requested to >> >

[PATCH v1] usb: dwc2: Fix kernel doc's warnings.

Added descriptions for all not described parameters. Fix all kernel doc's warnings. Signed-off-by: Grigor Tovmasyan --- Changes from version 0: Rebased to balbi/next. Fixed new kernel-doc warnings which cames from new patches. --- drivers/usb/dwc2/core.c | 7 ++

[PATCH 2/2] usb: dwc2: gadget: Change default values

Change default values of LPM parameters to avoid "dwc2_check_params: Invalid parameter" warnings when harwere did not support LPM feature. Cc: Stefan Wahren Signed-off-by: Grigor Tovmasyan --- drivers/usb/dwc2/params.c | 8 1 file

[PATCH 1/2] usb: dwc2: gadget: Fix coverity issue

When _param is unsigned and the minimum value of range is 0, it gives the following warning: COVERITY NO_EFFECT: This less-than-zero comparison of an unsigned value is never true. Converting ._param to int to avoid this warning. Signed-off-by: Grigor Tovmasyan ---

[PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Grigor Tovmasyan (2): usb: dwc2: gadget: Fix coverity issue usb: dwc2: gadget: Change default values drivers/usb/dwc2/params.c | 10 +- 1 file changed, 5

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

On 4/3/2018 3:49 PM, Masahiro Yamada wrote: 2018-04-03 17:46 GMT+09:00 Philipp Zabel : On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: 2018-04-03 17:00 GMT+09:00 Philipp Zabel : On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 17:46 GMT+09:00 Philipp Zabel : > On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: >> 2018-04-03 17:00 GMT+09:00 Philipp Zabel : >> > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: >> > > This driver handles the reset

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

Hi, On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > This allows dual-role ports to be reported as having gadget mode by > > > the > > >

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: > 2018-04-03 17:00 GMT+09:00 Philipp Zabel : > > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: > > > This driver handles the reset control in a common manner; deassert > > > resets before use, assert them

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 17:00 GMT+09:00 Philipp Zabel : > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: >> This driver handles the reset control in a common manner; deassert >> resets before use, assert them after use. There is no good reason >> why it should be exclusive.

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

On 28.03.2018 18:06, Li Jun wrote: > Add bingdings supported by current typec driver, so user can pass > all those properties via dt. > > Signed-off-by: Li Jun > --- > .../bindings/connector/usb-connector.txt | 39 > ++ > 1 file changed, 39

Re: [Question] MFD driver that handles clocks/resets and populates child nodes

On Mon, 02 Apr 2018, Andrew Lunn wrote: > On Mon, Apr 02, 2018 at 10:21:01PM +0900, Masahiro Yamada wrote: > > 2018-04-02 21:04 GMT+09:00 Andrew Lunn : > > >> The maintainer of DWC3, Felipe Balbi, requested to > > >> split the glue layer driver into small parts such as > > >>

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: > This driver handles the reset control in a common manner; deassert > resets before use, assert them after use. There is no good reason > why it should be exclusive. Is this preemptive cleanup, or do you have hardware on the horizon that

Re: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

On Mon, Apr 02, 2018 at 02:52:32PM -0600, Shuah Khan wrote: > vhci_hcd fails to do reset to put usb device and sockfd in the > module remove/stop paths. Fix the leak. > > Signed-off-by: Shuah Khan Should this be marked for the stable kernels? thanks, greg k-h -- To

Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached

On Mon, Apr 02, 2018 at 02:52:31PM -0600, Shuah Khan wrote: > vhci_hcd module can be removed even when devices are attached. Fix to > prevent module removal when devices are still attached. > > Signed-off-by: Shuah Khan > --- > drivers/usb/usbip/vhci_sysfs.c | 25

[PATCH] usb: gadget: udc-xilinx: Add clock support

From: Shubhrajyoti Datta Currently the driver depends on the bootloader to enable the clocks. Add support for clocking. The patch enables the clock at probe and disables them at remove. Signed-off-by: Shubhrajyoti Datta ---