Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-05-31 Thread Thinh Nguyen
Hi, On 5/30/2018 11:49 PM, Felipe Balbi wrote: > Paul Zimmerman writes: > >> Hi Felipe, >> >> Felipe Balbi writes: >> >> < snip > >> >>> thinking about this a little more. This extra list_empty() check is >>> not wrong at all :-) I've amended this series with the 3 patches >>> below. I'll

Re: [Query] checking hub port status while USB 2.0 port is resuming.

2018-05-31 Thread Alan Stern
On Thu, 31 May 2018, Anshuman Gupta wrote: > > + resuming_ports = hcd->driver->get_resuming_ports(hcd); > > + for (i = 0; i < hdev->maxchild; ++i) { > > + if (test_bit(i, _ports)) { > > + struct usb_port *port_dev = hub->ports[i]; >

Re: bogus optimal IO sizes for ASMedia ASM105x

2018-05-31 Thread Alan Stern
On Thu, 31 May 2018, Christoph Anton Mitterer wrote: > (forwarded from: https://bugzilla.kernel.org/show_bug.cgi?id=199759) > > Hi. > > > I have some USB/SATA bridges from Inatek apparently based on different > chipset generations: ... > Apparently the optimal IO sizes reported by the

bogus optimal IO sizes for ASMedia ASM105x

2018-05-31 Thread Christoph Anton Mitterer
(forwarded from: https://bugzilla.kernel.org/show_bug.cgi?id=199759) Hi. I have some USB/SATA bridges from Inatek apparently based on different chipset generations: My older ones: May 11 22:41:08 heisenberg kernel: usb 4-2.2: new SuperSpeed USB device number 10 using xhci_hcd May 11 22:41:08

Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

2018-05-31 Thread Mats Karrman
Hi, After bisecting usb-next starting from tag 'v4.16' to current head I found that the commit:    commit 4e88d4c083016454f179686529ae65d70b933b58    Author: Martin Blumenstingl    Date:   Sat Mar 3 22:43:03 2018 +0100        usb: add a flag to skip PHY initialization to struct usb_hcd

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-05-31 Thread Johan Hovold
On Thu, May 31, 2018 at 04:45:52PM +0200, Johan Hovold wrote: > The clocks have already been explicitly disabled and put as part of > remove() so the runtime suspend callback must not be run when balancing > the runtime PM usage count before returning. > > Fixes: 16adc674d0d6 ("usb: dwc3: add

[PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-05-31 Thread Johan Hovold
The clocks have already been explicitly disabled and put as part of remove() so the runtime suspend callback must not be run when balancing the runtime PM usage count before returning. Fixes: 16adc674d0d6 ("usb: dwc3: add generic OF glue layer") Signed-off-by: Johan Hovold --- Changes in v2 -

Re: [PATCH 02/22 v2] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 06:16:27AM -0700, Guenter Roeck wrote: > On 05/31/2018 04:08 AM, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different

Re: [PATCH 02/22 v2] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

2018-05-31 Thread Guenter Roeck
On 05/31/2018 04:08 AM, Greg Kroah-Hartman wrote: When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the fsusb302 driver to not care if the root directory

[bug report] usb: musb: break the huge isr musb_stage0_irq() into small functions

2018-05-31 Thread Dan Carpenter
Hello Bin Liu, The patch bcb8fd3a2fba: "usb: musb: break the huge isr musb_stage0_irq() into small functions" from May 21, 2018, leads to the following static checker warning: drivers/usb/musb/musb_core.c:825 musb_handle_intr_disconnect() warn: variable dereferenced before check

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Teichmann, Martin
Hi Greg, Hi everybody, being the original author of this patch: no. It is wrong. Greetings Martin - Original Message - From: "Greg KH" To: "Johan Hovold" Cc: "Teichmann, Martin" , "linux-usb" Sent: Thursday, 31 May, 2018 12:39:41 Subject: Re: [PATCH] ftdi_sio: add Id for Physik

Re: [PATCH] usb: dwc2: Fix host exit from hibernation flow.

2018-05-31 Thread Minas Harutyunyan
Acked-by: Minas Harutyunyan On 5/23/2018 5:25 PM, Artur Petrosyan wrote: > In case when a hub is connected to DWC2 host > auto suspend occurs and host goes to > hibernation. When any device connected to hub > host hibernation exiting incorrectly. > > - Added dwc2_hcd_rem_wakeup() function call

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Greg KH
On Thu, May 31, 2018 at 01:24:52PM +0200, Johan Hovold wrote: > On Thu, May 31, 2018 at 12:39:41PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > > > This adds support for the Physik Instrumente E-870 PIShift Drive > > > Electronics, a

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Johan Hovold
On Thu, May 31, 2018 at 12:39:41PM +0200, Greg Kroah-Hartman wrote: > On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > > This adds support for the Physik Instrumente E-870 PIShift Drive > > Electronics, a Piezo motor driver. > > > > Signed-off-by: Martin Teichmann > > --- > >

[PATCH 02/22 v2] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

2018-05-31 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the fsusb302 driver to not care if the root directory was created, as the code should work properly either

Re: [PATCH 01/22] USB: typec: tcpm: no need to check return value of debugfs_create_dir()

2018-05-31 Thread Greg Kroah-Hartman
On Wed, May 30, 2018 at 06:42:49AM -0700, Guenter Roeck wrote: > On 05/30/2018 03:36 AM, Greg Kroah-Hartman wrote: > > On Wed, May 30, 2018 at 01:30:20PM +0300, Heikki Krogerus wrote: > > > +Guenter > > > > > > On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote: > > > > When

Re: [PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

2018-05-31 Thread Greg Kroah-Hartman
On Wed, May 30, 2018 at 08:20:50PM +0200, Alexandre Belloni wrote: > On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something

Re: [PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

2018-05-31 Thread Greg Kroah-Hartman
On Wed, May 30, 2018 at 01:58:18AM +, Peter Chen wrote: > > > > > When calling debugfs functions, there is no need to ever check the return > > value. The > > function can work or not, but the code logic should never do something > > different > > based on this. > > > > Cc: Peter Chen

Re: [PATCH 21/22] USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions

2018-05-31 Thread Greg Kroah-Hartman
On Wed, May 30, 2018 at 07:38:24AM +, Yoshihiro Shimoda wrote: > > From: Greg Kroah-Hartman, Sent: Wednesday, May 30, 2018 12:31 AM > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never

[PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB

2018-05-31 Thread Manu Gautam
Move from dwc3-of-simple to dwc3-qcom glue driver to support peripheral mode which requires qscratch wrapper programming on VBUS event. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Signed-off-by: Manu Gautam --- Changes since v1: - Update unit address of DT node as per

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

2018-05-31 Thread Greg KH
On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > This adds support for the Physik Instrumente E-870 PIShift Drive > Electronics, a Piezo motor driver. > > Signed-off-by: Martin Teichmann > --- > drivers/usb/serial/ftdi_sio.c | 1 + > drivers/usb/serial/ftdi_sio_ids.h | 1

Re: [GIT PULL] USB-serial updates for v4.18-rc1

2018-05-31 Thread Greg Kroah-Hartman
On Thu, May 31, 2018 at 11:24:13AM +0200, Johan Hovold wrote: > The following changes since commit 6da6c0db5316275015e8cc2959f12a17584aeb64: > > Linux v4.17-rc3 (2018-04-29 14:17:42 -0700) > > are available in the Git repository at: > >

Re: [PATCH 16/22] USB: dwc3: no need to check return value of debugfs_create functions

2018-05-31 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Acked-by: Felipe

[GIT PULL] USB-serial updates for v4.18-rc1

2018-05-31 Thread Johan Hovold
The following changes since commit 6da6c0db5316275015e8cc2959f12a17584aeb64: Linux v4.17-rc3 (2018-04-29 14:17:42 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.18-rc1 for you to fetch changes up to

Re: [PATCH v3 0/3] Revised Renesas uPD72020x workaround for 32bit DMA issue

2018-05-31 Thread Faiz Abbas
Hi, On Wednesday 23 May 2018 11:11 PM, Marc Zyngier wrote: > Back around the 4.13 timeframe, we tried to address a rather bad issue > with the Renesas uPD72020x USB3 controller family. They have trouble > with the programming of the base addresses which tend to stick on XHCI > reset. This makes

Re: [PATCH v2] usb: xhci: force all memory allocations to node

2018-05-31 Thread Mathias Nyman
On 30.05.2018 22:05, Adam Wallis wrote: Mathias, On 5/22/2018 2:55 PM, Adam Wallis wrote: The xhci driver forces DMA memory to be node aware, however, there are several ring-related memory allocations that are not memory node aware. This patch resolves those *alloc functions to be allocated on

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

2018-05-31 Thread Felipe Balbi
Hi, Paul Zimmerman writes: > Hi Felipe, > > Felipe Balbi writes: > > < snip > > >> thinking about this a little more. This extra list_empty() check is >> not wrong at all :-) I've amended this series with the 3 patches >> below. I'll resend the series once I've given more time for people to