Re: [PATCH 1/2] ACPI / PCI: don't allow PCI devices without irq to be enabled

On Mon, Aug 12, 2013 at 4:32 PM, Bjorn Helgaas bhelg...@google.com wrote: On Mon, Aug 12, 2013 at 3:32 PM, Yinghai Lu ying...@kernel.org wrote: On Mon, Aug 12, 2013 at 2:14 PM, Bjorn Helgaas bhelg...@google.com wrote: On Thu, Aug 8, 2013 at 7:57 AM, Rafael J. Wysocki r...@sisk.pl wrote

Re: [PATCH] pci: do not try to assign irq 255

On Tue, Mar 26, 2013 at 5:34 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas bhelg...@google.com wrote: Where are we at with this? I don't see Sarah's patch in the tree, and I haven't applied any changes, so my guess is this is still broken. Yes

[PATCH 0/2] usb_bus_list_lock updates

, and I'm pretty sure that other callers (hub_quiesce() and hub_port_connect_change()) do not hold usb_bus_list_lock while calling usb_disconnect(). But I know next to nothing about the USB locking scheme. --- Bjorn Helgaas (2): USB: remove claim that usb_disconnect() acquires usb_bus_list_lock

[PATCH 1/2] USB: remove claim that usb_disconnect() acquires usb_bus_list_lock

After 9ad3d6ccf5 (USB: Remove USB private semaphore), usb_disconnect() no longer acquires usb_bus_list_lock, so remove the comment to that effect. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/usb/core/hub.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/core

[PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

usb_bus_list_lock protects the usb_bus_list, and we don't touch that list in usb_disconnect(), so there's no reason to hold the lock here. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/usb/core/hcd.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/core/hcd.c

[PATCH v2 0/2] usb_bus_list_lock updates

Comment updates for usb_bus_list_lock. Also un-EXPORT usb_bus_list_lock. --- Bjorn Helgaas (2): USB: correct the usb_disconnect() comment about usb_bus_list_lock USB: unexport usb_bus_list_lock and update comments drivers/usb/core/hcd.c |5 ++--- drivers/usb/core/hub.c |4

[PATCH v2 1/2] USB: correct the usb_disconnect() comment about usb_bus_list_lock

usb_disconnect() no longer acquires usb_bus_list_lock, so update its comment to that effect. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/usb/core/hub.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c

[PATCH v2 2/2] USB: unexport usb_bus_list_lock and update comments

usb_bus_list_lock is used by usbfs, but that's in the same module as hcd.c, so there's no need to export it. Update the comment to show that it protects the set of root hubs as well as the list of buses. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- drivers/usb/core/hcd.c |5 ++--- 1

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, Sep 13, 2013 at 2:14 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 13 Sep 2013, Bjorn Helgaas wrote: On Fri, Sep 13, 2013 at 12:25 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 13 Sep 2013, Bjorn Helgaas wrote: usb_bus_list_lock protects the usb_bus_list

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, Sep 13, 2013 at 8:11 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 13 Sep 2013, Bjorn Helgaas wrote: Thanks. Maybe this is more relevant than I thought. I'd sure like to copy your strategy rather than reinvent something. Well, I don't know if this will really end up being

Re: ehci-pci D3cold logspam

[+cc Rafael, linux-pm] On Mon, Sep 23, 2013 at 1:36 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 23 Sep 2013, Andy Lutomirski wrote: I've been getting this on several recent kernel revisions. Is it interesting? If so, I'm happy to help diagnose it. If not, can the message be

Re: [PATCH] xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers

On Mon, Sep 23, 2013 at 3:49 PM, Greg KH g...@kroah.com wrote: On Mon, Sep 23, 2013 at 09:06:54PM +0300, Xenia Ragiadakou wrote: On 09/23/2013 07:45 PM, Sarah Sharp wrote: On Fri, Sep 20, 2013 at 07:45:53PM +0300, Xenia Ragiadakou wrote: The function pci_write_config_dword() sets the

Re: [PATCH v2 2/2] USB: unexport usb_bus_list_lock and update comments

On Thu, Sep 26, 2013 at 10:45 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote: usb_bus_list_lock is used by usbfs, but that's in the same module as hcd.c, so there's no need to export it. Update the comment to show

Re: [Bisected] [-next-20130204] usb/hcd: irq 18: nobody cared

[+cc linux-acpi, linux-pci] On Mon, Feb 11, 2013 at 01:06:27PM -0800, Yinghai Lu wrote: On Mon, Feb 11, 2013 at 11:57 AM, Yinghai Lu ying...@kernel.org wrote: Bjorn, Rafael, acpi_pci_irq_add_prt need to be called after pci bridge get scanned, so we can not call it from pci_acpi_setup,

Re: [PATCH] pci: do not try to assign irq 255

On Mon, Feb 18, 2013 at 3:09 AM, Hannes Reinecke h...@suse.de wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an

Re: [PATCH] pci: do not try to assign irq 255

[+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke h...@suse.de wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer didn't feel the need to

Re: [PATCH] pci: do not try to assign irq 255

On Tue, Mar 5, 2013 at 3:41 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] 3) I don't understand why the xhci init fails in the first place. It looks like

Re: 3.8.4: ohci question

[+cc linux-usb] On Wed, Mar 27, 2013 at 11:37 AM, Udo van den Heuvel udo...@xs4all.nl wrote: Hello, When my dmesg gives me a growing number of lines like the one below, what is going on? ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 -- status -71 Please let me

Re: EHCI host broken -- interrupts disabled

On Mon, Jan 20, 2014 at 5:15 AM, Chen, Jamie jamie.c...@intel.com wrote: Try to apply this patch to kernel 3.8.0. Make sure the ehci can work fine and lspci show that PCI_COMMAND_INTX_DISABLE is 0. The patch can resolved this issue. Thanks for testing it. Can you collect the complete

Re: EHCI host broken -- interrupts disabled

On Wed, Jan 29, 2014 at 5:04 PM, Bjorn Helgaas bhelg...@google.com wrote: On Mon, Jan 20, 2014 at 5:15 AM, Chen, Jamie jamie.c...@intel.com wrote: Try to apply this patch to kernel 3.8.0. Make sure the ehci can work fine and lspci show that PCI_COMMAND_INTX_DISABLE is 0. The patch can

Re: EHCI host broken -- interrupts disabled

think I'll cherry-pick it into for-linus for v3.14. Bjorn -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] Sent: Wednesday, February 12, 2014 7:24 AM To: Chen, Jamie Cc: Alan Stern; Sarah Sharp; USB list; Tsai, Gaggery; linux-...@vger.kernel.org Subject: Re: EHCI

Re: EHCI host broken -- interrupts disabled

On Fri, Feb 14, 2014 at 3:27 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Fri, Feb 14, 2014 at 01:47:48PM -0700, Bjorn Helgaas wrote: On Fri, Feb 14, 2014 at 9:36 AM, Chen, Jamie jamie.c...@intel.com wrote: Sorry for late response. The dmesg attach in the mail. Thanks, I put

Re: [PATCH] PCI: EHCI: fix crash during suspend on ASUS computers

On Mon, Jul 9, 2012 at 10:47 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jul 09, 2012 at 06:50:24PM +0200, Rafael J. Wysocki wrote: On Monday, July 09, 2012, Alan Stern wrote: Quite a few ASUS computers experience a nasty problem, related to the EHCI controllers, when going into

Re: [PATCH] PCI: EHCI: fix crash during suspend on ASUS computers

, not into Linux-next (I should have said so explicitly in the patch). Ah, ok, if so, and Bjorn doesn't mind, I can add it to the other USB patches that I have queued up to go in before 3.5-final is released. Bjorn, want me to take it? If so, can I get your ack? Yes, please. Acked-by: Bjorn Helgaas

Re: [PATCH 1/9] pci-rcar-gen2: add devicetree support

. Ben, could you please repost anything you have outstanding for me? --- Updates since v1: - moved documentation into patch - moved to using bus-range parsing - ensured usb phy can be linked to usb devices Cc: Bjorn Helgaas bhelg...@google.com Cc: Simon Horman ho

Re: EHCI host broken -- interrupts disabled

[+cc linux-pci] On Tue, Jan 14, 2014 at 11:47 AM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 14 Jan 2014, Sarah Sharp wrote: Hi Alan, I'm not a good person to ask about this. Maybe Bjorn can help. All this info is second- or third-hand, so please excuse the extremely vague bug

Re: EHCI host broken -- interrupts disabled

On Thu, Jan 16, 2014 at 02:40:35PM -0500, Alan Stern wrote: On Thu, 16 Jan 2014, Bjorn Helgaas wrote: I think dev-irq is supposed to be valid after pci_enable_device(), so it seems like it would make sense to clear PCI_COMMAND_INTX_DISABLE there. Okay. I don't know why a BIOS would

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

On Mon, Oct 22, 2012 at 5:40 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote: Hello, I have problems to get my USB3 cardreader to work reliably when connected to the USB3 port. Due to lack of other USB3 devices I don't know

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

On Tue, Oct 23, 2012 at 11:14 AM, Ulrich Eckhardt u...@uli-eckhardt.de wrote: Am 23.10.2012 01:40, schrieb Sarah Sharp: On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote: I have tested it with Kernel 3.6.2. The USB3 port is the one built in the Mainboard M4A87DT EVO. Did a

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

On Wed, Oct 24, 2012 at 3:10 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Wednesday 24 of October 2012 14:18:40 Bjorn Helgaas wrote: On Tue, Oct 23, 2012 at 11:14 AM, Ulrich Eckhardt u...@uli-eckhardt.de wrote: Am 23.10.2012 01:40, schrieb Sarah Sharp: On Sun, Oct 21, 2012 at 06:03:24PM

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

describing how to use those tracepoints? Hi Bjorn Helgaas, Firstly, please enable these tracepoints via below echo 1 /sys/kernel/debug/tracing/events/rpm/enable then store the trace event result by below once you make sure your interested events are completed: echo 0 /sys

Re: xhci Portsc register issue

On Thu, Oct 25, 2012 at 9:36 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Thu, Oct 25, 2012 at 12:31:09PM +0530, shashank chaturvedi wrote: Hi sarah, I am using Ubuntu 11.04 OS and NEC USB3.0 Host controller. I want to write the PLS [8:5] field in the PORTSC register

Re: [PATCH v2 02/16] pci: quirks: add quirk to avoid AMD NL to bind with xhci

. In particular, PCI (not pci), drop the quirks: part, and capitalize Add. Suggested-by: Heikki Krogerus heikki.kroge...@linux.intel.com Cc: Bjorn Helgaas bhelg...@google.com Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/pci/quirks.c | 20 1 file changed, 20 insertions

Re: [PATCH v2 02/16] pci: quirks: add quirk to avoid AMD NL to bind with xhci

On Sun, Oct 26, 2014 at 8:55 PM, Huang Rui ray.hu...@amd.com wrote: On Fri, Oct 24, 2014 at 10:35:29AM -0600, Bjorn Helgaas wrote: On Fri, Oct 17, 2014 at 04:53:27PM +0800, Huang Rui wrote: +/* FIXME should define in linux/pci_ids.h */ +#define PCI_DEVICE_ID_AMD_NL 0x7912 If you

Re: [PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver

the device, change the class code to 0x0c03fe, which the PCI r3.0 spec defines as USB device (not host controller). The dwc3 driver can then claim it based on its Vendor and Device ID. Suggested-by: Heikki Krogerus heikki.kroge...@linux.intel.com Cc: Bjorn Helgaas bhelg...@google.com Acked-by: Bjorn

Re: [PATCH v3 17/19] PCI: Add support for AMD Nolan USB3 DRD

-by: Bjorn Helgaas bhelg...@google.com Please merge along with the rest of your series. --- include/linux/pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 1fa99a3..5decad7 100644 --- a/include/linux/pci_ids.h +++ b/include

Re: [PATCH v3 13/19] usb: dwc3: add tx demphasis quirk

On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui ray.hu...@amd.com wrote: This patch adds Tx demphasis quirk, and the Tx demphasis value is demphasis (above and in subject) should be de-emphasis as used in the code and comments below. configurable according to PIPE3 specification. Value

Re: [PATCH v3 05/19] usb: dwc3: add lpm erratum support

On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui ray.hu...@amd.com wrote: When parameter DWC_USB3_LPM_ERRATA_ENABLE is enabled in Andvanced Advanced Configuration of coreConsultant, it supports of xHCI BESL Errata Dated I can't parse is supports of and I don't know enough to suggest an alternate

Re: [PATCH v3 04/19] usb: dwc3: add disscramble quirk

On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui ray.hu...@amd.com wrote: This patch adds disscramble quirk, and it only needs to be enabled at fpga disscramble (in subject and above) is not a real word. I see that DWC3_GCTL_DISSCRAMBLE is already defined in drivers/usb/dwc3/core.h even before your

Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h

On Sun, Feb 15, 2015 at 6:17 PM, Joseph Kogut joseph.ko...@gmail.com wrote: Moved DWC3 PCI IDS to linux/pci_ids.h per the FIXME. Signed-off-by: Joseph Kogut joseph.ko...@gmail.com --- drivers/usb/dwc3/dwc3-pci.c | 10 +- include/linux/pci_ids.h | 8 2 files changed, 9

[PATCH 0/3] USB: PHY: minor include cleanups

Remove some gpio and regulator #includes when they can be replaced by trivial forward struct declarations. Also move a linux/gpio/consumer.h #include from a header to the single .c files that uses it. --- Bjorn Helgaas (3): usb: phy: generic: use forward declarations instead of #includes

[PATCH 1/3] usb: phy: generic: use forward declarations instead of #includes

explicitly there. This is a little more efficient and ensures that users of the gpiod interfaces include linux/gpio/consumer.h directly rather than getting it accidentally via linux/usb/usb_phy_generic.h. Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- drivers/usb/phy/phy-generic.c

[PATCH 3/3] usb: phy: phy-am335x: remove include of regulator/consumer.h

phy-am335x.c doesn't use any interfaces from linux/regulator/consumer.h, so stop including it. Signed-off-by: Bjorn Helgaas <bhelg...@google.com> CC: Sebastian Andrzej Siewior <bige...@linutronix.de> --- drivers/usb/phy/phy-am335x.c |1 - 1 file changed, 1 deletion(-) diff --g

[PATCH 2/3] usb: phy: generic: use forward declarations instead of #includes

directly rather than accidentally getting them via drivers/usb/phy/phy-generic.h. Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- drivers/usb/phy/phy-generic.h |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-generic.h b/drivers/usb/phy/phy-gen

Re: [PATCH 1/3] usb: phy: generic: use forward declarations instead of #includes

[-cc Mark] On Wed, Feb 03, 2016 at 08:18:02PM +0200, Felipe Balbi wrote: > Bjorn Helgaas <bhelg...@google.com> writes: > > In include/linux/usb/usb_phy_generic.h, use a forward declaration for > > struct gpio_desc instead of including linux/gpio/consumer.h. > > &g

Re: [PATCH] pci: Add definition for USB Device Controller PCI Class ID

On Tue, Mar 15, 2016 at 02:06:00PM +0200, Heikki Krogerus wrote: > PCI-SIG has defined Interface FEh for Base Class 0Ch, > Sub-Class 03h as "USB Device (not host controller)". It is > already being used in various USB device controller drivers > for matching, so converting those to use the

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

[+cc Rafael, Lukas] On Wed, Oct 05, 2016 at 10:45:22AM -0400, Alan Stern wrote: > [Adding Bjorn and linux-pci to the CC: list] > > In short, Pierre's USB host controller doesn't send wakeup signals from > runtime suspend, because the firmware limits the runtime-suspend state > to D0 and the

Re: [PATCH 2/2] USB: UHCI: report non-PME wakeup signalling for Intel hardware

On Sat, Oct 22, 2016 at 12:03:44PM +0200, Greg KH wrote: > On Fri, Oct 21, 2016 at 04:49:07PM -0400, Alan Stern wrote: > > The UHCI controllers in Intel chipsets rely on a platform-specific > > non-PME mechanism for wakeup signalling. They can generate wakeup > > signals even though they don't

Should xhci_irq() call usb_hc_died()?

Hi Mathias, ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code equivalent to this: status = ehci_readl(...); if (status == ~(u32) 0) { ... usb_hc_died(hcd); ... return IRQ_HANDLED; } xhci_irq() has a similar check, but does not call usb_hc_died():

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On Wed, Apr 12, 2017 at 1:13 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: John Youn writes: >> Thinh Nguyen writes: >>> The dwc3 driver can overwite its previous events if its top

Re: Neophyte questions about PCIe

On Fri, Mar 10, 2017 at 04:05:50PM +0100, Mason wrote: > On 10/03/2017 15:06, David Laight wrote: > > > Robin Murphy wrote: > > > >> On 09/03/17 23:43, Mason wrote: > >> > >>> I think I'm making progress, in that I now have a better > >>> idea of what I don't understand. So I'm able to ask > >>>

Re: Neophyte questions about PCIe

On Mon, Mar 13, 2017 at 10:57:48PM +0100, Mason wrote: > On 13/03/2017 22:40, Bjorn Helgaas wrote: > > > On Sat, Mar 11, 2017 at 11:57:56AM +0100, Mason wrote: > > > >> On 10/03/2017 18:49, Mason wrote: > >> > >>> static void tango_pcie_bar_q

Re: Neophyte questions about PCIe

On Sat, Mar 11, 2017 at 11:57:56AM +0100, Mason wrote: > On 10/03/2017 18:49, Mason wrote: > > static void tango_pcie_bar_quirk(struct pci_dev *dev) > > { > > struct pci_bus *bus = dev->bus; > > > > printk("%s: bus=%d devfn=%d\n", __func__, bus->number, dev->devfn); > > > >

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > Ard and myself have just spent quite some time lately trying to pin > down an issue in the DMA code which was taking the form of a PCIe USB3 > controller issuing a DMA access at some bizarre address, and being > caught red-handed by

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

On Thu, Jul 13, 2017 at 10:26:40AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 12, 2017 at 10:12:34PM -0500, Bjorn Helgaas wrote: > > On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > > > Ard and myself have just spent quite some time lately trying to pin &

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > Ard and myself have just spent quite some time lately trying to pin > down an issue in the DMA code which was taking the form of a PCIe USB3 > controller issuing a DMA access at some bizarre address, and being > caught red-handed by

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

On Thu, Jul 13, 2017 at 08:46:45AM +0100, Marc Zyngier wrote: > On 13/07/17 07:48, Ard Biesheuvel wrote: > > On 13 July 2017 at 04:12, Bjorn Helgaas <helg...@kernel.org> wrote: > >> On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > >>> Ard and my

Re: [PATCH 0/2] Workaround for uPD72020x USB3 chips

On Thu, Jul 13, 2017 at 10:26:40AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 12, 2017 at 10:12:34PM -0500, Bjorn Helgaas wrote: > > On Mon, Jul 10, 2017 at 04:52:28PM +0100, Marc Zyngier wrote: > > > Ard and myself have just spent quite some time lately trying to pin &

Re: [PATCH v2] PCI / PM: Avoid using device_may_wakeup() for runtime PM

On Fri, Jun 23, 2017 at 02:58:11PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > pci_target_state() calls device_may_wakeup() which checks whether > or not the device may wake up the system from sleep states, but > pci_target_state() is used for

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Mon, Jun 19, 2017 at 11:30:18AM +0800, Kai-Heng Feng wrote: > On Sat, Jun 17, 2017 at 1:30 AM, Alan Stern wrote: > > On Sat, 17 Jun 2017, Kai-Heng Feng wrote: > > > >> On Fri, Jun 16, 2017 at 11:07 AM, Kai-Heng Feng > >> wrote: > >> > On

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

On Thu, Jun 15, 2017 at 03:02:25PM +0800, Kai-Heng Feng wrote: > On Thu, Jun 15, 2017 at 2:55 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > > On Tue, 13 Jun 2017, Bjorn Helgaas wrote: > > > >> [+cc Rafael, linux-pm] > >> > >> On Tue, Jun 1

Re: [PATCH v2 6/8] PCI / PM: Restore PME Enable if skipping wakeup setup

t when it is about to return > early. > > Also, it is reasonable to expect that __pci_enable_wake() will always > clear PME Status when invoked to disable device wakeup, so make it do > so even if it is going to return early then. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso

Re: [PATCH v2 1/8] ACPI / PM: Run wakeup notify handlers synchronously

been queued up. > > Fortunately, acpi_add_pm_notifier() is only used by PCI and by > ACPI device PM code internally, so the change is relatively > straightforward to make. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Acked-by: Bjorn Helgaas <bh

Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller

[+cc Rafael, linux-pm] On Tue, Jun 13, 2017 at 12:21:15PM +0800, Kai-Heng Feng wrote: > On Mon, Jun 12, 2017 at 10:18 PM, Alan Stern > wrote: > > Let's get some help from people who understand PCI well. > > > > Here's the general problem: Kai-Heng has a PCI-based USB

Re: [PATCH v1] ACPI: Switch to use generic UUID API

m> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: Joerg Roedel <j...@8bytes.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Yisen Zhuang <yisen.zhu...@huawei.com> > Cc: Bjorn Helgaas &

[bugzilla-dae...@bugzilla.kernel.org: [Bug 197159] New: Xhci host controller not responding starting kernel 4.13]

[+cc linux-pci, linux-usb, Mason, Mathias, Lukas, Greg, Felipe, Alan] - Forwarded message from bugzilla-dae...@bugzilla.kernel.org - > > Date: Sun, 08 Oct 2017 13:28:13 + > From: bugzilla-dae...@bugzilla.kernel.org > To: bugzilla@gmail.com > Subject: [Bug 197159] New: Xhci host

Re: [PATCH v2 06/15] PCI: endpoint: make config_item_type const

ccinelle. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Bjorn Helgaas <bhelg...@google.com> Please apply this along with the rest of the series, since it depends on an earlier patch in the series. > --- > * Changes in v2- Combine all the followup patch

Re: [PATCH 08/15] PCI: make device_type const

On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied to pci/misc for v4.14, thanks! > --- >

Re: [bugzilla-dae...@bugzilla.kernel.org: [Bug 197159] New: Xhci host controller not responding starting kernel 4.13]

On Mon, Oct 09, 2017 at 10:45:39PM +0200, Mason wrote: > On 09/10/2017 19:01, Bjorn Helgaas wrote: > ... > > In that thread, Mason reported a regression that looks similar, but as > > far as I can tell, we never identified a root cause. > > > > 1) The problem

Re: [PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

[+cc Rafael, linux-pm] On Wed, Dec 06, 2017 at 12:22:42AM +0800, Kai-Heng Feng wrote: > The board in question has three XHCI HCs: > 02:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] USB 3.1 > XHCI Controller [1022:43bb] (rev 02) > 04:00.0 USB controller [0c03]: ASMedia Technology

Re: `pci_apply_final_quirks()` taking half a second

On Tue, Dec 26, 2017 at 04:55:20PM +0100, Paul Menzel wrote: > Am 08.04.2017 um 17:41 schrieb Bjorn Helgaas: > >On Fri, Apr 07, 2017 at 11:07:15PM +0200, Paul Menzel wrote: > > >>Measuring where time is spent during boot with `systemd-bootchart` > >>on an Asus A780