Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-23 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 22 Jul 2013 23:10:27 -0700 On Mon, 2013-07-22 at 20:47 +0100, Ben Hutchings wrote: The real solution would be for someone to add SG support to the usbnet core. Trying to support 1GbE with only linear skbs is not a great idea... and it can

Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A

2013-07-23 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 23 Jul 2013 17:05:10 -0700 On Tue, 2013-07-23 at 16:56 -0700, Eric Dumazet wrote: A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have this problem. Instead of the patch starting this thread, I'd like to see one

Re: [PATCH 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-24 Thread David Miller
From: hayeswang hayesw...@realtek.com Date: Tue, 23 Jul 2013 17:26:04 +0800 diff --git a/drivers/net/usb/r815x.c b/drivers/net/usb/r815x.c index 8523922..e9b99ba 100644 --- a/drivers/net/usb/r815x.c +++ b/drivers/net/usb/r815x.c @@ -24,34 +24,43 @@ static int pla_read_word(struct

Re: [PATCH] usbnet: do not pretend to support SG/TSO

2013-07-26 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Tue, 23 Jul 2013 17:15:54 -0700 From: Eric Dumazet eduma...@google.com usbnet doesn't support yet SG, so drivers should not advertise SG or TSO capabilities, as they allow TCP stack to build large TSO packets that need to be linearized and

Re: [PATCH 0/2] USBNET: max rx/tx qlen change

2013-07-27 Thread David Miller
From: Ming Lei ming@canonical.com Date: Thu, 25 Jul 2013 13:47:52 +0800 There are two patches on computing max rx/tx qlen, and fix one performance problem on USB3 NIC. Applied to net-next, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-27 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 25 Jul 2013 15:59:02 +0800 Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc to replace those one. Signed-off-by: Hayes Wang hayesw...@realtek.com I don't think it's reasonable to kmalloc() a small integer

Re: [PATCH v2 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-29 Thread David Miller
From: Oliver Neukum oneu...@suse.de Date: Mon, 29 Jul 2013 07:20:24 +0200 On Sat, 2013-07-27 at 20:21 -0700, David Miller wrote: From: Hayes Wang hayesw...@realtek.com Date: Thu, 25 Jul 2013 15:59:02 +0800 Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Tue, 30 Jul 2013 07:00:59 -0700 This call is so slow, you can afford to make a call to kmalloc for the data, as it sure just did for other structures it needed :) I told him to implement things this way, to avoid calling kmalloc every single

Re: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-30 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 30 Jul 2013 11:41:17 -0700 On Tue, 2013-07-30 at 11:33 -0700, David Miller wrote: From: Greg KH gre...@linuxfoundation.org Date: Tue, 30 Jul 2013 07:00:59 -0700 This call is so slow, you can afford to make a call to kmalloc for the data

Re: [PATCH v4 3/5] net/usb/r815x: change the return value for bind functions

2013-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 31 Jul 2013 17:21:24 +0800 Replace 0 with the result from usbnet_cdc_bind(). Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH v4 4/5] net/usb/r8152: make sure the USB buffer is DMA-able

2013-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 31 Jul 2013 17:21:25 +0800 Allocate the required memory before calling usb_control_msg. And the additional memory copy is necessary. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line

Re: [PATCH v4 5/5] net/usb/r8152: adjust relative ocp function

2013-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 31 Jul 2013 17:21:26 +0800 - fix the conversion between cpu and __le32 - replace some pla_ocp and usb_ocp functions with generic_ocp function Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send

Re: [PATCH v4 2/5] net/usb/r815x: avoid to call mdio functions for runtime-suspended device

2013-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 31 Jul 2013 17:21:23 +0800 Don't replace the usb_control_msg() with usbnet_{read,write}_cmd() which couldn't be called inside suspend/resume callback. Keep the basic functions unlimited. Instead, using usb_autopm_get_interface() and

Re: [PATCH v4 1/5] net/usb/r815x: replace USB buffer from stack to DMA-able

2013-07-31 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 31 Jul 2013 17:21:22 +0800 Some USB buffers use stack which may not be DMA-able. Use the buffers from kmalloc to replace those one. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line

Re: [PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-02 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 1 Aug 2013 16:17:46 -0700 Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Series applied to net-next, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v1 3/4] USBNET: support DMA SG

2013-08-03 Thread David Miller
From: Oliver Neukum oneu...@suse.de Date: Sat, 03 Aug 2013 07:56:53 +0200 On Sat, 2013-08-03 at 10:46 +0800, Ming Lei wrote: @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, entry = (struct skb_data *) skb-cb; entry-urb = urb; entry-dev = dev; -

Re: [PATCH net-next] ax88179_178a: avoid copy of tx tcp packets

2013-08-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 01 Aug 2013 06:52:45 -0700 On Thu, 2013-08-01 at 06:49 -0700, Eric Dumazet wrote: From: Eric Dumazet eduma...@google.com ax88179_tx_fixup() has quite complex code trying to push 8 bytes of control data (len/mss), but fails to do it

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 09 Aug 2013 10:50:36 -0700 Some compiler folk decided 'extern' were not mandatory for code, but its really adding confusion and endless discussions. I certainly stopped talking about it, you could too :-) -- To unsubscribe from this list:

Re: [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer

2013-08-09 Thread David Miller
From: Jussi Kivilinna jussi.kivili...@iki.fi Date: Wed, 07 Aug 2013 16:26:29 +0300 URB setup packet must not be allocated as part of larger structure because DMA coherence issues. Patch changes catc to allocate ctrl_dr member as separate buffer. Patch is only compile tested. Cc:

Re: [PATCH v4 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-09 Thread David Miller
From: Ming Lei ming@canonical.com Date: Thu, 8 Aug 2013 21:48:21 +0800 This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1] on the

Re: [PATCH 1/2] net: asix: Staticise non-exported symbols

2013-08-13 Thread David Miller
From: Mark Brown broo...@kernel.org Date: Fri, 9 Aug 2013 18:31:21 +0100 From: Mark Brown broo...@linaro.org Make functions that are only referenced from ops structures static, they do not need to be in the global namespace and sparse complains about this. Signed-off-by: Mark Brown

Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation

2013-08-13 Thread David Miller
From: Oliver Neukum oneu...@suse.de Date: Tue, 13 Aug 2013 17:17:10 +0200 On Tue, 2013-08-13 at 20:32 +0800, hayeswang wrote: Oliver Neukum [mailto:oneu...@suse.de] Sent: Tuesday, August 13, 2013 4:49 PM To: Hayeswang Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [PATCH net-next v2 2/3] net/usb/r8152: enable tx checksum

2013-08-15 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 14 Aug 2013 20:54:39 +0800 Enable tx checksum. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net-next v2 3/3] net/usb/r8152: enable interrupt transfer

2013-08-15 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 14 Aug 2013 20:54:40 +0800 Use the interrupt transfer to replace polling link status. Signed-off-by: Hayes Wang hayesw...@realtek.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 14 Aug 2013 20:54:38 +0800 Enable the tx/rx aggregation which could contain one or more packets for each bulk in/out. This could reduce the loading of the host controller by sending less bulk transfer. The rx packets in the bulk in buffer

Re: [PATCH net-next 1/7] r8152: remove clearing the memory to zero for netdev priv

2013-08-20 Thread David Miller
Series applied, thanks. Please, in the future, provide an initial [PATCH 0/N] posting which gives a general overview to the series, and to which I can apply when I have something to say about the series as a whole. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH] Fix stack corruption on some architectures

2013-08-21 Thread David Miller
Please submit this with a more appropriate subject line. After '[PATCH] ' there should be a subsystem or driver name prefix, followed up a semicolon. Here it could be hso: , so something like: [PATCH] hso: Fix stack corruption on some architectures. -- To unsubscribe from this list: send the

Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Wed, 21 Aug 2013 09:25:07 -0700 On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote: There is no need to get an interface specification if we know it's the wrong one. Signed-off-by: Daniel Gimpelevich

Re: [PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Wed, 21 Aug 2013 09:24:47 -0700 On Wed, Aug 21, 2013 at 01:43:19AM -0700, Daniel Gimpelevich wrote: As Sergei Shtylyov explained in the #mipslinux IRC channel: [Mon 2013-08-19 12:28:21 PM PDT] headless guys, are you sure it's not DMA off stack

Re: [PATCH 2/2] fs: use inode_set_user to set uid/gid of inode

2013-08-22 Thread David Miller
From: Rui Xiang rui.xi...@huawei.com Date: Fri, 23 Aug 2013 10:48:38 +0800 Use the new interface to set i_uid/i_gid in inode struct. Signed-off-by: Rui Xiang rui.xi...@huawei.com For the networking bits: Acked-by: David S. Miller da...@davemloft.net -- To unsubscribe from this list: send

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Enrico Mioso mrkiko...@gmail.com Date: Fri, 23 Aug 2013 09:56:29 +0200 + if ((on atomic_add_return(1, drvstate-pmcount) == 1) || (!on atomic_dec_and_test(drvstate-pmcount))) { These line significantly exceeds 80 columns. + subdriver =

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 26 Aug 2013 13:45:13 -0700 I think the premise of local variable declaration by line length is flawed. I disagree. It can't work when local variables are dependent on initialization order as above. Move the initialization below the

Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-26 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 26 Aug 2013 14:05:55 -0700 On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote: From: Joe Perches j...@perches.com Date: Mon, 26 Aug 2013 13:45:13 -0700 I think the premise of local variable declaration by line length is flawed. I

Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700 Device Driver Support

2013-08-28 Thread David Miller
From: liujunliang_...@163.com Date: Sat, 24 Aug 2013 19:26:00 +0800 From: liujl liujunliang_...@163.com Your proper name is not liujl, please put something more reasonable here and also in your Signoff. Also, integrate Joe Perches's white space fixes into this patch as part of your

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner robma...@gmail.com Date: Sun, 25 Aug 2013 18:29:13 -0600 From 018343ce2e679d97283fb51da25c43aa876d087a Mon Sep 17 00:00:00 2001 From: Rob Gardner robma...@gmail.com Date: Sun, 25 Aug 2013 16:02:23 -0600 Subject: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner robma...@gmail.com Date: Wed, 28 Aug 2013 17:18:12 -0600 Bjørn says it could have a minor performance impact, but should not cause any loss of functionality. I don't think there's any hard data on what the performance cost might be but I know he would eventually like to get

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner robma...@gmail.com Date: Wed, 28 Aug 2013 18:40:22 -0600 The exception list means usb_device_id entries for specific devices that are known to need the workaround. There are just two such entries. There isn't even a separate list. So maybe we just have a nomenclature

Re: [PATCH] net: usbnet: update addr_assign_type if appropriate

2013-08-30 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 30 Aug 2013 20:18:58 +0200 Bjørn Mork bj...@mork.no writes: This module generates a common default address on init, using eth_random_addr. Set addr_assign_type to let userspace know the address is random unless it was overridden by the minidriver.

Re: [PATCH] net: usbnet: update addr_assign_type if appropriate

2013-08-30 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 30 Aug 2013 20:56:15 +0200 David Miller da...@davemloft.net writes: From: Bjørn Mork bj...@mork.no Date: Fri, 30 Aug 2013 20:18:58 +0200 Bjørn Mork bj...@mork.no writes: This module generates a common default address on init, using

Re: [PATCH] USB2NET : SR9700 : One Chip USB 1.1 USB2NET SR9700 Device Driver Support

2013-08-30 Thread David Miller
Please integrate the fixes Francois has proposed. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support

2013-09-03 Thread David Miller
From: liujunliang_...@163.com Date: Sun, 1 Sep 2013 19:38:08 +0800 From: Liu Junliang liujunliang_...@163.com Signed-off-by: Liu Junliang liujunliang_...@163.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH] net: qmi_wwan: add new Qualcomm devices

2013-09-11 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 10 Sep 2013 15:06:20 +0200 Adding the device list from the Windows driver description files included with a new Qualcomm MDM9615 based device, Alcatel-sbell ASB TL131 TDD LTE, from China Mobile. This device is tested and verified to work. The others

Re: [PATCH 0/3] net: usb: cdc_ether: improve telit support and code cleanups

2013-09-16 Thread David Miller
From: Fabio Porcedda fabio.porce...@gmail.com Date: Mon, 16 Sep 2013 11:47:49 +0200 Some patches to improve telit modules support and to cleanup the code. Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] USBNET: fix handling padding packet

2013-09-17 Thread David Miller
From: Ming Lei ming@canonical.com Date: Tue, 17 Sep 2013 17:10:02 +0800 Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG if the usb host controller is capable of building packet from discontinuous buffers, but missed handling padding packet when building DMA SG. This

Re: [PATCH] USBNET: fix handling padding packet

2013-09-18 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 18 Sep 2013 17:52:42 +0200 Ming Lei ming@canonical.com writes: There is no reason to forbid DMA SG for one driver which requires padding, right? Yes there is: Added complexity for everybody, based on a combination of features which just does

Re: [PATCH v1] USBNET: fix handling padding packet

2013-09-28 Thread David Miller
From: Ming Lei ming@canonical.com Date: Mon, 23 Sep 2013 20:59:35 +0800 Commit 638c5115a7949(USBNET: support DMA SG) introduces DMA SG if the usb host controller is capable of building packet from discontinuous buffers, but missed handling padding packet when building DMA SG. This

Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

2013-09-30 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 25 Sep 2013 15:31:39 +0200 Sorry, I really don't see the point of this. Yes, the lines are longer than 80 columns, but breaking them don't improve the readability at all. On the contrary, IMHO. So NAK from me for this part. Sorry, breaking things

Re: [PATCH 2/2] net: qmi_wwan: fix checkpatch warnings

2013-09-30 Thread David Miller
From: Fabio Porcedda fabio.porce...@gmail.com Date: Wed, 25 Sep 2013 11:21:26 +0200 Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Applied to net-next, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/2] net: qmi_wwan: add Telit LE920 newer firmware support

2013-09-30 Thread David Miller
From: Fabio Porcedda fabio.porce...@gmail.com Date: Wed, 25 Sep 2013 11:21:25 +0200 Newer firmware use a new pid and a different interface. Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Applied to net-next -- To unsubscribe from this list: send the line unsubscribe linux-usb in the

Re: [PATCH] net: qmi_wwan: fix Cinterion PLXX product ID

2013-09-30 Thread David Miller
From: Schmiedl Christian christian.schmi...@gemalto.com Date: Thu, 26 Sep 2013 16:02:13 +0200 Aleksander Morgado aleksan...@lanedo.com writes: Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1. The blacklisting in the serial/option driver does actually use the correct PID, as

Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN

2013-10-02 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 01 Oct 2013 19:04:40 -0700 Convert the memset/memcpy uses of 6 to ETH_ALEN where appropriate. Also convert some struct definitions and u8 array declarations of [6] to ETH_ALEN. Signed-off-by: Joe Perches j...@perches.com Looks fine, applied,

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-03 Thread David Miller
From: Dr. H. Nikolaus Schaller h...@goldelico.com Date: Wed, 2 Oct 2013 09:00:18 +0200 From f5c7e15b61f2ce4fe3105ff914f6bfaf5d74af0d Mon Sep 17 00:00:00 2001 From: H. Nikolaus Schaller h...@goldelico.com Date: Thu, 15 Nov 2012 14:40:57 +0100 Subject: [PATCH 1/1] hso: fix problem with wrong

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-03 Thread David Miller
From: Dr. H. Nikolaus Schaller h...@goldelico.com Date: Thu, 3 Oct 2013 21:40:34 +0200 I have made the bug observation from debug log that this bit is set in a response each time the modem has a RING message. It might be specific to this modem and firmware version, i.e. a firmware bug. But

Re: [PATCH] usbnet: fix error return code in usbnet_probe()

2013-10-17 Thread David Miller
From: Wei Yongjun weiyj...@gmail.com Date: Sat, 12 Oct 2013 14:24:08 +0800 From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the padding pkt alloc fail error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun

Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

2013-10-17 Thread David Miller
From: Enrico Mioso mrkiko...@gmail.com Date: Tue, 15 Oct 2013 15:06:48 +0200 This is a QMI device, manufactured by TCT Mobile Phones. A companion patch blacklisting this device's QMI interface in the option.c driver has been sent. Signed-off-by: Enrico Mioso mrkiko...@gmail.com

Re: [PATCH 1/1] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-21 Thread David Miller
From: fre...@asix.com.tw Date: Mon, 21 Oct 2013 14:37:40 +0800 From: Freddy Xin fre...@asix.com.tw Correct the definition of AX_RXHDR_CRC_ERR and AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr seperately. Add VID:DID for Samsung USB Ethernet Adapter. Signed-off-by: Freddy Xin

Re: [PATCH 1/1] [PATCH resubmit] ax88179_178a: Correct the RX error definition in RX header

2013-10-22 Thread David Miller
Submit these, not individually as single patches, but as a patch set, the first one with subject [PATCH 1/2] and the second with subject [PATCH 2/2] You have to do this, because it is absolutely essentially to let me know which patch gets applies first and which one gets applied second. The two

Re: [PATCH 1/2] [PATCH] ax88179_178a: Correct the RX error definition in RX header

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:10 +0800 From: Freddy Xin fre...@asix.com.tw Correct the definition of AX_RXHDR_CRC_ERR and AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr seperately. Signed-off-by: Freddy Xin fre...@asix.com.tw Applied. -- To unsubscribe

Re: [PATCH 2/2] [PATCH] ax88179_178a: Add VID:DID for Samsung USB Ethernet Adapter

2013-10-22 Thread David Miller
From: fre...@asix.com.tw Date: Tue, 22 Oct 2013 15:32:11 +0800 From: Freddy Xin fre...@asix.com.tw Add VID:DID for Samsung USB Ethernet Adapter. Signed-off-by: Freddy Xin fre...@asix.com.tw Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a

Re: [PATCH 1/1] ax88179_178a: Remove AX_MEDIUM_ALWAYS_ONE bit in AX_MEDIUM_STATUS_MODE register to avoid TX throttling

2013-10-25 Thread David Miller
From: fre...@asix.com.tw Date: Thu, 24 Oct 2013 14:58:25 +0800 From: Freddy Xin fre...@asix.com.tw Remove AX_MEDIUM_ALWAYS_ONE in AX_MEDIUM_STATUS_MODE register. Setting this bit may cause TX throttling in Half-Duplex mode. Signed-off-by: Freddy Xin fre...@asix.com.tw Applied. -- To

Re: [PATCH 0/5] r8152 bug fixes

2013-10-28 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 28 Oct 2013 19:58:09 +0800 These could fix some driver issues. Hayes Wang (5): net/usb/r8152: fix tx/rx memory overflow net/usb/r8152: make sure the tx checksum setting is correct net/usb/r8152: modify the tx flow net/usb/r8152:

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 29 Oct 2013 15:56:16 +0800 Support stopping and waking tx queue. The maximum tx queue length is 60. What is so special about the number 60? It seems arbitrary, and if it isn't arbitrary you haven't described why this value was choosen. I've

Re: [PATCH] net/cdc_ncm: fix null pointer panic at usbnet_link_change

2013-10-29 Thread David Miller
From: Du, ChangbinX changbinx...@intel.com Date: Tue, 29 Oct 2013 03:30:42 + In cdc_ncm_bind() function, it call cdc_ncm_bind_common() to setup usb. But cdc_ncm_bind_common() may meet error and cause usbnet_disconnect() be called which calls free_netdev(net). Thus usbnet structure(alloced

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: hayeswang hayesw...@realtek.com Date: Wed, 30 Oct 2013 11:03:55 +0800 David Miller [mailto:da...@davemloft.net] Sent: Wednesday, October 30, 2013 5:50 AM To: Hayeswang Cc: net...@vger.kernel.org; nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org Subject: Re: [PATCH

Re: [PATCH net v2 2/3] r8152: modify the tx flow

2013-10-30 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 30 Oct 2013 15:13:39 +0800 Remove the code for sending the packet in the rtl8152_start_xmit(). Let rtl8152_start_xmit() to queue the packet only, and schedule a tasklet to send the queued packets. This simplify the code and make sure all the

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-04 Thread David Miller
From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) } #ifdef XMT_VIA_SKB - if(p-tmd_skb[p-tmdlast]) { -

Re: [PATCH net-next 0/5] cdc_mbim + qmi_wwan trivial fixes

2013-11-04 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 1 Nov 2013 14:18:51 +0100 This series fixes three problems Oliver pointed out during the review of the new huawei_cdc_ncm driver: http://patchwork.ozlabs.org/patch/278903/ That innocent driver only used cdc_mbim as a blueprint, and all the blame

Re: [PATCH net v2 2/3] r8152: modify the tx flow

2013-11-04 Thread David Miller
From: hayeswang hayesw...@realtek.com Date: Thu, 31 Oct 2013 13:52:38 +0800 From: David Miller [mailto:da...@davemloft.net] Sent: Thursday, October 31, 2013 5:05 AM From: Hayes Wang hayesw...@realtek.com Date: Wed, 30 Oct 2013 15:13:39 +0800 [...] Basically, your driver will now queue up

Re: [PATCH net-next v6 0/3] The huawei_cdc_ncm driver

2013-11-05 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Mon, 4 Nov 2013 09:50:46 +0100 Enrico has been kind enough to let me repost his driver with the changes requested by Oliver Neukum during the last review of this series. The changes I have made from Enricos original v5 series to this version are: v6:

Re: [PATCH] net: cdc_ncm: cleanup a type issue in cdc_ncm_setup()

2013-11-14 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Wed, 13 Nov 2013 10:42:34 +0300 This is harmless but cdc_ncm_setup() returns negative error codes truncated to u8 values. There is only one caller and treats all non-zero returns as errors but doesn't store the the return code. So the code

Re: [PATCH] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-10 Thread David Miller
From: Ming Lei ming@canonical.com Date: Fri, 11 Jan 2013 10:45:38 +0800 Cc netdev and usb lists. That doesn't work for patches, sorry. It will have to be submitted freshly and cleanly to the appropriate lists, not as a quoted reply. -- To unsubscribe from this list: send the line

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-12 Thread David Miller
From: Wei Shuai cpuw...@gmail.com Date: Sat, 12 Jan 2013 19:34:39 +0800 Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in driver_info:data. so later on, if more such buggy devices are found, they could use same

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread David Miller
From: Dan Williams d...@redhat.com Date: Mon, 14 Jan 2013 11:19:13 -0600 On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: From: Wei Shuai cpuw...@gmail.com Date: Sat, 12 Jan 2013 19:34:39 +0800 Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I introduce a flag

Re: [PATCH] usbnet: dm9601: Fix incorrect command

2013-01-16 Thread David Miller
From: Tushar Behera tushar.beh...@linaro.org Date: Tue, 15 Jan 2013 11:09:01 +0530 commit 24b1042c4eb2 (usbnet: dm9601: apply introduced usb command APIs) removes the distiction between DM_WRITE_REG and DM_WRITE_REGS command. The distiction is reintroduced to the driver so that the

Re: [PATCH net] net: qmi_wwan: add TP-LINK HSUPA Modem MA180

2013-01-16 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 15 Jan 2013 10:19:50 +0100 The driver description files gives these names to the vendor specific functions on this modem: Diagnostics VID_2357PID_0201MI_00 NMEAVID_2357PID_0201MI_01 Modem VID_2357PID_0201MI_03 Networkcard

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Tue, 15 Jan 2013 09:34:07 +0100 The main problem is that these devices don't support ethernet. They support IP (v4 and _maybe_ v6) with an ethernet header. Many of them will do ARP (and IPv6 ND) as well to complete the picture, but some of them don't and

Re: [PATCH v3 1/2] net: asix: init ASIX AX88772B MAC from EEPROM

2013-01-18 Thread David Miller
From: Lucas Stach d...@lynxeye.de Date: Wed, 16 Jan 2013 15:24:06 +0100 The device comes up with a MAC address of all zeros. We need to read the initial device MAC from EEPROM so it can be set properly later. Signed-off-by: Lucas Stach d...@lynxeye.de Applied. -- To unsubscribe from this

Re: [PATCH v3 2/2] net: asix: handle packets crossing URB boundaries

2013-01-18 Thread David Miller
From: Lucas Stach d...@lynxeye.de Date: Wed, 16 Jan 2013 15:24:07 +0100 ASIX AX88772B started to pack data even more tightly. Packets and the ASIX packet header may now cross URB boundaries. To handle this we have to introduce some state between individual calls to asix_rx_fixup().

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-18 Thread David Miller
From: Freddy Xin fre...@asix.com.tw Date: Thu, 17 Jan 2013 17:32:54 +0800 +struct ax88179_rx_pkt_header { + + u8 l4_csum_err:1, Get rid of such extraneous empty lines. They do not add clarity, rather they just take up space. + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |

Re: [PATCH 1/2] introduce flag FLAG_NOARP for usb net devices which cannot do ARP

2013-01-19 Thread David Miller
Why did you submit this _4_ times? I'm deleteing everything, I'm not even going to try and guess why you submitted this so many times and what might be different between each copy. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH net] net: qmi_wwan: add ONDA MT8205 4G LTE

2013-01-19 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 18 Jan 2013 15:26:34 +0100 The driver description files gives these names to the vendor specific functions on this modem: Diag VID_19D2PID_0265MI_00 NMEA VID_19D2PID_0265MI_01 AT cmd VID_19D2PID_0265MI_02 Modem VID_19D2PID_0265MI_03 Net

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread David Miller
From: Wei Shuai cpuw...@gmail.com Date: Mon, 21 Jan 2013 10:20:22 +0800 The main problem is that these devices don't support ethernet. He's saying your comment is referring to the wrong thing, rather than saying anything against what your change is doing. Read his feedback carefully: +/*

Re: [PATCH] usbnet: pegasus: set wakeup enable in set_wol

2013-01-20 Thread David Miller
From: Ming Lei ming@canonical.com Date: Sat, 19 Jan 2013 19:32:01 +0800 This patch calls device_set_wakeup_enable() inside set_wol callback, so that turning on WOL from user mode utility can make the 'wakeup' of pegasus device to be enabled, then remote wakeup may be enabled before

Re: [PATCH net 0/3] cdc_ncm and cdc_mbim fixes for 3.8

2013-01-21 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Mon, 21 Jan 2013 16:50:37 +0100 The 2 first patches in this series are required to make the Sierra Wireless MC7710 card work in MBIM mode. They may also be required for other Qualcomm firmware based MBIM devices. Patch #1 was previously posted as a

Re: [PATCH 1/2] usbnet: add new flag FLAG_NOARP for usb net devices

2013-01-21 Thread David Miller
From: Wei Shuai cpuw...@gmail.com Date: Tue, 22 Jan 2013 00:00:31 +0800 We do have some USB net devices, which cannot do ARP. so we can introduce a new flag FLAG_NOARP, then client drivers can easily handle this kind of devices Signed-off-by: Wei Shuai cpuw...@gmail.com Applied. -- To

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-22 Thread David Miller
From: Freddy Xin fre...@asix.com.tw Date: Wed, 23 Jan 2013 10:32:17 +0800 Fixed coding style errors. There are still many style issues remaining, you have a lot more work to do, for example: + return fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, +value,

Re: [PATCH net] net: cdc_mbim: send ZLP only for the specific buggy device

2013-01-23 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 23 Jan 2013 11:57:02 +0100 Reverting 328d7b8 and instead adding an exception for the Sierra Wireless MC7710. commit 328d7b8 (net: cdc_mbim: send ZLP after max sized NTBs) added a workaround for an issue observed on one specific device. Concerns

Re: [PATCH] net: cdc_ncm: use IAD provided by the USB core

2013-01-27 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Sat, 26 Jan 2013 10:36:59 +0100 commit 9992c2e (net: cdc_ncm: workaround for missing CDC Union) added code to lookup an IAD for the interface we are probing. This is redundant. The USB core has already done the lookup and saved the result in the USB

Re: [PATCH net v2] net: usbnet: prevent buggy devices from killing us

2013-01-30 Thread David Miller
From: Oliver Neukum oli...@neukum.org Date: Wed, 30 Jan 2013 08:44:35 +0100 On Tuesday 29 January 2013 10:51:28 Bjørn Mork wrote: A device sending 0 length frames as fast as it can has been observed killing the host system due to the resulting memory pressure. Temporarily disable RX skb

Re: [PATCH v2] NET: qmi_wwan: add Telit LE920 support

2013-01-30 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 30 Jan 2013 14:50:46 +0100 Daniele Palmas dnl...@gmail.com writes: Add VID, PID and fixed interface for Telit LE920 Signed-off-by: Daniele Palmas dnl...@gmail.com --- v2: - rebased against net tree Excellent! Thanks. Looks like an

Re: [PATCH net] net: usbnet: fix tx_dropped statistics

2013-02-04 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 31 Jan 2013 19:36:05 +0100 It is normal for minidrivers accumulating frames to return NULL from their tx_fixup function. We do not want to count this as a drop, or log any debug messages. A different exit path is therefore chosen for such drivers,

Re: [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages

2013-02-04 Thread David Miller
From: Joe Perches j...@perches.com Date: Sun, 3 Feb 2013 19:28:07 -0800 Remove all the OOM messages that follow kernel alloc failures as there is already a generic equivalent to these messages in the mm subsystem. Joe Perches (8): caif: Remove unnecessary alloc/OOM messages can:

Re: [PATCH] net: cdc_ncm: add another Huawei vendor specific device

2013-02-06 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 6 Feb 2013 16:21:53 +0100 Adding a new vendor specific class/subclass/protocol combination for CDC NCM devices based on information from a GPLed out-of-tree driver from Huawei. Signed-off-by: Bjørn Mork bj...@mork.no Applied. -- To unsubscribe

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-07 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Thu, 7 Feb 2013 20:02:55 + On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote: From: Freddy Xin fre...@asix.com.tw This is a resubmission. Added const to ethtool_ops structure and fixed the coding style of AX88179_BULKIN_SIZE array.

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-08 Thread David Miller
From: David Laight david.lai...@aculab.com Date: Fri, 8 Feb 2013 10:23:08 - It is much better to define constants for the bit values and explicitly mask them as required. Yes, __be32/__le32 along with bit define macros is the only reasonable way to do this kind of stuff. -- To unsubscribe

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 07 Feb 2013 13:46:27 -0800 alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/memcpy to kmemdup.

Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings

2013-02-14 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Wed, 13 Feb 2013 23:09:52 +0100 commit bd329e1 (net: cdc_ncm: do not bind to NCM compatible MBIM devices) added a test for a CDC MBIM altsetting, implementing the cdc_ncm part of MBIM backward compatibility support. This intentionally made the driver

Re: [PATCH v2] qmi_wwan, cdc-ether: add ADU960S

2013-02-18 Thread David Miller
From: Dan Williams d...@redhat.com Date: Mon, 18 Feb 2013 21:25:09 -0600 It advertises a standard CDC-ETHER interface, which actually should be driven by qmi_wwan. Signed-off-by: Dan Williams d...@redhat.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in

Re: [PATCH 0/3] usbnet: smsc95xx: fix smsc95xx_suspend

2013-02-25 Thread David Miller
From: Ming Lei ming@canonical.com Date: Fri, 22 Feb 2013 21:05:02 +0800 The 1st two patches fix smsc95xx_suspend, and the 1st one should be backported to 3.8. The last one is to rename the misleading FEATURE_AUTOSUSPEND. All applied, thanks. -- To unsubscribe from this list: send the

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-25 Thread David Miller
From: Greg Kroah-Hartman gre...@linuxfoundation.org Date: Mon, 25 Feb 2013 20:23:43 -0800 On Tue, Feb 26, 2013 at 02:47:12PM +1030, Glen Turner wrote: This USB ethernet adapter was purchased in anodyne packaging marked USB2.0 to LAN from the computer store adjacent to linux.conf.au 2013 in

  1   2   3   4   5   6   7   >