Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq

[Jeff Moyer]

Christoph Hellwig h...@infradead.org writes:

 Please try the fix below, looks like the commit broke TCQ for all drivers 
 using block-level tagging.

 ---
 From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001
 From: Christoph Hellwig h...@lst.de
 Date: Fri, 12 Sep 2014 16:00:19 -0700
 Subject: scsi: fix regression that accidentally disabled block-based tcq

 The scsi blk-mq support accidentally flipped a conditional, which lead to
 never enabling block based tcq when using the legacy request path.

 Fixes: d285203cf647d7c9 scsi: add support for a blk-mq based I/O path.
 Reported-by: Hans de Goede hdego...@redhat.com
 Signed-off-by: Christoph Hellwig h...@lst.de
 ---
  include/scsi/scsi_tcq.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
 index cdcc90b..e645835 100644
 --- a/include/scsi/scsi_tcq.h
 +++ b/include/scsi/scsi_tcq.h
 @@ -68,7 +68,7 @@ static inline void scsi_activate_tcq(struct scsi_device 
 *sdev, int depth)
   return;
  
   if (!shost_use_blk_mq(sdev-host) 
 - blk_queue_tagged(sdev-request_queue))
 + !blk_queue_tagged(sdev-request_queue))
   blk_queue_init_tags(sdev-request_queue, depth,
   sdev-host-bqt);

Introduced by d285203:

-   if (!blk_queue_tagged(sdev-request_queue))
+   if (!shost_use_blk_mq(sdev-host) 
+   blk_queue_tagged(sdev-request_queue))

Seems like an obvious fix.

Reviewed-by: Jeff Moyer jmo...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] usb: gadget: fix error return code

[Jeff Moyer]

Julia Lawall julia.law...@lip6.fr writes:

 diff --git a/drivers/usb/gadget/udc/fusb300_udc.c 
 b/drivers/usb/gadget/udc/fusb300_udc.c
 index d40255f..5c5d1ad 100644
 --- a/drivers/usb/gadget/udc/fusb300_udc.c
 +++ b/drivers/usb/gadget/udc/fusb300_udc.c
 @@ -1398,13 +1398,17 @@ static int fusb300_probe(struct platform_device *pdev)
  
   /* initialize udc */
   fusb300 = kzalloc(sizeof(struct fusb300), GFP_KERNEL);
 - if (fusb300 == NULL)
 + if (fusb300 == NULL) {
 + ret = -ENOMEM;
   goto clean_up;
 + }
  
   for (i = 0; i  FUSB300_MAX_NUM_EP; i++) {
   _ep[i] = kzalloc(sizeof(struct fusb300_ep), GFP_KERNEL);
 - if (_ep[i] == NULL)
 + if (_ep[i] == NULL) {
 + ret = -ENOMEM;
   goto clean_up;
 + }
   fusb300-ep[i] = _ep[i];
   }

Reviewed-by: Jeff Moyer jmo...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC] aio: remove retry and cancel

[Jeff Moyer]

Benjamin LaHaise b...@kvack.org writes:

 On Mon, Oct 15, 2012 at 05:27:44PM -0700, Zach Brown wrote:
 The possibility of removing retry and cancelation came up a few times
 plumbers this year.  I finally gave it a try.
 
 Removing retry is a good iea.  It's of little value because retry
 happens in a kernel thread, not in the submitter's task.

 Getting rid of retry is probably a good idea.

 I'm ambivalent about removing cancelation.  The code is almost
 never used, though, so I figured it'd be interesting to see
 if we can get away with getting rid of it.

 Canellation *cannot* be removed.  If you remove cancellation, processes 
 with outstanding ios at exit() time will never release their resources.

Please explain.  wait_for_active_reqs will wait until all outstanding
I/O has completed before returning.  What resources do you think will be
left?

Cheers,
Jeff
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mount stuck, khubd blocked

[Jeff Moyer]

Alan Stern st...@rowland.harvard.edu writes:

 On Mon, 23 Jul 2012, Jeff Moyer wrote:

  Jeff, does this also fix Bugzilla #43269?
 
 First, this patch is wrong.  I posted another version later on that got
 merged for 3.5.
 
 As for bug 43269, it does not look like the same symptoms, so I would
 not expect the patches I posted to resolve that issue.  Sorry.

 Can you suggest someone who might be able to help with #43269?  It has 
 been languishing since May.

Well, either Jens or James may be able to make more progress faster than
I could.  I'm a little concerned that the reporter has unreasonable
expectations for his use of library calls, but I suppose that's a
separate issue.

James, Jens:
  https://bugzilla.kernel.org/show_bug.cgi?id=43269

Cheers,
Jeff
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html