Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

On 2/6/2015 6:02 AM, Zhangfei Gao wrote: On 6 February 2015 at 16:07, Kaukab, Yousaf yousaf.kau...@intel.com wrote: GAHBCFG_HBSTLEN_INCR4 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 15aa578..20085de 100644 --- a/drivers/usb/dwc2/gadget.c +++

Re: [PATCH RESEND] usb: dwc2: Fix a bug in reading the endpoint directions from reg.

; /* Direction in or both */ if (!(ep_type 2)) { Good catch on this. Acked-by: John Youn johny...@synopsys.com Hi Felipe, Any chance you'll accept this into your 3.20 queue? It affects any DWC2 core instance that has unidirectional endpoints defined. Regards, John

RE: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus

RE: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of

RE: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

From: Antti Seppälä [mailto:a.sepp...@gmail.com] Sent: Wednesday, January 21, 2015 10:28 AM This patch switches calls to readl/writel to their __raw_readl/__raw_writel equivalents which preserve platform endianness. This patch is necessary to access dwc2 registers correctly on big endian

Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

On 2/6/2015 2:23 PM, John Youn wrote: On 2/6/2015 6:02 AM, Zhangfei Gao wrote: On 6 February 2015 at 16:07, Kaukab, Yousaf yousaf.kau...@intel.com wrote: GAHBCFG_HBSTLEN_INCR4 diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 15aa578..20085de 100644 --- a/drivers/usb

Re: [RFC PATCH v1] usb: dwc2: reduce dwc2 driver probe time

On 2/11/2015 3:42 AM, Roy wrote: Hi John Youn: Could you please give some suggestions from your point of view, about this probe time issue ? Thanks a lot. at 2015/2/11 2:23, Julius Werner wrote: @@ -2703,7 +2703,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg

Re: [PATCH 2/2] usb: dwc2: gadget reuse ahbcfg assigned from platform

On 2/12/2015 1:04 AM, Kaukab, Yousaf wrote: -Original Message- From: John Youn [mailto:john.y...@synopsys.com] Sent: Wednesday, February 11, 2015 11:00 PM To: Zhangfei Gao; Kaukab, Yousaf Cc: ba...@ti.com; john.y...@synopsys.com; linux-usb@vger.kernel.org Subject: Re: [PATCH 2/2] usb

Re: [PATCH v2] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

On 2/12/2015 4:42 AM, Romain Perier wrote: ping 2015-02-06 17:50 GMT+01:00 Romain Perier romain.per...@gmail.com: Don't register interrupt handler before usb gadget is correctly initialized. For some embedded platforms which don't have a usb-phy, it crashes the driver because an interrupt

RE: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

From: Vincent Pelletier [mailto:plr.vinc...@gmail.com] Sent: Friday, January 23, 2015 12:19 AM On Fri, 23 Jan 2015 02:38:37 +, John Youn john.y...@synopsys.com wrote: Having the __raw functions everywhere is not pretty and probably not a good idea either. I would rather have

RE: [PATCH v1 01/13] usb: dwc2: host: register hcd handle to the phy

From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM From: Gregory Herrero gregory.herr...@intel.com If phy driver is present, register hcd handle to it and let it take care of calling usb_add_hcd. Otherwise, add hcd here. Moreover, save

Re: [PATCH 01/19] usb: dwc2: move debugfs code to a separate file

On 3/16/2015 6:43 AM, Kaukab, Yousaf wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Saturday, March 14, 2015 6:11 PM To: John Youn Cc: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; Herrero, Gregory; r.bald...@samsung.com; dingu

Re: [PATCH v2 00/22] usb: third series of updates for dwc2 driver

On 3/20/2015 8:35 AM, Mian Yousaf Kaukab wrote: Hi, This patchset consists of some bug fixes and feature enhancements for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of testing was with dma enabled. Although basic testing without dma was also

Re: [PATCH 01/19] usb: dwc2: move debugfs code to a separate file

On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote: + +int dwc2_debugfs_init(struct dwc2_hsotg *hsotg) +{ + int ret; + + hsotg-debug_root = debugfs_create_dir(dev_name(hsotg-dev), NULL); + if (!hsotg-debug_root) { + ret = -ENOMEM; + goto

Re: [PATCH 03/19] usb: dwc2: add controller hibernation support

On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote: From: Gregory Herrero gregory.herr...@intel.com When suspending usb bus, phy driver may disable controller power. In this case, registers need to be saved on suspend and restored on resume. Signed-off-by: Gregory Herrero

Re: [PATCH 07/19] usb: dwc2: set parameter values in probe function

On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote: So the parameters can be used in both host and gadget modes. Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/core.h | 3 +-- drivers/usb/dwc2/hcd.c | 18 +- drivers/usb/dwc2/hcd.h

Re: [PATCH 17/19] usb: dwc2: host: spinlock urb_enqueue

On 3/9/2015 8:05 AM, Mian Yousaf Kaukab wrote: From: Gregory Herrero gregory.herr...@intel.com During urb_enqueue, if the urb can't be queued to the endpoint, the urb is freed without any spinlock protection. This leads to memory corruption when concurrent urb_dequeue try to free same

Re: [PATCH] usb: dwc2: host: fix dwc2 disconnect bug

. Acked-by: John Youn johny...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: dwc2: pci: Add device mode to the dwc2-pci driver

has the effect of adding device and DRD mode to the pci driver. Tested on the Synopsys HAPS PCIe platform. Signed-off-by: John Youn johny...@synopsys.com --- drivers/usb/dwc2/Kconfig | 7 ++- drivers/usb/dwc2/pci.c | 159 +-- 2 files changed, 76

[PATCH] usb: dwc2: pci: Select the generic PHY for dwc2-pci driver

The dwc2-pci driver requires the generic PHY. This fixes undefined reference issues when it is not selected. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: John Youn johny...@synopsys.com --- This fixes issue with commit 9024c495 on -next. John drivers/usb/dwc2/Kconfig

Re: [PATCH RESEND] usb: dwc2: rework initialization of host and gadget in dual-role mode

; + } platform_set_drvdata(dev, hsotg); Acked-by: John Youn johny...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] usb: dwc2: gadget reuse ahbcfg assigned from platform

On 2/15/2015 5:50 AM, Zhangfei Gao wrote: Reuse ahbcfg if assigned from platform Input from John: AHB_SINGLE, NOTI_ALL_DMA_WRIT, REM_MEM_SUPP, HBSTLEN, and INV_DESC_ENDIANNESS only apply in DMA mode and are ignored in slave mode operation. Signed-off-by: Zhangfei Gao

Re: [PATCH v3] usb: dwc2: gadget reuse ahbcfg assigned from platform

On 2/20/2015 7:26 PM, zhangfei wrote: Hi, John On 02/21/2015 08:35 AM, John Youn wrote: On 2/15/2015 5:50 AM, Zhangfei Gao wrote: Reuse ahbcfg if assigned from platform Input from John: AHB_SINGLE, NOTI_ALL_DMA_WRIT, REM_MEM_SUPP, HBSTLEN, and INV_DESC_ENDIANNESS only apply in DMA mode

Re: [PATCH v2] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

On 2/6/2015 8:50 AM, Romain Perier wrote: Don't register interrupt handler before usb gadget is correctly initialized. For some embedded platforms which don't have a usb-phy, it crashes the driver because an interrupt is emitted with non-initialized hardware. According to devm_request_irq

Re: [PATCH v1 01/13] usb: dwc2: host: register hcd handle to the phy

On 01/28/2015 11:26 PM, Kaukab, Yousaf wrote: -Original Message- From: John Youn [mailto:john.y...@synopsys.com] Sent: Thursday, January 29, 2015 3:25 AM To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com Cc: Herrero, Gregory; r.bald...@samsung.com

Re: [PATCH] usb: dwc2: fix USB core dependencies

-by: John Youn johny...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

On 01/28/2015 02:02 AM, Antti Seppälä wrote: On 27 January 2015 at 04:18, John Youn john.y...@synopsys.com wrote: From: Vincent Pelletier [mailto:plr.vinc...@gmail.com] Sent: Friday, January 23, 2015 12:19 AM On Fri, 23 Jan 2015 02:38:37 +, John Youn john.y...@synopsys.com wrote: Having

Re: [PATCH v4 00/22] usb: third series of updates for dwc2 driver

is statically linked due to http://marc.info/?l=linux-usbm=142661773703793w=2 - usb: dwc2: host: ensure qtb exists before dereferencing it is added to fix a NULL pointer dereferencing bug v2: - Fixed comments from John Youn and Julius Werner - Fixed regression, found by John, when switching

Re: [PATCH] usb: dwc2: gadget: cleanup useless code

; - s3c_hsotg_of_probe(hsotg); - /* Initialize to legacy fifo configuration values */ hsotg-g_rx_fifo_sz = 2048; hsotg-g_np_g_tx_fifo_sz = 1024; Acked-by: John Youn johny...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH] usb: dwc2: gadget: cleanup useless code

On 4/28/2015 3:50 PM, John Youn wrote: On 4/26/2015 12:36 AM, Yunzhi Li wrote: dwc2 gadget driver s3c_hsotg_of_probe() run twice in dwc2_gadget_init() and the first one is useless, so remove it. Signed-off-by: Yunzhi Li l...@rock-chips.com --- drivers/usb/dwc2/gadget.c | 2 -- 1 file

Re: [PATCH 1/3] usb: dwc2: host: allocate qh before atomic enqueue

dwc2_hcd_urb *urb = qtd-urb; - int allocated = 0; int retval; /* * Get the QH which holds the QTD-list to insert to. Create QH if it * doesn't exist. */ This comment doesn't apply anymore. Otherwise the series looks ok. Acked-by: John Youn johny

Re: [PATCH] usb: dwc2: fix unnecessary USB overcurrent condition

Hi Dinh, Responding again to the proper message to add linux-usb. And also added more comments. On 5/26/2015 7:32 PM, dingu...@opensource.altera.com wrote: From: Dinh Nguyen dingu...@opensource.altera.com For platforms that use a ULPI phy, we should enable the external VbusValid signal

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

On 6/22/2015 4:00 PM, Doug Anderson wrote: Hi, On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf yousaf.kau...@intel.com wrote: Tested-by: Heiko Stuebner he...@sntech.de -- 8 -- [ 19.799200] BUG: sleeping function called from invalid context at mm/slab.c:2863

Re: [PATCH 1/3] usb: dwc2: host: allocate qh before atomic enqueue

On 6/10/2015 6:27 AM, Kaukab, Yousaf wrote: -Original Message- From: John Youn [mailto:john.y...@synopsys.com] Sent: Wednesday, June 10, 2015 1:06 AM To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com Cc: Herrero, Gregory; he...@sntech.de; Holmberg

Re: [PATCH v1] usb: dwc2: gadget: fix a memory use-after-free bug

the * request tries to queue more work for this endpoint. Acked-by: John Youn johny...@synopsys.com John -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v5 00/22] usb: third series of updates for dwc2 driver

Youn and Julius Werner - Fixed regression, found by John, when switching to gadget mode after running host mode - Added patch to add core parameter for enabling/disabling hibernation - Added patch to build dwc2_pci.ko independent from dwc2.ko v1: - Fixed comments from John Youn

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

On 6/29/2015 2:48 PM, Felipe Balbi wrote: Hi again, On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: We need to return error to caller if command is not sent to controller succesfully. Signed-off-by:

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

On 7/1/2015 8:00 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 02:03:14AM +, John Youn wrote: On 6/29/2015 2:48 PM, Felipe Balbi wrote: Hi again, On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: We

Re: [PATCH v1] usb: dwc2: reset AHB hclk domain before init

On 8/12/2015 12:33 PM, Felipe Balbi wrote: On Wed, Aug 12, 2015 at 07:06:09PM +0800, Yunzhi Li wrote: Hi , 在 2015/8/11 22:12, Felipe Balbi 写道: Hi, On Tue, Aug 11, 2015 at 10:27:42AM +0800, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset

Re: [PATCH v3] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

On 8/19/2015 5:22 AM, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should be called before dwc2_get_hwparams() to reset core registers to default value. Without this the FIFO setting might be incorrect because calculating FIFO size need power-on value of

Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

On 8/18/2015 2:41 AM, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should be called before dwc2_get_hwparams() to reset core registers to default value. Without this the FIFO setting might be incorrect because calculating FIFO size need power-on value of

Re: [PATCH RESEND v2 0/3] usb: dwc2: fix sleep while atomic bugs

On 6/29/2015 2:04 AM, Mian Yousaf Kaukab wrote: This series fixes 3 sources of sleep while atomic bugs. Including the one reported by Heiko Stuebner here: http://www.spinics.net/lists/linux-usb/msg125186.html Please review. Thank you, Best regards, Yousaf History: v2: - Fixed

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

On 6/29/2015 2:48 PM, Felipe Balbi wrote: Hi again, On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: We need to return error to caller if command is not sent to controller succesfully. Signed-off-by:

Re: [PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

On 8/11/2015 12:57 AM, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset AHB hclk domain to reset all AHB interface registers to default. Without this the FIFO value setting might be incorrect because calculating FIFO size need the power-on

Re: [PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

On 8/13/2015 8:29 PM, Yunzhi Li wrote: 在 2015/8/14 8:09, John Youn 写道: On 8/11/2015 12:57 AM, Yunzhi Li wrote: We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset AHB hclk domain to reset all AHB interface registers to default. Without this the FIFO value

[PATCH] usb: dwc3: Reset the transfer resource index on SET_INTERFACE

. Signed-off-by: John Youn johny...@synopsys.com --- drivers/usb/dwc3/ep0.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 2ef3c8d..69e769c 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -727,6 +727,10 @@ static int

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

On 7/20/2015 10:51 AM, Felipe Balbi wrote: Hi, On Wed, Jul 15, 2015 at 09:49:05AM +, Subbaraya Sundeep Bhatta wrote: Hi John, -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, July 14, 2015 12:29 AM To: John Youn Cc: ba...@ti.com; Subbaraya Sundeep

Re: [PATCH] usb: dwc2: rename all s3c_* to dwc2_*

/dwc2/gadget.c | 696 drivers/usb/dwc2/hcd.c | 4 +- drivers/usb/dwc2/platform.c | 8 +- include/linux/platform_data/s3c-hsotg.h | 10 +- Hi Felipe, For dwc2/*: Acked-by: John Youn johny...@synopsys.com Tested

Re: [PATCH] usb: dwc2: host: Fix ahbcfg for rk3066

LEN_SHIFT, > .uframe_sched = -1, > .external_id_pin_ctl= -1, > .hibernation= -1, > Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2] usb: dwc2: use devm_phy_optional_get

USB PHY when devm_phy_get returns -ENOENT Should be -ENODEV > only. Other values like > -EPROBE_DEFER need to be returned from the probe function, because it > could be that a phy is specified but not probed before. > > Suggested-by: Uwe Kleine-König <u.kleine-koe...@pengutro

Re: [REPOST PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288

On 10/21/2015 9:23 AM, Doug Anderson wrote: > John, > > On Mon, Jul 6, 2015 at 11:27 AM, Douglas Anderson > wrote: >> This series of patches, together with >> from Chris Zhong and a >> dts change allow us to wake up from a USB

Re: usb: dwc2: regression during boot on Raspberry Pi

On 11/9/2015 12:43 PM, Stefan Wahren wrote: > Hi, > > Am 09.11.2015 um 12:53 schrieb Marek Szyprowski: >> Hello, >> >> >> This change looks reasonable, I remember the similar issue was in >> s3c-hsotg driver >> and it caused kernel ops on driver probe, when bootloader left dwc2 >> enabled. >> The

Re: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

On 11/9/2015 1:09 PM, Felipe Balbi wrote: > > Hi, > > "McCauley, Ben" writes: >>> "McCauley, Ben" writes: >> Ben is talking about setting the gadget->max_speed, which is >> hard-coded in dwc3 to USB_SPEED_SUPER. >> >> For this

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

On 11/11/2015 4:22 PM, Doug Anderson wrote: > John, > > On Fri, Nov 6, 2015 at 2:04 AM, Yunzhi Li wrote: >> hi John , >> >> As we talked yesterday, I tried to fix the split schedule sequence. This >> patch will >> avoid scheduling SSPLIT-IN packet for another device

Re: usb: dwc2: regression during boot on Raspberry Pi

On 11/11/2015 3:20 PM, Stefan Wahren wrote: > Hi John, > > Am 11.11.2015 um 00:21 schrieb John Youn: >> On 11/9/2015 12:43 PM, Stefan Wahren wrote: >>> Hi, >> >> The gadget side required it but it looks like the host side >> didn't. >> &

Re: usb: dwc2: regression during boot on Raspberry Pi

On 11/11/2015 11:13 PM, Stefan Wahren wrote: > Am 12.11.2015 um 05:39 schrieb John Youn: >> On 11/11/2015 3:20 PM, Stefan Wahren wrote: >>> Hi John, >>> >>> Am 11.11.2015 um 00:21 schrieb John Youn: >>>> On 11/9/2015 12:43 PM, Stefan Wahren wro

Re: [PATCH 0/4 V2] usb: dwc2: fix usb host support on Raspberry Pi

gt; - extend "usb: dwc2: Return errors from PHY" to handle kernel > without PHY support > - take care of Sergei Shtylyov comments > - add patch to make otg clk optional again > > John Youn (1): > usb: dwc2: Make PHY optional > > Stefan Wahren (3): >

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

On 11/11/2015 8:46 PM, Doug Anderson wrote: > John, > > On Wed, Nov 11, 2015 at 8:29 PM, John Youn <john.y...@synopsys.com> wrote: >> I also feel it is not quite right as the SSPLIT should be able to >> happen during the SSPLIT of another device. I tried to re

Re: [REPOST PATCH] usb: dwc2: host: Support immediate retries for split transactions

} > > chan->start_pkt_count = num_packets; > @@ -1855,8 +1866,7 @@ void dwc2_hc_start_transfer(struct dwc2_hsotg *hsotg, > > hcchar = dwc2_readl(hsotg->regs + HCCHAR(chan->hc_num)); > hcchar &= ~HCCHAR_MULTICNT_MASK; > - hcchar |= chan->multi_coun

Re: [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions

On 11/16/2015 3:14 PM, Doug Anderson wrote: > Alan, > > On Mon, Nov 16, 2015 at 12:31 PM, Alan Stern > wrote: >> On Mon, 16 Nov 2015, Doug Anderson wrote: >> >>> Alan, >>> >>> On Mon, Nov 16, 2015 at 11:31 AM, Alan Stern >>> wrote: On

[PATCH RESEND 0/2] usb: dwc2: Fix issues with getting PHY during probe

This series address a couple issues with setting up and checking the PHY during probe. Resending to linux-usb list with fixed up headers and fixed cover letter subject. John Youn (2): usb: dwc2: Make PHY optional usb: dwc2: Return errors from PHY drivers/usb/dwc2/platform.c | 36

[PATCH RESEND 1/2] usb: dwc2: Make PHY optional

host side and broke some platforms when it was moved into platform.c. The gadget doesn't require the PHY either so remove the check. Reported-by: Stefan Wahren <i...@lategoodbye.de> Cc: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: John Youn <johny...@synopsys.com> ---

Re: usb: dwc2: regression during boot on Raspberry Pi

On 11/11/2015 9:57 AM, Alexander Aring wrote: > Hi, > > On Tue, Nov 10, 2015 at 11:21:56PM +0000, John Youn wrote: >> On 11/9/2015 12:43 PM, Stefan Wahren wrote: >>> Hi, >>> >>> Am 09.11.2015 um 12:53 schrieb Marek Szyprowski: >>>> Hello, &

[PATCH RESEND 2/2] usb: dwc2: Return errors from PHY

<alex.ar...@gmail.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/platform.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index b129c52..0a

Re: usb: dwc2: regression during boot on Raspberry Pi

On 11/8/2015 2:13 AM, Stefan Wahren wrote: > Hi Stephen, > > Am 08.11.2015 um 06:06 schrieb Stephen Warren: >> On 11/07/2015 05:16 PM, Stefan Wahren wrote: >>> Hi, >>> [...] >>>* phys (optional) >>>* phy-names (optional) >>> >>> So here are my questions: >>> >>> How to fix the kernel oops

Re: [PATCH] usb: dwc2: host: Fix remote wakeup when not in DWC2_L2

>> --- >> drivers/usb/dwc2/hcd.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) > > I know I've sent up a lot of patches recently, but this one in > particular would be good to get tested, reviewed, and landed sooner > rather than later. I believe it fixe

Re: [PATCH 1/2] usb: dwc2: host: Fix missing device insertions

On 10/16/2015 3:10 PM, Douglas Anderson wrote: > If you've got your interrupt signals bouncing a bit as you insert your > USB device, you might end up in a state when the device is connected but > the driver doesn't know it. > > Specifically, the observed order is: > 1. hardware sees connect >

Re: [PATCH v1 10/14] usb: dwc2: host: free status_buf on hcd de-init

On 10/12/2015 2:18 AM, Gregory Herrero wrote: > status_buf needs to be freed in dwc2_hcd_remove(). > > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/hcd.c | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH] RFT: usb: dwc2: bus suspend/resume that's not hibernate

On 10/30/2015 1:33 PM, Douglas Anderson wrote: > This is an attempt to rehash commit 0cf884e819e0 ("usb: dwc2: add bus > suspend/resume for dwc2") on ToT. That commit was reverted in commit > b0bb9bb6ce01 ("Revert "usb: dwc2: add bus suspend/resume for dwc2"") > because apparently it broke the

Re: [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions

enumerate. > > Signed-off-by: Douglas Anderson <diand...@chromium.org> > --- > Changes in v2: > - Don't reconnect when called from _dwc2_hcd_stop() (John Youn) > > drivers/usb/dwc2/core.h | 6 -- > drivers/usb/dwc2/core_intr.c | 4 ++-- > drivers/usb/dwc2/h

Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them

2_hsotg *hsotg) >* Clear if detected - Set internal flag if disabled >*/ > if (hprt0 & HPRT0_ENACHG) { > + writel(hprt0_modify | HPRT0_ENACHG, hsotg->regs + HPRT0); > dev_vdbg(hsotg->dev, >&q

Re: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

On 11/6/2015 9:55 AM, Felipe Balbi wrote: > > Hi, > > "McCauley, Ben" writes: >> Felipe, >> >> -Original Message- >> From: Felipe Balbi [mailto:ba...@ti.com] >> Sent: Friday, November 06, 2015 10:06 AM >> To: McCauley, Ben >> Cc:

Re: [PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

-- > drivers/usb/dwc2/core.h | 26 + > drivers/usb/dwc2/hcd.c | 76 +- > drivers/usb/dwc2/hcd.h | 19 > drivers/usb/dwc2/hcd_ddma.c | 240 > +++ > drivers/usb/dwc2/hcd_intr.c | 15 ++- > drivers/usb/dwc2

Re: [PATCH] usb: dwc2: host: Protect PCGCTL with lock in dwc2_port_resume()

e(>lock, flags); > usleep_range(2, 4); > + spin_lock_irqsave(>lock, flags); > } > > - spin_lock_irqsave(>lock, flags); > hprt0 = dwc2_read_hprt0(hsotg); > hprt0 |= HPRT0_RES; > hprt0 &= ~HPRT0_SUSP; >

Re: [PATCH] Revert "usb: dwc3: gadget: remove unnecessary _irqsave()"

On 10/13/2015 9:05 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >> On 10/12/2015 12:25 PM, Felipe Balbi wrote: >>> This reverts commit 70f3a9caa11665e9f9aace581d85d8483716a4c8. >>> >>> T

Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

On 10/14/2015 3:51 PM, Douglas Anderson wrote: > While plugging / unplugging on a DWC2 host port with "slub_debug=FZPUA" > enabled, I found a crash that was quite obviously a use after free. > > It appears that in some cases when we handle the various sub-cases of > HCINT we may end up freeing

Re: [PATCH v2] usb: dwc2: host: Fix use after free w/ simultaneous irqs

On 10/15/2015 4:38 PM, Doug Anderson wrote: > John, > > On Thu, Oct 15, 2015 at 4:21 PM, John Youn <john.y...@synopsys.com> wrote: >> Passing a NULL qtd to some of the subcases will lead to a NULL >> pointer dereference in that function or some function that it >&g

Re: [ANNOUNCE] tree closed for v4.4 merge window

On 10/15/2015 8:32 AM, Felipe Balbi wrote: > > Hi guys, > > it's already -rc5 and I need to close my tree for this merge > window. Major fixes will still be queued. I still have 3 patches on DWC2 > pending John's Ack, so those are the last ones which will get into my > tree; after that, only bug

[PATCH v2 3/7] usb: dwc3: pci: Add the PCI Product ID for Synopsys USB 3.1

This adds the PCI product ID for the Synopsys USB 3.1 IP core (DWC_usb31) on a HAPS-based PCI development platform. Cc: <sta...@vger.kernel.org> # v3.18+ Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc3/dwc3-pci.c | 5 + 1 file changed, 5 insertions(+)

[PATCH v2 4/7] usb: dwc3: pci: Add platform data for Synopsys HAPS

Add platform data and set usb3_lpm_capable and has_lpm_erratum. Cc: <sta...@vger.kernel.org> # v3.18+ Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc3/dwc3-pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-pci.c b

[PATCH v2 0/7] Various updates for Synopsys platforms

platform mostly mass-storage and CV and some internal testing. v2: * Updated the way the revisions are handled for 3.1 * Split up the dis_enblslpm_quirk patch John Youn (7): usb: dwc3: Support Synopsys USB 3.1 IP usb: dwc3: pci: Add the Synopsys HAPS AXI Product ID usb: dwc3: pci: Add

[PATCH v2 2/7] usb: dwc3: pci: Add the Synopsys HAPS AXI Product ID

This ID is for the Synopsys DWC_usb3 core with AXI interface on PCIe HAPS platform. This core has the debug registers mapped at a separate BAR in order to support enhanced hibernation. Cc: <sta...@vger.kernel.org> # v3.18+ Signed-off-by: John Youn <johny...@synopsys.com> --- driv

[PATCH v2 1/7] usb: dwc3: Support Synopsys USB 3.1 IP

the revision numbering scheme. Any future revision checks (for STARS, workarounds, and new features) should take into consideration how it applies to both the 3.1/3.0 IP. Cc: <sta...@vger.kernel.org> # v3.18+ Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc3

[PATCH v2 5/7] usb: dwc3: Add dis_enblslpm_quirk

Add a quirk to clear the GUSB2PHYCFG.ENBLSLPM bit, which controls whether the PHY receives the suspend signal from the controller. Cc: <sta...@vger.kernel.org> # v3.18+ Signed-off-by: John Youn <johny...@synopsys.com> --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ driv

Re: [PATCH v5 2/2] usb: dwc2: refactor common low-level hw code to platform.c

no longer needed > > v4: > - fixed broken conditional compilation and adjusted comments in dwc2_hsotg > structure documentation > > v3: > - rebased onto latest 'testing/next' from Felipe Balbi (includes > s3c_hsotg -> dwc2 rename) > > v2: > - moved setting

Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

On 10/7/2015 5:50 PM, Doug Anderson wrote: > John, > > On Mon, Oct 5, 2015 at 3:02 PM, John Youn <john.y...@synopsys.com> wrote: >> On 10/1/2015 1:50 PM, Doug Anderson wrote: >>> John, >>> >>> On Tue, Aug 18, 2015 at 5:19 PM, John Youn <john.y..

Re: [PATCH] usb: dwc2: fix duplicate argument warning

NT | > - GINTSTS_DISCONNINT; > + intmsk |= GINTSTS_DISCONNINT | GINTSTS_PRTINT | GINTSTS_HCHINT; > dwc2_writel(intmsk, hsotg->regs + GINTMSK); > } > > Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscrib

Re: [PATCH 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 8/18/2015 8:45 AM, Scott Branden wrote: From: Roman Bacik rba...@broadcom.com USB OTG driver in isochronous mode has to set the parity of the receiving microframe. The parity is set to even by default. This causes problems for an audio gadget, if the host starts transmitting on odd

Re: [PATCH v3] usb: dwc2: Use platform endianness when accessing registers

-by: John Youn johny...@synopsys.com Hi Felipe, Can you queue this for 4.4? I can remind you after the merge window. Regards, John -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 7/7] usb: dwc2: refactor common low-level hw code to platform.c

On 8/21/2015 5:39 AM, Marek Szyprowski wrote: > DWC2 module on some platforms needs three additional hardware > resources: phy controller, clock and power supply. All of them must be > enabled/activated to properly initialize and operate. This was initially > handled in s3c-hsotg driver, which has

Re: [PATCH] gadget: added besl support

On 9/4/2015 3:58 AM, Joao Pinto wrote: > When testing the Synopsys DWC USB 3.0 Device IP, Compliant Tests are run > for USB 3.0 and USB 2.0. An issue was found regarding the USB 2.0 CV > Chapter 9 test: LPM L1 Suspend Resume Test. For it to be successful it > is necessary to add besl support to

Re: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 8/31/2015 9:17 AM, Scott Branden wrote: > From: Roman Bacik > > USB OTG driver in isochronous mode has to set the parity of the receiving > microframe. The parity is set to even by default. This causes problems for > an audio gadget, if the host starts transmitting on odd

Re: [PATCH 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 8/25/2015 3:00 PM, Roman Bacik wrote: -Original Message- From: John Youn [mailto:john.y...@synopsys.com] Sent: August-25-15 2:52 PM To: Scott Branden; John Youn; Greg Kroah-Hartman; linux- u...@vger.kernel.org Cc: linux-ker...@vger.kernel.org; bcm-kernel-feedback-list; Roman Bacik

Re: [PATCH v1 03/32] usb: dwc2: host: add flag to reflect bus state

On 9/9/2015 3:20 AM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > lx_state must be used to reflect controller power state only and not > bus state. Thus add a flag to track state during bus suspend. > > Signed-off-by: Gregory Herrero

Re: [PATCH v1 23/32] usb: dwc2: gadget: abort core init if core_reset fails

On 9/9/2015 3:21 AM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > No point of continue with initialization if core is not in a sane > state. > > Signed-off-by: Gregory Herrero > Signed-off-by: Mian Yousaf Kaukab

Re: [PATCH v1 00/32] usb: dwc2: various bug fixes

On 9/9/2015 3:20 AM, Mian Yousaf Kaukab wrote: > Hi, > This series consists of various bug fixes for both host and gadget > sides. All patches are verified on dwc2 v3.0a with dedicated fifos. > It would be good to get some Tested-bys for other platforms. > > It is based on testing/next branch in

Re: [PATCH v1 27/32] usb: dwc2: gadget: kill ep0 requests before reinitializing core

On 9/9/2015 3:21 AM, Mian Yousaf Kaukab wrote: > Make sure there are no requests pending on ep0 before reinitializing > core. Otherwise, dwc2_hsotg_enqueue_setup will fail afterwards. > > Signed-off-by: Mian Yousaf Kaukab > Tested-by: Robert Baldyga

Re: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 9/9/2015 11:16 AM, Roman Bacik wrote: >> -Original Message- >> From: John Youn [mailto:john.y...@synopsys.com] >> Sent: September-03-15 11:53 PM >> To: Scott Branden; John Youn; Greg Kroah-Hartman; linux- >> u...@vger.kernel.org; Roman Bacik >> C

Re: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 9/10/2015 10:56 AM, Roman Bacik wrote: >> -Original Message- >> From: Roman Bacik >> Sent: September-09-15 7:59 PM >> To: 'John Youn'; Scott Branden; 'Greg Kroah-Hartman'; 'linux- >> u...@vger.kernel.org' >> Cc: 'linux-ker...@vger.kernel.org'; bcm

Re: [PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

On 9/9/2015 7:16 PM, Roman Bacik wrote: >> -Original Message- >> From: John Youn [mailto:john.y...@synopsys.com] >> Sent: September-09-15 7:11 PM >> To: Roman Bacik; John Youn; Scott Branden; Greg Kroah-Hartman; linux- >> u...@vger.kernel.org >> Cc: linu

  1   2   3   4   5   6   7   8   9   10   >