This makes sure that the name coming out of configfs cannot be used
accidentally as a format string.
Signed-off-by: Kees Cook keesc...@chromium.org
---
drivers/usb/gadget/tcm_usb_gadget.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/tcm_usb_gadget.c
This makes sure that the name coming out of configfs cannot be used
accidentally as a format string.
Signed-off-by: Kees Cook keesc...@chromium.org
Cc: sta...@vger.kernel.org
---
v2:
- with stable cc; Felipe Balbi.
---
drivers/usb/gadget/tcm_usb_gadget.c |2 +-
1 file changed, 1 insertion
driver */
> + dev_err(idev, "Not able to get a minor for this device.\n");
> + usb_set_intfdata (interface, NULL);
> + goto error;
> + }
> + dev->minor = interface->minor;
> +
> + /* let the user kn
n <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/phy/phy-isp1301-omap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/phy/phy-isp1301-omap.c
b/drivers/usb/phy/phy-is
Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Raviteja Garimella <raviteja.garime...@broadcom.com>
Cc: Michal Nazarewicz <min...@mina86.com>
Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc..
c: linux-usb@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Cc: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
t;
Cc: linux-usb@vger.kernel.org
Cc: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
soires <benjamin.tissoi...@redhat.com>
Cc: linux-in...@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback
org
Cc: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/net/usb/usbnet.c | 12 +++
Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/serial/garmin_gps.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_
com>
Cc: Michal Nazarewicz <min...@mina86.com>
Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/gadget/udc/snps_udc_core.c | 19 ++-
1 file changed, 6 insert
c: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/phy/phy-mv-usb.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/phy/phy-mv-usb.c b/drivers/usb/phy/phy-mv-usb.c
index 0e315694adc9..fc9ed047d25d 100644
c: linux-usb@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
Acked-by: Tony Lindgren <t...@atomide.com>
---
drivers/usb/phy/phy-isp1301-omap.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-isp13
...@mork.no>
Cc: "Stefan Brüns" <stefan.bru...@rwth-aachen.de>
Cc: Alexey Dobriyan <adobri...@gmail.com>
Cc: Greg Ungerer <g...@linux-m68k.org>
Cc: linux-usb@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/net/us
t;
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/host/xhci-mem.c | 4 ++--
drivers/usb/host/xhci-ring.c | 9 +++--
drivers/usb/host/xhci.h | 2 +-
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/host/xhci-m
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/net/usb/usbnet.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 6510e5cc1817..80348b6a8646 100644
--- a/drivers/net/usb/usbnet.c
+++ b/dri
On Sun, Sep 3, 2017 at 2:12 PM, Michal Nazarewicz <min...@mina86.com> wrote:
> On Thu, Aug 31 2017, Kees Cook wrote:
>> With timer initialization made earlier at the start, there is no reason
>> to make del_timer_sync() calls conditionally, there by removing the
>
ING_WITH_NULL_LEN, GFP_KERNEL);
> + if (!str)
> + return -ENOMEM;
> + }
> + strcpy(str, s);
> if (str[ret - 1] == '\n')
> str[ret - 1] = '\0';
> - kfree(copy);
> *s_copy = str;
> return 0;
> }
> --
> 2.7.4
>
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
n <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/phy/phy-isp1301-omap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/phy/phy-isp1301-omap.c
b/drivers/usb/phy/phy-is
ja Garimella <raviteja.garime...@broadcom.com>
Cc: Michal Nazarewicz <min...@mina86.com>
Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/gadget/udc/snps_udc_core.c | 16
> complex conflicts.
FWIW, timer_setup() should be preferred over setup_timer().
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
conflicting tree to minimise any
> particularly complex conflicts.
FWIW, timer_setup() should be preferred over setup_timer().
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/gadget/legacy/zero.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/legacy/zero.c b/drivers/usb/ga
structure for devices to use for their per-device
timer.
Cc: Bin Liu <b-...@ti.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/musb/am35x.c | 24 +++-
@embeddedor.com>
Cc: Bhumika Goyal <bhumi...@gmail.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/isp1760/isp1760-hcd.c | 8 +---
drivers/usb/isp1760/isp1760-udc.c | 7 +++
2 files changed, 8 insertions(+), 7 deletions(-)
gt;
Cc: Felipe Balbi <felipe.ba...@linux.intel.com>
Cc: Alan Stern <st...@rowland.harvard.edu>
Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/misc/usbtest.c | 22 ++
: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Chris Brandt <chris.bra...@renesas.com>
Cc: Julia Lawall <julia.law...@lip6.fr>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/host/r8a66597-hcd.c | 27 ++---
gt;
Cc: Duncan Sands <duncan.sa...@free.fr>
Cc: Allen Pais <allen.l...@gmail.com>
Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com>
Cc: accessrunner-gene...@lists.sourceforge.net
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org&
roah-Hartman <gre...@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/usbip/vudc_transfer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/usbip/vudc_transfer.c
b/drivers/usb/usb
Sorry, I sent this one but forgot that timer_setup_on_stack() is in
-next only. If it's okay, I can carry it in the timers tree.
Thanks!
-Kees
On Tue, Oct 24, 2017 at 12:27 PM, Felipe Balbi
<felipe.ba...@linux.intel.com> wrote:
> Kees Cook <keesc...@chromium.org> writes:
>
This also uses timer_setup_on_stack() (only in -next). If it's okay,
I'll carry it in the timers tree.
Thanks!
-Kees
On Tue, Oct 24, 2017 at 12:08 PM, Kees Cook <keesc...@chromium.org> wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all tim
apouillou.net>
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Cc: Shawn Lin <shawn@rock-chips.com>
Cc: Arvind Yadav <arvind.yadav...@gmail.com>
Cc: Allen <allen.l...@gmail.com>
Cc: linux-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-amlo..
On Tue, Oct 24, 2017 at 10:55 AM, Allen Pais <allen.p...@oracle.com> wrote:
> Switch to using the new timer_setup() and from_timer()
> for drivers/hid/*
>
> Cc: Kees Cook <keesc...@chromium.org>
> Signed-off-by: Allen Pais <allen.p...@oracle.com>
Yup, this matche
gt;
> - del_timer_sync(>timer);
> + del_timer_sync(>dev_timer);
> usb_phy_shutdown(musb->xceiv);
> phy_power_off(musb->phy);
> phy_exit(musb->phy);
> @@ -1028,7 +1027,7 @@ static int dsps_suspend(struct device *dev)
>
d-by: Stefan Wahren <stefan.wah...@i2se.com>
> Signed-off-by: Douglas Anderson <diand...@chromium.org>
> Cc: Kees Cook <keesc...@chromium.org>
Acked-by: Kees Cook <keesc...@chromium.org>
This matches my automated Coccinelle output for this code. (Actually,
it's better beca
Instead of kmalloc() with manually calculated values followed by
multiple strcpy()/strcat() calls, just fold it all into a single
kasprintf() call.
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/misc/chaoskey.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
-off-by: Himanshu Jha <himanshujha199...@gmail.com>
Reviewed-by: Kees Cook <keesc...@chromium.org>
-Kees
> ---
> drivers/usb/isp1760/isp1760-udc.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> v2:
>-removed the useless local variable devname.
>
> di
t the set_fs() usage? We've
been try to eliminate it in the kernel. I thought there was a safer
way to use iters now?
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More m
oogle.com>
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 67 +---
drivers/video/console/dummycon.c| 69 +
drivers/video/console/newport_con.c | 10 ++---
drivers/vide
.
Signed-off-by: Kees Cook <keesc...@chromium.org>
---
include/linux/console.h | 58 +++--
1 file changed, 32 insertions(+), 26 deletions(-)
diff --git a/include/linux/console.h b/include/linux/console.h
index b8920a031a3e..dfd6b0e97855 100644
--- a/i
This is a small series that cleans up struct consw a bit and
prepares it for Control Flow Integrity checking (i.e. Clang's
-fsanitize=cfi).
Thanks!
-Kees
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo
As done in commit:
724ba8b30b04 ("console/dummy: leave .con_font_get set to NULL")
This drops the dummy .con_font_get(), as it could leave arguments
uninitialized.
Cc: Thomas Winischhofer <tho...@winischhofer.net>
Signed-off-by: Kees Cook <keesc...@chromium.org>
42 matches
Mail list logo
