Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Laurent Pinchart
needs them? All the platforms we are concerned with here (exynos and omap, plus new platforms) can be booted using DT anyway. What about non-DT architectures such as MIPS (still widely used in consumer networking equipments from what I've heard) ? -- Regards, Laurent Pinchart -- To unsubscribe

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Laurent Pinchart
Hi Arnd, On Thursday 25 July 2013 13:00:49 Arnd Bergmann wrote: On Thursday 25 July 2013, Laurent Pinchart wrote: On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote: On Tuesday 23 July 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul

[GIT PULL FOR v3.12] UVC gadget fix

2013-08-09 Thread Laurent Pinchart
at: git://linuxtv.org/pinchartl/uvcvideo.git uvc-gadget for you to fetch changes up to cba76eb78667c8429916475618db0559ee2d9cbf: usb: gadget/uvc: Fix error handling in uvc_queue_buffer() (2013-08-09 15:45:17 +0200) Laurent Pinchart (1

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-20 Thread Laurent Pinchart
): [74a6af256b4816bf95ca59323dc06b8001673a43] USB: EHCI: work around silicon bug in Intel's EHCI controllers I've CC'ed Alan Stern, the author of the commit. Alan, would you be able to help Jürgen ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-31 Thread Laurent Pinchart
you try testing this on a different computer? Alan Stern -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-09-01 Thread Laurent Pinchart
to 0x100 (modprobe uvcvideo quirks=0x100) 4. Replug your webcam 5. Enjoy :-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-09-02 Thread Laurent Pinchart
(running as root if possible) ? But the good thing is, I've learned very much. Thanks to Alan and Laurent for the help. You're welcome. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-09-02 Thread Laurent Pinchart
On Monday 02 September 2013 13:59:52 Jürgen Liebmann wrote: Hi Laurent, in the attachment you find the output of lsusb. Thank you. I've updated the supported devices list on the uvcvideo driver's web page. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line

Re: [PATCH 31/51] DMA-API: media: omap3isp: use dma_coerce_mask_and_coherent()

2013-09-26 Thread Laurent Pinchart
on the DMA mask. It can be replaced with dma_coerce_mask_and_coherent(), avoiding the direct initialization of this mask. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/omap3isp/isp.c |6

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-09 Thread Laurent Pinchart
; /* true: PCI USB host 2, false: USBSS */ +}; + +#endif -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-09 Thread Laurent Pinchart
Hi Valentine, On Thursday 10 October 2013 01:21:27 Valentine wrote: On 10/10/2013 12:32 AM, Laurent Pinchart wrote: Hi Valentine, Hi Laurent, Thank you for the patch. On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: This adds RCAR Gen2 USB phy support. The driver

[PATCH 09/12] usb: gadget: r8a66597-udc: Convert to clk_prepare/unprepare

2013-10-28 Thread Laurent Pinchart
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and clk_disable_unprepare() to get ready for the migration to the common clock framework. Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

[PATCH 10/12] usb: r8a66597-hcd: Convert to clk_prepare/unprepare

2013-10-28 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/usb/host/r8a66597-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 2ad004a..a2fdd85 100644 --- a/drivers/usb/host

[PATCH 00/12] Prepare various SH/R Mobile/Car drivers for CCF migration

2013-10-28 Thread Laurent Pinchart
: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: linux-fb...@vger.kernel.org Laurent Pinchart (12): clocksource: sh_cmt: Add clk_prepare/unprepare support clocksource: sh_mtu2: Add clk_prepare/unprepare support clocksource: sh_tmu: Add

Re: [PATCH] usb: phy: Move R-Car Gen2 driver registration to postcore_inictall

2013-10-29 Thread Laurent Pinchart
) +{ + platform_driver_unregister(rcar_gen2_usb_phy_driver); +} +module_exit(rcar_gen2_usb_phy_mod_exit); MODULE_LICENSE(GPL v2); MODULE_DESCRIPTION(Renesas R-Car Gen2 USB phy); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 09/12] usb: gadget: r8a66597-udc: Convert to clk_prepare/unprepare

2013-11-09 Thread Laurent Pinchart
Hi Felipe, On Tuesday 29 October 2013 18:47:19 Shimoda, Yoshihiro wrote: Hi Laurent-san, (2013/10/29 7:49), Laurent Pinchart wrote: Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and clk_disable_unprepare() to get ready for the migration to the common clock

Re: [PATCH 10/12] usb: r8a66597-hcd: Convert to clk_prepare/unprepare

2013-11-09 Thread Laurent Pinchart
Hi Greg, On Tuesday 29 October 2013 18:47:26 Shimoda, Yoshihiro wrote: Hi Laurent-san, (2013/10/29 7:49), Laurent Pinchart wrote: Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and clk_disable_unprepare() to get ready for the migration to the common clock framework

Re: [PATCH] uvc: fix race of open and suspend in error case

2013-01-10 Thread Laurent Pinchart
be triggered when the device is opened just between usb_autopm_put_interface() and atomic_dec(stream-dev-users). The fix is trivial. Reported-by: Ming Lei tom.leim...@gmail.com Signed-off-by: Oliver Neukum oneu...@suse.de Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com The patch

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-01-21 Thread Laurent Pinchart
a couple of days to review the patches. I'll take them in my tree with the other UVC gadget patches I have and I'll send you a pull request. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-01-22 Thread Laurent Pinchart
= V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] uvc_v4l2: reset connection on uvc open

2013-01-24 Thread Laurent Pinchart
); v4l2_fh_add(handle-vfh); + usb_gadget_disconnect(cdev-gadget); + usb_gadget_connect(cdev-gadget); + handle-device = uvc-video; file-private_data = handle-vfh; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [RFC PATCH] uvc_v4l2: reset connection on uvc open

2013-01-24 Thread Laurent Pinchart
Hi Michael, On Thursday 24 January 2013 14:54:01 Michael Grzeschik wrote: On Thu, Jan 24, 2013 at 12:02:12PM +0100, Laurent Pinchart wrote: On Thursday 24 January 2013 11:22:02 Michael Grzeschik wrote: The current implementation of the composite framework connects the gadget function

Re: [RFC PATCH] uvc_v4l2: reset connection on uvc open

2013-01-24 Thread Laurent Pinchart
Hi Felipe, On Thursday 24 January 2013 16:42:50 Felipe Balbi wrote: On Thu, Jan 24, 2013 at 03:35:58PM +0100, Michael Grzeschik wrote: On Thu, Jan 24, 2013 at 03:21:37PM +0100, Laurent Pinchart wrote: On Thursday 24 January 2013 14:54:01 Michael Grzeschik wrote: On Thu, Jan 24, 2013

Re: [PATCH] uvcvideo: Be tolerant about IO errors

2013-02-03 Thread Laurent Pinchart
in the kernel log. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-02-07 Thread Laurent Pinchart
Hi Bhupesh, On Wednesday 30 January 2013 15:56:52 Bhupesh SHARMA wrote: On Monday, January 21, 2013 6:16 PM Laurent Pinchart wrote: On Friday 18 January 2013 20:46:59 Felipe Balbi wrote: On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote: This patchset tries to enhance

Re: [PATCH V3 2/5] usb: gadget/uvc: Make video streaming buffer size compliant to USB3.0 SS specs

2013-02-07 Thread Laurent Pinchart
; + video-req_size = video-ep-maxpacket * video-ep-maxburst * + (video-ep-mult + 1); + return 0; error: -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH V3 4/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2013-02-07 Thread Laurent Pinchart
to the UVC gadget. Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com This looks good to me, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com I've applied it to my tree with the commit message reflowed to fit into git's 72 characters default line length. --- drivers/usb

Re: [PATCH V3 5/5] usb: gadget/uvc: Add support for 'get_unmapped_area' for MMUless architectures

2013-02-07 Thread Laurent Pinchart
v4l2_file_operations uvc_v4l2_fops = { .ioctl = uvc_v4l2_ioctl, .mmap = uvc_v4l2_mmap, .poll = uvc_v4l2_poll, +#ifndef CONFIG_MMU + .get_unmapped_area = uvc_v4l2_get_unmapped_area, +#endif }; -- Regards, Laurent Pinchart -- To unsubscribe from

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-02-07 Thread Laurent Pinchart
Hi Bhupesh, On Thursday 07 February 2013 23:39:07 Laurent Pinchart wrote: On Wednesday 30 January 2013 15:56:52 Bhupesh SHARMA wrote: On Monday, January 21, 2013 6:16 PM Laurent Pinchart wrote: On Friday 18 January 2013 20:46:59 Felipe Balbi wrote: On Thu, Jan 17, 2013 at 04:23:48PM

Re: [PATCH V3 1/5] usb: gadget/uvc: Fix VS_INPUT_HEADER.bEndpointAddress and Video Streaming.bEndpointAddress values

2013-02-11 Thread Laurent Pinchart
for that branch would be appreciated. We can then work on getting your remaining patches ready for mainline. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V3 2/5] usb: gadget/uvc: Make video streaming buffer size compliant to USB3.0 SS specs

2013-02-11 Thread Laurent Pinchart
Hi Bhupesh, On Monday 11 February 2013 21:27:50 Bhupesh SHARMA wrote: On Friday, February 08, 2013 4:22 AM Laurent Pinchart wrote: On Thursday 17 January 2013 16:23:50 Bhupesh Sharma wrote: As per the USB3.0 specs, the bandwidth requirements of a UVC's video streaming endpoint

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-02-11 Thread Laurent Pinchart
and also Laurent's and then probably you can add your Tested-By. @ Laurent, would that be fine? What are your use cases that require vb2 dma-contig instead of vb2 vmalloc ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-02-11 Thread Laurent Pinchart
| 543 - drivers/usb/gadget/uvc_queue.h | 30 ++-- drivers/usb/gadget/uvc_v4l2.c | 56 +++-- drivers/usb/gadget/uvc_video.c | 27 ++- 7 files changed, 271 insertions(+), 432 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: [PATCH V3 3/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-02-11 Thread Laurent Pinchart
for pending events if the fh has the v4l2_fh type. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 3/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-02-11 Thread Laurent Pinchart
e-mail look like the last issues that need to be fixed. + return ret; } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] usb: gadget/uvc: Implement videobuf2 .wait_prepare and .wait_finish operations

2013-02-11 Thread Laurent Pinchart
. Implement them to avoid blocking qbuf or streamoff calls when a dqbuf is in progress. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com I've taken the patch in my tree and will wait for v4 of [1] before pushing it upstream

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-02-11 Thread Laurent Pinchart
Hi Michael, On Monday 11 February 2013 16:14:00 Michael Grzeschik wrote: On Mon, Feb 11, 2013 at 04:02:23PM +0100, Laurent Pinchart wrote: On Friday 08 February 2013 23:38:59 Bhupesh SHARMA wrote: [snip] Beside my two comments on patch 3 i have tested it with the contig

Re: [PATCH V3 2/5] usb: gadget/uvc: Make video streaming buffer size compliant to USB3.0 SS specs

2013-02-12 Thread Laurent Pinchart
Hi Bhupesh, On Tuesday 12 February 2013 16:48:08 Bhupesh SHARMA wrote: On Monday 11 February 2013 21:27:50 Bhupesh SHARMA wrote: On Friday, February 08, 2013 4:22 AM Laurent Pinchart wrote: On Thursday 17 January 2013 16:23:50 Bhupesh Sharma wrote: [snip] diff --git a/drivers/usb

[PATCH 01/12] usb: gadget/uvc: Clarify comment about string descriptors

2013-03-01 Thread Laurent Pinchart
The comment that describes string descriptors allocation isn't clear, fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-03-01 Thread Laurent Pinchart
? I've taken the patch in my tree. I've just sent a consolidated series of most pending UVC gadget patches to the list, and I will send you a pull request as soon as I receive a Tested-by. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

[PATCH 03/12] usb: gadget/uvc: Fix coding style issues introduced by SS support

2013-03-01 Thread Laurent Pinchart
Let's keep the code consistent, people might want to read it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 58 +++--- drivers/usb/gadget/f_uvc.h | 12 +- 2 files changed, 35 insertions(+), 35

[PATCH 11/12] usb: gadget/uvc: Use GFP_ATOMIC under spin lock

2013-03-01 Thread Laurent Pinchart
From: Cyril Roelandt tipec...@gmail.com Found using the following semantic patch: spml @@ @@ spin_lock_irqsave(...); ... when != spin_unlock_irqrestore(...); * GFP_KERNEL /spml Signed-off-by: Cyril Roelandt tipec...@gmail.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[PATCH 09/12] usb: gadget/uvc: Delay the status stage when setting alternate setting 1

2013-03-01 Thread Laurent Pinchart
-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c| 15 +-- drivers/usb/gadget/uvc.h | 1 + drivers/usb/gadget/uvc_v4l2.c | 14 +- 3 files changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/f_uvc.c b

[PATCH 10/12] usb: gadget/uvc: Make video streaming buffer size comply with USB3.0 SS

2013-03-01 Thread Laurent Pinchart
adds the above-mentioned support and is also USB2.0 backward compliant. Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_video.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

[PATCH 06/12] usb: gadget/uvc: Configure the streaming endpoint based on the speed

2013-03-01 Thread Laurent Pinchart
Call the appropriate usb_ep_autoconf*() function depending on the device speed, and pass it the corresponding streaming endpoint. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 19 --- 1 file changed, 12 insertions(+), 7

[PATCH 05/12] usb: gadget/uvc: Merge the streaming maxpacket and mult parameters

2013-03-01 Thread Laurent Pinchart
Compute the multiplier from the maximum packet size based on the speed. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 120 ++--- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers

[PATCH 02/12] usb: gadget/uvc: Rename STATUS_BYTECOUNT to UVC_STATUS_MAX_PACKET_SIZE

2013-03-01 Thread Laurent Pinchart
Descriptive names make the code more readable. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c index 2d08cc9

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-03-03 Thread Laurent Pinchart
Hi Felipe, On Sunday 03 March 2013 01:23:46 Felipe Balbi wrote: On Fri, Mar 01, 2013 at 08:47:34PM +0100, Laurent Pinchart wrote: On Wednesday 27 February 2013 10:26:23 Felipe Balbi wrote: On Sat, Feb 02, 2013 at 03:48:54PM +0800, Chen Gang wrote: for NUL terminated string, better

Re: [PATCH 00/12] UVC gadget patches for v3.10

2013-03-11 Thread Laurent Pinchart
Hi Bhupesh, On Monday 11 March 2013 15:07:05 Bhupesh SHARMA wrote: On Saturday, March 02, 2013 1:16 AM Laurent Pinchart wrote: Hello, Here are the miscellaneous fixes and enhacements for the UVC gadget driver that I would like to push for v3.10. All the patches have already been

Re: [PATCH 4/6] usb: gadget: uvc: remove references to DMA_ADDR_INVALID

2013-03-14 Thread Laurent Pinchart
false expectations to gadget driver writers. Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [patch] usb gadget: uvc: use capped length value

2013-03-14 Thread Laurent Pinchart
Hi Dan, Thanks for the patch. On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote: req-length is a capped version of data-length. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Good catch. Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Felipe, could you please pick

Re: [PATCH V4 0/2] UVC webcam gadget related changes

2013-03-27 Thread Laurent Pinchart
the patches. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: [PATCH V4 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-27 Thread Laurent Pinchart
uvc_queue_streaming(struct uvc_video_queue *queue) { - return queue-flags UVC_QUEUE_STREAMING; + return vb2_is_streaming(queue-queue); } #endif /* __KERNEL__ */ [snip] -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH V4 2/2] usb: gadget/uvc: Add support for 'get_unmapped_area' for MMUless architectures

2013-03-27 Thread Laurent Pinchart
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_queue.c | 18 ++ drivers/usb/gadget/uvc_v4l2.c | 15 +++ 2 files changed, 33 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/uvc_queue.c b/drivers/usb

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread Laurent Pinchart
comes from. You should also make sure that no other IRQ handler on the system keeps IRQs disabled for a long time. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Laurent Pinchart
(if you're running on an SMP system). -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
; spin_unlock_irqrestore(queue-irqlock, flags); mutex_unlock(queue-mutex); + return ret; } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
for a vb2 to be successfully absorbed at the USB side. Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com Finally, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com :-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
that the application space daemon is not left in a state waiting for a vb2 to be successfully absorbed at the USB side. Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com Finally, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com :-) Thanks for your

[PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-03-28 Thread Laurent Pinchart
The camera fails to start video streaming after having been autosuspend. Add a new quirk to selectively disable autosuspend for devices that don't support it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/usb/uvc/uvc_driver.c | 14 +- drivers

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-29 Thread Laurent Pinchart
. It is not odd to see I/O performance isn't very good on ARM... -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: usb video capture issue due to uvc_complete callback spends more time

2013-04-04 Thread Laurent Pinchart
(TDs) can be queued and HW executes the transfers on the bus without SW intervention. In case of musb host controller, the SW has to program the urb one by one, hence it is critical that urb completion callback called in interrupt context must be very thin. -- Regards, Laurent Pinchart

Re: [PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-04-04 Thread Laurent Pinchart
Hi Alan, On Thursday 28 March 2013 10:45:27 Alan Stern wrote: On Thu, 28 Mar 2013, Laurent Pinchart wrote: The camera fails to start video streaming after having been autosuspend. Add a new quirk to selectively disable autosuspend for devices that don't support it. Signed-off

Re: usb video capture issue due to uvc_complete callback spends more time

2013-04-04 Thread Laurent Pinchart
On Thursday 04 April 2013 19:49:26 Felipe Balbi wrote: On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote: Laurent/Ming Lei Since the uvc_video_complete() callback handler called from interrupt context, video post processing or memcpy can be deferred

Re: Fwd: USB2 isochronous camera not working on USB3 port

2013-04-08 Thread Laurent Pinchart
, and the output of lsusb -v for the device. This is with 3.8.2 opensuse Kernel Of The Day Regards, Jean-Philippe François PS : I am not subscribed to the list, can I be cc'ed in the reply ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux

Re: Fwd: USB2 isochronous camera not working on USB3 port

2013-04-08 Thread Laurent Pinchart
Hi Jean-Philippe, On Monday 08 April 2013 14:08:09 jean-philippe francois wrote: 2013/4/8 Laurent Pinchart laurent.pinch...@ideasonboard.com: On Wednesday 06 March 2013 14:21:14 jean-philippe francois wrote: Hi, The company I work for is doing USB cameras, for which I wrote

Re: [Test Application PATCH 0/2] UVC gadget test application enhancements

2013-04-15 Thread Laurent Pinchart
, can you please test this application patch at your end and provide your feedbacks? The first patch is pretty big, but I'll try to review it soon. Next time could you please try to split those large patches in a set of smaller patches ? -- Regards, Laurent Pinchart -- To unsubscribe from

Re: [PATCH] usb: gadget/uvc: Implement videobuf2 .wait_prepare and .wait_finish operations

2013-04-15 Thread Laurent Pinchart
Hi Michael, On Monday 15 April 2013 14:36:27 Michael Grzeschik wrote: On Mon, Feb 11, 2013 at 08:43:44PM +0100, Laurent Pinchart wrote: On Saturday 09 February 2013 00:54:54 Michael Grzeschik wrote: Those optional operations are used to release and reacquire the queue lock when videobuf2

Re: [PATCH] usb: gadget/uvc: Implement videobuf2 .wait_prepare and .wait_finish operations

2013-04-23 Thread Laurent Pinchart
On Tuesday 23 April 2013 14:16:56 Felipe Balbi wrote: On Mon, Apr 15, 2013 at 02:45:39PM +0200, Laurent Pinchart wrote: Those optional operations are used to release and reacquire the queue lock when videobuf2 needs to perform operations that sleep for a long time, such as waiting

[PATCH] usb: gadget/uvc: Remove unneeded endpoint descriptor fields initialization

2013-04-29 Thread Laurent Pinchart
The streaming endpoint bandwidth parameters are computed are runtime from module parameters. Remove the corresponding static initializers. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[PATCH 0/2] Clock fixes for UVC gadget driver

2014-03-23 Thread Laurent Pinchart
) queued for v3.15. It would thus be easier to merge it through the media tree. Greg and Mauro, would that be fine ? Alternatively I can rebase it on top of v3.15-rc1 when that version will be tagged. Laurent Pinchart (2): usb: gadget: uvc: Switch to monotonic clock for buffer timestamps usb: gadget

[PATCH 1/2] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

2014-03-23 Thread Laurent Pinchart
The wall time clock isn't useful for applications as it can jump around due to time adjustement. Switch to the monotonic clock. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_queue.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions

[PATCH 2/2] usb: gadget: uvc: Set the vb2 queue timestamp flags

2014-03-23 Thread Laurent Pinchart
] [2.105567] [ cut here ] [2.106779] WARNING: CPU: 0 PID: 1 at drivers/media/v4l2-core/videobuf2-core.c:2207 vb2_queue_init+0xa3/0x113() Fix it. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb

Re: [PATCH 1/2] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

2014-03-28 Thread Laurent Pinchart
Hi Hans, On Friday 28 March 2014 09:50:42 Hans Verkuil wrote: On 03/23/2014 04:32 PM, Laurent Pinchart wrote: The wall time clock isn't useful for applications as it can jump around due to time adjustement. Switch to the monotonic clock. Signed-off-by: Laurent Pinchart laurent.pinch

[PATCH v2 1/3] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

2014-03-28 Thread Laurent Pinchart
The wall time clock isn't useful for applications as it can jump around due to time adjustement. Switch to the monotonic clock. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_queue.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions

[PATCH v2 2/3] usb: gadget: uvc: Set the V4L2 buffer field to V4L2_FIELD_NONE

2014-03-28 Thread Laurent Pinchart
The UVC gadget driver doesn't support interlaced video but left the buffer field uninitialized. Set it to V4L2_FIELD_NONE. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget

[PATCH v2 3/3] usb: gadget: uvc: Set the vb2 queue timestamp flags

2014-03-28 Thread Laurent Pinchart
] [2.105567] [ cut here ] [2.106779] WARNING: CPU: 0 PID: 1 at drivers/media/v4l2-core/videobuf2-core.c:2207 vb2_queue_init+0xa3/0x113() Fix it. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans

[PATCH v2 0/3] Miscellaneous fixes for UVC gadget driver

2014-03-28 Thread Laurent Pinchart
872484ce40881e295b046adf21f7211306477751 (v4l: Add timestamp source flags, mask and document them) queued for v3.15. It would thus be easier to merge it through the media tree. Greg and Mauro, would that be fine ? Alternatively I can rebase it on top of v3.15-rc1 when that version will be tagged. Laurent Pinchart

Re: [PATCH] Support for write-only controls

2007-12-15 Thread Laurent Pinchart
I should have guessed that the mailing list rejects html attachments. Here's the mail again with the plain text dump only. On Saturday 15 December 2007, Greg KH wrote: On Sat, Dec 15, 2007 at 11:56:02AM +0100, Laurent Pinchart wrote: On Friday 14 December 2007, Greg KH wrote: On Fri, Dec

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-07-07 Thread Laurent Pinchart
Hi Bhupesh, On Tuesday 03 July 2012 23:42:59 Bhupesh SHARMA wrote: Hi Laurent, Thanks for your review and sorry for being late with my replies. I have a lot on my plate these days :) No worries, I'm no less busy anyway :-) On Tuesday, June 19, 2012 4:19 AM Laurent Pinchart wrote

Re: [PATCH 5/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2012-07-07 Thread Laurent Pinchart
Hi Bhupesh, On Tuesday 03 July 2012 23:47:14 Bhupesh SHARMA wrote: On Wednesday, June 20, 2012 3:19 AM Laurent Pinchart wrote: On Friday 01 June 2012 15:08:58 Bhupesh Sharma wrote: This patch adds the support in UVC webcam gadget design for providing USB_GADGET_DELAYED_STATUS in response

Re: [PATCH] From 2.6.39-rc1 onward, the Logitech Quickcam Fusion webcam (046d:08c1) stops

2012-07-08 Thread Laurent Pinchart
of the probe sequence ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] From 2.6.39-rc1 onward, the Logitech Quickcam Fusion webcam (046d:08c1) stops

2012-07-08 Thread Laurent Pinchart
the firmware contained something like events = read(IRQ_EVENTS register); write(IRQ_EVENTS registers, 0x); I'm unfortunately not surprised by device-side bugs anymore. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH] From 2.6.39-rc1 onward, the Logitech Quickcam Fusion webcam (046d:08c1) stops

2012-07-15 Thread Laurent Pinchart
Hi Oleksij, On Monday 09 July 2012 07:35:54 Oleksij Rempel wrote: Am 08.07.2012 23:35, schrieb Laurent Pinchart: On Sunday 08 July 2012 10:45:45 Oleksij Rempel wrote: On 08.07.2012 09:22, Eric Ding wrote: On 07/08/2012 02:52 PM, Oleksij Rempel (fishor) wrote: Hi, can you please do one

Re: [PATCH] From 2.6.39-rc1 onward, the Logitech Quickcam Fusion webcam (046d:08c1) stops

2012-07-15 Thread Laurent Pinchart
with both solutions. Handling the quirks in the USB core has my preference, as it would ensure that no race condition will cause any issue at probe time. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Laurent Pinchart
Hi Alan, On Tuesday 17 July 2012 10:47:39 Alan Stern wrote: On Tue, 17 Jul 2012, Laurent Pinchart wrote: Most Logitech UVC webcams (both early models that don't advertise UVC compatibility and newer UVC-advertised devices) require the RESET_RESUME quirk. Instead of listing each and every

[PATCH v2 0/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-18 Thread Laurent Pinchart
been tested with a Logitech C905 webcam and with a non-Logitech UVC webcam. The RESET_RESUME quirk gets enabled for the Logitech camera only. Laurent Pinchart (2): usb: Add quirk detection based on interface information usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams drivers/usb

[PATCH v2 2/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-18 Thread Laurent Pinchart
Most Logitech UVC webcams (both early models that don't advertise UVC compatibility and newer UVC-advertised devices) require the RESET_RESUME quirk. Instead of listing each and every model, match the devices based on the UVC interface information. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [PATCH v2 2/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-18 Thread Laurent Pinchart
Hi Bjørn, On Wednesday 18 July 2012 14:47:35 Bjørn Mork wrote: Laurent Pinchart laurent.pinch...@ideasonboard.com writes: static const struct usb_device_id usb_interface_quirk_list[] = { + /* Logitech UVC Cameras */ + { .match_flags = USB_DEVICE_ID_MATCH_VENDOR

[PATCH v3 0/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-18 Thread Laurent Pinchart
for the Logitech camera only. Laurent Pinchart (2): usb: Add quirk detection based on interface information usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams drivers/usb/core/driver.c | 38 +++- drivers/usb/core/hub.c|2 + drivers/usb/core/quirks.c | 151

Re: [PATCH v3 1/2] usb: Add quirk detection based on interface information

2012-07-18 Thread Laurent Pinchart
Hi Alan, On Wednesday 18 July 2012 10:59:41 Alan Stern wrote: On Wed, 18 Jul 2012, Laurent Pinchart wrote: When a whole class of devices (possibly from a specific vendor, or across multiple vendors) require a quirk, explictly listing all devices in the class make the quirks table

[PATCH v4 0/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-19 Thread Laurent Pinchart
Hi, Here's the fourth version of the Logitech UVC devices RESET_RESUME quirk patches. Compared to v3, the usb_detect_interface_quirks() has been moved to usb_enumerate_device(). Laurent Pinchart (2): usb: Add quirk detection based on interface information usb: Add USB_QUIRK_RESET_RESUME

Re: controlling record light on camera

2012-07-24 Thread Laurent Pinchart
to create mappings automatically when the camera is plugged in. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-25 Thread Laurent Pinchart
Hi Bhupesh, On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote: On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote: On Wednesday 25 July 2012 15:06:37 Bhupesh SHARMA wrote: [snip] It's been almost a month since this RFC was circulated. As no comments have been

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Laurent Pinchart
Hi Felipe, On Thursday 26 July 2012 10:45:56 Felipe Balbi wrote: On Thu, Jul 26, 2012 at 01:23:01AM +0200, Laurent Pinchart wrote: On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote: On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote: On Wednesday 25 July 2012 15:06:37

Re: [PATCH 0/3] Fixes for UVC test suite (available in USBCV) failures

2012-07-29 Thread Laurent Pinchart
, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/6] UVC gadget cleanup

2012-08-01 Thread Laurent Pinchart
the patches, especially the ones that touch super speed support ? I have no SS hardware I can test them on. Laurent Pinchart (6): usb: gadget/uvc: Clarify comment about string descriptors usb: gadget/uvc: Rename STATUS_BYTECOUNT to UVC_STATUS_MAX_PACKET_SIZE usb: gadget/uvc: Fix coding style

[PATCH 5/6] usb: gadget/uvc: Merge the streaming maxpacket and mult parameters

2012-08-01 Thread Laurent Pinchart
Compute the multiplier from the maximum packet size based on the speed. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 116 +--- 1 files changed, 55 insertions(+), 61 deletions(-) diff --git a/drivers

[PATCH 3/6] usb: gadget/uvc: Fix coding style issues introduced by SS support

2012-08-01 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 58 ++-- drivers/usb/gadget/f_uvc.h | 12 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers

[PATCH 4/6] usb: gadget/uvc: Merge the SS/HS/FS status endpoint descriptors

2012-08-01 Thread Laurent Pinchart
The descriptors are identical, there's no need to have several copies of them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/f_uvc.c | 52 +++ 1 files changed, 18 insertions(+), 34 deletions(-) diff --git

  1   2   3   4   5   6   >