The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions
The UVC gadget driver doesn't support interlaced video but left the
buffer field uninitialized. Set it to V4L2_FIELD_NONE.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget
]
[2.105567] [ cut here ]
[2.106779] WARNING: CPU: 0 PID: 1 at
drivers/media/v4l2-core/videobuf2-core.c:2207 vb2_queue_init+0xa3/0x113()
Fix it.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Reviewed-by: Hans
872484ce40881e295b046adf21f7211306477751 (v4l: Add timestamp source
flags, mask and document them) queued for v3.15. It would thus be easier to
merge it through the media tree. Greg and Mauro, would that be fine ?
Alternatively I can rebase it on top of v3.15-rc1 when that version will be
tagged.
Laurent Pinchart
) queued for v3.15. It would thus be easier to
merge it through the media tree. Greg and Mauro, would that be fine ?
Alternatively I can rebase it on top of v3.15-rc1 when that version will be
tagged.
Laurent Pinchart (2):
usb: gadget: uvc: Switch to monotonic clock for buffer timestamps
usb: gadget
The wall time clock isn't useful for applications as it can jump around
due to time adjustement. Switch to the monotonic clock.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions
]
[2.105567] [ cut here ]
[2.106779] WARNING: CPU: 0 PID: 1 at
drivers/media/v4l2-core/videobuf2-core.c:2207 vb2_queue_init+0xa3/0x113()
Fix it.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb
Hi Robert,
On Tuesday 10 December 2013 12:40:33 Robert Baldyga wrote:
Hello,
This patchset fixes UVC gadget test application, created by Laurent Pinchart
(git tree available here: git://git.ideasonboard.org/uvc-gadget.git), with
applied patches created by Bhupesh Sharma (which can be found
Hi Robert,
[Repost with Bhupesh's hopefully correct e-mail address]
On Tuesday 10 December 2013 12:40:33 Robert Baldyga wrote:
Hello,
This patchset fixes UVC gadget test application, created by Laurent Pinchart
(git tree available here: git://git.ideasonboard.org/uvc-gadget.git
Hi Roger,
On Tuesday 03 December 2013 11:36:57 Roger Quadros wrote:
On 12/03/2013 05:54 AM, Laurent Pinchart wrote:
Hi Roger,
On Monday 25 November 2013 15:55:45 Roger Quadros wrote:
Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply
for the USB PHY.
As the generic
-microvolt = 180;
+ regulator-always-on;
+};
+
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, uvc_ss_control_cls,
- uvc_fs_streaming_cls, uvc_hs_streaming_cls,
- uvc_ss_streaming_cls);
+ return uvc_bind_config(c);
}
static struct usb_configuration webcam_config_driver = {
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe
-req.bRequestType USB_DIR_IN);
- uvc-event_length = uvc_event-req.wLength;
- }
-
return ret;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Hi Greg,
On Monday 25 November 2013 18:36:08 Greg Kroah-Hartman wrote:
On Tue, Nov 26, 2013 at 03:00:30AM +0100, Laurent Pinchart wrote:
On Saturday 09 November 2013 08:10:59 Greg Kroah-Hartman wrote:
On Sat, Nov 09, 2013 at 03:12:05PM +0100, Laurent Pinchart wrote:
On Tuesday 29
Hi Felipe,
On Tuesday 26 November 2013 13:54:22 Felipe Balbi wrote:
On Tue, Nov 26, 2013 at 03:16:47AM +0100, Laurent Pinchart wrote:
On Monday 25 November 2013 20:12:39 Felipe Balbi wrote:
On Tue, Nov 26, 2013 at 02:59:51AM +0100, Laurent Pinchart wrote:
(2013/10/29 7:49), Laurent
Hi Felipe,
On Monday 11 November 2013 13:53:31 Felipe Balbi wrote:
On Sat, Nov 09, 2013 at 03:09:33PM +0100, Laurent Pinchart wrote:
Hi Felipe,
On Tuesday 29 October 2013 18:47:19 Shimoda, Yoshihiro wrote:
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn
Hi Greg,
On Saturday 09 November 2013 08:10:59 Greg Kroah-Hartman wrote:
On Sat, Nov 09, 2013 at 03:12:05PM +0100, Laurent Pinchart wrote:
On Tuesday 29 October 2013 18:47:26 Shimoda, Yoshihiro wrote:
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable
Hi Felipe,
On Monday 25 November 2013 20:12:39 Felipe Balbi wrote:
Hi,
On Tue, Nov 26, 2013 at 02:59:51AM +0100, Laurent Pinchart wrote:
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into
clk_prepare_enable
Hi Felipe,
On Tuesday 29 October 2013 18:47:19 Shimoda, Yoshihiro wrote:
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock
Hi Greg,
On Tuesday 29 October 2013 18:47:26 Shimoda, Yoshihiro wrote:
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework
)
+{
+ platform_driver_unregister(rcar_gen2_usb_phy_driver);
+}
+module_exit(rcar_gen2_usb_phy_mod_exit);
MODULE_LICENSE(GPL v2);
MODULE_DESCRIPTION(Renesas R-Car Gen2 USB phy);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-usb@vger.kernel.org
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/usb/host/r8a66597-hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index 2ad004a..a2fdd85 100644
--- a/drivers/usb/host
: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com
Cc: Tomi Valkeinen tomi.valkei...@ti.com
Cc: linux-fb...@vger.kernel.org
Laurent Pinchart (12):
clocksource: sh_cmt: Add clk_prepare/unprepare support
clocksource: sh_mtu2: Add clk_prepare/unprepare support
clocksource: sh_tmu: Add
; /* true: PCI USB host 2, false: USBSS */
+};
+
+#endif
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Valentine,
On Thursday 10 October 2013 01:21:27 Valentine wrote:
On 10/10/2013 12:32 AM, Laurent Pinchart wrote:
Hi Valentine,
Hi Laurent,
Thank you for the patch.
On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote:
This adds RCAR Gen2 USB phy support. The driver
on the DMA mask. It can be replaced
with dma_coerce_mask_and_coherent(), avoiding the direct initialization
of this mask.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/platform/omap3isp/isp.c |6
(running as root if possible) ?
But the good thing is, I've learned very much.
Thanks to Alan and Laurent for the help.
You're welcome.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
On Monday 02 September 2013 13:59:52 Jürgen Liebmann wrote:
Hi Laurent, in the attachment you find the output of lsusb.
Thank you. I've updated the supported devices list on the uvcvideo driver's
web page.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line
to 0x100 (modprobe uvcvideo
quirks=0x100)
4. Replug your webcam
5. Enjoy :-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
you try testing this on a different computer?
Alan Stern
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
):
[74a6af256b4816bf95ca59323dc06b8001673a43] USB: EHCI: work around silicon bug
in Intel's EHCI controllers
I've CC'ed Alan Stern, the author of the commit. Alan, would you be able to
help Jürgen ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
at:
git://linuxtv.org/pinchartl/uvcvideo.git uvc-gadget
for you to fetch changes up to cba76eb78667c8429916475618db0559ee2d9cbf:
usb: gadget/uvc: Fix error handling in uvc_queue_buffer() (2013-08-09
15:45:17 +0200)
Laurent Pinchart (1
needs
them? All the platforms we are concerned with here (exynos and omap, plus
new platforms) can be booted using DT anyway.
What about non-DT architectures such as MIPS (still widely used in consumer
networking equipments from what I've heard) ?
--
Regards,
Laurent Pinchart
--
To unsubscribe
Hi Arnd,
On Thursday 25 July 2013 13:00:49 Arnd Bergmann wrote:
On Thursday 25 July 2013, Laurent Pinchart wrote:
On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote:
On Tuesday 23 July 2013, Tomasz Figa wrote:
On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote:
On Tue, 23 Jul
Hi Pratyush,
On Tuesday 02 July 2013 17:24:41 Pratyush Anand wrote:
On 6/20/2013 11:20 AM, Chetan Nanda wrote:
On Tue, Jun 18, 2013 at 6:12 PM, Laurent Pinchart wrote:
On Tuesday 18 June 2013 11:17:40 Chetan Nanda wrote:
Hi,
I am currently working with UVC camera device which send
Hi Alan,
On Monday 01 July 2013 15:39:46 Alan Stern wrote:
On Mon, 1 Jul 2013, Laurent Pinchart wrote:
What about error recovery for insane systems? If we do get a 50-ms gap
in the data stream, what's the best way for the UVC driver to learn this
has happens and attempt to carry
slot after
the last one used by the preceding URB, even if that time slot
has already expired.
Something in between...
What would be best for your purposes? Or do you have any different
suggestions?
--
Regards,
Laurent Pinchart
--
To unsubscribe
Hi Alan,
On Monday 01 July 2013 11:08:33 Alan Stern wrote:
On Mon, 1 Jul 2013, Laurent Pinchart wrote:
That's correct. Unlike the UAC driver, the UVC driver doesn't care too
much about exact timings. Avoiding packet loss is my main concern. As
video frames are not delivered to userspace
with
gstreamer.
Thanks,
Michael
Laurent Pinchart (1):
usb: gadget/uvc: Fix error handling in uvc_queue_buffer()
Michael Grzeschik (8):
usb: gadget/uvc: cancel the video queue if buffers could not be enqueued
usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT
usb: gadget
no bulk activity has been detected for a given amount
of time. A bit hackish, but I'm not sure if there's any other practical way.
Any pointer would be very helpful.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
Hi Michael,
On Friday 03 May 2013 10:37:40 Michael Grzeschik wrote:
Hi Laurent,
On Fri, May 03, 2013 at 01:20:15AM +0200, Laurent Pinchart wrote:
[snip]
I'm open to suggestions :-) What features of the userspace application do
you think could (and should) be moved to kernelspace ? Many
.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Vladimir,
On Monday 06 May 2013 13:42:45 Vladimir Zapolskiy wrote:
On 05/04/13 21:22, Bhupesh SHARMA wrote:
On 5/3/2013 6:00 PM, Vladimir Zapolskiy wrote:
On 05/03/13 02:05, Laurent Pinchart wrote:
On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote:
On 05/03/13 01:18, Laurent
Hi Michael,
On Thursday 02 May 2013 00:27:59 Michael Grzeschik wrote:
On Mon, Apr 29, 2013 at 10:26:49PM +0200, Laurent Pinchart wrote:
On Monday 29 April 2013 17:56:50 Michael Grzeschik wrote:
On Mon, Feb 11, 2013 at 08:42:37PM +0100, Laurent Pinchart wrote:
On Monday 04 February 2013
-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_v4l2.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
index ad48e81..e2b66e1 100644
Hi Vladimir,
On Friday 03 May 2013 02:00:29 Vladimir Zapolskiy wrote:
On 05/03/13 01:18, Laurent Pinchart wrote:
On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote:
This change removes redundant calls to uvc_function_connect() and
uvc_function_disconnect() on V4L2 device node open
Hi Michael,
On Friday 03 May 2013 00:34:40 Michael Grzeschik wrote:
On Fri, May 03, 2013 at 12:18:21AM +0200, Laurent Pinchart wrote:
On Friday 03 May 2013 01:13:48 Vladimir Zapolskiy wrote:
This change removes redundant calls to uvc_function_connect() and
uvc_function_disconnect
Hi Bhupesh,
On Wednesday 01 May 2013 01:31:18 Bhupesh SHARMA wrote:
On 4/29/2013 4:23 PM, Laurent Pinchart wrote:
On Thursday 11 April 2013 15:04:04 Bhupesh Sharma wrote:
This patch adds the support for Bulk endpoint to be used as video
streamingendpoint, on basis of a module parameter
Hi Bhupesh,
On Wednesday 01 May 2013 01:08:23 Bhupesh SHARMA wrote:
On 4/29/2013 8:08 PM, Laurent Pinchart wrote:
On Wednesday 17 April 2013 09:44:25 Bhupesh Sharma wrote:
This patch adds the support in UVC webcam gadget to allocate UVC header
and payload as Scatter-Gather elements which
The streaming endpoint bandwidth parameters are computed are runtime
from module parameters. Remove the corresponding static initializers.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 13 +++--
1 file changed, 3 insertions(+), 10
-max_payload_size = video-imagesize;
+
/* Initialize the video buffers queue. */
uvc_queue_init(video-queue, V4L2_BUF_TYPE_VIDEO_OUTPUT);
return 0;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
);
+ sg_set_buf(video-req[i]-sg,
+ (void *)video-header_buf, 2);
+ }
+
video-req[i]-length = 0;
video-req[i]-complete = uvc_video_complete;
video-req[i]-context = video;
--
Regards,
Laurent
Hi Michael,
On Monday 29 April 2013 17:56:50 Michael Grzeschik wrote:
On Mon, Feb 11, 2013 at 08:42:37PM +0100, Laurent Pinchart wrote:
On Monday 04 February 2013 11:58:27 Michael Grzeschik wrote:
On Thu, Jan 17, 2013 at 04:23:51PM +0530, Bhupesh Sharma wrote:
This patch reworks
as blatantly wrong. Could this be a bug in the test tool ?
Do the test pass if you connect the device to an EHCI controller ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tuesday 23 April 2013 14:16:56 Felipe Balbi wrote:
On Mon, Apr 15, 2013 at 02:45:39PM +0200, Laurent Pinchart wrote:
Those optional operations are used to release and reacquire the
queue lock when videobuf2 needs to perform operations that sleep for
a long time, such as waiting
, can you please test this application patch at your
end and provide your feedbacks?
The first patch is pretty big, but I'll try to review it soon. Next time could
you please try to split those large patches in a set of smaller patches ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from
Hi Michael,
On Monday 15 April 2013 14:36:27 Michael Grzeschik wrote:
On Mon, Feb 11, 2013 at 08:43:44PM +0100, Laurent Pinchart wrote:
On Saturday 09 February 2013 00:54:54 Michael Grzeschik wrote:
Those optional operations are used to release and reacquire the queue
lock when videobuf2
, and the output of lsusb -v for
the device.
This is with 3.8.2 opensuse Kernel Of The Day
Regards,
Jean-Philippe François
PS : I am not subscribed to the list, can I be cc'ed in the reply ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux
Hi Jean-Philippe,
On Monday 08 April 2013 14:08:09 jean-philippe francois wrote:
2013/4/8 Laurent Pinchart laurent.pinch...@ideasonboard.com:
On Wednesday 06 March 2013 14:21:14 jean-philippe francois wrote:
Hi,
The company I work for is doing USB cameras, for which I wrote
(TDs)
can be queued and HW executes the transfers on the bus without SW
intervention. In case of musb host controller, the SW has to program the
urb one by one, hence it is critical that urb completion callback called in
interrupt context must be very thin.
--
Regards,
Laurent Pinchart
Hi Alan,
On Thursday 28 March 2013 10:45:27 Alan Stern wrote:
On Thu, 28 Mar 2013, Laurent Pinchart wrote:
The camera fails to start video streaming after having been autosuspend.
Add a new quirk to selectively disable autosuspend for devices that
don't support it.
Signed-off
On Thursday 04 April 2013 19:49:26 Felipe Balbi wrote:
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote:
Laurent/Ming Lei
Since the uvc_video_complete() callback handler called from
interrupt
context, video post processing or memcpy can be deferred
.
It is not odd to see I/O performance isn't very good on ARM...
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(if you're running on an SMP system).
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
spin_unlock_irqrestore(queue-irqlock, flags);
mutex_unlock(queue-mutex);
+ return ret;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
for
a vb2 to be successfully absorbed at the USB side.
Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com
Finally,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
:-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
that the
application space daemon is not left in a state waiting for
a vb2 to be successfully absorbed at the USB side.
Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com
Finally,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
:-)
Thanks for your
The camera fails to start video streaming after having been autosuspend.
Add a new quirk to selectively disable autosuspend for devices that
don't support it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/usb/uvc/uvc_driver.c | 14 +-
drivers
the patches.
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
uvc_queue_streaming(struct uvc_video_queue *queue)
{
- return queue-flags UVC_QUEUE_STREAMING;
+ return vb2_is_streaming(queue-queue);
}
#endif /* __KERNEL__ */
[snip]
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_queue.c | 18 ++
drivers/usb/gadget/uvc_v4l2.c | 15 +++
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/uvc_queue.c b/drivers/usb
comes from. You should also make sure
that no other IRQ handler on the system keeps IRQs disabled for a long time.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
false expectations to gadget driver writers.
Signed-off-by: Felipe Balbi ba...@ti.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Hi Dan,
Thanks for the patch.
On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote:
req-length is a capped version of data-length.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Good catch.
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Felipe, could you please pick
Hi Bhupesh,
On Monday 11 March 2013 15:07:05 Bhupesh SHARMA wrote:
On Saturday, March 02, 2013 1:16 AM Laurent Pinchart wrote:
Hello,
Here are the miscellaneous fixes and enhacements for the UVC gadget driver
that I would like to push for v3.10.
All the patches have already been
Hi Felipe,
On Sunday 03 March 2013 01:23:46 Felipe Balbi wrote:
On Fri, Mar 01, 2013 at 08:47:34PM +0100, Laurent Pinchart wrote:
On Wednesday 27 February 2013 10:26:23 Felipe Balbi wrote:
On Sat, Feb 02, 2013 at 03:48:54PM +0800, Chen Gang wrote:
for NUL terminated string, better
The comment that describes string descriptors allocation isn't clear,
fix it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget
?
I've taken the patch in my tree.
I've just sent a consolidated series of most pending UVC gadget patches to the
list, and I will send you a pull request as soon as I receive a Tested-by.
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
Let's keep the code consistent, people might want to read it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 58 +++---
drivers/usb/gadget/f_uvc.h | 12 +-
2 files changed, 35 insertions(+), 35
From: Cyril Roelandt tipec...@gmail.com
Found using the following semantic patch:
spml
@@
@@
spin_lock_irqsave(...);
... when != spin_unlock_irqrestore(...);
* GFP_KERNEL
/spml
Signed-off-by: Cyril Roelandt tipec...@gmail.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c| 15 +--
drivers/usb/gadget/uvc.h | 1 +
drivers/usb/gadget/uvc_v4l2.c | 14 +-
3 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/f_uvc.c b
adds the above-mentioned support and is also USB2.0 backward
compliant.
Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/uvc_video.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
Call the appropriate usb_ep_autoconf*() function depending on the device
speed, and pass it the corresponding streaming endpoint.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 19 ---
1 file changed, 12 insertions(+), 7
Compute the multiplier from the maximum packet size based on the speed.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 120 ++---
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git a/drivers
Descriptive names make the code more readable.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c
index 2d08cc9
Hi Bhupesh,
On Tuesday 12 February 2013 16:48:08 Bhupesh SHARMA wrote:
On Monday 11 February 2013 21:27:50 Bhupesh SHARMA wrote:
On Friday, February 08, 2013 4:22 AM Laurent Pinchart wrote:
On Thursday 17 January 2013 16:23:50 Bhupesh Sharma wrote:
[snip]
diff --git a/drivers/usb
for that branch
would be appreciated. We can then work on getting your remaining patches ready
for mainline.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Hi Bhupesh,
On Monday 11 February 2013 21:27:50 Bhupesh SHARMA wrote:
On Friday, February 08, 2013 4:22 AM Laurent Pinchart wrote:
On Thursday 17 January 2013 16:23:50 Bhupesh Sharma wrote:
As per the USB3.0 specs, the bandwidth requirements of a UVC's video
streaming endpoint
and also Laurent's and then
probably you can add your Tested-By. @ Laurent, would that be fine?
What are your use cases that require vb2 dma-contig instead of vb2 vmalloc ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
| 543 -
drivers/usb/gadget/uvc_queue.h | 30 ++--
drivers/usb/gadget/uvc_v4l2.c | 56 +++--
drivers/usb/gadget/uvc_video.c | 27 ++-
7 files changed, 271 insertions(+), 432 deletions(-)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list
for pending events if
the fh has the v4l2_fh type.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e-mail look like the last issues that need to be fixed.
+ return ret;
}
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
. Implement them to
avoid blocking qbuf or streamoff calls when a dqbuf is in progress.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I've taken the patch in my tree and will wait for v4 of [1] before pushing it
upstream
Hi Michael,
On Monday 11 February 2013 16:14:00 Michael Grzeschik wrote:
On Mon, Feb 11, 2013 at 04:02:23PM +0100, Laurent Pinchart wrote:
On Friday 08 February 2013 23:38:59 Bhupesh SHARMA wrote:
[snip]
Beside my two comments on patch 3 i have tested it with the contig
Hi Bhupesh,
On Wednesday 30 January 2013 15:56:52 Bhupesh SHARMA wrote:
On Monday, January 21, 2013 6:16 PM Laurent Pinchart wrote:
On Friday 18 January 2013 20:46:59 Felipe Balbi wrote:
On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote:
This patchset tries to enhance
;
+ video-req_size = video-ep-maxpacket * video-ep-maxburst *
+ (video-ep-mult + 1);
+
return 0;
error:
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
to the
UVC gadget.
Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com
This looks good to me,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I've applied it to my tree with the commit message reflowed to fit into git's
72 characters default line length.
---
drivers/usb
v4l2_file_operations uvc_v4l2_fops = {
.ioctl = uvc_v4l2_ioctl,
.mmap = uvc_v4l2_mmap,
.poll = uvc_v4l2_poll,
+#ifndef CONFIG_MMU
+ .get_unmapped_area = uvc_v4l2_get_unmapped_area,
+#endif
};
--
Regards,
Laurent Pinchart
--
To unsubscribe from
Hi Bhupesh,
On Thursday 07 February 2013 23:39:07 Laurent Pinchart wrote:
On Wednesday 30 January 2013 15:56:52 Bhupesh SHARMA wrote:
On Monday, January 21, 2013 6:16 PM Laurent Pinchart wrote:
On Friday 18 January 2013 20:46:59 Felipe Balbi wrote:
On Thu, Jan 17, 2013 at 04:23:48PM
401 - 500 of 552 matches
Mail list logo
