in
the kernel log.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
v4l2_fh_add(handle-vfh);
+ usb_gadget_disconnect(cdev-gadget);
+ usb_gadget_connect(cdev-gadget);
+
handle-device = uvc-video;
file-private_data = handle-vfh;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Hi Michael,
On Thursday 24 January 2013 14:54:01 Michael Grzeschik wrote:
On Thu, Jan 24, 2013 at 12:02:12PM +0100, Laurent Pinchart wrote:
On Thursday 24 January 2013 11:22:02 Michael Grzeschik wrote:
The current implementation of the composite framework connects the
gadget function
Hi Felipe,
On Thursday 24 January 2013 16:42:50 Felipe Balbi wrote:
On Thu, Jan 24, 2013 at 03:35:58PM +0100, Michael Grzeschik wrote:
On Thu, Jan 24, 2013 at 03:21:37PM +0100, Laurent Pinchart wrote:
On Thursday 24 January 2013 14:54:01 Michael Grzeschik wrote:
On Thu, Jan 24, 2013
= V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
a couple of days to review the patches.
I'll take them in my tree with the other UVC gadget patches I have and I'll
send you a pull request.
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
be triggered when the device is opened just
between usb_autopm_put_interface() and atomic_dec(stream-dev-users).
The fix is trivial.
Reported-by: Ming Lei tom.leim...@gmail.com
Signed-off-by: Oliver Neukum oneu...@suse.de
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
The patch
Hi Bhupesh,
On Tuesday 08 January 2013 12:00:43 Bhupesh SHARMA wrote:
On Tuesday, January 08, 2013 2:13 AM Laurent Pinchart wrote:
On Wednesday 31 October 2012 15:06:54 Felipe Balbi wrote:
On Mon, Oct 22, 2012 at 10:15:05PM +0200, Sebastian Andrzej Siewior
wrote:
The video-minor = -1
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
and applied to my tree
---
drivers/usb/gadget/uvc_video.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/uvc_video.c b/drivers/usb/gadget/uvc_video.c
index b0e53a8..cd067a6 100644
);
IMHO, this should be two lines, aka:
ret = usb_ep_queue(video-ep, req, GFP_KERNEL);
if (ret0)
correct, please resend with the fix.
I agree as well.
--
Regards,
Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
Hi Felipe,
On Monday 22 October 2012 13:56:01 Felipe Balbi wrote:
On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote:
On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:
On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:
On Fri, Oct 19, 2012 at 06:19:26PM +0100
Hi Bhupesh,
On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
Hi,
These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's UVC
webcam gadget related changes patch series. They're what I would have asked
during patch review if the original patches hadn't been merged
|| !_req || !ep-ep.desc)
return -EINVAL;
Shouldn't that last check be done with a lock taken ?
spin_lock_irqsave(ep-udc-lock, flags);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Composite gadget support is now available as a library instead of being
built with each gadget. Composite drivers need to select
USB_LIBCOMPOSITE.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/Kconfig |1 +
1 files changed, 1 insertions(+), 0
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
MAINTAINERS |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d919e3d..b118b23 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7392,6 +7392,13 @@ S: Maintained
Hi,
The first patch in this series should fix the UVC gadget compilation errors in
linux-next. The second patch should make sure I'll be notified next time a
patch tries to break it :-)
Both patches are based on Linus' tree.
Laurent Pinchart (2):
usb: gadget: Make webcam gadget select
driver uses isochronous transfers, but doesn't care about which
frame URBs will be transferred. If there was an ASAP flag the driver would set
it.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Hi Alan,
On Thursday 13 September 2012 12:08:35 Alan Stern wrote:
On Thu, 13 Sep 2012, Laurent Pinchart wrote:
Hi Alan,
Sorry for the late answer, I've been travelling with no internet
connection.
No problem; thanks for joining the discussion.
For video ISO IN problems can
registrated.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Bhupesh Sharma bhupesh.sha...@st.com
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/f_uvc.c | 39 +--
1 file changed, 21 insertions(+), 18 deletions
be to just check timestamps on the host side when
starting a new video frame. I'm not sure whether the USB core could help with
this problem.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
Hi Felipe,
On Thursday 09 August 2012 11:18:47 Felipe Balbi wrote:
On Wed, Aug 01, 2012 at 02:57:10PM +0200, Laurent Pinchart wrote:
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I'm a bit pedantic about commit logs. please resend with proper commit
logs.
Sure. I'll
Hi Bhupesh,
On Tuesday 07 August 2012 23:07:56 Bhupesh SHARMA wrote:
On Tuesday, August 07, 2012 8:23 PM Laurent Pinchart wrote:
On Tuesday 31 July 2012 06:24:51 Bhupesh Sharma wrote:
This patch reworks the videobuffer management logic present in the
UVC webcam gadget and ports it to use
Hi Bhupesh,
On Thursday 09 August 2012 01:19:49 Bhupesh SHARMA wrote:
On Wednesday, August 08, 2012 5:32 PM Laurent Pinchart wrote:
On Tuesday 07 August 2012 23:07:56 Bhupesh SHARMA wrote:
On Tuesday, August 07, 2012 8:23 PM Laurent Pinchart wrote:
On Tuesday 31 July 2012 06:24:51
Hi Alan,
On Wednesday 08 August 2012 21:31:12 Alan Stern wrote:
On Wed, 8 Aug 2012, Laurent Pinchart wrote:
I guess it depends on the usb_ep_dequeue() API. The function documentation
doesn't clearly state whether calling it with an already dequeuing request
is valid (in which case
-by: Bhupesh Sharma bhupesh.sha...@st.com
With the indentation fixed,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I've added the patch to my tree, rebased on top of my cleanup patches. There's
no need to resubmit it.
---
drivers/usb/gadget/f_uvc.c |9 ++---
1 files changed
);
if (ret 0)
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bhupesh,
On Wednesday 01 August 2012 21:24:58 Bhupesh SHARMA wrote:
On Wednesday, August 01, 2012 6:40 PM Laurent Pinchart wrote;
On Tuesday 31 July 2012 06:24:52 Bhupesh Sharma wrote:
[snip]
diff --git a/drivers/usb/gadget/uvc_v4l2.c
b/drivers/usb/gadget/uvc_v4l2.c
index 134bfe5
Hi Bhupesh,
On Saturday 04 August 2012 00:31:38 Bhupesh SHARMA wrote:
On Friday, August 03, 2012 1:42 PM Laurent Pinchart wrote:
On Thursday 26 July 2012 10:42:51 Bhupesh Sharma wrote:
As per the UVC compliance test suite's assertion 6.1.25, the `iFunction`
field of the Interface
the patches, especially the ones that touch
super speed support ? I have no SS hardware I can test them on.
Laurent Pinchart (6):
usb: gadget/uvc: Clarify comment about string descriptors
usb: gadget/uvc: Rename STATUS_BYTECOUNT to
UVC_STATUS_MAX_PACKET_SIZE
usb: gadget/uvc: Fix coding style
Compute the multiplier from the maximum packet size based on the speed.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 116 +---
1 files changed, 55 insertions(+), 61 deletions(-)
diff --git a/drivers
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 58 ++--
drivers/usb/gadget/f_uvc.h | 12
2 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/gadget/f_uvc.c b/drivers
The descriptors are identical, there's no need to have several copies of
them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/usb/gadget/f_uvc.c | 52 +++
1 files changed, 18 insertions(+), 34 deletions(-)
diff --git
probably too big).
Can you please let me know your opinions and how you tested the UVC gadget's
MJPEG frame format.
[1] http://lxr.linux.no/linux+v3.5/drivers/usb/gadget/webcam.c#L232
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb
Hi Bhupesh,
On Wednesday 01 August 2012 21:12:51 Bhupesh SHARMA wrote:
On Wednesday, August 01, 2012 6:27 PM Laurent Pinchart wrote:
Hi,
These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's
UVC webcam gadget related changes patch series. They're what I would
have
,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Felipe,
On Thursday 26 July 2012 10:45:56 Felipe Balbi wrote:
On Thu, Jul 26, 2012 at 01:23:01AM +0200, Laurent Pinchart wrote:
On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote:
On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote:
On Wednesday 25 July 2012 15:06:37
Hi Bhupesh,
On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote:
On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote:
On Wednesday 25 July 2012 15:06:37 Bhupesh SHARMA wrote:
[snip]
It's been almost a month since this RFC was circulated.
As no comments have been
to create mappings automatically when the camera
is plugged in.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Here's the fourth version of the Logitech UVC devices RESET_RESUME quirk
patches. Compared to v3, the usb_detect_interface_quirks() has been moved to
usb_enumerate_device().
Laurent Pinchart (2):
usb: Add quirk detection based on interface information
usb: Add USB_QUIRK_RESET_RESUME
been tested with a Logitech C905 webcam and with a non-Logitech
UVC webcam. The RESET_RESUME quirk gets enabled for the Logitech camera only.
Laurent Pinchart (2):
usb: Add quirk detection based on interface information
usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams
drivers/usb
Most Logitech UVC webcams (both early models that don't advertise UVC
compatibility and newer UVC-advertised devices) require the RESET_RESUME
quirk. Instead of listing each and every model, match the devices based
on the UVC interface information.
Signed-off-by: Laurent Pinchart laurent.pinch
Hi Bjørn,
On Wednesday 18 July 2012 14:47:35 Bjørn Mork wrote:
Laurent Pinchart laurent.pinch...@ideasonboard.com writes:
static const struct usb_device_id usb_interface_quirk_list[] = {
+ /* Logitech UVC Cameras */
+ { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
for the Logitech camera only.
Laurent Pinchart (2):
usb: Add quirk detection based on interface information
usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams
drivers/usb/core/driver.c | 38 +++-
drivers/usb/core/hub.c|2 +
drivers/usb/core/quirks.c | 151
Hi Alan,
On Wednesday 18 July 2012 10:59:41 Alan Stern wrote:
On Wed, 18 Jul 2012, Laurent Pinchart wrote:
When a whole class of devices (possibly from a specific vendor, or
across multiple vendors) require a quirk, explictly listing all devices
in the class make the quirks table
Hi Alan,
On Tuesday 17 July 2012 10:47:39 Alan Stern wrote:
On Tue, 17 Jul 2012, Laurent Pinchart wrote:
Most Logitech UVC webcams (both early models that don't advertise UVC
compatibility and newer UVC-advertised devices) require the RESET_RESUME
quirk. Instead of listing each and every
Hi Oleksij,
On Monday 09 July 2012 07:35:54 Oleksij Rempel wrote:
Am 08.07.2012 23:35, schrieb Laurent Pinchart:
On Sunday 08 July 2012 10:45:45 Oleksij Rempel wrote:
On 08.07.2012 09:22, Eric Ding wrote:
On 07/08/2012 02:52 PM, Oleksij Rempel (fishor) wrote:
Hi, can you please do one
with both solutions. Handling the quirks in the USB core has my
preference, as it would ensure that no race condition will cause any issue at
probe time.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
of the probe
sequence ?
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the
firmware contained something like
events = read(IRQ_EVENTS register);
write(IRQ_EVENTS registers, 0x);
I'm unfortunately not surprised by device-side bugs anymore.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Hi Bhupesh,
On Tuesday 03 July 2012 23:42:59 Bhupesh SHARMA wrote:
Hi Laurent,
Thanks for your review and sorry for being late with my replies.
I have a lot on my plate these days :)
No worries, I'm no less busy anyway :-)
On Tuesday, June 19, 2012 4:19 AM Laurent Pinchart wrote
Hi Bhupesh,
On Tuesday 03 July 2012 23:47:14 Bhupesh SHARMA wrote:
On Wednesday, June 20, 2012 3:19 AM Laurent Pinchart wrote:
On Friday 01 June 2012 15:08:58 Bhupesh Sharma wrote:
This patch adds the support in UVC webcam gadget design for providing
USB_GADGET_DELAYED_STATUS in response
I should have guessed that the mailing list rejects html attachments. Here's
the mail again with the plain text dump only.
On Saturday 15 December 2007, Greg KH wrote:
On Sat, Dec 15, 2007 at 11:56:02AM +0100, Laurent Pinchart wrote:
On Friday 14 December 2007, Greg KH wrote:
On Fri, Dec
501 - 552 of 552 matches
Mail list logo
