[EHCI Debug Port] Linux fails to setup EHCI debug port

2014-02-17 Thread Lu, Baolu
Hi list, Linux kernel (3.12.8) fails to setup EHCI debug port on my Sandy Bridge server. This seems to be a normal thing as I tried on other machines and got the same result. This is the EHCI host controller information (printed by lspci -vvv) 00:1a.0 USB controller: Intel Corporation

Re: [EHCI Debug Port] Linux fails to setup EHCI debug port

2014-02-19 Thread Lu, Baolu
[0.00] ehci_setup failed [0.00] Malformed early option 'kgdbdbgp' ... ... It fails in dbgp_ehci_startup(). Thanks, Allen On 2/19/2014 1:01 AM, Felipe Balbi wrote: On Tue, Feb 18, 2014 at 09:01:29AM -0800, Greg KH wrote: On Tue, Feb 18, 2014 at 02:46:00PM +0800, Lu, Baolu wrote: Hi list

[PATCH 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-11 Thread Lu Baolu
When the xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some Intel platform may get a spurious wakeup, even if PCI PME# is disabled. http://marc.info/?l=linux-usbm=138194006009255w=2 Signed-off-by: Lu

[PATCH v2 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-12 Thread Lu Baolu
, that contains the commit 9777e3ce907d4cb5a513902a87ecd03b52499569 USB: xHCI: bus power management implementation. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb

USB keyboard on T100TA dock blocks system entering S3 when remote wakeup is enabled

2014-07-03 Thread Lu, Baolu
Hi, I am using an ASUS T100TA with dock attached. I installed Ubuntu Linux on eMMC and customized the kernel. I started from echo mem /sys/power/state. Kernel starts its processes to put the system into suspend mode. Before kernel executes to xhci_bus_suspend(), xHC USB 2 root hub port

[PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-08-28 Thread Lu Baolu
. With this quirk set, wakeup capability will be ignored during device configure. This patch could be back-ported to kernels as old as 2.6.39. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/core/hub.c | 6 -- drivers/usb/core/quirks.c | 4 include/linux/usb/quirks.h | 3

Re: [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-08-29 Thread Lu, Baolu
On 8/29/2014 7:59 PM, Sergei Shtylyov wrote: Hello. On 8/29/2014 8:26 AM, Lu Baolu wrote: This full-speed USB device generates spurious remote wakeup event as soon as USB_DEVICE_REMOTE_WAKEUP feature is set. As the result, Linux can't enter system suspend and S0ix power saving modes once

[PATCH v2 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-08-31 Thread Lu Baolu
. With this quirk set, wakeup capability will be ignored during device configure. This patch could be back-ported to kernels as old as 2.6.39. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/core/hub.c | 6 -- drivers/usb/core/quirks.c | 4 include/linux/usb/quirks.h | 3

Re: PROBLEM: XHCI Host Controller on Intel Panther Point with CDC/ACM dead after massive NAK

2014-09-10 Thread Lu, Baolu
Hi Andreas, I'd like to reproduce this problem in the lab. How can I get a CDC device? Thanks, -baolu On 9/10/2014 3:04 PM, Kasberger Andreas wrote: So I am back with more tests on this problem. Intel itself told us it is a problem on the driver for the XHCI host controller. I will put some

[PATCH 1/1] usb: xhci: fix comment for PORT_DEV_REMOVE

2014-09-16 Thread Lu Baolu
According to xHCI specification, PORT_DEV_REMOVE(bit 30) in PORTSC true means Device is non-removable. Reported-by: Juro Bystricky jurobystri...@hotmail.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-09-18 Thread Lu Baolu
On 09/18/2014 10:40 PM, Alan Stern wrote: Is this quirk doable? What's your opinions? It's okay with me. Acked-by: Alan Sternst...@rowland.harvard.edu Thank you Alan. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

[PATCH v3 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-09-18 Thread Lu Baolu
. With this quirk set, wakeup capability will be ignored during device configure. This patch could be back-ported to kernels as old as 2.6.39. Signed-off-by: Lu Baolu baolu...@linux.intel.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/core/hub.c | 6 -- drivers/usb/core

Re: USB3 WD drive failure on ASUS M5A 78L-M USB3

2014-09-25 Thread Lu, Baolu
Can you try with the latest kernel? On 9/24/2014 6:13 AM, Len Berman wrote: I'm running debian 7. Linux foobar 3.2.0-4-amd64 #1 SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux. I have a Passport drive which fails on the USB3 connector. It works fine on USB2. It also works fine as USB3 on my

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-09-30 Thread Lu, Baolu
On 9/30/2014 5:03 AM, Mark Knibbs wrote: Great. I hope someone else is motivated to reproduce the issue. It will take a long time for me to bisect due to my slow computer. Hi Mark, I tried to reproduce this issue. I connected a USB key under a full-speed hub. sg_rbuf returns error which I

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-10-09 Thread Lu Baolu
:10:28 +0800 Lu, Baolu baolu...@linux.intel.com wrote: On 9/30/2014 5:03 AM, Mark Knibbs wrote: Great. I hope someone else is motivated to reproduce the issue. It will take a long time for me to bisect due to my slow computer. Hi Mark, I tried to reproduce this issue. I connected a USB key under

Re: Poor performance with USB 1.1 drive connected to USB 3.0 port

2014-10-09 Thread Lu Baolu
On 10/09/2014 07:07 PM, Mark Knibbs wrote: [For removable media, it's a good idea to disable polling for medium changes before running a test. Depending on kernel distribution that could be achieved by doing udisks --inhibit-all-polling and/or for example echo -1

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-11 Thread Lu, Baolu
On 10/8/2014 11:52 PM, Alan Stern wrote: On Wed, 8 Oct 2014, Mathias Nyman wrote: Index: usb-3.17/drivers/usb/host/xhci-hub.c === --- usb-3.17.orig/drivers/usb/host/xhci-hub.c +++ usb-3.17/drivers/usb/host/xhci-hub.c @@ -1136,13

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-11 Thread Lu, Baolu
Hi Dmitry, Can you please try to disable wakeup of root hub instead of host controller? Regards, -baolu On 10/10/2014 3:16 PM, Dmitry Nezhevenko wrote: On Wed, Oct 08, 2014 at 12:38:35PM -0400, Alan Stern wrote: Dmitry, this gave me another idea. Can you test the patch below, _without_ the

Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

2014-10-15 Thread Lu, Baolu
On 10/15/2014 6:07 PM, Dmitry Nezhevenko wrote: On Sat, Oct 11, 2014 at 03:51:47PM +0800, Lu, Baolu wrote: Hi Dmitry, Can you please try to disable wakeup of root hub instead of host controller? Hi, Sorry for delay. Can you please suggest how to do this? I always do this with below steps

[PATCH 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-10-30 Thread Lu Baolu
. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci-pci.c | 42 ++ drivers/usb/host/xhci.h | 6 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 280dde9..3e7441a

[PATCH 3/3] usb: xhci: fix comment for PORT_DEV_REMOVE

2014-10-30 Thread Lu Baolu
According to xHCI specification, PORT_DEV_REMOVE(bit 30) in PORTSC true means Device is non-removable. Reported-by: Juro Bystricky jurobystri...@hotmail.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/3] Rework xhci: clear root port wake on bits if controller isn't wake-up capable

2014-10-30 Thread Lu Baolu
This serie of patch reworks commit ff8cbf250b448aac35589f6075082c3fcad8a8fe. This has been discussed at http://www.spinics.net/lists/linux-usb/msg114986.html It also includes a patch to fix a comment in drivers/usb/host/xhci.h. Lu Baolu (3): usb: xhci: Revert xhci: clear root port wake on bits

[PATCH 1/3] usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable

2014-10-30 Thread Lu Baolu
This reverts commit ff8cbf250b448aac35589f6075082c3fcad8a8fe. Commit ff8cbf250b448aac35589f6075082c3fcad8a8fe triggers the bug logged at https://bugzilla.kernel.org/show_bug.cgi?id=85701 Reported-by: Dmitry Nezhevenko d...@inhex.net Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers

Re: [PATCH 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-03 Thread Lu, Baolu
On 10/31/2014 10:28 PM, Alan Stern wrote: On Fri, 31 Oct 2014, Lu Baolu wrote: xhci: clear root port wake on bits if controller isn't wake-up capable When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, xhci_pci_suspend needs to clear all root port wake on bits

[PATCH v2 1/3] usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-04 Thread Lu Baolu
This reverts commit ff8cbf250b448aac35589f6075082c3fcad8a8fe. Commit ff8cbf250b448aac35589f6075082c3fcad8a8fe triggers the bug logged at https://bugzilla.kernel.org/show_bug.cgi?id=85701 Reported-by: Dmitry Nezhevenko d...@inhex.net Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers

[PATCH v2 3/3] usb: xhci: fix comment for PORT_DEV_REMOVE

2014-11-04 Thread Lu Baolu
According to xHCI specification, PORT_DEV_REMOVE(bit 30) in PORTSC true means Device is non-removable. Reported-by: Juro Bystricky jurobystri...@hotmail.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 0/3] Rework xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-04 Thread Lu Baolu
xhci controllers. Lu Baolu (3): usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe usb: xhci: fix comment for PORT_DEV_REMOVE drivers/usb/host/xhci-hub.c | 5 + drivers/usb/host

[PATCH v2 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-04 Thread Lu Baolu
-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 2a5d45b..cd57aae 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host

Re: [PATCH v2 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-04 Thread Lu, Baolu
On 11/5/2014 12:58 AM, Alan Stern wrote: On Tue, 4 Nov 2014, Lu Baolu wrote: xhci: clear root port wake on bits if controller isn't wake-up capable When system is being suspended, if host device is not wakeup capable, xhci_suspend() needs to clear all root port wake on bits. Otherwise, some

[PATCH v3 0/3] Rework xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-04 Thread Lu Baolu
wake-up capable to allowed to do wakeup in both comments and patch description. * Add Suggested-by: Alan Stern Changes in v2: * Should not be a quirk. * Should be applied to all xhci controllers. Lu Baolu (3): usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake

[PATCH v3 1/3] usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-04 Thread Lu Baolu
This reverts commit ff8cbf250b448aac35589f6075082c3fcad8a8fe. Commit ff8cbf250b448aac35589f6075082c3fcad8a8fe triggers the bug logged at https://bugzilla.kernel.org/show_bug.cgi?id=85701 Signed-off-by: Lu Baolu baolu...@linux.intel.com Reported-by: Dmitry Nezhevenko d...@inhex.net --- drivers

[PATCH v3 3/3] usb: xhci: fix comment for PORT_DEV_REMOVE

2014-11-04 Thread Lu Baolu
According to xHCI specification, PORT_DEV_REMOVE(bit 30) in PORTSC true means Device is non-removable. Signed-off-by: Lu Baolu baolu...@linux.intel.com Reported-by: Juro Bystricky jurobystri...@hotmail.com --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-04 Thread Lu Baolu
. Signed-off-by: Lu Baolu baolu...@linux.intel.com Suggested-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/xhci-pci.c | 2 +- drivers/usb/host/xhci-plat.c | 10 +- drivers/usb/host/xhci.c | 44 +++- drivers/usb/host/xhci.h

Re: [PATCH v3 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-05 Thread Lu, Baolu
On 11/6/2014 5:24 AM, Alan Stern wrote: On Wed, 5 Nov 2014, Lu Baolu wrote: xhci: clear root port wake on bits if controller isn't allowed to do wakeup When system is being suspended, if host device is not allowed to do wakeup, xhci_suspend() needs to clear all root port wake on bits

[PATCH v4 0/3] Rework xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-05 Thread Lu Baolu
. - Should be applied to all xhci controllers. Lu Baolu (3): usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe usb: xhci: fix comment for PORT_DEV_REMOVE drivers/usb/host/xhci

[PATCH v4 2/3] usb: xhci: This reworks ff8cbf250b448aac35589f6075082c3fcad8a8fe

2014-11-05 Thread Lu Baolu
. Signed-off-by: Lu Baolu baolu...@linux.intel.com Suggested-by: Alan Stern st...@rowland.harvard.edu Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/xhci-pci.c | 2 +- drivers/usb/host/xhci-plat.c | 10 +- drivers/usb/host/xhci.c | 42

[PATCH v4 3/3] usb: xhci: fix comment for PORT_DEV_REMOVE

2014-11-05 Thread Lu Baolu
According to xHCI specification, PORT_DEV_REMOVE(bit 30) in PORTSC true means Device is non-removable. Signed-off-by: Lu Baolu baolu...@linux.intel.com Reported-by: Juro Bystricky jurobystri...@hotmail.com --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4 1/3] usb: xhci: Revert xhci: clear root port wake on bits if controller isn't wake-up capable

2014-11-05 Thread Lu Baolu
This reverts commit ff8cbf250b448aac35589f6075082c3fcad8a8fe. Commit ff8cbf250b448aac35589f6075082c3fcad8a8fe triggers the bug logged at https://bugzilla.kernel.org/show_bug.cgi?id=85701 Signed-off-by: Lu Baolu baolu...@linux.intel.com Reported-by: Dmitry Nezhevenko d...@inhex.net --- drivers

Re: [xHCI bug report]: some USB3.0 devices will be re-enumerated immediately after we safely remove it(but not plug out the cable)

2014-11-24 Thread Lu, Baolu
Hi, Have you tried the latest kernel? Can below commit change anything? commit bb86cf569bbd7ad4dce581a37c7fbd748057e9dc Author: Gavin Guo gavin@canonical.com Date: Fri Jul 18 01:12:13 2014 +0800 usb: Check if port status is equal to RxDetect When using USB 3.0 pen drive

xhci: xhci_handle_cmd_stop_ep might give back urb incorrectly

2014-11-24 Thread Lu, Baolu
; } while (cur_td != last_unlinked_td); [end of code segment] Beset Regards, Lu Baolu -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: xhci: xhci_handle_cmd_stop_ep might give back urb incorrectly

2014-11-24 Thread Lu, Baolu
On 2014年11月24日 23:33, Alan Stern wrote: On Mon, 24 Nov 2014, Lu, Baolu wrote: Hi Mathias, Alan and all, During xhci handling a completion event for stop endpoint command , xhci_handle_cmd_stop_ep() always gives back a urb with status set to 0. The comment says, /* Doesn't

Re: [PATCH 06/19] usb: dwc3: host: Pass the XHCI_DRD_SUPPORT and XHCI_NEEDS_LHC_RESET quirk

2014-11-26 Thread Lu, Baolu
On 2014年11月25日 21:11, George Cherian wrote: Pass the quir flag XHCI_DRD_SUPPORT from DWC3 host to xhci platform driver. quir to quirk Regards, Baolu This enables xhci driver to handle deallocation's differently while in DRD mode. Pass the quirk flag XHCI_NEEDS_LHC_RESET from DWC3 host to

Re: Control message failures kill entire XHCI stack

2015-03-10 Thread Lu, Baolu
Hi Devin, Do you mind to post output of lspci -xv on the machine where you saw this problem? We are facing the same problems in other cases. I could provide a patch for it later. Thanks, Baolu On 01/19/2015 04:55 AM, Devin Heitmueller wrote: Hello, I'm debugging some issues on a couple

Re: [PATCH 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to Intel ValleyView and LynxPoint LP

2015-03-12 Thread Lu, Baolu
On 03/12/2015 04:46 PM, Mathias Nyman wrote: On 12.03.2015 03:39, Lu Baolu wrote: When a device with an isochronous endpoint is plugged into the Intel xHCI host controller, and the driver submits multiple frames per URB, the xHCI driver will set the Block Event Interrupt (BEI) flag on all

Re: [PATCH 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to Intel ValleyView and LynxPoint LP

2015-03-12 Thread Lu, Baolu
On 03/12/2015 03:54 PM, Greg Kroah-Hartman wrote: On Thu, Mar 12, 2015 at 09:39:06AM +0800, Lu Baolu wrote: When a device with an isochronous endpoint is plugged into the Intel xHCI host controller, and the driver submits multiple frames per URB, the xHCI driver will set the Block Event

[PATCH v2 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to all Intel xHCI controllers

2015-03-12 Thread Lu Baolu
to user. This patch is to apply XHCI_AVOID_BEI quirk to Intel xHC devices. And it should be backported to kernels as old as 3.0, that contains the commit 69e848c2090a (Intel xhci: Support EHCI/xHCI port switching.). Signed-off-by: Lu Baolu baolu...@linux.intel.com Cc: sta...@vger.kernel.org

Re: [PATCH 1/1] usb: xhci: handle Config Error Change (CEC) in xhci driver

2015-03-08 Thread Lu, Baolu
Hi Alan, Do you have any comments for this patch? Thanks, Baolu On 03/06/2015 04:12 PM, Lu Baolu wrote: Linux xHCI driver doesn't report and handle port cofig error change. If Port Configure Error for root hub port occurs, CEC bit in PORTSC would be set by xHC and remains 1. This happends

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-11 Thread Lu, Baolu
On 03/11/2015 02:49 AM, Alan Stern wrote: On Tue, 10 Mar 2015, Mathias Nyman wrote: Mathias: Your patch description says this: The endpoint might already processesed some TRBs on the endpiont ring before we soft reset the endpoint. Make sure we set the dequeue pointer to where we were

[PATCH v3 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to all Intel xHCI controllers

2015-03-12 Thread Lu Baolu
to user. This patch is to apply XHCI_AVOID_BEI quirk to Intel xHC devices. And it should be backported to kernels as old as 3.0, that contains the commit 69e848c2090a (Intel xhci: Support EHCI/xHCI port switching.). Signed-off-by: Lu Baolu baolu...@linux.intel.com Tested-by: Alistair Grant

Re: xhci_hcd : Not enough bandwidth on HS bus for newly activated TT.

2015-03-05 Thread Lu, Baolu
On 03/05/2015 09:17 PM, Kenneth Johansson wrote: On 2015-03-05 03:23, Lu, Baolu wrote: Hi Kenneth Johansson, Did you still get the bandwidth error when testing it with longer time? no I have not seen it on any 3.19 kernel I have used so far. But It could take a week to see it before so

Re: Control message failures kill entire XHCI stack

2015-03-10 Thread Lu, Baolu
Devin On Tue, Mar 10, 2015 at 5:55 AM, Lu, Baolu baolu...@linux.intel.com wrote: Hi Devin, Do you mind to post output of lspci -xv on the machine where you saw this problem? We are facing the same problems in other cases. I could provide a patch for it later. Thanks, Baolu On 01/19/2015 04

[PATCH 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to Intel ValleyView and LynxPoint LP

2015-03-11 Thread Lu Baolu
. As the result, the xHC looks like dead to user. The patch is to apply XHCI_AVOID_BEI to Intel VallyView and Lynx Point LP devices. And it should be backported to kernels as old as 3.0, that contains the commit 69e848c2090a (Intel xhci: Support EHCI/xHCI port switching.) Signed-off-by: Lu Baolu baolu

Re: xhci_hcd : Not enough bandwidth on HS bus for newly activated TT.

2015-03-02 Thread Lu, Baolu
. so I guess I get it like 5 minutes after I send this ;) On 2015-03-02 03:37, Lu, Baolu wrote: Include Kenneth Johansson. On 2015-03-02 10:33, Lu, Baolu wrote: I tried to reproduce this issue on an Intel Ivybridge machine. But I failed. Kernel version: 4.0.0-rc1 (built against master branch

Re: xhci_hcd : Not enough bandwidth on HS bus for newly activated TT.

2015-03-04 Thread Lu, Baolu
Hi Kenneth Johansson, Did you still get the bandwidth error when testing it with longer time? Thanks, Baolu On 2015-03-03 10:06, Lu, Baolu wrote: cc'ed usb mailing list. On 2015-03-02 21:23, Kenneth Johansson wrote: I have been running 3.19 prereleases and now 3.19 and have not got

Re: xhci_hcd : Not enough bandwidth on HS bus for newly activated TT.

2015-03-01 Thread Lu, Baolu
I tried to reproduce this issue on an Intel Ivybridge machine. But I failed. Kernel version: 4.0.0-rc1 (built against master branch of Greg's usb tree) USB fabric: $ sudo lsusb -t /: Bus 04.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/3p, 480M |__ Port 1: Dev 2, If 0, Class=Hub,

[PATCH 1/1] usb: xhci: handle Config Error Change (CEC) in xhci driver

2015-03-06 Thread Lu Baolu
in xhci_clear_port_change_bit(). [Mathias Nyman contributed the idea. The commit log is based on patch posted at http://marc.info/?l=linux-kernelm=142323612321434w=2] Signed-off-by: Lu Baolu baolu...@linux.intel.com Cc: stable sta...@vger.kernel.org # v3.2+ --- drivers/usb/host/xhci-hub.c | 9 - 1 file

Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-23 Thread Lu, Baolu
On 03/18/2015 08:40 PM, Heikki Krogerus wrote: + +/** + * ulpi_register_driver - unregister a driver with the ULPI bus Hi Heikki, ulpi_register_driver should be changed to ulpi_unregister_driver. Thanks, Baolu + * @drv: driver to unregister + * + * Unregisters a driver with the ULPI bus. +

[RFC][PATCH 2/3] usb: xhci: implement hc_driver notify entry

2015-05-03 Thread Lu Baolu
, it will ring doorbells for all endpoints unconditionally. XHC may use these hints to optimize its operation on endpoint state cashes. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 2 +- drivers/usb/host/xhci.c | 28 drivers/usb

[PATCH v2 2/3] usb: xhci: implement device_suspend/device_resume entries

2015-05-06 Thread Lu Baolu
the suspend. device_resume will be called when a USB device is just resumed. It will ring doorbells of all endpoint unconditionally. XHC may use these suspend/resume hints to optimize its operation. Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 2 +- drivers

Re: [PATCH 1/1] usb: ulpi: ulpi_init should be used in subsys_initcall

2015-05-21 Thread Lu, Baolu
On 05/21/2015 03:33 PM, Heikki Krogerus wrote: On Thu, May 21, 2015 at 01:40:43PM +0800, Lu Baolu wrote: The intention of this change is to fix below kernel panic when USB_ULPI_BUS was configured as buildin. That is actually incorrect. Having the bus build-in does not cause this panic

Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

2015-05-21 Thread Lu, Baolu
On 05/21/2015 05:22 AM, David Cohen wrote: Hi, On Wed, May 20, 2015 at 03:33:26PM -0400, Sasha Levin wrote: ULPI registers it's bus at module_init so if the bus fails to register, the A minor comment: s/it's/its/ module will fail to load and all will be well in the world. However, if the

[PATCH 1/1] usb: ulpi: ulpi_init should be used in subsys_initcall

2015-05-20 Thread Lu Baolu
] kernel_init+0xe/0xf0 [0.935266] [81b0f442] ret_from_fork+0x42/0x70 [0.941315] [81affed0] ? rest_init+0x90/0x90 Reported-by: Zhuo Qiuxu qiuxu.z...@intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/1] usb: ulpi: don't register drivers if bus doesn't exist

2015-05-21 Thread Lu Baolu
, which will panic the kernel. Fix that by checking that the bus was indeed initialized before trying to register drivers on top of it. Signed-off-by: Sasha Levin sasha.le...@oracle.com Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com

Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-06-04 Thread Lu, Baolu
On 06/04/2015 08:17 PM, Heikki Krogerus wrote: Hi Baolu, On Thu, May 28, 2015 at 08:50:12AM +0800, Lu, Baolu wrote: On 05/28/2015 12:53 AM, David Cohen wrote: Hi, On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote: On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote

Re: USB3 external HDD not recognized [regression]

2015-06-07 Thread Lu, Baolu
On 06/06/2015 04:56 AM, Ralf Jung wrote: Hi, I got some untested and not yet reviewed usb3 resume race fixes from Zhuang Jin Can If you can try them out and see if they help it would be great. They are sitting in a topic branch called xhci_usb3_pm_fixes in my tree: (5 extra patches on top

Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend

2015-06-25 Thread Lu, Baolu
On 06/25/2015 10:53 PM, Mathias Nyman wrote: On 09.05.2015 04:15, Lu Baolu wrote: There is no need to call xhci_stop_device() and xhci_ring_device() in hub control and bus suspend functions since all device suspend and resume have been notified through device_suspend/device_resume interfaces

Re: [PATCH 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-12 Thread Lu, Baolu
On 06/12/2015 12:32 PM, Greg Kroah-Hartman wrote: On Fri, Jun 12, 2015 at 09:29:37AM +0800, Lu Baolu wrote: Commit 25cd2882e2fc (usb/xhci: Change how we indicate a host supports Link PM.) removed the code to set lpm_capable for USB 3.0 super-speed root hub. The intention of that change

[PATCH v2 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-13 Thread Lu Baolu
...@vger.kernel.org # 3.15 Reported-by: Kevin Strasser kevin.stras...@linux.intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/core/hcd.c | 7 +-- drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 6 ++ 3 files changed, 12 insertions(+), 3 deletions(-) v1-v2

Re: [PATCH 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-12 Thread Lu, Baolu
On 06/13/2015 01:43 AM, Alan Stern wrote: On Fri, 12 Jun 2015, Lu Baolu wrote: Commit 25cd2882e2fc (usb/xhci: Change how we indicate a host supports Link PM.) removed the code to set lpm_capable for USB 3.0 super-speed root hub. The intention of that change was to avoid touching usb core

[PATCH v4 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-15 Thread Lu Baolu
...@vger.kernel.org # 3.15 Reported-by: Kevin Strasser kevin.stras...@linux.intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/core/hcd.c | 7 +-- drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 1 + 3 files changed, 7

[PATCH 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-11 Thread Lu Baolu
...@vger.kernel.org # 3.15 Reported-by: Kevin Strasser kevin.stras...@linux.intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/core/hcd.c | 6 ++ drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH v3 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-14 Thread Lu Baolu
...@vger.kernel.org # 3.15 Reported-by: Kevin Strasser kevin.stras...@linux.intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/core/hcd.c | 7 +-- drivers/usb/core/hub.c | 2 +- drivers/usb/core/usb.h | 1 + 3 files changed, 7 insertions(+), 3 deletions(-) v1-v2 change

Re: [PATCH v2 1/1] usb: core: lpm: set lpm_capable for root hub device

2015-06-14 Thread Lu, Baolu
On 06/13/2015 11:00 PM, Alan Stern wrote: On Sat, 13 Jun 2015, Lu Baolu wrote: Commit 25cd2882e2fc (usb/xhci: Change how we indicate a host supports Link PM.) removed the code to set lpm_capable for USB 3.0 super-speed root hub. The intention of that change was to avoid touching usb core

[PATCH v5 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-06-04 Thread Lu Baolu
. Reported-by: Zhuo Qiuxu qiuxu.z...@intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com Acked-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v0-v5 change log: Various changes in the commit description. diff

Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-26 Thread Lu, Baolu
On 05/26/2015 10:50 PM, Felipe Balbi wrote: Hi, On Mon, May 25, 2015 at 02:24:00PM +0800, Lu, Baolu wrote: On 05/23/2015 12:08 AM, David Cohen wrote: Hi, On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote: Phy drivers and the ulpi interface providers depend on the registeration

[PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-26 Thread Lu Baolu
Phy drivers and the ulpi interface providers depend on the registration of the ulpi bus. Ulpi registers the bus in module_init(). This could cause unnecessary probe delays. Reported-by: Zhuo Qiuxu qiuxu.z...@intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com Acked-by: Heikki Krogerus

Re: [PATCH v4 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-27 Thread Lu, Baolu
On 05/28/2015 12:53 AM, David Cohen wrote: Hi, On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote: On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote: Phy drivers and the ulpi interface providers depend on the registration of the ulpi bus. Ulpi registers the bus

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-22 Thread Lu, Baolu
On 05/22/2015 11:11 AM, David Cohen wrote: On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: Many drivers and modules depend on ULPI bus registeration to register ULPI interfaces and drivers. It's more appropriate

Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-22 Thread Lu, Baolu
On 05/22/2015 02:46 PM, Lu, Baolu wrote: On 05/22/2015 11:11 AM, David Cohen wrote: On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote: Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: Many drivers and modules depend on ULPI bus registeration to register ULPI

Re: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-25 Thread Lu, Baolu
On 05/23/2015 12:08 AM, David Cohen wrote: Hi, On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote: Phy drivers and the ulpi interface providers depend on the registeration of the ulpi bus. Ulpi registers the bus in module_init(). This could result in a load order issue, i.e. It's

Re: [Bulk] seagate SRD00f2 expansion 4Tb desktop drive does not work on USB 3.0 Part 2 xhci-debug

2015-05-25 Thread Lu, Baolu
On 05/23/2015 10:00 PM, Donald Harter wrote: May 23 08:52:05 pc_u kernel: [53875.075976] xhci_hcd :00:14.0: Port Status Change Event for port 3 May 23 08:52:05 pc_u kernel: [53875.075979] xhci_hcd :00:14.0: port resume event for port 3 May 23 08:52:05 pc_u kernel: [53875.075981]

Re: [Bulk] seagate SRD00f2 expansion 4Tb desktop drive does not work on USB 3.0 Part 2 xhci-debug SOLVED

2015-05-25 Thread Lu, Baolu
bU2DevExitLat 512 micro seconds Device Status: 0x0001 Self Powered On 05/25/2015 05:34 AM, Lu, Baolu wrote: On 05/23/2015 10:00 PM, Donald Harter wrote: May 23 08:52:05 pc_u kernel: [53875.075976] xhci_hcd :00:14.0: Port Status Change Event for port 3 May 23 08:52:05 pc_u

Re: [PATCH 1/1] usb: ulpi: don't register drivers if bus doesn't exist

2015-05-21 Thread Lu, Baolu
Hi Heikki, Sasha and others, Please ignore this patch. I should not squash these two patches into one and sign it off behalf of other people. I apologize for this and I'm sorry if this lets you feel affronted. Thanks, Baolu On 05/21/2015 04:57 PM, Lu Baolu wrote: ULPI registers its bus

[PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-21 Thread Lu Baolu
of kernel panic by putting ulpi_init in subsys_initcall(). Reported-by: Zhuo Qiuxu qiuxu.z...@intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common

[PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall

2015-05-22 Thread Lu Baolu
issue by putting ulpi_init in subsys_initcall(). Reported-by: Zhuo Qiuxu qiuxu.z...@intel.com Signed-off-by: Lu Baolu baolu...@linux.intel.com --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c

Re: [PATCH v2 1/1] usb: xhci: fix checking ep busy for CFC

2015-10-29 Thread Lu, Baolu
On 10/29/2015 08:51 PM, Sergei Shtylyov wrote: Hello. On 10/29/2015 5:46 AM, Lu Baolu wrote: Function ep_ring_is_processing() checks the dequeue pointer in endpoint context to know whether an endpoint is busy with processing TRBs. This is not correct since dequeue pointer field

[PATCH v3 1/1] usb: xhci: fix checking ep busy for CFC

2015-10-29 Thread Lu Baolu
audio noise when playing sound with USB headset connected to host controllers which support CFC (one of xhci 1.1 features). This patch should exist in stable kernel since v4.3. Reported-and-tested-by: YD Tseng <yd_ts...@asmedia.com.tw> Signed-off-by: Lu Baolu <baolu...@linux.intel.com>

Re: [PATCH v2 1/1] usb: xhci: fix checking ep busy for CFC

2015-10-29 Thread Lu, Baolu
On 10/29/2015 10:08 PM, Mathias Nyman wrote: On 29.10.2015 14:58, Lu, Baolu wrote: On 10/29/2015 08:51 PM, Sergei Shtylyov wrote: Hello. On 10/29/2015 5:46 AM, Lu Baolu wrote: Function ep_ring_is_processing() checks the dequeue pointer in endpoint context to know whether an endpoint

[PATCH 1/1] usb: xhci: fix checking ep busy for CFC

2015-10-27 Thread Lu Baolu
audio noise when playing sound with USB headset connected to host controllers which support CFC (one of xhci 1.1 features). This patch should exist in stable kernel since v4.3. Reported-and-tested-by: YD Tseng <yd_ts...@asmedia.com.tw> Signed-off-by: Lu Baolu <baolu...@linux.intel.com>

[PATCH 08/12] usb: xhci: dbc: handle endpoint stall

2015-10-28 Thread Lu Baolu
. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/early/xhci-dbc.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index 8a5a51f..aaf655f 100644 --- a/drivers/usb/early/xhci

[PATCH 12/12] usb: doc: add document for xHCI DbC driver

2015-10-28 Thread Lu Baolu
Add Documentation/usb/xhci-dbc.txt. This document includes development status and usage guide for USB3 debug port. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- Documentation/usb/xhci-dbc.txt | 325 + MAINTAINERS

[PATCH 11/12] usb: serial: usb_debug: add support for dbc debug device

2015-10-28 Thread Lu Baolu
This patch add dbc debug device support in usb_debug driver. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/serial/usb_debug.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/usb_debug.c b/drive

[PATCH 03/12] usb: xhci: dbc: probe and setup xhci debug capability

2015-10-28 Thread Lu Baolu
between the debug host and target. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- MAINTAINERS | 7 + arch/x86/Kconfig.debug | 12 + drivers/usb/early/Makefile | 1 + drivers/usb/early/xhci-dbc.c | 787 +++ include/lin

[PATCH 05/12] usb: xhci: dbc: add debug buffer

2015-10-28 Thread Lu Baolu
DBC_DEBUG is defined. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/early/xhci-dbc.c | 62 ++-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index

[PATCH 06/12] usb: xhci: dbc: add bulk out and bulk in interfaces

2015-10-28 Thread Lu Baolu
This patch adds interfaces for bulk out and bulk in ops. These interfaces could be used to implement early printk bootconsole or hook to various system debuggers. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/early/xhci-dbc.c

[PATCH 04/12] usb: xhci: dbc: add support for Intel xHCI dbc quirk

2015-10-28 Thread Lu Baolu
a port reset to the debug port from the host xHCI. This patch introduces this work around. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/early/xhci-dbc.c | 52 include/linux/usb/xhci-dbc.h | 2 ++ 2 files changed, 54 inse

[PATCH 07/12] usb: xhci: dbc: handle dbc-configured exit

2015-10-28 Thread Lu Baolu
DbC might exit configured state in some cases (refer to 7.6.4.4 in xHCI spec 1.1). Software needs detect and clear this situation by clearing DCCTRL.DCR and wait until the DbC configured before read or write oprations. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/earl

[PATCH 09/12] x86: early_printk: add USB3 debug port earlyprintk support

2015-10-28 Thread Lu Baolu
Add support for early printk by writing debug messages to the USB3 debug port. Users can use this type of early printk by specifying kernel parameter of "earlyprintk=xdbc". This gives users a chance of providing debug output. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --

[PATCH 10/12] usb: xhci: dbc: add handshake between debug target and host

2015-10-28 Thread Lu Baolu
' in the tty application. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/early/xhci-dbc.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index 68a7139..b75c523 100644 --- a/drivers/usb

[PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs

2015-10-28 Thread Lu Baolu
this. This patch exposes extended capabilities supported by the xHCI host via debugfs. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/host/xhci-dbg.c | 212 +++ drivers/usb/host/xhci-ext-caps.h | 9 +- drivers/usb/host/xhci.c

  1   2   3   4   5   6   7   >