On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote:
> > +A freshly-initialised XArray contains a ``NULL`` pointer at every index.
> > +Each non-``NULL`` entry in the array has three bits associated with
> > +it called tags. Each tag may be flipped on or off independently of
> > +the
On Thu, Dec 14, 2017 at 08:22:14PM -0800, Matthew Wilcox wrote:
> On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote:
> > > +A freshly-initialised XArray contains a ``NULL`` pointer at every index.
> > > +Each non-``NULL`` entry in the array has
From: Matthew Wilcox <mawil...@microsoft.com>
Rename pag_ici_root to pag_ici_xa and use XArray APIs instead of radix
tree APIs. Shorter code, typechecking on tag numbers, better error
checking in xfs_reclaim_inode(), and eliminates a call to
radix_tree_preload().
Signed-off-by: Matthew
From: Matthew Wilcox <mawil...@microsoft.com>
This is a pretty straight-forward conversion.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/xfs/xfs_dquot.c | 38 +-
fs/xfs/xfs_qm.c| 32
fs/
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 98 +---
1 file changed, 26 insertions(+), 72 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index
From: Matthew Wilcox <mawil...@microsoft.com>
While the radix tree offers no ability to store IS_ERR pointers,
documenting that the XArray does not led to some concern. Here is a
sanctioned way to store errnos in the XArray. I'm concerned that it
will confuse people who can'
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/btrfs/compression.c | 4 +---
fs/btrfs/extent_io.c | 6 ++
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compres
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/migrate.c | 41 -
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 75d19904dd9a..
From: Matthew Wilcox <mawil...@microsoft.com>
Getting rid of the m_perag_lock lets us also get rid of the call to
radix_tree_preload(). This is a relatively naive conversion; we could
improve performance over the radix tree implementation by passing around
xa_state pointers instead of i
On Mon, Dec 11, 2017 at 03:10:22PM -0800, Randy Dunlap wrote:
> > +The XArray does not support storing :c:func:`IS_ERR` pointers; some
> > +conflict with data values and others conflict with entries the XArray
> > +uses for its own purposes. If you need to store special values which
> > +cannot
From: Matthew Wilcox <mawil...@microsoft.com>
Simpler code because the xarray takes care of things like the limit and
dereferencing the slot.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 18 +++---
1 file changed, 3 insertions(+), 15 deleti
From: Matthew Wilcox <mawil...@microsoft.com>
This first function in the XArray API brings with it a lot of support
infrastructure. The advanced API is based around the xa_state which is
a more capable version of the radix_tree_iter.
As the test-suite demonstrates, it is possible
From: Matthew Wilcox <mawil...@microsoft.com>
This hopefully temporary function is useful for users who have not yet
been converted to multi-index entries.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/xarray.h | 2 ++
lib/xarray.c
From: Matthew Wilcox <mawil...@microsoft.com>
This iterator operates across each tagged entry in the specified range.
We do not yet have a user for an xa_for_each_tag iterator, but it would
be straight-forward to add one if needed. This commit also includes
xas_find_tag() and xas_ne
From: Matthew Wilcox <mawil...@microsoft.com>
Introduce xarray value entries to replace the radix tree exceptional
entry code. This is a slight change in encoding to allow the use of an
extra bit (we can now store BITS_PER_LONG - 1 bits in a value entry).
It is also a change in em
From: Matthew Wilcox <mawil...@microsoft.com>
Quite a straightforward conversion.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/huge_memory.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_me
From: Matthew Wilcox <mawil...@microsoft.com>
Slightly shorter and easier to read code.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/khugepaged.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/mm/khugepaged.c b/mm/khugep
From: Matthew Wilcox <mawil...@microsoft.com>
The IDR distinguishes between unallocated entries (read as NULL) and
entries where the user has chosen to store NULL. The radix tree was
modified to consider NULL entries which had tag 0 _clear_ as being
allocated, but it added a lot of comp
From: Matthew Wilcox <mawil...@microsoft.com>
This is a simple rename, except that xa_ail becomes ail_head.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/xfs/xfs_buf_item.c| 10 ++--
fs/xfs/xfs_dquot.c | 4 +-
fs/xfs/xfs_dquot_item.c | 11
From: Matthew Wilcox <mawil...@microsoft.com>
This is a direct replacement for struct radix_tree_root. Some of the
struct members have changed name; convert those, and use a #define so
that radix_tree users continue to work without change.
Signed-off-by: Matthew Wilcox <mawil...@micr
From: Matthew Wilcox <mawil...@microsoft.com>
This works like doing cmpxchg() on an array entry. Code which wants
the radix_tree_insert() semantic of not overwriting an existing entry
can cmpxchg() with NULL and get the action it wants. Plus, instead of
having an error returned, th
From: Matthew Wilcox <mawil...@microsoft.com>
This is a direct replacement for struct radix_tree_node. A couple of
struct members have changed name, so convert those. Use a #define so
that radix tree users continue to work without change.
Signed-off-by: Matthew Wilcox <mawil...@micr
From: Matthew Wilcox <mawil...@microsoft.com>
This is a straightforward conversion.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/f2fs/data.c | 3 +--
fs/f2fs/dir.c| 5 +
fs/f2fs/inline.c | 6 +-
fs/f2fs/node.c | 10 ++
4 files changed,
From: Matthew Wilcox <mawil...@microsoft.com>
Includes moving mapping_tagged() to fs.h as a static inline, and
changing it to return bool.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/fs.h | 17 +--
mm/page-writ
From: Matthew Wilcox <mawil...@microsoft.com>
This is a perfect use for xa_cmpxchg(). Note the use of 0 for GFP
flags; we won't be allocating memory.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
From: Matthew Wilcox <mawil...@microsoft.com>
Combine __add_to_swap_cache and add_to_swap_cache into one function
since there is no more need to preload.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/swap_state.c | 93 ++--
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index dd4674ce48f5..46a4d83b1b46 100644
--- a/fs/dax.c
++
From: Matthew Wilcox <mawil...@microsoft.com>
With no more radix tree API users left, we can drop the GFP flags
and use xa_init() instead of INIT_RADIX_TREE().
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/inode.c | 2 +-
include/linux/fs.h | 2 +-
mm/swap_st
From: Matthew Wilcox <mawil...@microsoft.com>
Add myself as XArray and IDR maintainer.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
MAINTAINERS | 12
1 file changed, 12 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 82ad0eabce4f..bb5ffa1
From: Matthew Wilcox <mawil...@microsoft.com>
The code is slightly shorter and simpler.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/filemap.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/mm/filemap.c b/mm/fil
From: Matthew Wilcox <mawil...@microsoft.com>
Removes sparse warnings.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/btrfs/extent_io.c| 4 ++--
fs/ext4/inode.c | 2 +-
fs/f2fs/data.c | 2 +-
fs/gfs2/aops.c | 2 +-
include/linux/p
From: Matthew Wilcox <mawil...@microsoft.com>
These two functions move the xas index by one position, and adjust the
rest of the iterator state to match it. This is more efficient than
calling xas_set() as it keeps the iterator at the leaves of the tree
instead of walking the iterato
From: Matthew Wilcox <mawil...@microsoft.com>
btrfs has its own custom function for determining whether the page cache
has any pages in a particular range. Move this functionality to the
page cache, and call it from btrfs.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
-
From: Matthew Wilcox <mawil...@microsoft.com>
In a non-critical path, irqdomain wants to know how many entries are
stored in the xarray, so add xa_count(). This is a pretty straightforward
conversion; mostly just removing now-redundant locking. The only thing
of note is just how much s
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index d6dd779e1b46..9cfd4fcc0b0d 100644
--- a/fs/dax.c
+++ b/fs/dax.c
From: Matthew Wilcox <mawil...@microsoft.com>
This is essentially xa_cmpxchg() with the locking handled above us,
and it doesn't have to handle replacing a NULL entry.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/truncate.c | 15 ++-
1 file changed,
From: Matthew Wilcox <mawil...@microsoft.com>
shmem_radix_tree_replace() is renamed to shmem_xa_replace() and
converted to use the XArray API.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 22 --
1 file changed, 8 insertions(+),
From: Matthew Wilcox <mawil...@microsoft.com>
This function frees all the internal memory allocated to the xarray
and reinitialises it to be empty.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/xarray.h | 1 +
lib/xarray.c | 25
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
drivers/staging/lustre/lustre/llite/glimpse.c | 12 +---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 16
2 files changed, 13 insertions(+),
From: Matthew Wilcox <mawil...@microsoft.com>
xa_load has its own RCU locking, so we can eliminate it here.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index
From: Matthew Wilcox <mawil...@microsoft.com>
Introduce page_cache_pin() to factor out the common logic between the
various lookup routines:
find_get_entry
find_get_entries
find_get_pages_range
find_get_pages_contig
find_get_pages_range_tag
find_get_entries_tag
filemap_map_pages
By
From: Matthew Wilcox <mawil...@microsoft.com>
Simple now that we already have an xa_state!
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index 2629ffa70575..
From: Matthew Wilcox <mawil...@microsoft.com>
sparse doesn't know that follow_pte_pmd conditionally acquires the ptl,
so add an annotation to let it know what's going on.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 1 +
1 file changed, 1 insertion(+)
dif
From: Matthew Wilcox <mawil...@microsoft.com>
Remove the address_space ->tree_lock and use the xa_lock newly added to
the radix_tree_root. Rename the address_space ->page_tree to ->pages,
since we don't really care that it's a tree. Take the opportunity to
rearran
From: Matthew Wilcox <mawil...@microsoft.com>
As with shmem_tag_pins(), hold the lock around the entire loop instead
of acquiring & dropping it for each entry we're going to untag.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
From: Matthew Wilcox <mawil...@microsoft.com>
Use the xarray infrstructure like we used the radix tree infrastructure.
This lets us get rid of idr_get_free() from the radix tree code.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/idr.h| 8 +-
i
From: Matthew Wilcox <mawil...@microsoft.com>
This results in no change in structure size on 64-bit x86 as it fits in
the padding between the gfp_t and the void *.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/f2fs/gc.c | 2 +-
include
From: Matthew Wilcox <mawil...@microsoft.com>
xa_store() differs from radix_tree_insert() in that it will overwrite an
existing element in the array rather than returning an error. This is
the behaviour which most users want, and those that want more complex
behaviour generally want
From: Matthew Wilcox <mawil...@microsoft.com>
These functions allow a range of xarray entries to be extracted into a
compact normal array.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/xarray.h | 27
lib/xarray.c
From: Matthew Wilcox <mawil...@microsoft.com>
This is documentation on how to use the XArray, not details about its
internal implementation.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
Documentation/core-api/index.rst | 1 +
Documentation/core-api/xarr
From: Matthew Wilcox <mawil...@microsoft.com>
XArray tags are slightly more strongly typed than the radix tree tags,
but occupy the same bits. This commit also adds the xas_ family of tag
operations, for cases where the caller is already holding the lock, and
xa_tagged() to ask whether any
From: Matthew Wilcox <mawil...@microsoft.com>
This one is trivial.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/readahead.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/readahead.c b/mm/readahead.c
index f64b31b3a84a..66bcaffd47f0 100
From: Matthew Wilcox <mawil...@microsoft.com>
Use the XArray APIs to add and replace pages in the page cache. This
removes two uses of the radix tree preload API and is significantly
shorter code.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/fil
From: Matthew Wilcox <mawil...@microsoft.com>
The page cache offers the ability to search for a miss in the previous or
next N locations. Rather than teach the XArray about the page cache's
definition of a miss, use xas_prev() and xas_next() to search the page
array. This should b
From: Matthew Wilcox <mawil...@microsoft.com>
This is a fairly naive conversion, leaving in place the GFP_ATOMIC
allocation. By switching the locking around, we could use GFP_KERNEL
and probably simplify the error handling.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
From: Matthew Wilcox <mawil...@microsoft.com>
Removes another user of radix_tree_preload().
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/fscache/cookie.c | 6 +-
fs/fscache/internal.h | 2 +-
fs/fscache/object.c | 2 +-
fs/fscache/page.c
From: Matthew Wilcox <mawil...@microsoft.com>
Convert brd_pages from a radix tree to an XArray. Simpler and smaller
code; in particular another user of radix_tree_preload is eliminated.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
drivers/bloc
From: Matthew Wilcox <mawil...@microsoft.com>
This is the first user of the radix tree I've converted which was
storing numbers rather than pointers. I'm fairly pleased with how
well it came out. There's less boiler-plate involved than there was
with the radix tree, so that's a win. I
From: Matthew Wilcox <mawil...@microsoft.com>
Replace slot_locked() with dax_locked() and inline unlock_slot() into
its only caller.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 48
1 file changed, 16 inser
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index 9cfd4fcc0b0d..a3e795ad2493 100644
--- a/fs/dax.c
++
From: Matthew Wilcox <mawil...@microsoft.com>
We construct a fake XA_STATE and use it to delete the node with xa_store()
rather than adding a special function for this unique use case.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/swap.h | 4 ++--
mm/
From: Matthew Wilcox <mawil...@microsoft.com>
A couple of short loops.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/fs-writeback.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-write
From: Matthew Wilcox <mawil...@microsoft.com>
Both callers of __delete_from_swap_cache have the swp_entry_t already,
so pass that in to make constructing the XA_STATE easier.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
include/linux/swap.h | 5 +++--
mm/swap_state
From: Matthew Wilcox <mawil...@microsoft.com>
Rename the function from page_cache_tree_delete_batch to just
page_cache_delete_batch.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/filemap.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
From: Matthew Wilcox <mawil...@microsoft.com>
Don't open-code accesses to data structure internals.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/fscache/cookie.c | 2 +-
fs/fscache/object.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Matthew Wilcox <mawil...@microsoft.com>
This removes the last caller of radix_tree_maybe_preload_order().
Simpler code, unless we run out of memory for new xa_nodes partway through
inserting entries into the xarray. Hopefully we can support multi-index
entries in the page cach
From: Matthew Wilcox <mawil...@microsoft.com>
Again, this patch set does not apply to any particular tree
because it depends on things which are purely noise, and I'm trying
to keep the patch count down [1]. If you want it in a git tree, try
http://git.infradead.org/users/willy/linux-d
From: Matthew Wilcox <mawil...@microsoft.com>
I'm not 100% convinced that the rewrite of nilfs_copy_back_pages is
correct, but it will at least have different bugs from the current
version.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/nilfs2/b
From: Matthew Wilcox <mawil...@microsoft.com>
The XArray API is a slightly better fit for xhci_insert_segment_mapping()
than the radix tree API was.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
drivers/usb/host/xhci-mem.c | 68 +++---
From: Matthew Wilcox <mawil...@microsoft.com>
Likewise easy
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index d3894c15609a..d6dd779e1b46 100644
--- a/fs
From: Matthew Wilcox <mawil...@microsoft.com>
Simplify the locking by taking the spinlock while we walk the tree on
the assumption that many acquires and releases of the lock will be
worse than holding the lock for a (potentially) long time.
We could replicate the same locking beh
From: Matthew Wilcox <mawil...@microsoft.com>
This iterator allows the user to efficiently walk a range of the array,
executing the loop body once for each non-NULL entry in that range.
This commit also includes xa_find() and xa_next() which are helper
functions for xa_for_each() but ma
From: Matthew Wilcox <mawil...@microsoft.com>
This eliminates a call to radix_tree_preload().
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/xfs/xfs_mru_cache.c | 72 +++---
1 file changed, 33 insertions(+), 39 deletions(-)
From: Matthew Wilcox <mawil...@microsoft.com>
This time, we want to convert get_unlocked_mapping_entry() to use the
XArray. That has a ripple effect, causing us to change the waitqueues
to hash on the address of the xarray rather than the address of the
mapping (functionally equi
From: Matthew Wilcox <mawil...@microsoft.com>
This is a 1:1 conversion.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 654f367aca90..
From: Matthew Wilcox <mawil...@microsoft.com>
Instead of storing a pointer to the slot containing the canonical entry,
store the offset of the slot. Produces slightly more efficient code
(~300 bytes) and simplifies the implementation.
Signed-off-by: Matthew Wilcox <mawil...@micr
From: Matthew Wilcox <mawil...@microsoft.com>
Remove the last mentions of radix tree from various comments.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mm/shmem.c b/mm/s
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 92ddee25f19b..75d1b32080a4 100644
--- a/mm/filemap.c
+++ b/
From: Matthew Wilcox <mawil...@microsoft.com>
I found another victim of the radix tree being hard to use. Because
there was no call to radix_tree_preload(), khugepaged was allocating
radix_tree_nodes using GFP_ATOMIC.
I also converted a local_irq_save()/restore() pair to
disable()/
From: Matthew Wilcox <mawil...@microsoft.com>
Mostly comment fixes, but one use of __xa_set_tag.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/buffer.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index
From: Matthew Wilcox <mawil...@microsoft.com>
The radix tree of vmap blocks is simpler to express as an XArray.
Saves a couple of hundred bytes of text and eliminates a user of the
radix tree preload API.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/vm
On Thu, Dec 07, 2017 at 11:06:34AM -0500, Theodore Ts'o wrote:
> The problem is that if it has too many false positives --- and it's
> gotten *way* worse with the completion callback "feature", people will
> just stop using Lockdep as being too annyoing and a waste of developer
> time when trying
On Thu, Dec 07, 2017 at 02:38:03PM -0800, Matthew Wilcox wrote:
> You need to get LOCKDEP_CROSSRELEASE off. I'd revert patches
> e26f34a407aec9c65bce2bc0c838fabe4f051fc6 and
> b483cf3bc249d7af706390efa63d6671e80d1c09
Oops. I meant to revert 2dcd5adfb7401b762ddbe4b86dcacc2f3de6b97b.
Or
On Fri, Dec 08, 2017 at 10:27:17AM -0500, Theodore Ts'o wrote:
> So if you are adding complexity to the kernel with the argument,
> "lockdep will save us", I'm with Dave --- it's just not a believable
> argument.
I think that's a gross misrepresentation of what I'm doing.
At the moment, the
From: Matthew Wilcox <mawil...@microsoft.com>
I'm not 100% convinced that the rewrite of nilfs_copy_back_pages is
correct, but it will at least have different bugs from the current
version.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/nilfs2/b
From: Matthew Wilcox <mawil...@microsoft.com>
Rename pag_ici_root to pag_ici_xa and use XArray APIs instead of radix
tree APIs. Shorter code, typechecking on tag numbers, better error
checking in xfs_reclaim_inode(), and eliminates a call to
radix_tree_preload().
Signed-off-by: Matthew
From: Matthew Wilcox <mawil...@microsoft.com>
Likewise easy
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index 66f6c4ea18f7..7bd94f1b61d0 100644
--- a/fs
From: Matthew Wilcox <mawil...@microsoft.com>
Convert brd_pages from a radix tree to an XArray. Simpler and smaller
code; in particular another user of radix_tree_preload is eliminated.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
drivers/bloc
From: Matthew Wilcox <mawil...@microsoft.com>
The radix tree of vmap blocks is simpler to express as an XArray.
Saves a couple of hundred bytes of text and eliminates a user of the
radix tree preload API.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/vm
From: Matthew Wilcox <mawil...@microsoft.com>
Simple now that we already have an xa_state!
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index ad984dece12e..
From: Matthew Wilcox <mawil...@microsoft.com>
This time, we want to convert get_unlocked_mapping_entry() to use the
XArray. That has a ripple effect, causing us to change the waitqueues
to hash on the address of the xarray rather than the address of the
mapping (functionally equi
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/dax.c | 98 +---
1 file changed, 26 insertions(+), 72 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index
From: Matthew Wilcox <mawil...@microsoft.com>
Removes sparse warnings.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
fs/btrfs/extent_io.c| 4 ++--
fs/ext4/inode.c | 2 +-
fs/f2fs/data.c | 2 +-
fs/gfs2/aops.c | 2 +-
include/linux/p
From: Matthew Wilcox <mawil...@microsoft.com>
Quite a straightforward conversion.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/huge_memory.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_me
From: Matthew Wilcox <mawil...@microsoft.com>
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 9e6158cfbaeb..79d0731b8762 100644
--- a/mm/filemap.c
+++ b/
From: Matthew Wilcox <mawil...@microsoft.com>
Simplify the locking by taking the spinlock while we walk the tree on
the assumption that many acquires and releases of the lock will be
worse than holding the lock for a (potentially) long time.
We could replicate the same locking beh
From: Matthew Wilcox <mawil...@microsoft.com>
shmem_radix_tree_replace() is renamed to shmem_xa_replace() and
converted to use the XArray API.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
mm/shmem.c | 22 --
1 file changed, 8 insertions(+),
From: Matthew Wilcox <mawil...@microsoft.com>
This is a direct replacement for struct radix_tree_root. Some of the
struct members have changed name; convert those, and use a #define so
that radix_tree users continue to work without change.
Signed-off-by: Matthew Wilcox <mawil...@micr
From: Matthew Wilcox <mawil...@microsoft.com>
This is documentation on how to use the XArray, not details about its
internal implementation.
Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>
---
Documentation/core-api/index.rst | 1 +
Documentation/core-api/xarr
From: Matthew Wilcox <mawil...@microsoft.com>
Getting rid of the m_perag_lock lets us also get rid of the call to
radix_tree_preload(). This is a relatively naive conversion; we could
improve performance over the radix tree implementation by passing around
xa_state pointers instead of i
1 - 100 of 288 matches
Mail list logo
