, and I'll queue it to the usb-next branch for 3.14.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
support streams?
Intel xHCI hosts. I believe some NEC hosts as well. I'm not sure about
other vendors. Obviously you already know TI supports streams.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
hardware bug, it's just an
unfortunate design flaw that the USB 3.0 spec doesn't account for a
root hub port being reset independently of its connected device. I
think Sarah is correct that it could be limited to root hubs, though.
Sarah Sharp
--
To unsubscribe from this list: send the line
On Wed, Dec 11, 2013 at 11:03:09AM -0500, Alan Stern wrote:
On Tue, 10 Dec 2013, Sarah Sharp wrote:
On 3.13-rc1, the btrfs partion from the disconnected USB device
continues to be listed as mounted. Yanking the cable produces some
additional oops messages. It also produced a couple hard
638298dc66ea36623dbc2757a24fc2c4ab41b016 xhci: Fix
spurious wakeups after S5 on Haswell.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=66171
Cc: sta...@vger.kernel.org
Signed-off-by: Takashi Iwai ti...@suse.de
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Tested-by: dashing.m...@gmail.com
Reported
the xHCI quirk to only run on HP systems.
Sometimes fixing firmware issues feels like plugging holes in a leaky boat.
Sarah Sharp
Takashi Iwai (1):
xhci: Limit the spurious wakeup fix only to HP machines
drivers/usb/host/xhci
From: Dan Williams dan.j.willi...@intel.com
Specify whether we are only performing the context setup portion of the
'address device' command, or the full operation issuing 'SetAddress'
on the wire.
Signed-off-by: Dan Williams dan.j.willi...@intel.com
Signed-off-by: Sarah Sharp sarah.a.sh
, headset, ethernet, serial, mouse, keyboard,
etc). They all work, so these patches are ready for wider testing.
Sarah Sharp
Dan Williams (2):
usb: xhci: change enumeration scheme to 'new scheme' by default
xhci: clarify
bMaxPacketSize0= 9
which results in the discovery process looping until falling back to
'old scheme' enumeration.
Acked-by: Alan Stern st...@rowland.harvard.edu
Reported-by: David Moore david.mo...@gmail.com
Suggested-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Reported-by: Dan Carpenter
of the hardware the
quirks were enabled for.
Greg, thoughts on this?
Sarah Sharp
drivers/usb/host/xhci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 4265b48856f6..08a4fd458d22 100644
--- a/drivers/usb/host/xhci.c
with the reset-resume procedure for the child device?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
without a spurious
reboot, but none of the original reporters have reported success with
this patch yet.
Sarah Sharp
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=66171
Cc: sta...@vger.kernel.org
Signed-off-by: Takashi Iwai ti...@suse.de
---
v1-v2: Fix bug description
drivers/usb/host
On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote:
On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote:
On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote:
The following changes since commit
c24cb6c8b501ebdf1aacec7960110a9741a45ced:
Merge tag 'fixes-for-v3.13-rc2
On Fri, Dec 06, 2013 at 05:46:40PM -, David Laight wrote:
From: David Miller [mailto:da...@davemloft.net]
From: Greg Kroah-Hartman gre...@linuxfoundation.org
Date: Fri, 6 Dec 2013 09:29:47 -0800
On Fri, Dec 06, 2013 at 09:03:25AM -0800, Sarah Sharp wrote:
On Fri, Dec 06, 2013
Sorry for the very delayed response on this, I'm trying to catch up on
my email from around Kernel Summit and my vacation.
On Tue, Oct 08, 2013 at 10:19:11AM -0400, Alan Stern wrote:
On Mon, 7 Oct 2013, Sarah Sharp wrote:
i am using 3.10 kernel. Also i looked at tip i see same
Hi Jack,
Sorry for the extremely delayed reply, I've been trying to catch up on
my patch queue.
On Tue, Oct 22, 2013 at 12:33:27PM -0700, Jack Pham wrote:
From: Hemant Kumar hema...@codeaurora.org
USB control transfers can contain an optional IN data stage, in which
case the xHCI driver
with my patch backlog, which starts around September.
Please be patient, there's no need to resend at this point in time.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Hi Dan,
Can you send me an updated patch for commit 1e6ed41e7e29 that includes
this fix? I haven't queued this to Greg yet, and I would like to avoid
introducing bugs on bisect.
Thanks,
Sarah Sharp
On Thu, Dec 05, 2013 at 10:00:00AM -0800, Dan Williams wrote:
Smatch says:
drivers/usb/core
? Do you want Hans to resend
the entire 70 patch set to the USB storage mailing list, or do you think
sending it to the USB mailing list was good enough?
Sarah Sharp
New this version is that the uas: Use proper packet size when submitting
reponse urbs patch has been dropped. As Gerd rightfully
have it.
Ping, Alexis: any info on this question?
Sarah Sharp
-Original Message-
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
Sent: Thursday, November 14, 2013 5:31 PM
To: Alan Stern
Cc: Julius Werner; Greg Kroah-Hartman; LKML; linux-usb@vger.kernel.org;
Benson Leung
into issues with the
new scheme enumeration?
Sarah Sharp
-Original Message-
From: Pratyush Anand [mailto:pratyush.an...@gmail.com]
Sent: mardi 26 novembre 2013 14:06
To: Aymen BOUATTAY; sarah.a.sh...@linux.intel.com
Cc: linux-usb@vger.kernel.org
Subject: Re: Xhci Host not allowed to send get
: Oliver Neukum oneu...@suse.de
Signed-off-by: Takashi Iwai ti...@suse.de
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
When testing with Intel BIOSes on Lynx Point LP systems, we found that
it increases the xHCI module load time by about 100ms (load time
.
Sarah Sharp
On Tue, Dec 03, 2013 at 08:58:17AM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-linus
head: 35773dac5f862cb1c82ea151eba3e2f6de51ec3e
commit: 35773dac5f862cb1c82ea151eba3e2f6de51ec3e [1/1] usb: xhci: Link TRB
must
On Wed, Nov 27, 2013 at 05:21:57PM -0700, Shuah Khan wrote:
On 11/27/2013 02:59 PM, Sarah Sharp wrote:
On Mon, Nov 25, 2013 at 11:41:47AM -0700, Shuah Khan wrote:
I started seeing the following on my Samsung Series on 3.12.1
Is this bad? Looks like the following WARN_ON is firing:
drivers
On Wed, Nov 27, 2013 at 03:49:43PM -0800, Sarah Sharp wrote:
On Wed, Nov 27, 2013 at 03:36:56PM -0800, Greg Kroah-Hartman wrote:
On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote:
On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote:
The following changes since
On Mon, Dec 02, 2013 at 10:05:54AM -0500, Mark Lord wrote:
On 13-12-02 04:30 AM, David Laight wrote:
From: Mark Lord
Sent: 30 November 2013 02:59
To: Sarah Sharp; David Laight
Cc: David Miller; eric.duma...@gmail.com; ming@canonical.com;
net...@vger.kernel.org; linux-
u
controllers, so I would only like to be conservative and only queue
it for 3.13 and 3.12 stable.
Please queue this for 3.13.
Sarah Sharp
David Laight (1):
usb: xhci: Link TRB must not occur within a USB payload burst
drivers/usb/host
david.lai...@aculab.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Tested-by: Mark Lord ml...@pobox.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-ring.c | 54 ++--
include/linux/usb.h | 2 ++
2 files changed, 54 insertions
From: Xenia Ragiadakou burzalod...@gmail.com
This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in
'control' field of the link TRB.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
advantage of inherent atomic 64bit
write operations on 64bit systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-mem.c | 8
drivers/usb/host/xhci-ring.c | 8 +++-
drivers/usb/host/xhci.c | 8
stable material because this code will produce harmless
behavior on non-PCI xHCI hosts. The pci_device pointer is never
dereferenced, only used to re-calculate the underlying device pointer.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh
...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c | 36 +--
drivers/usb/host/xhci-hub.c | 71 ++--
drivers/usb/host/xhci-mem.c | 20 +--
drivers/usb/host/xhci-ring.c | 12 +++
drivers/usb
of valid endpoints.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci.c b
...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-hub.c | 35 ++
drivers/usb/host/xhci-mem.c | 6 +++---
drivers/usb/host/xhci-ring.c | 8 +++
drivers/usb/host/xhci.c | 51
for stable, since the bug would only be
triggered on big endian systems, and the code only runs for Intel xHCI
host controllers, which are always integrated into little endian
systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
will not lead to overflow.
In the original code, the typecasting of le32 to u64 was incorrect and the
subsequent conversion to le64 reverts the low and high address parts.
This bug was found using sparse.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh
test those later this week.) The goal is to get both the
xHCI driver streams support and the UAS driver fixed up for 3.14. We
don't want to mark the fixes for stable, as all the code changes are
really too big for stable.
Please queue for 3.14.
Sarah Sharp
the contents of the TRB that generated the event.
The trace-cmd tool with the help of plugin_xhci.py will use this field to
parse the TRB contents in a human readable way.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host
cycles since most configurations come with 1-2
interfaces while USB_MAXINTERFACES is 32.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
is not suitable for stable, since the bug would only be
triggered on big endian systems, and the code only runs for Intel xHCI
host controllers, which are always integrated into little endian
systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
of inherent atomic 64bit
read operations on 64bit systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c | 6 +++---
drivers/usb/host/xhci-mem.c | 6 +++---
drivers/usb/host/xhci-ring.c | 6
we want.
This patch fixes the above issue by defining the SCT_FOR_CTX(p) macro as
(((p) 0x7) 1)
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Xenia Ragiadakou burzalod...@gmail.com
This patch removes the unneccessary check 'if (stream_info)' because
there is already a check few lines above which ensures that stream_info
is not NULL.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh
On Thu, Nov 28, 2013 at 11:08:13AM +0900, Jingoo Han wrote:
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han jg1@samsung.com
Applied to my for-usb-next-queue branch. It will be queued to Greg's
usb-next branch, and should be merged into 3.14.
Sarah
newest kernels?
It's probably specific to your USB 3.0 device. The USB 3.0 mass storage
devices I have work fine on my Intel xHCI host.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, Dec 03, 2013 at 07:48:30AM +0900, Jingoo Han wrote:
On Tuesday, December 03, 2013 7:26 AM, Sarah Sharp wrote:
On Thu, Nov 28, 2013 at 11:08:13AM +0900, Jingoo Han wrote:
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han jg1@samsung.com
=for-usb-next-queue
I've been testing the for-usb-next-queue branch on top of 3.12-rc6 for
the last week, and the patches are stable.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Wed, Nov 27, 2013 at 01:51:05PM -0800, Greg KH wrote:
On Wed, Nov 27, 2013 at 01:42:40PM -0800, Sarah Sharp wrote:
Hi Greg,
I've got a potential pull request to send you for usb-next, but I wanted
to get your advice on it first. It contains a series of patches from
Xenia to remove
that causes this might be.
Sarah Sharp
[ 565.276187] [ cut here ]
[ 565.276198] WARNING: CPU: 2 PID: 2228 at
drivers/usb/host/xhci.c:3748 xhci_address_device+0x57b/0x630()
[ 565.276262] Modules linked in: parport_pc ppdev arc4 iwldvm
rfcomm bnep mac80211 i915 ext2
xhci_cmd_completion trace event
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci
186a7ef13a8fa3bc7cca1ccd33bd469b931e46de xHCI: set cycle
state when allocate rings
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
of valid endpoints.
This bug was found using sparse.
This patch should be backported to kernels as old as 3.12, that
contain the commit 1d27fabec068a204186c6af10e05f23911c0c902 xhci: add
xhci_address_ctx trace event
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp
63a23b9a7451660525c90b08219e14e701e294f1 xhci: add
xhci_cmd_completion trace event
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
the commit 623bef9e03a60adc623b09673297ca7a1cdfb367 USB/xhci: Enable
remote wakeup for USB3 devices.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1
cycles since most configurations come with 1-2
interfaces while USB_MAXINTERFACES is 32.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
of inherent atomic 64bit
read operations on 64bit systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c | 6 +++---
drivers/usb/host/xhci-mem.c | 6 +++---
drivers/usb/host/xhci-ring.c | 6
for stable, since the bug would only be
triggered on big endian systems, and the code only runs for Intel xHCI
host controllers, which are always integrated into little endian
systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
advantage of inherent atomic 64bit
write operations on 64bit systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-mem.c | 8
drivers/usb/host/xhci-ring.c | 8 +++-
drivers/usb/host/xhci.c | 8
is not suitable for stable, since the bug would only be
triggered on big endian systems, and the code only runs for Intel xHCI
host controllers, which are always integrated into little endian
systems.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-hub.c | 35 ++
drivers/usb/host/xhci-mem.c | 6 +++---
drivers/usb/host/xhci-ring.c | 8 +++
drivers/usb/host/xhci.c | 51
From: Xenia Ragiadakou burzalod...@gmail.com
This patch removes the unneccessary check 'if (stream_info)' because
there is already a check few lines above which ensures that stream_info
is not NULL.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh
...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c | 36 +--
drivers/usb/host/xhci-hub.c | 71 ++--
drivers/usb/host/xhci-mem.c | 20 +--
drivers/usb/host/xhci-ring.c | 12 +++
drivers/usb
support and the UAS driver fixed up for 3.14. We don't
want to mark the fixes for stable, as all the code changes are really
too big for stable.
Please merge usb-linus into usb-next before pulling this request.
Sarah Sharp
Xenia
we want.
This patch fixes the above issue by defining the SCT_FOR_CTX(p) macro as
(((p) 0x7) 1)
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
stable material because this code will produce harmless
behavior on non-PCI xHCI hosts. The pci_device pointer is never
dereferenced, only used to re-calculate the underlying device pointer.
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh
On Wed, Nov 27, 2013 at 03:36:56PM -0800, Greg Kroah-Hartman wrote:
On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote:
On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote:
The following changes since commit
7d49f0bac41ee9b012af1efe2f725d91a87a8fe9:
USB
On Wed, Nov 20, 2013 at 09:36:11AM -, David Laight wrote:
From: Alan Stern [mailto:st...@rowland.harvard.edu]
On Tue, 19 Nov 2013, Sarah Sharp wrote:
The xHCI driver can limit the number of sg-list entries through
hcd-self.sg_tablesize. It's currently set to ~0, which is however
On Wed, Nov 20, 2013 at 09:46:08AM -, David Laight wrote:
From: Sarah Sharp
...
(Also, usb-storage aligns the block sizes to 512K, which explains why
we've never had an issue with TD fragments with that driver.)
What is a 'block' in that context?
512K sounds more like the value
to
be silently corrupted.
The real fix for this will probably be too large for stable, and is
likely to take at least a kernel revision to fix.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
lists was the driving motivation to
add the ring expansion.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 18, 2013 at 03:41:00PM -, David Laight wrote:
-Original Message-
From: Ben Hutchings [mailto:bhutchi...@solarflare.com]
Sent: 18 November 2013 15:03
To: David Laight
Cc: Alan Stern; Sarah Sharp; net...@vger.kernel.org;
linux-usb@vger.kernel.org
Subject
Applied to for-usb-linus to be queued for 3.13. (I changed my mind
about some of the big endian sparse fixes, and marked them to be queued
for the stable tree, so some of your patches have migrated from
for-usb-next-queue to for-usb-linus-queue.)
Sarah Sharp
On Fri, Nov 15, 2013 at 03:18:07AM
Applied to for-usb-next-queue to be queued for 3.13.
Thanks,
Sarah Sharp
On Fri, Nov 15, 2013 at 03:18:08AM +0200, Xenia Ragiadakou wrote:
This patch removes the to_pci_dev() conversion performed to generic struct
device since it is not actually useful (the pointer to the generic device
can
on the Linux
USB mailing list.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
parameter to disable UAS all together?
We're trying to get away from adding extra module parameters
to kernel drivers, so this really needs to be justified.
Sarah Sharp
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/usb.c | 12
drivers/usb/storage/uas
On Fri, Nov 15, 2013 at 04:56:59PM +0100, Hans de Goede wrote:
Hi,
On 11/15/2013 04:46 PM, David Laight wrote:
From: Hans de Goede
Sent: 15 November 2013 15:06
To: Sarah Sharp
Cc: linux-usb@vger.kernel.org; Gerd Hoffmann; Alan Stern; Hans de Goede
Subject: [PATCH 01/68] xhci: fix usb3
that the two other points are non-issues for that
* particular descriptor type.
*/
It doesn't look like the networking subsystem (which seems to be the
code you're most familiar with) uses packed, but plenty of other
subsystems do.
Sarah Sharp
--
To unsubscribe from this list: send the line
and, for example,
the USB3 ethernet ax88179_178a card will stop sending (while still receiving)
when running a netperf tcp transmit test with (say) and 8k buffer.
Can you send the exact command line you used to cause the stall? I'd
like to reproduce this with my USB 3.0 ethernet adapter.
Thanks,
Sarah
structure pointer.
The patch shouldn't change the current behavior, so I'll queue it for
usb-next and 3.14 instead of 3.13.
Sarah Sharp
Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com
---
drivers/usb/host/xhci-mem.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions
On Thu, Nov 14, 2013 at 12:31:16PM -0800, Sarah Sharp wrote:
Hi Xenia,
Sorry for the really late review on this.
On Mon, Aug 26, 2013 at 11:29:49PM +0300, Xenia Ragiadakou wrote:
This patch removes the to_pci_dev() conversion performed to generic struct
device since it is not actually
Hi Xenia,
This patch doesn't apply any more either, could you resend when you have
time?
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:08PM +0300, Xenia Ragiadakou wrote:
The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs
to be converted to CPU byteorder
Applied to for-usb-next-queue. I'll rebase it against Greg's usb-next
branch once 3.13-rc1 is out, and send it off for inclusion for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:46PM +0300, Xenia Ragiadakou wrote:
This patch replaces USB_MAXINTERFACES with config-desc.bNumInterface
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:47PM +0300, Xenia Ragiadakou wrote:
SCT_FOR_CTX(p) is defined as (((p) 1) 0x7) in which case if we want
to set the stream context type to SCT_SSA_256 i.e 0x7 (although secondary
stream arrays are not yet
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Aug 26, 2013 at 11:29:48PM +0300, Xenia Ragiadakou wrote:
This patch removes the unneccessary check 'if (stream_info)' because
there is already a check few lines above which ensures that stream_info
is not NULL.
Signed-off
Applied to for-usb-next-queue for 3.14.
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:06PM +0300, Xenia Ragiadakou wrote:
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx
have type __le32 and need to be converted to CPU byteorder before being
used to derive the number
On Thu, Nov 14, 2013 at 11:04:14PM +0200, Xenia Ragiadakou wrote:
On 11/14/2013 10:52 PM, Sarah Sharp wrote:
Hi Xenia,
This patch doesn't apply any more either, could you resend when you have
time?
Thanks,
Sarah Sharp
Yes, sure! Do you want me to resend all the patch series or just
Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:09PM +0300, Xenia Ragiadakou wrote:
This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in
'control' field of the link TRB.
This bug was found using sparse.
Signed-off-by: Xenia
Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:07PM +0300, Xenia Ragiadakou wrote:
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx
have type __le32 and need to be converted to CPU byteorder before being
used to derive the number
Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:12PM +0300, Xenia Ragiadakou wrote:
This patch fixes the following sparse warnings:
drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32
drivers/usb/host/./xhci-trace.h:116:1: warning
Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:11PM +0300, Xenia Ragiadakou wrote:
This patch fixes the retrieval of the DMA address of the TRB that generated
the event by converting the field[0] (low address bits) and field[1] (high
address bits) to CPU
Applied to for-usb-next for 3.14.
Thanks,
Sarah Sharp
On Mon, Sep 09, 2013 at 09:03:10PM +0300, Xenia Ragiadakou wrote:
This patch converts Event TRB's 3rd field, which has type le32, to CPU
byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro.
This bug was found using
On Thu, Nov 14, 2013 at 01:13:31PM -0800, Sarah Sharp wrote:
On Thu, Nov 14, 2013 at 11:04:14PM +0200, Xenia Ragiadakou wrote:
On 11/14/2013 10:52 PM, Sarah Sharp wrote:
Hi Xenia,
This patch doesn't apply any more either, could you resend when you have
time?
Thanks,
Sarah Sharp
On Thu, Oct 17, 2013 at 10:42:44AM -0700, Dan Williams wrote:
On Wed, Oct 16, 2013 at 3:58 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
Hi Dan,
I'm attempting to put my queue together for usb-next, and this patch
doesn't apply, due to conflicts in the USB core. Can you rebase
currently
work.
Besides, the patch shouldn't change behavior when you're just trying to
change the code to use a local variable.
Sarah Sharp
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/devio.c | 18 --
1 file changed, 8 insertions(+), 10 deletions
can
choose to indicate it doesn't support streams at all, by setting that
value to zero.
Ideally, we should have something like bus-sg_tablesize that allows the
xHCI host to indicate the number of streams it supports. Perhaps
usb_bus-max_streams?
Sarah Sharp
+
+ eps = kmalloc(num_eps
On Thu, Nov 07, 2013 at 10:32:33AM -0500, Alan Stern wrote:
On Wed, 6 Nov 2013, Julius Werner wrote:
What if the device is in USB_STATE_SUSPENDED?
I'm not sure that is possible at that point in hub_events(), I don't
know of a way that could lead to this situation. I could still add
On Wed, Nov 13, 2013 at 11:11:12AM -0500, Alan Stern wrote:
On Tue, 12 Nov 2013, Sarah Sharp wrote:
No, but that last one can be subdivided into:
- implement hotplug vs hardwired policy
I think the original agreement when the USB 2.0 port power off work
went in was that hotplug vs
patches.
git commit --amend
I'll look over this patch in a couple days. ISTR that someone else
submitted a zero-length packet fix patch, so I need to coordinate the
two.
Sarah Sharp
drivers/usb/host/xhci-ring.c | 390
+++
drivers/usb/host/xhci.h
4 Recommended Deep BESL valid
11:8 Recommended Baseline BESL value
15:12 Recommended Deep BESL value
31:16 Reserved
So fix the bit mask from 0x1e to 0xfffe.
Reported-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off
that the USB mass storage driver is
using scatter gather lists just fine without the driver following the TD
fragment rules. Or at least no one has reported any issues. I wonder
why it works?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
301 - 400 of 1281 matches
Mail list logo
