[PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

2015-10-28 Thread Saurabh Sengar
replace dma_pool_alloc and memset with a single call to dma_pool_zalloc Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/chipidea/udc.c | 3 +-- drivers/usb/gadget/udc/gr_udc.c | 3 +-- drivers/usb/host/uhci-q.c | 3 +-- drivers/usb/host/whci/qset.c

[PATCH] usb: host: ohci-pxa27x: use of_property_read_bool()

2015-11-15 Thread Saurabh Sengar
for checking if a property is present or not, of_property_read_bool is more appropriate then of_get_property() Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH v2] usb: host: ohci-pxa27x: use of_property_read_bool()

2015-11-16 Thread Saurabh Sengar
for checking if a property is present or not, of_property_read_bool is more appropriate than of_get_property() Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v2 : replaced then to than in description drivers/usb/host/ohci-pxa27x.c | 14 +++--- 1 file changed, 7 inse

[PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v2 : removed pval variable v3 : removed unnecessary if condition drivers/usb/chipidea/core.

[PATCH] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/chipidea/core.c | 67 ++--- 1 file chang

[PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v2: removed pval variable drivers/usb/chipidea/core.

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
t; Please check. The code, with the blank line on line 692, looks strange. > > julia > > On Tue, 17 Nov 2015, kbuild test robot wrote: > >> CC: kbuild-...@01.org >> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com> >> TO: Saurabh Sengar

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-11-06 Thread Saurabh Sengar
added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/host/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-qu

Re: [PATCH v3] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
a another patch(v4) as you have suggested. Regards, Saurabh On 18 November 2015 at 09:08, Peter Chen <peter.c...@freescale.com> wrote: > On Tue, Nov 17, 2015 at 05:22:26PM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >>

[PATCH v4] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v4 : removed return type check for optional property 'itc-setting' drivers/usb/chipidea/

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-02 Thread Saurabh Sengar
Hi Greg, I am little unclear. Now, shall I resend my patch on top of usb.git tree or linux.git tree. Regards, Saurabh On 2 December 2015 at 21:15, Greg KH <gre...@linuxfoundation.org> wrote: > On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote: >> On 2 December 2015

[PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-02 Thread Saurabh Sengar
added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v2: changed logic a bit, because of recent patches pushed to usb-next drivers/usb/host/pci-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-04 Thread Saurabh Sengar
added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v3: reverted to v1 logic, on top of usb-next branch drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

Re: [PATCH v2] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-04 Thread Saurabh Sengar
On 4 December 2015 at 21:53, Greg KH <gre...@linuxfoundation.org> wrote: > On Wed, Dec 02, 2015 at 10:51:37PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar <saurabh.tr...@gm

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-01 Thread Saurabh Sengar
On 2 December 2015 at 04:05, Greg KH <gre...@linuxfoundation.org> wrote: > On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar <saurabh.tr...@gma

[RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-12-12 Thread Saurabh Sengar
added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c

Re: [PATCH] usb : replace dma_pool_alloc and memset with dma_pool_zalloc

2015-11-24 Thread Saurabh Sengar
any conclusion for this patch ? any feedback ? On Oct 28, 2015 2:46 PM, "Peter Chen" <peter.c...@freescale.com> wrote: > > On Wed, Oct 28, 2015 at 12:44:35PM +0530, Saurabh Sengar wrote: > > replace dma_pool_alloc and memset with a single call to dma_pool_zalloc &g

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-11-29 Thread Saurabh Sengar
pinging in case this patch is lost. On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.tr...@gmail.com> wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> > --- > drivers/usb/host

Re: [PATCH v4] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
On 18 November 2015 at 12:54, Peter Chen wrote: > I am clear now, I will queue it. Thank you -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v4] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
On 18 November 2015 at 11:35, Peter Chen <peter.c...@freescale.com> wrote: > On Wed, Nov 18, 2015 at 09:40:12AM +0530, Saurabh Sengar wrote: >> call to of_find_property() before of_property_read_u32() is unnecessary. >> of_property_read_u32() anyway calls to of_find_property

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2016-02-11 Thread Saurabh Sengar
Added iounmap inorder to free memory mapped to pointer before returning Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/usb/host/pci-quirks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-qu