Re: [PATCH v2 0/4] usb: chipidea: imx: add HSIC support

2018-10-23 Thread Schrempf Frieder
Hi Peter, On 22.10.18 07:42, Peter Chen wrote: > Most of NXP (Freescale) i.mx USB part has HSIC support, in this series, > we add support for them, it should cover all imx6 and imx7d SoC. > > Changes for v2: > - Compile error reported by kbuild robot [Patch 2/4] > - Comment from Frieder Schrempf

Re: [PATCH v2 2/4] usb: chipidea: imx: add HSIC support

2018-11-05 Thread Schrempf Frieder
On 22.10.18 07:43, Peter Chen wrote: > To support imx HSIC, there are some special requirement: > - The HSIC pad is 1.2v, it may need to supply from external > - The data/strobe pin needs to be pulled down first, and after >host mode is initialized, the strobe pin needs to be pulled up > -

Re: [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation

2018-11-05 Thread Schrempf Frieder
On 22.10.18 07:42, Peter Chen wrote: > NXP (Freecale) imx HSIC design has some special requirements, add > some flags at host code to handle them. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/host.c | 24 > include/linux/usb/chipidea.h | 3 +++ > 2

Re: [PATCH v2 0/4] usb: chipidea: imx: add HSIC support

2018-11-05 Thread Schrempf Frieder
Hi Peter, On 23.10.18 08:33, Peter Chen wrote: > >> As I already posted when I was testing v1 last week, there is a problem with >> auto >> suspend with my LAN9730 chip. I thought it was a problem with the >> smsc95xx/usbnet driver, but I'm not so sure anymore. >> >> So I'd like to figure out

Re: Set reference clock for onboard hub in DT

2018-11-05 Thread Schrempf Frieder
Hi Fabio, On 25.10.18 15:20, Fabio Estevam wrote: > Hi Frieder, > > On Thu, Sep 20, 2018 at 10:52 AM Frieder Schrempf > wrote: >> >> Hi, >> >> I have a question concerning the setup for a board with an onboard USB >> hub. The SoC (i.MX6S) is expected to provide a 12 MHz clock on one of >> the

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Fabio, On 04.12.18 21:01, Fabio Estevam wrote: > Hi Frieder, > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > wrote: > >> There are many other optional properties for this driver and a lot of >> them are not in the given example. Maybe we should just keep th

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-05 Thread Schrempf Frieder
On 05.12.18 08:45, Schrempf Frieder wrote: > Hi Fabio, > > On 04.12.18 21:01, Fabio Estevam wrote: >> Hi Frieder, >> >> On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder >> wrote: >> >>> There are many other optional properties for this driver an

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Peter, hi Fabio, On 30.11.18 03:33, PETER CHEN wrote: > >> >> On Tue, Nov 27, 2018 at 7:31 AM PETER CHEN wrote: >>> >>> For USB HSIC, the data and strobe pin needs to be pulled down at >>> default, we consider it as "idle" state. When the USB host is ready to >>> be used, the strobe pin

Re: [PATCH v2 0/4] usb: chipidea: imx: add HSIC support

2018-11-19 Thread Schrempf Frieder
Hi Peter, On 05.11.18 09:52, Frieder Schrempf wrote: > Hi Peter, > > On 23.10.18 08:33, Peter Chen wrote: >>> As I already posted when I was testing v1 last week, there is a >>> problem with auto >>> suspend with my LAN9730 chip. I thought it was a problem with the >>> smsc95xx/usbnet driver,

Re: [PATCH v3 2/4] usb: chipidea: imx: add HSIC support

2018-11-27 Thread Schrempf Frieder
On 27.11.18 10:30, PETER CHEN wrote: > To support imx HSIC, there are some special requirement: > - The HSIC pad is 1.2v, it may need to supply from external > - The data/strobe pin needs to be pulled down first, and after >host mode is initialized, the strobe pin needs to be pulled up > -

Re: [PATCH v3 1/4] usb: chipidea: add flag for imx hsic implementation

2018-11-27 Thread Schrempf Frieder
On 27.11.18 10:30, PETER CHEN wrote: > NXP (Freecale) imx HSIC design has some special requirements, add > some flags at host code to handle them. > > Signed-off-by: Peter Chen Tested on i.MX6S with Microchip LAN9730 USB HSIC Ethernet Controller. Reviewed-by: Frieder Schrempf Tested-by:

Re: [PATCH v3 3/4] usb: chipidea: host: override ehci->hub_control

2018-11-27 Thread Schrempf Frieder
On 27.11.18 10:30, PETER CHEN wrote: > The chipidea controller has some special requirements during > suspend/resume, override common ehci->hub_control to implement > it. > > Signed-off-by: Peter Chen Tested on i.MX6S with Microchip LAN9730 USB HSIC Ethernet Controller. I have some minor format