Re: Bug: Toggling green led on Olinuxino Maxi, also toggles USB

Hi Fabio, Fabio Estevam feste...@gmail.com hat am 14. April 2015 um 16:15 geschrieben: Hi Stefan, On Tue, Apr 14, 2015 at 5:43 AM, Peter Chen peter.c...@freescale.com wrote: So setting dr_mode to host is the one and only solution for this case? From my point, yes. I also agree this

Re: Bug: Toggling green led on Olinuxino Maxi, also toggles USB

Hi Peter, Peter Chen peter.c...@freescale.com hat am 13. April 2015 um 09:00 geschrieben: On Sun, Apr 12, 2015 at 12:06:10PM +0200, Stefan Wahren wrote: [...] I think the problem has something to with USB OTG, because GPIO 65 is on the same pin for USB_OTG_ID. My idea was to set

Bug: Toggling green led on Olinuxino Maxi, also toggles USB

Hi, toggling the green LED (GPIO 65) on Olinuxino Maxi unexpectedly also toggles the USB Host support. Here is the console output: # Switching the led off (USB drive connected) echo 255 /sys/class/leds/green/brightness [ 318.65] ci_hdrc ci_hdrc.0: timeout waiting for 0800 in 11 [

usb: phy: phy-mxs-usb: suspend to RAM causes NULL pointer dereference

on suspend to RAM This patch avoids the oops in mxs_phy_get_vbus_status() by aborting since there is no syscon available. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com Fixes: efdbd3a5d6e (usb: phy: mxs: do not set PWD.RXPWD1PT1 for low speed connection) CC: sta...@vger.kernel.org # 4.0 --- drivers

[PATCH] phy: phy-mxs-usb: suspend to RAM causes NULL pointer dereference

Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer dereference. This patch avoids the oops in mxs_phy_get_vbus_status() by aborting since there is no syscon available. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com Fixes: efdbd3a5d6e (usb: phy: mxs: do not set

Re: [PATCH] phy: phy-mxs-usb: suspend to RAM causes NULL pointer dereference

Am 30.06.2015 um 08:10 schrieb Felipe Balbi: On Tue, Jun 30, 2015 at 07:30:35AM +0200, Stefan Wahren wrote: Am 15.06.2015 um 06:37 schrieb Stefan Wahren: Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer dereference. This patch avoids the oops in mxs_phy_get_vbus_status

Re: [PATCH] phy: phy-mxs-usb: suspend to RAM causes NULL pointer dereference

Am 15.06.2015 um 06:37 schrieb Stefan Wahren: Triggering suspend to RAM via sysfs on a i.MX28 causes a NULL pointer dereference. This patch avoids the oops in mxs_phy_get_vbus_status() by aborting since there is no syscon available. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com Fixes

Re: usb: dwc2: regression during boot on Raspberry Pi

Hi Stephen, Am 08.11.2015 um 06:06 schrieb Stephen Warren: On 11/07/2015 05:16 PM, Stefan Wahren wrote: Hi, [...] * phys (optional) * phy-names (optional) So here are my questions: How to fix the kernel oops in dwc2 driver? Do you know exactly what causes the crash; you've bisected

Re: usb: dwc2: regression during boot on Raspberry Pi

Hi, Am 09.11.2015 um 12:53 schrieb Marek Szyprowski: Hello, This change looks reasonable, I remember the similar issue was in s3c-hsotg driver and it caused kernel ops on driver probe, when bootloader left dwc2 enabled. The other way of solving it would be to add irq_set_status_flags(irq,

[PATCH 0/4 V2] usb: dwc2: fix usb host support on Raspberry Pi

without PHY support - take care of Sergei Shtylyov comments - add patch to make otg clk optional again John Youn (1): usb: dwc2: Make PHY optional Stefan Wahren (3): usb: dwc2: fix kernel oops during driver probe usb: dwc2: Return errors from PHY usb: dwc2: make otg clk optional drivers

[PATCH 1/4 V2] usb: dwc2: fix kernel oops during driver probe

: cb4d task.ti: cb4d PC is at dwc2_is_controller_alive+0x18/0x34 LR is at dwc2_handle_common_intr+0x24/0xb60 Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/platform.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-)

[PATCH 3/4 V2] usb: dwc2: Return errors from PHY

<alex.ar...@gmail.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/platform.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/drivers/usb

Re: usb: dwc2: regression during boot on Raspberry Pi

Am 12.11.2015 um 05:39 schrieb John Youn: On 11/11/2015 3:20 PM, Stefan Wahren wrote: Hi John, Am 11.11.2015 um 00:21 schrieb John Youn: On 11/9/2015 12:43 PM, Stefan Wahren wrote: Hi, The gadget side required it but it looks like the host side didn't. When Marek did the low-level hw

[PATCH 2/4 V2 RESEND] usb: dwc2: Make PHY optional

PHY is specified. This requirement never existed on the host side and broke some platforms when it was moved into platform.c. The gadget doesn't require the PHY either so remove the check. Reported-by: Stefan Wahren <i...@lategoodbye.de> Cc: Marek Szyprowski <m.szyprow...@samsung.com> Sig

Re: [PATCH 2/4 V2] usb: dwc2: Make PHY optional

Am 13.11.2015 um 13:25 schrieb Sergei Shtylyov: > Hello. > > On 11/13/2015 12:08 AM, Stefan Wahren wrote: > >> From: John Youn <john.y...@synopsys.com> >> >> Fixes commit 09a75e857790 >> ("usb: dwc2: refactor common low-level hw code to platform.

[PATCH 3/4 V2 RESEND] usb: dwc2: Return errors from PHY

<alex.ar...@gmail.com> Signed-off-by: John Youn <johny...@synopsys.com> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> --- drivers/usb/dwc2/platform.c | 37 - 1 file chan

[PATCH 1/4 V2 RESEND] usb: dwc2: fix kernel oops during driver probe

: cb4d task.ti: cb4d PC is at dwc2_is_controller_alive+0x18/0x34 LR is at dwc2_handle_common_intr+0x24/0xb60 Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Acked-by: John Youn <johny...@synopsys.com> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> ---

[PATCH 0/4 V2 RESEND] usb: dwc2: fix usb host support on Raspberry Pi

without PHY support - take care of Sergei Shtylyov comments - add patch to make otg clk optional again John Youn (1): usb: dwc2: Make PHY optional Stefan Wahren (3): usb: dwc2: fix kernel oops during driver probe usb: dwc2: Return errors from PHY usb: dwc2: make otg clk optional drivers

[PATCH 4/4 V2 RESEND] usb: dwc2: make otg clk optional

k handling optional again. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Cc: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: John Youn <johny...@synopsys.com> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> Fixes: 09a75e857790 ("usb: dwc2: refactor

Re: usb: dwc2: regression during boot on Raspberry Pi

Am 11.11.2015 um 22:58 schrieb John Youn: On 11/8/2015 2:13 AM, Stefan Wahren wrote: --->8 diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 5859b0f..0e80087 100644 --- a/drivers/usb/dwc2/platfor

Re: usb: dwc2: regression during boot on Raspberry Pi

Hi John, Am 11.11.2015 um 00:21 schrieb John Youn: On 11/9/2015 12:43 PM, Stefan Wahren wrote: Hi, The gadget side required it but it looks like the host side didn't. When Marek did the low-level hw refactor, some of the gadget stuff was brought up to the common layer, including

usb: dwc2: regression during boot on Raspberry Pi

Hi, i try to run linux-next-20151106 (U-Boot + USB patches from Stephen Warren) on my Raspberry Pi B rev2 and get a kernel oops (see bootlog at the end). I bisect the issue to this commit: 09a75e8577901489f77a14a3b305a9a1f67bf25b ("usb: dwc2: refactor common low-level hw code to

[PATCH 1/2] usb: chipidea: add CI_HDRC_TURN_VBUS_EARLY_ON for imx23

Until now the imx23 uses the imx27 platform flag. But the imx23 needs the flag CI_HDRC_TURN_VBUS_EARLY_ON, too. So fix this by adding a separate platform flag. Suggested-by: Peter Chen <peter.c...@nxp.com> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/

[PATCH 2/2] dt-bindings: ci-hdrc-usb2: add missing compatibles

This patch adds the missing compatible strings from ci_hdrc_imx. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/usb/ci-hdrc-usb2.txt |7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.

Re: usb: dwc2: regression on bcm2835 after commit 09c96980dc72

Hi Remi, > Remi Pommarel hat am 2. Januar 2016 um 14:55 geschrieben: > > > Hi Stefan, Hi John, > > On Mon, Dec 28, 2015 at 3:16:47AM -0800, Stefan Wharen wrote: ... > > I came up with the same patch, but it does not seem to fix everything. Indeed >

Re: usb: dwc2: regression on bcm2835 after commit 09c96980dc72

Am 05.01.2016 um 21:39 schrieb John Youn: > > Ok, I'll get these fixes in. > > I'm not totally sure what the problem is. I'll see if I can get a > raspberry pi to test it out. So you don't need a proper patch series according to these regressions from me? > > Regards, > John -- To unsubscribe

Re: MX28 with hub cannot reset

Hi, > Peter Chen <hzpeterc...@gmail.com> hat am 25. Dezember 2015 um 07:22 > geschrieben: > > > On Thu, Dec 24, 2015 at 09:42:58AM +0100, Stefan Wahren wrote: > > Hi, > > > > > Peter Chen <hzpeterc...@gmail.com> hat am 23. Dezember 2015 um 10:49 >

usb: dwc2: regression on bcm2835 after commit 09c96980dc72

Hi John, the commit 09c96980dc72 ("usb: dwc2: Add functions to set and clear force mode") in Felipe's USB repo causes a regression on Raspberry Pi B which prevents the probing of the dwc2 driver. I attached a patch which fixes the regression but i'm not sure that's the right way. Regards Stefan

usb: wrong compatible string for MX23?

Hi Peter, i was inspired by the discussion about the USB runtime suspend issue on MX28. I think i've found another issue. In the dtsi for the MX23 the usb node has the following compatible: usb0: usb@8008 { compatible = "fsl,imx23-usb", "fsl,imx27-usb"; ... But in ci_hdrc_imx.c

Re: MX28 with hub cannot reset

Hi, > Peter Chen hat am 23. Dezember 2015 um 10:49 > geschrieben: > > > On Wed, Dec 23, 2015 at 6:54 AM, Fabio Estevam wrote: > > Hi, > > > > On a mx28 custom board with a USB hub I can get a USB stick to get > > detected after applying this change: >

Re: [PATCH] usb: phy: mxs: Remove unused flags

SENDING_SOF_TOO_FAST flags > > are never used, so let's get rid of them. > > > > Reported-by: Stefan Wahren <stefan.wah...@i2se.com> > > Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> > > --- > ... > > I prefer to keep it, and it let us know th

Re: MX28 with hub cannot reset

Hi Fabio, > Fabio Estevam hat am 22. Dezember 2015 um 23:54 > geschrieben: > > > Hi, > > On a mx28 custom board with a USB hub I can get a USB stick to get > detected after applying this change: > http://marc.info/?l=linux-usb=145079935324339=2 > > Things work fine if I boot

Re: [PATCH RESEND 1/2] usb: dwc2: Make PHY optional

Hi Felipe, Am 19.11.2015 um 20:54 schrieb Felipe Balbi: Hi John, John Youn writes: Fixes commit 09a75e85 "usb: dwc2: refactor common low-level hw code to platform.c" these two lines should be placed ... The above commit consolidated the low-level phy access into

Re: [PATCH RESEND 1/2] usb: dwc2: Make PHY optional

Hi Felipe, Am 20.11.2015 um 16:27 schrieb Felipe Balbi: Hi, Stefan Wahren <i...@lategoodbye.de> writes: Hi Felipe, Am 19.11.2015 um 20:54 schrieb Felipe Balbi: Hi John, John Youn <john.y...@synopsys.com> writes: Fixes commit 09a75e85 "usb: dwc2: refactor common

Re: [PATCH RESEND 1/2] usb: dwc2: Make PHY optional

Hi, Am 20.11.2015 um 18:18 schrieb Felipe Balbi: Hi, Stefan Wahren <i...@lategoodbye.de> writes: Hi Felipe, Am 20.11.2015 um 16:27 schrieb Felipe Balbi: Hi, Stefan Wahren <i...@lategoodbye.de> writes: Hi Felipe, Am 19.11.2015 um 20:54 schrieb Felipe Balbi: Hi John, John

[PATCH RFC 0/4] Improvements to Chipidea UDC

This patch series aim to improve the ChipIdea UDC driver in regards to readability and runtime behavior. Stefan Wahren (4): usb: chipidea: udc: move write barrier into hw_ep_prime usb: chipidea: udc: Don't flush endpoint fifo twice usb: chipidea: udc: Avoid busy wait in reset ISR usb

[PATCH RFC 4/4] usb: chipidea: udc: Use direction flags consequently

This driver make assumptions about the value of the direction flags. So better use them in comparisons to improve the readability. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH RFC 2/4] usb: chipidea: udc: Don't flush endpoint fifo twice

The endpoint fifo is already flushed in _ep_nuke so there is no need to flush it twice. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 8

[PATCH RFC 1/4] usb: chipidea: udc: move write barrier into hw_ep_prime

Since there should be a write barrier before every call of hw_ep_prime we could move it into hw_ep_prime. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH RFC 3/4] usb: chipidea: udc: Avoid busy wait in reset ISR

Since there is no dependency from this busy wait in the reset ISR we could remove it. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Hi Doug, Am 27.01.2016 um 21:43 schrieb Doug Anderson: > Stefan, > > On Wed, Jan 27, 2016 at 12:36 PM, Stefan Wahren <stefan.wah...@i2se.com> > wrote: >> i can only give you feedback from a user perspective. My keyboard and C-Media >> USB Audio still works as expec

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

sertions(+), 672 deletions(-) > thanks for providing this series. I have tested successfully it on my Raspberry Pi B. So you can have my Tested-by: Stefan Wahren <stefan.wah...@i2se.com> for all non platform specific patches. Regards Stefan -- To unsubscribe from this list: send the

Re: usb: dwc2: Disconnecting hub from rpi leads to errors

Hi, > Doug Anderson <diand...@chromium.org> hat am 27. Januar 2016 um 20:34 > geschrieben: > > > Stefan, > > On Sat, Jan 23, 2016 at 9:08 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Hi, > > > >> Stefan Wahren <stefan.wah...@i

Re: [PATCH v5 0/21] usb: dwc2: host: Fix and speed up all the stuff, especially with splits

Hi Doug, > Doug Anderson <diand...@chromium.org> hat am 27. Januar 2016 um 19:24 > geschrieben: > > > Stefan, > > On Wed, Jan 27, 2016 at 9:33 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Hi Doug, > > > >> Douglas Anderson (21)

Re: Bug in split transactions on Raspberry Pi

ns, and the result doesn't boot. No easy > > way to figure out why -- nothing shows up on the HDMI screen but the > > color splash. > > Interestingly enough Stefan Wahren reached out to me after my recent > patch series indicating that my series didn't fix some other problem &

Re: usb: dwc2: Disconnecting hub from rpi leads to errors

Hi, > Stefan Wahren <stefan.wah...@i2se.com> hat am 17. Januar 2016 um 04:36 > geschrieben: > > > Hi, > > i have a Cherry G83 USB Keyboard connected to external 4 Port USB hub and this > is connected to a Raspberry Pi B (Linux 4.4-rc7). > > If i disconnect

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

> Doug Anderson <diand...@chromium.org> hat am 7. März 2016 um 22:30 > geschrieben: > > > Stefan, > > On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Hi Doug, > > > >> Douglas Anderson <diand...@ch

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi, > Eric Anholt <e...@anholt.net> hat am 19. März 2016 um 03:17 geschrieben: > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > > Hi Eric, > > hi Martin, > > > >> John Youn <john.y...@synopsys.com> hat am 16. März 2016 um 19:28

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi, > Martin Sperl <ker...@martin.sperl.org> hat am 19. März 2016 um 08:44 > geschrieben: > > > > > On 19.03.2016, at 03:17, Eric Anholt <e...@anholt.net> wrote: > > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > > >> Hi

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi Eric, hi Martin, > John Youn <john.y...@synopsys.com> hat am 16. März 2016 um 19:28 geschrieben: > > > On 3/10/2016 11:14 AM, John Youn wrote: > > On 3/9/2016 11:06 AM, Doug Anderson wrote: > >> Stefan, > >> > >> On Wed, Mar 9, 2016

Re: [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems

Hi John, Am 29.03.2016 um 04:36 schrieb John Youn: > Hi, > > The following patch series addresses the core reset and force mode > delay problems we have been seeing on dwc2 for some platforms. > > I think I have identified the source of the inconsistencies between > platforms and this series

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi, > Martin Sperl <ker...@martin.sperl.org> hat am 19. März 2016 um 11:10 > geschrieben: > > > > On 19.03.2016, at 10:52, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > > > Hi, > > > >> Martin Sperl <ker...@mart

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi Doug, > Doug Anderson <diand...@chromium.org> hat am 7. März 2016 um 22:30 > geschrieben: > > > Stefan, > > On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > > Hi Doug, > > > >> Douglas Anderso

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

Hi Doug, > Douglas Anderson hat am 4. März 2016 um 19:23 > geschrieben: > > > This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on > bcm2835") now that we've found the root cause. See the change > titled ("usb: dwc2: Add a 10 ms delay to dwc2_core_reset()").

Re: [PATCHv3] usb: dwc2: Add reset control to dwc2

Hi Dinh, > From: Dinh Nguyen > > Allow for platforms that have a reset controller driver in place to bring the > USB IP out of reset. > > Signed-off-by: Dinh Nguyen > diff --git a/drivers/usb/dwc2/platform.c

Re: [PATCHv7] usb: dwc2: Add reset control to dwc2

hout reset controller) Tested-by: Stefan Wahren <stefan.wah...@i2se.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH V2 RFC 3/6] ARM: dts: bcm283x: Add missing usb clock

According to the DWC2 binding an appropriate clock is required. This clock isn't handled by bcm2835 clock driver, so add a fixed clock to the bcm283x DT. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- arch/arm/boot/dts/bcm283x.dtsi |9 + 1 file changed, 9 inse

[PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

. dwc2 2098.usb: Setting host_perio_tx_fifo_size to 0 Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index 4135a5f..5

[PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

The Raspberry Pi Zero is a minified version of model A+. It's notable there is no PWR LED and the ACT LED is inverted. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- arch/arm/boot/dts/Makefile |3 +- arch/arm/boot/dts/bcm2835-rpi-zero.dts

[PATCH V2 RFC 2/6] usb: dwc2: Add DT properties to specify fifo size in host/otg mode

specific fifo sizes in order to define them in the devicetree and avoid these errors. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- Documentation/devicetree/bindings/usb/dwc2.txt |3 +++ drivers/usb/dwc2/core.c| 25 ++-- 2 files c

[PATCH V2 RFC 0/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

V1: - rebase to current linux-next - add patches 1 - 4 for otg/gadget support - add patch 5 with model compatible - use polarity define for ACT LED [1] - http://lists.infradead.org/pipermail/linux-rpi-kernel/2016-February/003221.html [2] - https://github.com/raspberrypi/linux/pull/1239/ Stefan

[PATCH V2 RFC 5/6] DT: bindings: bcm: Add Raspberry Pi Zero

Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/arm/bcm/brcm,bcm2835.txt |4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt

[PATCH V2 RFC 4/6] ARM: dts: bcm283x: Add generic USB PHY

In order to use DWC2 in otg or gadget mode the USB PHY must be specified. Since there is no bcm283x USB PHY driver use the generic one. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- arch/arm/boot/dts/bcm283x.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/ar

[PATCH V3] usb: chipidea: udc: Use direction flags consequently

This driver make assumptions about the value of the direction flags. So better use them in comparisons to improve the readability. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 del

[PATCH V2] usb: chipidea: udc: Use direction flags consequently

This driver make assumptions about the value of the direction flags. So better use them in comparisons to improve the readability. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c | 18 +- 1 file changed, 9 insertions(+), 9 del

Re: [PATCH V2] usb: chipidea: udc: Use direction flags consequently

I have already queued it at local tree for testing, and make the similar changes: commit c95b4427b7328b2618ca70fea65de0427f5d5734 Author: Stefan Wahren <stefan.wah...@i2se.com> Date: Sat Jul 9 14:16:40 2016 + usb: chipidea: udc: Use direction flags consequently This

[PATCH 1/3] usb: chipidea: udc: move write barrier into hw_ep_prime

Since there should be a write barrier before every call of hw_ep_prime we could move it into hw_ep_prime. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea

Re: [PATCH RFC 3/4] usb: chipidea: udc: Avoid busy wait in reset ISR

Hi Peter, > Peter Chen <hzpeterc...@gmail.com> hat am 30. Juni 2016 um 11:30 geschrieben: > > > On Sat, Jun 25, 2016 at 08:38:58AM +0000, Stefan Wahren wrote: > > Since there is no dependency from this busy wait in the reset ISR > > we could remove it. > &g

[PATCH 0/3] usb: chipidea: Improvements to UDC

This patch series aim to improve the ChipIdea UDC driver in regards to readability and runtime behavior. Changes since RFC: - drop patch usb: chipidea: udc: Avoid busy wait in reset ISR Stefan Wahren (3): usb: chipidea: udc: move write barrier into hw_ep_prime usb: chipidea: udc: Don't flush

[PATCH 2/3] usb: chipidea: udc: Don't flush endpoint fifo twice

The endpoint fifo is already flushed in _ep_nuke so there is no need to flush it twice. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 8

[PATCH 3/3] usb: chipidea: udc: Use direction flags consequently

This driver make assumptions about the value of the direction flags. So better use them in comparisons to improve the readability. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/chipidea/udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi Stephen, > Stephen Warren <swar...@wwwdotorg.org> hat am 2. August 2016 um 19:19 > geschrieben: > > > On 07/26/2016 12:53 PM, Stefan Wahren wrote: > > The Raspberry Pi Zero is a minified version of model A+. It's > > notable there is no PWR LED and the ACT

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

Hi John, > John Youn <john.y...@synopsys.com> hat am 16. August 2016 um 21:20 > geschrieben: > > > On 8/16/2016 9:44 AM, Stefan Wahren wrote: > > Hi John, > > > >> John Youn <john.y...@synopsys.com> hat am 16. August 2016 um 03:30 > ... > &

Re: [PATCH v3 24/24] usb: dwc2: gadget: Add checking for g-tx-fifo-size parameter

Hi John, could you please push this series to the github synopsys-usb repo? I didn't have the chance to test combination of your last series. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: USB/swiotlb failure on arm64/RPi3

[Add John and linux-usb] Am 24.01.2017 um 23:52 schrieb Aaro Koskinen: > Hi, > > Booting Debian rootfs from USB hard disk (ext4) using 64-bit 4.9 kernel > on Raspberry Pi 3 fails early in the boot as follows: > > [ 15.162466] systemd[1]: Detected architecture arm64. > > Welcome to Debian

Re: [PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

Hi John, is there a public git repo where this series is already applied? Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi John, > John Youn <john.y...@synopsys.com> hat am 18. August 2016 um 20:03 > geschrieben: > > > On 8/17/2016 3:17 PM, Stefan Wahren wrote: > > Hi John, > > > >> John Youn <john.y...@synopsys.com> hat am 17. August 2016 um 23:21 > >>

Re: [PATCH V2 RFC 0/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi Eric, > Eric Anholt <e...@anholt.net> hat am 18. August 2016 um 20:14 geschrieben: > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > > This patch series is only a draft and not intended to be merged. Patches 1 > > and 2 > > aren't bcm

Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode

Hi John, > John Youn <john.y...@synopsys.com> hat am 16. August 2016 um 03:30 > geschrieben: > > > On 7/26/2016 11:54 AM, Stefan Wahren wrote: > > In gadget mode On bcm2835 platform the host tx fifo size could be zero. > > So add zero to range and avoid su

[Bug] usb: dwc2: host function broken in OTG mode on bcm283x

Hi John, on bcm2835 in OTG mode the USB host function broken (USB devices don't enumerate) with the following settings: CONFIG_USB=y CONFIG_USB_OTG=y CONFIG_USB_DWC2=y CONFIG_USB_DWC2_DUAL_ROLE=y CONFIG_USB_PHY=y CONFIG_NOP_USB_XCEIV=y CONFIG_USB_GADGET=y CONFIG_USB_ZERO=y and DT don't provide

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi John, > John Youn hat am 17. August 2016 um 23:21 > geschrieben: > > > ... > Ok, yeah, that seems better. > > Can you check if applying just patch 2 and 3 solves the issue? If so I > think we can send those upstream. unfortunately not: [2.280719]

Re: [PATCH V2 RFC 6/6] ARM: dts: bcm2835: Add Raspberry Pi Zero

Hi, > John Youn <john.y...@synopsys.com> hat am 17. August 2016 um 00:07 > geschrieben: > > > On 8/16/2016 12:58 PM, Stefan Wahren wrote: > > Hi John, > > ... > > > > like in host mode i took the default values in otg mode for the last two > &g

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Baruch, Am 28.02.2017 um 13:01 schrieb Baruch Siach: Hi linux-usb list, (Dropped Jan's bouncing address, added Rpi3 platform lists) On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: Hi linux-usb list, I'm hitting this warning consistently on my Raspberry Pi 3 running kernel

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Baruch, > Baruch Siach <bar...@tkos.co.il> hat am 28. Februar 2017 um 19:07 geschrieben: > > > Hi Stefan, > > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > > > On Tue, Feb 28, 2017

Re: usb: chipidea: hdc: kernel panic during shutdown

Hi Alan, > Alan Stern <st...@rowland.harvard.edu> hat am 24. August 2016 um 20:55 > geschrieben: > > > On Wed, 24 Aug 2016, Stefan Wahren wrote: > > > Hi, > > > > [add Li Jun to CC] > > > > > Alan Stern <st...@rowland.ha

Re: usb: chipidea: hdc: kernel panic during shutdown

Am 25.08.2016 um 08:44 schrieb Peter Chen: > On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: >> Hi Alan, >> >> i tried the following patch: >> --- a/drivers/usb/chipidea/host.c >> +++ b/drivers/usb/chipidea/host.c >> @@ -185,6 +185,8 @@ s

Re: usb: chipidea: hdc: kernel panic during shutdown

Hi Peter, > Stefan Wahren <stefan.wah...@i2se.com> hat am 25. August 2016 um 19:17 > geschrieben: > > > Hi, > > > Peter Chen <hzpeterc...@gmail.com> hat am 25. August 2016 um 11:16 > > geschrieben: > > > > > > On Thu, Aug 25, 2016 a

Re: [RFT PATCH v4 0/3] usb: dwc2: Fix core reset and force mode delays

I have doubled > this. > > Appreciate any testing on RK3188 and RPi platforms. i tested the whole series successful with a Raspberry Pi B in dr_mode "host" and "otg" Tested-by: Stefan Wahren <stefan.wah...@i2se.com> -- To unsubscribe from this list: send the line "

Re: usb: chipidea: hdc: kernel panic during shutdown

Am 05.09.2016 um 04:51 schrieb Peter Chen: > On Fri, Sep 02, 2016 at 08:20:35PM +0200, Stefan Wahren wrote: >> Hi Peter, >> >>> Stefan Wahren <stefan.wah...@i2se.com> hat am 25. August 2016 um 19:17 >>> geschrieben: >>> >>> >>> Hi,

[PATCH] usb: chipidea: host: fix NULL ptr dereference during shutdown

LE_END and we finish interrupt handling before the hcd is deallocated. This avoids the NULL pointer dereference. Suggested-by: Alan Stern <st...@rowland.harvard.edu> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: b09b5224fe86 ("usb: chipidea: implement platform shutdown

Re: usb: chipidea: hdc: kernel panic during shutdown

Hi, > Peter Chen <hzpeterc...@gmail.com> hat am 25. August 2016 um 11:16 > geschrieben: > > > On Thu, Aug 25, 2016 at 08:27:03AM +0200, Stefan Wahren wrote: > > Am 25.08.2016 um 08:44 schrieb Peter Chen: > > > On Thu, Aug 25, 2016 at 07:06:12AM +0200,

usb: chipidea: hdc: kernel panic during shutdown

Hi, i'm using a iMX233-OLinuXino board and the kernel panics during shutdown with 4.8.0-rc2-next-20160819: [ 420.04] ci_hdrc ci_hdrc.0: remove, state 1 [ 420.05] usb usb1: USB disconnect, device number 1 [ 420.06] usb 1-1: USB disconnect, device number 2 [ 420.06] usb 1-1.1:

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

Hi John, > John Youn <john.y...@synopsys.com> hat am 23. August 2016 um 00:08 > geschrieben: > > > On 8/22/2016 1:47 PM, Stefan Wahren wrote: > > Hi John, > > > >> John Youn <john.y...@synopsys.com> hat am 22. August 2016 um 22:06 > >>

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

Hi John, > John Youn hat am 23. August 2016 um 20:37 > geschrieben: > > > > How about we fall back to smaller defaults if the original values > fail? And don't configure more than the amount of endpoints. this sounds good. I would prefer to calculate the estimated

Re: [Bug] usb: dwc2: host function broken in OTG mode on bcm283x

Hi John, > John Youn <john.y...@synopsys.com> hat am 22. August 2016 um 22:06 > geschrieben: > > > On 8/20/2016 6:03 AM, Stefan Wahren wrote: > > Hi John, > > > > > > Hi Stefan, > > Why doesn't DT work? I think all the properties are

Re: usb: chipidea: hdc: kernel panic during shutdown

Hi, [add Li Jun to CC] > Alan Stern <st...@rowland.harvard.edu> hat am 24. August 2016 um 15:45 > geschrieben: > > > On Wed, 24 Aug 2016, Peter Chen wrote: > > > On Tue, Aug 23, 2016 at 09:17:02PM +0200, Stefan Wahren wrote: > > > Hi, > >

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

Hi Felipe, Am 22.11.2016 um 13:23 schrieb Felipe Balbi: > Hi, > > Stefan Wahren <stefan.wah...@i2se.com> writes: >> Since there is no parameter @value replace it with @legacy. >> >> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")

Re: [PATCH v2 2/3] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"

Hi John, > John Youn hat am 18. Oktober 2016 um 02:36 > geschrieben: > > > This reverts commit aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size > and address initialization"). > > The original commit removed the FIFO size programming per endpoint. The > DPTXFSIZn

Re: [PATCH 1/4] usb: dwc2: Fix AHB burst type for bcm2835

Hi John, > John Youn hat am 16. November 2016 um 01:36 > geschrieben: > > > The ahbcfg param for bcm2835 is specifying a HBSTLEN of 0x8 (0x10 >> 1) > which is not a valid value for that field. Remove the param and default > to using INCR4. i don't have any Synopsys

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

Hi John, Am 17.11.2016 um 00:47 schrieb John Youn: > Add the "snps,ahb-burst" binding and read it in. > > This property controls which burst type to perform on the AHB bus as a > master in internal DMA mode. This overrides the legacy param value, > which we need to keep around for now since

  1   2   >